[GitHub] zhongjiajie commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode

2019-01-17 Thread GitBox
zhongjiajie commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode URL: https://github.com/apache/airflow/pull/4535#discussion_r248946469 ## File path: tests/contrib/hooks/test_ftp_hook.py ## @@ -125,5 +127,50 @@ def

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-17 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455439058 Hey @Fokko - I pushed all the changes. Please let me know if you have more concerns about caching and

[GitHub] codecov-io edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-17 Thread GitBox
codecov-io edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-454963037 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4543?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4550: [Airflow 3714] Correct DAG name in docs/start.rst

2019-01-17 Thread GitBox
codecov-io edited a comment on issue #4550: [Airflow 3714] Correct DAG name in docs/start.rst URL: https://github.com/apache/airflow/pull/4550#issuecomment-455434092 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4550?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4550: [Airflow 3714] Correct DAG name in docs/start.rst

2019-01-17 Thread GitBox
codecov-io edited a comment on issue #4550: [Airflow 3714] Correct DAG name in docs/start.rst URL: https://github.com/apache/airflow/pull/4550#issuecomment-455434092 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4550?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4550: [Airflow 3714] Correct DAG name in docs/start.rst

2019-01-17 Thread GitBox
codecov-io edited a comment on issue #4550: [Airflow 3714] Correct DAG name in docs/start.rst URL: https://github.com/apache/airflow/pull/4550#issuecomment-455434092 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4550?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4550: [Airflow 3714] Correct DAG name in docs/start.rst

2019-01-17 Thread GitBox
codecov-io edited a comment on issue #4550: [Airflow 3714] Correct DAG name in docs/start.rst URL: https://github.com/apache/airflow/pull/4550#issuecomment-455434092 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4550?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4550: [Airflow 3714] Correct DAG name in docs/start.rst

2019-01-17 Thread GitBox
codecov-io commented on issue #4550: [Airflow 3714] Correct DAG name in docs/start.rst URL: https://github.com/apache/airflow/pull/4550#issuecomment-455434092 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4550?src=pr=h1) Report > Merging

[GitHub] reubenvanammers commented on a change in pull request #4156: [AIRFLOW-3314] Changed auto inlets feature to work as described

2019-01-17 Thread GitBox
reubenvanammers commented on a change in pull request #4156: [AIRFLOW-3314] Changed auto inlets feature to work as described URL: https://github.com/apache/airflow/pull/4156#discussion_r248929437 ## File path: airflow/lineage/__init__.py ## @@ -110,26 +114,31 @@ def

[GitHub] zhongjiajie opened a new pull request #4550: [Airflow 3714] Correct DAG name in docs/start.rst

2019-01-17 Thread GitBox
zhongjiajie opened a new pull request #4550: [Airflow 3714] Correct DAG name in docs/start.rst URL: https://github.com/apache/airflow/pull/4550 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Resolved] (AIRFLOW-2843) ExternalTaskSensor: Add option to cease waiting immediately if the external DAG/task doesn't exist

2019-01-17 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG resolved AIRFLOW-2843. Resolution: Resolved > ExternalTaskSensor: Add option to cease waiting immediately if

[jira] [Assigned] (AIRFLOW-3714) Quickstart references outdated DAG

2019-01-17 Thread zhongjiajie (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhongjiajie reassigned AIRFLOW-3714: Assignee: zhongjiajie > Quickstart references outdated DAG >

[jira] [Created] (AIRFLOW-3727) Fix a wrong reference to timezone method

2019-01-17 Thread Kengo Seki (JIRA)
Kengo Seki created AIRFLOW-3727: --- Summary: Fix a wrong reference to timezone method Key: AIRFLOW-3727 URL: https://issues.apache.org/jira/browse/AIRFLOW-3727 Project: Apache Airflow Issue

[GitHub] dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-01-17 Thread GitBox
dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-455389403 @r39132 your crash is specific to MacOS. Apple makes modifications to the vanilla install, resulting in this specific bug you're

[GitHub] dargueta commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-01-17 Thread GitBox
dargueta commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-455389403 @r39132 your crash is specific to MacOS. Apple makes modifications to the vanilla install, resulting in this specific bug you're encountering;

[GitHub] mik-laj commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection

2019-01-17 Thread GitBox
mik-laj commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-455387553 I do not think that it is worth writing a list of operators and hooks. just mention the default conn_id is enough

[GitHub] mik-laj edited a comment on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection

2019-01-17 Thread GitBox
mik-laj edited a comment on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-455385856 This is already described when my PR is accepted.I personally think that this is not enough. Unfortunately people are lazy

[GitHub] mik-laj edited a comment on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection

2019-01-17 Thread GitBox
mik-laj edited a comment on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-455385856 This is already described when my PR is accepted.I personally think that this is not enough. People is unfortunately lazy

[GitHub] mik-laj commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection

2019-01-17 Thread GitBox
mik-laj commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-455385856 This is already described when my PR is accepted. This is an

[GitHub] dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-01-17 Thread GitBox
dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-455369056 I also can't reproduce the crash. `apache-airflow`: 1.10.1 `tenacity`: I tried 4.11 _and_ 4.12. Python: 3.7.2 and 3.6.8

[GitHub] danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection

2019-01-17 Thread GitBox
danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-455384494 Since the query parameter bit is the same as for other Connection types, perhaps it makes more sense for the general case to

[GitHub] mik-laj commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection

2019-01-17 Thread GitBox
mik-laj commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-455378999 @mik-laj What specific things do you need? `schema` part must be equals `aws`. Query parameters must cotanins extra parameters.

[GitHub] XD-DENG commented on issue #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
XD-DENG commented on issue #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547#issuecomment-455375389 Thanks @feng-tao This is an

[jira] [Created] (AIRFLOW-3726) Change the description and the default value for broker_url in airflow.cfg

2019-01-17 Thread Kengo Seki (JIRA)
Kengo Seki created AIRFLOW-3726: --- Summary: Change the description and the default value for broker_url in airflow.cfg Key: AIRFLOW-3726 URL: https://issues.apache.org/jira/browse/AIRFLOW-3726 Project:

[GitHub] codecov-io edited a comment on issue #4321: incubator-airflow/scripts/ launchctl

2019-01-17 Thread GitBox
codecov-io edited a comment on issue #4321: incubator-airflow/scripts/ launchctl URL: https://github.com/apache/airflow/pull/4321#issuecomment-453847975 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4321?src=pr=h1) Report > Merging

[GitHub] dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-01-17 Thread GitBox
dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-455369056 I also can't reproduce the crash. `apache-airflow`: 1.10.1 Python: 3.7.2 tenacity: I tried 4.11 _and_ 4.12.

[GitHub] dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-01-17 Thread GitBox
dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-455369056 I also can't reproduce the crash. `apache-airflow`: 1.10.1 `tenacity`: I tried 4.11 _and_ 4.12. Python: 3.7.2

[jira] [Updated] (AIRFLOW-3702) Reverse Backfilling(from current date to start date)

2019-01-17 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-3702: Fix Version/s: (was: 1.10.2) 2.0.0 > Reverse Backfilling(from current

[jira] [Commented] (AIRFLOW-3229) New install with python3.7 fail - Need to bump tenacity version

2019-01-17 Thread Diego Argueta (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745610#comment-16745610 ] Diego Argueta commented on AIRFLOW-3229: After some experimenting I've been able to get this to

[GitHub] dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-01-17 Thread GitBox
dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-455369056 I also can't reproduce the crash. `apache-airflow`: 1.10.1 Python: 3.7.2 I installed `tenacity` using the constraints

[GitHub] dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-01-17 Thread GitBox
dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-455369056 I also can't reproduce the crash. `apache-airflow`: 1.10.1 Python: 3.7.2 I installed `tenacity` using the constraints

[GitHub] dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-01-17 Thread GitBox
dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-455369056 I also can't reproduce the crash. `apache-airflow`: 1.10.1 Python: 3.7.2 `tenacity >=4.11, <5.0` gives `4.12` and this

[GitHub] dargueta commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-01-17 Thread GitBox
dargueta commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-455369056 I also can't reproduce the crash. `apache-airflow`: 1.10.1 Python: 3.7.2 tenacity >=4.11, <5.0 gives `4.12` and this works. I

[jira] [Updated] (AIRFLOW-3720) GoogleCloudStorageToS3Operator - incorrect folder compare

2019-01-17 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-3720: Fix Version/s: (was: 1.10.2) 2.0.0 > GoogleCloudStorageToS3Operator -

[jira] [Commented] (AIRFLOW-2876) Bump version of Tenacity

2019-01-17 Thread Diego Argueta (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745616#comment-16745616 ] Diego Argueta commented on AIRFLOW-2876: Would it be possible to pin this to {{>=4.11.0, <5.0}}

[jira] [Commented] (AIRFLOW-3725) Bigquery_hook should be able to supply private_key to pandas_gbq.read_gbq

2019-01-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745605#comment-16745605 ] ASF GitHub Bot commented on AIRFLOW-3725: - asawitt commented on pull request #4549:

[GitHub] asawitt opened a new pull request #4549: [AIRFLOW-3725] Add private_key to bigquery_hook get_pandas_df

2019-01-17 Thread GitBox
asawitt opened a new pull request #4549: [AIRFLOW-3725] Add private_key to bigquery_hook get_pandas_df URL: https://github.com/apache/airflow/pull/4549 [AIRFLOW-3725] Bigquery Hook authentication currently defaults to Google User-account credentials, and the user is asked to

[GitHub] danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection

2019-01-17 Thread GitBox
danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-455352968 @mik-laj Oh cool, I didn't know you could do that! I'm afraid I haven't set up the AWS Connection that way before so I'm not

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-17 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455242821 @fokko - I am pushing an updated version. I know that famous quote, but I think in this case cache invalidation works in

[GitHub] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-17 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r248747685 ## File path: Dockerfile ## @@ -16,26 +16,83 @@ FROM python:3.6-slim -COPY .

[GitHub] feng-tao commented on issue #4459: [AIRFLOW-3649] Feature to add extra labels to kubernetes worker pods

2019-01-17 Thread GitBox
feng-tao commented on issue #4459: [AIRFLOW-3649] Feature to add extra labels to kubernetes worker pods URL: https://github.com/apache/airflow/pull/4459#issuecomment-455347596 once you rebase with master, it should be good @wyndhblb

[jira] [Commented] (AIRFLOW-3724) Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745544#comment-16745544 ] ASF subversion and git services commented on AIRFLOW-3724: -- Commit

[jira] [Commented] (AIRFLOW-3724) Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745543#comment-16745543 ] ASF subversion and git services commented on AIRFLOW-3724: -- Commit

svn commit: r32026 - /dev/airflow/1.10.2rc2/

2019-01-17 Thread kaxilnaik
Author: kaxilnaik Date: Thu Jan 17 21:49:15 2019 New Revision: 32026 Log: Add artefacts for Airflow 1.10.2rc2 Added: dev/airflow/1.10.2rc2/ dev/airflow/1.10.2rc2/apache-airflow-1.10.2rc2-bin.tar.gz (with props) dev/airflow/1.10.2rc2/apache-airflow-1.10.2rc2-bin.tar.gz.asc

[GitHub] idavison commented on issue #4294: [AIRFLOW-3451] Add UI button to refresh all dags

2019-01-17 Thread GitBox
idavison commented on issue #4294: [AIRFLOW-3451] Add UI button to refresh all dags URL: https://github.com/apache/airflow/pull/4294#issuecomment-455342669 @ron819 rebased This is an automated message from the Apache Git

[jira] [Commented] (AIRFLOW-3724) Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745524#comment-16745524 ] ASF GitHub Bot commented on AIRFLOW-3724: - kaxil commented on pull request #4548:

[jira] [Commented] (AIRFLOW-3724) Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745525#comment-16745525 ] ASF subversion and git services commented on AIRFLOW-3724: -- Commit

[jira] [Resolved] (AIRFLOW-3724) Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3724. - Resolution: Fixed Fix Version/s: 1.10.2 > Fix the broken refresh button on Graph View

[GitHub] kaxil merged pull request #4548: [AIRFLOW-3724] Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread GitBox
kaxil merged pull request #4548: [AIRFLOW-3724] Fix the broken refresh button on Graph View in RBAC UI URL: https://github.com/apache/airflow/pull/4548 This is an automated message from the Apache Git Service. To respond to

[GitHub] codecov-io commented on issue #4548: [AIRFLOW-3724] Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread GitBox
codecov-io commented on issue #4548: [AIRFLOW-3724] Fix the broken refresh button on Graph View in RBAC UI URL: https://github.com/apache/airflow/pull/4548#issuecomment-455333956 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4548?src=pr=h1) Report > Merging

[GitHub] mik-laj commented on a change in pull request #2455: [AIRFLOW-1423] Add logs to the scheduler DAG run decision logic

2019-01-17 Thread GitBox
mik-laj commented on a change in pull request #2455: [AIRFLOW-1423] Add logs to the scheduler DAG run decision logic URL: https://github.com/apache/airflow/pull/2455#discussion_r240830440 ## File path: airflow/jobs.py ## @@ -786,6 +788,9 @@ def create_dag_run(self, dag,

[GitHub] mik-laj commented on a change in pull request #4494: [AIRFLOW-3284] Azure Batch AI Operator

2019-01-17 Thread GitBox
mik-laj commented on a change in pull request #4494: [AIRFLOW-3284] Azure Batch AI Operator URL: https://github.com/apache/airflow/pull/4494#discussion_r248836913 ## File path: airflow/contrib/hooks/azure_batchai_hook.py ## @@ -0,0 +1,111 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] mik-laj commented on a change in pull request #4494: [AIRFLOW-3284] Azure Batch AI Operator

2019-01-17 Thread GitBox
mik-laj commented on a change in pull request #4494: [AIRFLOW-3284] Azure Batch AI Operator URL: https://github.com/apache/airflow/pull/4494#discussion_r248833770 ## File path: airflow/utils/db.py ## @@ -280,6 +280,14 @@ def initdb(rbac=False): Connection(

[GitHub] feng-tao commented on issue #4502: [AIRFLOW-3591] Fix start date, end date, duration for rescheduled tasks

2019-01-17 Thread GitBox
feng-tao commented on issue #4502: [AIRFLOW-3591] Fix start date, end date, duration for rescheduled tasks URL: https://github.com/apache/airflow/pull/4502#issuecomment-455325072 LGTM, PTAL @ashb and see if he has any other comments.

[GitHub] mik-laj edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-17 Thread GitBox
mik-laj edited a comment on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-455198427 @ashb I introduced all expected changes. This is an

[GitHub] kaxil commented on a change in pull request #4548: [AIRFLOW-3724] Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread GitBox
kaxil commented on a change in pull request #4548: [AIRFLOW-3724] Fix the broken refresh button on Graph View in RBAC UI URL: https://github.com/apache/airflow/pull/4548#discussion_r248829454 ## File path: airflow/www/templates/airflow/graph.html ## @@ -112,8 +112,8 @@

[jira] [Closed] (AIRFLOW-2165) XCOM values are being saved as bytestring

2019-01-17 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik closed AIRFLOW-2165. --- Resolution: Not A Problem > XCOM values are being saved as bytestring >

[jira] [Closed] (AIRFLOW-1850) Sqoop password is overwritten by reference

2019-01-17 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong closed AIRFLOW-1850. - Resolution: Fixed Fix Version/s: 1.9.0 > Sqoop password is overwritten by

[jira] [Commented] (AIRFLOW-1850) Sqoop password is overwritten by reference

2019-01-17 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745458#comment-16745458 ] Fokko Driesprong commented on AIRFLOW-1850: --- [~jackjack10] No this has been fixed already:

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-17 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455242821 @fokko - I am pushing an updated version. I know that famous quote, but I think in this case cache invalidation works in

[GitHub] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-17 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r248651860 ## File path: Dockerfile ## @@ -16,26 +16,83 @@ FROM python:3.6-slim -COPY .

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-17 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455242821 @fokko - I am pushing an updated version. I know that famous quote, but I think in this case cache invalidation works in

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-17 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455242821 @fokko - I am pushing an updated version. I know that famous quote, but I think in this case cache invalidation works in

[jira] [Commented] (AIRFLOW-2843) ExternalTaskSensor: Add option to cease waiting immediately if the external DAG/task doesn't exist

2019-01-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745315#comment-16745315 ] ASF GitHub Bot commented on AIRFLOW-2843: - feng-tao commented on pull request #4547:

[jira] [Commented] (AIRFLOW-3713) Updating.md should be updated with information about Optional Project Id in GCP operators

2019-01-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745318#comment-16745318 ] ASF subversion and git services commented on AIRFLOW-3713: -- Commit

[jira] [Commented] (AIRFLOW-3713) Updating.md should be updated with information about Optional Project Id in GCP operators

2019-01-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745317#comment-16745317 ] ASF GitHub Bot commented on AIRFLOW-3713: - feng-tao commented on pull request #4541:

[GitHub] feng-tao merged pull request #4541: [AIRFLOW-3713] Updated documentation for GCP optional project_id

2019-01-17 Thread GitBox
feng-tao merged pull request #4541: [AIRFLOW-3713] Updated documentation for GCP optional project_id URL: https://github.com/apache/airflow/pull/4541 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (AIRFLOW-2843) ExternalTaskSensor: Add option to cease waiting immediately if the external DAG/task doesn't exist

2019-01-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745316#comment-16745316 ] ASF subversion and git services commented on AIRFLOW-2843: -- Commit

[GitHub] feng-tao merged pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
feng-tao merged pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547 This is an automated message from the Apache Git

[GitHub] feng-tao commented on issue #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
feng-tao commented on issue #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547#issuecomment-455260837 LGTM, thanks @XD-DENG This is an

[jira] [Assigned] (AIRFLOW-2009) DataFlowHook does not use correct service account

2019-01-17 Thread Wilson Lian (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wilson Lian reassigned AIRFLOW-2009: Assignee: (was: Wilson Lian) > DataFlowHook does not use correct service account >

[GitHub] verdan commented on a change in pull request #4548: [AIRFLOW-3724] Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread GitBox
verdan commented on a change in pull request #4548: [AIRFLOW-3724] Fix the broken refresh button on Graph View in RBAC UI URL: https://github.com/apache/airflow/pull/4548#discussion_r248752708 ## File path: airflow/www/templates/airflow/graph.html ## @@ -112,8 +112,8 @@

[GitHub] potiuk commented on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-17 Thread GitBox
potiuk commented on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455242821 @fokko - I am pushing an updated version. I know that famous quote, but I think in this case cache invalidation works on our

[jira] [Commented] (AIRFLOW-1850) Sqoop password is overwritten by reference

2019-01-17 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745229#comment-16745229 ] jack commented on AIRFLOW-1850: --- [~Fokko] is this still an issue? > Sqoop password is overwritten by

[GitHub] ron819 commented on issue #4294: [AIRFLOW-3451] Add UI button to refresh all dags

2019-01-17 Thread GitBox
ron819 commented on issue #4294: [AIRFLOW-3451] Add UI button to refresh all dags URL: https://github.com/apache/airflow/pull/4294#issuecomment-455218322 @idavison Can you rebase? This is an automated message from the Apache

[jira] [Commented] (AIRFLOW-3455) Snowflake connector needs region ID also

2019-01-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745198#comment-16745198 ] ASF GitHub Bot commented on AIRFLOW-3455: - Fokko commented on pull request #4285:

[jira] [Commented] (AIRFLOW-2165) XCOM values are being saved as bytestring

2019-01-17 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745207#comment-16745207 ] jack commented on AIRFLOW-2165: --- [~kaxilnaik] is there something to do here or this can be closed? >

[jira] [Commented] (AIRFLOW-2319) Table "dag_run" has (bad) second index on (dag_id, execution_date)

2019-01-17 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745201#comment-16745201 ] jack commented on AIRFLOW-2319: --- [~akoeltringer] you can submit your proposal on the mailing list.. this

[jira] [Commented] (AIRFLOW-3455) Snowflake connector needs region ID also

2019-01-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745199#comment-16745199 ] ASF subversion and git services commented on AIRFLOW-3455: -- Commit

[jira] [Commented] (AIRFLOW-3455) Snowflake connector needs region ID also

2019-01-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745200#comment-16745200 ] ASF subversion and git services commented on AIRFLOW-3455: -- Commit

[GitHub] Fokko merged pull request #4285: [AIRFLOW-3455] add region in snowflake connector

2019-01-17 Thread GitBox
Fokko merged pull request #4285: [AIRFLOW-3455] add region in snowflake connector URL: https://github.com/apache/airflow/pull/4285 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] Fokko merged pull request #4545: [AIRFLOW-XXX] Correct Typo in sensor's exception

2019-01-17 Thread GitBox
Fokko merged pull request #4545: [AIRFLOW-XXX] Correct Typo in sensor's exception URL: https://github.com/apache/airflow/pull/4545 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] kaxil commented on issue #4548: [AIRFLOW-3724] Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread GitBox
kaxil commented on issue #4548: [AIRFLOW-3724] Fix the broken refresh button on Graph View in RBAC UI URL: https://github.com/apache/airflow/pull/4548#issuecomment-455209308 cc @verdan This is an automated message from the

[jira] [Commented] (AIRFLOW-3724) Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745180#comment-16745180 ] ASF GitHub Bot commented on AIRFLOW-3724: - kaxil commented on pull request #4548:

[jira] [Updated] (AIRFLOW-3724) Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-3724: Issue Type: Bug (was: Improvement) > Fix the broken refresh button on Graph View in RBAC UI >

[jira] [Created] (AIRFLOW-3724) Fix the broken refresh button on Graph View in RBAC UI

2019-01-17 Thread Kaxil Naik (JIRA)
Kaxil Naik created AIRFLOW-3724: --- Summary: Fix the broken refresh button on Graph View in RBAC UI Key: AIRFLOW-3724 URL: https://issues.apache.org/jira/browse/AIRFLOW-3724 Project: Apache Airflow

[GitHub] mik-laj commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection

2019-01-17 Thread GitBox
mik-laj commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-455200450 Could you provide a description on how to set up a connection via environment variables? Similar to GCP:

[GitHub] mik-laj commented on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-17 Thread GitBox
mik-laj commented on issue #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#issuecomment-455198427 @ashb I introduced all the expected changes. This is an

[GitHub] codecov-io commented on issue #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
codecov-io commented on issue #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547#issuecomment-455188704 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4547?src=pr=h1) Report > Merging

[GitHub] XD-DENG edited a comment on issue #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
XD-DENG edited a comment on issue #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547#issuecomment-455175873 Hi @feng-tao , as discussed in https://github.com/apache/airflow/pull/3688. PTAL.

[GitHub] XD-DENG commented on a change in pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
XD-DENG commented on a change in pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547#discussion_r248673451 ## File path: airflow/sensors/external_task_sensor.py ## @@

[GitHub] XD-DENG commented on issue #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
XD-DENG commented on issue #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547#issuecomment-455175873 Hi @feng-tao , PTAL. This is an

[GitHub] XD-DENG commented on a change in pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
XD-DENG commented on a change in pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547#discussion_r248673851 ## File path: airflow/sensors/external_task_sensor.py ## @@

[GitHub] XD-DENG commented on a change in pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
XD-DENG commented on a change in pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547#discussion_r248673451 ## File path: airflow/sensors/external_task_sensor.py ## @@

[jira] [Updated] (AIRFLOW-2843) ExternalTaskSensor: Add option to cease waiting immediately if the external DAG/task doesn't exist

2019-01-17 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-2843: --- Description: h2. Background *ExternalTaskSensor* will keep waiting (given restrictions of

[GitHub] XD-DENG commented on a change in pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
XD-DENG commented on a change in pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547#discussion_r248672681 ## File path: airflow/sensors/external_task_sensor.py ## @@ -26,7

[GitHub] XD-DENG commented on a change in pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
XD-DENG commented on a change in pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547#discussion_r248672681 ## File path: airflow/sensors/external_task_sensor.py ## @@ -26,7

[jira] [Commented] (AIRFLOW-2843) ExternalTaskSensor: Add option to cease waiting immediately if the external DAG/task doesn't exist

2019-01-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745046#comment-16745046 ] ASF GitHub Bot commented on AIRFLOW-2843: - XD-DENG commented on pull request #4547:

[GitHub] XD-DENG opened a new pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists

2019-01-17 Thread GitBox
XD-DENG opened a new pull request #4547: [AIRFLOW-2843] Add flag in ExternalTaskSensor to check if external DAG/task exists URL: https://github.com/apache/airflow/pull/4547 ### Jira - https://issues.apache.org/jira/browse/AIRFLOW-2843 ### Description Background

[jira] [Reopened] (AIRFLOW-2843) ExternalTaskSensor: Add option to cease waiting immediately if the external task doesn't exist

2019-01-17 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG reopened AIRFLOW-2843: > ExternalTaskSensor: Add option to cease waiting immediately if the external > task

  1   2   >