[GitHub] codecov-io commented on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator

2019-02-21 Thread GitBox
codecov-io commented on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator URL: https://github.com/apache/airflow/pull/4738#issuecomment-466303056 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4738?src=pr=h1) Report > Merging

[jira] [Created] (AIRFLOW-3936) Support for emptyDir volume in KubernetesExecutor

2019-02-21 Thread raman (JIRA)
raman created AIRFLOW-3936: -- Summary: Support for emptyDir volume in KubernetesExecutor Key: AIRFLOW-3936 URL: https://issues.apache.org/jira/browse/AIRFLOW-3936 Project: Apache Airflow Issue Type:

[GitHub] ttanay commented on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator

2019-02-21 Thread GitBox
ttanay commented on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator URL: https://github.com/apache/airflow/pull/4738#issuecomment-466293458 Job 9 failed with: ``` Authenticating as principal admin/admin with password. kadmin: Cannot resolve

[jira] [Resolved] (AIRFLOW-3604) Azure Integration - Hdinsight-operators

2019-02-21 Thread Alikemal Ocalan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alikemal Ocalan resolved AIRFLOW-3604. -- Resolution: Done > Azure Integration - Hdinsight-operators >

[jira] [Work stopped] (AIRFLOW-3604) Azure Integration - Hdinsight-operators

2019-02-21 Thread Alikemal Ocalan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-3604 stopped by Alikemal Ocalan. > Azure Integration - Hdinsight-operators >

[jira] [Work started] (AIRFLOW-3604) Azure Integration - Hdinsight-operators

2019-02-21 Thread Alikemal Ocalan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-3604 started by Alikemal Ocalan. > Azure Integration - Hdinsight-operators >

[GitHub] ttanay commented on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator

2019-02-21 Thread GitBox
ttanay commented on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator URL: https://github.com/apache/airflow/pull/4738#issuecomment-466276697 > @ttanay Maybe you could base on master and `git push -f` to your branch restart the CI test again.

[GitHub] zhongjiajie commented on issue #4584: [AIRFLOW-3741] Add extra config to Oracle hook

2019-02-21 Thread GitBox
zhongjiajie commented on issue #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#issuecomment-466275018 @ashb Thanks for changing and reviewing. But CI test in `check docs` section, should I restart CI test or not?

[GitHub] zhongjiajie commented on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator

2019-02-21 Thread GitBox
zhongjiajie commented on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator URL: https://github.com/apache/airflow/pull/4738#issuecomment-466273851 @ttanay Maybe you could base on master and `git push -f` to your branch restart the CI test again.

[GitHub] zhongjiajie commented on a change in pull request #4724: [AIRFLOW-3906] Add npm compile to docker file

2019-02-21 Thread GitBox
zhongjiajie commented on a change in pull request #4724: [AIRFLOW-3906] Add npm compile to docker file URL: https://github.com/apache/airflow/pull/4724#discussion_r259211977 ## File path: Dockerfile ## @@ -16,26 +16,43 @@ FROM python:3.6-slim -COPY . /opt/airflow/ -

[GitHub] codecov-io edited a comment on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links.

2019-02-21 Thread GitBox
codecov-io edited a comment on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links. URL: https://github.com/apache/airflow/pull/4742#issuecomment-465716310 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4742?src=pr=h1) Report > Merging

[GitHub] mik-laj commented on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links.

2019-02-21 Thread GitBox
mik-laj commented on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links. URL: https://github.com/apache/airflow/pull/4742#issuecomment-466270986 I will look at it in 6 hours when I get up. It looks to me that the change was favorable in other places, but I would like to check

[GitHub] mik-laj edited a comment on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links.

2019-02-21 Thread GitBox
mik-laj edited a comment on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links. URL: https://github.com/apache/airflow/pull/4742#issuecomment-466270986 I will look at it in 6 hours when I wake up. It looks to me that the change was favorable in other places, but I would like to

[GitHub] jmcarp commented on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links.

2019-02-21 Thread GitBox
jmcarp commented on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links. URL: https://github.com/apache/airflow/pull/4742#issuecomment-466269155 Yes: > Note: I only updated the four links at the top of the modal. The other links behave more like buttons, so I didn't change

[GitHub] mik-laj edited a comment on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links.

2019-02-21 Thread GitBox
mik-laj edited a comment on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links. URL: https://github.com/apache/airflow/pull/4742#issuecomment-466267474 did you omit some buttons intentionally? ```js $('#btn_edit_dagrun').click(function() { window.location

[GitHub] mik-laj commented on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links.

2019-02-21 Thread GitBox
mik-laj commented on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links. URL: https://github.com/apache/airflow/pull/4742#issuecomment-466267474 did you omit some buttons intentionally? ```js $('#btn_edit_dagrun').click(function() {

[GitHub] jmcarp commented on issue #4740: [AIRFLOW-3925] Don't pull docker-images on pretest

2019-02-21 Thread GitBox
jmcarp commented on issue #4740: [AIRFLOW-3925] Don't pull docker-images on pretest URL: https://github.com/apache/airflow/pull/4740#issuecomment-466266813 OK, if #4685 and #4703 will take more time to review, let's merge this and start saving time on pre-test steps now.

[GitHub] jmcarp commented on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links.

2019-02-21 Thread GitBox
jmcarp commented on issue #4742: [AIRFLOW-3929] Use anchor tags for modal links. URL: https://github.com/apache/airflow/pull/4742#issuecomment-466266419 Updated. I had to modify the example a bit, because different urls use different sets of query parameters, but base urls are templated

[GitHub] jmcarp commented on a change in pull request #4742: [AIRFLOW-3929] Use anchor tags for modal links.

2019-02-21 Thread GitBox
jmcarp commented on a change in pull request #4742: [AIRFLOW-3929] Use anchor tags for modal links. URL: https://github.com/apache/airflow/pull/4742#discussion_r259205435 ## File path: airflow/www/templates/airflow/dag.html ## @@ -315,6 +315,19 @@ var task_id = '';

[GitHub] ttanay edited a comment on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator

2019-02-21 Thread GitBox
ttanay edited a comment on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator URL: https://github.com/apache/airflow/pull/4738#issuecomment-466237072 The job 7 fails with message: ``` ERROR: for redis Get

[GitHub] ttanay edited a comment on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator

2019-02-21 Thread GitBox
ttanay edited a comment on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator URL: https://github.com/apache/airflow/pull/4738#issuecomment-466237072 The job 7 fails with message: ``` ERROR: for redis Get

[GitHub] ttanay commented on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator

2019-02-21 Thread GitBox
ttanay commented on issue #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator URL: https://github.com/apache/airflow/pull/4738#issuecomment-466237072 The job 7 fails with message: ``` ERROR: for redis Get

[GitHub] mik-laj commented on a change in pull request #4742: [AIRFLOW-3929] Use anchor tags for modal links.

2019-02-21 Thread GitBox
mik-laj commented on a change in pull request #4742: [AIRFLOW-3929] Use anchor tags for modal links. URL: https://github.com/apache/airflow/pull/4742#discussion_r259177966 ## File path: airflow/www/templates/airflow/dag.html ## @@ -315,6 +315,19 @@ var task_id = '';

[GitHub] briandconnelly commented on a change in pull request #3115: [AIRFLOW-2193] Add ROperator for using R

2019-02-21 Thread GitBox
briandconnelly commented on a change in pull request #3115: [AIRFLOW-2193] Add ROperator for using R URL: https://github.com/apache/airflow/pull/3115#discussion_r259159507 ## File path: airflow/contrib/operators/r_operator.py ## @@ -0,0 +1,79 @@ +# -*- coding: utf-8 -*-

[GitHub] AnderEnder commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-02-21 Thread GitBox
AnderEnder commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-466190991 @feng-tao, could you please backport this to the `v1-10-stable` branch? The fix is ready, but latest release and stable branch still does

[GitHub] feng-tao commented on issue #3533: [AIRFLOW-161] New redirect route and extra links

2019-02-21 Thread GitBox
feng-tao commented on issue #3533: [AIRFLOW-161] New redirect route and extra links URL: https://github.com/apache/airflow/pull/3533#issuecomment-466158868 @ArgentFalcon this pr has been reverted. Do let me know if you have the chance to resubmit with fixing all the test failures.

[GitHub] feng-tao closed pull request #3997: [AIRFLOW-3153] send dag last_run to statsd

2019-02-21 Thread GitBox
feng-tao closed pull request #3997: [AIRFLOW-3153] send dag last_run to statsd URL: https://github.com/apache/airflow/pull/3997 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (AIRFLOW-3153) send dag last_run to statsd

2019-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774468#comment-16774468 ] ASF GitHub Bot commented on AIRFLOW-3153: - feng-tao commented on pull request #3997:

[GitHub] codecov-io edited a comment on issue #4460: [AIRFLOW-3604] Add Azure Hdinsight operators for creating cluster and submitting

2019-02-21 Thread GitBox
codecov-io edited a comment on issue #4460: [AIRFLOW-3604] Add Azure Hdinsight operators for creating cluster and submitting URL: https://github.com/apache/airflow/pull/4460#issuecomment-454791525 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4460?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-3153) send dag last_run to statsd

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774460#comment-16774460 ] ASF subversion and git services commented on AIRFLOW-3153: -- Commit

[jira] [Commented] (AIRFLOW-3153) send dag last_run to statsd

2019-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774459#comment-16774459 ] ASF GitHub Bot commented on AIRFLOW-3153: - feng-tao commented on pull request #4748:

[GitHub] feng-tao commented on issue #4748: [AIRFLOW-3153] Send DAG processing stats to statsd

2019-02-21 Thread GitBox
feng-tao commented on issue #4748: [AIRFLOW-3153] Send DAG processing stats to statsd URL: https://github.com/apache/airflow/pull/4748#issuecomment-466140998 thanks @astahlman , lgtm This is an automated message from the

[jira] [Resolved] (AIRFLOW-3153) send dag last_run to statsd

2019-02-21 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng resolved AIRFLOW-3153. --- Resolution: Fixed > send dag last_run to statsd > --- > >

[GitHub] feng-tao merged pull request #4748: [AIRFLOW-3153] Send DAG processing stats to statsd

2019-02-21 Thread GitBox
feng-tao merged pull request #4748: [AIRFLOW-3153] Send DAG processing stats to statsd URL: https://github.com/apache/airflow/pull/4748 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] astahlman commented on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes

2019-02-21 Thread GitBox
astahlman commented on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes URL: https://github.com/apache/airflow/pull/4637#issuecomment-466096095 LGTM, for what it's worth

[jira] [Updated] (AIRFLOW-3923) Dependency flask-admin==1.5.2 fails safety check

2019-02-21 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3923: --- Fix Version/s: 1.10.3 > Dependency flask-admin==1.5.2 fails safety check >

[jira] [Commented] (AIRFLOW-3923) Dependency flask-admin==1.5.2 fails safety check

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774307#comment-16774307 ] ASF subversion and git services commented on AIRFLOW-3923: -- Commit

[jira] [Commented] (AIRFLOW-3907) Make session cookie security options configurable

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774306#comment-16774306 ] ASF subversion and git services commented on AIRFLOW-3907: -- Commit

[GitHub] ashb commented on issue #4739: [AIRFLOW-3923] Update flask-admin dependency to 1.5.3

2019-02-21 Thread GitBox
ashb commented on issue #4739: [AIRFLOW-3923] Update flask-admin dependency to 1.5.3 URL: https://github.com/apache/airflow/pull/4739#issuecomment-466075606 @feng-tao Until we are done with releases on 1.10 we need to keep up to date there anyway (though perhaps on the v1-10-stable branch

[GitHub] astahlman commented on issue #4748: [AIRFLOW-3153] Send DAG processing stats to statsd

2019-02-21 Thread GitBox
astahlman commented on issue #4748: [AIRFLOW-3153] Send DAG processing stats to statsd URL: https://github.com/apache/airflow/pull/4748#issuecomment-466074501 cc @feng-tao This is an automated message from the Apache Git

[jira] [Updated] (AIRFLOW-3907) Make session cookie security options configurable

2019-02-21 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3907: --- Fix Version/s: 1.10.3 > Make session cookie security options configurable >

[jira] [Commented] (AIRFLOW-2787) Airflow scheduler dies on DAGs with NULL DagRun run_id

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774272#comment-16774272 ] ASF subversion and git services commented on AIRFLOW-2787: -- Commit

[jira] [Commented] (AIRFLOW-3807) Fix graph view not highlighting correct tasks when hovering over or clicking on task state

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774280#comment-16774280 ] ASF subversion and git services commented on AIRFLOW-3807: -- Commit

[jira] [Commented] (AIRFLOW-3698) Add documentation for AWS Connection

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774275#comment-16774275 ] ASF subversion and git services commented on AIRFLOW-3698: -- Commit

[jira] [Commented] (AIRFLOW-3683) Error message of invalid trigger_rule not properly formatted

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774276#comment-16774276 ] ASF subversion and git services commented on AIRFLOW-3683: -- Commit

[jira] [Commented] (AIRFLOW-3636) Fix a test introduced in PR #4425

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774278#comment-16774278 ] ASF subversion and git services commented on AIRFLOW-3636: -- Commit

[jira] [Commented] (AIRFLOW-3780) Found some pages are incorrectly redirected after set base_url

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774271#comment-16774271 ] ASF subversion and git services commented on AIRFLOW-3780: -- Commit

[jira] [Commented] (AIRFLOW-3807) Fix graph view not highlighting correct tasks when hovering over or clicking on task state

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774279#comment-16774279 ] ASF subversion and git services commented on AIRFLOW-3807: -- Commit

[jira] [Commented] (AIRFLOW-3807) Fix graph view not highlighting correct tasks when hovering over or clicking on task state

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774282#comment-16774282 ] ASF subversion and git services commented on AIRFLOW-3807: -- Commit

[jira] [Commented] (AIRFLOW-3807) Fix graph view not highlighting correct tasks when hovering over or clicking on task state

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774281#comment-16774281 ] ASF subversion and git services commented on AIRFLOW-3807: -- Commit

[jira] [Commented] (AIRFLOW-3807) Fix graph view not highlighting correct tasks when hovering over or clicking on task state

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774283#comment-16774283 ] ASF subversion and git services commented on AIRFLOW-3807: -- Commit

[jira] [Commented] (AIRFLOW-3616) Connection parsed from URI - unacceptable underscore in schema part

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774273#comment-16774273 ] ASF subversion and git services commented on AIRFLOW-3616: -- Commit

[jira] [Commented] (AIRFLOW-3623) Support download log file from UI

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774277#comment-16774277 ] ASF subversion and git services commented on AIRFLOW-3623: -- Commit

[jira] [Commented] (AIRFLOW-3639) Jenkins Operator does not set up "Authorization" header correctly

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774270#comment-16774270 ] ASF subversion and git services commented on AIRFLOW-3639: -- Commit

[jira] [Resolved] (AIRFLOW-3623) Support download log file from UI

2019-02-21 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3623. Resolution: Fixed Fix Version/s: 2.0.0 > Support download log file from

[jira] [Reopened] (AIRFLOW-3623) Support download log file from UI

2019-02-21 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-3623: > Support download log file from UI > - > >

[GitHub] XD-DENG edited a comment on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes

2019-02-21 Thread GitBox
XD-DENG edited a comment on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes URL: https://github.com/apache/airflow/pull/4637#issuecomment-466058891 > I vote for removing the currently skipped tests that depend upon config settings we are

[GitHub] XD-DENG commented on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes

2019-02-21 Thread GitBox
XD-DENG commented on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes URL: https://github.com/apache/airflow/pull/4637#issuecomment-466058891 > I vote for removing the currently skipped tests that depend upon config settings we are

[GitHub] XD-DENG commented on a change in pull request #4705: [AIRFLOW-3743] Unify different methods of working out AIRFLOW_HOME

2019-02-21 Thread GitBox
XD-DENG commented on a change in pull request #4705: [AIRFLOW-3743] Unify different methods of working out AIRFLOW_HOME URL: https://github.com/apache/airflow/pull/4705#discussion_r258994888 ## File path: airflow/configuration.py ## @@ -530,6 +530,24 @@ def

[GitHub] XD-DENG edited a comment on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes

2019-02-21 Thread GitBox
XD-DENG edited a comment on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes URL: https://github.com/apache/airflow/pull/4637#issuecomment-466049607 > Sorry - been swamped recently. Where did we end up with the various API auth

[GitHub] XD-DENG edited a comment on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes

2019-02-21 Thread GitBox
XD-DENG edited a comment on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes URL: https://github.com/apache/airflow/pull/4637#issuecomment-466049607 > Sorry - been swamped recently. Where did we end up with the various API auth

[GitHub] rhwang10 commented on a change in pull request #4303: [AIRFLOW-3370] Elasticsearch log task handler additional features

2019-02-21 Thread GitBox
rhwang10 commented on a change in pull request #4303: [AIRFLOW-3370] Elasticsearch log task handler additional features URL: https://github.com/apache/airflow/pull/4303#discussion_r258987877 ## File path: airflow/utils/log/es_task_handler.py ## @@ -68,12 +118,115 @@ def

[GitHub] rhwang10 commented on a change in pull request #4303: [AIRFLOW-3370] Elasticsearch log task handler additional features

2019-02-21 Thread GitBox
rhwang10 commented on a change in pull request #4303: [AIRFLOW-3370] Elasticsearch log task handler additional features URL: https://github.com/apache/airflow/pull/4303#discussion_r258987877 ## File path: airflow/utils/log/es_task_handler.py ## @@ -68,12 +118,115 @@ def

[GitHub] XD-DENG commented on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes

2019-02-21 Thread GitBox
XD-DENG commented on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes URL: https://github.com/apache/airflow/pull/4637#issuecomment-466049607 > Sorry - been swamped recently. Where did we end up with the various API auth discussions?

[jira] [Commented] (AIRFLOW-3683) Error message of invalid trigger_rule not properly formatted

2019-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774160#comment-16774160 ] ASF GitHub Bot commented on AIRFLOW-3683: - ashb commented on pull request #4490: [AIRFLOW-3683]

[GitHub] codecov-io commented on issue #4752: [AIRFLOW-3935] answer a TODO in airflow/executors/local_executor.py

2019-02-21 Thread GitBox
codecov-io commented on issue #4752: [AIRFLOW-3935] answer a TODO in airflow/executors/local_executor.py URL: https://github.com/apache/airflow/pull/4752#issuecomment-466046339 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4752?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-3683) Error message of invalid trigger_rule not properly formatted

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774163#comment-16774163 ] ASF subversion and git services commented on AIRFLOW-3683: -- Commit

[GitHub] ashb commented on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes

2019-02-21 Thread GitBox
ashb commented on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes URL: https://github.com/apache/airflow/pull/4637#issuecomment-466042301 I vote for removing the currently skipped tests that depend upon config settings we are removing.

[GitHub] ashb commented on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes

2019-02-21 Thread GitBox
ashb commented on issue #4637: [AIRFLOW-3793] Decommission configuration items for Flask-Admin web UI & related codes URL: https://github.com/apache/airflow/pull/4637#issuecomment-466040739 Sorry - been swamped recently. Where did we end up with the various API auth discussions?

[GitHub] ashb commented on a change in pull request #4705: [AIRFLOW-3743] Unify different methods of working out AIRFLOW_HOME

2019-02-21 Thread GitBox
ashb commented on a change in pull request #4705: [AIRFLOW-3743] Unify different methods of working out AIRFLOW_HOME URL: https://github.com/apache/airflow/pull/4705#discussion_r258974858 ## File path: airflow/configuration.py ## @@ -530,6 +530,24 @@ def

[jira] [Resolved] (AIRFLOW-3683) Error message of invalid trigger_rule not properly formatted

2019-02-21 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3683. Resolution: Fixed Fix Version/s: 1.10.3 > Error message of invalid

[jira] [Commented] (AIRFLOW-3683) Error message of invalid trigger_rule not properly formatted

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774161#comment-16774161 ] ASF subversion and git services commented on AIRFLOW-3683: -- Commit

[GitHub] ashb merged pull request #4490: [AIRFLOW-3683] Fix formatting of error message for invalid TriggerRule

2019-02-21 Thread GitBox
ashb merged pull request #4490: [AIRFLOW-3683] Fix formatting of error message for invalid TriggerRule URL: https://github.com/apache/airflow/pull/4490 This is an automated message from the Apache Git Service. To respond to

[GitHub] ashb commented on issue #4686: [AIRFLOW-3864] Recognize lists as JSON in variables --import

2019-02-21 Thread GitBox
ashb commented on issue #4686: [AIRFLOW-3864] Recognize lists as JSON in variables --import URL: https://github.com/apache/airflow/pull/4686#issuecomment-466038422 Could you please add some tests to this - there is a case already in tests/core.py - CliTest.test_variables. You'll probably

[jira] [Comment Edited] (AIRFLOW-2508) Handle non string types in render_template_from_field

2019-02-21 Thread Galak (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774156#comment-16774156 ] Galak edited comment on AIRFLOW-2508 at 2/21/19 3:17 PM: - [~bjoern.pollex] :

[jira] [Commented] (AIRFLOW-2508) Handle non string types in render_template_from_field

2019-02-21 Thread Galak (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774156#comment-16774156 ] Galak commented on AIRFLOW-2508: [~bjoern.pollex] : I've just read your comment here. I had not seen

[GitHub] ashb commented on issue #4667: [AIRFLOW-3826] Group SageMaker sensors and operators into 2 files

2019-02-21 Thread GitBox
ashb commented on issue #4667: [AIRFLOW-3826] Group SageMaker sensors and operators into 2 files URL: https://github.com/apache/airflow/pull/4667#issuecomment-466034974 So `from airflow.sensors.aws_sagemaker import SageMakerFooSensor` pattern then? (Main point of my suggestion was

[GitHub] ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

2019-02-21 Thread GitBox
ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r258947600 ## File path: airflow/hooks/oracle_hook.py ## @@ -48,22 +48,65 @@ def get_conn(self):

[GitHub] XD-DENG edited a comment on issue #4752: [AIRFLOW-3935] answer a TODO in airflow/executors/local_executor.py

2019-02-21 Thread GitBox
XD-DENG edited a comment on issue #4752: [AIRFLOW-3935] answer a TODO in airflow/executors/local_executor.py URL: https://github.com/apache/airflow/pull/4752#issuecomment-466016399 Hi @Fokko , may you take a look? This minor PR is to address a TODO you marked eariler (quite long time

[GitHub] XD-DENG commented on issue #4752: [AIRFLOW-3935] answer a TODO in airflow/executors/local_executor.py

2019-02-21 Thread GitBox
XD-DENG commented on issue #4752: [AIRFLOW-3935] answer a TODO in airflow/executors/local_executor.py URL: https://github.com/apache/airflow/pull/4752#issuecomment-466016399 Hi @Fokko , may you take a look? This minor PR is to address a TODO you marked eariler (quite long time back) in

[jira] [Commented] (AIRFLOW-3935) Clear a TODO in airflow/executors/local_executor.py: answer why not explicitly raise exception

2019-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774101#comment-16774101 ] ASF GitHub Bot commented on AIRFLOW-3935: - XD-DENG commented on pull request #4752:

[jira] [Updated] (AIRFLOW-3935) Clear a TODO in airflow/executors/local_executor.py: answer why not explicitly raise exception

2019-02-21 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-3935: --- Description: A TODO was added in

[GitHub] XD-DENG opened a new pull request #4752: [AIRFLOW-3935] answer a TODO in airflow/executors/local_executor.py

2019-02-21 Thread GitBox
XD-DENG opened a new pull request #4752: [AIRFLOW-3935] answer a TODO in airflow/executors/local_executor.py URL: https://github.com/apache/airflow/pull/4752 ### Jira - https://issues.apache.org/jira/browse/AIRFLOW-3935 ### Description The TODO cleared in this PR

[jira] [Updated] (AIRFLOW-3935) Clear a TODO in airflow/executors/local_executor.py: answer why not explicitly raise exception

2019-02-21 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-3935: --- Summary: Clear a TODO in airflow/executors/local_executor.py: answer why not explicitly

[jira] [Created] (AIRFLOW-3935) Remove a TODO in airflow/executors/local_executor.py

2019-02-21 Thread Xiaodong DENG (JIRA)
Xiaodong DENG created AIRFLOW-3935: -- Summary: Remove a TODO in airflow/executors/local_executor.py Key: AIRFLOW-3935 URL: https://issues.apache.org/jira/browse/AIRFLOW-3935 Project: Apache Airflow

[jira] [Commented] (AIRFLOW-2806) test_mark_success_no_kill test breaks intermittently on CI

2019-02-21 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774081#comment-16774081 ] jack commented on AIRFLOW-2806: --- Was this resolved? > test_mark_success_no_kill test breaks

[jira] [Commented] (AIRFLOW-1400) catchup=False caused exception

2019-02-21 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774076#comment-16774076 ] jack commented on AIRFLOW-1400: --- [~arjun.arippa] tested your DAG on 1.9.0 it works perfectly. There is no

[GitHub] OmerJog commented on issue #4745: [AIRFLOW-xxx] Correct BranchPythonOperator docs

2019-02-21 Thread GitBox
OmerJog commented on issue #4745: [AIRFLOW-xxx] Correct BranchPythonOperator docs URL: https://github.com/apache/airflow/pull/4745#issuecomment-465999408 There is another pending PR https://github.com/apache/airflow/pull/4388 on the same docs rows @BasPH @jgao54

[GitHub] feluelle edited a comment on issue #4751: collected trigger rule dep check per dag run

2019-02-21 Thread GitBox
feluelle edited a comment on issue #4751: collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#issuecomment-465996380 Please reference your jira ticket number in the PR title. It is required for the jira git integration to work.

[GitHub] feluelle commented on issue #4751: collected trigger rule dep check per dag run

2019-02-21 Thread GitBox
feluelle commented on issue #4751: collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#issuecomment-465996380 Please reference your jira ticket number in the PR title. This is an

[jira] [Commented] (AIRFLOW-1215) Add Airflow Connections via command line for schemes with underscore fail to be added successfully

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774039#comment-16774039 ] ASF subversion and git services commented on AIRFLOW-1215: -- Commit

[jira] [Commented] (AIRFLOW-3729) Support env variables with pod runtime information in KubernetesPodOperator

2019-02-21 Thread Stijn De Haes (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774044#comment-16774044 ] Stijn De Haes commented on AIRFLOW-3729: I was searching for this so thank you for the PR!

[jira] [Commented] (AIRFLOW-3698) Add documentation for AWS Connection

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774040#comment-16774040 ] ASF subversion and git services commented on AIRFLOW-3698: -- Commit

[jira] [Commented] (AIRFLOW-3616) Connection parsed from URI - unacceptable underscore in schema part

2019-02-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774038#comment-16774038 ] ASF subversion and git services commented on AIRFLOW-3616: -- Commit

[GitHub] amichai07 opened a new pull request #4751: collected trigger rule dep check per dag run

2019-02-21 Thread GitBox
amichai07 opened a new pull request #4751: collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751 ### Jira * My PR addresses the following https://issues.apache.org/jira/browse/AIRFLOW-3607 and references them in the PR title * Decreasing

[GitHub] Fokko commented on issue #4750: [AIRFLOW-XXX] Add Slack Badge to Readme

2019-02-21 Thread GitBox
Fokko commented on issue #4750: [AIRFLOW-XXX] Add Slack Badge to Readme URL: https://github.com/apache/airflow/pull/4750#issuecomment-465971841 Thanks @feluelle This is an automated message from the Apache Git Service. To

[GitHub] Fokko commented on a change in pull request #4750: [AIRFLOW-XXX] Add Slack Badge to Readme

2019-02-21 Thread GitBox
Fokko commented on a change in pull request #4750: [AIRFLOW-XXX] Add Slack Badge to Readme URL: https://github.com/apache/airflow/pull/4750#discussion_r258894729 ## File path: README.md ## @@ -26,6 +26,7 @@ under the License.

[GitHub] Fokko merged pull request #4750: [AIRFLOW-XXX] Add Slack Badge to Readme

2019-02-21 Thread GitBox
Fokko merged pull request #4750: [AIRFLOW-XXX] Add Slack Badge to Readme URL: https://github.com/apache/airflow/pull/4750 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] feluelle commented on a change in pull request #4750: [AIRFLOW-XXX] Add Slack Badge to Readme

2019-02-21 Thread GitBox
feluelle commented on a change in pull request #4750: [AIRFLOW-XXX] Add Slack Badge to Readme URL: https://github.com/apache/airflow/pull/4750#discussion_r258879828 ## File path: README.md ## @@ -26,6 +26,7 @@ under the License.

[GitHub] amichai07 closed pull request #4614: Decreasing scheduler delay between tasks

2019-02-21 Thread GitBox
amichai07 closed pull request #4614: Decreasing scheduler delay between tasks URL: https://github.com/apache/airflow/pull/4614 This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   >