[GitHub] [airflow] codecov-io edited a comment on issue #7163: [AIRFLOW-6542] add spark-on-k8s operator/hook/sensor

2020-02-27 Thread GitBox
codecov-io edited a comment on issue #7163: [AIRFLOW-6542] add spark-on-k8s operator/hook/sensor URL: https://github.com/apache/airflow/pull/7163#issuecomment-574641714 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7163?src=pr=h1) Report > Merging

[jira] [Created] (AIRFLOW-6948) Remove ASCII Airflow from version command

2020-02-27 Thread Tomasz Urbaszek (Jira)
Tomasz Urbaszek created AIRFLOW-6948: Summary: Remove ASCII Airflow from version command Key: AIRFLOW-6948 URL: https://issues.apache.org/jira/browse/AIRFLOW-6948 Project: Apache Airflow

[GitHub] [airflow] konpap94 commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp…

2020-02-27 Thread GitBox
konpap94 commented on issue #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp… URL: https://github.com/apache/airflow/pull/6337#issuecomment-592023535  This is an automated message from the Apache

[GitHub] [airflow] roitvt commented on issue #7163: [AIRFLOW-6542] add spark-on-k8s operator/hook/sensor

2020-02-27 Thread GitBox
roitvt commented on issue #7163: [AIRFLOW-6542] add spark-on-k8s operator/hook/sensor URL: https://github.com/apache/airflow/pull/7163#issuecomment-592021693 @kaxil and @ashb I added test and fixed the things from your last review and you check again? Thanks

[GitHub] [airflow] roitvt commented on issue #7163: [AIRFLOW-6542] add spark-on-k8s operator/hook/sensor

2020-02-27 Thread GitBox
roitvt commented on issue #7163: [AIRFLOW-6542] add spark-on-k8s operator/hook/sensor URL: https://github.com/apache/airflow/pull/7163#issuecomment-592021378 @kaxil and @ashb I added test and fixed the things from your last review and you check again? Thanks

[GitHub] [airflow] zhongjiajie commented on issue #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax

2020-02-27 Thread GitBox
zhongjiajie commented on issue #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax URL: https://github.com/apache/airflow/pull/7343#issuecomment-592015585 @mik-laj Sure, but how could I do? submit a new PR to this repo? or create a PR to

[GitHub] [airflow] mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

2020-02-27 Thread GitBox
mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun URL: https://github.com/apache/airflow/pull/7565#discussion_r385176259 ## File path: tests/models/test_dag.py ## @@ -1341,3 +1344,26 @@ class

[jira] [Commented] (AIRFLOW-6939) Executor configuration via import path

2020-02-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046714#comment-17046714 ] ASF subversion and git services commented on AIRFLOW-6939: -- Commit

[GitHub] [airflow] ryw commented on a change in pull request #7553: [AIRFLOW-XXXX] Update LICENSE versions and remove old licenses

2020-02-27 Thread GitBox
ryw commented on a change in pull request #7553: [AIRFLOW-] Update LICENSE versions and remove old licenses URL: https://github.com/apache/airflow/pull/7553#discussion_r385171624 ## File path: LICENSE ## @@ -229,36 +229,22 @@ MIT licenses The following components are

[jira] [Commented] (AIRFLOW-6939) Executor configuration via import path

2020-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046712#comment-17046712 ] ASF GitHub Bot commented on AIRFLOW-6939: - mik-laj commented on pull request #7563:

[GitHub] [airflow] mik-laj merged pull request #7563: [AIRFLOW-6939] Executor configuration via import path

2020-02-27 Thread GitBox
mik-laj merged pull request #7563: [AIRFLOW-6939] Executor configuration via import path URL: https://github.com/apache/airflow/pull/7563 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

2020-02-27 Thread GitBox
mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun URL: https://github.com/apache/airflow/pull/7565#discussion_r385172573 ## File path: tests/models/test_dag.py ## @@ -1341,3 +1344,26 @@ class

[jira] [Resolved] (AIRFLOW-6939) Executor configuration via import path

2020-02-27 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula resolved AIRFLOW-6939. Fix Version/s: 2.0.0 Resolution: Fixed > Executor configuration via import path >

[GitHub] [airflow] mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

2020-02-27 Thread GitBox
mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun URL: https://github.com/apache/airflow/pull/7565#discussion_r385170832 ## File path: tests/models/test_dag.py ## @@ -1341,3 +1344,26 @@ class

[GitHub] [airflow] feluelle commented on issue #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE

2020-02-27 Thread GitBox
feluelle commented on issue #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE URL: https://github.com/apache/airflow/pull/7536#issuecomment-592005586 Can you try a rebase? This is an automated message

[GitHub] [airflow] tooptoop4 commented on issue #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE

2020-02-27 Thread GitBox
tooptoop4 commented on issue #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE URL: https://github.com/apache/airflow/pull/7536#issuecomment-592000630 @feluelle any idea why travis unhappy? maybe the current code (before my PR) was always evaluating to false

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

2020-02-27 Thread GitBox
nuclearpinguin commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun URL: https://github.com/apache/airflow/pull/7565#discussion_r385154503 ## File path: tests/models/test_dag.py ## @@ -1341,3 +1344,26 @@ class

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

2020-02-27 Thread GitBox
nuclearpinguin commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun URL: https://github.com/apache/airflow/pull/7565#discussion_r385154503 ## File path: tests/models/test_dag.py ## @@ -1341,3 +1344,26 @@ class

[GitHub] [airflow] ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor URL: https://github.com/apache/airflow/pull/7559#discussion_r385146211 ## File path: airflow/jobs/scheduler_job.py ## @@ -991,10 +1057,13 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor URL: https://github.com/apache/airflow/pull/7559#discussion_r385146089 ## File path: airflow/jobs/scheduler_job.py ## @@ -991,10 +1057,13 @@ def

[GitHub] [airflow] zhongjiajie commented on issue #7148: [AIRFLOW-6472] Correct short option in cli

2020-02-27 Thread GitBox
zhongjiajie commented on issue #7148: [AIRFLOW-6472] Correct short option in cli URL: https://github.com/apache/airflow/pull/7148#issuecomment-591988120 @potiuk and @mik-laj CI green, could you please review this PR, don't forget we still have discuss in

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook

2020-02-27 Thread GitBox
nuclearpinguin commented on a change in pull request #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook URL: https://github.com/apache/airflow/pull/6576#discussion_r385135203 ## File path: airflow/providers/mysql/hooks/mysql.py ## @@

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385142816 ## File path: tests/providers/amazon/aws/operators/test_ecs.py ## @@ -48,12 +48,10 @@ ] }

[GitHub] [airflow] codecov-io commented on issue #7547: [AIRFLOW-6926] Fix Google Tasks operators return types and idempotency

2020-02-27 Thread GitBox
codecov-io commented on issue #7547: [AIRFLOW-6926] Fix Google Tasks operators return types and idempotency URL: https://github.com/apache/airflow/pull/7547#issuecomment-591984953 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7547?src=pr=h1) Report > Merging

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385139258 ## File path: tests/providers/amazon/aws/operators/test_ecs.py ## @@ -171,7 +166,7 @@ def

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385139258 ## File path: tests/providers/amazon/aws/operators/test_ecs.py ## @@ -171,7 +166,7 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #7563: [AIRFLOW-6939] Executor configuration via import path

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7563: [AIRFLOW-6939] Executor configuration via import path URL: https://github.com/apache/airflow/pull/7563#discussion_r385131154 ## File path: UPDATING.md ## @@ -61,6 +61,29 @@

[GitHub] [airflow] feluelle commented on issue #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook

2020-02-27 Thread GitBox
feluelle commented on issue #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook URL: https://github.com/apache/airflow/pull/6576#issuecomment-591974065 It is green  This is an automated

[GitHub] [airflow] ashb commented on a change in pull request #7437: [AIRFLOW-2325] Add CloudwatchTaskHandler option for remote task loggi…

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7437: [AIRFLOW-2325] Add CloudwatchTaskHandler option for remote task loggi… URL: https://github.com/apache/airflow/pull/7437#discussion_r385123141 ## File path: airflow/utils/log/cloudwatch_task_handler.py ## @@ -0,0 +1,114 @@

[GitHub] [airflow] ashb commented on a change in pull request #7437: [AIRFLOW-2325] Add CloudwatchTaskHandler option for remote task loggi…

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7437: [AIRFLOW-2325] Add CloudwatchTaskHandler option for remote task loggi… URL: https://github.com/apache/airflow/pull/7437#discussion_r382901838 ## File path: setup.py ## @@ -157,6 +157,7 @@ def write_version(filename: str =

[GitHub] [airflow] ashb commented on a change in pull request #7437: [AIRFLOW-2325] Add CloudwatchTaskHandler option for remote task loggi…

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7437: [AIRFLOW-2325] Add CloudwatchTaskHandler option for remote task loggi… URL: https://github.com/apache/airflow/pull/7437#discussion_r385128092 ## File path: docs/howto/write-logs.rst ## @@ -115,6 +115,29 @@ To configure it,

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7571: [AIRFLOW-XXXX] Fix typos in best-practices.rst, yandexcloud.rst, and concepts.rst

2020-02-27 Thread GitBox
boring-cyborg[bot] commented on issue #7571: [AIRFLOW-] Fix typos in best-practices.rst, yandexcloud.rst, and concepts.rst URL: https://github.com/apache/airflow/pull/7571#issuecomment-591972889 Awesome work, congrats on your first merged pull request!

[GitHub] [airflow] kaxil merged pull request #7571: [AIRFLOW-XXXX] Fix typos in best-practices.rst, yandexcloud.rst, and concepts.rst

2020-02-27 Thread GitBox
kaxil merged pull request #7571: [AIRFLOW-] Fix typos in best-practices.rst, yandexcloud.rst, and concepts.rst URL: https://github.com/apache/airflow/pull/7571 This is an automated message from the Apache Git Service.

[GitHub] [airflow] ryanahamilton opened a new pull request #7571: [AIRFLOW-XXXX] Fix typos in best-practices.rst, yandexcloud.rst, and concepts.rst

2020-02-27 Thread GitBox
ryanahamilton opened a new pull request #7571: [AIRFLOW-] Fix typos in best-practices.rst, yandexcloud.rst, and concepts.rst URL: https://github.com/apache/airflow/pull/7571 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7571: [AIRFLOW-XXXX] Fix typos in best-practices.rst, yandexcloud.rst, and concepts.rst

2020-02-27 Thread GitBox
boring-cyborg[bot] commented on issue #7571: [AIRFLOW-] Fix typos in best-practices.rst, yandexcloud.rst, and concepts.rst URL: https://github.com/apache/airflow/pull/7571#issuecomment-591972078 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If

[jira] [Assigned] (AIRFLOW-6768) Graph view rendering angular edges

2020-02-27 Thread Nathan Hadfield (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Hadfield reassigned AIRFLOW-6768: Assignee: Ry Walker > Graph view rendering angular edges >

[jira] [Assigned] (AIRFLOW-6768) Graph view rendering angular edges

2020-02-27 Thread Nathan Hadfield (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Hadfield reassigned AIRFLOW-6768: Assignee: (was: Nathan Hadfield) > Graph view rendering angular edges >

[GitHub] [airflow] mik-laj commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor

2020-02-27 Thread GitBox
mik-laj commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor URL: https://github.com/apache/airflow/pull/7559#discussion_r385123975 ## File path: airflow/jobs/scheduler_job.py ## @@ -991,10 +1057,13 @@ def

[GitHub] [airflow] mik-laj commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor

2020-02-27 Thread GitBox
mik-laj commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor URL: https://github.com/apache/airflow/pull/7559#discussion_r385123579 ## File path: airflow/jobs/scheduler_job.py ## @@ -991,10 +1057,13 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #7492: [AIRFLOW-6871] optimize tree view for large DAGs

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7492: [AIRFLOW-6871] optimize tree view for large DAGs URL: https://github.com/apache/airflow/pull/7492#discussion_r385121966 ## File path: airflow/www/views.py ## @@ -1374,90 +1376,115 @@ def tree(self): .all()

[GitHub] [airflow] ashb commented on a change in pull request #7492: [AIRFLOW-6871] optimize tree view for large DAGs

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7492: [AIRFLOW-6871] optimize tree view for large DAGs URL: https://github.com/apache/airflow/pull/7492#discussion_r385121446 ## File path: airflow/www/views.py ## @@ -1371,90 +1374,115 @@ def tree(self): .all()

[GitHub] [airflow] ashb commented on a change in pull request #7492: [AIRFLOW-6871] optimize tree view for large DAGs

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7492: [AIRFLOW-6871] optimize tree view for large DAGs URL: https://github.com/apache/airflow/pull/7492#discussion_r385120657 ## File path: airflow/www/views.py ## @@ -1374,90 +1376,115 @@ def tree(self): .all()

[GitHub] [airflow] ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor URL: https://github.com/apache/airflow/pull/7559#discussion_r385118219 ## File path: airflow/jobs/scheduler_job.py ## @@ -991,10 +1057,13 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor URL: https://github.com/apache/airflow/pull/7559#discussion_r385119442 ## File path: airflow/jobs/scheduler_job.py ## @@ -991,10 +1057,13 @@ def

[jira] [Commented] (AIRFLOW-6857) Bulk sync DAGs

2020-02-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046608#comment-17046608 ] ASF subversion and git services commented on AIRFLOW-6857: -- Commit

[jira] [Commented] (AIRFLOW-6857) Bulk sync DAGs

2020-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046607#comment-17046607 ] ASF GitHub Bot commented on AIRFLOW-6857: - mik-laj commented on pull request #7477:

[GitHub] [airflow] mik-laj merged pull request #7477: [AIRFLOW-6857] Bulk sync DAGs

2020-02-27 Thread GitBox
mik-laj merged pull request #7477: [AIRFLOW-6857] Bulk sync DAGs URL: https://github.com/apache/airflow/pull/7477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-02-27 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-591959953 @feluelle deleted 'tests/sensors/test_aws_glue_job_sensor.py' Not sure about how to exclude integration change, you asked to

[GitHub] [airflow] baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r38577 ## File path: tests/providers/amazon/aws/operators/test_ecs.py ## @@ -48,12 +48,10 @@ ] }

[GitHub] [airflow] abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-02-27 Thread GitBox
abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#discussion_r385110737 ## File path: docs/integration.rst ## @@ -17,7 +17,6 @@ Integration === - Review

[GitHub] [airflow] baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385110474 ## File path: tests/providers/amazon/aws/operators/test_ecs.py ## @@ -171,7 +166,7 @@ def

[GitHub] [airflow] feluelle commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#discussion_r385107981 ## File path: docs/integration.rst ## @@ -17,7 +17,6 @@ Integration === - Review

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-02-27 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-591954863 @feluelle I have made all changes and have rebased, does it look okay now?

[GitHub] [airflow] zhongjiajie commented on issue #7148: [AIRFLOW-6472] Correct short option in cli

2020-02-27 Thread GitBox
zhongjiajie commented on issue #7148: [AIRFLOW-6472] Correct short option in cli URL: https://github.com/apache/airflow/pull/7148#issuecomment-591951660 I find out our Breeze subcommand also name kebab-case style ![](https://i.loli.net/2020/02/27/IsqAGHgeMRbD4iE.png) But Airflow CLI

[jira] [Commented] (AIRFLOW-6938) Don't read dag_directory in Scheduler

2020-02-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046579#comment-17046579 ] ASF subversion and git services commented on AIRFLOW-6938: -- Commit

[jira] [Commented] (AIRFLOW-6938) Don't read dag_directory in Scheduler

2020-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046577#comment-17046577 ] ASF GitHub Bot commented on AIRFLOW-6938: - mik-laj commented on pull request #7562:

[GitHub] [airflow] mik-laj merged pull request #7562: [AIRFLOW-6938] Don't read dag_directory in SchedulerJob

2020-02-27 Thread GitBox
mik-laj merged pull request #7562: [AIRFLOW-6938] Don't read dag_directory in SchedulerJob URL: https://github.com/apache/airflow/pull/7562 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on issue #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax

2020-02-27 Thread GitBox
mik-laj commented on issue #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax URL: https://github.com/apache/airflow/pull/7343#issuecomment-591949011 @zhongjiajie I don't have time to finish this, because I've taken care of the scheduler performance. You want to take over?

[GitHub] [airflow] mik-laj edited a comment on issue #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax

2020-02-27 Thread GitBox
mik-laj edited a comment on issue #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax URL: https://github.com/apache/airflow/pull/7343#issuecomment-591949011 @zhongjiajie I don't have time to finish this, because I've taken care of the scheduler performance. Would you like

[jira] [Updated] (AIRFLOW-6947) UTF8mb4 encoding for mysql does not work in Airflow 2.0

2020-02-27 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-6947: -- Description: The problem is with how MySQL handles different encodings. Especially UTF8.

[jira] [Updated] (AIRFLOW-6947) UTF8mb4 encoding for mysql does not work in Airflow 2.0

2020-02-27 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-6947: -- Description: The problem is with how MySQL handles different encodings. Especially UTF8.

[GitHub] [airflow] zhongjiajie commented on a change in pull request #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax

2020-02-27 Thread GitBox
zhongjiajie commented on a change in pull request #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax URL: https://github.com/apache/airflow/pull/7343#discussion_r385092821 ## File path: airflow/providers/amazon/aws/operators/s3_delete_objects.py ## @@

[GitHub] [airflow] zhongjiajie commented on a change in pull request #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax

2020-02-27 Thread GitBox
zhongjiajie commented on a change in pull request #7343: [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax URL: https://github.com/apache/airflow/pull/7343#discussion_r385093470 ## File path: tests/providers/amazon/aws/operators/test_sftp_to_s3.py ## @@ -81,7

[GitHub] [airflow] baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385091513 ## File path: airflow/providers/amazon/aws/sensors/athena.py ## @@ -57,13 +57,11 @@ def

[GitHub] [airflow] baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385091780 ## File path: tests/providers/amazon/aws/operators/test_ecs.py ## @@ -48,12 +48,10 @@ ] }

[jira] [Updated] (AIRFLOW-6947) UTF8mb4 encoding for mysql does not work in Airflow 2.0

2020-02-27 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-6947: -- Description: The problem is with how MySQL handles different encodings. Especially UTF8.

[jira] [Created] (AIRFLOW-6947) UTF8mb4 encoding for mysql does not work in Airflow 2.0

2020-02-27 Thread Jarek Potiuk (Jira)
Jarek Potiuk created AIRFLOW-6947: - Summary: UTF8mb4 encoding for mysql does not work in Airflow 2.0 Key: AIRFLOW-6947 URL: https://issues.apache.org/jira/browse/AIRFLOW-6947 Project: Apache Airflow

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385081131 ## File path: airflow/providers/amazon/aws/sensors/sqs.py ## @@ -56,6 +56,7 @@ def

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385082524 ## File path: tests/providers/amazon/aws/operators/test_ecs.py ## @@ -48,12 +48,10 @@ ] }

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385080404 ## File path: airflow/providers/amazon/aws/sensors/athena.py ## @@ -57,13 +57,11 @@ def

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385087185 ## File path: airflow/providers/amazon/aws/hooks/base_aws.py ## @@ -47,11 +48,29 @@ class

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385083228 ## File path: tests/providers/amazon/aws/operators/test_ecs.py ## @@ -171,7 +166,7 @@ def

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385080772 ## File path: airflow/providers/amazon/aws/sensors/redshift.py ## @@ -43,9 +43,9 @@ def

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385089326 ## File path: airflow/providers/amazon/aws/hooks/base_aws.py ## @@ -232,6 +251,38 @@ def

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385084222 ## File path: airflow/providers/amazon/aws/hooks/athena.py ## @@ -28,8 +28,12 @@ class

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385080961 ## File path: airflow/providers/amazon/aws/sensors/s3_prefix.py ## @@ -69,12 +70,11 @@ def

[GitHub] [airflow] feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385083943 ## File path: tests/providers/amazon/aws/sensors/test_sqs.py ## @@ -18,8 +18,9 @@ import

[GitHub] [airflow] mik-laj commented on a change in pull request #7563: [AIRFLOW-6939] Executor configuration via import path

2020-02-27 Thread GitBox
mik-laj commented on a change in pull request #7563: [AIRFLOW-6939] Executor configuration via import path URL: https://github.com/apache/airflow/pull/7563#discussion_r385085663 ## File path: UPDATING.md ## @@ -61,6 +61,29 @@

[GitHub] [airflow] mik-laj commented on a change in pull request #7562: [AIRFLOW-6938] Don't read dag_directory in SchedulerJob

2020-02-27 Thread GitBox
mik-laj commented on a change in pull request #7562: [AIRFLOW-6938] Don't read dag_directory in SchedulerJob URL: https://github.com/apache/airflow/pull/7562#discussion_r385081097 ## File path: airflow/utils/dag_processing.py ## @@ -577,7 +566,7 @@ def __init__(self,

[GitHub] [airflow] kaxil commented on a change in pull request #7562: [AIRFLOW-6938] Don't read dag_directory in SchedulerJob

2020-02-27 Thread GitBox
kaxil commented on a change in pull request #7562: [AIRFLOW-6938] Don't read dag_directory in SchedulerJob URL: https://github.com/apache/airflow/pull/7562#discussion_r385076833 ## File path: airflow/utils/dag_processing.py ## @@ -577,7 +566,7 @@ def __init__(self,

[GitHub] [airflow] ashb commented on a change in pull request #7563: [AIRFLOW-6939] Executor configuration via import path

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7563: [AIRFLOW-6939] Executor configuration via import path URL: https://github.com/apache/airflow/pull/7563#discussion_r385076603 ## File path: UPDATING.md ## @@ -61,6 +61,29 @@

[GitHub] [airflow] feluelle commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-02-27 Thread GitBox
feluelle commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-591929366 Yes please rebase first. Yes, you are right - only remove your changes to the file.

[GitHub] [airflow] ashb commented on a change in pull request #7563: [AIRFLOW-6939] Executor configuration via import path

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7563: [AIRFLOW-6939] Executor configuration via import path URL: https://github.com/apache/airflow/pull/7563#discussion_r385075833 ## File path: UPDATING.md ## @@ -61,6 +61,29 @@

[GitHub] [airflow] blcksrx commented on issue #7422: [AIRFLOW-6809] Test for presto operators

2020-02-27 Thread GitBox
blcksrx commented on issue #7422: [AIRFLOW-6809] Test for presto operators URL: https://github.com/apache/airflow/pull/7422#issuecomment-591923291 @feluelle Done! This is an automated message from the Apache Git Service. To

[GitHub] [airflow] ashb commented on a change in pull request #7553: [AIRFLOW-XXXX] Update LICENSE versions and remove old licenses

2020-02-27 Thread GitBox
ashb commented on a change in pull request #7553: [AIRFLOW-] Update LICENSE versions and remove old licenses URL: https://github.com/apache/airflow/pull/7553#discussion_r385066087 ## File path: LICENSE ## @@ -229,36 +229,22 @@ MIT licenses The following components

[GitHub] [airflow] ashb commented on issue #7553: [AIRFLOW-XXXX] Update LICENSE versions and remove old licenses

2020-02-27 Thread GitBox
ashb commented on issue #7553: [AIRFLOW-] Update LICENSE versions and remove old licenses URL: https://github.com/apache/airflow/pull/7553#issuecomment-591919253 Twistlock really "detects" versions of code in use from what is mentioned in a license file? o_O

[GitHub] [airflow] baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#discussion_r385061503 ## File path: airflow/providers/amazon/aws/hooks/base_aws.py ## @@ -49,9 +50,19 @@ class

[GitHub] [airflow] codecov-io commented on issue #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-02-27 Thread GitBox
codecov-io commented on issue #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#issuecomment-591909170 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7541?src=pr=h1) Report > Merging

[jira] [Resolved] (AIRFLOW-6940) Improve test isolation in test_views.py

2020-02-27 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-6940. - Fix Version/s: 2.0.0 Resolution: Fixed > Improve test isolation in test_views.py >

[jira] [Commented] (AIRFLOW-6940) Improve test isolation in test_views.py

2020-02-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046464#comment-17046464 ] ASF subversion and git services commented on AIRFLOW-6940: -- Commit

[jira] [Commented] (AIRFLOW-6940) Improve test isolation in test_views.py

2020-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046463#comment-17046463 ] ASF GitHub Bot commented on AIRFLOW-6940: - kaxil commented on pull request #7564:

[jira] [Resolved] (AIRFLOW-5659) Add support for ephemeral storage on KubernetesPodOperator

2020-02-27 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-5659. - Fix Version/s: 2.0.0 Resolution: Fixed > Add support for ephemeral storage on

[GitHub] [airflow] kaxil merged pull request #7564: [AIRFLOW-6940] Improve test isolation in test_views.py

2020-02-27 Thread GitBox
kaxil merged pull request #7564: [AIRFLOW-6940] Improve test isolation in test_views.py URL: https://github.com/apache/airflow/pull/7564 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] kaxil merged pull request #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp…

2020-02-27 Thread GitBox
kaxil merged pull request #6337: [AIRFLOW-5659] - Add support for ephemeral storage on KubernetesPodOp… URL: https://github.com/apache/airflow/pull/6337 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (AIRFLOW-5659) Add support for ephemeral storage on KubernetesPodOperator

2020-02-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046462#comment-17046462 ] ASF subversion and git services commented on AIRFLOW-5659: -- Commit

[jira] [Commented] (AIRFLOW-5659) Add support for ephemeral storage on KubernetesPodOperator

2020-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046461#comment-17046461 ] ASF GitHub Bot commented on AIRFLOW-5659: - kaxil commented on pull request #6337:

[GitHub] [airflow] potiuk opened a new pull request #7570: [AIRFLOW-6946] [WIP] Switch to MySQL 5.7 in 2.0 as base

2020-02-27 Thread GitBox
potiuk opened a new pull request #7570: [AIRFLOW-6946] [WIP] Switch to MySQL 5.7 in 2.0 as base URL: https://github.com/apache/airflow/pull/7570 Switch to MySQL 5.7 in tests. Also test utf8mb4 encoding --- Issue link: WILL BE INSERTED BY

[jira] [Commented] (AIRFLOW-6946) Switch to MySQL 5.7 in 2.0 as base

2020-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046451#comment-17046451 ] ASF GitHub Bot commented on AIRFLOW-6946: - potiuk commented on pull request #7570:

[jira] [Updated] (AIRFLOW-6946) Switch to MySQL 5.7 in 2.0 as base

2020-02-27 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-6946: -- Description: Switch to MySQL 5.7 in tests.  Also test utf8mb4 encoding was:Switch to

[jira] [Created] (AIRFLOW-6946) Switch to MySQL 5.7 in 2.0 as base

2020-02-27 Thread Jarek Potiuk (Jira)
Jarek Potiuk created AIRFLOW-6946: - Summary: Switch to MySQL 5.7 in 2.0 as base Key: AIRFLOW-6946 URL: https://issues.apache.org/jira/browse/AIRFLOW-6946 Project: Apache Airflow Issue Type:

<    1   2   3   >