[jira] [Commented] (AIRFLOW-6481) SalesforceHook attempts to use .str accessor on object dtype

2020-03-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057615#comment-17057615 ] ASF GitHub Bot commented on AIRFLOW-6481: - TeddyHartanto commented on pull request #7703:

[GitHub] [airflow] baolsen commented on a change in pull request #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML

2020-03-11 Thread GitBox
baolsen commented on a change in pull request #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML URL: https://github.com/apache/airflow/pull/7619#discussion_r391410752 ## File path: airflow/providers/amazon/aws/hooks/base_aws.py ## @@ -206,6 +214,106 @@ def

[GitHub] [airflow] TeddyHartanto opened a new pull request #7703: [AIRFLOW-6481] Fix bug in SalesforceHook

2020-03-11 Thread GitBox
TeddyHartanto opened a new pull request #7703: [AIRFLOW-6481] Fix bug in SalesforceHook URL: https://github.com/apache/airflow/pull/7703 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before creating

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook

2020-03-11 Thread GitBox
boring-cyborg[bot] commented on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook URL: https://github.com/apache/airflow/pull/7703#issuecomment-598016137 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about

[GitHub] [airflow] kaxil merged pull request #7702: [AIRFLOW-XXXX] Update to the latest version of pre-commit-hooks

2020-03-11 Thread GitBox
kaxil merged pull request #7702: [AIRFLOW-] Update to the latest version of pre-commit-hooks URL: https://github.com/apache/airflow/pull/7702 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] baolsen commented on issue #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML

2020-03-11 Thread GitBox
baolsen commented on issue #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML URL: https://github.com/apache/airflow/pull/7619#issuecomment-598012580 > The `_assume_role_with_saml` method looks a bit _complex_ to me, because you are importing so many different libraries and you are

[jira] [Commented] (AIRFLOW-6481) SalesforceHook attempts to use .str accessor on object dtype

2020-03-11 Thread Teddy Hartanto (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057577#comment-17057577 ] Teddy Hartanto commented on AIRFLOW-6481: - [~dephusluke] on it > SalesforceHook attempts to

[jira] [Updated] (AIRFLOW-6481) SalesforceHook attempts to use .str accessor on object dtype

2020-03-11 Thread Teddy Hartanto (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Teddy Hartanto updated AIRFLOW-6481: Description: I've searched through Airflow's issues and couldn't find any report

[jira] [Assigned] (AIRFLOW-7043) CLONE - The mirrored data folder for BigQuery_operators can't be accessed on manual runs

2020-03-11 Thread Valerio Dacanal (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Valerio Dacanal reassigned AIRFLOW-7043: Assignee: (was: Valerio Dacanal) > CLONE - The mirrored data folder for

[jira] [Work started] (AIRFLOW-7043) CLONE - The mirrored data folder for BigQuery_operators can't be accessed on manual runs

2020-03-11 Thread Valerio Dacanal (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-7043 started by Valerio Dacanal. > CLONE - The mirrored data folder for BigQuery_operators can't be

[jira] [Created] (AIRFLOW-7043) CLONE - The mirrored data folder for BigQuery_operators can't be accessed on manual runs

2020-03-11 Thread Valerio Dacanal (Jira)
Valerio Dacanal created AIRFLOW-7043: Summary: CLONE - The mirrored data folder for BigQuery_operators can't be accessed on manual runs Key: AIRFLOW-7043 URL:

[GitHub] [airflow] codecov-io edited a comment on issue #7701: [AIRFLOW-XXXX] Wrap line under 110 characters

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7701: [AIRFLOW-] Wrap line under 110 characters URL: https://github.com/apache/airflow/pull/7701#issuecomment-597979053 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7701?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #7701: [AIRFLOW-XXXX] Wrap line under 110 characters

2020-03-11 Thread GitBox
codecov-io commented on issue #7701: [AIRFLOW-] Wrap line under 110 characters URL: https://github.com/apache/airflow/pull/7701#issuecomment-597979053 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7701?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil merged pull request #7696: [AIRFLOW-XXXX] Replace conversion from list to set

2020-03-11 Thread GitBox
kaxil merged pull request #7696: [AIRFLOW-] Replace conversion from list to set URL: https://github.com/apache/airflow/pull/7696 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] kaxil merged pull request #7697: [AIRFLOW-XXXX] Remove already solved items from pylint_todo.txt

2020-03-11 Thread GitBox
kaxil merged pull request #7697: [AIRFLOW-] Remove already solved items from pylint_todo.txt URL: https://github.com/apache/airflow/pull/7697 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] kaxil merged pull request #7698: [AIRFLOW-XXXX] Fix typo in tests/jobs/test_base_job.py

2020-03-11 Thread GitBox
kaxil merged pull request #7698: [AIRFLOW-] Fix typo in tests/jobs/test_base_job.py URL: https://github.com/apache/airflow/pull/7698 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] kaxil merged pull request #7699: [AIRFLOW-XXXX] Fix docstring in TestSchedulerJob

2020-03-11 Thread GitBox
kaxil merged pull request #7699: [AIRFLOW-] Fix docstring in TestSchedulerJob URL: https://github.com/apache/airflow/pull/7699 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] codecov-io edited a comment on issue #7698: [AIRFLOW-XXXX] Fix typo in tests/jobs/test_base_job.py

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7698: [AIRFLOW-] Fix typo in tests/jobs/test_base_job.py URL: https://github.com/apache/airflow/pull/7698#issuecomment-597965471 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7698?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7696: [AIRFLOW-XXXX] Replace conversion from list to set

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7696: [AIRFLOW-] Replace conversion from list to set URL: https://github.com/apache/airflow/pull/7696#issuecomment-597962633 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7696?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #7698: [AIRFLOW-XXXX] Fix typo in tests/jobs/test_base_job.py

2020-03-11 Thread GitBox
codecov-io commented on issue #7698: [AIRFLOW-] Fix typo in tests/jobs/test_base_job.py URL: https://github.com/apache/airflow/pull/7698#issuecomment-597965471 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7698?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7697: [AIRFLOW-XXXX] Remove already solved items from pylint_todo.txt

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7697: [AIRFLOW-] Remove already solved items from pylint_todo.txt URL: https://github.com/apache/airflow/pull/7697#issuecomment-597964595 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7697?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7697: [AIRFLOW-XXXX] Remove already solved items from pylint_todo.txt

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7697: [AIRFLOW-] Remove already solved items from pylint_todo.txt URL: https://github.com/apache/airflow/pull/7697#issuecomment-597964595 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7697?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #7697: [AIRFLOW-XXXX] Remove already solved items from pylint_todo.txt

2020-03-11 Thread GitBox
codecov-io commented on issue #7697: [AIRFLOW-] Remove already solved items from pylint_todo.txt URL: https://github.com/apache/airflow/pull/7697#issuecomment-597964595 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7697?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil opened a new pull request #7702: [AIRFLOW-XXXX] Update to the latest version of pre-commit-hooks

2020-03-11 Thread GitBox
kaxil opened a new pull request #7702: [AIRFLOW-] Update to the latest version of pre-commit-hooks URL: https://github.com/apache/airflow/pull/7702 The latest release is 2.5: https://github.com/pre-commit/pre-commit-hooks/releases --- Issue link: WILL BE INSERTED BY

[GitHub] [airflow] codecov-io edited a comment on issue #7696: [AIRFLOW-XXXX] Replace conversion from list to set

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7696: [AIRFLOW-] Replace conversion from list to set URL: https://github.com/apache/airflow/pull/7696#issuecomment-597962633 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7696?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #7696: [AIRFLOW-XXXX] Replace conversion from list to set

2020-03-11 Thread GitBox
codecov-io commented on issue #7696: [AIRFLOW-] Replace conversion from list to set URL: https://github.com/apache/airflow/pull/7696#issuecomment-597962633 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7696?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7696: [AIRFLOW-XXXX] Replace conversion from list to set

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7696: [AIRFLOW-] Replace conversion from list to set URL: https://github.com/apache/airflow/pull/7696#issuecomment-597962633 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7696?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on issue #7701: [AIRFLOW-XXXX] Wrap line under 110 characters

2020-03-11 Thread GitBox
kaxil commented on issue #7701: [AIRFLOW-] Wrap line under 110 characters URL: https://github.com/apache/airflow/pull/7701#issuecomment-597962297 > Why 90? We have a limit of 110 on all tools. You are right, updated the title

[GitHub] [airflow] mik-laj commented on issue #7701: [AIRFLOW-XXXX] Wrap line under 90 characters

2020-03-11 Thread GitBox
mik-laj commented on issue #7701: [AIRFLOW-] Wrap line under 90 characters URL: https://github.com/apache/airflow/pull/7701#issuecomment-597962001 Why 90? We have a limit of 110 on all tools. This is an automated message

[GitHub] [airflow] kaxil opened a new pull request #7701: [AIRFLOW-XXXX] Wrap line under 90 characters

2020-03-11 Thread GitBox
kaxil opened a new pull request #7701: [AIRFLOW-] Wrap line under 90 characters URL: https://github.com/apache/airflow/pull/7701 Wrap line under 90 characters --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark

[jira] [Commented] (AIRFLOW-7017) Respect default dag view on redirect after trigger

2020-03-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057508#comment-17057508 ] ASF GitHub Bot commented on AIRFLOW-7017: - kaxil commented on pull request #7667:

[GitHub] [airflow] kaxil merged pull request #7667: [AIRFLOW-7017] Respect default dag view in trigger dag origin.

2020-03-11 Thread GitBox
kaxil merged pull request #7667: [AIRFLOW-7017] Respect default dag view in trigger dag origin. URL: https://github.com/apache/airflow/pull/7667 This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (AIRFLOW-7017) Respect default dag view on redirect after trigger

2020-03-11 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-7017. - Fix Version/s: 1.10.10 Resolution: Fixed > Respect default dag view on redirect after

[GitHub] [airflow] codecov-io edited a comment on issue #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table URL: https://github.com/apache/airflow/pull/7633#issuecomment-596834730 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7633?src=pr=h1) Report

[GitHub] [airflow] codecov-io edited a comment on issue #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table URL: https://github.com/apache/airflow/pull/7633#issuecomment-596834730 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7633?src=pr=h1) Report

[GitHub] [airflow] kaxil opened a new pull request #7700: [AIRFLOW-XXXX] Fix broken link in backport_packages/README.md

2020-03-11 Thread GitBox
kaxil opened a new pull request #7700: [AIRFLOW-] Fix broken link in backport_packages/README.md URL: https://github.com/apache/airflow/pull/7700 Fix broken link in backport_packages/README.md --- Issue link: WILL BE INSERTED BY

[GitHub] [airflow] kaxil opened a new pull request #7699: [AIRFLOW-XXXX] Fix docstring in TestSchedulerJob

2020-03-11 Thread GitBox
kaxil opened a new pull request #7699: [AIRFLOW-] Fix docstring in TestSchedulerJob URL: https://github.com/apache/airflow/pull/7699 Fix docstring in TestSchedulerJob. Instead of `dags_folder` it was `directory` --- Issue link: WILL BE INSERTED BY

[GitHub] [airflow] kaxil opened a new pull request #7698: [AIRFLOW-XXXX] Fix typo in tests/jobs/test_base_job.py

2020-03-11 Thread GitBox
kaxil opened a new pull request #7698: [AIRFLOW-] Fix typo in tests/jobs/test_base_job.py URL: https://github.com/apache/airflow/pull/7698 Fix typo in tests/jobs/test_base_job.py --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)

[GitHub] [airflow] kaxil opened a new pull request #7697: [AIRFLOW-XXXX] Remove already solved items from pylint_todo.txt

2020-03-11 Thread GitBox
kaxil opened a new pull request #7697: [AIRFLOW-] Remove already solved items from pylint_todo.txt URL: https://github.com/apache/airflow/pull/7697 This files already pass pylint --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)

[GitHub] [airflow] kaxil opened a new pull request #7696: [AIRFLOW-XXXX] Replace conversion from list to set

2020-03-11 Thread GitBox
kaxil opened a new pull request #7696: [AIRFLOW-] Replace conversion from list to set URL: https://github.com/apache/airflow/pull/7696 ```python {ti_key} ``` is same as: ```python set([ti_key]) ``` We don't need to make a list and then convert it to set.

[GitHub] [airflow] kaxil commented on issue #7694: [AIRFLOW-5948][WIP] Replace SimpleDag with SerializedDag

2020-03-11 Thread GitBox
kaxil commented on issue #7694: [AIRFLOW-5948][WIP] Replace SimpleDag with SerializedDag URL: https://github.com/apache/airflow/pull/7694#issuecomment-597946217 > this is great, I assume we are going to consolidate with single serde form in the future for Airflow which is json? > >

[GitHub] [airflow] kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-11 Thread GitBox
kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391342005 ## File path: airflow/models/renderedtifields.py ## @@ -0,0 +1,135 @@ +#

[GitHub] [airflow] kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-11 Thread GitBox
kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391341287 ## File path: tests/models/test_renderedtifields.py ## @@ -0,0 +1,217 @@

[GitHub] [airflow] kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-11 Thread GitBox
kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391341255 ## File path: airflow/models/renderedtifields.py ## @@ -0,0 +1,135 @@ +#

[GitHub] [airflow] feng-tao commented on issue #7694: [AIRFLOW-5948][WIP] Replace SimpleDag with SerializedDag

2020-03-11 Thread GitBox
feng-tao commented on issue #7694: [AIRFLOW-5948][WIP] Replace SimpleDag with SerializedDag URL: https://github.com/apache/airflow/pull/7694#issuecomment-597944091 this is great, I assume we are going to consolidate with single serde form in the future for Airflow which is json?

[GitHub] [airflow] kaxil opened a new pull request #7695: [AIRFLOW-XXXX] Change CONTRIBUTING.md to CONTRIBUTING.rst

2020-03-11 Thread GitBox
kaxil opened a new pull request #7695: [AIRFLOW-] Change CONTRIBUTING.md to CONTRIBUTING.rst URL: https://github.com/apache/airflow/pull/7695 - Remove CONTRIBUTING.md - Update mentions of CONTRIBUTING.md --- Issue link: WILL BE INSERTED BY

[GitHub] [airflow] mik-laj commented on a change in pull request #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table URL: https://github.com/apache/airflow/pull/7633#discussion_r391323795 ## File path: airflow/models/renderedtifields.py ## @@

[GitHub] [airflow] mik-laj commented on a change in pull request #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table URL: https://github.com/apache/airflow/pull/7633#discussion_r391323555 ## File path: airflow/models/renderedtifields.py ## @@

[GitHub] [airflow] dferguson992 commented on issue #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor

2020-03-11 Thread GitBox
dferguson992 commented on issue #7407: [AIRFLOW-6786] Add KafkaConsumerHook, KafkaProduerHook and KafkaSensor URL: https://github.com/apache/airflow/pull/7407#issuecomment-597912749 hey @ashb I'm not sure what else to do for this PR. Is there anything outstanding before it can be merged?

[GitHub] [airflow] codecov-io edited a comment on issue #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#issuecomment-597902794 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7674?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#issuecomment-597902794 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7674?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
codecov-io commented on issue #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#issuecomment-597902794 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7674?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-11 Thread GitBox
ashb commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391286629 ## File path: airflow/models/renderedtifields.py ## @@ -0,0 +1,135 @@ +# +#

[GitHub] [airflow] ashb commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-11 Thread GitBox
ashb commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391286829 ## File path: airflow/models/renderedtifields.py ## @@ -0,0 +1,135 @@ +# +#

[jira] [Commented] (AIRFLOW-5948) Replace SimpleDag with serialized version

2020-03-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057405#comment-17057405 ] ASF GitHub Bot commented on AIRFLOW-5948: - kaxil commented on pull request #7694: WIP:

[GitHub] [airflow] kaxil opened a new pull request #7694: WIP: [AIRFLOW-5948] Replace SimpleDag with SerializedDag

2020-03-11 Thread GitBox
kaxil opened a new pull request #7694: WIP: [AIRFLOW-5948] Replace SimpleDag with SerializedDag URL: https://github.com/apache/airflow/pull/7694 Replace SimpleDag with serialized version (json over multiprocessing) in SchedulerJob etc., no other change in scheduler behaviour. (This

[GitHub] [airflow] mik-laj commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391273748 ## File path: tests/models/test_renderedtifields.py ## @@ -0,0 +1,217 @@

[GitHub] [airflow] mik-laj commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391268396 ## File path: airflow/models/renderedtifields.py ## @@ -0,0 +1,135 @@ +#

[GitHub] [airflow] mik-laj commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391272463 ## File path: airflow/models/renderedtifields.py ## @@ -0,0 +1,135 @@ +#

[GitHub] [airflow] mik-laj commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391271079 ## File path: airflow/models/renderedtifields.py ## @@ -0,0 +1,135 @@ +#

[jira] [Assigned] (AIRFLOW-5610) Add ability to specify multiple objects to copy to GoogleCloudStorageToGoogleCloudStorageOperator

2020-03-11 Thread Ephraim E Anierobi (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ephraim E Anierobi reassigned AIRFLOW-5610: --- Assignee: Ephraim E Anierobi > Add ability to specify multiple objects to

[GitHub] [airflow] mik-laj commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391268396 ## File path: airflow/models/renderedtifields.py ## @@ -0,0 +1,135 @@ +#

[GitHub] [airflow] mik-laj commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#discussion_r391266670 ## File path: airflow/jobs/scheduler_job.py ## @@ -845,11 +845,11 @@ def process_file(

[GitHub] [airflow] mik-laj commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#discussion_r391266639 ## File path: airflow/jobs/scheduler_job.py ## @@ -845,11 +845,11 @@ def process_file(

[GitHub] [airflow] rebeccasg commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator

2020-03-11 Thread GitBox
rebeccasg commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator URL: https://github.com/apache/airflow/pull/7630#discussion_r391261027 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py ##

[jira] [Commented] (AIRFLOW-3981) Make Airflow UI timezone aware

2020-03-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057369#comment-17057369 ] ASF GitHub Bot commented on AIRFLOW-3981: - samblackk commented on pull request #7693:

[GitHub] [airflow] samblackk opened a new pull request #7693: [AIRFLOW-3981] Locale-formatted datetimes (UI only)

2020-03-11 Thread GitBox
samblackk opened a new pull request #7693: [AIRFLOW-3981] Locale-formatted datetimes (UI only) URL: https://github.com/apache/airflow/pull/7693 In addition to Airflow being timezone aware, this PR handles formatting datetime in the UI. This PR **does not** modify the timestamps to

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7693: [AIRFLOW-3981] Locale-formatted datetimes (UI only)

2020-03-11 Thread GitBox
boring-cyborg[bot] commented on issue #7693: [AIRFLOW-3981] Locale-formatted datetimes (UI only) URL: https://github.com/apache/airflow/pull/7693#issuecomment-597870743 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are

[GitHub] [airflow] kaxil commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
kaxil commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#discussion_r391227897 ## File path: airflow/jobs/scheduler_job.py ## @@ -845,11 +845,11 @@ def process_file(

[GitHub] [airflow] kaxil commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
kaxil commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#discussion_r391228009 ## File path: airflow/jobs/scheduler_job.py ## @@ -845,11 +845,11 @@ def process_file(

[GitHub] [airflow] kaxil commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
kaxil commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#discussion_r391227796 ## File path: airflow/jobs/scheduler_job.py ## @@ -845,11 +845,11 @@ def process_file(

[GitHub] [airflow] mik-laj commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#discussion_r391221756 ## File path: tests/jobs/test_scheduler_job.py ## @@ -1057,6 +1057,31 @@ def

[GitHub] [airflow] codecov-io edited a comment on issue #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#issuecomment-597447171 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7688?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#issuecomment-597447171 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7688?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
codecov-io edited a comment on issue #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#issuecomment-597447171 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7688?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
ashb commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#discussion_r391159188 ## File path: tests/jobs/test_scheduler_job.py ## @@ -1057,6 +1057,31 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
ashb commented on a change in pull request #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#discussion_r391158278 ## File path: tests/jobs/test_scheduler_job.py ## @@ -1057,6 +1057,31 @@ def

[GitHub] [airflow] ashb commented on issue #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method

2020-03-11 Thread GitBox
ashb commented on issue #7674: [AIRFLOW-7022] Simplify DagFileProcessor.process_file method URL: https://github.com/apache/airflow/pull/7674#issuecomment-59026 Thanks for doing them as fixup commits @mik-laj -- I think we (comitters) should get more in the habit of it, makes re-review

[GitHub] [airflow] codecov-io commented on issue #7689: [AIRFLOW-7038] Cassandra sensors tests

2020-03-11 Thread GitBox
codecov-io commented on issue #7689: [AIRFLOW-7038] Cassandra sensors tests URL: https://github.com/apache/airflow/pull/7689#issuecomment-597755068 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7689?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-6788) Improve the instructions for getting started with Postgres

2020-03-11 Thread HaloKu (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057200#comment-17057200 ] HaloKu commented on AIRFLOW-6788: - came across this one and had to reply. You do realise that this is

[jira] [Commented] (AIRFLOW-3653) Pausing a Dag does not pause its SubDags

2020-03-11 Thread HaloKu (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057198#comment-17057198 ] HaloKu commented on AIRFLOW-3653: - [~lbronshtein] I don't run 1.10.4 so I can't confirm. If this is

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-11 Thread GitBox
nuclearpinguin commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391081579 ## File path: airflow/providers/google/marketing_platform/hooks/google_ads.py ##

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-11 Thread GitBox
nuclearpinguin commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391088292 ## File path:

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-11 Thread GitBox
nuclearpinguin commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391087275 ## File path: airflow/providers/google/marketing_platform/operators/google_ads.py

[GitHub] [airflow] codecov-io commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

2020-03-11 Thread GitBox
codecov-io commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op URL: https://github.com/apache/airflow/pull/7685#issuecomment-597723193 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7685?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

2020-03-11 Thread GitBox
potiuk commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op URL: https://github.com/apache/airflow/pull/7685#issuecomment-597717437 Restarted This is an automated message from the

[GitHub] [airflow] zhongjiajie commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

2020-03-11 Thread GitBox
zhongjiajie commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op URL: https://github.com/apache/airflow/pull/7685#issuecomment-597714613 FYI, CI failed without more detail, should restart it to retest

[GitHub] [airflow] swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391071044 ## File path: UPDATING.md ## @@ -1047,6 +1047,20 @@ If the DAG

[GitHub] [airflow] mik-laj commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391064247 ## File path: UPDATING.md ## @@ -1047,6 +1047,24 @@ If the DAG relies

[GitHub] [airflow] swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391059082 ## File path: tests/providers/amazon/aws/operators/test_redshift_to_s3.py

[GitHub] [airflow] swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391056490 ## File path: UPDATING.md ## @@ -1047,6 +1047,24 @@ If the DAG

[GitHub] [airflow] mik-laj commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391052165 ## File path: UPDATING.md ## @@ -1047,6 +1047,20 @@ If the DAG relies

[GitHub] [airflow] mik-laj commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391051551 ## File path: UPDATING.md ## @@ -1047,6 +1047,24 @@ If the DAG relies

[GitHub] [airflow] mik-laj commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
mik-laj commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391051551 ## File path: UPDATING.md ## @@ -1047,6 +1047,24 @@ If the DAG relies

[GitHub] [airflow] swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391046137 ## File path: UPDATING.md ## @@ -1047,6 +1047,24 @@ If the DAG

[GitHub] [airflow] swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391044835 ## File path: UPDATING.md ## @@ -1047,6 +1047,24 @@ If the DAG

[GitHub] [airflow] swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391045710 ## File path: UPDATING.md ## @@ -1047,6 +1047,24 @@ If the DAG

[GitHub] [airflow] swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391044835 ## File path: UPDATING.md ## @@ -1047,6 +1047,24 @@ If the DAG

[GitHub] [airflow] swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391036023 ## File path: airflow/providers/amazon/aws/operators/redshift_to_s3.py

[GitHub] [airflow] swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query

2020-03-11 Thread GitBox
swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS Operator RedshiftToS3Transfer To Run a Custom Query URL: https://github.com/apache/airflow/pull/7688#discussion_r391035372 ## File path: UPDATING.md ## @@ -1047,6 +1047,20 @@ If the DAG

  1   2   >