[GitHub] [airflow] jhtimmins edited a comment on pull request #8680: Add metric for start/end task run

2020-05-21 Thread GitBox
jhtimmins edited a comment on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632485204 Hi @Acehaidrey, sorry been heads down with 3.8 stuff. Happy to take a look tomorrow. thanks for pinging me. Same for @dimberman for your other PR.

[GitHub] [airflow] jhtimmins commented on pull request #8680: Add metric for start/end task run

2020-05-21 Thread GitBox
jhtimmins commented on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632485204 Hi @Acehaidrey, sorry been heads down with 3.8 stuff. Happy to take a look tomorrow. thanks for pinging me.

[GitHub] [airflow] Acehaidrey commented on pull request #8680: Add metric for start/end task run

2020-05-21 Thread GitBox
Acehaidrey commented on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632478686 @ashb @jhtimmins mind helping me close this one out? This is an automated message from the Apache Git

[GitHub] [airflow] Acehaidrey commented on pull request #8702: Add context to execution_date_fn in ExternalTaskSensor

2020-05-21 Thread GitBox
Acehaidrey commented on pull request #8702: URL: https://github.com/apache/airflow/pull/8702#issuecomment-632476755 @dimberman can you please review this again so we can get it completed. Thank you @ashb for looking over this and approving

[GitHub] [airflow] samuelkhtu commented on pull request #8942: #8525 Add SQL Branch Operator

2020-05-21 Thread GitBox
samuelkhtu commented on pull request #8942: URL: https://github.com/apache/airflow/pull/8942#issuecomment-632474847 Hi @eladkal , the PR is ready to review again. Please take a look when you have a chance. Thanks! This is

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8964: [workaround]add a method:get k8s 'Exit Code' after k8s log stream int…

2020-05-21 Thread GitBox
boring-cyborg[bot] commented on pull request #8964: URL: https://github.com/apache/airflow/pull/8964#issuecomment-632468316 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] ywan2017 opened a new pull request #8964: [workaround]add a method:get k8s 'Exit Code' after k8s log stream int…

2020-05-21 Thread GitBox
ywan2017 opened a new pull request #8964: URL: https://github.com/apache/airflow/pull/8964 #8963 ## Description I use airflow to schedule spark jobs on k8s using SparkSubmitOperator. when spark jobs run on k8s for long time (>30mins), airflow often mark job failed status

[airflow] tag nightly-master updated (2121f49 -> 94a7673)

2020-05-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from 2121f49 (commit) to 94a7673 (commit) from

[GitHub] [airflow] MNic commented on issue #8494: TriggerDagOperator sometimes causes database to trigger UniqueViolation constraint

2020-05-21 Thread GitBox
MNic commented on issue #8494: URL: https://github.com/apache/airflow/issues/8494#issuecomment-632441166 We're having the same issue when trying to trigger the same DAG twice in a second. We're using the CLI to trigger but it doesn't expose the `replace_microseconds` param. Would

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8963: SparkSubmitOperator could not get Exit Code after log stream interrupted by k8s old resource version exception

2020-05-21 Thread GitBox
boring-cyborg[bot] commented on issue #8963: URL: https://github.com/apache/airflow/issues/8963#issuecomment-632429783 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] ywan2017 opened a new issue #8963: SparkSubmitOperator could not get Exit Code after log stream interrupted by k8s old resource version exception

2020-05-21 Thread GitBox
ywan2017 opened a new issue #8963: URL: https://github.com/apache/airflow/issues/8963 # SparkSubmitOperator could not get Exit Code after log stream interrupted by k8s old resource version exception ## description I use airflow to schedule spark jobs on k8s using

[GitHub] [airflow] kweitzner edited a comment on issue #8923: Google AdManager

2020-05-21 Thread GitBox
kweitzner edited a comment on issue #8923: URL: https://github.com/apache/airflow/issues/8923#issuecomment-632429124 Very interested in this, I built my own based off Concorde airflow plug-in, but I have low experience with airflow right now.

[GitHub] [airflow] kweitzner commented on issue #8923: Google AdManager

2020-05-21 Thread GitBox
kweitzner commented on issue #8923: URL: https://github.com/apache/airflow/issues/8923#issuecomment-632429124 Very interested in this, I built my own based off Concorde airflow plug-in, but I have low experience with airflow right.

[GitHub] [airflow] yuqian90 commented on pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-05-21 Thread GitBox
yuqian90 commented on pull request #8867: URL: https://github.com/apache/airflow/pull/8867#issuecomment-632423049 Thanks. I commented about some small fixes to the doc inline. Please investigate the `continuous-integration/travis-ci/pr` failure and I'll accept once it passes.

[GitHub] [airflow] yuqian90 commented on a change in pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-05-21 Thread GitBox
yuqian90 commented on a change in pull request #8867: URL: https://github.com/apache/airflow/pull/8867#discussion_r428992336 ## File path: UPDATING.md ## @@ -62,6 +62,17 @@ https://developers.google.com/style/inclusive-documentation --> +### BaseSensorOperator to make

[GitHub] [airflow] casassg commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-21 Thread GitBox
casassg commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r428991468 ## File path: airflow/operators/python.py ## @@ -145,6 +147,141 @@ def execute_callable(self): return self.python_callable(*self.op_args,

[GitHub] [airflow] yuqian90 commented on pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-05-21 Thread GitBox
yuqian90 commented on pull request #8867: URL: https://github.com/apache/airflow/pull/8867#issuecomment-632418891 Can you look into "continuous-integration/travis-ci/pr — The Travis CI build failed" ? The build should not be failing. Try rebase onto the latest origin master and push

[GitHub] [airflow] casassg commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-21 Thread GitBox
casassg commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r428975003 ## File path: airflow/operators/python.py ## @@ -145,6 +147,141 @@ def execute_callable(self): return self.python_callable(*self.op_args,

[GitHub] [airflow] casassg commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-21 Thread GitBox
casassg commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r428972097 ## File path: airflow/operators/python.py ## @@ -145,6 +147,141 @@ def execute_callable(self): return self.python_callable(*self.op_args,

[GitHub] [airflow] casassg commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-21 Thread GitBox
casassg commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r428968991 ## File path: airflow/models/xcom_arg.py ## @@ -83,7 +83,7 @@ def __getitem__(self, item): """ Implements xcomresult['some_result_key']

[GitHub] [airflow] aoen commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-21 Thread GitBox
aoen commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r428954360 ## File path: airflow/operators/python.py ## @@ -145,6 +147,141 @@ def execute_callable(self): return self.python_callable(*self.op_args,

[airflow] branch v1-10-test updated: Cache 1 10 ci images (#8955) (#8959)

2020-05-21 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-test by this push: new 179fbb6 Cache 1 10 ci images (#8955)

[GitHub] [airflow] ashb commented on pull request #8904: Move Kubernetes modules out of contrib to match 2.0 layout

2020-05-21 Thread GitBox
ashb commented on pull request #8904: URL: https://github.com/apache/airflow/pull/8904#issuecomment-632373196 @dimberman Needs rebasing now please. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb merged pull request #8959: Cache 1 10 ci images (#8955)

2020-05-21 Thread GitBox
ashb merged pull request #8959: URL: https://github.com/apache/airflow/pull/8959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] casassg opened a new pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-21 Thread GitBox
casassg opened a new pull request #8962: URL: https://github.com/apache/airflow/pull/8962 Airflow [AIP-31](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-31:+Airflow+functional+DAG+definition) task decorator implementation. This decorator should facilitate wrapping a function

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-21 Thread GitBox
boring-cyborg[bot] commented on pull request #8962: URL: https://github.com/apache/airflow/pull/8962#issuecomment-632362835 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8961: Fix the dag_id fetching for /taskinstance/list UI page

2020-05-21 Thread GitBox
boring-cyborg[bot] commented on pull request #8961: URL: https://github.com/apache/airflow/pull/8961#issuecomment-632362157 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] pyuelee opened a new pull request #8961: Fix the dag_id fetching for /taskinstance/list UI page

2020-05-21 Thread GitBox
pyuelee opened a new pull request #8961: URL: https://github.com/apache/airflow/pull/8961 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] mik-laj opened a new pull request #8960: Remove side-effect in test_get_dag_code

2020-05-21 Thread GitBox
mik-laj opened a new pull request #8960: URL: https://github.com/apache/airflow/pull/8960 To trigger a side effect, run the following command ```bash pytest tests/www/api/experimental/test_endpoints.py::TestApiExperimental_1_True::test_get_dag_code --with-db-init ``` ---

[airflow] branch master updated (dd72040 -> 94a7673)

2020-05-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from dd72040 Pin Version of Azure Cosmos to <4 (#8956) add 94a7673 Pin google-cloud-datacatalog to <0.8

[GitHub] [airflow] kaxil merged pull request #8957: Pin google-cloud-datacatalog to <0.8

2020-05-21 Thread GitBox
kaxil merged pull request #8957: URL: https://github.com/apache/airflow/pull/8957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] snazzyfox commented on issue #8933: pyhive is installed without Hive dependencies

2020-05-21 Thread GitBox
snazzyfox commented on issue #8933: URL: https://github.com/apache/airflow/issues/8933#issuecomment-632345025 Yep, but `pyhive` is still needed for Hive. But since airflow is installing it without hive support, it's not actually usable unless packages for hive support are installed

[airflow] branch master updated (90a07d8 -> dd72040)

2020-05-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 90a07d8 Cache 1 10 ci images (#8955) add dd72040 Pin Version of Azure Cosmos to <4 (#8956) No new

[GitHub] [airflow] kaxil merged pull request #8956: Pin Version of Azure Cosmos to <4

2020-05-21 Thread GitBox
kaxil merged pull request #8956: URL: https://github.com/apache/airflow/pull/8956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on pull request #8928: Bump httplib2 from 0.17.3 to 0.18.0 in /requirements

2020-05-21 Thread GitBox
potiuk commented on pull request #8928: URL: https://github.com/apache/airflow/pull/8928#issuecomment-632336230 I am afraid it only works with setup.py where we do not have open-ended conditions. We have quite a bit too complex setup trying to be both library and app,

[GitHub] [airflow] potiuk commented on pull request #8958: Add caching

2020-05-21 Thread GitBox
potiuk commented on pull request #8958: URL: https://github.com/apache/airflow/pull/8958#issuecomment-632333728 I am quite sure it's not :) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk commented on pull request #8957: Pin google-cloud-datacatalog to <0.8

2020-05-21 Thread GitBox
potiuk commented on pull request #8957: URL: https://github.com/apache/airflow/pull/8957#issuecomment-632332841 Needs py3.7 update as well. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] ashb commented on pull request #8958: Add caching

2020-05-21 Thread GitBox
ashb commented on pull request #8958: URL: https://github.com/apache/airflow/pull/8958#issuecomment-632332155 Not sure what's in this... But not sure it's what you wanted to do :) This is an automated message from the Apache

[GitHub] [airflow] dimberman opened a new pull request #8958: Add caching

2020-05-21 Thread GitBox
dimberman opened a new pull request #8958: URL: https://github.com/apache/airflow/pull/8958 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] dimberman opened a new pull request #8959: Cache 1 10 ci images (#8955)

2020-05-21 Thread GitBox
dimberman opened a new pull request #8959: URL: https://github.com/apache/airflow/pull/8959 * Push CI images to Docker packcage cache for v1-10 branches This is done as a commit to master so that we can keep the two branches in sync Co-Authored-By: Ash Berlin-Taylor

[airflow] branch master updated (113982b -> 90a07d8)

2020-05-21 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 113982b Make scheduler_dag_execution_timing grok dynamic start date of elastic dag (#8952) add 90a07d8

[GitHub] [airflow] dimberman merged pull request #8955: Cache 1 10 ci images

2020-05-21 Thread GitBox
dimberman merged pull request #8955: URL: https://github.com/apache/airflow/pull/8955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] kaxil commented on pull request #8956: Pin Version of Azure Cosmos to <4

2020-05-21 Thread GitBox
kaxil commented on pull request #8956: URL: https://github.com/apache/airflow/pull/8956#issuecomment-632318615 Created a followup PR: https://github.com/apache/airflow/pull/8957 This is an automated message from the Apache

[GitHub] [airflow] kaxil opened a new pull request #8957: Pin google-cloud-datacatalog to <0.8

2020-05-21 Thread GitBox
kaxil opened a new pull request #8957: URL: https://github.com/apache/airflow/pull/8957 Depends on https://github.com/apache/airflow/pull/8956. `field_path` was renamed to `tag_template_field_path` in >=0.8 and there might be other unknown errors --- Make sure to mark

[GitHub] [airflow] mik-laj commented on pull request #8651: [AIP-31] [AIRFLOW-8058] Retrieve current execution context without altering function's signature

2020-05-21 Thread GitBox
mik-laj commented on pull request #8651: URL: https://github.com/apache/airflow/pull/8651#issuecomment-632315068 I still don't understand why the additional execution context is configured as a global option. In my opinion, it is worth each task could have its own separate contexts. In

[GitHub] [airflow] kaxil commented on pull request #8956: Pin Version of Azure Cosmos to <4

2020-05-21 Thread GitBox
kaxil commented on pull request #8956: URL: https://github.com/apache/airflow/pull/8956#issuecomment-63239 Aah that is because Datacatalogclinet released new version too :( This is an automated message from the Apache

[GitHub] [airflow] kaxil commented on pull request #8956: Pin Version of Azure Cosmos to <4

2020-05-21 Thread GitBox
kaxil commented on pull request #8956: URL: https://github.com/apache/airflow/pull/8956#issuecomment-632310470 I am not sure why the test is failing: ``` * Module airflow.providers.google.cloud.hooks.datacatalog

[GitHub] [airflow] jaketf commented on a change in pull request #8954: Wait for pipeline state in Data Fusion operators

2020-05-21 Thread GitBox
jaketf commented on a change in pull request #8954: URL: https://github.com/apache/airflow/pull/8954#discussion_r428873640 ## File path: airflow/providers/google/cloud/hooks/datafusion.py ## @@ -67,6 +85,49 @@ def wait_for_operation(self, operation: Dict[str, Any]) ->

[GitHub] [airflow] ashb commented on a change in pull request #8955: Cache 1 10 ci images

2020-05-21 Thread GitBox
ashb commented on a change in pull request #8955: URL: https://github.com/apache/airflow/pull/8955#discussion_r428870688 ## File path: .github/workflows/ci.yml ## @@ -358,7 +358,10 @@ jobs: - prepare-backport-packages - build-prod-image - docs -if:

[GitHub] [airflow] ashb commented on a change in pull request #8955: Cache 1 10 ci images

2020-05-21 Thread GitBox
ashb commented on a change in pull request #8955: URL: https://github.com/apache/airflow/pull/8955#discussion_r428870376 ## File path: .github/workflows/ci.yml ## @@ -358,7 +358,10 @@ jobs: - prepare-backport-packages - build-prod-image - docs -if:

[GitHub] [airflow] dimberman commented on a change in pull request #8955: Cache 1 10 ci images

2020-05-21 Thread GitBox
dimberman commented on a change in pull request #8955: URL: https://github.com/apache/airflow/pull/8955#discussion_r428870499 ## File path: .github/workflows/ci.yml ## @@ -358,7 +358,10 @@ jobs: - prepare-backport-packages - build-prod-image - docs -

[GitHub] [airflow] dimberman commented on a change in pull request #8955: Cache 1 10 ci images

2020-05-21 Thread GitBox
dimberman commented on a change in pull request #8955: URL: https://github.com/apache/airflow/pull/8955#discussion_r428870285 ## File path: .github/workflows/ci.yml ## @@ -358,7 +358,10 @@ jobs: - prepare-backport-packages - build-prod-image - docs -

[GitHub] [airflow] dimberman commented on a change in pull request #8955: Cache 1 10 ci images

2020-05-21 Thread GitBox
dimberman commented on a change in pull request #8955: URL: https://github.com/apache/airflow/pull/8955#discussion_r428870171 ## File path: .github/workflows/ci.yml ## @@ -358,7 +358,10 @@ jobs: - prepare-backport-packages - build-prod-image - docs -

[GitHub] [airflow] ashb commented on a change in pull request #8955: Cache 1 10 ci images

2020-05-21 Thread GitBox
ashb commented on a change in pull request #8955: URL: https://github.com/apache/airflow/pull/8955#discussion_r428869862 ## File path: .github/workflows/ci.yml ## @@ -358,7 +358,10 @@ jobs: - prepare-backport-packages - build-prod-image - docs -if:

[GitHub] [airflow] VijayantSoni commented on pull request #8701: Adding ElastiCache Hook for creating, describing and deleting replication groups

2020-05-21 Thread GitBox
VijayantSoni commented on pull request #8701: URL: https://github.com/apache/airflow/pull/8701#issuecomment-632303195 rebased with latest upstream master hence the force push This is an automated message from the Apache Git

[GitHub] [airflow] dimberman commented on pull request #8955: Cache 1 10 ci images

2020-05-21 Thread GitBox
dimberman commented on pull request #8955: URL: https://github.com/apache/airflow/pull/8955#issuecomment-632302103 @potiuk sounds good changed to just 1-10-test This is an automated message from the Apache Git Service. To

[GitHub] [airflow] kaxil opened a new pull request #8956: Pin Version of Azure Cosmos to <4

2020-05-21 Thread GitBox
kaxil opened a new pull request #8956: URL: https://github.com/apache/airflow/pull/8956 Old Repo: https://github.com/Azure/azure-cosmos-python New Repo: https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/cosmos/azure-cosmos azure-cosmos==4.0.0 was released on 20 May

[GitHub] [airflow] dimberman opened a new pull request #8955: Cache 1 10 ci images

2020-05-21 Thread GitBox
dimberman opened a new pull request #8955: URL: https://github.com/apache/airflow/pull/8955 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed for documentation

[airflow] branch v1-10-test updated: Fix new flake8 warnings on v1-10-test branch (#8953)

2020-05-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-test by this push: new 4bccfd5 Fix new flake8 warnings on

[GitHub] [airflow] kaxil merged pull request #8953: Fix new flake8 warnings on v1-10-test branch.

2020-05-21 Thread GitBox
kaxil merged pull request #8953: URL: https://github.com/apache/airflow/pull/8953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] ashb commented on pull request #8928: Bump httplib2 from 0.17.3 to 0.18.0 in /requirements

2020-05-21 Thread GitBox
ashb commented on pull request #8928: URL: https://github.com/apache/airflow/pull/8928#issuecomment-632260870 I wonder if we can point it at setup.py only... (_And_ have it understand the versions in it) This is an

[GitHub] [airflow] samuelkhtu commented on a change in pull request #8942: #8525 Add SQL Branch Operator

2020-05-21 Thread GitBox
samuelkhtu commented on a change in pull request #8942: URL: https://github.com/apache/airflow/pull/8942#discussion_r428794914 ## File path: airflow/operators/sql_branch_operator.py ## @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] ashb commented on pull request #8953: Fix new flake8 warnings on v1-10-test branch.

2020-05-21 Thread GitBox
ashb commented on pull request #8953: URL: https://github.com/apache/airflow/pull/8953#issuecomment-632229695 There we go, static checks passing now. This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] turbaszek opened a new pull request #8954: Wait for pipeline state in Data Fusion operators

2020-05-21 Thread GitBox
turbaszek opened a new pull request #8954: URL: https://github.com/apache/airflow/pull/8954 Closes: #8673 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [ ] Unit tests coverage for changes (not

[GitHub] [airflow] RohitR1 commented on a change in pull request #8777: Add Production Helm chart support

2020-05-21 Thread GitBox
RohitR1 commented on a change in pull request #8777: URL: https://github.com/apache/airflow/pull/8777#discussion_r428741660 ## File path: chart/values.yaml ## @@ -0,0 +1,438 @@ +# Default values for airflow. +# This is a YAML-formatted file. +# Declare variables to be passed

[GitHub] [airflow] ashb commented on pull request #8739: Test that DagFileProcessor can operator against on a Serialized DAG

2020-05-21 Thread GitBox
ashb commented on pull request #8739: URL: https://github.com/apache/airflow/pull/8739#issuecomment-632164460 Just the Travis/Kube tests failing now. And they have been doing that for a while now :( This is an automated

[GitHub] [airflow] ashb opened a new pull request #8953: Fix new flake8 warnings on v1-10-test branch.

2020-05-21 Thread GitBox
ashb opened a new pull request #8953: URL: https://github.com/apache/airflow/pull/8953 Flake8 released a new version, and we have some new issues to fix in 1.10 branches. --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides

[GitHub] [airflow] mik-laj commented on issue #8620: Transfer operators and division into providers

2020-05-21 Thread GitBox
mik-laj commented on issue #8620: URL: https://github.com/apache/airflow/issues/8620#issuecomment-632135416 @potiuk Fantastic! Let me know if you start work. I will be happy to help with reviews. This is an automated

[GitHub] [airflow] mik-laj commented on issue #8899: Get UI color of operators from airflow.cfg

2020-05-21 Thread GitBox
mik-laj commented on issue #8899: URL: https://github.com/apache/airflow/issues/8899#issuecomment-632133779 @JavierLTPromofarma Have you tried to set a cluster policy? I think it should work. https://airflow.readthedocs.io/en/latest/concepts.html#cluster-policy

[airflow] branch master updated (b26b3ca -> 113982b)

2020-05-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from b26b3ca Don't hard-code constants in scheduler_dag_execution_timing (#8950) add 113982b Make

[GitHub] [airflow] kaxil merged pull request #8952: Make scheduler_dag_execution_timing grok dynamic start date of elastic dag

2020-05-21 Thread GitBox
kaxil merged pull request #8952: URL: https://github.com/apache/airflow/pull/8952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] zachliu commented on a change in pull request #8944: Update example webserver_config.py to show correct CSRF config

2020-05-21 Thread GitBox
zachliu commented on a change in pull request #8944: URL: https://github.com/apache/airflow/pull/8944#discussion_r428683403 ## File path: airflow/config_templates/default_webserver_config.py ## @@ -34,7 +34,7 @@ SQLALCHEMY_DATABASE_URI = conf.get('core', 'SQL_ALCHEMY_CONN')

[GitHub] [airflow] ashb opened a new pull request #8952: Make scheduler_dag_execution_timing grok dynamic start date of elastic dag

2020-05-21 Thread GitBox
ashb opened a new pull request #8952: URL: https://github.com/apache/airflow/pull/8952 The scheduler_dag_execution_timing script wants to run _n_ dag runs to completion. However since the start date of those dags is Dynamic (`now - delta`) we can't pre-compute the execution_dates like

[GitHub] [airflow] JavierLTPromofarma commented on issue #8899: Get UI color of operators from airflow.cfg

2020-05-21 Thread GitBox
JavierLTPromofarma commented on issue #8899: URL: https://github.com/apache/airflow/issues/8899#issuecomment-632098153 I'm not sure either, but I think this customization has to be addressed somehow in order to avoid the necessity of modifying the core code of Airflow. Do you (or anyone)

[GitHub] [airflow] jhettler opened a new issue #8951: Run task with ignoring all options doesn't work

2020-05-21 Thread GitBox
jhettler opened a new issue #8951: URL: https://github.com/apache/airflow/issues/8951 **Apache Airflow version**: 1.10.10 **Environment**: Docker official image - **Cloud provider or hardware configuration**: - **OS** (e.g. from /etc/os-release): - **Kernel** (e.g.

[GitHub] [airflow] ToxaZ commented on issue #8861: HttpHook.run method doesn't convert dict in 'data' parameter to json object

2020-05-21 Thread GitBox
ToxaZ commented on issue #8861: URL: https://github.com/apache/airflow/issues/8861#issuecomment-632084696 @ashb but the functionatliy of HttpHook.run is still broken. I don't insist on fixing it, just fyi. This is an

[GitHub] [airflow] turbaszek commented on pull request #8651: [AIP-31] [AIRFLOW-8058] Retrieve current execution context without altering function's signature

2020-05-21 Thread GitBox
turbaszek commented on pull request #8651: URL: https://github.com/apache/airflow/pull/8651#issuecomment-632079527 @kaxil @mik-laj what are your thoughts? This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] j-y-matsubara edited a comment on pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-05-21 Thread GitBox
j-y-matsubara edited a comment on pull request #8867: URL: https://github.com/apache/airflow/pull/8867#issuecomment-632075311 > > On a side note... > > If you know of a documentation file that needs to be modified, please let me know. > > I think the document you need to update

[GitHub] [airflow] j-y-matsubara edited a comment on pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-05-21 Thread GitBox
j-y-matsubara edited a comment on pull request #8867: URL: https://github.com/apache/airflow/pull/8867#issuecomment-632075311 > > On a side note... > > If you know of a documentation file that needs to be modified, please let me know. > > I think the document you need to update

[GitHub] [airflow] j-y-matsubara commented on pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-05-21 Thread GitBox
j-y-matsubara commented on pull request #8867: URL: https://github.com/apache/airflow/pull/8867#issuecomment-632075311 > > On a side note... > > If you know of a documentation file that needs to be modified, please let me know. > > I think the document you need to update is

[GitHub] [airflow] potiuk commented on issue #8620: Transfer operators and division into providers

2020-05-21 Thread GitBox
potiuk commented on issue #8620: URL: https://github.com/apache/airflow/issues/8620#issuecomment-632069777 I will add some doc changes alongside releasing first batch of backport packages. This is an automated message from

[GitHub] [airflow] potiuk commented on pull request #8928: Bump httplib2 from 0.17.3 to 0.18.0 in /requirements

2020-05-21 Thread GitBox
potiuk commented on pull request #8928: URL: https://github.com/apache/airflow/pull/8928#issuecomment-632068712 Requirements should never be changed manually or via dependabot. They are by-product. Our "master" source of requirements versions is setup.py. Next time someone touches

[GitHub] [airflow] potiuk closed pull request #8928: Bump httplib2 from 0.17.3 to 0.18.0 in /requirements

2020-05-21 Thread GitBox
potiuk closed pull request #8928: URL: https://github.com/apache/airflow/pull/8928 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] dependabot[bot] commented on pull request #8928: Bump httplib2 from 0.17.3 to 0.18.0 in /requirements

2020-05-21 Thread GitBox
dependabot[bot] commented on pull request #8928: URL: https://github.com/apache/airflow/pull/8928#issuecomment-632068756 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[airflow] branch master updated (41481bb -> b26b3ca)

2020-05-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 41481bb Python base images are stored in cache (#8943) add b26b3ca Don't hard-code constants in

[GitHub] [airflow] kaxil merged pull request #8950: Don't hard-code constants in scheduler_dag_execution_timing

2020-05-21 Thread GitBox
kaxil merged pull request #8950: URL: https://github.com/apache/airflow/pull/8950 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] eladkal commented on issue #8933: pyhive is installed without Hive dependencies

2020-05-21 Thread GitBox
eladkal commented on issue #8933: URL: https://github.com/apache/airflow/issues/8933#issuecomment-632059927 Airflow doesn't need `pyhive` for Presto https://github.com/apache/airflow/pull/6822 removed that dependency. Presto is now using `prestodb`

[GitHub] [airflow] ashb commented on a change in pull request #8950: Don't hard-code constants in scheduler_dag_execution_timing

2020-05-21 Thread GitBox
ashb commented on a change in pull request #8950: URL: https://github.com/apache/airflow/pull/8950#discussion_r428621218 ## File path: scripts/perf/scheduler_dag_execution_timing.py ## @@ -131,11 +131,18 @@ def create_dag_runs(dag, num_runs, session): from airflow.utils

[GitHub] [airflow] ashb commented on a change in pull request #8950: Don't hard-code constants in scheduler_dag_execution_timing

2020-05-21 Thread GitBox
ashb commented on a change in pull request #8950: URL: https://github.com/apache/airflow/pull/8950#discussion_r428619816 ## File path: scripts/perf/scheduler_dag_execution_timing.py ## @@ -131,11 +131,18 @@ def create_dag_runs(dag, num_runs, session): from airflow.utils

[GitHub] [airflow] mik-laj commented on issue #8923: Google AdManager

2020-05-21 Thread GitBox
mik-laj commented on issue #8923: URL: https://github.com/apache/airflow/issues/8923#issuecomment-632053490 @Handtaker23 That sounds fantastic. I would be very interested in them. Let me know if you start work. I will be happy to help with reviews.

[GitHub] [airflow] kaxil commented on a change in pull request #8950: Don't hard-code constants in scheduler_dag_execution_timing

2020-05-21 Thread GitBox
kaxil commented on a change in pull request #8950: URL: https://github.com/apache/airflow/pull/8950#discussion_r428612054 ## File path: scripts/perf/scheduler_dag_execution_timing.py ## @@ -131,11 +131,18 @@ def create_dag_runs(dag, num_runs, session): from airflow.utils

[GitHub] [airflow] kaxil commented on a change in pull request #8950: Don't hard-code constants in scheduler_dag_execution_timing

2020-05-21 Thread GitBox
kaxil commented on a change in pull request #8950: URL: https://github.com/apache/airflow/pull/8950#discussion_r428611927 ## File path: scripts/perf/scheduler_dag_execution_timing.py ## @@ -131,11 +131,18 @@ def create_dag_runs(dag, num_runs, session): from airflow.utils

[GitHub] [airflow] ashb opened a new pull request #8950: Don't hard-code constants in scheduler_dag_execution_timing

2020-05-21 Thread GitBox
ashb opened a new pull request #8950: URL: https://github.com/apache/airflow/pull/8950 Slight "improvement" on #8949 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes

[airflow] branch master updated (97b6cc7 -> 41481bb)

2020-05-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 97b6cc7 Add note in Updating.md about the removel of DagRun.ID_PREFIX (#8949) add 41481bb Python base

[GitHub] [airflow] potiuk merged pull request #8943: Python base images are stored in cache

2020-05-21 Thread GitBox
potiuk merged pull request #8943: URL: https://github.com/apache/airflow/pull/8943 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated (16206cd -> 97b6cc7)

2020-05-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 16206cd Update example webserver_config.py to show correct CSRF config (#8944) add 97b6cc7 Add note in

[GitHub] [airflow] kaxil merged pull request #8949: Add note in Updating.md about the removel of DagRun.ID_PREFIX

2020-05-21 Thread GitBox
kaxil merged pull request #8949: URL: https://github.com/apache/airflow/pull/8949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated (47413d9 -> 16206cd)

2020-05-21 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 47413d9 Remove singularity from CI images (#8945) add 16206cd Update example webserver_config.py to show

[GitHub] [airflow] kaxil opened a new pull request #8949: Add note in Updating.md about the removel of DagRun.ID_PREFIX

2020-05-21 Thread GitBox
kaxil opened a new pull request #8949: URL: https://github.com/apache/airflow/pull/8949 It was removed in https://github.com/apache/airflow/pull/7583 and https://github.com/apache/airflow/pull/7484 --- Make sure to mark the boxes below before creating PR: [x] - [x]

[GitHub] [airflow] ashb closed issue #8915: CSRF configuration is missing the WTF_ prefix

2020-05-21 Thread GitBox
ashb closed issue #8915: URL: https://github.com/apache/airflow/issues/8915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

  1   2   >