[GitHub] [airflow] boring-cyborg[bot] commented on issue #15773: [SambaHook] Can not extract domain from the username

2021-05-10 Thread GitBox
boring-cyborg[bot] commented on issue #15773: URL: https://github.com/apache/airflow/issues/15773#issuecomment-837807022 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] edwinkong opened a new issue #15773: [SambaHook] Can not extract domain from the username

2021-05-10 Thread GitBox
edwinkong opened a new issue #15773: URL: https://github.com/apache/airflow/issues/15773 **Apache Airflow version**: 2.0.1 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): **Environment**: docker-compose + custom built docker

[GitHub] [airflow] vikramcse commented on issue #15524: Improve test coverage of task_command

2021-05-10 Thread GitBox
vikramcse commented on issue #15524: URL: https://github.com/apache/airflow/issues/15524#issuecomment-837783667 Raised a PR for improving test coverage of task_command.py file https://github.com/apache/airflow/pull/15760 -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] dstandish edited a comment on pull request #14521: Add Asana Provider

2021-05-10 Thread GitBox
dstandish edited a comment on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-837774480 seems that the recent change to `get_all_changes_for_package` in docs generation may not handle the "new provider" case? ``` File

[GitHub] [airflow] dstandish commented on pull request #14521: Add Asana Provider

2021-05-10 Thread GitBox
dstandish commented on pull request #14521: URL: https://github.com/apache/airflow/pull/14521#issuecomment-837774480 seems that the recent change to `get_all_changes_for_package` in docs generation may not handle the "new provider" case? ``` File

[GitHub] [airflow] dstandish opened a new pull request #15772: Fix OdbcHook handling of port

2021-05-10 Thread GitBox
dstandish opened a new pull request #15772: URL: https://github.com/apache/airflow/pull/15772 When port was set in connection, it was not added to connection string. This PR fixes that. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15726: Add more integration tests to the kubernetes executor

2021-05-10 Thread GitBox
ephraimbuddy commented on a change in pull request #15726: URL: https://github.com/apache/airflow/pull/15726#discussion_r629804088 ## File path: kubernetes_tests/test_kubernetes_executor.py ## @@ -266,3 +266,65 @@ def test_integration_run_dag_with_scheduler_failure(self):

[GitHub] [airflow] EunSeop commented on issue #15196: ExternalTaskSensor not working python3.6 & airflow2.0.1

2021-05-10 Thread GitBox
EunSeop commented on issue #15196: URL: https://github.com/apache/airflow/issues/15196#issuecomment-837608306 @DenisOgr I never saw that message. Airflow 2.0 is not perfectly support python 3.6, so I decided upgrade python version using pyenv. Please check airflow and python versions.

[GitHub] [airflow] kaxil commented on a change in pull request #15602: Update KylinHook docstring

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #15602: URL: https://github.com/apache/airflow/pull/15602#discussion_r629777234 ## File path: airflow/providers/apache/kylin/hooks/kylin.py ## @@ -26,6 +26,8 @@ class KylinHook(BaseHook): """ +Interact with Kylin to run

[GitHub] [airflow] kaxil commented on pull request #15719: Refactor tests/www/test_views.py (Part 2/2)

2021-05-10 Thread GitBox
kaxil commented on pull request #15719: URL: https://github.com/apache/airflow/pull/15719#issuecomment-837578992 @uranusjr There are some conflicts -- can you fix them please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] kaxil commented on pull request #15695: Add integration test for other executors in kubernetes cluster

2021-05-10 Thread GitBox
kaxil commented on pull request #15695: URL: https://github.com/apache/airflow/pull/15695#issuecomment-837577849 @ephraimbuddy We should also now integrate this in CI to run Helm Chart integration test with Celery & Local Executor too -- This is an automated message from the Apache Git

[GitHub] [airflow] ferruzzi commented on pull request #15727: templatize_awsconnectionid

2021-05-10 Thread GitBox
ferruzzi commented on pull request #15727: URL: https://github.com/apache/airflow/pull/15727#issuecomment-837577270 I'm not a Committer so I can't merge it, but other that my comments about style consistency - which is admittedly subjective - it looks good to me. -- This is an automated

[airflow] branch master updated (34cf525 -> cbc3cb8)

2021-05-10 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 34cf525 Clean up unnecessary Airflow config in helm chart (#15729) add cbc3cb8 Add integration test for

[GitHub] [airflow] kaxil merged pull request #15695: Add integration test for other executors in kubernetes cluster

2021-05-10 Thread GitBox
kaxil merged pull request #15695: URL: https://github.com/apache/airflow/pull/15695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] kaxil commented on a change in pull request #15726: Add more integration tests to the kubernetes executor

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #15726: URL: https://github.com/apache/airflow/pull/15726#discussion_r629773272 ## File path: kubernetes_tests/test_kubernetes_executor.py ## @@ -266,3 +266,65 @@ def test_integration_run_dag_with_scheduler_failure(self): )

[GitHub] [airflow] khilawar4 commented on a change in pull request #15727: templatize_awsconnectionid

2021-05-10 Thread GitBox
khilawar4 commented on a change in pull request #15727: URL: https://github.com/apache/airflow/pull/15727#discussion_r629762975 ## File path: airflow/providers/amazon/aws/operators/s3_list.py ## @@ -65,7 +67,7 @@ class S3ListOperator(BaseOperator): ) """ -

[airflow] branch master updated (3edcd12 -> 34cf525)

2021-05-10 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3edcd12 Update croniter to 1.0.x series (#15769) add 34cf525 Clean up unnecessary Airflow config in helm

[GitHub] [airflow] kaxil merged pull request #15729: Clean up unnecessary Airflow config in helm chart

2021-05-10 Thread GitBox
kaxil merged pull request #15729: URL: https://github.com/apache/airflow/pull/15729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] khilawar4 commented on a change in pull request #15727: templatize_awsconnectionid

2021-05-10 Thread GitBox
khilawar4 commented on a change in pull request #15727: URL: https://github.com/apache/airflow/pull/15727#discussion_r629770582 ## File path: airflow/providers/amazon/aws/operators/s3_delete_objects.py ## @@ -45,6 +45,8 @@ class S3DeleteObjectsOperator(BaseOperator):

[airflow] branch master updated (25caeda -> 3edcd12)

2021-05-10 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 25caeda Remove unused dependency (#15762) add 3edcd12 Update croniter to 1.0.x series (#15769) No new

[GitHub] [airflow] kaxil merged pull request #15769: Update croniter to 1.0.x series

2021-05-10 Thread GitBox
kaxil merged pull request #15769: URL: https://github.com/apache/airflow/pull/15769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] khilawar4 commented on a change in pull request #15727: templatize_awsconnectionid

2021-05-10 Thread GitBox
khilawar4 commented on a change in pull request #15727: URL: https://github.com/apache/airflow/pull/15727#discussion_r629762975 ## File path: airflow/providers/amazon/aws/operators/s3_list.py ## @@ -65,7 +67,7 @@ class S3ListOperator(BaseOperator): ) """ -

[GitHub] [airflow] khilawar4 commented on a change in pull request #15727: templatize_awsconnectionid

2021-05-10 Thread GitBox
khilawar4 commented on a change in pull request #15727: URL: https://github.com/apache/airflow/pull/15727#discussion_r629762502 ## File path: airflow/providers/amazon/aws/operators/s3_bucket.py ## @@ -37,12 +37,16 @@ class S3CreateBucketOperator(BaseOperator): running

[GitHub] [airflow] khilawar4 commented on a change in pull request #15727: templatize_awsconnectionid

2021-05-10 Thread GitBox
khilawar4 commented on a change in pull request #15727: URL: https://github.com/apache/airflow/pull/15727#discussion_r629761961 ## File path: airflow/providers/amazon/aws/operators/cloud_formation.py ## @@ -67,9 +67,11 @@ class CloudFormationDeleteStackOperator(BaseOperator):

[GitHub] [airflow] khilawar4 commented on a change in pull request #15727: templatize_awsconnectionid

2021-05-10 Thread GitBox
khilawar4 commented on a change in pull request #15727: URL: https://github.com/apache/airflow/pull/15727#discussion_r629760514 ## File path: airflow/providers/amazon/aws/operators/emr_modify_cluster.py ## @@ -32,6 +32,8 @@ class EmrModifyClusterOperator(BaseOperator):

[GitHub] [airflow] khilawar4 commented on a change in pull request #15727: templatize_awsconnectionid

2021-05-10 Thread GitBox
khilawar4 commented on a change in pull request #15727: URL: https://github.com/apache/airflow/pull/15727#discussion_r629760349 ## File path: airflow/providers/amazon/aws/operators/cloud_formation.py ## @@ -67,9 +67,11 @@ class CloudFormationDeleteStackOperator(BaseOperator):

[GitHub] [airflow] github-actions[bot] commented on pull request #15012: PostgreSQL operator returns query result

2021-05-10 Thread GitBox
github-actions[bot] commented on pull request #15012: URL: https://github.com/apache/airflow/pull/15012#issuecomment-837524479 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on pull request #13832: removing try-catch block to fix timeout exception getting ignored in aws batch operator

2021-05-10 Thread GitBox
github-actions[bot] commented on pull request #13832: URL: https://github.com/apache/airflow/pull/13832#issuecomment-837524537 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] kaxil opened a new issue #15771: Automate docs for `values.yaml` via pre-commit config and break them into logical groups

2021-05-10 Thread GitBox
kaxil opened a new issue #15771: URL: https://github.com/apache/airflow/issues/15771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] Smithx10 commented on issue #15724: mysql cluster import_error waits for a lock

2021-05-10 Thread GitBox
Smithx10 commented on issue #15724: URL: https://github.com/apache/airflow/issues/15724#issuecomment-837479909 @potiuk, I made a bit of progress today. I forked the percona-healthcheck script, ported it to go, and added raft. It still needs to be cleaned up, Logging, Config,

[GitHub] [airflow] kaxil closed issue #14302: Helm Chart: Review Architecture

2021-05-10 Thread GitBox
kaxil closed issue #14302: URL: https://github.com/apache/airflow/issues/14302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] dstandish opened a new issue #15770: google provider requires leveldb in host

2021-05-10 Thread GitBox
dstandish opened a new issue #15770: URL: https://github.com/apache/airflow/issues/15770 google provider now requires plyvel, which is used by leveldb hook. to install plyvel, the user needs leveldb headers installed in the system, otherwise it will fail: ```

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629703321 ## File path: airflow/migrations/versions/83f031fd9f1c_improve_mssql_compatibility.py ## @@ -0,0 +1,256 @@ +# +# Licensed to the Apache Software

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629701355 ## File path: airflow/migrations/versions/bbf4a7ad0465_remove_id_column_from_xcom.py ## @@ -35,6 +37,61 @@ depends_on = None +def

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629692470 ## File path: airflow/migrations/versions/bbf4a7ad0465_remove_id_column_from_xcom.py ## @@ -35,6 +37,61 @@ depends_on = None +def

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629695358 ## File path: airflow/migrations/versions/e9304a3141f0_make_xcom_pkey_columns_non_nullable.py ## @@ -0,0 +1,76 @@ +# +# Licensed to the Apache Software

[GitHub] [airflow] mik-laj commented on pull request #14105: Add Google leveldb hook (#13109)

2021-05-10 Thread GitBox
mik-laj commented on pull request #14105: URL: https://github.com/apache/airflow/pull/14105#issuecomment-837368681 @dstandish can you create a issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629693212 ## File path: airflow/migrations/versions/bbf4a7ad0465_remove_id_column_from_xcom.py ## @@ -35,6 +37,61 @@ depends_on = None +def

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629693129 ## File path: airflow/migrations/versions/bbf4a7ad0465_remove_id_column_from_xcom.py ## @@ -35,6 +37,61 @@ depends_on = None +def

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629693037 ## File path: airflow/migrations/versions/bbf4a7ad0465_remove_id_column_from_xcom.py ## @@ -35,6 +37,61 @@ depends_on = None +def

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629692470 ## File path: airflow/migrations/versions/bbf4a7ad0465_remove_id_column_from_xcom.py ## @@ -35,6 +37,61 @@ depends_on = None +def

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629692289 ## File path: airflow/migrations/versions/98271e7606e2_add_scheduling_decision_to_dagrun_and_.py ## @@ -35,12 +35,32 @@ depends_on = None +def

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629691901 ## File path: airflow/migrations/versions/83f031fd9f1c_improve_mssql_compatibility.py ## @@ -0,0 +1,256 @@ +# +# Licensed to the Apache Software

[GitHub] [airflow] kaxil commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629691560 ## File path: airflow/migrations/versions/83f031fd9f1c_improve_mssql_compatibility.py ## @@ -0,0 +1,256 @@ +# +# Licensed to the Apache Software

[GitHub] [airflow] dstandish edited a comment on pull request #14105: Add Google leveldb hook (#13109)

2021-05-10 Thread GitBox
dstandish edited a comment on pull request #14105: URL: https://github.com/apache/airflow/pull/14105#issuecomment-837350318 with this change it seems leveldb is a required system dependency for the google provider. it doesn't seem right to require users to install leveldb on their

[GitHub] [airflow] dstandish edited a comment on pull request #14105: Add Google leveldb hook (#13109)

2021-05-10 Thread GitBox
dstandish edited a comment on pull request #14105: URL: https://github.com/apache/airflow/pull/14105#issuecomment-837350318 with this change it seems leveldb is a required system dependency for the google provider. it doesn't seem right to require users to install leveldb on their

[GitHub] [airflow] malthe opened a new pull request #15769: Update croniter to 1.0.x series

2021-05-10 Thread GitBox
malthe opened a new pull request #15769: URL: https://github.com/apache/airflow/pull/15769 The [croniter](https://pypi.org/project/croniter/#changelog) project transitioned to semver2 as part of recently making it to 1.0.x. -- This is an automated message from the Apache Git

[GitHub] [airflow] mik-laj commented on pull request #15755: Save pod name to xcom for KubernetesPodOperator

2021-05-10 Thread GitBox
mik-laj commented on pull request #15755: URL: https://github.com/apache/airflow/pull/15755#issuecomment-837350803 Tests faield. Can you look at it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] dstandish commented on pull request #14105: Add Google leveldb hook (#13109)

2021-05-10 Thread GitBox
dstandish commented on pull request #14105: URL: https://github.com/apache/airflow/pull/14105#issuecomment-837350318 with this change it seems leveldb is a required system dependency for the google provider. it doesn't seem right to require users to install leveldb on their

[GitHub] [airflow] xinbinhuang edited a comment on pull request #15743: Redirect forked process output to logger

2021-05-10 Thread GitBox
xinbinhuang edited a comment on pull request #15743: URL: https://github.com/apache/airflow/pull/15743#issuecomment-837266936 > I'm not yet convinced this is an actual problem in a task run by airflow -- I haven't been able to reproduce this with a python operator Can you reproduce

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15768: PythonVirtualenvOperator fails with error from pip execution: Can not perform a '--user' install.

2021-05-10 Thread GitBox
boring-cyborg[bot] commented on issue #15768: URL: https://github.com/apache/airflow/issues/15768#issuecomment-837296054 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] NickPancakes opened a new issue #15768: PythonVirtualenvOperator fails with error from pip execution: Can not perform a '--user' install.

2021-05-10 Thread GitBox
NickPancakes opened a new issue #15768: URL: https://github.com/apache/airflow/issues/15768 **Apache Airflow version**: 2.0.2 **Environment**: - **Hardware configuration**: Macbook Pro 2017 - **OS**: macOS X Catalina 10.15.7 - **Kernel**: Darwin 19.6.0 - **Others**:

[GitHub] [airflow] xinbinhuang edited a comment on pull request #15743: Redirect forked process output to logger

2021-05-10 Thread GitBox
xinbinhuang edited a comment on pull request #15743: URL: https://github.com/apache/airflow/pull/15743#issuecomment-837266936 > I'm not yet convinced this is an actual problem in a task run by airflow -- I haven't been able to reproduce this with a python operator Can you reproduce

[GitHub] [airflow] xinbinhuang edited a comment on pull request #15743: Redirect forked process output to logger

2021-05-10 Thread GitBox
xinbinhuang edited a comment on pull request #15743: URL: https://github.com/apache/airflow/pull/15743#issuecomment-837266936 > I'm not yet convinced this is an actual problem in a task run by airflow -- I haven't been able to reproduce this with a python operator Can you reproduce

[GitHub] [airflow] xinbinhuang edited a comment on pull request #15743: Redirect forked process output to logger

2021-05-10 Thread GitBox
xinbinhuang edited a comment on pull request #15743: URL: https://github.com/apache/airflow/pull/15743#issuecomment-837266936 > I'm not yet convinced this is an actual problem in a task run by airflow -- I haven't been able to reproduce this with a python operator Can you reproduce

[GitHub] [airflow] xinbinhuang edited a comment on pull request #15743: Redirect forked process output to logger

2021-05-10 Thread GitBox
xinbinhuang edited a comment on pull request #15743: URL: https://github.com/apache/airflow/pull/15743#issuecomment-837266936 > I'm not yet convinced this is an actual problem in a task run by airflow -- I haven't been able to reproduce this with a python operator Can you reproduce

[GitHub] [airflow] malthe commented on a change in pull request #15581: Add bindvars Xcom result to Oracle operator

2021-05-10 Thread GitBox
malthe commented on a change in pull request #15581: URL: https://github.com/apache/airflow/pull/15581#discussion_r629657710 ## File path: airflow/providers/oracle/operators/oracle.py ## @@ -62,4 +68,30 @@ def __init__( def execute(self, context) -> None:

[GitHub] [airflow] xinbinhuang commented on pull request #15743: Redirect forked process output to logger

2021-05-10 Thread GitBox
xinbinhuang commented on pull request #15743: URL: https://github.com/apache/airflow/pull/15743#issuecomment-837266936 > I'm not yet convinced this is an actual problem in a task run by airflow -- I haven't been able to reproduce this with a python operator Can you reproduce the

[GitHub] [airflow] SamWheating commented on issue #15759: flask error: ValueError: instance() only accepts datetime objects.

2021-05-10 Thread GitBox
SamWheating commented on issue #15759: URL: https://github.com/apache/airflow/issues/15759#issuecomment-837261174 Fixed in https://github.com/apache/airflow/pull/14416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] lsowen commented on issue #13853: Clearing of historic Task or DagRuns leads to failed DagRun

2021-05-10 Thread GitBox
lsowen commented on issue #13853: URL: https://github.com/apache/airflow/issues/13853#issuecomment-837226456 Is this or #14265 a candidate for https://github.com/apache/airflow/milestone/21? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] dvd9604 opened a new issue #15767: Webserver changes the base path for the log on rerun of task 404

2021-05-10 Thread GitBox
dvd9604 opened a new issue #15767: URL: https://github.com/apache/airflow/issues/15767 **Apache Airflow version**: 2.0.0 **Environment**: - **OS** (e.g. from /etc/os-release): RHEL7 - **Python**: 3.8.6 - **Executor**: CeleryExecutor - **Workers**: 4 worker nodes -

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15767: Webserver changes the base path for the log on rerun of task 404

2021-05-10 Thread GitBox
boring-cyborg[bot] commented on issue #15767: URL: https://github.com/apache/airflow/issues/15767#issuecomment-837160531 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch master updated (dab10d9 -> 25caeda)

2021-05-10 Thread ryanahamilton
This is an automated email from the ASF dual-hosted git repository. ryanahamilton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from dab10d9 MongoToS3Operator failed when running with a single query (not aggregate pipeline) (#15680)

[GitHub] [airflow] ryanahamilton merged pull request #15762: Remove unused dependency

2021-05-10 Thread GitBox
ryanahamilton merged pull request #15762: URL: https://github.com/apache/airflow/pull/15762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [airflow] ephraimbuddy closed pull request #15726: Add more integration tests to the kubernetes executor

2021-05-10 Thread GitBox
ephraimbuddy closed pull request #15726: URL: https://github.com/apache/airflow/pull/15726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [airflow] dstandish commented on issue #15016: OdbcHook string values in connect_kwargs dict converts to None

2021-05-10 Thread GitBox
dstandish commented on issue #15016: URL: https://github.com/apache/airflow/issues/15016#issuecomment-837110088 > Why is clean_bool being called in the first place for a user-provided dictionary? I'm not sure how this is necessary because the user can provide a literal boolean value in

[GitHub] [airflow] aneesh-joseph commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
aneesh-joseph commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629543337 ## File path: airflow/www/security.py ## @@ -347,19 +347,23 @@ def can_read_dag(self, dag_id, user=None) -> bool: if not user:

[GitHub] [airflow] jedcunningham closed pull request #15729: Clean up unnecessary Airflow config in helm chart

2021-05-10 Thread GitBox
jedcunningham closed pull request #15729: URL: https://github.com/apache/airflow/pull/15729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [airflow] ConstantinoSchillebeeckx opened a new issue #15766: execution_timeout not working

2021-05-10 Thread GitBox
ConstantinoSchillebeeckx opened a new issue #15766: URL: https://github.com/apache/airflow/issues/15766 **Apache Airflow version**: 2.0.2 **Environment**: - **Cloud provider or hardware configuration**: AWS **What happened**: I have a custom operator that

[jira] [Commented] (AIRFLOW-4922) If a task crashes, host name is not committed to the database so logs aren't able to be seen in the UI

2021-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342007#comment-17342007 ] ASF GitHub Bot commented on AIRFLOW-4922: - ashb edited a comment on pull request #6722: URL:

[GitHub] [airflow] ashb edited a comment on pull request #6722: [AIRFLOW-4922]Fix task get log by Web UI

2021-05-10 Thread GitBox
ashb edited a comment on pull request #6722: URL: https://github.com/apache/airflow/pull/6722#issuecomment-836943220 Not specifically - we don't plan at the bug level, just high level features. So either someone has to tackle this themselves (which we will help you do), or engage in

[GitHub] [airflow] github-actions[bot] commented on pull request #15762: Remove unused dependency

2021-05-10 Thread GitBox
github-actions[bot] commented on pull request #15762: URL: https://github.com/apache/airflow/pull/15762#issuecomment-836949243 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[jira] [Commented] (AIRFLOW-4922) If a task crashes, host name is not committed to the database so logs aren't able to be seen in the UI

2021-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342004#comment-17342004 ] ASF GitHub Bot commented on AIRFLOW-4922: - ashb commented on pull request #6722: URL:

[GitHub] [airflow] ashb commented on pull request #6722: [AIRFLOW-4922]Fix task get log by Web UI

2021-05-10 Thread GitBox
ashb commented on pull request #6722: URL: https://github.com/apache/airflow/pull/6722#issuecomment-836943220 Not specifically - we don't plan at the bug level, just high level features. So either someone has to tackle this themselves (which we will help you do), or engage in some

[GitHub] [airflow] john-jac commented on issue #15306: Support Serialized DAGs on CLI Commands

2021-05-10 Thread GitBox
john-jac commented on issue #15306: URL: https://github.com/apache/airflow/issues/15306#issuecomment-836941555 > list_dags is fine -- backfill won't work on serialized dags. @kaxil could you provide details as to why backfill can't run on serialized dags? -- This is an automated

[GitHub] [airflow] mik-laj commented on a change in pull request #15755: Save pod name to xcom for KubernetesPodOperator

2021-05-10 Thread GitBox
mik-laj commented on a change in pull request #15755: URL: https://github.com/apache/airflow/pull/15755#discussion_r629510571 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -338,6 +338,7 @@ def execute(self, context) -> Optional[str]:

[GitHub] [airflow] mik-laj commented on a change in pull request #15755: Save pod name to xcom for KubernetesPodOperator

2021-05-10 Thread GitBox
mik-laj commented on a change in pull request #15755: URL: https://github.com/apache/airflow/pull/15755#discussion_r629510178 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -367,8 +366,10 @@ def execute(self, context) -> Optional[str]:

[GitHub] [airflow] mik-laj commented on a change in pull request #15755: Save pod name to xcom for KubernetesPodOperator

2021-05-10 Thread GitBox
mik-laj commented on a change in pull request #15755: URL: https://github.com/apache/airflow/pull/15755#discussion_r629510342 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -367,8 +366,10 @@ def execute(self, context) -> Optional[str]:

[GitHub] [airflow] mik-laj commented on a change in pull request #15755: Save pod name to xcom for KubernetesPodOperator

2021-05-10 Thread GitBox
mik-laj commented on a change in pull request #15755: URL: https://github.com/apache/airflow/pull/15755#discussion_r629509871 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -367,8 +366,10 @@ def execute(self, context) -> Optional[str]:

[GitHub] [airflow] ashb commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
ashb commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629501511 ## File path: airflow/www/security.py ## @@ -347,19 +347,23 @@ def can_read_dag(self, dag_id, user=None) -> bool: if not user: user =

[GitHub] [airflow] ashb commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
ashb commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629500122 ## File path: airflow/www/security.py ## @@ -348,19 +348,21 @@ def can_read_dag(self, dag_id, user=None) -> bool: if not user: user =

[GitHub] [airflow] jedcunningham commented on a change in pull request #15729: Clean up unnecessary Airflow config in helm chart

2021-05-10 Thread GitBox
jedcunningham commented on a change in pull request #15729: URL: https://github.com/apache/airflow/pull/15729#discussion_r629486438 ## File path: chart/values.yaml ## @@ -914,10 +912,6 @@ config: elasticsearch: json_format: 'True' log_id_template:

[GitHub] [airflow] ChethanUK opened a new pull request #15765: Introducing BaseCustomK8sApp Sensor and Improving the spark driver logs

2021-05-10 Thread GitBox
ChethanUK opened a new pull request #15765: URL: https://github.com/apache/airflow/pull/15765 Introducing BaseCustomK8sApp Sensor to add more Sensors like Flink Cluster Sensor etc... Just improving the spark sensor logs includes the name of the app and the namespace in which it's

[GitHub] [airflow] PeterLambe commented on issue #11901: DAGs remain in the UI after renaming the dag_id in the same python file

2021-05-10 Thread GitBox
PeterLambe commented on issue #11901: URL: https://github.com/apache/airflow/issues/11901#issuecomment-836848483 Confirming that pressing "Delete DAG" on the old DAG will remove it from the metadata tables properly -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] github-actions[bot] commented on pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
github-actions[bot] commented on pull request #9973: URL: https://github.com/apache/airflow/pull/9973#issuecomment-836846212 [The Workflow run](https://github.com/apache/airflow/actions/runs/828512188) is cancelling this PR. Building images for the PR has failed. Follow the workflow link

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15726: Add more integration tests to the kubernetes executor

2021-05-10 Thread GitBox
ephraimbuddy commented on a change in pull request #15726: URL: https://github.com/apache/airflow/pull/15726#discussion_r629455917 ## File path: kubernetes_tests/test_kubernetes_executor.py ## @@ -173,41 +190,24 @@ def start_dag(self, dag_id, host): print(f"Calling

[GitHub] [airflow] maryampashmi commented on issue #15451: No module named 'airflow.providers.google.common.hooks.leveldb'

2021-05-10 Thread GitBox
maryampashmi commented on issue #15451: URL: https://github.com/apache/airflow/issues/15451#issuecomment-836841894 Using --upgrade, solved the error. I haven't get it anymore. Thanks for your help. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] github-actions[bot] commented on pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
github-actions[bot] commented on pull request #9973: URL: https://github.com/apache/airflow/pull/9973#issuecomment-836816009 [The Workflow run](https://github.com/apache/airflow/actions/runs/828407904) is cancelling this PR. Building images for the PR has failed. Follow the workflow link

[GitHub] [airflow] kaxil commented on a change in pull request #15729: Clean up unnecessary Airflow config in helm chart

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #15729: URL: https://github.com/apache/airflow/pull/15729#discussion_r629432849 ## File path: chart/values.yaml ## @@ -914,10 +912,6 @@ config: elasticsearch: json_format: 'True' log_id_template:

[GitHub] [airflow] kaxil commented on a change in pull request #15729: Clean up unnecessary Airflow config in helm chart

2021-05-10 Thread GitBox
kaxil commented on a change in pull request #15729: URL: https://github.com/apache/airflow/pull/15729#discussion_r629432849 ## File path: chart/values.yaml ## @@ -914,10 +912,6 @@ config: elasticsearch: json_format: 'True' log_id_template:

[jira] [Commented] (AIRFLOW-4922) If a task crashes, host name is not committed to the database so logs aren't able to be seen in the UI

2021-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341943#comment-17341943 ] ASF GitHub Bot commented on AIRFLOW-4922: - pelaprat commented on pull request #6722: URL:

[GitHub] [airflow] pelaprat commented on pull request #6722: [AIRFLOW-4922]Fix task get log by Web UI

2021-05-10 Thread GitBox
pelaprat commented on pull request #6722: URL: https://github.com/apache/airflow/pull/6722#issuecomment-836791611 @ashb – sorry to pick on you; any sense of where this bug fits into development priorities? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] aneesh-joseph commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
aneesh-joseph commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629416272 ## File path: airflow/migrations/versions/83f031fd9f1c_improve_mssql_compatibility.py ## @@ -0,0 +1,262 @@ +# +# Licensed to the Apache Software

[GitHub] [airflow] aneesh-joseph commented on a change in pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
aneesh-joseph commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r629415571 ## File path: airflow/sensors/smart_sensor.py ## @@ -391,13 +391,21 @@ def _update_ti_hostname(self, sensor_works, session=None): :param

[GitHub] [airflow] github-actions[bot] commented on pull request #9973: Improve compatibility with mssql

2021-05-10 Thread GitBox
github-actions[bot] commented on pull request #9973: URL: https://github.com/apache/airflow/pull/9973#issuecomment-836770497 [The Workflow run](https://github.com/apache/airflow/actions/runs/828262569) is cancelling this PR. Building images for the PR has failed. Follow the workflow link

[GitHub] [airflow] Goodkat commented on pull request #15510: OdbcHook returns None. Related to #15016 issue.

2021-05-10 Thread GitBox
Goodkat commented on pull request #15510: URL: https://github.com/apache/airflow/pull/15510#issuecomment-836757441 @eladkal should be OK now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] xinbinhuang commented on pull request #15680: MongoToS3Operator failed when running with a single query (not aggregate pipeline)

2021-05-10 Thread GitBox
xinbinhuang commented on pull request #15680: URL: https://github.com/apache/airflow/pull/15680#issuecomment-836752384 Thank you for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[airflow] branch master updated (e7293b0 -> dab10d9)

2021-05-10 Thread binh
This is an automated email from the ASF dual-hosted git repository. binh pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e7293b0 Mark test_mark_success_on_success_callback as quarantined (#15756) add dab10d9 MongoToS3Operator

[GitHub] [airflow] xinbinhuang closed issue #15679: MongoToS3Operator failed when running with a single query (not aggregate pipeline)

2021-05-10 Thread GitBox
xinbinhuang closed issue #15679: URL: https://github.com/apache/airflow/issues/15679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] xinbinhuang merged pull request #15680: MongoToS3Operator failed when running with a single query (not aggregate pipeline)

2021-05-10 Thread GitBox
xinbinhuang merged pull request #15680: URL: https://github.com/apache/airflow/pull/15680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

  1   2   >