khilawar4 commented on a change in pull request #15727:
URL: https://github.com/apache/airflow/pull/15727#discussion_r629762975
##########
File path: airflow/providers/amazon/aws/operators/s3_list.py
##########
@@ -65,7 +67,7 @@ class S3ListOperator(BaseOperator):
)
"""
- template_fields: Iterable[str] = ('bucket', 'prefix', 'delimiter')
+ template_fields: Iterable[str] = ('bucket', 'prefix', 'delimiter' ,
'aws_conn_id')
Review comment:
Well it was commited by someone else before so i can't comment on that ,
but i agree , we should standardize 'type hinting'. May be i can work on that
as part of separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
