[GitHub] [airflow] ashb commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
ashb commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636870358 ## File path: airflow/www/templates/airflow/conn_edit_form.html ## @@ -0,0 +1,81 @@ +{# +Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] [airflow] ashb commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
ashb commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636868848 ## File path: airflow/www/static/js/connection_form.js ## @@ -140,6 +140,55 @@ $(document).ready(function () { } } + $.fn.serializeObject =

[GitHub] [airflow] ashb commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
ashb commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636867154 ## File path: airflow/www/static/js/connection_form.js ## @@ -140,6 +140,55 @@ $(document).ready(function () { } } + $.fn.serializeObject =

[GitHub] [airflow] ashb commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
ashb commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636863418 ## File path: airflow/models/connection.py ## @@ -348,6 +348,25 @@ def debug_info(self): self.extra_dejson, ) +def

[GitHub] [airflow] ashb commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
ashb commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636862403 ## File path: airflow/api_connexion/endpoints/connection_endpoint.py ## @@ -129,3 +133,21 @@ def post_connection(session): session.commit()

[GitHub] [airflow] ashb commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
ashb commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636862851 ## File path: airflow/api_connexion/endpoints/connection_endpoint.py ## @@ -129,3 +133,21 @@ def post_connection(session): session.commit()

[GitHub] [airflow] ashb commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
ashb commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636862656 ## File path: airflow/api_connexion/endpoints/connection_endpoint.py ## @@ -129,3 +133,21 @@ def post_connection(session): session.commit()

[GitHub] [airflow] kaxil commented on issue #15670: Pod overrides not working

2021-05-21 Thread GitBox
kaxil commented on issue #15670: URL: https://github.com/apache/airflow/issues/15670#issuecomment-845896442 Probably something like that should work: ```python sidecar_task = PythonOperator( task_id="task_with_sidecar", python_callable=test_sharedvolume_mount,

[GitHub] [airflow] CatarinaSilva commented on issue #15670: Pod overrides not working

2021-05-21 Thread GitBox
CatarinaSilva commented on issue #15670: URL: https://github.com/apache/airflow/issues/15670#issuecomment-845883145 Hi @kaxil also experiencing this issue in 2.0.2, although I was using the old overrides: ``` "KubernetesExecutor": { "request_cpu": "250m",

[GitHub] [airflow] uranusjr commented on a change in pull request #15964: SSHHook: Using correct hostname for host_key when using non-default ssh port

2021-05-21 Thread GitBox
uranusjr commented on a change in pull request #15964: URL: https://github.com/apache/airflow/pull/15964#discussion_r636840511 ## File path: airflow/providers/ssh/hooks/ssh.py ## @@ -218,7 +218,8 @@ def get_conn(self) -> paramiko.SSHClient: else: if

[GitHub] [airflow] uranusjr commented on a change in pull request #15964: SSHHook: Using correct hostname for host_key when using non-default ssh port

2021-05-21 Thread GitBox
uranusjr commented on a change in pull request #15964: URL: https://github.com/apache/airflow/pull/15964#discussion_r636840511 ## File path: airflow/providers/ssh/hooks/ssh.py ## @@ -218,7 +218,8 @@ def get_conn(self) -> paramiko.SSHClient: else: if

[GitHub] [airflow] uranusjr opened a new pull request #15981: Properly remove user for test_create_user for it to work against a dirty database

2021-05-21 Thread GitBox
uranusjr opened a new pull request #15981: URL: https://github.com/apache/airflow/pull/15981 I didn't implement the user cleanup fixture correctly, but the error was not noticed before since a clean-slate DB (as on CI and `./breeze tests`) wouldn't need them. Can't wait for the

[GitHub] [airflow] uranusjr opened a new pull request #15980: Always return as reponse in TI's action_clear view

2021-05-21 Thread GitBox
uranusjr opened a new pull request #15980: URL: https://github.com/apache/airflow/pull/15980 A flask view should always return a response object, not None. This makes `TaskInstanceModelView.action_view` works like all other action views in the same class, redirecting to the previous page

[GitHub] [airflow] kaxil commented on issue #14161: Cannot use specific python module on KubernetesExecutor.

2021-05-21 Thread GitBox
kaxil commented on issue #14161: URL: https://github.com/apache/airflow/issues/14161#issuecomment-845858312 Use `PythonVirtualEnvOperator` -

[GitHub] [airflow] kaxil closed issue #14161: Cannot use specific python module on KubernetesExecutor.

2021-05-21 Thread GitBox
kaxil closed issue #14161: URL: https://github.com/apache/airflow/issues/14161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] ephraimbuddy commented on issue #15775: clear tasks is failing

2021-05-21 Thread GitBox
ephraimbuddy commented on issue #15775: URL: https://github.com/apache/airflow/issues/15775#issuecomment-845851044 @maryampashmi can you try in 2.0.2. Though you said 2.0.0, the error says 2.0.2, and I couldn't reproduce in 2.0.2 -- This is an automated message from the Apache Git

[GitHub] [airflow] Dr-Denzy commented on issue #15526: Improve test coverage of Kubernetes config_refresh

2021-05-21 Thread GitBox
Dr-Denzy commented on issue #15526: URL: https://github.com/apache/airflow/issues/15526#issuecomment-845832948 Hey @gm7y8 how is the progress on putting up a PR for this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] ephraimbuddy commented on issue #15978: DAG getting stuck in "running" state indefinitely

2021-05-21 Thread GitBox
ephraimbuddy commented on issue #15978: URL: https://github.com/apache/airflow/issues/15978#issuecomment-845827141 @hafid-d Can you get the scheduler logs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15978: DAG getting stuck in "running" state indefinitely

2021-05-21 Thread GitBox
boring-cyborg[bot] commented on issue #15978: URL: https://github.com/apache/airflow/issues/15978#issuecomment-845822981 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] hafid-d opened a new issue #15978: DAG getting stuck in "running" state indefinitely

2021-05-21 Thread GitBox
hafid-d opened a new issue #15978: URL: https://github.com/apache/airflow/issues/15978 **Apache Airflow version**: 2.0.2 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): - **Cloud provider or hardware configuration**: - **OS** : Ubuntu

[GitHub] [airflow] uranusjr commented on issue #15976: Error when querying on the Browse view with empty date picker

2021-05-21 Thread GitBox
uranusjr commented on issue #15976: URL: https://github.com/apache/airflow/issues/15976#issuecomment-845788083 I wonder what the best solution is. We can ignore empty fields in the backend (and probably should no matter what), but I would want the frontend to block form submission when

[GitHub] [airflow] BebokBebop opened a new issue #15977: SalesforceToGcsOperator requires additional packages

2021-05-21 Thread GitBox
BebokBebop opened a new issue #15977: URL: https://github.com/apache/airflow/issues/15977 **Apache Airflow version**: 1.10.15 **Environment**: GCP composer - image: `composer-1.16.4-airflow-1.10.15` **What happened**: When trying to import the `SalesforceToGcsOperator` in a

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15977: SalesforceToGcsOperator requires additional packages

2021-05-21 Thread GitBox
boring-cyborg[bot] commented on issue #15977: URL: https://github.com/apache/airflow/issues/15977#issuecomment-845786594 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] turbaszek merged pull request #15266: Update Google Ads hook

2021-05-21 Thread GitBox
turbaszek merged pull request #15266: URL: https://github.com/apache/airflow/pull/15266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[airflow] branch master updated (85b2ccb -> aa4713e)

2021-05-21 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 85b2ccb Add `KubernetesPodOperat` `pod-template-file` jinja template support (#15942) add aa4713e Use

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15939: Add CI test for helm upgrade with different Executors

2021-05-21 Thread GitBox
ephraimbuddy commented on a change in pull request #15939: URL: https://github.com/apache/airflow/pull/15939#discussion_r636715373 ## File path: .github/workflows/ci.yml ## @@ -21,9 +21,9 @@ on: # yamllint disable-line rule:truthy schedule: - cron: '28 0 * * *'

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15939: Add CI test for helm upgrade with different Executors

2021-05-21 Thread GitBox
ephraimbuddy commented on a change in pull request #15939: URL: https://github.com/apache/airflow/pull/15939#discussion_r636710592 ## File path: scripts/ci/kubernetes/ci_upgrade_cluster_with_different_executors_in_parallel.sh ## @@ -0,0 +1,105 @@ +#!/usr/bin/env bash +#

[GitHub] [airflow] msumit commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
msumit commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636708108 ## File path: airflow/www/static/js/connection_form.js ## @@ -140,6 +140,55 @@ $(document).ready(function () { } } + $.fn.serializeObject =

[GitHub] [airflow] msumit commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
msumit commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636707667 ## File path: airflow/www/static/js/connection_form.js ## @@ -140,6 +140,55 @@ $(document).ready(function () { } } + $.fn.serializeObject =

[GitHub] [airflow] msumit commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
msumit commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636705796 ## File path: airflow/models/connection.py ## @@ -348,6 +348,25 @@ def debug_info(self): self.extra_dejson, ) +def

[GitHub] [airflow] msumit commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
msumit commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636704895 ## File path: airflow/api_connexion/endpoints/connection_endpoint.py ## @@ -129,3 +133,21 @@ def post_connection(session): session.commit()

[GitHub] [airflow] potiuk commented on a change in pull request #15939: Add CI test for helm upgrade with different Executors

2021-05-21 Thread GitBox
potiuk commented on a change in pull request #15939: URL: https://github.com/apache/airflow/pull/15939#discussion_r636683793 ## File path: scripts/ci/kubernetes/ci_upgrade_cluster_with_different_executors_in_parallel.sh ## @@ -0,0 +1,105 @@ +#!/usr/bin/env bash +# Licensed to

[GitHub] [airflow] potiuk commented on a change in pull request #15939: Add CI test for helm upgrade with different Executors

2021-05-21 Thread GitBox
potiuk commented on a change in pull request #15939: URL: https://github.com/apache/airflow/pull/15939#discussion_r636682272 ## File path: .github/workflows/ci.yml ## @@ -1114,10 +1183,9 @@ ${{ hashFiles('.pre-commit-config.yaml') }}" - tests-kubernetes -

[GitHub] [airflow] potiuk commented on a change in pull request #15939: Add CI test for helm upgrade with different Executors

2021-05-21 Thread GitBox
potiuk commented on a change in pull request #15939: URL: https://github.com/apache/airflow/pull/15939#discussion_r636682209 ## File path: scripts/ci/kubernetes/ci_upgrade_cluster_with_different_executors_in_parallel.sh ## @@ -0,0 +1,105 @@ +#!/usr/bin/env bash +# Licensed to

[GitHub] [airflow] potiuk commented on a change in pull request #15939: Add CI test for helm upgrade with different Executors

2021-05-21 Thread GitBox
potiuk commented on a change in pull request #15939: URL: https://github.com/apache/airflow/pull/15939#discussion_r636681367 ## File path: .github/workflows/ci.yml ## @@ -1163,10 +1231,9 @@ ${{ hashFiles('.pre-commit-config.yaml') }}" GITHUB_REGISTRY: ${{

[GitHub] [airflow] potiuk commented on a change in pull request #15939: Add CI test for helm upgrade with different Executors

2021-05-21 Thread GitBox
potiuk commented on a change in pull request #15939: URL: https://github.com/apache/airflow/pull/15939#discussion_r636680567 ## File path: .github/workflows/ci.yml ## @@ -1053,10 +1123,9 @@ ${{ hashFiles('.pre-commit-config.yaml') }}" - tests-kubernetes -

[GitHub] [airflow] potiuk commented on a change in pull request #15939: Add CI test for helm upgrade with different Executors

2021-05-21 Thread GitBox
potiuk commented on a change in pull request #15939: URL: https://github.com/apache/airflow/pull/15939#discussion_r636680287 ## File path: .github/workflows/ci.yml ## @@ -21,9 +21,9 @@ on: # yamllint disable-line rule:truthy schedule: - cron: '28 0 * * *' push: -

[GitHub] [airflow] jacobhjkim commented on pull request #15266: Update Google Ads hook

2021-05-21 Thread GitBox
jacobhjkim commented on pull request #15266: URL: https://github.com/apache/airflow/pull/15266#issuecomment-845702674  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] sawaca96 edited a comment on issue #15572: import error

2021-05-21 Thread GitBox
sawaca96 edited a comment on issue #15572: URL: https://github.com/apache/airflow/issues/15572#issuecomment-845695724 @zorzigio I'm use airflow helm chart and image info is below ``` image: repository: apache/airflow tag: 2.0.2-python3.8 ``` I add just

[GitHub] [airflow] sawaca96 commented on issue #15572: import error

2021-05-21 Thread GitBox
sawaca96 commented on issue #15572: URL: https://github.com/apache/airflow/issues/15572#issuecomment-845695724 @zorzigio I'm use airflow helm chart and image info is below ``` image: repository: apache/airflow tag: 2.0.2-python3.8 ``` I add just `PYTHONPATH` to

[GitHub] [airflow] gdevanla commented on issue #15938: celery_executor becomes stuck if child process receives signal before reset_signals is called

2021-05-21 Thread GitBox
gdevanla commented on issue #15938: URL: https://github.com/apache/airflow/issues/15938#issuecomment-845692411 On a related note, we used to have `-r` option to recycle the scheduler. Looks like that option is not available anymore. That option would have been a nice workaround for this

[GitHub] [airflow-site] potiuk commented on issue #423: Please: can a 'quick start' or 'getting started' with detailed step by step instructions be provided for minimal real world software development

2021-05-21 Thread GitBox
potiuk commented on issue #423: URL: https://github.com/apache/airflow-site/issues/423#issuecomment-845683039 There is no "one way" to run airflow, however there are some useful articles, blog posts, videos and even hands-on Udemy courses that you can follow. Airflow is a community-driven

[GitHub] [airflow-site] potiuk closed issue #423: Please: can a 'quick start' or 'getting started' with detailed step by step instructions be provided for minimal real world software development?

2021-05-21 Thread GitBox
potiuk closed issue #423: URL: https://github.com/apache/airflow-site/issues/423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

<    1   2