[GitHub] [airflow] yuqian90 commented on issue #17012: NONE_FAILED_OR_SKIPPED and NONE_FAILED do the same

2021-07-19 Thread GitBox
yuqian90 commented on issue #17012: URL: https://github.com/apache/airflow/issues/17012#issuecomment-883089001 @uranusjr already explained the differences between these states. I just want to re-iterate that `none_failed_or_skipped` and `none_failed` are different. The difference is

[GitHub] [airflow] uranusjr edited a comment on pull request #16931: #16692 show cron description in UI

2021-07-19 Thread GitBox
uranusjr edited a comment on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-883067237 The problem is we can’t store the timetable object in db (at least not easily; it’s technically doable but should be avoided). Maybe we can pre-render the description

[GitHub] [airflow] uranusjr edited a comment on pull request #16931: #16692 show cron description in UI

2021-07-19 Thread GitBox
uranusjr edited a comment on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-883067237 The problem is we can’t store the timetable object in db (at least easily, technically doable but should be avoided). Maybe we can pre-render the description and

[GitHub] [airflow] pateash edited a comment on pull request #16931: #16692 show cron description in UI

2021-07-19 Thread GitBox
pateash edited a comment on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-883062473 @ashb @potiuk @kaxil @uranusjr @ryanahamilton Please correct me If I am wrong here, As far as I know we use DagModel object to render dag information in UI,

[GitHub] [airflow] uranusjr commented on pull request #16931: #16692 show cron description in UI

2021-07-19 Thread GitBox
uranusjr commented on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-883067237 The problem is we can’t store the timetable object in db (at least easily, technically doable but should be avoided). Maybe we can pre-render the description and store that

[GitHub] [airflow] pateash edited a comment on pull request #16931: #16692 show cron description in UI

2021-07-19 Thread GitBox
pateash edited a comment on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-883062473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] pateash edited a comment on pull request #16931: #16692 show cron description in UI

2021-07-19 Thread GitBox
pateash edited a comment on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-883062473 > > we can create a base class like DagBase which will have the common properties, but I think it's a overkill but a better approach so applying this. > > The

[GitHub] [airflow] pateash commented on pull request #16931: #16692 show cron description in UI

2021-07-19 Thread GitBox
pateash commented on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-883062473 > > we can create a base class like DagBase which will have the common properties, but I think it's a overkill but a better approach so applying this. > > The problem

[GitHub] [airflow] uranusjr commented on issue #10874: SSHHook get_conn() does not re-use client

2021-07-19 Thread GitBox
uranusjr commented on issue #10874: URL: https://github.com/apache/airflow/issues/10874#issuecomment-883048540 That would also mean `SSHHook` cannot be re-used though, because afaict `paramiko.SSHClient` does not support reopening a client once it’s closed. So if we do ```python

[GitHub] [airflow] uranusjr commented on issue #17084: Resources cannot be used due to issues with pickling

2021-07-19 Thread GitBox
uranusjr commented on issue #17084: URL: https://github.com/apache/airflow/issues/17084#issuecomment-883044707 I think this can basically be fixed by changing `Resources.__eq__()` to something like ```python if not isintance(other, type(self)): return False return

[GitHub] [airflow] uranusjr commented on issue #17088: MSSQL-2019 tests are failing

2021-07-19 Thread GitBox
uranusjr commented on issue #17088: URL: https://github.com/apache/airflow/issues/17088#issuecomment-883032995 Other MSSQL jobs are failing as well ``` INFO [airflow.models.dag] Setting next_dagrun for example_subdag_operator.section-2 to None Traceback (most recent call

[GitHub] [airflow] sudarshan2906 commented on issue #17044: Option to not show DAG import error in the UI

2021-07-19 Thread GitBox
sudarshan2906 commented on issue #17044: URL: https://github.com/apache/airflow/issues/17044#issuecomment-883026195 @mik-laj Yes agreed, Its not a bug and it is not possible with the current setup. What do think about disabling it via a config parameter? Just to not display it in the UI

[GitHub] [airflow] github-actions[bot] commented on pull request #17095: Fix error in Druid connection attribute retrieval

2021-07-19 Thread GitBox
github-actions[bot] commented on pull request #17095: URL: https://github.com/apache/airflow/pull/17095#issuecomment-883022861 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] BrunoSerafim commented on issue #13108: Airflow Scheduler on WSL fails to execute Windows EXE

2021-07-19 Thread GitBox
BrunoSerafim commented on issue #13108: URL: https://github.com/apache/airflow/issues/13108#issuecomment-883022450 I had the same issue. And I believe the problem is how the bashoperator parses the shell script. In the airflow bashoperator code the execute function tries to run "bash" +

[GitHub] [airflow] github-actions[bot] commented on pull request #17099: Adding EdgeModifier support for chain()

2021-07-19 Thread GitBox
github-actions[bot] commented on pull request #17099: URL: https://github.com/apache/airflow/pull/17099#issuecomment-883016938 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] josh-fell commented on a change in pull request #17099: Adding EdgeModifier support for chain()

2021-07-19 Thread GitBox
josh-fell commented on a change in pull request #17099: URL: https://github.com/apache/airflow/pull/17099#discussion_r672770679 ## File path: airflow/models/baseoperator.py ## @@ -1546,13 +1546,17 @@ def inherits_from_dummy_operator(self): return getattr(self,

[GitHub] [airflow] uranusjr commented on a change in pull request #17099: Adding EdgeModifier support for chain()

2021-07-19 Thread GitBox
uranusjr commented on a change in pull request #17099: URL: https://github.com/apache/airflow/pull/17099#discussion_r672768216 ## File path: airflow/models/baseoperator.py ## @@ -1546,13 +1546,17 @@ def inherits_from_dummy_operator(self): return getattr(self,

[GitHub] [airflow] josh-fell opened a new pull request #17099: Adding EdgeModifier support for chain()

2021-07-19 Thread GitBox
josh-fell opened a new pull request #17099: URL: https://github.com/apache/airflow/pull/17099 Closes: #17083 - Added support for EdgeModifier in chain() helper function - Added additional tests in test_baseoperator.py --- **^ Add meaningful description above**

[GitHub] [airflow] BShraman opened a new pull request #17098: Enhancement to bash scripts

2021-07-19 Thread GitBox
BShraman opened a new pull request #17098: URL: https://github.com/apache/airflow/pull/17098 Added return code check to minimized writing to txt file in every loop. **This request is just to review below changes** . I have added two different version for return code check logic.

[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py

2021-07-19 Thread GitBox
jmelot commented on a change in pull request #15959: URL: https://github.com/apache/airflow/pull/15959#discussion_r672749007 ## File path: airflow/providers/asana/example_dags/example_asana.py ## @@ -31,46 +33,62 @@ "owner": "airflow", } +ASANA_TASK_TO_UPDATE =

[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py

2021-07-19 Thread GitBox
jmelot commented on a change in pull request #15959: URL: https://github.com/apache/airflow/pull/15959#discussion_r672749007 ## File path: airflow/providers/asana/example_dags/example_asana.py ## @@ -31,46 +33,62 @@ "owner": "airflow", } +ASANA_TASK_TO_UPDATE =

[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py

2021-07-19 Thread GitBox
jmelot commented on a change in pull request #15959: URL: https://github.com/apache/airflow/pull/15959#discussion_r672749007 ## File path: airflow/providers/asana/example_dags/example_asana.py ## @@ -31,46 +33,62 @@ "owner": "airflow", } +ASANA_TASK_TO_UPDATE =

[airflow] branch main updated (896f351 -> 40595ae)

2021-07-19 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 896f351 Add more typing to airflow.utils.helpers (#15582) add 40595ae Fix static checks after merging

[GitHub] [airflow] mik-laj merged pull request #17096: Fix static checks after merging #17093

2021-07-19 Thread GitBox
mik-laj merged pull request #17096: URL: https://github.com/apache/airflow/pull/17096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17097: LatestOnlyOperator example from v1.10.15 documentation not working as expected

2021-07-19 Thread GitBox
boring-cyborg[bot] commented on issue #17097: URL: https://github.com/apache/airflow/issues/17097#issuecomment-882971927 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] spire-mike opened a new issue #17097: LatestOnlyOperator example from v1.10.15 documentation not working as expected

2021-07-19 Thread GitBox
spire-mike opened a new issue #17097: URL: https://github.com/apache/airflow/issues/17097 I am experimenting with the `LatestOnlyOperator` in Airflow 1.10.15. The [documentation shows](https://airflow.apache.org/docs/apache-airflow/1.10.15/concepts.html#latest-run-only) an example dag

[GitHub] [airflow] github-actions[bot] commented on pull request #17096: Fix static checks after merging #17093

2021-07-19 Thread GitBox
github-actions[bot] commented on pull request #17096: URL: https://github.com/apache/airflow/pull/17096#issuecomment-882962763 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] uranusjr commented on pull request #17096: Fix static checks after merging #17093

2021-07-19 Thread GitBox
uranusjr commented on pull request #17096: URL: https://github.com/apache/airflow/pull/17096#issuecomment-882962480 Beat me to it, thanks  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] mik-laj opened a new pull request #17096: Fix static checks after merging #17093

2021-07-19 Thread GitBox
mik-laj opened a new pull request #17096: URL: https://github.com/apache/airflow/pull/17096 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[airflow] branch main updated (3234527 -> 896f351)

2021-07-19 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3234527 Adds oauth libraries to PROD docker image (#17093) add 896f351 Add more typing to

[GitHub] [airflow] mik-laj merged pull request #15582: Add more typing to airflow.utils.helpers

2021-07-19 Thread GitBox
mik-laj merged pull request #15582: URL: https://github.com/apache/airflow/pull/15582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] SamWheating edited a comment on issue #11901: DAGs remain in the UI after renaming the dag_id in the same python file

2021-07-19 Thread GitBox
SamWheating edited a comment on issue #11901: URL: https://github.com/apache/airflow/issues/11901#issuecomment-882942563  Hey there, I was looking into this issue a bit today and it looks like the code which deactivates stale DAGs (DAGs which have not been recently parsed) will never be

[GitHub] [airflow] SamWheating edited a comment on issue #11901: DAGs remain in the UI after renaming the dag_id in the same python file

2021-07-19 Thread GitBox
SamWheating edited a comment on issue #11901: URL: https://github.com/apache/airflow/issues/11901#issuecomment-882946410 But even then, as @leonsmith identified, a renamed DAG will be marked as active again on the next pass:

[GitHub] [airflow] SamWheating edited a comment on issue #11901: DAGs remain in the UI after renaming the dag_id in the same python file

2021-07-19 Thread GitBox
SamWheating edited a comment on issue #11901: URL: https://github.com/apache/airflow/issues/11901#issuecomment-882946410 But even then, as @leonsmith identified, a renamed DAG will be marked as active again on the next pass:

[GitHub] [airflow] SamWheating commented on issue #11901: DAGs remain in the UI after renaming the dag_id in the same python file

2021-07-19 Thread GitBox
SamWheating commented on issue #11901: URL: https://github.com/apache/airflow/issues/11901#issuecomment-882946410 But even then, as @leonsmith identified, a renamed DAG will be marked as active again on the next pass:

[GitHub] [airflow] github-actions[bot] commented on pull request #15676: WIP: document chart values

2021-07-19 Thread GitBox
github-actions[bot] commented on pull request #15676: URL: https://github.com/apache/airflow/pull/15676#issuecomment-882943663 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on pull request #15749: Time range tolerance on external task sensor

2021-07-19 Thread GitBox
github-actions[bot] commented on pull request #15749: URL: https://github.com/apache/airflow/pull/15749#issuecomment-882943650 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] SamWheating commented on issue #11901: DAGs remain in the UI after renaming the dag_id in the same python file

2021-07-19 Thread GitBox
SamWheating commented on issue #11901: URL: https://github.com/apache/airflow/issues/11901#issuecomment-882942563  Hey there, I was looking into this issue a bit today and it looks like the code which deactivates stale DAGs will never be reached if the value of `scheduler.num_runs` isn't

[GitHub] [airflow] mik-laj commented on issue #17079: dag.cli should detect DAG cycles

2021-07-19 Thread GitBox
mik-laj commented on issue #17079: URL: https://github.com/apache/airflow/issues/17079#issuecomment-882940772 Cycles are checked by `DagBag`. https://github.com/apache/airflow/blob/3234527284ce01db67ba22c544f71ddaf28fa27e/airflow/models/dagbag.py#L429 In this case of `dag.cli()`, we

[GitHub] [airflow] iostreamdoth commented on issue #17089: cluster config generation using cluster config YAML file.

2021-07-19 Thread GitBox
iostreamdoth commented on issue #17089: URL: https://github.com/apache/airflow/issues/17089#issuecomment-882928050 Got it, I got confused with the Operator name earlier. Thanks @mik-laj -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] uranusjr commented on pull request #17093: Adds oauth libraries to PROD docker image

2021-07-19 Thread GitBox
uranusjr commented on pull request #17093: URL: https://github.com/apache/airflow/pull/17093#issuecomment-882922088 Oh wait I was wrong, the check failure was tryign to say this PR needs to *also* fix the documentation. I’ll fix it them. -- This is an automated message from the Apache

[airflow] branch main updated (d268016 -> 3234527)

2021-07-19 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from d268016 Chore: Some code cleanup in `airflow/utils/db.py` (#17090) add 3234527 Adds oauth libraries to PROD

[GitHub] [airflow] uranusjr closed issue #16944: Include `Authlib` in Airflow Docker images

2021-07-19 Thread GitBox
uranusjr closed issue #16944: URL: https://github.com/apache/airflow/issues/16944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr merged pull request #17093: Adds oauth libraries to PROD docker image

2021-07-19 Thread GitBox
uranusjr merged pull request #17093: URL: https://github.com/apache/airflow/pull/17093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on pull request #17093: Adds oauth libraries to PROD docker image

2021-07-19 Thread GitBox
uranusjr commented on pull request #17093: URL: https://github.com/apache/airflow/pull/17093#issuecomment-882921001 Static check failure is unrelated to this PR and needs to be fixed in `main`. (How did it get in there in the first place?) -- This is an automated message from the Apache

[GitHub] [airflow] mik-laj commented on issue #17089: cluster config generation using cluster config YAML file.

2021-07-19 Thread GitBox
mik-laj commented on issue #17089: URL: https://github.com/apache/airflow/issues/17089#issuecomment-882919242 @iostreamdoth ClusterGenerator from providers is legacy/deprecated method to generate dataproc cluster configuration. You should use `cluster_config` parameter. For details, see:

[GitHub] [airflow] mik-laj edited a comment on issue #17089: cluster config generation using cluster config YAML file.

2021-07-19 Thread GitBox
mik-laj edited a comment on issue #17089: URL: https://github.com/apache/airflow/issues/17089#issuecomment-882871939 > config generator DataprocCreateClusterOperatorClusterGenerator class is a deprecated and we are not adding new features to it. I think we can extend

[GitHub] [airflow] iostreamdoth edited a comment on issue #17089: cluster config generation using cluster config YAML file.

2021-07-19 Thread GitBox
iostreamdoth edited a comment on issue #17089: URL: https://github.com/apache/airflow/issues/17089#issuecomment-882914685 you mean `airflow.providers.google.cloud.operators.dataproc.DataprocCreateClusterOperator` or you mean

[GitHub] [airflow] iostreamdoth edited a comment on issue #17089: cluster config generation using cluster config YAML file.

2021-07-19 Thread GitBox
iostreamdoth edited a comment on issue #17089: URL: https://github.com/apache/airflow/issues/17089#issuecomment-882914685 you mean `airflow.providers.google.cloud.operators.dataproc.DataprocCreateClusterOperator` or you mean

[GitHub] [airflow] iostreamdoth commented on issue #17089: cluster config generation using cluster config YAML file.

2021-07-19 Thread GitBox
iostreamdoth commented on issue #17089: URL: https://github.com/apache/airflow/issues/17089#issuecomment-882914685 you mean `airflow.providers.google.cloud.operators.dataproc.DataprocCreateClusterOperator` or you mean

[GitHub] [airflow] uranusjr edited a comment on issue #17012: NONE_FAILED_OR_SKIPPED and NONE_FAILED do the same

2021-07-19 Thread GitBox
uranusjr edited a comment on issue #17012: URL: https://github.com/apache/airflow/issues/17012#issuecomment-882907844 I `git blame`-ed this and `NONE_FAILED_OR_SKIPPED` was added in #7464 to resolve [AIRFLOW-4453]. `NONE_FAILED_OR_SKIPPED` is intentionally implemented to be almost exactly

[GitHub] [airflow] uranusjr edited a comment on issue #17012: NONE_FAILED_OR_SKIPPED and NONE_FAILED do the same

2021-07-19 Thread GitBox
uranusjr edited a comment on issue #17012: URL: https://github.com/apache/airflow/issues/17012#issuecomment-882907844 I `git blame`-ed this and `NONE_FAILED_OR_SKIPPED` was added in #7464. `NONE_FAILED_OR_SKIPPED` is intentionally implemented to be almost exactly the same as

[GitHub] [airflow] uranusjr commented on issue #17012: NONE_FAILED_OR_SKIPPED and NONE_FAILED do the same

2021-07-19 Thread GitBox
uranusjr commented on issue #17012: URL: https://github.com/apache/airflow/issues/17012#issuecomment-882907844 I `git blame`-ed this and `NONE_FAILED_OR_SKIPPED` was added in #7464. `NONE_FAILED_OR_SKIPPED` is intentionally implemented to be almost exactly the same as `NONE_FAILED`, but

[GitHub] [airflow] ephraimbuddy commented on issue #16983: `on_failure_callback` on DAG level is not executed

2021-07-19 Thread GitBox
ephraimbuddy commented on issue #16983: URL: https://github.com/apache/airflow/issues/16983#issuecomment-882898678 Cool. Let's close the issue then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] ephraimbuddy closed issue #16983: `on_failure_callback` on DAG level is not executed

2021-07-19 Thread GitBox
ephraimbuddy closed issue #16983: URL: https://github.com/apache/airflow/issues/16983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on issue #16922: Using the string ".json" in a dag makes KubernetesPodOperator worker unable to trigger the pod

2021-07-19 Thread GitBox
kaxil commented on issue #16922: URL: https://github.com/apache/airflow/issues/16922#issuecomment-882882890 > > Did you actually have a `vivi.json` file so that jinja could pickup? The traceback you shared is different then the one posted on this issue. Your traceback says

[GitHub] [airflow] kaxil edited a comment on issue #17032: Improved SQL rendering within BigQueryInsertJobOperator

2021-07-19 Thread GitBox
kaxil edited a comment on issue #17032: URL: https://github.com/apache/airflow/issues/17032#issuecomment-882878793 Looks like usage of triple quotes adds line breaks -- https://stackoverflow.com/questions/19756715/remove-n-from-triple-quoted-string-in-python explains it better. I

[GitHub] [airflow] kaxil commented on issue #17032: Improved SQL rendering within BigQueryInsertJobOperator

2021-07-19 Thread GitBox
kaxil commented on issue #17032: URL: https://github.com/apache/airflow/issues/17032#issuecomment-882878793 Looks like usage of triple quotes adds line breaks -- https://stackoverflow.com/questions/19756715/remove-n-from-triple-quoted-string-in-python explains it better. I think

[GitHub] [airflow] mik-laj commented on issue #17089: cluster config generation using cluster config YAML file.

2021-07-19 Thread GitBox
mik-laj commented on issue #17089: URL: https://github.com/apache/airflow/issues/17089#issuecomment-882871939 > config generator DataprocCreateClusterOperator class is a deprecated and we are not adding new features to it. I think we can extend

[GitHub] [airflow] potiuk opened a new pull request #17095: Fix error in Druid connection attribute retrieval

2021-07-19 Thread GitBox
potiuk opened a new pull request #17095: URL: https://github.com/apache/airflow/pull/17095 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] josh-fell commented on pull request #17094: Adding SalesforceToS3Operator to Amazon Provider

2021-07-19 Thread GitBox
josh-fell commented on pull request #17094: URL: https://github.com/apache/airflow/pull/17094#issuecomment-882869245 @potiuk Sorry about earlier. Here is a fresh one. Thanks for your support as always! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] josh-fell opened a new pull request #17094: Adding SalesforceToS3Operator to Amazon Provider

2021-07-19 Thread GitBox
josh-fell opened a new pull request #17094: URL: https://github.com/apache/airflow/pull/17094 Closes: #16891 Creating an operator to extract data from Salesforce and upload to S3: `SalesforceToS3Operator` Items contained in this PR include: - Operator code:

[GitHub] [airflow] kaxil commented on issue #17054: Unable to trigger a DAG run via stable rest api

2021-07-19 Thread GitBox
kaxil commented on issue #17054: URL: https://github.com/apache/airflow/issues/17054#issuecomment-882864391 I can't reproduce this on Airflow 2.1.2: ``` ❯ curl -X POST -d '{"execution_date": "2021-01-01T15:00:00Z", "conf": {}}'

[GitHub] [airflow] github-actions[bot] commented on pull request #17093: Adds oauth libraries to PROD docker image

2021-07-19 Thread GitBox
github-actions[bot] commented on pull request #17093: URL: https://github.com/apache/airflow/pull/17093#issuecomment-882863316 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on pull request #16829: Queue support for DaskExecutor using Dask Worker Resources

2021-07-19 Thread GitBox
potiuk commented on pull request #16829: URL: https://github.com/apache/airflow/pull/16829#issuecomment-882854356 Unfortunately I have very little knowledge of Dask Executor. Anyone who can help with it . (and @aa1371 - can you please rebase to latest main)? -- This is an automated

[GitHub] [airflow] jzuhusky commented on pull request #16166: Fixing SES backend - source (mail_from) must be string.

2021-07-19 Thread GitBox
jzuhusky commented on pull request #16166: URL: https://github.com/apache/airflow/pull/16166#issuecomment-882853853 @potiuk @satishmittal111 @mik-laj Any updates here? I just ran into this issue. Seems like the fix is done? Any idea when this might be released? -- This is an

[GitHub] [airflow] potiuk commented on pull request #16795: GCP Dataflow - Fixed getting job status by job id

2021-07-19 Thread GitBox
potiuk commented on pull request #16795: URL: https://github.com/apache/airflow/pull/16795#issuecomment-882853060 Can you please rebase to latest main? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on pull request #16945: Enable using custom pod launcher in Kubernetes Pod Operator

2021-07-19 Thread GitBox
potiuk commented on pull request #16945: URL: https://github.com/apache/airflow/pull/16945#issuecomment-882849125 Can you please rebase to latest main @mgorsk1 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] github-actions[bot] commented on pull request #16945: Enable using custom pod launcher in Kubernetes Pod Operator

2021-07-19 Thread GitBox
github-actions[bot] commented on pull request #16945: URL: https://github.com/apache/airflow/pull/16945#issuecomment-882848932 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] potiuk commented on pull request #16980: Change pod id notation back to hyphen

2021-07-19 Thread GitBox
potiuk commented on pull request #16980: URL: https://github.com/apache/airflow/pull/16980#issuecomment-882846913 Could you please rebase to latest main? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] ferruzzi commented on a change in pull request #16571: Implemented Basic EKS Integration

2021-07-19 Thread GitBox
ferruzzi commented on a change in pull request #16571: URL: https://github.com/apache/airflow/pull/16571#discussion_r672618235 ## File path: airflow/providers/amazon/aws/hooks/eks.py ## @@ -0,0 +1,346 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk closed issue #16938: Airflow + AWS SES HTTP Api: Error Invalid type for parameter Source, value: None, type: , valid types:

2021-07-19 Thread GitBox
potiuk closed issue #16938: URL: https://github.com/apache/airflow/issues/16938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #16938: Airflow + AWS SES HTTP Api: Error Invalid type for parameter Source, value: None, type: , valid types:

2021-07-19 Thread GitBox
potiuk commented on issue #16938: URL: https://github.com/apache/airflow/issues/16938#issuecomment-882846264 Duplicate of #16166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk opened a new pull request #17093: Adds oauth libraries to PROD docker image

2021-07-19 Thread GitBox
potiuk opened a new pull request #17093: URL: https://github.com/apache/airflow/pull/17093 The flask OAuth requires oauth libraries and this case is frequent enough to be added to the reference image. Fixes: #16944 --- **^ Add meaningful description above**

[GitHub] [airflow] jarfgit commented on issue #8448: Create S3ListPrefixesOperator that returns subfolders from an S3 bucket.

2021-07-19 Thread GitBox
jarfgit commented on issue #8448: URL: https://github.com/apache/airflow/issues/8448#issuecomment-882838957 I'd like to re-open and address this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] jarfgit removed a comment on pull request #8464: Add operator to list subfolders from s3 bucket

2021-07-19 Thread GitBox
jarfgit removed a comment on pull request #8464: URL: https://github.com/apache/airflow/pull/8464#issuecomment-882837234 I'd like to re-open and address this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] dacort commented on pull request #16766: Add an Amazon EMR on EKS provider package

2021-07-19 Thread GitBox
dacort commented on pull request #16766: URL: https://github.com/apache/airflow/pull/16766#issuecomment-882837737 @potiuk Yep, rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] jarfgit commented on pull request #8464: Add operator to list subfolders from s3 bucket

2021-07-19 Thread GitBox
jarfgit commented on pull request #8464: URL: https://github.com/apache/airflow/pull/8464#issuecomment-882837234 I'd like to re-open and address this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk closed issue #8759: Log rotation for scheduler logs

2021-07-19 Thread GitBox
potiuk closed issue #8759: URL: https://github.com/apache/airflow/issues/8759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #8759: Log rotation for scheduler logs

2021-07-19 Thread GitBox
potiuk commented on issue #8759: URL: https://github.com/apache/airflow/issues/8759#issuecomment-882835326 In modern deployments logs are handled usually by the deployment/externally. I do not think rotating the logs makes airflow Crash (that would be pretty suriprising given than airlfow

[GitHub] [airflow] kaxil edited a comment on issue #17085: Configuration validation for run-configs

2021-07-19 Thread GitBox
kaxil edited a comment on issue #17085: URL: https://github.com/apache/airflow/issues/17085#issuecomment-882834756 cc @msumit -- Sumit has implemented something already for it :) He will be opening a PR soon -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] kaxil commented on issue #17085: Configuration validation for run-configs

2021-07-19 Thread GitBox
kaxil commented on issue #17085: URL: https://github.com/apache/airflow/issues/17085#issuecomment-882834756 cc @msumit -- Sumit has implemented something already for it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[airflow] branch main updated (a1d3b27 -> d268016)

2021-07-19 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from a1d3b27 Parse template parameters field for MySQL operator (#17080) add d268016 Chore: Some code cleanup in

[GitHub] [airflow] kaxil merged pull request #17090: Chore: Some code cleanup in `airflow/utils/db.py`

2021-07-19 Thread GitBox
kaxil merged pull request #17090: URL: https://github.com/apache/airflow/pull/17090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #16979: Support run multiple sql statements from file in DBApiHook

2021-07-19 Thread GitBox
potiuk commented on issue #16979: URL: https://github.com/apache/airflow/issues/16979#issuecomment-882830072 Yeah. Sounds like the third time is the charm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] kaxil commented on issue #15563: airflow dag can't be deleted cleanly

2021-07-19 Thread GitBox
kaxil commented on issue #15563: URL: https://github.com/apache/airflow/issues/15563#issuecomment-882826379 Are you sure you deleted the DAG File, as your statements contradict. In **What Happened** you say that you removed the dag file, but in **Anything else we need to know** you say

[GitHub] [airflow] trucnguyenlam commented on issue #16983: `on_failure_callback` on DAG level is not executed

2021-07-19 Thread GitBox
trucnguyenlam commented on issue #16983: URL: https://github.com/apache/airflow/issues/16983#issuecomment-882824881 @ephraimbuddy I checked the location of the log, the callback does get handled. So it is technically working for me. Thanks. -- This is an automated message from the

[GitHub] [airflow] potiuk commented on pull request #16766: Add an Amazon EMR on EKS provider package

2021-07-19 Thread GitBox
potiuk commented on pull request #16766: URL: https://github.com/apache/airflow/pull/16766#issuecomment-882821163 Can you please rebase to latest main ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider

2021-07-19 Thread GitBox
potiuk commented on pull request #17036: URL: https://github.com/apache/airflow/pull/17036#issuecomment-882814671 No problem. This happens often too. We move fast! and sometimes the best thing is to close and apply changes from the scratch -- This is an automated message from the

[GitHub] [airflow] josh-fell edited a comment on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider

2021-07-19 Thread GitBox
josh-fell edited a comment on pull request #17036: URL: https://github.com/apache/airflow/pull/17036#issuecomment-882813742 ~~@potiuk Would you mind closing this PR? I'll open a new one. Sorry for really mucking this up.~~ -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] josh-fell closed pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider

2021-07-19 Thread GitBox
josh-fell closed pull request #17036: URL: https://github.com/apache/airflow/pull/17036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] josh-fell commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider

2021-07-19 Thread GitBox
josh-fell commented on pull request #17036: URL: https://github.com/apache/airflow/pull/17036#issuecomment-882813742 @potiuk Would you mind closing this PR? I'll open a new one. Sorry for really mucking this up. -- This is an automated message from the Apache Git Service. To respond to

[airflow] branch main updated (a4af964 -> a1d3b27)

2021-07-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from a4af964 Translate non-ascii characters (#17057) add a1d3b27 Parse template parameters field for MySQL operator

[GitHub] [airflow] potiuk merged pull request #17080: Parse JSON template parameters field for MySQL operator

2021-07-19 Thread GitBox
potiuk merged pull request #17080: URL: https://github.com/apache/airflow/pull/17080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (1a0730a -> a4af964)

2021-07-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1a0730a #16976 Add json.dumps() for templated fields objects: 'dict' and 'list' (#17082) add a4af964

[GitHub] [airflow] potiuk merged pull request #17057: Strip non-ascii characters in pod name on k8s executor

2021-07-19 Thread GitBox
potiuk merged pull request #17057: URL: https://github.com/apache/airflow/pull/17057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #16992: Pod fails to run when task or dag name contains non ASCII characters (k8s executor)

2021-07-19 Thread GitBox
potiuk closed issue #16992: URL: https://github.com/apache/airflow/issues/16992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17090: Chore: Some code cleanup in `airflow/utils/db.py`

2021-07-19 Thread GitBox
github-actions[bot] commented on pull request #17090: URL: https://github.com/apache/airflow/pull/17090#issuecomment-882809521 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on issue #17012: NONE_FAILED_OR_SKIPPED and NONE_FAILED do the same

2021-07-19 Thread GitBox
potiuk commented on issue #17012: URL: https://github.com/apache/airflow/issues/17012#issuecomment-882808812 Looks about right. For the sake of backwards compatibility I'd merge it in one IF and deprecate one of those. Anyone? -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] kaxil opened a new pull request #17090: Chore: Some code cleanup in `airflow/utils/db.py`

2021-07-19 Thread GitBox
kaxil opened a new pull request #17090: URL: https://github.com/apache/airflow/pull/17090 As part of https://github.com/apache/airflow/pull/17078, a separate `filldb` function was created which isn't needed as it isn't used anywhere outof `initdb` --- **^ Add meaningful

  1   2   3   >