[GitHub] [airflow] uranusjr commented on a change in pull request #17265: Use `dag_maker` fixture in test_scheduler_job.py

2021-08-08 Thread GitBox
uranusjr commented on a change in pull request #17265: URL: https://github.com/apache/airflow/pull/17265#discussion_r684942112 ## File path: tests/jobs/test_scheduler_job.py ## @@ -495,45 +439,24 @@ def test_find_executable_task_instances_pool(self): assert tis[3].key

[GitHub] [airflow] uranusjr commented on a change in pull request #17485: Pass explicit state, not a success boolean

2021-08-08 Thread GitBox
uranusjr commented on a change in pull request #17485: URL: https://github.com/apache/airflow/pull/17485#discussion_r684933868 ## File path: airflow/executors/base_executor.py ## @@ -97,6 +100,15 @@ def queue_task_instance( cfg_path: Optional[str] = None, ) -> Non

[GitHub] [airflow] uranusjr commented on a change in pull request #17485: Pass explicit state, not a success boolean

2021-08-08 Thread GitBox
uranusjr commented on a change in pull request #17485: URL: https://github.com/apache/airflow/pull/17485#discussion_r684932622 ## File path: airflow/cli/cli_parser.py ## @@ -219,7 +221,17 @@ def _check(value): # backfill ARG_MARK_SUCCESS = Arg( -("-m", "--mark-success")

[airflow] branch main updated: Use `dag_maker` in tests/core/test_core.py (#17462)

2021-08-08 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new daece96 Use `dag_maker` in tests/core/test_core.

[GitHub] [airflow] uranusjr merged pull request #17462: Use `dag_maker` in tests/core/test_core.py

2021-08-08 Thread GitBox
uranusjr merged pull request #17462: URL: https://github.com/apache/airflow/pull/17462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] uranusjr commented on pull request #17462: Use `dag_maker` in tests/core/test_core.py

2021-08-08 Thread GitBox
uranusjr commented on pull request #17462: URL: https://github.com/apache/airflow/pull/17462#issuecomment-894974360 `test_add_unparseable_file_before_sched_start_creates_import_error` and `test_mark_success_on_success_callback` have been really flaky recently. -- This is an automated mes

[GitHub] [airflow] github-actions[bot] commented on pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator

2021-08-08 Thread GitBox
github-actions[bot] commented on pull request #17496: URL: https://github.com/apache/airflow/pull/17496#issuecomment-894973305 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-08 Thread GitBox
Sonins edited a comment on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 I wrote new test coverage in test_elasticsearch_secret.py. Here's my local test result. with original template ``` root@cbffb11c21aa:/opt/airflow# pytest

[GitHub] [airflow] uranusjr commented on issue #17493: BigQueryInsertJobOperator may start the same job twice

2021-08-08 Thread GitBox
uranusjr commented on issue #17493: URL: https://github.com/apache/airflow/issues/17493#issuecomment-894970193 We have ceased maintenance of Airflow 1.10. Please consider upgrading to Airflow 2. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [airflow] uranusjr closed issue #17493: BigQueryInsertJobOperator may start the same job twice

2021-08-08 Thread GitBox
uranusjr closed issue #17493: URL: https://github.com/apache/airflow/issues/17493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [airflow] EliMor edited a comment on issue #17489: Helm chart converts ' ' to '+' in passwords (and username)

2021-08-08 Thread GitBox
EliMor edited a comment on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894841242 Hi people! I thought it was strange that it was encoded as '+' as well!! Here's a more clear example... If I have in my values.yaml file: ``` met

[GitHub] [airflow] uranusjr commented on a change in pull request #17068: Influxdb Hook

2021-08-08 Thread GitBox
uranusjr commented on a change in pull request #17068: URL: https://github.com/apache/airflow/pull/17068#discussion_r684911389 ## File path: tests/providers/influxdb/operators/test_influxDbHook.py ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] uranusjr commented on a change in pull request #17068: Influxdb Hook

2021-08-08 Thread GitBox
uranusjr commented on a change in pull request #17068: URL: https://github.com/apache/airflow/pull/17068#discussion_r684910691 ## File path: airflow/providers/influxdb/hooks/influxdb.py ## @@ -0,0 +1,166 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] uranusjr commented on a change in pull request #17068: Influxdb Hook

2021-08-08 Thread GitBox
uranusjr commented on a change in pull request #17068: URL: https://github.com/apache/airflow/pull/17068#discussion_r684907749 ## File path: airflow/providers/influxdb/example_dags/example_influxdb.py ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] EliMor edited a comment on issue #17489: Helm chart converts ' ' to '+' in passwords (and username)

2021-08-08 Thread GitBox
EliMor edited a comment on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894863824 Apologies for my bad assumption(s)! That's annoying! Small minefield for me to remember now. To minimize confusion to potential readers, I've corrected the issu

[GitHub] [airflow] EliMor edited a comment on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
EliMor edited a comment on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894841242 Hi people! I thought it was strange that it was encoded as '+' as well!! Here's a more clear example... If I have in my values.yaml file: ``` met

[GitHub] [airflow] EliMor edited a comment on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
EliMor edited a comment on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894841242 Hi people! I thought it was strange that it was encoded as '+' as well!! Here's a more clear example... If I have in my values.yaml file: ``` met

[GitHub] [airflow] EliMor edited a comment on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
EliMor edited a comment on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894841242 Hi people! I thought it was strange that it was encoded as '+' as well!! Here's a more clear example... If I have in my values.yaml file: ``` met

[GitHub] [airflow] EliMor edited a comment on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
EliMor edited a comment on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894841242 Hi people! I thought it was strange that it was encoded as '+' as well!! Here's a more clear example... If I have in my values.yaml file: ``` met

[GitHub] [airflow] subkanthi commented on issue #17494: Lint Dockerfile - pre_commit_lint_dockerfile.sh takes too long or gets stuck

2021-08-08 Thread GitBox
subkanthi commented on issue #17494: URL: https://github.com/apache/airflow/issues/17494#issuecomment-894915360 > You can always disable it by setting SKIP variable in the meantime https://pre-commit.com/#temporarily-disabling-hooks (as a workaround) Thanks that helps for now -- T

[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-08 Thread GitBox
Sonins edited a comment on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 I wrote new test coverage. Here's my local test result. with original template ``` root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_

[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-08 Thread GitBox
Sonins edited a comment on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 I wrote new test coverage. Here's my local test result. with original template ``` root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_

[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-08 Thread GitBox
Sonins edited a comment on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 I wrote new test coverage. Here's my local test result. with original template ``` root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_

[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-08 Thread GitBox
Sonins edited a comment on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 I wrote new test coverage. Here's my local test result. with original template ``` root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_

[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-08 Thread GitBox
Sonins edited a comment on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 I wrote new test coverage. Here's my local test result. with original template ``` root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_

[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-08 Thread GitBox
Sonins edited a comment on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 I wrote new test coverage. Here's my local test result. with original template ``` root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_

[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-08 Thread GitBox
Sonins edited a comment on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 I wrote new test coverage. Here's my local test result. with original template ``` root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsearch_

[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-08 Thread GitBox
Sonins edited a comment on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 OK. I wrote new test coverage. Here's my local test result. with original template ``` root@cbffb11c21aa:/opt/airflow# pytest chart/tests/test_elasticsea

[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-08 Thread GitBox
Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 OK. I wrote new test coverage. Here's my local test result. with original template ``` ``` -- This is an automated message from the Apache Git Ser

[GitHub] [airflow] fatmumuhomer commented on a change in pull request #17236: [Airflow 16364] Add conn_timeout and cmd_timeout params to SSHOperator; add conn_timeout param to SSHHook

2021-08-08 Thread GitBox
fatmumuhomer commented on a change in pull request #17236: URL: https://github.com/apache/airflow/pull/17236#discussion_r684854398 ## File path: tests/providers/ssh/hooks/test_ssh.py ## @@ -475,6 +504,122 @@ def test_ssh_connection_with_no_host_key_where_no_host_key_check_is_f

[GitHub] [airflow] mik-laj commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
mik-laj commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684852280 ## File path: docs/apache-airflow/start/docker.rst ## @@ -124,6 +123,22 @@ After initialization is complete, you should see a message like below. Th

[GitHub] [airflow] mik-laj commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
mik-laj commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684852160 ## File path: docs/apache-airflow/start/docker.rst ## @@ -124,6 +123,22 @@ After initialization is complete, you should see a message like below. Th

[GitHub] [airflow] mik-laj commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
mik-laj commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684852147 ## File path: docs/apache-airflow/start/docker.rst ## @@ -124,6 +123,22 @@ After initialization is complete, you should see a message like below. Th

[GitHub] [airflow] github-actions[bot] commented on issue #16354: Airflow 2.0.2 export and import variables from CLI has an issue

2021-08-08 Thread GitBox
github-actions[bot] commented on issue #16354: URL: https://github.com/apache/airflow/issues/16354#issuecomment-894878188 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] closed issue #16354: Airflow 2.0.2 export and import variables from CLI has an issue

2021-08-08 Thread GitBox
github-actions[bot] closed issue #16354: URL: https://github.com/apache/airflow/issues/16354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [airflow] github-actions[bot] commented on pull request #14820: `sync_resource_permissions` should be called during initialization.

2021-08-08 Thread GitBox
github-actions[bot] commented on pull request #14820: URL: https://github.com/apache/airflow/pull/14820#issuecomment-894878206 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank y

[GitHub] [airflow] github-actions[bot] commented on pull request #14641: Remove the default config from the Configuration View, show only running configuration

2021-08-08 Thread GitBox
github-actions[bot] commented on pull request #14641: URL: https://github.com/apache/airflow/pull/14641#issuecomment-894878213 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank y

[GitHub] [airflow] mik-laj commented on pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
mik-laj commented on pull request #17484: URL: https://github.com/apache/airflow/pull/17484#issuecomment-894866653 This docker-compose file support at least Airflow 2.1, because we use `airflow jobs check` command. https://github.com/apache/airflow/blob/d19e61a7e4fe8b7a315e6fc17b670f4f2

[GitHub] [airflow] EliMor edited a comment on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
EliMor edited a comment on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894863824 Apologies for my bad assumption! That's annoying! Small minefield for me to remember now. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] EliMor commented on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
EliMor commented on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894863824 Apologies for my bad assumption! That's annoying! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [airflow] hsej commented on issue #17493: BigQueryInsertJobOperator may start the same job twice

2021-08-08 Thread GitBox
hsej commented on issue #17493: URL: https://github.com/apache/airflow/issues/17493#issuecomment-894863507 Sorry! Thank you very much for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [airflow] potiuk commented on pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on pull request #17484: URL: https://github.com/apache/airflow/pull/17484#issuecomment-894857985 Also added some instructions on how to cleanup the docker-compose environment. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] potiuk commented on pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on pull request #17484: URL: https://github.com/apache/airflow/pull/17484#issuecomment-894856984 Seems the version check works nice - also (as a side effect) the checks for resources /IUID/GID happen before the database initialization and it will make it faster to give fee

[airflow] branch main updated (ef1b124 -> d19e61a)

2021-08-08 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from ef1b124 Use `dag_maker` fixture in models/test_taskinstance.py (#17425) add d19e61a Improve breeze resource ch

[GitHub] [airflow] potiuk merged pull request #17492: Improve breeze resource check

2021-08-08 Thread GitBox
potiuk merged pull request #17492: URL: https://github.com/apache/airflow/pull/17492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] blcksrx opened a new pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator

2021-08-08 Thread GitBox
blcksrx opened a new pull request #17496: URL: https://github.com/apache/airflow/pull/17496 The `job.result` method already invokes on the `hook.insert_job` method, so basically it's duplicated beside of the referenced issue. https://github.com/apache/airflow/blob/ef1b1242a8907c1f526bb3

[GitHub] [airflow] potiuk commented on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
potiuk commented on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894851965 @jedcunningham @kaxil : from what I can see (and what seems to be confirmed by https://github.com/pallets/jinja/issues/17 - it seems that the "urlquery" filter we use is wrong. It

[GitHub] [airflow] ephraimbuddy closed pull request #17462: Use `dag_maker` in tests/core/test_core.py

2021-08-08 Thread GitBox
ephraimbuddy closed pull request #17462: URL: https://github.com/apache/airflow/pull/17462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[airflow] branch main updated (b311bc0 -> ef1b124)

2021-08-08 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from b311bc0 add deprecation notice for SubDagOperator (#17488) add ef1b124 Use `dag_maker` fixture in mode

[GitHub] [airflow] ephraimbuddy merged pull request #17425: Use `dag_maker` fixture in models/test_taskinstance.py

2021-08-08 Thread GitBox
ephraimbuddy merged pull request #17425: URL: https://github.com/apache/airflow/pull/17425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [airflow] josh-fell opened a new issue #17495: Add an operator and sensor for Azure Data Factory pipeline runs

2021-08-08 Thread GitBox
josh-fell opened a new issue #17495: URL: https://github.com/apache/airflow/issues/17495 **Description** Azure Data Factory (ADF) is a fully-managed, orchestration and integration service that allows users to run data pipelines easily within the Azure ecosystem. Currently there is only

[GitHub] [airflow] potiuk commented on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
potiuk commented on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894850015 @jedcunningham @kaxil -> I think this one is pretty legit, if ' ' is encoded as '+' in the URI, this is pretty wrong, possibly we could use different encoding function in the chart

[GitHub] [airflow] potiuk commented on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
potiuk commented on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894849733 Actually it should work (and is the only correct way!!!) if you replace it with: ``` postgresql://airflow:top%20secret%20passw...@fakedb.us-west-2.rds.amazonaws.com:5432/p

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684822272 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on pull request #17484: URL: https://github.com/apache/airflow/pull/17484#issuecomment-894847717 I just double-checked and indeed Airflow 2.0.0 an 2.0.1 would not work. I have added adjustment and min-version check that will work for all versions. So I've added an extra ch

[GitHub] [airflow] EliMor edited a comment on issue #17490: KubernetesJobOperator

2021-08-08 Thread GitBox
EliMor edited a comment on issue #17490: URL: https://github.com/apache/airflow/issues/17490#issuecomment-894843706 Thanks for your time and teaching me some new things today! Ray+Airflow looks very neat. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [airflow] EliMor commented on issue #17490: KubernetesJobOperator

2021-08-08 Thread GitBox
EliMor commented on issue #17490: URL: https://github.com/apache/airflow/issues/17490#issuecomment-894843706 Thanks for teaching me some new things today! Ray+Airflow looks very neat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] EliMor edited a comment on issue #17490: KubernetesJobOperator

2021-08-08 Thread GitBox
EliMor edited a comment on issue #17490: URL: https://github.com/apache/airflow/issues/17490#issuecomment-894764947 Yes there's a lot of discussion that could be had here I think. I like your impulse to make a higher tier 'Base' kube operator. Something dumb that we could reuse even

[GitHub] [airflow] EliMor edited a comment on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
EliMor edited a comment on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894841242 Hi people! I thought it was strange that it was encoded as '+' as well!! Here's a more clear example... If I have in my values.yaml file: ``` met

[GitHub] [airflow] EliMor commented on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
EliMor commented on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894841242 Hi people! I thought it was strange that it was encoded as '+' as well!! Here's a more clear example... If I have in my values.yaml file: ``` metadataCo

[GitHub] [airflow] mariotaddeucci commented on a change in pull request #16915: New generic tableau operator: TableauOperator

2021-08-08 Thread GitBox
mariotaddeucci commented on a change in pull request #16915: URL: https://github.com/apache/airflow/pull/16915#discussion_r684814365 ## File path: docs/apache-airflow-providers-tableau/operators.rst ## @@ -0,0 +1,101 @@ +.. Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684808729 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684807699 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684807699 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684807699 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684807699 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684806153 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684806153 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk edited a comment on issue #17494: Lint Dockerfile - pre_commit_lint_dockerfile.sh takes too long or gets stuck

2021-08-08 Thread GitBox
potiuk edited a comment on issue #17494: URL: https://github.com/apache/airflow/issues/17494#issuecomment-894830708 You can always disable it by setting SKIP variable in the meantime https://pre-commit.com/#temporarily-disabling-hooks (as a workaround) -- This is an automated message fro

[GitHub] [airflow] potiuk commented on issue #17494: Lint Dockerfile - pre_commit_lint_dockerfile.sh takes too long or gets stuck

2021-08-08 Thread GitBox
potiuk commented on issue #17494: URL: https://github.com/apache/airflow/issues/17494#issuecomment-894830708 You can always disable it by setting SKIP variable in the meantime https://pre-commit.com/#temporarily-disabling-hooks -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684806153 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] ferruzzi commented on a change in pull request #16571: Implemented Basic EKS Integration

2021-08-08 Thread GitBox
ferruzzi commented on a change in pull request #16571: URL: https://github.com/apache/airflow/pull/16571#discussion_r684804950 ## File path: airflow/providers/amazon/aws/hooks/eks.py ## @@ -0,0 +1,420 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

[GitHub] [airflow] github-actions[bot] commented on pull request #16915: New generic tableau operator: TableauOperator

2021-08-08 Thread GitBox
github-actions[bot] commented on pull request #16915: URL: https://github.com/apache/airflow/pull/16915#issuecomment-894828010 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] eladkal commented on a change in pull request #16915: New generic tableau operator: TableauOperator

2021-08-08 Thread GitBox
eladkal commented on a change in pull request #16915: URL: https://github.com/apache/airflow/pull/16915#discussion_r684804186 ## File path: docs/apache-airflow-providers-tableau/operators.rst ## @@ -0,0 +1,101 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684803118 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684803118 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684803118 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk edited a comment on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
potiuk edited a comment on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894825583 Yeah @mik-laj is right. You can also see examples of that explained in our documentation - https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#handlin

[GitHub] [airflow] potiuk commented on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
potiuk commented on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894825583 Yeah @mik-laj is right. You can also see examples of that explained in our documentation - https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#handling-of-sp

[airflow] branch constraints-main updated: Update to latest main constraints

2021-08-08 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 7efdda2 Update to latest m

[GitHub] [airflow] mik-laj commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
mik-laj commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684799944 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on pull request #16915: New generic tableau operator: TableauOperator

2021-08-08 Thread GitBox
potiuk commented on pull request #16915: URL: https://github.com/apache/airflow/pull/16915#issuecomment-894820131 New dependency was added by new provider and you need to rebase to get it working I am afraid :) -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684792456 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684791040 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684792456 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684792456 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] mariotaddeucci edited a comment on pull request #16915: New generic tableau operator: TableauOperator

2021-08-08 Thread GitBox
mariotaddeucci edited a comment on pull request #16915: URL: https://github.com/apache/airflow/pull/16915#issuecomment-894816512 @eladkal the last commit haven't passed on on `CI Build / Build and test provider packages wheel` because pypsrc on Microsoft provider and wasn't caused by this

[GitHub] [airflow] mariotaddeucci edited a comment on pull request #16915: New generic tableau operator: TableauOperator

2021-08-08 Thread GitBox
mariotaddeucci edited a comment on pull request #16915: URL: https://github.com/apache/airflow/pull/16915#issuecomment-894816512 @eladkal the last commit haven't passed on on `CI Build / Build and test provider packages wheel` because pypsrc on Microsoft and wasn't caused by this PR. Is th

[GitHub] [airflow] mariotaddeucci commented on pull request #16915: New generic tableau operator: TableauOperator

2021-08-08 Thread GitBox
mariotaddeucci commented on pull request #16915: URL: https://github.com/apache/airflow/pull/16915#issuecomment-894816512 @eladkal the last commit haven't passed on on CI Build / Build and test provider packages wheel because pypsrc on Microsoft and wasn't caused by this PR. Is there anyth

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684792456 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684792456 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684791040 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684790627 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684790441 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] potiuk commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
potiuk commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684790125 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] mik-laj commented on issue #17489: Helm chart converts ' ' to '+' in passwords due to urlJoin helm function

2021-08-08 Thread GitBox
mik-laj commented on issue #17489: URL: https://github.com/apache/airflow/issues/17489#issuecomment-894810340 Space is a character not allowed in the URI, so it should be percent-encoded. We used to have errors with the handling of special characters in passwords. https://github.com/apa

[GitHub] [airflow] subkanthi opened a new issue #17494: Lint Dockerfile - pre_commit_lint_dockerfile.sh takes too long or gets stuck

2021-08-08 Thread GitBox
subkanthi opened a new issue #17494: URL: https://github.com/apache/airflow/issues/17494 On Mac M1, the "Lint Dockerfile" pre-commit step takes forever to complete. Need to troubleshoot and add a fix for this problem. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [airflow] mik-laj commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
mik-laj commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684776354 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] mik-laj commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
mik-laj commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684776007 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

[GitHub] [airflow] mik-laj commented on a change in pull request #17484: Better diagnostics and self-healing of docker-compose

2021-08-08 Thread GitBox
mik-laj commented on a change in pull request #17484: URL: https://github.com/apache/airflow/pull/17484#discussion_r684775296 ## File path: docs/apache-airflow/start/docker-compose.yaml ## @@ -146,13 +146,54 @@ services: airflow-init: <<: *airflow-common -command:

  1   2   >