[GitHub] [airflow] uranusjr commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
uranusjr commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r694509540 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -62,15 +62,12 @@ def logging_and_db(self): (as the test environment

[GitHub] [airflow] uranusjr commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
uranusjr commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r694508782 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -228,6 +225,8 @@ def test_on_kill(self): for process in processes:

[GitHub] [airflow] uranusjr edited a comment on issue #17800: BigQueryCreateExternalTableOperator from providers package fails to get schema from GCS object

2021-08-23 Thread GitBox
uranusjr edited a comment on issue #17800: URL: https://github.com/apache/airflow/issues/17800#issuecomment-904336344 It feels weird to me the use of `download_as_string` results in a 404, the issue seems to be separate. A PR fixing `download_as_string` would be very much welcomed, but I

[GitHub] [airflow] uranusjr commented on issue #17800: BigQueryCreateExternalTableOperator from providers package fails to get schema from GCS object

2021-08-23 Thread GitBox
uranusjr commented on issue #17800: URL: https://github.com/apache/airflow/issues/17800#issuecomment-904336344 I feels weird to me the use of `download_as_string` results in a 404, the issue seems to be separate. A PR fixing `download_as_string` would be very much welcomed, but I suspect

[airflow] branch main updated: Fix missing whitespace in ``apply_default`` deprecation message (#17799)

2021-08-23 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 41e3a91 Fix missing whitespace in

[GitHub] [airflow] uranusjr merged pull request #17799: Fix missing whitespace in ``apply_default`` deprecation message

2021-08-23 Thread GitBox
uranusjr merged pull request #17799: URL: https://github.com/apache/airflow/pull/17799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on a change in pull request #17777: get_pandas_df() fails when it tries to read an empty table

2021-08-23 Thread GitBox
uranusjr commented on a change in pull request #1: URL: https://github.com/apache/airflow/pull/1#discussion_r694503504 ## File path: tests/providers/apache/hive/hooks/test_hive.py ## @@ -687,6 +687,13 @@ def test_get_pandas_df(self):

[GitHub] [airflow] uranusjr commented on issue #17795: Circular Dependency in Apache Airflow 2.1.3

2021-08-23 Thread GitBox
uranusjr commented on issue #17795: URL: https://github.com/apache/airflow/issues/17795#issuecomment-904329243 FWIW circular dependencies are allowed in Python (in other words, a project’s Python package dependencies is not a DAG), so Bazel not supporting it is a bug (or missing feature).

[GitHub] [airflow] edwardwang888 edited a comment on issue #16877: Cleared task instances in manual runs should have borders

2021-08-23 Thread GitBox
edwardwang888 edited a comment on issue #16877: URL: https://github.com/apache/airflow/issues/16877#issuecomment-904297333 @bbovenzi Sorry for the delay! I have my local development environment setup now, and am playing around with `tree.js`. I will reach out either here or on Slack if I

[GitHub] [airflow] edwardwang888 edited a comment on issue #16877: Cleared task instances in manual runs should have borders

2021-08-23 Thread GitBox
edwardwang888 edited a comment on issue #16877: URL: https://github.com/apache/airflow/issues/16877#issuecomment-904297333 @bbovenzi Sorry for the delay. I have my local development environment setup now, and am playing around with `tree.js`. I will reach out either here or on Slack if I

[GitHub] [airflow] edwardwang888 commented on issue #16877: Cleared task instances in manual runs should have borders

2021-08-23 Thread GitBox
edwardwang888 commented on issue #16877: URL: https://github.com/apache/airflow/issues/16877#issuecomment-904297333 @bbovenzi Sorry for the delay. I have my local development environment setup now, and am playing around with `tree.js`. I will reach out on Slack if I have any questions!

[GitHub] [airflow] EliMor commented on issue #17661: Support git sync from multiple repositories

2021-08-23 Thread GitBox
EliMor commented on issue #17661: URL: https://github.com/apache/airflow/issues/17661#issuecomment-904285865 seems related to: https://github.com/apache/airflow/issues/11708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] EliMor commented on issue #17737: Allow multiple repos to be source for dags in helm chart

2021-08-23 Thread GitBox
EliMor commented on issue #17737: URL: https://github.com/apache/airflow/issues/17737#issuecomment-904266423 Seems like duplicate of https://github.com/apache/airflow/issues/17661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] iblaine commented on pull request #17777: get_pandas_df() fails when it tries to read an empty table

2021-08-23 Thread GitBox
iblaine commented on pull request #1: URL: https://github.com/apache/airflow/pull/1#issuecomment-904239844 * A new flag `empty_table_flag` has been added to enable tests against an empty hive table * A new test has been added to validate get_pandas_df against an empty table --

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17800: BigQueryCreateExternalTableOperator from providers package fails to get schema from GCS object

2021-08-23 Thread GitBox
boring-cyborg[bot] commented on issue #17800: URL: https://github.com/apache/airflow/issues/17800#issuecomment-904225776 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] lawrencestfs opened a new issue #17800: BigQueryCreateExternalTableOperator from providers package fails to get schema from GCS object

2021-08-23 Thread GitBox
lawrencestfs opened a new issue #17800: URL: https://github.com/apache/airflow/issues/17800 **Apache Airflow version**: 1.10.15 **OS**: Linux 5.4.109+ **Apache Airflow Provider versions**: apache-airflow-backport-providers-apache-beam==2021.3.13

[GitHub] [airflow] github-actions[bot] closed issue #10574: Dag in existing persistent volume claim not registering

2021-08-23 Thread GitBox
github-actions[bot] closed issue #10574: URL: https://github.com/apache/airflow/issues/10574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on issue #10574: Dag in existing persistent volume claim not registering

2021-08-23 Thread GitBox
github-actions[bot] commented on issue #10574: URL: https://github.com/apache/airflow/issues/10574#issuecomment-904217119 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] kaxil opened a new pull request #17799: Fix missing whitespace in ``apply_default`` deprecation message

2021-08-23 Thread GitBox
kaxil opened a new pull request #17799: URL: https://github.com/apache/airflow/pull/17799 Before: ``` In previous versions, all subclasses of BaseOperator must use apply_default decorator for the`default_args` feature to work properly. ``` After: ``` In

[GitHub] [airflow] kaxil opened a new pull request #17798: Prepare release for Kubernetes Provider

2021-08-23 Thread GitBox
kaxil opened a new pull request #17798: URL: https://github.com/apache/airflow/pull/17798 https://github.com/apache/airflow/issues/17186 -- This has made the XCom functionality not work with KubernetesPodOperator, this has been fixed by https://github.com/apache/airflow/pull/17760 -- so

[GitHub] [airflow] potiuk commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r694367348 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -228,6 +225,8 @@ def test_on_kill(self): for process in processes:

[GitHub] [airflow] potiuk commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r694367348 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -228,6 +225,8 @@ def test_on_kill(self): for process in processes:

[GitHub] [airflow] potiuk commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r694367348 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -228,6 +225,8 @@ def test_on_kill(self): for process in processes:

[GitHub] [airflow] potiuk commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r694365694 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -228,6 +225,8 @@ def test_on_kill(self): for process in processes:

[GitHub] [airflow] potiuk commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r694363964 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -228,6 +225,8 @@ def test_on_kill(self): for process in processes:

[GitHub] [airflow] jedcunningham commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
jedcunningham commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r694361191 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -228,6 +225,8 @@ def test_on_kill(self): for process in

[GitHub] [airflow] jedcunningham closed pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
jedcunningham closed pull request #17797: URL: https://github.com/apache/airflow/pull/17797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (36c5fd3 -> 0264fea)

2021-08-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 36c5fd3 Move instriuctions of constraint/image refreshing to dev add 0264fea Remove airflow dependency from

[GitHub] [airflow] potiuk closed issue #17795: Circular Dependency in Apache Airflow 2.1.3

2021-08-23 Thread GitBox
potiuk closed issue #17795: URL: https://github.com/apache/airflow/issues/17795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #17796: Remove airflow dependency from http provider

2021-08-23 Thread GitBox
potiuk merged pull request #17796: URL: https://github.com/apache/airflow/pull/17796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r694358373 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -228,6 +225,8 @@ def test_on_kill(self): for process in processes:

[GitHub] [airflow] github-actions[bot] commented on pull request #17796: Remove airflow dependency from http provider

2021-08-23 Thread GitBox
github-actions[bot] commented on pull request #17796: URL: https://github.com/apache/airflow/pull/17796#issuecomment-904183023 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] potiuk commented on issue #17788: livy operator print sparkUiUrl in log output

2021-08-23 Thread GitBox
potiuk commented on issue #17788: URL: https://github.com/apache/airflow/issues/17788#issuecomment-904174613 > > @potiuk I am not sure if that extra operator will work for this case. The livy api only stores data for about 3 hours in our case. The default is much shorter. Since the uri

[GitHub] [airflow] potiuk commented on issue #17788: livy operator print sparkUiUrl in log output

2021-08-23 Thread GitBox
potiuk commented on issue #17788: URL: https://github.com/apache/airflow/issues/17788#issuecomment-904173353 > @potiuk I am not sure if that extra operator will work for this case. The livy api only stores data for about 3 hours in our case. The default is much shorter. Since the uri has

[GitHub] [airflow] jedcunningham opened a new pull request #17797: Fix broken MSSQL test

2021-08-23 Thread GitBox
jedcunningham opened a new pull request #17797: URL: https://github.com/apache/airflow/pull/17797 This broken test was causing the next test to use the db to fail. Also, by not ignoring exceptions here we let the failure be exposed where its broken, not in the next test that happens

[airflow] branch main updated: Move instriuctions of constraint/image refreshing to dev

2021-08-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 36c5fd3 Move instriuctions of constraint/image

[GitHub] [airflow] potiuk merged pull request #17782: Move instructions of constraint/image refreshing to dev

2021-08-23 Thread GitBox
potiuk merged pull request #17782: URL: https://github.com/apache/airflow/pull/17782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk edited a comment on issue #17795: Circular Dependency in Apache Airflow 2.1.3

2021-08-23 Thread GitBox
potiuk edited a comment on issue #17795: URL: https://github.com/apache/airflow/issues/17795#issuecomment-904169637 Yeah . HTTP provider has been brought back to be preinstalled and we have to fix that and release it to remove the circular dependency, This will be fixed with the next

[GitHub] [airflow] potiuk edited a comment on issue #17795: Circular Dependency in Apache Airflow 2.1.3

2021-08-23 Thread GitBox
potiuk edited a comment on issue #17795: URL: https://github.com/apache/airflow/issues/17795#issuecomment-904169637 Yeah . HTTP provider has been brought back to be preinstalled and we have to fix that and release it to remove the circular dependency, This will be fixed with the next

[GitHub] [airflow] potiuk commented on issue #17795: Circular Dependency in Apache Airflow 2.1.3

2021-08-23 Thread GitBox
potiuk commented on issue #17795: URL: https://github.com/apache/airflow/issues/17795#issuecomment-904169637 Yeah . HTTP provider has been brought back to be preinstalled and we had to release it to remove the circular dependency, This will be fixed with the next release of HTTP provider

[GitHub] [airflow] potiuk opened a new pull request #17796: Remove airflow dependency from http provider

2021-08-23 Thread GitBox
potiuk opened a new pull request #17796: URL: https://github.com/apache/airflow/pull/17796 The http provider has been temporarily moved out of preinstalled providers (because of licensing issues). Those issues have now been removed and http provider went back to be preinstalled,

[GitHub] [airflow] cocampbe commented on issue #17788: livy operator print sparkUiUrl in log output

2021-08-23 Thread GitBox
cocampbe commented on issue #17788: URL: https://github.com/apache/airflow/issues/17788#issuecomment-904163197 @potiuk I am not sure if that extra operator will work for this case. The livy api only stores data for about 3 hours in our case. The default is much shorter. Since the uri has

[GitHub] [airflow] potiuk closed pull request #17767: Update description about the new ``connection-types`` provider meta-data

2021-08-23 Thread GitBox
potiuk closed pull request #17767: URL: https://github.com/apache/airflow/pull/17767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #17767: Update description about the new ``connection-types`` provider meta-data

2021-08-23 Thread GitBox
potiuk commented on pull request #17767: URL: https://github.com/apache/airflow/pull/17767#issuecomment-904161210 Already merged together with #17775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[airflow] 02/02: Improve discoverability of Provider packages' functionality

2021-08-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git commit bcc76656844be47f923527c0a6cd1de546655cb4 Author: Jarek Potiuk AuthorDate: Sat Aug 21 23:10:31 2021 +0200 Improve

[airflow] 01/02: Update description about the new ``connection-types`` provider meta-data

2021-08-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git commit be75dcd39cd10264048c86e74110365bd5daf8b7 Author: Jarek Potiuk AuthorDate: Sat Aug 21 12:12:39 2021 +0200 Update

[airflow] branch main updated (3a7a65c -> bcc7665)

2021-08-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3a7a65c feat: Add Loadsmart in the list of companies using it (#17792) new be75dcd Update description about

[GitHub] [airflow] potiuk merged pull request #17775: Improve discoverability of Provider packages' functionality

2021-08-23 Thread GitBox
potiuk merged pull request #17775: URL: https://github.com/apache/airflow/pull/17775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #17792: Added Loadsmart to the list of companies using Airflow

2021-08-23 Thread GitBox
potiuk merged pull request #17792: URL: https://github.com/apache/airflow/pull/17792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: feat: Add Loadsmart in the list of companies using it (#17792)

2021-08-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 3a7a65c feat: Add Loadsmart in the list of

[airflow] branch main updated: Update ``README.md`` to point to Airflow 2.1.3 (#17793)

2021-08-23 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 39a8b2c Update ``README.md`` to point to

[GitHub] [airflow] kaxil merged pull request #17793: Update ``README.md`` to point to Airflow 2.1.3

2021-08-23 Thread GitBox
kaxil merged pull request #17793: URL: https://github.com/apache/airflow/pull/17793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17793: Update ``README.md`` to point to Airflow 2.1.3

2021-08-23 Thread GitBox
github-actions[bot] commented on pull request #17793: URL: https://github.com/apache/airflow/pull/17793#issuecomment-904156007 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[airflow] branch main updated (a0ce41c -> 6fdfa09)

2021-08-23 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from a0ce41c Add warning about https configuration in SimpleHttpOperator (#17783) add 6fdfa09 Chart: Update the

[GitHub] [airflow] kaxil merged pull request #17794: Chart: Update the default Airflow version to ``2.1.2``

2021-08-23 Thread GitBox
kaxil merged pull request #17794: URL: https://github.com/apache/airflow/pull/17794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17794: Chart: Update the default Airflow version to ``2.1.2``

2021-08-23 Thread GitBox
github-actions[bot] commented on pull request #17794: URL: https://github.com/apache/airflow/pull/17794#issuecomment-904155679 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[jira] [Commented] (AIRFLOW-2910) HTTP Connection not obvious how use with https://

2021-08-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403399#comment-17403399 ] ASF subversion and git services commented on AIRFLOW-2910: -- Commit

[airflow] branch main updated (cb9f0bd -> a0ce41c)

2021-08-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from cb9f0bd Move Model collation args tests to correct folder (#17791) add a0ce41c Add warning about https

[GitHub] [airflow] potiuk merged pull request #17783: Add warning about https configuration in SimpleHttpOperator

2021-08-23 Thread GitBox
potiuk merged pull request #17783: URL: https://github.com/apache/airflow/pull/17783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17782: Move instructions of constraint/image refreshing to dev

2021-08-23 Thread GitBox
github-actions[bot] commented on pull request #17782: URL: https://github.com/apache/airflow/pull/17782#issuecomment-904154595 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on pull request #17791: Move Model collation args tests to correct folder

2021-08-23 Thread GitBox
potiuk commented on pull request #17791: URL: https://github.com/apache/airflow/pull/17791#issuecomment-904154511 Nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated: Move Model collation args tests to correct folder (#17791)

2021-08-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new cb9f0bd Move Model collation args tests to

[GitHub] [airflow] potiuk merged pull request #17791: Move Model collation args tests to correct folder

2021-08-23 Thread GitBox
potiuk merged pull request #17791: URL: https://github.com/apache/airflow/pull/17791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #17757: Improves documentation about modules management

2021-08-23 Thread GitBox
potiuk commented on pull request #17757: URL: https://github.com/apache/airflow/pull/17757#issuecomment-904152014 Thanks for the thorough comments @jedcunningham ! I think the only one remaining is about `__init__.py` presence - I'd love to hear what others think about it - is it really

[GitHub] [airflow] potiuk commented on a change in pull request #17757: Improves documentation about modules management

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17757: URL: https://github.com/apache/airflow/pull/17757#discussion_r694324576 ## File path: docs/apache-airflow/modules_management.rst ## @@ -68,99 +81,192 @@ In the next section, you will learn how to create your own simple

[GitHub] [airflow] potiuk commented on a change in pull request #17757: Improves documentation about modules management

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17757: URL: https://github.com/apache/airflow/pull/17757#discussion_r694319921 ## File path: docs/apache-airflow/modules_management.rst ## @@ -68,99 +81,192 @@ In the next section, you will learn how to create your own simple

[GitHub] [airflow] potiuk commented on a change in pull request #17757: Improves documentation about modules management

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17757: URL: https://github.com/apache/airflow/pull/17757#discussion_r694319259 ## File path: docs/apache-airflow/modules_management.rst ## @@ -68,99 +81,192 @@ In the next section, you will learn how to create your own simple

[GitHub] [airflow] ashwin153 opened a new issue #17795: Circular Dependency in Apache Airflow 2.1.3

2021-08-23 Thread GitBox
ashwin153 opened a new issue #17795: URL: https://github.com/apache/airflow/issues/17795 **Apache Airflow version**: 2.1.3 **OS**: Ubuntu 20.04 LTS **Deployment**: Bazel **What happened**: When I tried to bump my Bazel monorepo from 2.1.2 to

[GitHub] [airflow] kaxil opened a new pull request #17794: Chart: Update the default Airflow version to ``2.1.2``

2021-08-23 Thread GitBox
kaxil opened a new pull request #17794: URL: https://github.com/apache/airflow/pull/17794 Since 2.1.3 is out we should use that as the default Airflow version. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] kaxil opened a new pull request #17793: Update ``README.md`` to point to Airflow 2.1.3

2021-08-23 Thread GitBox
kaxil opened a new pull request #17793: URL: https://github.com/apache/airflow/pull/17793 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] potiuk commented on issue #17788: livy operator print sparkUiUrl in log output

2021-08-23 Thread GitBox
potiuk commented on issue #17788: URL: https://github.com/apache/airflow/issues/17788#issuecomment-904102830 That's a perfect case for Extra Operator link: https://airflow.apache.org/docs/apache-airflow/stable/howto/define_extra_link.html . Shall I assign you to that issue? -- This is

[GitHub] [airflow] github-actions[bot] commented on pull request #17775: Improve discoverability of Provider packages' functionality

2021-08-23 Thread GitBox
github-actions[bot] commented on pull request #17775: URL: https://github.com/apache/airflow/pull/17775#issuecomment-904101694 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] kaxil closed issue #10127: Quarantined issues v1-10-stable

2021-08-23 Thread GitBox
kaxil closed issue #10127: URL: https://github.com/apache/airflow/issues/10127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil closed issue #10128: Quarantined Issues v1-10-test

2021-08-23 Thread GitBox
kaxil closed issue #10128: URL: https://github.com/apache/airflow/issues/10128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] Jorricks edited a comment on pull request #16634: Require can_edit on DAG privileges to modify TaskInstances and DagRuns

2021-08-23 Thread GitBox
Jorricks edited a comment on pull request #16634: URL: https://github.com/apache/airflow/pull/16634#issuecomment-904079791 ~~Let me know if you need me to rebase to the latest main  ~~ Nvm. Saw a merge conflict so rebased to the latest main. -- This is an automated message from

[GitHub] [airflow] Jorricks commented on pull request #16634: Require can_edit on DAG privileges to modify TaskInstances and DagRuns

2021-08-23 Thread GitBox
Jorricks commented on pull request #16634: URL: https://github.com/apache/airflow/pull/16634#issuecomment-904079791 Let me know if you need me to rebase to the latest main  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on a change in pull request #17775: Improve discoverability of Provider packages' functionality

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17775: URL: https://github.com/apache/airflow/pull/17775#discussion_r694269305 ## File path: docs/apache-airflow-providers-elasticsearch/logging/index.rst ## @@ -17,7 +17,7 @@ Review comment: Yep. Found it. Fixed already

[GitHub] [airflow] Jorricks commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-23 Thread GitBox
Jorricks commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-904077786 I tried to add some tests on the CLI task part. That is pretty much done. However, I had quite some trouble wrapping my head around a decent test approach on the

[GitHub] [airflow] Jorricks commented on a change in pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-23 Thread GitBox
Jorricks commented on a change in pull request #17207: URL: https://github.com/apache/airflow/pull/17207#discussion_r694266238 ## File path: airflow/executors/celery_executor.py ## @@ -125,8 +129,10 @@ def _execute_in_fork(command_to_exec: CommandType) -> None:

[GitHub] [airflow] gmcrocetti opened a new pull request #17792: Added Loadsmart to the list of companies using Airflow

2021-08-23 Thread GitBox
gmcrocetti opened a new pull request #17792: URL: https://github.com/apache/airflow/pull/17792 Added Loadsmart to INTHEWILD.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] mik-laj commented on a change in pull request #17775: Improve discoverability of Provider packages' functionality

2021-08-23 Thread GitBox
mik-laj commented on a change in pull request #17775: URL: https://github.com/apache/airflow/pull/17775#discussion_r694264711 ## File path: docs/apache-airflow-providers-elasticsearch/logging/index.rst ## @@ -17,7 +17,7 @@ Review comment: Here is example:

[GitHub] [airflow] potiuk commented on a change in pull request #17775: Improve discoverability of Provider packages' functionality

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17775: URL: https://github.com/apache/airflow/pull/17775#discussion_r694258279 ## File path: docs/apache-airflow-providers-elasticsearch/logging/index.rst ## @@ -17,7 +17,7 @@ Review comment: Ah. Found it! Good catch!

[GitHub] [airflow] potiuk commented on a change in pull request #17775: Improve discoverability of Provider packages' functionality

2021-08-23 Thread GitBox
potiuk commented on a change in pull request #17775: URL: https://github.com/apache/airflow/pull/17775#discussion_r694257448 ## File path: docs/apache-airflow-providers-elasticsearch/logging/index.rst ## @@ -17,7 +17,7 @@ Review comment: How do I do that? Could you

[GitHub] [airflow] github-actions[bot] commented on pull request #17783: Add warning about https configuration in SimpleHttpOperator

2021-08-23 Thread GitBox
github-actions[bot] commented on pull request #17783: URL: https://github.com/apache/airflow/pull/17783#issuecomment-904063607 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] ashb opened a new pull request #17791: Move Model collation args tests to correct folder

2021-08-23 Thread GitBox
ashb opened a new pull request #17791: URL: https://github.com/apache/airflow/pull/17791 The tests for this got added to test_base.py in #17729, which is the right file name, but inside tests/sensors/, which isn't right :) Created a new tests/models/test_base.py for this. And

[GitHub] [airflow] potiuk commented on pull request #17576: Add pre/post execution hooks

2021-08-23 Thread GitBox
potiuk commented on pull request #17576: URL: https://github.com/apache/airflow/pull/17576#issuecomment-904010653 > These two new fields you add don't need to be serialized (and callables can't generally be anyway) -- the general rule is that things needed by the Scheduler should be

[GitHub] [airflow] potiuk closed pull request #17576: Add pre/post execution hooks

2021-08-23 Thread GitBox
potiuk closed pull request #17576: URL: https://github.com/apache/airflow/pull/17576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow-site] kaxil merged pull request #468: Add documentation for Apache Airflow 2.1.3

2021-08-23 Thread GitBox
kaxil merged pull request #468: URL: https://github.com/apache/airflow-site/pull/468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow-site] kaxil opened a new pull request #468: Add documentation for Apache Airflow 2.1.3

2021-08-23 Thread GitBox
kaxil opened a new pull request #468: URL: https://github.com/apache/airflow-site/pull/468 Add docs for Airflow and Docker images -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow-site] 02/03: Remove log files

2021-08-23 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch airflow-2.1.3-docker in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 260873efa12d4d008ef95a85538774a14aa48be7 Author: Kaxil Naik AuthorDate: Mon Aug 23 18:56:44 2021

[airflow-site] branch airflow-2.1.3-docker created (now 545bbb5)

2021-08-23 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch airflow-2.1.3-docker in repository https://gitbox.apache.org/repos/asf/airflow-site.git. at 545bbb5 Remove Airflow Summit banner This branch includes the following new commits:

[GitHub] [airflow] iblaine commented on pull request #17777: get_pandas_df() fails when it tries to read an empty table

2021-08-23 Thread GitBox
iblaine commented on pull request #1: URL: https://github.com/apache/airflow/pull/1#issuecomment-903993858 Setting this [line](https://github.com/apache/airflow/blob/main/tests/test_utils/mock_process.py#L59) to `self.iterable = []` will trigger this bug. -- This is an

[GitHub] [airflow] iblaine commented on pull request #17777: get_pandas_df() fails when it tries to read an empty table

2021-08-23 Thread GitBox
iblaine commented on pull request #1: URL: https://github.com/apache/airflow/pull/1#issuecomment-903981341 > I wonder if it’d work to do `SELECT * FROM table LIMIT 0` Mock seems to return a result set regardless of the SQL. -- This is an automated message from the Apache

[GitHub] [airflow] iblaine commented on issue #17765: get_pandas_df() fails when it tries to read an empty table

2021-08-23 Thread GitBox
iblaine commented on issue #17765: URL: https://github.com/apache/airflow/issues/17765#issuecomment-903980110 PR for this issue is https://github.com/apache/airflow/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] subkanthi opened a new pull request #17790: Gcp ai hyperparameter tuning

2021-08-23 Thread GitBox
subkanthi opened a new pull request #17790: URL: https://github.com/apache/airflow/pull/17790 closes: #17348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] dimberman commented on a change in pull request #15330: Add a Docker Taskflow decorator

2021-08-23 Thread GitBox
dimberman commented on a change in pull request #15330: URL: https://github.com/apache/airflow/pull/15330#discussion_r694154586 ## File path: airflow/providers_manager.py ## @@ -278,6 +309,51 @@ def _get_attr(obj: Any, attr_name: str): return None return

[GitHub] [airflow] jedcunningham commented on a change in pull request #17757: Improves documentation about modules management

2021-08-23 Thread GitBox
jedcunningham commented on a change in pull request #17757: URL: https://github.com/apache/airflow/pull/17757#discussion_r694153747 ## File path: docs/apache-airflow/modules_management.rst ## @@ -68,99 +81,192 @@ In the next section, you will learn how to create your own

[GitHub] [airflow] jedcunningham commented on a change in pull request #17757: Improves documentation about modules management

2021-08-23 Thread GitBox
jedcunningham commented on a change in pull request #17757: URL: https://github.com/apache/airflow/pull/17757#discussion_r694114919 ## File path: docs/apache-airflow/modules_management.rst ## @@ -25,9 +25,21 @@ Airflow configuration. The following article will describe how

[airflow] branch main updated: Fix failing Helm Chart docs test (#17789)

2021-08-23 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d97e50f Fix failing Helm Chart docs test

[GitHub] [airflow] kaxil merged pull request #17789: Fix failing Helm Chart docs test

2021-08-23 Thread GitBox
kaxil merged pull request #17789: URL: https://github.com/apache/airflow/pull/17789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >