[GitHub] [airflow] asaf400 opened a new pull request #19030: Align EcsOperator with DockerOperator capabilities

2021-10-16 Thread GitBox
asaf400 opened a new pull request #19030: URL: https://github.com/apache/airflow/pull/19030 Hello, I would like some opinions on this PR, it has no open issue, but it's something I have encountered and fix locally in Airflow 2.0.2, and the code hasn't change in main branch.

[GitHub] [airflow] dstandish opened a new pull request #19029: Simplify "invalid TI state" message

2021-10-16 Thread GitBox
dstandish opened a new pull request #19029: URL: https://github.com/apache/airflow/pull/19029 Currently in the web UI on task instance details page, if a task is in the "up for retry" state we will see this message: > Task is in the up_for_retry state which is not a valid state

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19028: PermissionError when `core:default_impersonation` is set

2021-10-16 Thread GitBox
boring-cyborg[bot] commented on issue #19028: URL: https://github.com/apache/airflow/issues/19028#issuecomment-945033023 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] jgmarcel opened a new issue #19028: PermissionError when `core:default_impersonation` is set

2021-10-16 Thread GitBox
jgmarcel opened a new issue #19028: URL: https://github.com/apache/airflow/issues/19028 ### Apache Airflow version 2.2.0 (latest released) ### Operating System Ubuntu 20.04.3 LTS ### Versions of Apache Airflow Providers ```

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19027: Fix for DockerOperator Xcoms functionality

2021-10-16 Thread GitBox
boring-cyborg[bot] commented on pull request #19027: URL: https://github.com/apache/airflow/pull/19027#issuecomment-945032982 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] asaf400 opened a new pull request #19027: Fix for DockerOperator Xcoms functionality

2021-10-16 Thread GitBox
asaf400 opened a new pull request #19027: URL: https://github.com/apache/airflow/pull/19027 closes: #18874 This PR is an attempt at fixing DockerOperator xcoms behavior, The fix is keeping the existing attach to docker's log stream for 'live' airflow logging for long-running

[GitHub] [airflow] github-actions[bot] commented on pull request #19013: Minor grammar tweaks in docs

2021-10-16 Thread GitBox
github-actions[bot] commented on pull request #19013: URL: https://github.com/apache/airflow/pull/19013#issuecomment-944452342 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] codenamestif edited a comment on issue #18089: KeyError when ECS failed to start image

2021-10-16 Thread GitBox
codenamestif edited a comment on issue #18089: URL: https://github.com/apache/airflow/issues/18089#issuecomment-944887234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] dimon222 commented on issue #18939: Upgrading from version 2.1.4 to 2.2.0 fails during mysql db upgrade with error Can't DROP 'dag_id'

2021-10-16 Thread GitBox
dimon222 commented on issue #18939: URL: https://github.com/apache/airflow/issues/18939#issuecomment-944703655 I'm suffering from same issue too. I'm using MariaDB instead of MySQL. I wonder if the rest of folks are noticing same pattern? -- This is an automated message from the Apache

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19025: [Minor] Fix padding on home page

2021-10-16 Thread GitBox
boring-cyborg[bot] commented on pull request #19025: URL: https://github.com/apache/airflow/pull/19025#issuecomment-944987810 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] josh-fell commented on issue #14319: tasks with `none_failed` trigger rule do not run when all upstream tasks are skipped

2021-10-16 Thread GitBox
josh-fell commented on issue #14319: URL: https://github.com/apache/airflow/issues/14319#issuecomment-944921627 I can confirm this is fixed in Airflow 2.1.0 and Airflow 2.2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] kaxil commented on pull request #19017: fixed incorrect KubernetesPodOperator param name

2021-10-16 Thread GitBox
kaxil commented on pull request #19017: URL: https://github.com/apache/airflow/pull/19017#issuecomment-944872104 No worries :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk opened a new pull request #19010: Workaround libstdcpp TLS error

2021-10-16 Thread GitBox
potiuk opened a new pull request #19010: URL: https://github.com/apache/airflow/pull/19010 Workaround https://github.com/apache/airflow/issues/17546 issue with /usr/lib/x86_64-linux-gnu/libstdc++.so.6: cannot allocate memory in static TLS block. We do not yet a more "correct"

[GitHub] [airflow] harlequin opened a new pull request #19008: Authentication via JWT token and Impersonation

2021-10-16 Thread GitBox
harlequin opened a new pull request #19008: URL: https://github.com/apache/airflow/pull/19008 This change introduce the authentication method via JWT and also the possibility to impersonate as DAG owner. --- **^ Add meaningful description above** Read the **[Pull

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19008: Authentication via JWT token and Impersonation

2021-10-16 Thread GitBox
boring-cyborg[bot] commented on pull request #19008: URL: https://github.com/apache/airflow/pull/19008#issuecomment-944235628 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] mik-laj commented on issue #19007: argument execution_date: invalid parse value

2021-10-16 Thread GitBox
mik-laj commented on issue #19007: URL: https://github.com/apache/airflow/issues/19007#issuecomment-944261431 CC: @ephraimbuddy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] ss-nef commented on issue #16770: AWS hook should automatically refresh credentials when using temporary credentials

2021-10-16 Thread GitBox
ss-nef commented on issue #16770: URL: https://github.com/apache/airflow/issues/16770#issuecomment-944298277 Hello, I am not able to understand how to enable the automatic refresh when using the ECSOperator to orchestrate Fargate Containers. The container I am running is

[GitHub] [airflow] potiuk commented on a change in pull request #18964: Add pre-commit hook for common misspelling check in files

2021-10-16 Thread GitBox
potiuk commented on a change in pull request #18964: URL: https://github.com/apache/airflow/pull/18964#discussion_r729789012 ## File path: airflow/providers/microsoft/azure/sensors/wasb.py ## @@ -57,7 +57,7 @@ def __init__( self.check_options = check_options

[GitHub] [airflow] github-actions[bot] commented on pull request #18930: pinot operators guide #8194

2021-10-16 Thread GitBox
github-actions[bot] commented on pull request #18930: URL: https://github.com/apache/airflow/pull/18930#issuecomment-944875517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] mik-laj commented on pull request #18997: Add pandas requirements for providers that use pandas

2021-10-16 Thread GitBox
mik-laj commented on pull request #18997: URL: https://github.com/apache/airflow/pull/18997#issuecomment-944984146 Is Apache Hive also covered by this change? https://github.com/apache/airflow/issues/18901 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #17891: Show error in UI when a DAG with same dag_id as another DAG is present

2021-10-16 Thread GitBox
github-actions[bot] commented on pull request #17891: URL: https://github.com/apache/airflow/pull/17891#issuecomment-945024273 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] mik-laj removed a comment on pull request #18997: Add pandas requirements for providers that use pandas

2021-10-16 Thread GitBox
mik-laj removed a comment on pull request #18997: URL: https://github.com/apache/airflow/pull/18997#issuecomment-944984146 Is Apache Hive also covered by this change? https://github.com/apache/airflow/issues/18901 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] baolsen commented on issue #16770: AWS hook should automatically refresh credentials when using temporary credentials

2021-10-16 Thread GitBox
baolsen commented on issue #16770: URL: https://github.com/apache/airflow/issues/16770#issuecomment-944336930 Hi there If you are using an "assume_role"/similar with the aws hook then the credentials _should_ automatically refresh. I tested it using normal boto3 clients but

[GitHub] [airflow] deedmitrij opened a new pull request #19014: Fix Cloud SQL system tests

2021-10-16 Thread GitBox
deedmitrij opened a new pull request #19014: URL: https://github.com/apache/airflow/pull/19014 - Add creation of Fine-grained bucket for ACLs - Add patching of environment variables - Add unique postfix to instances names -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] mik-laj commented on pull request #19008: Authentication via JWT token and Impersonation Resolves #18969

2021-10-16 Thread GitBox
mik-laj commented on pull request #19008: URL: https://github.com/apache/airflow/pull/19008#issuecomment-944260266 What do you think about adding some docs? https://github.com/apache/airflow/tree/main/docs/apache-airflow-providers-trino -- This is an automated message from the Apache

[GitHub] [airflow] PApostol opened a new pull request #19026: Remove unnecessary string concatenations in AirflowException in s3_to_hive.py

2021-10-16 Thread GitBox
PApostol opened a new pull request #19026: URL: https://github.com/apache/airflow/pull/19026 Remove unnecessary string concatenations in `AirflowException` in `airflow/providers/apache/hive/transfers/s3_to_hive.py` -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19017: fixed incorrect KubernetesPodOperator param name

2021-10-16 Thread GitBox
boring-cyborg[bot] commented on pull request #19017: URL: https://github.com/apache/airflow/pull/19017#issuecomment-944601010 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] potatochip commented on issue #19015: Remote logging using GCP connection from connection table broken

2021-10-16 Thread GitBox
potatochip commented on issue #19015: URL: https://github.com/apache/airflow/issues/19015#issuecomment-944584848 that is the standard way of doing it. it is referenced in the airflow configuration https://github.com/apache/airflow/issues/19015. It was done that way for gcp before

[GitHub] [airflow] pvanliefland commented on issue #18239: Airflow Celery Worker logs inaccessible

2021-10-16 Thread GitBox
pvanliefland commented on issue #18239: URL: https://github.com/apache/airflow/issues/18239#issuecomment-944256151 I'm using the helm chart and experiencing something similar. When using `KubernetesExecutor` and `logs.persistence.existingClaim`, it works fine. As soon as I switch to

[GitHub] [airflow] RobbeSneyders commented on pull request #18934: Implement API generator and use it on Connection

2021-10-16 Thread GitBox
RobbeSneyders commented on pull request #18934: URL: https://github.com/apache/airflow/pull/18934#issuecomment-944282013 @Ruwann and I have recently joined as maintainers on Connexion, specifically because it is the only mature API-first Python framework. Let us know if we can help out.

[GitHub] [airflow] josh-fell edited a comment on issue #14319: tasks with `none_failed` trigger rule do not run when all upstream tasks are skipped

2021-10-16 Thread GitBox
josh-fell edited a comment on issue #14319: URL: https://github.com/apache/airflow/issues/14319#issuecomment-944921627 I can confirm this is fixed in Airflow 2.1.0 and Airflow 2.2.0. DAG code ```python from datetime import datetime from airflow import DAG from

[GitHub] [airflow] FurcyPin commented on issue #17507: Task processes killed with WARNING - Recorded pid does not match the current pid

2021-10-16 Thread GitBox
FurcyPin commented on issue #17507: URL: https://github.com/apache/airflow/issues/17507#issuecomment-944311274 +1, I'm seeing task failures with similar messages on Cloud Composer 2 (composer-2.0.0-preview.3-airflow-2.1.2) I had 2 schedulers enabled and downscaled to just 1 scheduler,

[GitHub] [airflow] mihaitodor commented on pull request #19017: fixed incorrect KubernetesPodOperator param name

2021-10-16 Thread GitBox
mihaitodor commented on pull request #19017: URL: https://github.com/apache/airflow/pull/19017#issuecomment-944826315 My bad, I somehow misread the example code while working on a custom DAG and asked Andrew to push this fix. I should’ve ran the example again. Please close this one and

[GitHub] [airflow] harlequin commented on pull request #19008: Authentication via JWT token and Impersonation Resolves #18969

2021-10-16 Thread GitBox
harlequin commented on pull request #19008: URL: https://github.com/apache/airflow/pull/19008#issuecomment-944249699 Resolves #18969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk closed issue #18901: Pandas Not Installed with Pip When Required for Providers Packages

2021-10-16 Thread GitBox
potiuk closed issue #18901: URL: https://github.com/apache/airflow/issues/18901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham closed issue #19001: Slow liveness probe causes frequent restarts (scheduler and triggerer)

2021-10-16 Thread GitBox
jedcunningham closed issue #19001: URL: https://github.com/apache/airflow/issues/19001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] sensei100 commented on issue #17536: Oauth for google redirect_uri error expecting HTTPS but sending HTTP

2021-10-16 Thread GitBox
sensei100 commented on issue #17536: URL: https://github.com/apache/airflow/issues/17536#issuecomment-944497529 We solved this by adding @gvillafanetapia's workaround in the airflow.cfg file under the webserver section. ``` [webserver] enable_proxy_fix = True ``` --

[GitHub] [airflow] anaynayak opened a new pull request #19022: CloudwatchTaskHandler params to create log group/stream

2021-10-16 Thread GitBox
anaynayak opened a new pull request #19022: URL: https://github.com/apache/airflow/pull/19022 **Todo:** - [X] Add `__init__` params for CloudwatchTaskHandler which are passed to `watchtower.CloudWatchLogHandler` to control whether a log group/stream are to be created - [ ]

[GitHub] [airflow] github-actions[bot] commented on issue #16208: add ability to add java_opts for jdbcoperator

2021-10-16 Thread GitBox
github-actions[bot] commented on issue #16208: URL: https://github.com/apache/airflow/issues/16208#issuecomment-944818126 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] kaxil merged pull request #19013: Minor grammar tweaks in docs

2021-10-16 Thread GitBox
kaxil merged pull request #19013: URL: https://github.com/apache/airflow/pull/19013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] AndrewSmith593 opened a new pull request #19017: fixed incorrect KubernetesPodOperator param name

2021-10-16 Thread GitBox
AndrewSmith593 opened a new pull request #19017: URL: https://github.com/apache/airflow/pull/19017 This change fixes an incorrect parameter name in the "init_container" in the example dag for using the KubernetesPodOperator. The current doc has the parameter name as "env", which is

[GitHub] [airflow] SamWheating commented on issue #18239: Airflow Celery Worker logs inaccessible

2021-10-16 Thread GitBox
SamWheating commented on issue #18239: URL: https://github.com/apache/airflow/issues/18239#issuecomment-944809282 > worker.abc.com -> Airflow workers (multiple behind a load balancer sharing logs storage) I don't think this is going to work, since each airflow worker runs a

[GitHub] [airflow] sunank200 opened a new pull request #19018: S3 hooks filter options

2021-10-16 Thread GitBox
sunank200 opened a new pull request #19018: URL: https://github.com/apache/airflow/pull/19018 Add more filter options to list_keys of S3Hook This commit adds following filters to list the keys in list_keys of S3Hook: - `start_after_key` filters the any keys after the

[GitHub] [airflow] ageofneil edited a comment on pull request #18883: Align the default version with Facebook business SDK

2021-10-16 Thread GitBox
ageofneil edited a comment on pull request #18883: URL: https://github.com/apache/airflow/pull/18883#issuecomment-943607246 Are we sure this is working as intended? ``` Traceback (most recent call last): File

[GitHub] [airflow] MM-Lehmann opened a new issue #19011: new task return status: _Warning_

2021-10-16 Thread GitBox
MM-Lehmann opened a new issue #19011: URL: https://github.com/apache/airflow/issues/19011 ### Description In our use case, we often import data which contains some noise which cannot be handled correctly. However, we don't want an entire task or job to fail because of it (simply

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19015: Remote logging using GCP connection from connection table broken

2021-10-16 Thread GitBox
boring-cyborg[bot] commented on issue #19015: URL: https://github.com/apache/airflow/issues/19015#issuecomment-944475816 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ldacey commented on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-16 Thread GitBox
ldacey commented on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-944795288 This impacted me. The one thing that stood out was that most of the execution dates were from a period I definitely remember deleting. There was a DAG which was downloading data

[GitHub] [airflow] Bowrna commented on issue #11913: Add how-to Guide for MSSQL operators

2021-10-16 Thread GitBox
Bowrna commented on issue #11913: URL: https://github.com/apache/airflow/issues/11913#issuecomment-944458784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] sensei100 edited a comment on issue #17536: Oauth for google redirect_uri error expecting HTTPS but sending HTTP

2021-10-16 Thread GitBox
sensei100 edited a comment on issue #17536: URL: https://github.com/apache/airflow/issues/17536#issuecomment-944497529 We solved this by adding @gvillafanetapia's workaround in the airflow.cfg file under the webserver section. This solution also works for Airflow 1.10.15. ```

[GitHub] [airflow] eladkal commented on a change in pull request #18930: pinot operators guide #8194

2021-10-16 Thread GitBox
eladkal commented on a change in pull request #18930: URL: https://github.com/apache/airflow/pull/18930#discussion_r730226523 ## File path: docs/apache-airflow-providers-apache-beam/operators.rst ## @@ -76,6 +76,7 @@ Python Pipelines with DataflowRunner :start-after:

[GitHub] [airflow] potiuk merged pull request #18997: Add pandas requirements for providers that use pandas

2021-10-16 Thread GitBox
potiuk merged pull request #18997: URL: https://github.com/apache/airflow/pull/18997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on a change in pull request #18897: Fix catchup by limiting queued dagrun creation using max_active_runs

2021-10-16 Thread GitBox
jedcunningham commented on a change in pull request #18897: URL: https://github.com/apache/airflow/pull/18897#discussion_r729923995 ## File path: airflow/config_templates/config.yml ## @@ -195,14 +195,6 @@ type: string example: ~ default: "16" -- name:

[GitHub] [airflow] uranusjr commented on issue #18939: Upgrading from version 2.1.4 to 2.2.0 fails during mysql db upgrade with error Can't DROP 'dag_id'

2021-10-16 Thread GitBox
uranusjr commented on issue #18939: URL: https://github.com/apache/airflow/issues/18939#issuecomment-944973055 I think you get what you see because MySQL lacks DDL transaction, so when migration failed on line 140, the database is stuck in an awkward state that the migration is half

[GitHub] [airflow] potiuk commented on pull request #19010: Workaround libstdcpp TLS error

2021-10-16 Thread GitBox
potiuk commented on pull request #19010: URL: https://github.com/apache/airflow/pull/19010#issuecomment-944334817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk merged pull request #19023: Skip updating constraints when only datetime changes

2021-10-16 Thread GitBox
potiuk merged pull request #19023: URL: https://github.com/apache/airflow/pull/19023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #18997: Add pandas requirements for providers that use pandas

2021-10-16 Thread GitBox
potiuk commented on pull request #18997: URL: https://github.com/apache/airflow/pull/18997#issuecomment-944359206 @uranusjr - renamed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] deedmitrij commented on a change in pull request #19014: Fix Cloud SQL system tests

2021-10-16 Thread GitBox
deedmitrij commented on a change in pull request #19014: URL: https://github.com/apache/airflow/pull/19014#discussion_r730077161 ## File path: tests/providers/google/cloud/operators/test_cloud_sql_system.py ## @@ -34,27 +35,98 @@ from tests.test_utils.gcp_system_helpers

[GitHub] [airflow] khalidmammadov opened a new pull request #19020: Removing redundant max_tis_per_query initialisation on SchedulerJob

2021-10-16 Thread GitBox
khalidmammadov opened a new pull request #19020: URL: https://github.com/apache/airflow/pull/19020 This is redundant initialisation as it's super class (Base) does exactly the same initialisation inside its own init. Removing to clean code duplication. --- **^ Add

[GitHub] [airflow] josh-fell commented on a change in pull request #18930: Add Guide for Apache Pinot

2021-10-16 Thread GitBox
josh-fell commented on a change in pull request #18930: URL: https://github.com/apache/airflow/pull/18930#discussion_r730258954 ## File path: airflow/providers/apache/pinot/example_dags/example_pinot_dag.py ## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation

[GitHub] [airflow] mik-laj merged pull request #19026: Remove unnecessary string concatenations in AirflowException in s3_to_hive.py

2021-10-16 Thread GitBox
mik-laj merged pull request #19026: URL: https://github.com/apache/airflow/pull/19026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] xinbinhuang opened a new pull request #19019: Remove dead code path from JenkinsJobTriggerOperator

2021-10-16 Thread GitBox
xinbinhuang opened a new pull request #19019: URL: https://github.com/apache/airflow/pull/19019 These code path are dead because both `jenkins_connection_id` and `job_name` are positional args on the constructor --- **^ Add meaningful description above** Read the

[GitHub] [airflow] pateash commented on pull request #16931: #16692 show schedule_interval/timetable description in UI

2021-10-16 Thread GitBox
pateash commented on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-944879588 > What will it show for 6th param in cron expression? croniter doesn't follow the convention about it see

[GitHub] [airflow] kapopken closed issue #19007: argument execution_date: invalid parse value

2021-10-16 Thread GitBox
kapopken closed issue #19007: URL: https://github.com/apache/airflow/issues/19007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] mik-laj commented on issue #19015: Remote logging using GCP connection from connection table broken

2021-10-16 Thread GitBox
mik-laj commented on issue #19015: URL: https://github.com/apache/airflow/issues/19015#issuecomment-944534479 Why do you want to configure the logginfusing connection? This does not sound safe as every user has the option to edit connections and therefore damage the instances. Can you

[GitHub] [airflow] ss-nef edited a comment on issue #16770: AWS hook should automatically refresh credentials when using temporary credentials

2021-10-16 Thread GitBox
ss-nef edited a comment on issue #16770: URL: https://github.com/apache/airflow/issues/16770#issuecomment-944298277 Hello, I am not able to understand how to enable the automatic refresh when using the ECSOperator to orchestrate Fargate Containers. The container I am running

[GitHub] [airflow] kaxil closed issue #17085: Configuration validation for run-configs

2021-10-16 Thread GitBox
kaxil closed issue #17085: URL: https://github.com/apache/airflow/issues/17085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] zkan commented on pull request #18931: Add clear task menu on task instance view

2021-10-16 Thread GitBox
zkan commented on pull request #18931: URL: https://github.com/apache/airflow/pull/18931#issuecomment-944927314 @bbovenzi @potiuk May I have your advice, please? I'm not good at designing a UI and here what I have so far. ![Screen Shot 2564-10-16 at 21 47

[GitHub] [airflow] prabhjyotsingh opened a new pull request #19025: [Minor] Fix padding on home page

2021-10-16 Thread GitBox
prabhjyotsingh opened a new pull request #19025: URL: https://github.com/apache/airflow/pull/19025 This is a minor CSS to add padding on the table and paginator. It does not make or break anything but makes this page looks slightly different from others. I've added before/after below

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19024: Data type (Bit / INTEGER) incompatibility between schema and file in MysqltoGCSOperator

2021-10-16 Thread GitBox
boring-cyborg[bot] commented on issue #19024: URL: https://github.com/apache/airflow/issues/19024#issuecomment-944972806 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj edited a comment on issue #18913: Better "recipe" for image with gcloud

2021-10-16 Thread GitBox
mik-laj edited a comment on issue #18913: URL: https://github.com/apache/airflow/issues/18913#issuecomment-941317784 We can still delete a few unnecessary files. ```Dockerfile && rm -rf "/root/.config/gcloud/logs/" \ && find "$(python -c 'import sys; print(sys.prefix);')"

[GitHub] [airflow] oriolcmp commented on issue #12985: PythonVirtualenvOperator with provide_context=True does not have 'ti' keyword

2021-10-16 Thread GitBox
oriolcmp commented on issue #12985: URL: https://github.com/apache/airflow/issues/12985#issuecomment-944295056 Sorry but I don't think it shouldn't be a feature. It is a bug because If I'm not wrong all operators should be able to use XCom variables. And with this operator currently this

[GitHub] [airflow] kaxil closed pull request #18875: Add explicit session parameter in PoolSlotsAvailableDep

2021-10-16 Thread GitBox
kaxil closed pull request #18875: URL: https://github.com/apache/airflow/pull/18875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on a change in pull request #18718: Add hook_params in BaseSqlOperator

2021-10-16 Thread GitBox
kaxil commented on a change in pull request #18718: URL: https://github.com/apache/airflow/pull/18718#discussion_r730107853 ## File path: airflow/models/connection.py ## @@ -289,8 +289,11 @@ def rotate_fernet_key(self): if self._extra and self.is_extra_encrypted:

[GitHub] [airflow] ecerulm commented on pull request #18042: Fixing ses email backend

2021-10-16 Thread GitBox
ecerulm commented on pull request #18042: URL: https://github.com/apache/airflow/pull/18042#issuecomment-944211690 @ignaski ,can you rebase this? @uranusjr , is there anything else needed to merge this? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] dimon222 commented on issue #18239: Airflow Celery Worker logs inaccessible

2021-10-16 Thread GitBox
dimon222 commented on issue #18239: URL: https://github.com/apache/airflow/issues/18239#issuecomment-944827298 > By running the workers behind a load balancer, you're removing the webserver's ability to specify which server the logs are stored on.. I would assume "shared logs" implies

[GitHub] [airflow] potatochip edited a comment on issue #19015: Remote logging using GCP connection from connection table broken

2021-10-16 Thread GitBox
potatochip edited a comment on issue #19015: URL: https://github.com/apache/airflow/issues/19015#issuecomment-944584848 that is the standard way of doing it. it is referenced in the airflow configuration

[GitHub] [airflow] kaxil commented on issue #18843: SerializedDagNotFound: DAG not found in serialized_dag table

2021-10-16 Thread GitBox
kaxil commented on issue #18843: URL: https://github.com/apache/airflow/issues/18843#issuecomment-944653584 Yes, we should fix it in 2.2.2 - Scheduler should not crash and instead handle the `SerializedDagNotFound` error. @easontm @juroVee !KulykDmytro - Can you confirm if this

[GitHub] [airflow] codenamestif commented on issue #18089: KeyError when ECS failed to start image

2021-10-16 Thread GitBox
codenamestif commented on issue #18089: URL: https://github.com/apache/airflow/issues/18089#issuecomment-944887234 @theagilehacker I was able to reproduce same error: 1. start task from airflow 2. manually stop ECS task from ECS console before the task reached `RUNNING`

[GitHub] [airflow] sunank200 edited a comment on pull request #19018: S3 hooks filter options

2021-10-16 Thread GitBox
sunank200 edited a comment on pull request #19018: URL: https://github.com/apache/airflow/pull/19018#issuecomment-944801148 @potiuk @dstandish @eladkal could you trigger the CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] kaxil merged pull request #19012: Fix typos in CHANGELOG.txt

2021-10-16 Thread GitBox
kaxil merged pull request #19012: URL: https://github.com/apache/airflow/pull/19012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] theagilehacker commented on issue #18089: KeyError when ECS failed to start image

2021-10-16 Thread GitBox
theagilehacker commented on issue #18089: URL: https://github.com/apache/airflow/issues/18089#issuecomment-944992737 Oh nice, I guess that makes sense if you kill it before it is about to load the container should cause the same issue. -- This is an automated message from the Apache

[GitHub] [airflow] josh-fell commented on issue #12726: Add classic operator in TaskFlow API tutorial

2021-10-16 Thread GitBox
josh-fell commented on issue #12726: URL: https://github.com/apache/airflow/issues/12726#issuecomment-944918034 @eladkal @vikramkoka Following up on this. Feel free to assign to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] bbovenzi commented on pull request #18931: Add clear task menu on task instance view

2021-10-16 Thread GitBox
bbovenzi commented on pull request #18931: URL: https://github.com/apache/airflow/pull/18931#issuecomment-944968730 The simplest change would be to set a `max-width` on the `` element. So the clear button stays closer to the actions. I would also recommend adding a title above the action

[GitHub] [airflow] HaloKo4 commented on pull request #16931: #16692 show schedule_interval/timetable description in UI

2021-10-16 Thread GitBox
HaloKo4 commented on pull request #16931: URL: https://github.com/apache/airflow/pull/16931#issuecomment-944498545 What will it show for 6th param in cron expression? croniter doesn't follow the convention about it see https://github.com/taichino/croniter/issues/176 -- This is an

[GitHub] [airflow] kaxil commented on issue #17085: Configuration validation for run-configs

2021-10-16 Thread GitBox
kaxil commented on issue #17085: URL: https://github.com/apache/airflow/issues/17085#issuecomment-944872558 closed by https://github.com/apache/airflow/pull/17100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] bbovenzi commented on a change in pull request #16931: #16692 show cron description in UI

2021-10-16 Thread GitBox
bbovenzi commented on a change in pull request #16931: URL: https://github.com/apache/airflow/pull/16931#discussion_r729075558 ## File path: airflow/www/templates/airflow/dag.html ## @@ -91,11 +91,15 @@ Schedule: {{ dag.schedule_interval }} + {%

[GitHub] [airflow] github-actions[bot] commented on pull request #19023: Skip updating constraints when only datetime changes

2021-10-16 Thread GitBox
github-actions[bot] commented on pull request #19023: URL: https://github.com/apache/airflow/pull/19023#issuecomment-944980038 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] dimon222 edited a comment on issue #18939: Upgrading from version 2.1.4 to 2.2.0 fails during mysql db upgrade with error Can't DROP 'dag_id'

2021-10-16 Thread GitBox
dimon222 edited a comment on issue #18939: URL: https://github.com/apache/airflow/issues/18939#issuecomment-944703655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potatochip opened a new issue #19015: Remote logging using GCP connection from connection table broken

2021-10-16 Thread GitBox
potatochip opened a new issue #19015: URL: https://github.com/apache/airflow/issues/19015 ### Apache Airflow version 2.2.0 (latest released) ### Operating System linux ### Versions of Apache Airflow Providers _No response_ ### Deployment

[GitHub] [airflow] eladkal closed issue #14319: tasks with `none_failed` trigger rule do not run when all upstream tasks are skipped

2021-10-16 Thread GitBox
eladkal closed issue #14319: URL: https://github.com/apache/airflow/issues/14319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] dstandish commented on pull request #19003: Increase default liveness probe timeout

2021-10-16 Thread GitBox
dstandish commented on pull request #19003: URL: https://github.com/apache/airflow/pull/19003#issuecomment-944652256 So what's slow about the liveness probe is the import of airflow, which takes around 5 seconds it seems. Is the "right" way to do this to add `scheduler-health`

[GitHub] [airflow] piorkowskiprzemyslaw opened a new pull request #19009: Pass custom_headers to send_email and send_email_smtp

2021-10-16 Thread GitBox
piorkowskiprzemyslaw opened a new pull request #19009: URL: https://github.com/apache/airflow/pull/19009 closes: #16740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] kapopken opened a new issue #19007: argument execution_date: invalid parse value

2021-10-16 Thread GitBox
kapopken opened a new issue #19007: URL: https://github.com/apache/airflow/issues/19007 ### Apache Airflow version 2.2.0 (latest released) ### Operating System apache/airflow:2.2.0-python3.8 ### Versions of Apache Airflow Providers ``` RUN pip install

[GitHub] [airflow] Bowrna edited a comment on issue #11913: Add how-to Guide for MSSQL operators

2021-10-16 Thread GitBox
Bowrna edited a comment on issue #11913: URL: https://github.com/apache/airflow/issues/11913#issuecomment-944891532 Do we need to include sample code in the airflow/example_dags to add docs? @kaxil -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] kaxil commented on a change in pull request #19013: Minor grammar tweaks in docs

2021-10-16 Thread GitBox
kaxil commented on a change in pull request #19013: URL: https://github.com/apache/airflow/pull/19013#discussion_r729982570 ## File path: docs/apache-airflow/tutorial.rst ## @@ -182,11 +182,11 @@ in templates, make sure to read through the :ref:`templates-ref`. Adding DAG

[GitHub] [airflow] kapopken commented on issue #19007: argument execution_date: invalid parse value

2021-10-16 Thread GitBox
kapopken commented on issue #19007: URL: https://github.com/apache/airflow/issues/19007#issuecomment-944401814 Closing issue. The issue ended up being a typo which went to our old docker image repo 2 letter difference. This issue is solved. -- This is an automated message from the

[GitHub] [airflow] sunank200 commented on pull request #16821: Add more filter options to list_keys of S3Hook

2021-10-16 Thread GitBox
sunank200 commented on pull request #16821: URL: https://github.com/apache/airflow/pull/16821#issuecomment-944804074 Have implemented the pre-commit hook changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] xinbinhuang commented on a change in pull request #19019: Clean up JenkinsJobTriggerOperator

2021-10-16 Thread GitBox
xinbinhuang commented on a change in pull request #19019: URL: https://github.com/apache/airflow/pull/19019#discussion_r730177898 ## File path: airflow/providers/jenkins/operators/jenkins_job_trigger.py ## @@ -130,15 +130,6 @@ def build_job(self, jenkins_server: Jenkins,

[GitHub] [airflow] kaxil closed pull request #19017: fixed incorrect KubernetesPodOperator param name

2021-10-16 Thread GitBox
kaxil closed pull request #19017: URL: https://github.com/apache/airflow/pull/19017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] sunank200 commented on pull request #19018: S3 hooks filter options

2021-10-16 Thread GitBox
sunank200 commented on pull request #19018: URL: https://github.com/apache/airflow/pull/19018#issuecomment-944801148 @potiuk @dstandish could you trigger the CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

  1   2   >