[GitHub] [airflow] lwyszomi closed pull request #18879: Upgrade the dataproc package to 3.0.0 and migrate from v1beta2 to v1 api

2021-10-18 Thread GitBox
lwyszomi closed pull request #18879: URL: https://github.com/apache/airflow/pull/18879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] Bowrna commented on issue #19045: Setting up development environment for Airflow: Pyenv commands failed in macOS

2021-10-18 Thread GitBox
Bowrna commented on issue #19045: URL: https://github.com/apache/airflow/issues/19045#issuecomment-946382127 thank you @potiuk for your description. I will fix this and raise the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] github-actions[bot] commented on pull request #19036: replaced '.' with '-' and adjusted trimmed_pod_id per ticket comments

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #19036: URL: https://github.com/apache/airflow/pull/19036#issuecomment-946378601 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] uranusjr opened a new pull request #19064: Remove distutils usages for Python 3.10

2021-10-18 Thread GitBox
uranusjr opened a new pull request #19064: URL: https://github.com/apache/airflow/pull/19064 See #19059. Version parsing capabilities when building provider packages is now provided by `packaging.version.Version` instead. Non-Python software version parsing (sqlite) is

[GitHub] [airflow] ashmeet13 commented on issue #17778: Add Arango hook

2021-10-18 Thread GitBox
ashmeet13 commented on issue #17778: URL: https://github.com/apache/airflow/issues/17778#issuecomment-946369213 Hi @mrbazzan, sorry should have updated here - I am not you can go ahead and pick this up. My bad. I did however start on this and you can find a bit of code that I had

[GitHub] [airflow] kd2718 commented on a change in pull request #19036: replaced '.' with '-' and adjusted trimmed_pod_id per ticket comments

2021-10-18 Thread GitBox
kd2718 commented on a change in pull request #19036: URL: https://github.com/apache/airflow/pull/19036#discussion_r731487808 ## File path: airflow/kubernetes/pod_generator.py ## @@ -460,9 +460,9 @@ def make_unique_pod_id(pod_id: str) -> str: safe_uuid =

[GitHub] [airflow] andrenerd closed issue #19037: Set replace_microseconds to False

2021-10-18 Thread GitBox
andrenerd closed issue #19037: URL: https://github.com/apache/airflow/issues/19037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #19063: Rename execution date in forms and tables

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #19063: URL: https://github.com/apache/airflow/pull/19063#issuecomment-946345806 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] prabhjyotsingh commented on pull request #19025: [Minor] Fix padding on home page

2021-10-18 Thread GitBox
prabhjyotsingh commented on pull request #19025: URL: https://github.com/apache/airflow/pull/19025#issuecomment-946336910 Nothing new looks broken 爛. "Lint Helm Chart" failure looks unrelated.

[GitHub] [airflow] josh-fell commented on a change in pull request #19062: Static start_date and default arg cleanup for Microsoft providers example DAGs

2021-10-18 Thread GitBox
josh-fell commented on a change in pull request #19062: URL: https://github.com/apache/airflow/pull/19062#discussion_r731459874 ## File path: docs/apache-airflow-providers-microsoft-azure/operators/azure_blob_to_gcs.rst ## @@ -51,10 +51,10 @@ Operator transfers data from

[GitHub] [airflow] josh-fell commented on a change in pull request #19062: Static start_date and default arg cleanup for Microsoft providers example DAGs

2021-10-18 Thread GitBox
josh-fell commented on a change in pull request #19062: URL: https://github.com/apache/airflow/pull/19062#discussion_r731459744 ## File path: airflow/providers/microsoft/winrm/example_dags/example_winrm.py ## @@ -28,23 +28,22 @@ """ This is an example dag for using the

[GitHub] [airflow] bbovenzi opened a new pull request #19063: Rename execution date in forms and tables

2021-10-18 Thread GitBox
bbovenzi opened a new pull request #19063: URL: https://github.com/apache/airflow/pull/19063 Update references of "Execution Date" to "Logical Date" in forms and tables of the UI. Examples:

[GitHub] [airflow] josh-fell commented on a change in pull request #19062: Static start_date and default arg cleanup for Microsoft providers example DAGs

2021-10-18 Thread GitBox
josh-fell commented on a change in pull request #19062: URL: https://github.com/apache/airflow/pull/19062#discussion_r731459244 ## File path: airflow/providers/microsoft/azure/example_dags/example_azure_container_instances.py ## @@ -27,17 +27,10 @@ with DAG(

[GitHub] [airflow] josh-fell commented on a change in pull request #19062: Static start_date and default arg cleanup for Microsoft providers example DAGs

2021-10-18 Thread GitBox
josh-fell commented on a change in pull request #19062: URL: https://github.com/apache/airflow/pull/19062#discussion_r731458987 ## File path: airflow/providers/microsoft/azure/example_dags/example_azure_blob_to_gcs.py ## @@ -16,44 +16,33 @@ # specific language governing

[GitHub] [airflow] josh-fell opened a new pull request #19062: Static start_date and default arg cleanup for Microsoft providers example DAGs

2021-10-18 Thread GitBox
josh-fell opened a new pull request #19062: URL: https://github.com/apache/airflow/pull/19062 There is an ongoing effort to enhance example DAGs by setting static values for `start_date` (already complete for core example DAGs), cleaning up and/or implementing useful `default_args`, and

[airflow] 01/01: Rename execution date in forms and tables

2021-10-18 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch replace-execution-date-with-logical-date in repository https://gitbox.apache.org/repos/asf/airflow.git commit babe8fde5a3b17b9b50e1ddbfd21a35031b27ada Author: Brent Bovenzi AuthorDate: Mon Oct

[airflow] branch replace-execution-date-with-logical-date created (now babe8fd)

2021-10-18 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch replace-execution-date-with-logical-date in repository https://gitbox.apache.org/repos/asf/airflow.git. at babe8fd Rename execution date in forms and tables This branch includes the

[GitHub] [airflow] uranusjr commented on a change in pull request #19060: Warn about unsupported Python 3.10

2021-10-18 Thread GitBox
uranusjr commented on a change in pull request #19060: URL: https://github.com/apache/airflow/pull/19060#discussion_r731444613 ## File path: airflow/__main__.py ## @@ -19,20 +19,28 @@ # under the License. """Main executable module""" - +import logging import os import

[GitHub] [airflow] github-actions[bot] commented on pull request #19061: Rename trigger page label to Logical Date

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #19061: URL: https://github.com/apache/airflow/pull/19061#issuecomment-946313479 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] uranusjr opened a new pull request #19061: Rename trigger page label to Logical Date

2021-10-18 Thread GitBox
uranusjr opened a new pull request #19061: URL: https://github.com/apache/airflow/pull/19061 AIP-39 changed the canonical name from Execution Date, and this should match it. I'm wondering whether we should change the trigger page to have _two_ calendar pickers to represent the data

[GitHub] [airflow] mik-laj opened a new pull request #19060: Warn about unsupported Python 3.10

2021-10-18 Thread GitBox
mik-laj opened a new pull request #19060: URL: https://github.com/apache/airflow/pull/19060 Related: https://github.com/apache/airflow/issues/19059 Some users are unaware of the supported Python versions and then have trouble using Airflow. It's best to alert them to be aware of

[GitHub] [airflow] uranusjr commented on issue #19059: Add Python 3.10 support

2021-10-18 Thread GitBox
uranusjr commented on issue #19059: URL: https://github.com/apache/airflow/issues/19059#issuecomment-946304173 The `ModuleNotFoundError: No module named 'pwd'` error the user gets is weird though. Airflow should have no problem running on 3.10 (albeit not officially supported), and the

[GitHub] [airflow] mik-laj opened a new issue #19059: Add Python 3.10 support

2021-10-18 Thread GitBox
mik-laj opened a new issue #19059: URL: https://github.com/apache/airflow/issues/19059 ### Description According to README.md - "Support for Python and Kubernetes versions": > We support a new version of Python/Kubernetes in main after they are officially released, as soon

[GitHub] [airflow] github-actions[bot] commented on pull request #19052: Replacing non-attribute template_fields for BigQueryToMsSqlOperator

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #19052: URL: https://github.com/apache/airflow/pull/19052#issuecomment-946300363 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] mik-laj closed issue #12508: Run pip check in CI pipelines

2021-10-18 Thread GitBox
mik-laj closed issue #12508: URL: https://github.com/apache/airflow/issues/12508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] mik-laj commented on issue #12508: Run pip check in CI pipelines

2021-10-18 Thread GitBox
mik-laj commented on issue #12508: URL: https://github.com/apache/airflow/issues/12508#issuecomment-946298413 Done: https://github.com/apache/airflow/blob/e25eea052fd54c94b490a377de05c6bae4c24dbb/scripts/docker/install_airflow.sh#L63 -- This is an automated message from the Apache Git

[GitHub] [airflow] josh-fell commented on pull request #19052: Replacing non-attribute template_fields for BigQueryToMsSqlOperator

2021-10-18 Thread GitBox
josh-fell commented on pull request #19052: URL: https://github.com/apache/airflow/pull/19052#issuecomment-946294702 CC @dudutch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated: Workaround libstdcpp TLS error (#19010)

2021-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8858309 Workaround libstdcpp TLS error (#19010)

[GitHub] [airflow] potiuk merged pull request #19010: Workaround libstdcpp TLS error

2021-10-18 Thread GitBox
potiuk merged pull request #19010: URL: https://github.com/apache/airflow/pull/19010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on a change in pull request #19034: Allow Param to support a default value of ``None``

2021-10-18 Thread GitBox
uranusjr commented on a change in pull request #19034: URL: https://github.com/apache/airflow/pull/19034#discussion_r731414520 ## File path: airflow/models/param.py ## @@ -38,37 +48,44 @@ class Param: :type schema: dict """ -def __init__(self, default: Any =

[GitHub] [airflow] github-actions[bot] commented on pull request #19057: Update docstring to let users use `node_selector`

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #19057: URL: https://github.com/apache/airflow/pull/19057#issuecomment-946277243 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] github-actions[bot] commented on pull request #19010: Workaround libstdcpp TLS error

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #19010: URL: https://github.com/apache/airflow/pull/19010#issuecomment-946275408 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] uranusjr commented on a change in pull request #18042: Fixing ses email backend

2021-10-18 Thread GitBox
uranusjr commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r731411083 ## File path: airflow/config_templates/config.yml ## @@ -1358,6 +1358,14 @@ example: "/path/to/my_html_content_template_file" default: ~

[GitHub] [airflow] uranusjr commented on a change in pull request #18042: Fixing ses email backend

2021-10-18 Thread GitBox
uranusjr commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r731410907 ## File path: airflow/config_templates/config.yml ## @@ -1358,6 +1358,14 @@ example: "/path/to/my_html_content_template_file" default: ~

[GitHub] [airflow] uranusjr commented on pull request #16166: Fixing SES backend - source (mail_from) must be string.

2021-10-18 Thread GitBox
uranusjr commented on pull request #16166: URL: https://github.com/apache/airflow/pull/16166#issuecomment-946272873 Continuing in #18042. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] uranusjr closed pull request #16166: Fixing SES backend - source (mail_from) must be string.

2021-10-18 Thread GitBox
uranusjr closed pull request #16166: URL: https://github.com/apache/airflow/pull/16166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #16166: Fixing SES backend - source (mail_from) must be string.

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #16166: URL: https://github.com/apache/airflow/pull/16166#issuecomment-946259427 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on pull request #17485: Pass explicit state, not a success boolean

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #17485: URL: https://github.com/apache/airflow/pull/17485#issuecomment-946259391 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] potiuk edited a comment on pull request #19042: Update CONTRIBUTORS_QUICK_START.rst

2021-10-18 Thread GitBox
potiuk edited a comment on pull request #19042: URL: https://github.com/apache/airflow/pull/19042#issuecomment-946250086 > Sorry, I think I got you confused. I mean that they should be in this pull request. Close the others and add the changes to this one Yeah. Agree those are

[GitHub] [airflow] potiuk commented on pull request #19042: Update CONTRIBUTORS_QUICK_START.rst

2021-10-18 Thread GitBox
potiuk commented on pull request #19042: URL: https://github.com/apache/airflow/pull/19042#issuecomment-946250086 > Sorry, I think I got you confused. I mean that they should be in this pull request. Close the others and add the changes to this one Yeah. Agre e those are better

[GitHub] [airflow] potiuk commented on a change in pull request #19010: Workaround libstdcpp TLS error

2021-10-18 Thread GitBox
potiuk commented on a change in pull request #19010: URL: https://github.com/apache/airflow/pull/19010#discussion_r731386158 ## File path: Dockerfile.ci ## @@ -400,6 +400,16 @@ LABEL org.apache.airflow.distro="debian" \ org.opencontainers.image.title="Continuous Integration

[GitHub] [airflow] jedcunningham opened a new issue #19058: Manual dagrun logs to last scheduled dagruns log files

2021-10-18 Thread GitBox
jedcunningham opened a new issue #19058: URL: https://github.com/apache/airflow/issues/19058 ### Apache Airflow version 2.2.0 (latest released) ### Operating System MacOS 11.6 ### Versions of Apache Airflow Providers _No response_ ### Deployment

[GitHub] [airflow] ysk24ok opened a new pull request #19057: Update docstring to let users use `node_selector`

2021-10-18 Thread GitBox
ysk24ok opened a new pull request #19057: URL: https://github.com/apache/airflow/pull/19057 Updated `KubernetesPodOperator` docstring to let users use `node_selector` instead of `node_selectors` because `node_selectors` is deprecated. --- **^ Add meaningful description

[GitHub] [airflow] mik-laj commented on a change in pull request #19053: Referencing Connections in tutorial doc

2021-10-18 Thread GitBox
mik-laj commented on a change in pull request #19053: URL: https://github.com/apache/airflow/pull/19053#discussion_r731353667 ## File path: docs/apache-airflow/tutorial.rst ## @@ -377,6 +377,24 @@ We need to have docker and postgres installed. We will be using this `docker

[GitHub] [airflow] ephraimbuddy commented on pull request #19042: Update CONTRIBUTORS_QUICK_START.rst

2021-10-18 Thread GitBox
ephraimbuddy commented on pull request #19042: URL: https://github.com/apache/airflow/pull/19042#issuecomment-946205359 > > > @potiuk @ephraimbuddy @uranusjr I have updated and made the pull requests. Please let me know if there's another way I can help or anything else I can do to get

[GitHub] [airflow] OyinOlamide commented on pull request #19042: Update CONTRIBUTORS_QUICK_START.rst

2021-10-18 Thread GitBox
OyinOlamide commented on pull request #19042: URL: https://github.com/apache/airflow/pull/19042#issuecomment-946204214 > > @potiuk @ephraimbuddy @uranusjr I have updated and made the pull requests. Please let me know if there's another way I can help or anything else I can do to get the

[GitHub] [airflow] ephraimbuddy commented on pull request #19042: Update CONTRIBUTORS_QUICK_START.rst

2021-10-18 Thread GitBox
ephraimbuddy commented on pull request #19042: URL: https://github.com/apache/airflow/pull/19042#issuecomment-946182784 > @potiuk @ephraimbuddy @uranusjr I have updated and made the pull requests. Please let me know if there's another way I can help or anything else I can do to get the PR

[GitHub] [airflow] github-actions[bot] commented on pull request #18726: Consolidate method names between Airflow Security Manager and FAB default

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #18726: URL: https://github.com/apache/airflow/pull/18726#issuecomment-946167576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] jedcunningham commented on a change in pull request #18726: Consolidate method names between Airflow Security Manager and FAB default

2021-10-18 Thread GitBox
jedcunningham commented on a change in pull request #18726: URL: https://github.com/apache/airflow/pull/18726#discussion_r731311389 ## File path: airflow/www/fab_security/manager.py ## @@ -1347,20 +1345,20 @@ def _get_user_permission_view_menus( # include public

[GitHub] [airflow] mik-laj commented on a change in pull request #18945: Add dataproc metastore operators

2021-10-18 Thread GitBox
mik-laj commented on a change in pull request #18945: URL: https://github.com/apache/airflow/pull/18945#discussion_r731316602 ## File path: airflow/providers/google/cloud/hooks/dataproc_metastore.py ## @@ -0,0 +1,673 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] OyinOlamide opened a new pull request #19056: Update INSTALL

2021-10-18 Thread GitBox
OyinOlamide opened a new pull request #19056: URL: https://github.com/apache/airflow/pull/19056 I am Oyinkansola Awosan, an Outreachy applicant for the December - March round. This commit is necessitated by changes made in the contributors set up guide that needs to be implemented

[GitHub] [airflow] OyinOlamide opened a new pull request #19055: Update breeze

2021-10-18 Thread GitBox
OyinOlamide opened a new pull request #19055: URL: https://github.com/apache/airflow/pull/19055 I am Oyinkansola Awosan, an Outreachy applicant for the December - March round. This commit is necessitated by changes made in the contributors set up guide that needs to be implemented

[GitHub] [airflow] wojsamjan commented on a change in pull request #18945: Add dataproc metastore operators

2021-10-18 Thread GitBox
wojsamjan commented on a change in pull request #18945: URL: https://github.com/apache/airflow/pull/18945#discussion_r728882220 ## File path: airflow/providers/google/cloud/hooks/dataproc_metastore.py ## @@ -0,0 +1,673 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] OyinOlamide commented on pull request #19042: Update CONTRIBUTORS_QUICK_START.rst

2021-10-18 Thread GitBox
OyinOlamide commented on pull request #19042: URL: https://github.com/apache/airflow/pull/19042#issuecomment-946156994 @potiuk @ephraimbuddy @uranusjr I have updated and made the pull requests. Please let me know if there's another way I can help or anything else I can do to get the

[GitHub] [airflow] wojsamjan commented on a change in pull request #18945: Add dataproc metastore operators

2021-10-18 Thread GitBox
wojsamjan commented on a change in pull request #18945: URL: https://github.com/apache/airflow/pull/18945#discussion_r728871371 ## File path: airflow/providers/google/cloud/hooks/dataproc_metastore.py ## @@ -0,0 +1,673 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] mrbazzan edited a comment on issue #16921: Add support for Salesforce Bulk API

2021-10-18 Thread GitBox
mrbazzan edited a comment on issue #16921: URL: https://github.com/apache/airflow/issues/16921#issuecomment-946140083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] mrbazzan commented on issue #16921: Add support for Salesforce Bulk API

2021-10-18 Thread GitBox
mrbazzan commented on issue #16921: URL: https://github.com/apache/airflow/issues/16921#issuecomment-946155926 @subkanthi Alright -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] subkanthi commented on issue #16921: Add support for Salesforce Bulk API

2021-10-18 Thread GitBox
subkanthi commented on issue #16921: URL: https://github.com/apache/airflow/issues/16921#issuecomment-946141910 @mrbazzan I should have the PR this week hopefully -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] mrbazzan commented on issue #16921: Add support for Salesforce Bulk API

2021-10-18 Thread GitBox
mrbazzan commented on issue #16921: URL: https://github.com/apache/airflow/issues/16921#issuecomment-946140083 @eladkal Are you still working on this issue or should I pick it up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] mrbazzan commented on issue #17778: Add Arango hook

2021-10-18 Thread GitBox
mrbazzan commented on issue #17778: URL: https://github.com/apache/airflow/issues/17778#issuecomment-946137980 @ashmeet13 Are you still working on this issue? I'm interested if you aren't working on it anymore -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] mrbazzan commented on issue #17815: Missing example for Salesforce DAG

2021-10-18 Thread GitBox
mrbazzan commented on issue #17815: URL: https://github.com/apache/airflow/issues/17815#issuecomment-946135929 @SCrocky Are you still working on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] jedcunningham commented on a change in pull request #19010: Workaround libstdcpp TLS error

2021-10-18 Thread GitBox
jedcunningham commented on a change in pull request #19010: URL: https://github.com/apache/airflow/pull/19010#discussion_r731283680 ## File path: Dockerfile.ci ## @@ -400,6 +400,16 @@ LABEL org.apache.airflow.distro="debian" \ org.opencontainers.image.title="Continuous

[GitHub] [airflow] jedcunningham commented on a change in pull request #19034: Fix ``None`` default Param; refactor Param default handling

2021-10-18 Thread GitBox
jedcunningham commented on a change in pull request #19034: URL: https://github.com/apache/airflow/pull/19034#discussion_r731268063 ## File path: airflow/models/param.py ## @@ -38,37 +48,44 @@ class Param: :type schema: dict """ -def __init__(self, default: Any

[GitHub] [airflow] asaf400 commented on a change in pull request #19027: Fix for DockerOperator Xcoms functionality

2021-10-18 Thread GitBox
asaf400 commented on a change in pull request #19027: URL: https://github.com/apache/airflow/pull/19027#discussion_r731265880 ## File path: airflow/providers/docker/operators/docker.py ## @@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts, add_tmp_variable:

[GitHub] [airflow] asaf400 commented on a change in pull request #19027: Fix for DockerOperator Xcoms functionality

2021-10-18 Thread GitBox
asaf400 commented on a change in pull request #19027: URL: https://github.com/apache/airflow/pull/19027#discussion_r731265880 ## File path: airflow/providers/docker/operators/docker.py ## @@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts, add_tmp_variable:

[GitHub] [airflow] asaf400 commented on a change in pull request #19027: Fix for DockerOperator Xcoms functionality

2021-10-18 Thread GitBox
asaf400 commented on a change in pull request #19027: URL: https://github.com/apache/airflow/pull/19027#discussion_r731258638 ## File path: airflow/providers/docker/operators/docker.py ## @@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts, add_tmp_variable:

[GitHub] [airflow] asaf400 commented on a change in pull request #19027: Fix for DockerOperator Xcoms functionality

2021-10-18 Thread GitBox
asaf400 commented on a change in pull request #19027: URL: https://github.com/apache/airflow/pull/19027#discussion_r731258267 ## File path: airflow/providers/docker/operators/docker.py ## @@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts, add_tmp_variable:

[GitHub] [airflow] potiuk commented on issue #19045: Setting up development environment for Airflow: Pyenv commands failed in macOS

2021-10-18 Thread GitBox
potiuk commented on issue #19045: URL: https://github.com/apache/airflow/issues/19045#issuecomment-946100465 Also - following the discussion https://apache-airflow.slack.com/archives/CQ9QHSFQX/p1634550158070300 It seems that we have a little "destructive" behaviour of

[GitHub] [airflow] potiuk commented on pull request #19042: Update CONTRIBUTORS_QUICK_START.rst

2021-10-18 Thread GitBox
potiuk commented on pull request #19042: URL: https://github.com/apache/airflow/pull/19042#issuecomment-946089644 > Other places you should update too are: Yeah - would be nice to update those other places too - they give people some guldelines if their installation fails, so it's

[GitHub] [airflow] potiuk commented on a change in pull request #19042: Update CONTRIBUTORS_QUICK_START.rst

2021-10-18 Thread GitBox
potiuk commented on a change in pull request #19042: URL: https://github.com/apache/airflow/pull/19042#discussion_r731242547 ## File path: CONTRIBUTORS_QUICK_START.rst ## @@ -136,8 +136,8 @@ Pyenv and setting up virtual-env libreadline-dev libsqlite3-dev wget curl llvm

[GitHub] [airflow] Aakcht opened a new pull request #19054: Chart: allow specifying keytab in values.yaml

2021-10-18 Thread GitBox
Aakcht opened a new pull request #19054: URL: https://github.com/apache/airflow/pull/19054 This PR adds parameter for specifying base64 encoded keytab content in values.yaml. This makes it possible to manage keytab updates with the chart. -- This is an automated message from the Apache

[GitHub] [airflow] bbovenzi commented on pull request #19025: [Minor] Fix padding on home page

2021-10-18 Thread GitBox
bbovenzi commented on pull request #19025: URL: https://github.com/apache/airflow/pull/19025#issuecomment-946066655 Could you also check all hover/dropdowns on the last row of a table? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] hpatel-higi commented on issue #18846: Scheduler stops running: psycopg2.OperationalError: SSL SYSCALL error: EOF detected

2021-10-18 Thread GitBox
hpatel-higi commented on issue #18846: URL: https://github.com/apache/airflow/issues/18846#issuecomment-946048322 This is also the other error we are getting now: ``` 2021-10-15T04:26:35.894475528Z sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) server closed the

[GitHub] [airflow] drobert opened a new pull request #19053: Referencing Connections in tutorial doc

2021-10-18 Thread GitBox
drobert opened a new pull request #19053: URL: https://github.com/apache/airflow/pull/19053 closes: #18950 - added notes on configuring a `Connection` in tutorial example - added logging to tutorial example - used streaming ingest in tutorial example ##

[GitHub] [airflow] prabhjyotsingh commented on pull request #19025: [Minor] Fix padding on home page

2021-10-18 Thread GitBox
prabhjyotsingh commented on pull request #19025: URL: https://github.com/apache/airflow/pull/19025#issuecomment-946041440 Sure hopefully I didn't break anything. ![option2](https://user-images.githubusercontent.com/674497/137785578-7ecdb5b7-ad09-4077-af10-9605d2778b36.gif) --

[GitHub] [airflow] ryanahamilton commented on pull request #19025: [Minor] Fix padding on home page

2021-10-18 Thread GitBox
ryanahamilton commented on pull request #19025: URL: https://github.com/apache/airflow/pull/19025#issuecomment-946038838 Yeah, I think #1 is how it has been, but I agree with @bbovenzi that #2 is probably the more consistent presentation. -- This is an automated message from the Apache

[GitHub] [airflow] bbovenzi commented on pull request #19025: [Minor] Fix padding on home page

2021-10-18 Thread GitBox
bbovenzi commented on pull request #19025: URL: https://github.com/apache/airflow/pull/19025#issuecomment-946036859 I think option-2 is more consistent. I would just make sure that any dropdowns and tooltips don't get cut off. -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] prabhjyotsingh commented on pull request #19025: [Minor] Fix padding on home page

2021-10-18 Thread GitBox
prabhjyotsingh commented on pull request #19025: URL: https://github.com/apache/airflow/pull/19025#issuecomment-946035643 @ryanahamilton Sure, which one looks better? Option-1:

[GitHub] [airflow] josh-fell opened a new pull request #19052: Replacing non-attribute template_fields for BigQueryToMsSqlOperator + related example DAG update

2021-10-18 Thread GitBox
josh-fell opened a new pull request #19052: URL: https://github.com/apache/airflow/pull/19052 The `BigQueryToMsSqlOperator` has `template_fields` values for attributes that do not exist for the operator : `dataset_id` and `table_id`. As a result, the following exception is thrown during

[GitHub] [airflow] SamWheating edited a comment on pull request #18924: Adding dag_id_pattern parameter to the /dags endpoint

2021-10-18 Thread GitBox
SamWheating edited a comment on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-945999217 I agree that `dag_id_ilike` isn't great because it results in using database syntax in an API request, which means users may expect this endpoint to support other

[GitHub] [airflow] SamWheating commented on pull request #18924: Adding dag_id_pattern parameter to the /dags endpoint

2021-10-18 Thread GitBox
SamWheating commented on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-945999217 I agree that `dag_id_ilike` isn't great because it results in using database syntax in an API request. I think that `dag_id_contains` isn't quite accurate because

[GitHub] [airflow] hpatel-higi commented on issue #18846: Scheduler stops running: psycopg2.OperationalError: SSL SYSCALL error: EOF detected

2021-10-18 Thread GitBox
hpatel-higi commented on issue #18846: URL: https://github.com/apache/airflow/issues/18846#issuecomment-945988402 @potiuk so im getting a weird behavior now after adding the keep_alives args. Parent task in DAG succeeds but the subsequent task that should run after that task fail.

[GitHub] [airflow] uranusjr commented on pull request #19000: Add form to delete "moved" tables from web UI

2021-10-18 Thread GitBox
uranusjr commented on pull request #19000: URL: https://github.com/apache/airflow/pull/19000#issuecomment-945966586 I think we need to offer _something_ since direct database manipulation is probably not something most of the data pipeline ops have in their toolboxes; otherwise we

[GitHub] [airflow] dstandish opened a new pull request #19051: Add process state framework and watermark operator

2021-10-18 Thread GitBox
dstandish opened a new pull request #19051: URL: https://github.com/apache/airflow/pull/19051 PR to demo possible process state framework and watermark operator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] alex-astronomer closed issue #18217: Audit Logging for Variables, Connections, Pools

2021-10-18 Thread GitBox
alex-astronomer closed issue #18217: URL: https://github.com/apache/airflow/issues/18217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr opened a new issue #19049: Migrate execution_date database columns to logical_date

2021-10-18 Thread GitBox
uranusjr opened a new issue #19049: URL: https://github.com/apache/airflow/issues/19049 To conform with other AIP-39 changes. `execution_date` should still be kept on the class and emit a deprecation warning when accessed (either as a property or a filter). I think there's mechanism in

[GitHub] [airflow] github-actions[bot] commented on pull request #19048: Move validation of templated input params to run after the context init

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #19048: URL: https://github.com/apache/airflow/pull/19048#issuecomment-945914095 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] uranusjr commented on a change in pull request #19010: Workaround libstdcpp TLS error

2021-10-18 Thread GitBox
uranusjr commented on a change in pull request #19010: URL: https://github.com/apache/airflow/pull/19010#discussion_r731072454 ## File path: Dockerfile.ci ## @@ -400,6 +400,16 @@ LABEL org.apache.airflow.distro="debian" \ org.opencontainers.image.title="Continuous

[GitHub] [airflow] eskarimov opened a new pull request #19048: Move validation of templated input params to run after the context init

2021-10-18 Thread GitBox
eskarimov opened a new pull request #19048: URL: https://github.com/apache/airflow/pull/19048 ## Closes: #14682 Any validation of input parameter, which can be templated, shouldn't be inside operator's `__init__` function, as its real value will be available at earliest only during

[GitHub] [airflow] github-actions[bot] commented on pull request #18990: Add support of placement in the DockerSwarmOperator

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #18990: URL: https://github.com/apache/airflow/pull/18990#issuecomment-945906366 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] github-actions[bot] commented on pull request #19009: Pass custom_headers to send_email and send_email_smtp

2021-10-18 Thread GitBox
github-actions[bot] commented on pull request #19009: URL: https://github.com/apache/airflow/pull/19009#issuecomment-945905585 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] josh-fell commented on issue #12726: Add classic operator in TaskFlow API tutorial

2021-10-18 Thread GitBox
josh-fell commented on issue #12726: URL: https://github.com/apache/airflow/issues/12726#issuecomment-945895789 @eladkal Perhaps this has already been taken care of looking at the latest TaskFlow API Tutorial doc (starting

[GitHub] [airflow] eskarimov commented on pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-10-18 Thread GitBox
eskarimov commented on pull request #17446: URL: https://github.com/apache/airflow/pull/17446#issuecomment-945894875 I had to make small changes in the most recent commit, as described in the following issue #14682, validation/normalisation of input parameters, which could be templated,

[GitHub] [airflow] ephraimbuddy commented on pull request #19022: CloudwatchTaskHandler params to create log group/stream

2021-10-18 Thread GitBox
ephraimbuddy commented on pull request #19022: URL: https://github.com/apache/airflow/pull/19022#issuecomment-945892335 cc: @mik-laj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] uranusjr commented on a change in pull request #19027: Fix for DockerOperator Xcoms functionality

2021-10-18 Thread GitBox
uranusjr commented on a change in pull request #19027: URL: https://github.com/apache/airflow/pull/19027#discussion_r731040585 ## File path: airflow/providers/docker/operators/docker.py ## @@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts, add_tmp_variable:

[GitHub] [airflow] uranusjr commented on a change in pull request #19027: Fix for DockerOperator Xcoms functionality

2021-10-18 Thread GitBox
uranusjr commented on a change in pull request #19027: URL: https://github.com/apache/airflow/pull/19027#discussion_r731038338 ## File path: airflow/providers/docker/operators/docker.py ## @@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts, add_tmp_variable:

[GitHub] [airflow] uranusjr commented on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-18 Thread GitBox
uranusjr commented on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-945874974 Either `dag_id_pattern` or `dag_id_ilike` would work for me. I prefer `pattern` slightly since `ilike` is kind of leaking the database internals into the interface, but I

[GitHub] [airflow] uranusjr commented on issue #19045: Setting up development environment for Airflow: Pyenv commands failed in macOS

2021-10-18 Thread GitBox
uranusjr commented on issue #19045: URL: https://github.com/apache/airflow/issues/19045#issuecomment-945863144 Sounds good to me; assigning this to you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] uranusjr commented on issue #19040: Upgrading from 2.1.3 to 2.20 some dags fail due to pickeling

2021-10-18 Thread GitBox
uranusjr commented on issue #19040: URL: https://github.com/apache/airflow/issues/19040#issuecomment-945862008 Pickle protocol 5 is only implemented in Python 3.8+ and didn't exist when 3.6 was released, so it's pretty impossible it could be produced if the Python version never changed,

[GitHub] [airflow] Bowrna opened a new issue #19045: Setting up development environment for Airflow: Pyenv commands failed in macOS

2021-10-18 Thread GitBox
Bowrna opened a new issue #19045: URL: https://github.com/apache/airflow/issues/19045 ### Describe the issue with documentation I am following the steps in this link to set up the breeze in my machine https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst

  1   2   >