[GitHub] [airflow] vsimon opened a new pull request #19700: Fix parsing of Cloudwatch log group arn containing slashes (#14667)

2021-11-18 Thread GitBox
vsimon opened a new pull request #19700: URL: https://github.com/apache/airflow/pull/19700 When the log group arn contains slashes, the urlparse function parses the group name as part of the 'path' instead of including it as part of the 'netloc'. This fix concatenates both the

[GitHub] [airflow] MaksYermak commented on pull request #19248: Create dataproc serverless spark batches operator

2021-11-18 Thread GitBox
MaksYermak commented on pull request #19248: URL: https://github.com/apache/airflow/pull/19248#issuecomment-973834629 @turbaszek @josh-fell @mik-laj hi guys, could you look and approve this PR for merge if all good? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] pateash commented on issue #16911: Error in passing metadata to DataprocClusterCreateOperator

2021-11-18 Thread GitBox
pateash commented on issue #16911: URL: https://github.com/apache/airflow/issues/16911#issuecomment-973827278 > @pateash Sorry, just seen your reply, yes i was trying to update Airflow from 1.10x to 2.X. > > so what is the fix, i saw a merge request @rajaprakash91 You can

[GitHub] [airflow] kristoffern opened a new issue #19699: task_instances stuck in "queued" and are missing corresponding celery_taskmeta entries

2021-11-18 Thread GitBox
kristoffern opened a new issue #19699: URL: https://github.com/apache/airflow/issues/19699 ### Apache Airflow version 2.2.2 (latest released) ### Operating System apache/airflow:2.2.2-python3.8 ### Versions of Apache Airflow Providers

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19699: task_instances stuck in "queued" and are missing corresponding celery_taskmeta entries

2021-11-18 Thread GitBox
boring-cyborg[bot] commented on issue #19699: URL: https://github.com/apache/airflow/issues/19699#issuecomment-973803593 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] uranusjr commented on pull request #19640: clear task's next_method and next_kwargs when clear the task

2021-11-18 Thread GitBox
uranusjr commented on pull request #19640: URL: https://github.com/apache/airflow/pull/19640#issuecomment-973792545 Let it try again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr closed pull request #19640: clear task's next_method and next_kwargs when clear the task

2021-11-18 Thread GitBox
uranusjr closed pull request #19640: URL: https://github.com/apache/airflow/pull/19640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] rajaprakash91 commented on issue #16911: Error in passing metadata to DataprocClusterCreateOperator

2021-11-18 Thread GitBox
rajaprakash91 commented on issue #16911: URL: https://github.com/apache/airflow/issues/16911#issuecomment-973781647 @pateash Sorry, just seen your reply, yes i was trying to update Airflow from 1.10x to 2.X. so what is the fix, i saw a merge request -- This is an automated

[GitHub] [airflow] kd2718 commented on pull request #19036: replaced '.' with '-' and adjusted trimmed_pod_id per ticket comments

2021-11-18 Thread GitBox
kd2718 commented on pull request #19036: URL: https://github.com/apache/airflow/pull/19036#issuecomment-973768174 I am getting errors like this one now: https://github.com/apache/airflow/runs/4248182868?check_suite_focus=true#step:7:2000 I am not sure where to go to debug this. Any

[GitHub] [airflow] alexbegg commented on pull request #19530: Do not require all extras for SalesforceHook

2021-11-18 Thread GitBox
alexbegg commented on pull request #19530: URL: https://github.com/apache/airflow/pull/19530#issuecomment-973761875 This PR is using the same extra names as the previous version of the method. Once I make the PR I'll link it here. Also I'm a bit busy at the moment if someone want to

[GitHub] [airflow] alexbegg commented on pull request #19530: Do not require all extras for SalesforceHook

2021-11-18 Thread GitBox
alexbegg commented on pull request #19530: URL: https://github.com/apache/airflow/pull/19530#issuecomment-973758342 Yes, I am planning to make a separate PR to have `get_conn` to allow both formats, `security_token` and `extra__salesforce__security_token`. This PR initially allowed for

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19698: Graceful handle for airflow application pods during K8s API brief interuption

2021-11-18 Thread GitBox
boring-cyborg[bot] commented on issue #19698: URL: https://github.com/apache/airflow/issues/19698#issuecomment-973723520 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] nayanen opened a new issue #19698: Graceful handle for airflow application pods during K8s API brief interuption

2021-11-18 Thread GitBox
nayanen opened a new issue #19698: URL: https://github.com/apache/airflow/issues/19698 ### Description ### Description I have come across this issue where k8s customer using airflow application. The pod get terminated when there is brief API server interruption. API server

[airflow-ci-infra] 01/01: Add latest git version

2021-11-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch add-latest-git-version in repository https://gitbox.apache.org/repos/asf/airflow-ci-infra.git commit e6482ee31bf7dc5565f07406f1e7849a2cf241b7 Author: Jarek Potiuk AuthorDate: Fri Nov 19 04:06:40

[GitHub] [airflow-ci-infra] potiuk opened a new pull request #44: Add latest git version

2021-11-18 Thread GitBox
potiuk opened a new pull request #44: URL: https://github.com/apache/airflow-ci-infra/pull/44 Git should be updated to latest version to handle --ignore-matching-lines command -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[airflow-ci-infra] branch add-latest-git-version created (now e6482ee)

2021-11-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch add-latest-git-version in repository https://gitbox.apache.org/repos/asf/airflow-ci-infra.git. at e6482ee Add latest git version This branch includes the following new commits: new

[airflow] branch constraints-main updated: Update to latest constraints

2021-11-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 455ca8f Update to latest

[GitHub] [airflow] Greetlist commented on pull request #19640: clear task's next_method and next_kwargs when clear the task

2021-11-18 Thread GitBox
Greetlist commented on pull request #19640: URL: https://github.com/apache/airflow/pull/19640#issuecomment-973677298 It seems stuck at **Tests/ Wait for CI images(pull_request)**, What can I do now? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] dstandish commented on a change in pull request #19695: Add config and context params to KubernetesHook

2021-11-18 Thread GitBox
dstandish commented on a change in pull request #19695: URL: https://github.com/apache/airflow/pull/19695#discussion_r752822542 ## File path: tests/providers/cncf/kubernetes/hooks/test_kubernetes.py ## @@ -34,100 +32,124 @@ from tests.test_utils.db import clear_db_connections

[GitHub] [airflow] potiuk opened a new pull request #19697: Fix speed of yarn installation

2021-11-18 Thread GitBox
potiuk opened a new pull request #19697: URL: https://github.com/apache/airflow/pull/19697 The --network-concurrency=1 is very slow and even if this has been added in #17293 to battle connection refused, it slows regular builds far too much. There is a new optimisation in

[GitHub] [airflow] dstandish commented on pull request #19694: Coalesce `extra` params to None in KubernetesHook

2021-11-18 Thread GitBox
dstandish commented on pull request #19694: URL: https://github.com/apache/airflow/pull/19694#issuecomment-973646741 > I feel like we should have a test for this too. I can see reversing this being an "optimization" later on. reasonable -- This is an automated message from the

[airflow] branch main updated (49b7e75 -> 3336bb6)

2021-11-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 49b7e75 Fix failures with recent moto library 2.2.15 (#19693) add 3336bb6 Fix badly merged impersonation in

[GitHub] [airflow] potiuk merged pull request #19696: Fix badly merged impersonation in GKEPodOperator

2021-11-18 Thread GitBox
potiuk merged pull request #19696: URL: https://github.com/apache/airflow/pull/19696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #19696: Fix badly merged impersonation in GKEPodOperator

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #19696: URL: https://github.com/apache/airflow/pull/19696#issuecomment-973639019 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] potiuk commented on pull request #19696: Fix badly merged impersonation in GKEPodOperator

2021-11-18 Thread GitBox
potiuk commented on pull request #19696: URL: https://github.com/apache/airflow/pull/19696#issuecomment-973637934 cc: @lwyszomi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk opened a new pull request #19696: Fix badly merged impersonation in GKEPodOperator

2021-11-18 Thread GitBox
potiuk opened a new pull request #19696: URL: https://github.com/apache/airflow/pull/19696 The #19518 was merged while we had false-positive test results due to testing memory optmisation in CI - test failures went unnoticed for the change. This PR fixes the problem (both in

[airflow] branch main updated (84ea55b -> 49b7e75)

2021-11-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 84ea55b Add FAB base class and set import_name explicitly. (#19667) add 49b7e75 Fix failures with recent moto

[GitHub] [airflow] potiuk merged pull request #19693: Fix failures with recent moto library 2.2.15

2021-11-18 Thread GitBox
potiuk merged pull request #19693: URL: https://github.com/apache/airflow/pull/19693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #19693: Fix failures with recent moto library 2.2.15

2021-11-18 Thread GitBox
potiuk commented on pull request #19693: URL: https://github.com/apache/airflow/pull/19693#issuecomment-973635612 Failure is for different reason - badly merged PR due to "false positiive" test results in tests merged. Fixing in the follow-up PR -- This is an automated message from the

[GitHub] [airflow] dstandish opened a new pull request #19695: Add params to k8s hook

2021-11-18 Thread GitBox
dstandish opened a new pull request #19695: URL: https://github.com/apache/airflow/pull/19695 **Note:** Assumes merge of https://github.com/apache/airflow/pull/19694 Add config and context params to KubernetesHook This is mainly needed in order to enable use KubernetesHook

[GitHub] [airflow] dstandish opened a new pull request #19694: Coalesce `extra` params to None in KubernetesHook

2021-11-18 Thread GitBox
dstandish opened a new pull request #19694: URL: https://github.com/apache/airflow/pull/19694 When using UI form widgets FAB provides a empty string by default for every param. This turns out to make a difference sometimes. E.g. in this hook, we decide what to do depending on whether

[GitHub] [airflow] github-actions[bot] commented on issue #17190: Fetching remote s3 logs fails: An error occurred (AccessDenied) when calling the AssumeRole operation

2021-11-18 Thread GitBox
github-actions[bot] commented on issue #17190: URL: https://github.com/apache/airflow/issues/17190#issuecomment-973498614 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] commented on pull request #18652: Add banner indicating environment type

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #18652: URL: https://github.com/apache/airflow/pull/18652#issuecomment-973498562 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #18707: URL: https://github.com/apache/airflow/pull/18707#issuecomment-973498520 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on pull request #19693: Fix failures with recent moto library 2.2.15

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #19693: URL: https://github.com/apache/airflow/pull/19693#issuecomment-973496301 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on a change in pull request #19662: BaseOperator.on_kill should optionally accept airflow context

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19662: URL: https://github.com/apache/airflow/pull/19662#discussion_r752746375 ## File path: airflow/models/baseoperator.py ## @@ -1000,7 +1000,7 @@ def post_execute(self, context: Any, result: Any = None): if

[GitHub] [airflow] potiuk commented on issue #19688: Airflow does not load default connections

2021-11-18 Thread GitBox
potiuk commented on issue #19688: URL: https://github.com/apache/airflow/issues/19688#issuecomment-973465341 @dstandish is completely right. I already explained that to you ~ week ago @luancaarvalho https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1636638536256300 If you

[GitHub] [airflow] potiuk closed issue #19688: Airflow does not load default connections

2021-11-18 Thread GitBox
potiuk closed issue #19688: URL: https://github.com/apache/airflow/issues/19688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #19693: Fix failures with recent moto library 2.2.15

2021-11-18 Thread GitBox
potiuk commented on pull request #19693: URL: https://github.com/apache/airflow/pull/19693#issuecomment-973444690 That should fix `main` failures with the most recent moto library (for example here: https://github.com/apache/airflow/runs/4256547245?check_suite_focus=true#step:6:12964

[GitHub] [airflow] potiuk opened a new pull request #19693: Fix failures with recent moto library 2.2.15

2021-11-18 Thread GitBox
potiuk opened a new pull request #19693: URL: https://github.com/apache/airflow/pull/19693 The recent moto library is more picky about parameters passed to it: * when you are sending too old logs they are rejected * when you are passing cloud formation template they are parsed

[airflow] branch main updated: Add FAB base class and set import_name explicitly. (#19667)

2021-11-18 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 84ea55b Add FAB base class and set import_name

[GitHub] [airflow] jhtimmins merged pull request #19667: Add FAB base class and set import_name explicitly.

2021-11-18 Thread GitBox
jhtimmins merged pull request #19667: URL: https://github.com/apache/airflow/pull/19667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (2976070 -> 952ef90)

2021-11-18 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 2976070 Chart: Remove unnecessary pod_template_file defaults (#19690) add 952ef90 Support

[GitHub] [airflow] mik-laj merged pull request #19518: Support impersonation_chain parameter in the GKEStartPodOperator

2021-11-18 Thread GitBox
mik-laj merged pull request #19518: URL: https://github.com/apache/airflow/pull/19518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] dstandish commented on issue #19688: Airflow does not load default connections

2021-11-18 Thread GitBox
dstandish commented on issue #19688: URL: https://github.com/apache/airflow/issues/19688#issuecomment-973358312 @kaxil @ephraimbuddy @jedcunningham if i remember correctly, `airflow db upgrade` does not load connections. so i think that's what's going on here. the

[GitHub] [airflow] dstandish commented on issue #19688: Airflow does not load default connections

2021-11-18 Thread GitBox
dstandish commented on issue #19688: URL: https://github.com/apache/airflow/issues/19688#issuecomment-973309647 @luancaarvalho can you document how you set `AIRFLOW__CORE__LOAD_DEFAULT_CONNECTIONS`? thanks -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] dstandish commented on a change in pull request #19662: BaseOperator.on_kill should optionally accept airflow context

2021-11-18 Thread GitBox
dstandish commented on a change in pull request #19662: URL: https://github.com/apache/airflow/pull/19662#discussion_r752655282 ## File path: airflow/models/baseoperator.py ## @@ -1000,7 +1000,7 @@ def post_execute(self, context: Any, result: Any = None): if

[GitHub] [airflow] andormarkus commented on issue #13824: Cloudwatch Integration: SIGTERM/SIGKILL Sent Following DAG Completion, Causing Errors in Worker Logs

2021-11-18 Thread GitBox
andormarkus commented on issue #13824: URL: https://github.com/apache/airflow/issues/13824#issuecomment-973286690 Hi @ephraimbuddy I have tested it with Airflow 2.2.2 and the problem is still existing. Example logs 1: ```shell 2021-11-18 21:19:01,060: INFO/MainProcess]

[GitHub] [airflow] seancaulfield commented on issue #18989: CeleryKubernetesExecutor does not shutdown gracefully in 2.2.0

2021-11-18 Thread GitBox
seancaulfield commented on issue #18989: URL: https://github.com/apache/airflow/issues/18989#issuecomment-973280537 We also have this issue, but with the `KubernetesExecutor`. Airflow version is 2.1.4. Seems to happen whenever the scheduler is being restarted by the deployment.

[GitHub] [airflow] jedcunningham closed pull request #19691: Better ``pod_template_file`` examples

2021-11-18 Thread GitBox
jedcunningham closed pull request #19691: URL: https://github.com/apache/airflow/pull/19691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on a change in pull request #19686: Disclaimer in Kubernetes executor pod template example

2021-11-18 Thread GitBox
jedcunningham commented on a change in pull request #19686: URL: https://github.com/apache/airflow/pull/19686#discussion_r752620097 ## File path: docs/apache-airflow/executor/kubernetes.rst ## @@ -91,6 +91,14 @@ Example pod templates With these requirements in mind, here

[GitHub] [airflow] eduartua commented on issue #13494: Unable to view StackDriver logs in Web UI

2021-11-18 Thread GitBox
eduartua commented on issue #13494: URL: https://github.com/apache/airflow/issues/13494#issuecomment-973251448 @mcgin Could you tell me if you ever go this working? I'm having the same issue. Airflow config ``` Apache Airflow version| 2.2.2 executor

[GitHub] [airflow] jedcunningham commented on pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
jedcunningham commented on pull request #19689: URL: https://github.com/apache/airflow/pull/19689#issuecomment-973242274 This should probably be added after #18249 is merged so we have one less deprecation to deal with. -- This is an automated message from the Apache Git Service. To

[airflow] branch main updated (853c164 -> 2976070)

2021-11-18 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 853c164 Clean-up of google cloud example dags - batch 3 (#19664) add 2976070 Chart: Remove unnecessary

[GitHub] [airflow] jedcunningham merged pull request #19690: Chart: Remove unnecessary pod_template_file defaults

2021-11-18 Thread GitBox
jedcunningham merged pull request #19690: URL: https://github.com/apache/airflow/pull/19690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #19691: Better ``pod_template_file`` examples

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #19691: URL: https://github.com/apache/airflow/pull/19691#issuecomment-973215711 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on pull request #15947: Applied permissions to self._error_file

2021-11-18 Thread GitBox
potiuk commented on pull request #15947: URL: https://github.com/apache/airflow/pull/15947#issuecomment-973213856 @kacpwoja - maybe you can add PR to fix it (unless someone explains why it WOULD work of course) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk commented on pull request #15947: Applied permissions to self._error_file

2021-11-18 Thread GitBox
potiuk commented on pull request #15947: URL: https://github.com/apache/airflow/pull/15947#issuecomment-973213231 It does look suspiciously wrong here. I think it will only work is airflow is run as root -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] zevaverbach commented on issue #18578: Allow to set execution_timeout default value in airflow.cfg

2021-11-18 Thread GitBox
zevaverbach commented on issue #18578: URL: https://github.com/apache/airflow/issues/18578#issuecomment-973211876 Oh darn, to be honest I think I over-committed. Can you please unassign me? On Thu, Nov 18, 2021 at 6:53 PM eladkal ***@***.***> wrote: > @zevaverbach

[GitHub] [airflow] jedcunningham opened a new pull request #19691: Better ``pod_template_file`` examples

2021-11-18 Thread GitBox
jedcunningham opened a new pull request #19691: URL: https://github.com/apache/airflow/pull/19691 Removes extra noise and actually mounts ``airflow.cfg``. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[airflow] branch main updated (bd109b4 -> 853c164)

2021-11-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from bd109b4 Fix: Do not render undefined graph edges (#19684) add 853c164 Clean-up of google cloud example dags -

[GitHub] [airflow] potiuk merged pull request #19664: Clean-up of google cloud example dags - batch 3

2021-11-18 Thread GitBox
potiuk merged pull request #19664: URL: https://github.com/apache/airflow/pull/19664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #19592: Cast macro datetime string inputs explicitly

2021-11-18 Thread GitBox
potiuk commented on pull request #19592: URL: https://github.com/apache/airflow/pull/19592#issuecomment-973201742 I'd feel safer if it is rebased again after the fix from Ash :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on issue #19217: Airflow Config connection URI generation from backend/vault similar to Connection done in amazon provider 2.3.0

2021-11-18 Thread GitBox
potiuk commented on issue #19217: URL: https://github.com/apache/airflow/issues/19217#issuecomment-973200468 As pointed out above: > This is already possibly via _CMD and _SECRET env variable. See https://airflow.apache.org/docs/apache-airflow/stable/howto/set-config.html

[GitHub] [airflow] potiuk commented on issue #13942: Bash Operator can't run custom bash commands

2021-11-18 Thread GitBox
potiuk commented on issue #13942: URL: https://github.com/apache/airflow/issues/13942#issuecomment-973198779 Oh yeah. It is :exploding_head: especially that for example MacOS has their own rules on which ones are loaded when as well. -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk commented on a change in pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19689: URL: https://github.com/apache/airflow/pull/19689#discussion_r752565596 ## File path: chart/values.schema.json ## @@ -2856,6 +2856,11 @@ "type": "array", "default": []

[GitHub] [airflow] potiuk commented on a change in pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19689: URL: https://github.com/apache/airflow/pull/19689#discussion_r752565596 ## File path: chart/values.schema.json ## @@ -2856,6 +2856,11 @@ "type": "array", "default": []

[GitHub] [airflow] potiuk commented on a change in pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19689: URL: https://github.com/apache/airflow/pull/19689#discussion_r752564631 ## File path: chart/values.schema.json ## @@ -2856,6 +2856,11 @@ "type": "array", "default": []

[GitHub] [airflow] tomasgatial commented on a change in pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
tomasgatial commented on a change in pull request #19689: URL: https://github.com/apache/airflow/pull/19689#discussion_r752560842 ## File path: chart/values.schema.json ## @@ -2856,6 +2856,11 @@ "type": "array", "default": []

[GitHub] [airflow] tomasgatial commented on a change in pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
tomasgatial commented on a change in pull request #19689: URL: https://github.com/apache/airflow/pull/19689#discussion_r752560842 ## File path: chart/values.schema.json ## @@ -2856,6 +2856,11 @@ "type": "array", "default": []

[GitHub] [airflow] tomasgatial commented on a change in pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
tomasgatial commented on a change in pull request #19689: URL: https://github.com/apache/airflow/pull/19689#discussion_r752560842 ## File path: chart/values.schema.json ## @@ -2856,6 +2856,11 @@ "type": "array", "default": []

[GitHub] [airflow] potiuk commented on a change in pull request #19662: BaseOperator.on_kill should optionally accept airflow context

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19662: URL: https://github.com/apache/airflow/pull/19662#discussion_r752556309 ## File path: airflow/models/baseoperator.py ## @@ -1000,7 +1000,7 @@ def post_execute(self, context: Any, result: Any = None): if

[GitHub] [airflow] potiuk commented on a change in pull request #19662: BaseOperator.on_kill should optionally accept airflow context

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19662: URL: https://github.com/apache/airflow/pull/19662#discussion_r752556309 ## File path: airflow/models/baseoperator.py ## @@ -1000,7 +1000,7 @@ def post_execute(self, context: Any, result: Any = None): if

[GitHub] [airflow] potiuk commented on a change in pull request #19662: BaseOperator.on_kill should optionally accept airflow context

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19662: URL: https://github.com/apache/airflow/pull/19662#discussion_r752556309 ## File path: airflow/models/baseoperator.py ## @@ -1000,7 +1000,7 @@ def post_execute(self, context: Any, result: Any = None): if

[GitHub] [airflow] brosenkrantz commented on issue #17507: Task processes killed with WARNING - Recorded pid does not match the current pid

2021-11-18 Thread GitBox
brosenkrantz commented on issue #17507: URL: https://github.com/apache/airflow/issues/17507#issuecomment-973177410 I found that I change aiflow.cfg **default_impersonation = myuser**. When I set it back to default **default_impersonation=** this issue is resolved for me in Airflow

[GitHub] [airflow] potiuk commented on pull request #19637: Trigger DAG re-serialization after upgrade

2021-11-18 Thread GitBox
potiuk commented on pull request #19637: URL: https://github.com/apache/airflow/pull/19637#issuecomment-973176367 > Collin works with us :) We were both debugging the same issue after 2.2.0 -- but that's what I think that is it just one isolated issue in 2 years that happened with 2.2.0.

[GitHub] [airflow] dstandish commented on a change in pull request #19662: BaseOperator.on_kill should optionally accept airflow context

2021-11-18 Thread GitBox
dstandish commented on a change in pull request #19662: URL: https://github.com/apache/airflow/pull/19662#discussion_r752549672 ## File path: airflow/models/baseoperator.py ## @@ -1000,7 +1000,7 @@ def post_execute(self, context: Any, result: Any = None): if

[GitHub] [airflow] github-actions[bot] commented on pull request #19690: Chart: Remove unnecessary pod_template_file defaults

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #19690: URL: https://github.com/apache/airflow/pull/19690#issuecomment-973173155 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] collinmcnulty edited a comment on pull request #19637: Trigger DAG re-serialization after upgrade

2021-11-18 Thread GitBox
collinmcnulty edited a comment on pull request #19637: URL: https://github.com/apache/airflow/pull/19637#issuecomment-973172102 I unfortunately do not have logs. I have encountered three kinds of scenarios where clearing the serialized dag representations was required, but the latter two

[GitHub] [airflow] collinmcnulty commented on pull request #19637: Trigger DAG re-serialization after upgrade

2021-11-18 Thread GitBox
collinmcnulty commented on pull request #19637: URL: https://github.com/apache/airflow/pull/19637#issuecomment-973172102 I unfortunately do not have logs. I have encountered three kinds of scenarios where clearing the serialized dag representations was required, but the latter two seem to

[GitHub] [airflow] jedcunningham opened a new pull request #19690: Chart: Remove unnecessary pod_template_file defaults

2021-11-18 Thread GitBox
jedcunningham opened a new pull request #19690: URL: https://github.com/apache/airflow/pull/19690 We don't need to set these in `pod_template_file`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on a change in pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19689: URL: https://github.com/apache/airflow/pull/19689#discussion_r752542302 ## File path: chart/values.schema.json ## @@ -2856,6 +2856,11 @@ "type": "array", "default": []

[GitHub] [airflow] potiuk commented on a change in pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19689: URL: https://github.com/apache/airflow/pull/19689#discussion_r752542302 ## File path: chart/values.schema.json ## @@ -2856,6 +2856,11 @@ "type": "array", "default": []

[GitHub] [airflow] kaxil edited a comment on pull request #19637: Trigger DAG re-serialization after upgrade

2021-11-18 Thread GitBox
kaxil edited a comment on pull request #19637: URL: https://github.com/apache/airflow/pull/19637#issuecomment-973165667 > > Can you give some examples of this please except for the 2.2.0 issue where just reserializing would have helped > > Yep. It all started with this: #19519 for

[GitHub] [airflow] kaxil commented on pull request #19637: Trigger DAG re-serialization after upgrade

2021-11-18 Thread GitBox
kaxil commented on pull request #19637: URL: https://github.com/apache/airflow/pull/19637#issuecomment-973165667 > > Can you give some examples of this please except for the 2.2.0 issue where just reserializing would have helped > > Yep. It all started with this: #19519 for example.

[GitHub] [airflow] davidavdav commented on a change in pull request #19683: In DAG dependency detector, use class type instead of class name, related #19582

2021-11-18 Thread GitBox
davidavdav commented on a change in pull request #19683: URL: https://github.com/apache/airflow/pull/19683#discussion_r752533080 ## File path: airflow/serialization/serialized_objects.py ## @@ -444,14 +446,14 @@ class DependencyDetector: @staticmethod def

[GitHub] [airflow] o-nikolas commented on issue #15279: Error on logging empty line to Cloudwatch

2021-11-18 Thread GitBox
o-nikolas commented on issue #15279: URL: https://github.com/apache/airflow/issues/15279#issuecomment-973159337 I cut [an issue](https://github.com/kislyuk/watchtower/issues/154) to the watchtower repo (since the other was closed) with some possible fixes I had tested. But it seems like

[GitHub] [airflow] tomasgatial commented on issue #19681: Can't launch Redis container on a cluster enforcing MustRunAsNonRoot policy

2021-11-18 Thread GitBox
tomasgatial commented on issue #19681: URL: https://github.com/apache/airflow/issues/19681#issuecomment-973158960 Sure, here comes. @potiuk thanks for encouragement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
boring-cyborg[bot] commented on pull request #19689: URL: https://github.com/apache/airflow/pull/19689#issuecomment-973157587 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] tomasgatial opened a new pull request #19689: add redis runAsUser option (#19681)

2021-11-18 Thread GitBox
tomasgatial opened a new pull request #19689: URL: https://github.com/apache/airflow/pull/19689 closes: #19681 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] luancaarvalho commented on issue #19688: Airflow does not load default connections

2021-11-18 Thread GitBox
luancaarvalho commented on issue #19688: URL: https://github.com/apache/airflow/issues/19688#issuecomment-973147184 Tagging you guys. @kaxil @dstandish -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] luancaarvalho opened a new issue #19688: Airflow does not load default connections

2021-11-18 Thread GitBox
luancaarvalho opened a new issue #19688: URL: https://github.com/apache/airflow/issues/19688 ### Apache Airflow version 2.2.1 ### Operating System linux ### Versions of Apache Airflow Providers _No response_ ### Deployment Official Apache

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19688: Airflow does not load default connections

2021-11-18 Thread GitBox
boring-cyborg[bot] commented on issue #19688: URL: https://github.com/apache/airflow/issues/19688#issuecomment-973146163 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on a change in pull request #19686: Disclaimer in Kubernetes executor pod template example

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19686: URL: https://github.com/apache/airflow/pull/19686#discussion_r752508035 ## File path: docs/apache-airflow/executor/kubernetes.rst ## @@ -91,6 +91,14 @@ Example pod templates With these requirements in mind, here are some

[GitHub] [airflow] potiuk commented on a change in pull request #19686: Disclaimer in Kubernetes executor pod template example

2021-11-18 Thread GitBox
potiuk commented on a change in pull request #19686: URL: https://github.com/apache/airflow/pull/19686#discussion_r752508035 ## File path: docs/apache-airflow/executor/kubernetes.rst ## @@ -91,6 +91,14 @@ Example pod templates With these requirements in mind, here are some

[GitHub] [airflow] potiuk edited a comment on pull request #19637: Trigger DAG re-serialization after upgrade

2021-11-18 Thread GitBox
potiuk edited a comment on pull request #19637: URL: https://github.com/apache/airflow/pull/19637#issuecomment-973129528 > Can you give some examples of this please except for the 2.2.0 issue where just reserializing would have helped Yep. It all started with this:

[GitHub] [airflow] potiuk commented on pull request #19637: Trigger DAG re-serialization after upgrade

2021-11-18 Thread GitBox
potiuk commented on pull request #19637: URL: https://github.com/apache/airflow/pull/19637#issuecomment-973129528 > Can you give some examples of this please except for the 2.2.0 issue where just reserializing would have helped Yep. It all started with this:

[GitHub] [airflow] jedcunningham commented on a change in pull request #19686: Disclaimer in Kubernetes executor pod template example

2021-11-18 Thread GitBox
jedcunningham commented on a change in pull request #19686: URL: https://github.com/apache/airflow/pull/19686#discussion_r752499335 ## File path: docs/apache-airflow/executor/kubernetes.rst ## @@ -91,6 +91,14 @@ Example pod templates With these requirements in mind, here

[GitHub] [airflow] dstandish commented on pull request #19530: Do not require all extras for SalesforceHook

2021-11-18 Thread GitBox
dstandish commented on pull request #19530: URL: https://github.com/apache/airflow/pull/19530#issuecomment-973116793 I totally feel your pain. I do not like the decision. My very uninformed guess is that more often than not creds are not managed in UI and I would prefer if we never

[GitHub] [airflow] github-actions[bot] commented on pull request #19686: Disclaimer in Kubernetes executor pod template example

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #19686: URL: https://github.com/apache/airflow/pull/19686#issuecomment-973115053 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

  1   2   3   4   >