[GitHub] [airflow] ulsc commented on a change in pull request #22179: Support Uploading Bigger Files to Google Drive

2022-03-12 Thread GitBox
ulsc commented on a change in pull request #22179: URL: https://github.com/apache/airflow/pull/22179#discussion_r825408162 ## File path: airflow/providers/google/suite/hooks/drive.py ## @@ -180,12 +180,25 @@ def get_file_id(self, folder_id: str, file_name: str, drive_id:

[GitHub] [airflow] uranusjr commented on issue #22141: Dump configurations in airflow scheduler logs based on the config it reads

2022-03-12 Thread GitBox
uranusjr commented on issue #22141: URL: https://github.com/apache/airflow/issues/22141#issuecomment-1066047007 Just dump everything to the log file when the scheduler launches, then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] harishkrao commented on a change in pull request #22104: Issue 20453 - Fixes the test_http and test_sheets assert calls only

2022-03-12 Thread GitBox
harishkrao commented on a change in pull request #22104: URL: https://github.com/apache/airflow/pull/22104#discussion_r825407008 ## File path: tests/providers/google/suite/operators/test_sheets.py ## @@ -39,12 +39,9 @@ def test_execute(self, mock_xcom, mock_hook): op

[GitHub] [airflow] harishkrao commented on a change in pull request #22104: Issue 20453 - Fixes the test_http and test_sheets assert calls only

2022-03-12 Thread GitBox
harishkrao commented on a change in pull request #22104: URL: https://github.com/apache/airflow/pull/22104#discussion_r825394693 ## File path: tests/providers/google/suite/operators/test_sheets.py ## @@ -39,12 +39,9 @@ def test_execute(self, mock_xcom, mock_hook): op

[GitHub] [airflow] andyfcx commented on issue #22152: render_template_as_native_obj=True in DAG constructor prevents failure e-mail from sending

2022-03-12 Thread GitBox
andyfcx commented on issue #22152: URL: https://github.com/apache/airflow/issues/22152#issuecomment-1066045310 I think `return "".join((str(n) for n in nodes) ` might not work due to possible returning as generator string representations -- This is an automated message from the Apache

[GitHub] [airflow] andyfcx commented on a change in pull request #22218: Do not use native obj Jinja2 env to render error emails

2022-03-12 Thread GitBox
andyfcx commented on a change in pull request #22218: URL: https://github.com/apache/airflow/pull/22218#discussion_r825405925 ## File path: airflow/models/dag.py ## @@ -1278,7 +1278,10 @@ def get_template_env(self) -> jinja2.Environment:

[GitHub] [airflow] uranusjr commented on a change in pull request #22179: Support Uploading Bigger Files to Google Drive

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22179: URL: https://github.com/apache/airflow/pull/22179#discussion_r825405904 ## File path: airflow/providers/google/suite/hooks/drive.py ## @@ -180,12 +180,25 @@ def get_file_id(self, folder_id: str, file_name: str, drive_id:

[GitHub] [airflow] uranusjr commented on a change in pull request #22218: Do not use native obj Jinja2 env to render error emails

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22218: URL: https://github.com/apache/airflow/pull/22218#discussion_r825405206 ## File path: airflow/models/dag.py ## @@ -1278,7 +1278,10 @@ def get_template_env(self) -> jinja2.Environment:

[GitHub] [airflow] uranusjr commented on a change in pull request #22218: Do not use native obj Jinja2 env to render error emails

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22218: URL: https://github.com/apache/airflow/pull/22218#discussion_r825405109 ## File path: airflow/models/abstractoperator.py ## @@ -115,7 +115,7 @@ def get_template_env(self) -> "jinja2.Environment": dag =

[GitHub] [airflow] uranusjr commented on a change in pull request #22218: Do not use native obj Jinja2 env to render error emails

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22218: URL: https://github.com/apache/airflow/pull/22218#discussion_r825404401 ## File path: airflow/models/abstractoperator.py ## @@ -115,7 +115,7 @@ def get_template_env(self) -> "jinja2.Environment": dag =

[GitHub] [airflow] uranusjr edited a comment on pull request #22218: Do not use native obj Jinja2 env to render error emails

2022-03-12 Thread GitBox
uranusjr edited a comment on pull request #22218: URL: https://github.com/apache/airflow/pull/22218#issuecomment-1066043308 (Some context for this) I’m helping @andyfcx to work out a solution to #22152. The main problem with #22152 is that, when you set

[GitHub] [airflow] uranusjr commented on pull request #22218: Do not use native obj Jinja2 env to render error emails

2022-03-12 Thread GitBox
uranusjr commented on pull request #22218: URL: https://github.com/apache/airflow/pull/22218#issuecomment-1066043308 (Some context for this) I’m helping @andyfcx to work out a solution to #22152. The main problem with #22152 is that, when you set `render_template_as_native_obj` on

[airflow] branch main updated (4e70aeb -> 42a891d)

2022-03-12 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4e70aeb Fix typo in mongo.rst (#22211) add 42a891d Update ``GKEDeleteClusterOperator`,

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22212: Update ``GKEDeleteClusterOperator`, ``GKECreateClusterOperator`` docstrings

2022-03-12 Thread GitBox
boring-cyborg[bot] commented on pull request #22212: URL: https://github.com/apache/airflow/pull/22212#issuecomment-1066043182 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] eladkal merged pull request #22212: Update ``GKEDeleteClusterOperator`, ``GKECreateClusterOperator`` docstrings

2022-03-12 Thread GitBox
eladkal merged pull request #22212: URL: https://github.com/apache/airflow/pull/22212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] andyfcx commented on a change in pull request #22218: Do not use native obj Jinja2 env to render error emails

2022-03-12 Thread GitBox
andyfcx commented on a change in pull request #22218: URL: https://github.com/apache/airflow/pull/22218#discussion_r825399819 ## File path: airflow/models/abstractoperator.py ## @@ -115,7 +115,7 @@ def get_template_env(self) -> "jinja2.Environment": dag =

[GitHub] [airflow] uranusjr commented on a change in pull request #22218: Do not use native obj Jinja2 env to render error emails

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22218: URL: https://github.com/apache/airflow/pull/22218#discussion_r825399731 ## File path: airflow/models/abstractoperator.py ## @@ -115,7 +115,7 @@ def get_template_env(self) -> "jinja2.Environment": dag =

[GitHub] [airflow] uranusjr commented on a change in pull request #22217: added docs about detailed network and constraints information

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22217: URL: https://github.com/apache/airflow/pull/22217#discussion_r825399461 ## File path: airflow/providers/docker/operators/docker_swarm.py ## @@ -86,8 +86,16 @@ class DockerSwarmOperator(DockerOperator): :param mode:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22218: Fix 22152

2022-03-12 Thread GitBox
boring-cyborg[bot] commented on pull request #22218: URL: https://github.com/apache/airflow/pull/22218#issuecomment-1066042236 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] andyfcx opened a new pull request #22218: Fix 22152

2022-03-12 Thread GitBox
andyfcx opened a new pull request #22218: URL: https://github.com/apache/airflow/pull/22218 https://github.com/apache/airflow/issues/22152 I added a flag **force_string** to make sure returning will be string, Testing code still in progress. Need more discussion. ---

[GitHub] [airflow] xingularity commented on issue #22072: @task decorator does not handle "templates_exts" argument correctly (files are not rendered)

2022-03-12 Thread GitBox
xingularity commented on issue #22072: URL: https://github.com/apache/airflow/issues/22072#issuecomment-1066041776 I am interested in this issue and I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] Bowrna opened a new pull request #22217: added docs about detailed network and constraints information

2022-03-12 Thread GitBox
Bowrna opened a new pull request #22217: URL: https://github.com/apache/airflow/pull/22217 related: #15974 Added more docs information about adding network and constraints in Docker swarm option. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] ulsc commented on a change in pull request #22179: Support Uploading Bigger Files to Google Drive

2022-03-12 Thread GitBox
ulsc commented on a change in pull request #22179: URL: https://github.com/apache/airflow/pull/22179#discussion_r825398098 ## File path: airflow/providers/google/suite/hooks/drive.py ## @@ -180,12 +180,25 @@ def get_file_id(self, folder_id: str, file_name: str, drive_id:

[GitHub] [airflow] github-actions[bot] commented on pull request #20757: SFTP docs add example “extras” field using ``key_file``, ``private_key`` and ``host_key``

2022-03-12 Thread GitBox
github-actions[bot] commented on pull request #20757: URL: https://github.com/apache/airflow/pull/20757#issuecomment-1066039821 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might

[GitHub] [airflow] eladkal commented on a change in pull request #20757: SFTP docs add example “extras” field using ``key_file``, ``private_key`` and ``host_key``

2022-03-12 Thread GitBox
eladkal commented on a change in pull request #20757: URL: https://github.com/apache/airflow/pull/20757#discussion_r825397763 ## File path: docs/apache-airflow-providers-sftp/connections/sftp.rst ## @@ -73,17 +73,25 @@ Extra (optional) * ``private_key`` Specify the

[GitHub] [airflow] ashb commented on a change in pull request #22200: Soften the wording in issue templates

2022-03-12 Thread GitBox
ashb commented on a change in pull request #22200: URL: https://github.com/apache/airflow/pull/22200#discussion_r825396615 ## File path: .github/ISSUE_TEMPLATE/airflow_bug_report.yml ## @@ -51,7 +51,7 @@ body: required: true - type: textarea attributes: -

[GitHub] [airflow] ashb commented on a change in pull request #22210: fix AttributeError

2022-03-12 Thread GitBox
ashb commented on a change in pull request #22210: URL: https://github.com/apache/airflow/pull/22210#discussion_r825396544 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -283,7 +283,7 @@ def _get_ti_pod_labels(context: Optional[dict] = None,

[GitHub] [airflow] uranusjr commented on issue #22078: ExternalTaskSensorLink does not respect execution_delta and execution_date_fn

2022-03-12 Thread GitBox
uranusjr commented on issue #22078: URL: https://github.com/apache/airflow/issues/22078#issuecomment-1066038666 I believe those attributes are set on the `SerializedBaseOperator` instance directly. It should be, otherwise the deserialization has a bug… -- This is an automated message

[airflow] branch scheduler-autorefresh-pause updated (41a7a74 -> d6b2726)

2022-03-12 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch scheduler-autorefresh-pause in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 41a7a74 fix test discard c4fc2a4 pause autorefresh if scheduler isn't running add

[GitHub] [airflow] uranusjr commented on pull request #22151: Pause autorefresh if scheduler isn't running

2022-03-12 Thread GitBox
uranusjr commented on pull request #22151: URL: https://github.com/apache/airflow/pull/22151#issuecomment-1066037550 I rebased the branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] harishkrao commented on a change in pull request #22104: Issue 20453 - Fixes the test_http and test_sheets assert calls only

2022-03-12 Thread GitBox
harishkrao commented on a change in pull request #22104: URL: https://github.com/apache/airflow/pull/22104#discussion_r825394693 ## File path: tests/providers/google/suite/operators/test_sheets.py ## @@ -39,12 +39,9 @@ def test_execute(self, mock_xcom, mock_hook): op

[GitHub] [airflow] github-actions[bot] commented on pull request #22163: Make code snippet appear again

2022-03-12 Thread GitBox
github-actions[bot] commented on pull request #22163: URL: https://github.com/apache/airflow/pull/22163#issuecomment-1066035122 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might

[GitHub] [airflow] uranusjr commented on a change in pull request #19702: Switch Markdown engine to markdown-it-py

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #19702: URL: https://github.com/apache/airflow/pull/19702#discussion_r825387595 ## File path: tests/www/test_utils.py ## @@ -160,7 +160,7 @@ def setUp(self): self.attr_renderer = utils.get_attr_renderer() def

[GitHub] [airflow] wutienyang commented on issue #22215: Contributing guide still refers to the branch 'master'

2022-03-12 Thread GitBox
wutienyang commented on issue #22215: URL: https://github.com/apache/airflow/issues/22215#issuecomment-1066025600 Hi, thanks for the easy issue to experience how to contribute to Airflow. I am from PyCon APAC 2022 Sprint It's my first time to give pr

[GitHub] [airflow] github-actions[bot] commented on pull request #22216: fix contributing guide image master -> main

2022-03-12 Thread GitBox
github-actions[bot] commented on pull request #22216: URL: https://github.com/apache/airflow/pull/22216#issuecomment-1066025318 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might

[GitHub] [airflow] wutienyang opened a new pull request #22216: fix contributing guide image master -> main

2022-03-12 Thread GitBox
wutienyang opened a new pull request #22216: URL: https://github.com/apache/airflow/pull/22216 Hi, I replace contributing guide image. Fork airflow/master -> Fork airflow/main --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22216: fix contributing guide image master -> main

2022-03-12 Thread GitBox
boring-cyborg[bot] commented on pull request #22216: URL: https://github.com/apache/airflow/pull/22216#issuecomment-1066025133 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] uranusjr commented on a change in pull request #22213: Issue 20453 google common cloud fixes part 1

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22213: URL: https://github.com/apache/airflow/pull/22213#discussion_r825386896 ## File path: tests/providers/google/cloud/hooks/test_dataproc.py ## @@ -474,7 +474,7 @@ def test_wait_for_job(self, mock_get_job):

[GitHub] [airflow] github-actions[bot] commented on pull request #22202: Added autodetect arg to Create External Table Operator

2022-03-12 Thread GitBox
github-actions[bot] commented on pull request #22202: URL: https://github.com/apache/airflow/pull/22202#issuecomment-1066023351 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] uranusjr commented on a change in pull request #22179: Support Uploading Bigger Files to Google Drive

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22179: URL: https://github.com/apache/airflow/pull/22179#discussion_r825385969 ## File path: airflow/providers/google/suite/hooks/drive.py ## @@ -180,12 +180,25 @@ def get_file_id(self, folder_id: str, file_name: str, drive_id:

[GitHub] [airflow] uranusjr commented on a change in pull request #22210: fix AttributeError

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22210: URL: https://github.com/apache/airflow/pull/22210#discussion_r825385828 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -283,7 +283,7 @@ def _get_ti_pod_labels(context: Optional[dict] =

[GitHub] [airflow] github-actions[bot] commented on pull request #22212: Updated Misleading Docstrings

2022-03-12 Thread GitBox
github-actions[bot] commented on pull request #22212: URL: https://github.com/apache/airflow/pull/22212#issuecomment-1066022487 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] uranusjr commented on a change in pull request #22104: Issue 20453 - Fixes the test_http and test_sheets assert calls only

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22104: URL: https://github.com/apache/airflow/pull/22104#discussion_r825385622 ## File path: tests/providers/google/suite/operators/test_sheets.py ## @@ -39,12 +39,9 @@ def test_execute(self, mock_xcom, mock_hook): op =

[GitHub] [airflow] uranusjr commented on issue #22154: Ambiguity of format for template fields in Airflow Kubernetes Operator (airflow.providers.cncf.kubernetes.operators.kubernetes_pod)

2022-03-12 Thread GitBox
uranusjr commented on issue #22154: URL: https://github.com/apache/airflow/issues/22154#issuecomment-1066021985 Done in readthedocs/sphinx-autoapi#330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] uranusjr commented on issue #22154: Ambiguity of format for template fields in Airflow Kubernetes Operator (airflow.providers.cncf.kubernetes.operators.kubernetes_pod)

2022-03-12 Thread GitBox
uranusjr commented on issue #22154: URL: https://github.com/apache/airflow/issues/22154#issuecomment-1066018811 Hmm, this is weird. The documentation is automatically generated from AutoAPI, and I have no idea why it chooses to render the tuple as a list. Perhaps we need to raise this

[GitHub] [airflow] euccas commented on issue #22174: Support log download in task log view

2022-03-12 Thread GitBox
euccas commented on issue #22174: URL: https://github.com/apache/airflow/issues/22174#issuecomment-1066018099 I think we should keep the download buttons in the modal window, those buttons are useful! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] uranusjr commented on a change in pull request #22200: Soften the wording in issue templates

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22200: URL: https://github.com/apache/airflow/pull/22200#discussion_r825381690 ## File path: .github/ISSUE_TEMPLATE/airflow_bug_report.yml ## @@ -51,7 +51,7 @@ body: required: true - type: textarea attributes: -

[GitHub] [airflow] github-actions[bot] commented on pull request #22206: Add cgroupspy to _vendor folder

2022-03-12 Thread GitBox
github-actions[bot] commented on pull request #22206: URL: https://github.com/apache/airflow/pull/22206#issuecomment-1066015412 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] uranusjr opened a new issue #22215: Contributing guide still refers to the branch 'master'

2022-03-12 Thread GitBox
uranusjr opened a new issue #22215: URL: https://github.com/apache/airflow/issues/22215 ### Describe the issue with documentation In `CONTRIBUTING.rst`, the image still says to fork `airflow/master`:

[GitHub] [airflow] uranusjr commented on pull request #22204: Add description on the vendoring process we use

2022-03-12 Thread GitBox
uranusjr commented on pull request #22204: URL: https://github.com/apache/airflow/pull/22204#issuecomment-1066013806 Some ideas from how pip does this. pip fully automates the vendoring-patching process so a new version can be pulled immediately if needed. It uses

[GitHub] [airflow] mik-laj commented on issue #22174: Support log download in task log view

2022-03-12 Thread GitBox
mik-laj commented on issue #22174: URL: https://github.com/apache/airflow/issues/22174#issuecomment-1066006844 SGTM. We should add it because it is actually more intuitive. I'm just wondering if we shouldn't delete the download buttons from the modal window. What do you think? -- This

[GitHub] [airflow] uranusjr commented on a change in pull request #22204: Add description on the vendoring process we use

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22204: URL: https://github.com/apache/airflow/pull/22204#discussion_r825371901 ## File path: airflow/_vendor/README.md ## @@ -0,0 +1,37 @@ +# Vendor package + +## What vendored packages are for + +The `airlfow._vendor` package is

[GitHub] [airflow] kazanzhy commented on pull request #22125: AWS RDS integration fixes

2022-03-12 Thread GitBox
kazanzhy commented on pull request #22125: URL: https://github.com/apache/airflow/pull/22125#issuecomment-1065989260 A new `moto` version was released recently. So I can say that operators work as expected with real AWS and `moto` as well. -- This is an automated message from the

[GitHub] [airflow] github-actions[bot] commented on issue #9610: Pod logs from KubernetesPodOperator occasionally get replaced with "Task is not able to run"

2022-03-12 Thread GitBox
github-actions[bot] commented on issue #9610: URL: https://github.com/apache/airflow/issues/9610#issuecomment-1065989000 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] closed issue #9610: Pod logs from KubernetesPodOperator occasionally get replaced with "Task is not able to run"

2022-03-12 Thread GitBox
github-actions[bot] closed issue #9610: URL: https://github.com/apache/airflow/issues/9610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (31550c8 -> 4e70aeb)

2022-03-12 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 31550c8 Update instructions of doc updates when removing providers from release (#22199) add 4e70aeb

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22211: Fix typo in mongo.rst

2022-03-12 Thread GitBox
boring-cyborg[bot] commented on pull request #22211: URL: https://github.com/apache/airflow/pull/22211#issuecomment-1065977310 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] github-actions[bot] commented on pull request #22211: Fix typo in mongo.rst

2022-03-12 Thread GitBox
github-actions[bot] commented on pull request #22211: URL: https://github.com/apache/airflow/pull/22211#issuecomment-1065977304 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might

[GitHub] [airflow] mik-laj merged pull request #22211: Fix typo in mongo.rst

2022-03-12 Thread GitBox
mik-laj merged pull request #22211: URL: https://github.com/apache/airflow/pull/22211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] sebbASF commented on issue #22197: Broken link for dbt-Cloud download

2022-03-12 Thread GitBox
sebbASF commented on issue #22197: URL: https://github.com/apache/airflow/issues/22197#issuecomment-1065966741 I extracted the links semi-manually from the main page, and then checked them all using a Whimsy tool. However of course this failed at the first hurdle. -- This is

[GitHub] [airflow] dstandish commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
dstandish commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825351993 ## File path: airflow/api_connexion/endpoints/task_instance_endpoint.py ## @@ -88,7 +79,7 @@ def get_task_instance( ) if task_instance

[GitHub] [airflow] dstandish commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
dstandish commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825351792 ## File path: airflow/dag_processing/processor.py ## @@ -412,20 +411,19 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] BasPH commented on a change in pull request #22200: Soften the wording in issue templates

2022-03-12 Thread GitBox
BasPH commented on a change in pull request #22200: URL: https://github.com/apache/airflow/pull/22200#discussion_r825347613 ## File path: .github/ISSUE_TEMPLATE/airflow_doc_issue_report.yml ## @@ -19,15 +19,15 @@ body: # yamllint enable rule:line-length - type:

[GitHub] [airflow] BasPH commented on a change in pull request #22200: Soften the wording in issue templates

2022-03-12 Thread GitBox
BasPH commented on a change in pull request #22200: URL: https://github.com/apache/airflow/pull/22200#discussion_r825347591 ## File path: .github/ISSUE_TEMPLATE/airflow_bug_report.yml ## @@ -51,7 +51,7 @@ body: required: true - type: textarea attributes: -

[GitHub] [airflow] BasPH commented on pull request #22200: Soften the wording in issue templates

2022-03-12 Thread GitBox
BasPH commented on pull request #22200: URL: https://github.com/apache/airflow/pull/22200#issuecomment-1065958204 I personally don't perceive this as strong language, but maybe a native English speaker can share their opinion here -- This is an automated message from the Apache Git

[GitHub] [airflow] hsrocks closed pull request #21863: Add Quicksight create ingestion Hook and Operator

2022-03-12 Thread GitBox
hsrocks closed pull request #21863: URL: https://github.com/apache/airflow/pull/21863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] harishkrao commented on pull request #22213: Issue 20453 google common cloud fixes part 1

2022-03-12 Thread GitBox
harishkrao commented on pull request #22213: URL: https://github.com/apache/airflow/pull/22213#issuecomment-1065948965 @potiuk @mik-laj Opened another PR for the same issue, can you please take a look when you have time? Thank you. -- This is an automated message from the Apache Git

[GitHub] [airflow] harishkrao commented on pull request #22104: Issue 20453 - Fixes the test_http and test_sheets assert calls only

2022-03-12 Thread GitBox
harishkrao commented on pull request #22104: URL: https://github.com/apache/airflow/pull/22104#issuecomment-1065948819 > @potiuk @mik-laj @kaxil if you have time, can you please review the PR? If you are busy and can suggest other reviewers, that is great too. Thank you! @potiuk Just

[GitHub] [airflow] ashb commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
ashb commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825338095 ## File path: airflow/dag_processing/processor.py ## @@ -412,20 +411,19 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] ashb commented on a change in pull request #22214: Make SlaMiss test stricter

2022-03-12 Thread GitBox
ashb commented on a change in pull request #22214: URL: https://github.com/apache/airflow/pull/22214#discussion_r825337610 ## File path: tests/dag_processing/test_processor.py ## @@ -222,15 +222,47 @@ def test_dag_file_processor_sla_miss_doesnot_raise_integrity_error(self,

[GitHub] [airflow] ashb commented on a change in pull request #22214: Make SlaMiss test stricter

2022-03-12 Thread GitBox
ashb commented on a change in pull request #22214: URL: https://github.com/apache/airflow/pull/22214#discussion_r825337571 ## File path: tests/dag_processing/test_processor.py ## @@ -222,15 +222,47 @@ def test_dag_file_processor_sla_miss_doesnot_raise_integrity_error(self,

[GitHub] [airflow] ashb commented on a change in pull request #22214: Make SlaMiss test stricter

2022-03-12 Thread GitBox
ashb commented on a change in pull request #22214: URL: https://github.com/apache/airflow/pull/22214#discussion_r825336536 ## File path: tests/dag_processing/test_processor.py ## @@ -222,15 +222,47 @@ def test_dag_file_processor_sla_miss_doesnot_raise_integrity_error(self,

[GitHub] [airflow] alexott commented on pull request #22050: Add Python 3.10 support

2022-03-12 Thread GitBox
alexott commented on pull request #22050: URL: https://github.com/apache/airflow/pull/22050#issuecomment-1065940476 I’ll look tomorrow into a new version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on pull request #22050: Add Python 3.10 support

2022-03-12 Thread GitBox
potiuk commented on pull request #22050: URL: https://github.com/apache/airflow/pull/22050#issuecomment-1065940163 BTW. @alexott @NiallEgan - I looked at 2.0.0b1 code, and it is very different from 1.0.1 - so I think even if it will be fixed in 2.0.0b1, this might mean some provider

[GitHub] [airflow] uranusjr commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825335721 ## File path: airflow/dag_processing/processor.py ## @@ -375,16 +375,15 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] uranusjr commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825335721 ## File path: airflow/dag_processing/processor.py ## @@ -375,16 +375,15 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] uranusjr commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
uranusjr commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825335661 ## File path: airflow/api_connexion/endpoints/task_instance_endpoint.py ## @@ -88,7 +79,7 @@ def get_task_instance( ) if task_instance

[GitHub] [airflow] potiuk commented on pull request #22050: Add Python 3.10 support

2022-03-12 Thread GitBox
potiuk commented on pull request #22050: URL: https://github.com/apache/airflow/pull/22050#issuecomment-1065938743 BTW. @alexott - this might be one reason why I **COULD** speed up release of the Databricks provider :P -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] dstandish commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
dstandish commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825333926 ## File path: airflow/dag_processing/processor.py ## @@ -412,20 +411,19 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] dstandish commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
dstandish commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825333926 ## File path: airflow/dag_processing/processor.py ## @@ -412,20 +411,19 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] dstandish commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
dstandish commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825333926 ## File path: airflow/dag_processing/processor.py ## @@ -412,20 +411,19 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] dstandish commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
dstandish commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825333926 ## File path: airflow/dag_processing/processor.py ## @@ -412,20 +411,19 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] alexott commented on pull request #22050: Add Python 3.10 support

2022-03-12 Thread GitBox
alexott commented on pull request #22050: URL: https://github.com/apache/airflow/pull/22050#issuecomment-1065934809 @potiuk let me raise it with the dev team... Source code is in the pypi itself right now @NiallEgan - is it possible to fix? -- This is an automated message

[GitHub] [airflow] potiuk closed pull request #22208: Fix python 3.10 support in vendored in cgroupspy

2022-03-12 Thread GitBox
potiuk closed pull request #22208: URL: https://github.com/apache/airflow/pull/22208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] plockaby commented on pull request #20147: clean up temp files correctly when using impersonation

2022-03-12 Thread GitBox
plockaby commented on pull request #20147: URL: https://github.com/apache/airflow/pull/20147#issuecomment-1065933676 I've updated my branch with the latest commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk commented on pull request #22050: Add Python 3.10 support

2022-03-12 Thread GitBox
potiuk commented on pull request #22050: URL: https://github.com/apache/airflow/pull/22050#issuecomment-1065933341 Hey @alexott - we seem to have a blocker for Python 3.10 enabling in databicks-sql-connector (one of the last few blockers): ``` self = item = ['file1',

[GitHub] [airflow] dstandish commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
dstandish commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825331979 ## File path: airflow/dag_processing/processor.py ## @@ -412,20 +411,19 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] dstandish opened a new pull request #22214: Make SlaMiss test stricter

2022-03-12 Thread GitBox
dstandish opened a new pull request #22214: URL: https://github.com/apache/airflow/pull/22214 Tests previously did not document that the SlaMiss records created are for TIs that follow completed TIs. Importantly, the TIs for which SLA misses are created may not actually exist in the DB,

[GitHub] [airflow] harishkrao opened a new pull request #22213: Issue 20453 google common cloud fixes part 1

2022-03-12 Thread GitBox
harishkrao opened a new pull request #22213: URL: https://github.com/apache/airflow/pull/22213 related: #20453 The PR is related to the Big Query and PubSub providers' unit tests. Fixed include: * Changing the tests to assert instead of having only `has_calls`. *

[GitHub] [airflow] anuragbisht12 commented on pull request #22212: Updated Misleading Docstrings

2022-03-12 Thread GitBox
anuragbisht12 commented on pull request #22212: URL: https://github.com/apache/airflow/pull/22212#issuecomment-1065930253 Hi Please merge this PR, the current docstring is misleading, I have updated it. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] anuragbisht12 opened a new pull request #22212: Updated Misleading Docstrings

2022-03-12 Thread GitBox
anuragbisht12 opened a new pull request #22212: URL: https://github.com/apache/airflow/pull/22212 updated misleading docstrings to use Kubernetes rather than Compute as this takes Kubernetes engine zone as location parameters --- **^ Add meaningful description above**

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22212: Updated Misleading Docstrings

2022-03-12 Thread GitBox
boring-cyborg[bot] commented on pull request #22212: URL: https://github.com/apache/airflow/pull/22212#issuecomment-1065929896 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] subkanthi commented on pull request #19729: Local kubernetes executor

2022-03-12 Thread GitBox
subkanthi commented on pull request #19729: URL: https://github.com/apache/airflow/pull/19729#issuecomment-1065929107 I can work on this in a week from now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22211: one and is enough

2022-03-12 Thread GitBox
boring-cyborg[bot] commented on pull request #22211: URL: https://github.com/apache/airflow/pull/22211#issuecomment-1065928696 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] likecodingloveproblems opened a new pull request #22211: one and is enough

2022-03-12 Thread GitBox
likecodingloveproblems opened a new pull request #22211: URL: https://github.com/apache/airflow/pull/22211 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] ashb commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
ashb commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825329765 ## File path: airflow/dag_processing/processor.py ## @@ -412,20 +411,19 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] ashb commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
ashb commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825329685 ## File path: airflow/api_connexion/schemas/sla_miss_schema.py ## @@ -30,7 +30,8 @@ class Meta: task_id = auto_field(dump_only=True) dag_id =

[GitHub] [airflow] dstandish commented on a change in pull request #22184: WIP - Add run_id and map_index to SlaMiss

2022-03-12 Thread GitBox
dstandish commented on a change in pull request #22184: URL: https://github.com/apache/airflow/pull/22184#discussion_r825329142 ## File path: airflow/dag_processing/processor.py ## @@ -375,16 +375,15 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] potiuk closed pull request #22208: Fix python 3.10 support in vendored in cgroupspy

2022-03-12 Thread GitBox
potiuk closed pull request #22208: URL: https://github.com/apache/airflow/pull/22208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22210: fix AttributeError

2022-03-12 Thread GitBox
boring-cyborg[bot] commented on pull request #22210: URL: https://github.com/apache/airflow/pull/22210#issuecomment-1065918431 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

  1   2   >