[GitHub] [airflow] eladkal commented on a diff in pull request #23405: Add `OpsgenieDeleteAlertOperator`

2022-05-03 Thread GitBox
eladkal commented on code in PR #23405: URL: https://github.com/apache/airflow/pull/23405#discussion_r864457144 ## airflow/providers/opsgenie/operators/opsgenie.py: ## @@ -208,3 +208,55 @@ def execute(self, context: 'Context') -> None:

[GitHub] [airflow] github-actions[bot] commented on pull request #23463: Disallow calling expand with no arguments

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23463: URL: https://github.com/apache/airflow/pull/23463#issuecomment-1116910545 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] Bowrna commented on a diff in pull request #23445: tests command in new breeze

2022-05-03 Thread GitBox
Bowrna commented on code in PR #23445: URL: https://github.com/apache/airflow/pull/23445#discussion_r864439638 ## TESTING.rst: ## @@ -168,19 +168,19 @@ to breeze. .. code-block:: bash - ./breeze-legacy tests tests/providers/http/hooks/test_http.py

[GitHub] [airflow] pingzh commented on a diff in pull request #22917: remove stale serialized dags

2022-05-03 Thread GitBox
pingzh commented on code in PR #22917: URL: https://github.com/apache/airflow/pull/22917#discussion_r864437030 ## airflow/models/serialized_dag.py: ## @@ -220,6 +220,35 @@ def remove_dag(cls, dag_id: str, session: Session = None): """

[GitHub] [airflow] pingzh commented on a diff in pull request #22917: remove stale serialized dags

2022-05-03 Thread GitBox
pingzh commented on code in PR #22917: URL: https://github.com/apache/airflow/pull/22917#discussion_r864436993 ## tests/dag_processing/test_processor.py: ## @@ -635,6 +636,30 @@ def test_import_error_tracebacks(self, tmpdir): ) session.rollback() +

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23470: Fix conn close error on retrieving log events

2022-05-03 Thread GitBox
boring-cyborg[bot] commented on PR #23470: URL: https://github.com/apache/airflow/pull/23470#issuecomment-1116897364 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] thinhnd2104 opened a new pull request, #23470: Fix conn close error on retrieving log events

2022-05-03 Thread GitBox
thinhnd2104 opened a new pull request, #23470: URL: https://github.com/apache/airflow/pull/23470 related: [#23469] (https://github.com/apache/airflow/issues/23469). --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] josh-fell commented on a diff in pull request #23405: Add `OpsgenieDeleteAlertOperator`

2022-05-03 Thread GitBox
josh-fell commented on code in PR #23405: URL: https://github.com/apache/airflow/pull/23405#discussion_r864430454 ## airflow/providers/opsgenie/operators/opsgenie.py: ## @@ -208,3 +208,55 @@ def execute(self, context: 'Context') -> None:

[GitHub] [airflow] thinhnd2104 opened a new issue, #23469: Airflow ecs fail to fetch logs from cloudwatch

2022-05-03 Thread GitBox
thinhnd2104 opened a new issue, #23469: URL: https://github.com/apache/airflow/issues/23469 ### Apache Airflow Provider(s) amazon ### Versions of Apache Airflow Providers _No response_ ### Apache Airflow version 2.3.0 (latest released) ### Operating

[GitHub] [airflow] boring-cyborg[bot] commented on issue #23469: Airflow ecs fail to fetch logs from cloudwatch

2022-05-03 Thread GitBox
boring-cyborg[bot] commented on issue #23469: URL: https://github.com/apache/airflow/issues/23469#issuecomment-1116888401 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] josh-fell commented on a diff in pull request #23428: Update the Athena Sample DAG and Docs

2022-05-03 Thread GitBox
josh-fell commented on code in PR #23428: URL: https://github.com/apache/airflow/pull/23428#discussion_r864427781 ## docs/apache-airflow-providers-amazon/operators/athena.rst: ## @@ -16,42 +16,56 @@ under the License. -.. _howto/operator:AthenaOperator: - -Amazon

[GitHub] [airflow] josh-fell commented on a diff in pull request #23428: Update the Athena Sample DAG and Docs

2022-05-03 Thread GitBox
josh-fell commented on code in PR #23428: URL: https://github.com/apache/airflow/pull/23428#discussion_r864427978 ## docs/apache-airflow-providers-amazon/operators/athena.rst: ## @@ -16,42 +16,56 @@ under the License. -.. _howto/operator:AthenaOperator: - -Amazon

[GitHub] [airflow] josh-fell commented on a diff in pull request #23428: Update the Athena Sample DAG and Docs

2022-05-03 Thread GitBox
josh-fell commented on code in PR #23428: URL: https://github.com/apache/airflow/pull/23428#discussion_r864428831 ## airflow/providers/amazon/aws/example_dags/example_athena.py: ## @@ -82,66 +65,60 @@ def read_results_from_s3(query_execution_id): dag_id='example_athena',

[GitHub] [airflow] k1my0 commented on pull request #22965: Upgrade to support Google Ads v10

2022-05-03 Thread GitBox
k1my0 commented on PR #22965: URL: https://github.com/apache/airflow/pull/22965#issuecomment-1116882343 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] humit0 opened a new pull request, #23468: Rename cluster_policy to task_policy

2022-05-03 Thread GitBox
humit0 opened a new pull request, #23468: URL: https://github.com/apache/airflow/pull/23468 From [documentation](https://airflow.apache.org/docs/apache-airflow/stable/concepts/overview.html), there are only three policies (`dag_policy`, `task_policy`, `task_instance_mutation_hook`)

[GitHub] [airflow] github-actions[bot] commented on pull request #23448: Add sample dag and doc for S3ListPrefixesOperator

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23448: URL: https://github.com/apache/airflow/pull/23448#issuecomment-1116882284 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] github-actions[bot] commented on pull request #23449: Add sample dag and doc for S3ListOperator

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23449: URL: https://github.com/apache/airflow/pull/23449#issuecomment-1116881895 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] josh-fell commented on a diff in pull request #23449: Add sample dag and doc for S3ListOperator

2022-05-03 Thread GitBox
josh-fell commented on code in PR #23449: URL: https://github.com/apache/airflow/pull/23449#discussion_r864426483 ## docs/apache-airflow-providers-amazon/operators/s3.rst: ## @@ -196,6 +196,21 @@ To create a new (or replace) Amazon S3 object you can use :start-after:

[GitHub] [airflow] juhonkang opened a new issue, #23465: airflow webserver fail to start

2022-05-03 Thread GitBox
juhonkang opened a new issue, #23465: URL: https://github.com/apache/airflow/issues/23465 ### Apache Airflow version 2.3.0 (latest released) ### What happened ERROR: The `secret_key` setting under the webserver config has an insecure value - Airflow has failed safe and

[GitHub] [airflow] boring-cyborg[bot] commented on issue #23465: airflow webserver fail to start

2022-05-03 Thread GitBox
boring-cyborg[bot] commented on issue #23465: URL: https://github.com/apache/airflow/issues/23465#issuecomment-1116850149 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] uranusjr commented on a diff in pull request #23301: Fix: Exception when parsing log #20966

2022-05-03 Thread GitBox
uranusjr commented on code in PR #23301: URL: https://github.com/apache/airflow/pull/23301#discussion_r864382377 ## tests/hooks/test_subprocess.py: ## @@ -96,3 +96,9 @@ def test_should_exec_subprocess(self, mock_popen, mock_temporary_directory): stderr=STDOUT,

[GitHub] [airflow] uranusjr commented on a diff in pull request #23301: Fix: Exception when parsing log #20966

2022-05-03 Thread GitBox
uranusjr commented on code in PR #23301: URL: https://github.com/apache/airflow/pull/23301#discussion_r864380307 ## tests/hooks/test_subprocess.py: ## @@ -96,3 +96,9 @@ def test_should_exec_subprocess(self, mock_popen, mock_temporary_directory): stderr=STDOUT,

[GitHub] [airflow] github-actions[bot] commented on pull request #23036: Add missing container_timeout argument

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23036: URL: https://github.com/apache/airflow/pull/23036#issuecomment-1116814933 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[airflow] branch main updated: Add Python 3.10 trove classifier (#23464)

2022-05-03 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 673f894078 Add Python 3.10 trove classifier

[GitHub] [airflow] kaxil merged pull request #23464: Add Python 3.10 trove classifier

2022-05-03 Thread GitBox
kaxil merged PR #23464: URL: https://github.com/apache/airflow/pull/23464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on pull request #19702: Switch Markdown engine to markdown-it-py

2022-05-03 Thread GitBox
uranusjr commented on PR #19702: URL: https://github.com/apache/airflow/pull/19702#issuecomment-1116785518 That happens semi-randomly, let me just restart it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] csm10495 commented on pull request #23286: Allow more parameters to be piped through via execute_in_subprocess

2022-05-03 Thread GitBox
csm10495 commented on PR #23286: URL: https://github.com/apache/airflow/pull/23286#issuecomment-1116773167 The nice-ness of this function is that it logs the output in sort-of realtime to the logger. If you just call `subprocess.run` you'd need to instrument that yourself. -- This is an

[GitHub] [airflow] uranusjr commented on pull request #23286: Allow more parameters to be piped through via execute_in_subprocess

2022-05-03 Thread GitBox
uranusjr commented on PR #23286: URL: https://github.com/apache/airflow/pull/23286#issuecomment-1116764756 Why do you need to call that function in the first place? These days it’s way easier to just use `subprocess.run`. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] csm10495 commented on pull request #23286: Allow more parameters to be piped through via execute_in_subprocess

2022-05-03 Thread GitBox
csm10495 commented on PR #23286: URL: https://github.com/apache/airflow/pull/23286#issuecomment-1116763554 @potiuk any chance you could take a look at this change? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] github-actions[bot] commented on pull request #23464: Add Python 3.10 trove classifier

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23464: URL: https://github.com/apache/airflow/pull/23464#issuecomment-1116759965 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] uranusjr commented on pull request #22754: Fix secrets rendered in UI when task is not executed.

2022-05-03 Thread GitBox
uranusjr commented on PR #22754: URL: https://github.com/apache/airflow/pull/22754#issuecomment-1116759560 Still doesn’t like the approach of this, but I guess it’s worthwhile having this in 2.3.1 instead of nothing. Can someone open a follow-up issue to do this the “right way”

[GitHub] [airflow] jedcunningham opened a new pull request, #23464: Add Python 3.10 trove classifier

2022-05-03 Thread GitBox
jedcunningham opened a new pull request, #23464: URL: https://github.com/apache/airflow/pull/23464 Now that 3.10 is officially support it, let's add the trove classifier! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] github-actions[bot] commented on pull request #23394: Use DefaultAzureCredential instead of ManagedIdentityCredential in azure wasb hook

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23394: URL: https://github.com/apache/airflow/pull/23394#issuecomment-1116757011 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] uranusjr commented on issue #23400: Datetimes are not timezone aware in template variables

2022-05-03 Thread GitBox
uranusjr commented on issue #23400: URL: https://github.com/apache/airflow/issues/23400#issuecomment-1116750737 No, all the datetimes are aware of timezones, they are simply all in UTC. There is a big difference between the two. In other words, the values specify the correct points of

[GitHub] [airflow] uranusjr commented on issue #23406: Multiple DagRuns for the same day after changing the DAG schedule and re-running old tasks.

2022-05-03 Thread GitBox
uranusjr commented on issue #23406: URL: https://github.com/apache/airflow/issues/23406#issuecomment-1116742788 Removing _bug_ for now since it is less of a bug but a… quirk? The behaviour needs to be discussed in more detail. -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] uranusjr commented on issue #23406: Multiple DagRuns for the same day after changing the DAG schedule and re-running old tasks.

2022-05-03 Thread GitBox
uranusjr commented on issue #23406: URL: https://github.com/apache/airflow/issues/23406#issuecomment-1116741974 I don’t know, I can see an argument the current behaviour makes sense for certain cases though. Would it work if when you change the schedule, you also change `start_date`? --

[GitHub] [airflow] uranusjr opened a new pull request, #23463: Disallow calling expand with no arguments

2022-05-03 Thread GitBox
uranusjr opened a new pull request, #23463: URL: https://github.com/apache/airflow/pull/23463 This makes everything easier. FIx #23435. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #23444: Add cascade to `dag_tag` to `dag` foreignkey

2022-05-03 Thread GitBox
ephraimbuddy commented on code in PR #23444: URL: https://github.com/apache/airflow/pull/23444#discussion_r864311303 ## airflow/migrations/utils.py: ## @@ -35,7 +35,8 @@ def get_mssql_table_constraints(conn, table_name): FROM INFORMATION_SCHEMA.TABLE_CONSTRAINTS AS tc

[GitHub] [airflow] uranusjr commented on pull request #21796: Replaced all days_ago functions with datetime functions

2022-05-03 Thread GitBox
uranusjr commented on PR #21796: URL: https://github.com/apache/airflow/pull/21796#issuecomment-1116726918 Superceded by #23237. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr closed pull request #21796: Replaced all days_ago functions with datetime functions

2022-05-03 Thread GitBox
uranusjr closed pull request #21796: Replaced all days_ago functions with datetime functions URL: https://github.com/apache/airflow/pull/21796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] github-actions[bot] commented on pull request #23393: Move dag_processing.processor_timeouts to counters section from gauges

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23393: URL: https://github.com/apache/airflow/pull/23393#issuecomment-1116726791 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[airflow] branch main updated (5b1ab96865 -> 2d109401b3)

2022-05-03 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 5b1ab96865 Move non-opencontainer labeling of the image to breeze from Dockerfile (#23379) add 2d109401b3

[GitHub] [airflow] mik-laj merged pull request #22887: Bump pre-commit hook versions

2022-05-03 Thread GitBox
mik-laj merged PR #22887: URL: https://github.com/apache/airflow/pull/22887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] o-nikolas commented on a diff in pull request #23372: Update docs Amazon Glacier Docs

2022-05-03 Thread GitBox
o-nikolas commented on code in PR #23372: URL: https://github.com/apache/airflow/pull/23372#discussion_r864303243 ## docs/apache-airflow-providers-amazon/operators/glacier.rst: ## @@ -16,24 +16,25 @@ under the License. -Amazon Glacier Operator -===

[airflow] branch main updated: Move non-opencontainer labeling of the image to breeze from Dockerfile (#23379)

2022-05-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5b1ab96865 Move non-opencontainer labeling of the

[GitHub] [airflow] potiuk merged pull request #23379: Move non-opencontainer labeling of the image to breeze from Dockerfile

2022-05-03 Thread GitBox
potiuk merged PR #23379: URL: https://github.com/apache/airflow/pull/23379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #21046: More ArtifactsHub specific labels in docker image

2022-05-03 Thread GitBox
potiuk closed issue #21046: More ArtifactsHub specific labels in docker image URL: https://github.com/apache/airflow/issues/21046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] repl-chris opened a new pull request, #23462: Fix broken dagrun links when many runs start at the same time

2022-05-03 Thread GitBox
repl-chris opened a new pull request, #23462: URL: https://github.com/apache/airflow/pull/23462 DagRun links in the UI to `/graph` can currently be broken if you have several runs starting at (basically) the same time. The UI control that airflow uses for base_date only has per-second

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23392: 19943 Tree view status filters

2022-05-03 Thread GitBox
pierrejeambrun commented on code in PR #23392: URL: https://github.com/apache/airflow/pull/23392#discussion_r864282726 ## airflow/www/static/js/grid/api/useGridData.js: ## @@ -67,9 +64,14 @@ const useGridData = () => { }, { // only refetch if the refresh switch is on

[GitHub] [airflow] ashb commented on a diff in pull request #23461: Log info when pre upgrade checks

2022-05-03 Thread GitBox
ashb commented on code in PR #23461: URL: https://github.com/apache/airflow/pull/23461#discussion_r864274680 ## airflow/utils/db.py: ## @@ -1282,6 +1287,7 @@ def _check_migration_errors(session: Session = NEW_SESSION) -> Iterable[str]: check_bad_references, )

[GitHub] [airflow] edithturn commented on pull request #23090: Use inclusive words in apache airflow project

2022-05-03 Thread GitBox
edithturn commented on PR #23090: URL: https://github.com/apache/airflow/pull/23090#issuecomment-1116675270 I think I need to rebase :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated (ebc1f14db3 -> 451c7cbc42)

2022-05-03 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from ebc1f14db3 Unify approach for user questions asked in Breeze (#23335) add 451c7cbc42 Show warning if '/' is

[GitHub] [airflow] uranusjr merged pull request #23106: Show warning if '/' is used in a DAG run ID

2022-05-03 Thread GitBox
uranusjr merged PR #23106: URL: https://github.com/apache/airflow/pull/23106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr closed issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2022-05-03 Thread GitBox
uranusjr closed issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API URL: https://github.com/apache/airflow/issues/20063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] dstandish opened a new pull request, #23461: Log info when pre upgrade checks

2022-05-03 Thread GitBox
dstandish opened a new pull request, #23461: URL: https://github.com/apache/airflow/pull/23461 Let users know what's happening when pre-migration checks are running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] uranusjr commented on a diff in pull request #23444: Add cascade to `dag_tag` to `dag` foreignkey

2022-05-03 Thread GitBox
uranusjr commented on code in PR #23444: URL: https://github.com/apache/airflow/pull/23444#discussion_r864270954 ## airflow/migrations/utils.py: ## @@ -35,7 +35,8 @@ def get_mssql_table_constraints(conn, table_name): FROM INFORMATION_SCHEMA.TABLE_CONSTRAINTS AS tc

[GitHub] [airflow] bbovenzi commented on a diff in pull request #23392: 19943 Tree view status filters

2022-05-03 Thread GitBox
bbovenzi commented on code in PR #23392: URL: https://github.com/apache/airflow/pull/23392#discussion_r864270267 ## airflow/www/static/js/tree/Tree.jsx: ## @@ -85,7 +91,10 @@ const Tree = () => { }, [tableRef, scrollOnResize]); return ( - + + + +

[GitHub] [airflow] github-actions[bot] commented on pull request #23379: Move non-opencontainer labeling of the image to breeze from Dockerfile

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23379: URL: https://github.com/apache/airflow/pull/23379#issuecomment-1116646829 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] mik-laj commented on a diff in pull request #23379: Move non-opencontainer labeling of the image to breeze from Dockerfile

2022-05-03 Thread GitBox
mik-laj commented on code in PR #23379: URL: https://github.com/apache/airflow/pull/23379#discussion_r864256229 ## dev/breeze/src/airflow_breeze/build_image/prod/build_prod_params.py: ## @@ -202,6 +214,15 @@ def extra_docker_build_flags(self) -> List[str]:

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #23444: Add cascade to `dag_tag` to `dag` foreignkey

2022-05-03 Thread GitBox
ephraimbuddy commented on code in PR #23444: URL: https://github.com/apache/airflow/pull/23444#discussion_r864253629 ## airflow/migrations/utils.py: ## @@ -35,7 +35,8 @@ def get_mssql_table_constraints(conn, table_name): FROM INFORMATION_SCHEMA.TABLE_CONSTRAINTS AS tc

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23392: 19943 Tree view status filters

2022-05-03 Thread GitBox
pierrejeambrun commented on code in PR #23392: URL: https://github.com/apache/airflow/pull/23392#discussion_r864252329 ## airflow/www/static/js/tree/Tree.jsx: ## @@ -85,7 +91,10 @@ const Tree = () => { }, [tableRef, scrollOnResize]); return ( - + + +

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23392: 19943 Tree view status filters

2022-05-03 Thread GitBox
pierrejeambrun commented on code in PR #23392: URL: https://github.com/apache/airflow/pull/23392#discussion_r864252329 ## airflow/www/static/js/tree/Tree.jsx: ## @@ -85,7 +91,10 @@ const Tree = () => { }, [tableRef, scrollOnResize]); return ( - + + +

[GitHub] [airflow] mik-laj commented on a diff in pull request #23379: Move non-opencontainer labeling of the image to breeze from Dockerfile

2022-05-03 Thread GitBox
mik-laj commented on code in PR #23379: URL: https://github.com/apache/airflow/pull/23379#discussion_r864249358 ## dev/breeze/src/airflow_breeze/build_image/prod/build_prod_params.py: ## @@ -202,6 +214,15 @@ def extra_docker_build_flags(self) -> List[str]:

[GitHub] [airflow] potiuk commented on a diff in pull request #23379: Move non-opencontainer labeling of the image to breeze from Dockerfile

2022-05-03 Thread GitBox
potiuk commented on code in PR #23379: URL: https://github.com/apache/airflow/pull/23379#discussion_r864232278 ## dev/breeze/src/airflow_breeze/build_image/prod/build_prod_params.py: ## @@ -202,6 +214,15 @@ def extra_docker_build_flags(self) -> List[str]:

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23392: 19943 Tree view status filters

2022-05-03 Thread GitBox
pierrejeambrun commented on code in PR #23392: URL: https://github.com/apache/airflow/pull/23392#discussion_r864213111 ## airflow/www/static/js/tree/utils/useFilters.js: ## @@ -0,0 +1,82 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23392: 19943 Tree view status filters

2022-05-03 Thread GitBox
pierrejeambrun commented on code in PR #23392: URL: https://github.com/apache/airflow/pull/23392#discussion_r864223209 ## airflow/www/static/js/tree/FilterBar.jsx: ## @@ -0,0 +1,122 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [airflow] uranusjr commented on a diff in pull request #23444: Add cascade to `dag_tag` to `dag` foreignkey

2022-05-03 Thread GitBox
uranusjr commented on code in PR #23444: URL: https://github.com/apache/airflow/pull/23444#discussion_r864220700 ## airflow/migrations/utils.py: ## @@ -35,7 +35,8 @@ def get_mssql_table_constraints(conn, table_name): FROM INFORMATION_SCHEMA.TABLE_CONSTRAINTS AS tc

[GitHub] [airflow] mik-laj commented on a diff in pull request #23379: Move non-opencontainer labeling of the image to breeze from Dockerfile

2022-05-03 Thread GitBox
mik-laj commented on code in PR #23379: URL: https://github.com/apache/airflow/pull/23379#discussion_r864216008 ## dev/breeze/src/airflow_breeze/build_image/prod/build_prod_params.py: ## @@ -202,6 +214,15 @@ def extra_docker_build_flags(self) -> List[str]:

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23392: 19943 Tree view status filters

2022-05-03 Thread GitBox
pierrejeambrun commented on code in PR #23392: URL: https://github.com/apache/airflow/pull/23392#discussion_r864213111 ## airflow/www/static/js/tree/utils/useFilters.js: ## @@ -0,0 +1,82 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [airflow] bbovenzi commented on a diff in pull request #23392: 19943 Tree view status filters

2022-05-03 Thread GitBox
bbovenzi commented on code in PR #23392: URL: https://github.com/apache/airflow/pull/23392#discussion_r864208277 ## airflow/www/static/js/grid/api/useGridData.js: ## @@ -67,9 +64,14 @@ const useGridData = () => { }, { // only refetch if the refresh switch is on

[GitHub] [airflow] potiuk commented on issue #23460: Add Postgres 14 support

2022-05-03 Thread GitBox
potiuk commented on issue #23460: URL: https://github.com/apache/airflow/issues/23460#issuecomment-1116559212 Feel free! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] bbovenzi commented on a diff in pull request #23392: 19943 Tree view status filters

2022-05-03 Thread GitBox
bbovenzi commented on code in PR #23392: URL: https://github.com/apache/airflow/pull/23392#discussion_r864199233 ## airflow/www/static/js/grid/api/useGridData.js: ## @@ -17,42 +17,39 @@ * under the License. */ -/* global gridData, autoRefreshInterval */ +/* global

[airflow] branch main updated: Unify approach for user questions asked in Breeze (#23335)

2022-05-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ebc1f14db3 Unify approach for user questions asked

[GitHub] [airflow] potiuk merged pull request #23335: Unify approach for user questions asked in Breeze

2022-05-03 Thread GitBox
potiuk merged PR #23335: URL: https://github.com/apache/airflow/pull/23335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #23335: Unify approach for user questions asked in Breeze

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23335: URL: https://github.com/apache/airflow/pull/23335#issuecomment-1116554675 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[GitHub] [airflow] eskarimov commented on pull request #19736: Add Databricks Deferrable Operators

2022-05-03 Thread GitBox
eskarimov commented on PR #19736: URL: https://github.com/apache/airflow/pull/19736#issuecomment-1116538406 Rebased and resolved conflicts. How could I help to get it reviewed? I've also seen [Astoronomer's repo](https://github.com/astronomer/astronomer-providers) with plenty of

[GitHub] [airflow] gmcrocetti commented on issue #23439: DataprocJobBaseOperator not compatible with TaskGroups

2022-05-03 Thread GitBox
gmcrocetti commented on issue #23439: URL: https://github.com/apache/airflow/issues/23439#issuecomment-1116523969 I can take it o/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] jedcunningham commented on a diff in pull request #23307: Adds resultBackendSecretName warning in Helm production docs

2022-05-03 Thread GitBox
jedcunningham commented on code in PR #23307: URL: https://github.com/apache/airflow/pull/23307#discussion_r864132429 ## docs/helm-chart/production-guide.rst: ## @@ -52,6 +52,9 @@ configure the secret name: .. _production-guide:pgbouncer: +.. warning:: + If you use

[GitHub] [airflow] subkanthi commented on issue #23460: Add Postgres 14 support

2022-05-03 Thread GitBox
subkanthi commented on issue #23460: URL: https://github.com/apache/airflow/issues/23460#issuecomment-1116487029 Can I take this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] allebacco commented on issue #23447: External DAG processor not working

2022-05-03 Thread GitBox
allebacco commented on issue #23447: URL: https://github.com/apache/airflow/issues/23447#issuecomment-1116457312 @eladkal are you sure that thias issue is a duplicate? In this case I am not using `AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD`. The line mentioned in the description of the

[GitHub] [airflow] eladkal commented on issue #23112: Handle batch queries in `DbApiHook`?

2022-05-03 Thread GitBox
eladkal commented on issue #23112: URL: https://github.com/apache/airflow/issues/23112#issuecomment-1116456639 @williesb currently no one is working on this. Would you like to start a PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[airflow] branch main updated: Docs: Python 3.10 is now supported (#23457)

2022-05-03 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 04eb78bc0d Docs: Python 3.10 is now supported

[GitHub] [airflow] kaxil merged pull request #23457: Docs: Python 3.10 is now supported

2022-05-03 Thread GitBox
kaxil merged PR #23457: URL: https://github.com/apache/airflow/pull/23457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] williesb commented on issue #23112: Handle batch queries in `DbApiHook`?

2022-05-03 Thread GitBox
williesb commented on issue #23112: URL: https://github.com/apache/airflow/issues/23112#issuecomment-1116450069 What is the tentative ETA on this? I am stuck at the moment not being able to run multiple statements in a single connection/session with the TrinoHook because the run

[GitHub] [airflow] eladkal closed issue #23447: External DAG processor not working

2022-05-03 Thread GitBox
eladkal closed issue #23447: External DAG processor not working URL: https://github.com/apache/airflow/issues/23447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] eladkal commented on issue #23447: External DAG processor not working

2022-05-03 Thread GitBox
eladkal commented on issue #23447: URL: https://github.com/apache/airflow/issues/23447#issuecomment-1116449328 Duplicate of https://github.com/apache/airflow/issues/23408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[airflow] branch main updated (f61119c0f3 -> 8e3d6c30e2)

2022-05-03 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f61119c0f3 Fix `check_files.py` to work on new minor releases (#23287) add 8e3d6c30e2 Optimize 2.3.0 pre-upgrade

[GitHub] [airflow] ashb merged pull request #23458: Optimize 2.3.0 pre-upgrade check queries

2022-05-03 Thread GitBox
ashb merged PR #23458: URL: https://github.com/apache/airflow/pull/23458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham merged pull request #23287: Fix `check_files.py` to work on new minor releases

2022-05-03 Thread GitBox
jedcunningham merged PR #23287: URL: https://github.com/apache/airflow/pull/23287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Fix `check_files.py` to work on new minor releases (#23287)

2022-05-03 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f61119c0f3 Fix `check_files.py` to work on

[GitHub] [airflow] uranusjr commented on pull request #23458: Optimize 2.3.0 pre-upgrade check queries

2022-05-03 Thread GitBox
uranusjr commented on PR #23458: URL: https://github.com/apache/airflow/pull/23458#issuecomment-1116420833 I’d assume this is at least equally good from the current implementation across all databases. This basically eliminates join that does not need to happen. -- This is an automated

[GitHub] [airflow] github-actions[bot] commented on pull request #23090: Use inclusive words in apache airflow project

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23090: URL: https://github.com/apache/airflow/pull/23090#issuecomment-1116419891 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] eladkal commented on a diff in pull request #23090: Use inclusive words in apache airflow project

2022-05-03 Thread GitBox
eladkal commented on code in PR #23090: URL: https://github.com/apache/airflow/pull/23090#discussion_r864069273 ## .pre-commit-config.yaml: ## @@ -428,19 +428,38 @@ repos: - id: check-for-inclusive-language language: pygrep name: Check for language that

[GitHub] [airflow] eladkal commented on a diff in pull request #23090: Use inclusive words in apache airflow project

2022-05-03 Thread GitBox
eladkal commented on code in PR #23090: URL: https://github.com/apache/airflow/pull/23090#discussion_r864069273 ## .pre-commit-config.yaml: ## @@ -428,19 +428,38 @@ repos: - id: check-for-inclusive-language language: pygrep name: Check for language that

[GitHub] [airflow] potiuk commented on issue #23460: Add Postgres 14 support

2022-05-03 Thread GitBox
potiuk commented on issue #23460: URL: https://github.com/apache/airflow/issues/23460#issuecomment-1116415666 Would you like to make a PR to change it ? It should be rather easy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] dstandish commented on pull request #23458: Optimize 2.3.0 pre-upgrade check queries

2022-05-03 Thread GitBox
dstandish commented on PR #23458: URL: https://github.com/apache/airflow/pull/23458#issuecomment-1116413361 > What about other DBs? Do we need to only for this for postgres i think it's likely that this will be better on all DBs. we should test but it will take some time. >

[GitHub] [airflow] alexInhert opened a new issue, #23460: Add Postgres 14 support

2022-05-03 Thread GitBox
alexInhert opened a new issue, #23460: URL: https://github.com/apache/airflow/issues/23460 ### Description _No response_ ### Use case/motivation Using Postgres 14 as backend ### Related issues _No response_ ### Are you willing to submit a PR?

[GitHub] [airflow] ashb commented on pull request #23458: Optimize 2.3.0 pre-upgrade check queries

2022-05-03 Thread GitBox
ashb commented on PR #23458: URL: https://github.com/apache/airflow/pull/23458#issuecomment-1116396699 Why do we even need to do such a count query? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] github-actions[bot] commented on pull request #23458: Optimize 2.3.0 pre-upgrade check queries

2022-05-03 Thread GitBox
github-actions[bot] commented on PR #23458: URL: https://github.com/apache/airflow/pull/23458#issuecomment-1116386441 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] dstandish opened a new pull request, #23458: Optimize 2.3.0 pre-upgrade check queries

2022-05-03 Thread GitBox
dstandish opened a new pull request, #23458: URL: https://github.com/apache/airflow/pull/23458 We have to check for rows that are missing either corresponding TI or DR and move them out of table before adding FKs. We were doing correlation in the JOIN condition but it appears postgres

  1   2   3   >