Re: [I] Add a Reset Password button under Security > List Users > Edit user [airflow]

2024-04-13 Thread via GitHub
aritra24 commented on issue #37030: URL: https://github.com/apache/airflow/issues/37030#issuecomment-2053919829 I believe it might need to be added as an

Re: [I] Add a Reset Password button under Security > List Users > Edit user [airflow]

2024-04-13 Thread via GitHub
poorvirohidekar commented on issue #37030: URL: https://github.com/apache/airflow/issues/37030#issuecomment-2053915661 @aritra24 - Yup, I was checking out the same. @vincbeck - I was actually looking into this edit view implementation.

Re: [PR] Increment try_number while clearing deferred tasks. [airflow]

2024-04-13 Thread via GitHub
tirkarthi commented on code in PR #38984: URL: https://github.com/apache/airflow/pull/38984#discussion_r1564470882 ## airflow/models/taskinstance.py: ## @@ -274,6 +274,12 @@ def clear_task_instances( ti.state = TaskInstanceState.RESTARTING

Re: [PR] Adds job_id as path param in update permission [airflow]

2024-04-13 Thread via GitHub
SubhamSinghal commented on code in PR #38962: URL: https://github.com/apache/airflow/pull/38962#discussion_r1564466479 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -656,14 +655,20 @@ def get_repo_by_path(self, path: str) -> str | None: return None -

Re: [PR] Adds job_id as path param in update permission [airflow]

2024-04-13 Thread via GitHub
SubhamSinghal commented on code in PR #38962: URL: https://github.com/apache/airflow/pull/38962#discussion_r1564466479 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -656,14 +655,20 @@ def get_repo_by_path(self, path: str) -> str | None: return None -

[I] Allow passing airflow params as job parameter in databricks job [airflow]

2024-04-13 Thread via GitHub
SubhamSinghal opened a new issue, #39002: URL: https://github.com/apache/airflow/issues/39002 ### Description Currently we if we need to pass any parameter to spark job we need to hardcode parameters in json config. But we want to pass parameters dynamically through airflow. This

Re: [PR] Adds job_id as path param in update permission [airflow]

2024-04-13 Thread via GitHub
pankajkoti commented on code in PR #38962: URL: https://github.com/apache/airflow/pull/38962#discussion_r1564464458 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -656,14 +655,20 @@ def get_repo_by_path(self, path: str) -> str | None: return None -

Re: [PR] Adds job_id as path param in update permission [airflow]

2024-04-13 Thread via GitHub
pankajkoti commented on code in PR #38962: URL: https://github.com/apache/airflow/pull/38962#discussion_r1564464458 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -656,14 +655,20 @@ def get_repo_by_path(self, path: str) -> str | None: return None -

Re: [PR] Fix automatic termination issue in EmrOperator by ensuring `waiter_max_attempts` is set for deferrable triggers [airflow]

2024-04-13 Thread via GitHub
beobest2 commented on PR #38658: URL: https://github.com/apache/airflow/pull/38658#issuecomment-2053905730 @eladkal I have also added unit tests. Please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Status of testing Providers that were prepared on April 13, 2024 [airflow]

2024-04-13 Thread via GitHub
pankajkoti commented on issue #38997: URL: https://github.com/apache/airflow/issues/38997#issuecomment-2053904837 For the databricks provider, for PRs #38741 and #38918 to work well, we would need PR #38692 to be included as well cc: @SubhamSinghal @Lee-W -- This is an automated

Re: [PR] Adds job_id as path param in update permission [airflow]

2024-04-13 Thread via GitHub
Lee-W commented on code in PR #38962: URL: https://github.com/apache/airflow/pull/38962#discussion_r1564461104 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -656,14 +655,20 @@ def get_repo_by_path(self, path: str) -> str | None: return None -def

Re: [PR] Fix triggerer race condition in HA setting [airflow]

2024-04-13 Thread via GitHub
Lioscro commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1564458689 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,140 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword

Re: [PR] Adds job_id as path param in update permission [airflow]

2024-04-13 Thread via GitHub
pankajkoti commented on code in PR #38962: URL: https://github.com/apache/airflow/pull/38962#discussion_r1564457145 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -656,14 +655,20 @@ def get_repo_by_path(self, path: str) -> str | None: return None -

Re: [PR] Increment try_number while clearing deferred tasks. [airflow]

2024-04-13 Thread via GitHub
dirrao commented on code in PR #38984: URL: https://github.com/apache/airflow/pull/38984#discussion_r1564417518 ## airflow/models/taskinstance.py: ## @@ -274,6 +274,12 @@ def clear_task_instances( ti.state = TaskInstanceState.RESTARTING

Re: [PR] Remove unnecessary nginx redirect rule from reverse proxy documentation [airflow]

2024-04-13 Thread via GitHub
dirrao commented on code in PR #38953: URL: https://github.com/apache/airflow/pull/38953#discussion_r1564410001 ## docs/apache-airflow/howto/run-behind-proxy.rst: ## @@ -62,7 +62,6 @@ Your reverse proxy (ex: nginx) should be configured as follow: server_name

Re: [PR] Updated logic to allow AWS Batch Hook `get_job_description` retries to be more effective [airflow]

2024-04-13 Thread via GitHub
dirrao commented on code in PR #38998: URL: https://github.com/apache/airflow/pull/38998#discussion_r1564401980 ## airflow/providers/amazon/aws/hooks/batch_client.py: ## @@ -414,22 +418,20 @@ def get_job_description(self, job_id: str) -> dict: )

Re: [PR] Make ImapHook mail body encoding configurable [airflow]

2024-04-13 Thread via GitHub
github-actions[bot] closed pull request #37517: Make ImapHook mail body encoding configurable URL: https://github.com/apache/airflow/pull/37517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2024-04-13 Thread via GitHub
github-actions[bot] commented on PR #35800: URL: https://github.com/apache/airflow/pull/35800#issuecomment-2053813733 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

Re: [PR] Attempt to update Connexion library to version 3 [airflow]

2024-04-13 Thread via GitHub
github-actions[bot] closed pull request #36052: Attempt to update Connexion library to version 3 URL: https://github.com/apache/airflow/pull/36052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Partially enable `B028` rule: no-explicit-stacklevel [airflow]

2024-04-13 Thread via GitHub
Taragolis opened a new pull request, #39000: URL: https://github.com/apache/airflow/pull/39000 This partially resolve in https://github.com/apache/airflow/pull/36831 However I forget/do not have a time to resolve other cases and additional `warnings.warn` without

[PR] Use `model_validate` instead of `parse_obj` for de-serialize Pydantic V2 model [airflow]

2024-04-13 Thread via GitHub
Taragolis opened a new pull request, #38999: URL: https://github.com/apache/airflow/pull/38999 I've miss during https://github.com/apache/airflow/pull/38933 that we also use Pydantic V1 methods for deserialize ```console { "category":

[PR] Updated logic to allow AWS Batch Hook `get_job_description` retries to be more effective [airflow]

2024-04-13 Thread via GitHub
shahar1 opened a new pull request, #38998: URL: https://github.com/apache/airflow/pull/38998 related: #37552 (stale PR) --- **^ Add meaningful description above** Read the **[Pull Request

[PR] Add Power BI plugin GitHub link in ecosystem. [airflow-site]

2024-04-13 Thread via GitHub
ambika-garg opened a new pull request, #1006: URL: https://github.com/apache/airflow-site/pull/1006 Added the Power BI Airflow plugin repository link in ecosystem web page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[I] Status of testing Providers that were prepared on April 13, 2024 [airflow]

2024-04-13 Thread via GitHub
eladkal opened a new issue, #38997: URL: https://github.com/apache/airflow/issues/38997 ### Body I have a kind request for all the contributors to the latest provider packages release. Could you please help us to test the RC versions of the providers? The guidelines on how

[PR] Add documentation for packages - 2024-04-13 [airflow-site]

2024-04-13 Thread via GitHub
eladkal opened a new pull request, #1005: URL: https://github.com/apache/airflow-site/pull/1005 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(airflow-site) branch add-documentation-2024-04-13 created (now 25aaeff330)

2024-04-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch add-documentation-2024-04-13 in repository https://gitbox.apache.org/repos/asf/airflow-site.git at 25aaeff330 Add documentation for packages - 2024-04-13 This branch includes the

(airflow) annotated tag providers-yandex/3.10.0rc2 updated (f9dcc82fb6 -> 6fa2a5d98b)

2024-04-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to annotated tag providers-yandex/3.10.0rc2 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag providers-yandex/3.10.0rc2 was modified! *** from f9dcc82fb6 (commit)

(airflow) annotated tag providers-databricks/6.3.0rc2 updated (f9dcc82fb6 -> ce3f3885a9)

2024-04-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to annotated tag providers-databricks/6.3.0rc2 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag providers-databricks/6.3.0rc2 was modified! *** from f9dcc82fb6 (commit)

svn commit: r68478 - /dev/airflow/providers/

2024-04-13 Thread eladkal
Author: eladkal Date: Sat Apr 13 20:11:42 2024 New Revision: 68478 Log: Add artifacts for Airflow Providers 2024-04-13 Added: dev/airflow/providers/apache_airflow_providers_databricks-6.3.0-py3-none-any.whl (with props)

(airflow) branch main updated (34daebc073 -> f9dcc82fb6)

2024-04-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 34daebc073 Update providers metadata 2024-04-13 (#38994) add f9dcc82fb6 Prepare docs 1st wave (RC2) April 2024

Re: [PR] Prepare docs 1st wave (RC2) April 2024 [airflow]

2024-04-13 Thread via GitHub
eladkal merged PR #38995: URL: https://github.com/apache/airflow/pull/38995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated (67ad95ffcf -> 34daebc073)

2024-04-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 67ad95ffcf refactor: Added 2 unit test with rows as iterator instead of a list to assure it still works (#38986)

Re: [PR] Update providers metadata 2024-04-13 [airflow]

2024-04-13 Thread via GitHub
eladkal merged PR #38994: URL: https://github.com/apache/airflow/pull/38994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Update testing_packages.rst [airflow]

2024-04-13 Thread via GitHub
shahar1 opened a new pull request, #38996: URL: https://github.com/apache/airflow/pull/38996 --- **^ Add meaningful description above** Read the **[Pull Request

[PR] Prepare docs 1st wave (RC2) April 2024 [airflow]

2024-04-13 Thread via GitHub
eladkal opened a new pull request, #38995: URL: https://github.com/apache/airflow/pull/38995 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Status of testing Providers that were prepared on April 10, 2024 [airflow]

2024-04-13 Thread via GitHub
eladkal closed issue #38904: Status of testing Providers that were prepared on April 10, 2024 URL: https://github.com/apache/airflow/issues/38904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Status of testing Providers that were prepared on April 10, 2024 [airflow]

2024-04-13 Thread via GitHub
eladkal commented on issue #38904: URL: https://github.com/apache/airflow/issues/38904#issuecomment-2053723135 Thank you everyone. Providers are released. yandex and databricks providers are excluded and will followup with rc2 I invite everyone to help improve providers for the

[PR] Update providers metadata 2024-04-13 [airflow]

2024-04-13 Thread via GitHub
eladkal opened a new pull request, #38994: URL: https://github.com/apache/airflow/pull/38994 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

(airflow-site) branch add-documentation-2024-04-10 deleted (was e90c52e668)

2024-04-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch add-documentation-2024-04-10 in repository https://gitbox.apache.org/repos/asf/airflow-site.git was e90c52e668 Exclude databricks and yandex from release The revisions that were on this

Re: [PR] Add documentation for packages - 2024-04-10 [airflow-site]

2024-04-13 Thread via GitHub
eladkal merged PR #1003: URL: https://github.com/apache/airflow-site/pull/1003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

svn commit: r68477 - /dev/airflow/providers/ /release/airflow/providers/

2024-04-13 Thread eladkal
Author: eladkal Date: Sat Apr 13 18:09:08 2024 New Revision: 68477 Log: Release Airflow Providers on 2024-04-13 Added: release/airflow/providers/apache_airflow_providers_airbyte-3.7.0-py3-none-any.whl - copied unchanged from r68476,

[PR] Ensure we can serialize DatasetEventAccessor(s) properly [airflow]

2024-04-13 Thread via GitHub
dstandish opened a new pull request, #38993: URL: https://github.com/apache/airflow/pull/38993 needed for _run_raw_task -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Make _run_raw_task AIP-44 compatible [airflow]

2024-04-13 Thread via GitHub
dstandish opened a new pull request, #38992: URL: https://github.com/apache/airflow/pull/38992 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Undeprecate `BaseXCom.get_one` method [airflow]

2024-04-13 Thread via GitHub
Taragolis opened a new pull request, #38991: URL: https://github.com/apache/airflow/pull/38991 I guess `BaseXCom.get_one` is deprecated by a mistake in https://github.com/apache/airflow/pull/37058 ```console {"category": "DeprecationWarning", "message": "Call to

[I] Allow searching dag by display name [airflow]

2024-04-13 Thread via GitHub
darkag opened a new issue, #38990: URL: https://github.com/apache/airflow/issues/38990 ### Description Hello, Version 2.9 added new feature to give a display name to dags but searching in web interface is still limited to dag's ID. I think search should work on both display

[PR] Provide a UUID to trace log when RPC internal server error... WDYT? [airflow]

2024-04-13 Thread via GitHub
dstandish opened a new pull request, #38989: URL: https://github.com/apache/airflow/pull/38989 For security reasons, we don't present the user with tracebacks when there's a webserver error. If we similarly don't want to provide tracebacks in task execution logs, we could provide a UUID

Re: [I] Status of testing Providers that were prepared on April 10, 2024 [airflow]

2024-04-13 Thread via GitHub
Lee-W commented on issue #38904: URL: https://github.com/apache/airflow/issues/38904#issuecomment-2053699453 Verified #38390, https://github.com/apache/airflow/pull/38396/, https://github.com/apache/airflow/pull/38397/, https://github.com/apache/airflow/pull/38394/,

[I] Flaky docker example test around `mpi4py` builds [airflow]

2024-04-13 Thread via GitHub
Taragolis opened a new issue, #38988: URL: https://github.com/apache/airflow/issues/38988 ### Body Our test with build example docker image (https://airflow.apache.org/docs/docker-stack/build.html#example-when-you-add-packages-requiring-compilation) started failed recently with

Re: [PR] Mark `extending/add-build-essential-extend/Dockerfile` docker example test as XFAIL [airflow]

2024-04-13 Thread via GitHub
Taragolis commented on PR #38978: URL: https://github.com/apache/airflow/pull/38978#issuecomment-2053696805 Aaaand it's back 藍 - https://github.com/apache/airflow/actions/runs/8674524298/job/23787271307 - https://github.com/apache/airflow/actions/runs/8674113008/job/23786580180

Re: [PR] Fix `update-common-sql-api-stubs` pre-commit check [airflow]

2024-04-13 Thread via GitHub
Taragolis commented on PR #38915: URL: https://github.com/apache/airflow/pull/38915#issuecomment-2053695839 The problem here, that we talk about implementation about SQL, and there is no one database which implements all features from the modern SQL Standard (SQL ANSI 92 outdated decades

[PR] Fix wrong path in `providers/aws/utils/__init__.py` [airflow]

2024-04-13 Thread via GitHub
shahar1 opened a new pull request, #38987: URL: https://github.com/apache/airflow/pull/38987 --- **^ Add meaningful description above** Read the **[Pull Request

(airflow) branch main updated: refactor: Added 2 unit test with rows as iterator instead of a list to assure it still works (#38986)

2024-04-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 67ad95ffcf refactor: Added 2 unit test with rows

Re: [PR] Added unit tests for insert_rows method in DbAPiHook when rows is an iterator instead of a list [airflow]

2024-04-13 Thread via GitHub
eladkal merged PR #38986: URL: https://github.com/apache/airflow/pull/38986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow-site) branch add-documentation-2024-04-10 updated (308355acab -> e90c52e668)

2024-04-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch add-documentation-2024-04-10 in repository https://gitbox.apache.org/repos/asf/airflow-site.git from 308355acab Add documentation for packages - 2024-04-10 add e90c52e668 Exclude

Re: [PR] Fix `DbApiHook.insert_rows` when `rows` is a generator [airflow]

2024-04-13 Thread via GitHub
dabla commented on PR #38972: URL: https://github.com/apache/airflow/pull/38972#issuecomment-2053666381 As promised I created a [PR](https://github.com/apache/airflow/pull/38986) which also checks the insert_rows method when an iterator is passed as rows parameter. -- This is an

(airflow) branch main updated (7dee832963 -> 6de420a0ee)

2024-04-13 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 7dee832963 Resolve test pool unit test warnings (#38981) add 6de420a0ee Fix 'polling_interval' parameter

Re: [PR] Fix 'polling_interval' parameter docs in LivyOperator [airflow]

2024-04-13 Thread via GitHub
boring-cyborg[bot] commented on PR #38979: URL: https://github.com/apache/airflow/pull/38979#issuecomment-2053663426 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Fix 'polling_interval' parameter docs in LivyOperator [airflow]

2024-04-13 Thread via GitHub
hussein-awala merged PR #38979: URL: https://github.com/apache/airflow/pull/38979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Added unit tests for insert_rows method in DbAPiHook when rows is an iterator instead of a list [airflow]

2024-04-13 Thread via GitHub
dabla opened a new pull request, #38986: URL: https://github.com/apache/airflow/pull/38986 …o assure it still works As promised I added 2 unit tests which verify if the insert_rows method still works as expected if an iterator is passed as a rows parameter instead of

Re: [PR] Resolve test pool unit test warnings [airflow]

2024-04-13 Thread via GitHub
Taragolis merged PR #38981: URL: https://github.com/apache/airflow/pull/38981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Resolve test pool unit test warnings (#38981)

2024-04-13 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7dee832963 Resolve test pool unit test warnings

[PR] Add `inherit_cache` attribute for `CreateTableAs` custom SA Clause [airflow]

2024-04-13 Thread via GitHub
Taragolis opened a new pull request, #38985: URL: https://github.com/apache/airflow/pull/38985 We should set `cache_ok` or `inherit_cache` explicitly for custom clauses or types. See (valid for 1.4 and 2.0):

Re: [I] GlueJobOperator with local script location fails on consecutive runs [airflow]

2024-04-13 Thread via GitHub
eladkal closed issue #38959: GlueJobOperator with local script location fails on consecutive runs URL: https://github.com/apache/airflow/issues/38959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(airflow) branch main updated: Fix bug in GlueJobOperator where consecutive runs fail when a local script file is used (#38960)

2024-04-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d946d7b013 Fix bug in GlueJobOperator where

Re: [PR] Fix bug in GlueJobOperator where consecutive runs fail when a local script file is used [airflow]

2024-04-13 Thread via GitHub
boring-cyborg[bot] commented on PR #38960: URL: https://github.com/apache/airflow/pull/38960#issuecomment-2053642568 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Fix bug in GlueJobOperator where consecutive runs fail when a local script file is used [airflow]

2024-04-13 Thread via GitHub
eladkal merged PR #38960: URL: https://github.com/apache/airflow/pull/38960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch constraints-main updated: Updating constraints. Github run id:8673109637

2024-04-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 416fa49ce9 Updating

(airflow) branch main updated: Resolve internal warnings for TestLocalTaskJob and TestSigTermOnRunner (#38893)

2024-04-13 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 28bd256829 Resolve internal warnings for

Re: [PR] Resolve internal warnings for TestLocalTaskJob and TestSigTermOnRunner [airflow]

2024-04-13 Thread via GitHub
Taragolis merged PR #38893: URL: https://github.com/apache/airflow/pull/38893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Resolve internal warnings for TestLocalTaskJob and TestSigTermOnRunner [airflow]

2024-04-13 Thread via GitHub
Owen-CH-Leung commented on PR #38893: URL: https://github.com/apache/airflow/pull/38893#issuecomment-2053608069 @Taragolis Shall we merge this ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(airflow) branch improve-warning-system updated (91cae11e3d -> f81e7493ff)

2024-04-13 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch improve-warning-system in repository https://gitbox.apache.org/repos/asf/airflow.git discard 91cae11e3d Change capture warnings output format to the JSON add f81e7493ff Change capture

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-13 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1563936620 ## airflow/providers/pinecone/CHANGELOG.rst: ## @@ -20,6 +20,29 @@ Changelog - +2.0.0 +. + +Breaking changes + + +.. note:: + This

(airflow) branch improve-warning-system updated (5f96fee9be -> 91cae11e3d)

2024-04-13 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch improve-warning-system in repository https://gitbox.apache.org/repos/asf/airflow.git discard 5f96fee9be Change capture warnings output format to the JSON add 91cae11e3d Change capture

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-13 Thread via GitHub
Taragolis commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1563914685 ## airflow/providers/pinecone/CHANGELOG.rst: ## @@ -20,6 +20,29 @@ Changelog - +2.0.0 +. + +Breaking changes + + +.. note:: +

(airflow) branch improve-warning-system updated (d8fdf34e29 -> 5f96fee9be)

2024-04-13 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch improve-warning-system in repository https://gitbox.apache.org/repos/asf/airflow.git discard d8fdf34e29 Revert some accidental changes discard 8469e5db44 Update example in docs discard

Re: [PR] Adds job_id as path param in update permission [airflow]

2024-04-13 Thread via GitHub
SubhamSinghal commented on code in PR #38962: URL: https://github.com/apache/airflow/pull/38962#discussion_r1563909747 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -656,14 +655,20 @@ def get_repo_by_path(self, path: str) -> str | None: return None -

Re: [PR] Adds job_id as path param in update permission [airflow]

2024-04-13 Thread via GitHub
SubhamSinghal commented on PR #38962: URL: https://github.com/apache/airflow/pull/38962#issuecomment-2053593133 Tested. Code is working fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Mismatching dates in Run ID and Grid View [airflow]

2024-04-13 Thread via GitHub
tirkarthi commented on issue #38977: URL: https://github.com/apache/airflow/issues/38977#issuecomment-2053589599 This looks like a similar report to https://github.com/apache/airflow/issues/35946 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] clear a deferred task do not increment the tries [airflow]

2024-04-13 Thread via GitHub
tirkarthi commented on issue #38735: URL: https://github.com/apache/airflow/issues/38735#issuecomment-2053588675 I have created PR https://github.com/apache/airflow/pull/38984 . This is already handled while marking tasks as success/failure. -- This is an automated message from the

[PR] Increment try_number while clearing deferred tasks. [airflow]

2024-04-13 Thread via GitHub
tirkarthi opened a new pull request, #38984: URL: https://github.com/apache/airflow/pull/38984 closes: #38735 related: #38735 This is already done while marking tasks as success/failure. Should this be done for up_for_reschedule tasks too? See also

Re: [I] Deferrable operator tasks do not call `on_kill` method when fail or restarted [airflow]

2024-04-13 Thread via GitHub
tirkarthi commented on issue #36090: URL: https://github.com/apache/airflow/issues/36090#issuecomment-2053554297 I just found out that there is already a cleanup method as part of the interface. The problem is that cleanup is called during triggerer restarts too as part of deployment due

Re: [I] trigger_rule=TriggerRule.ALWAYS doesn't work properly with task_groups [airflow]

2024-04-13 Thread via GitHub
github-actions[bot] commented on issue #30334: URL: https://github.com/apache/airflow/issues/30334#issuecomment-2053545716 This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last

Re: [PR] Fix bug in GlueJobOperator where consecutive runs fail when a local script file is used [airflow]

2024-04-13 Thread via GitHub
moritzsanne commented on PR #38960: URL: https://github.com/apache/airflow/pull/38960#issuecomment-2053545092 Hey, thanks for reviewing this so quickly. I've rebased my branch using the rebase button in github after your reviews. I am unsure if this was the right thing today in this case.

Re: [I] Tasks are in queued state for a longer time [airflow]

2024-04-13 Thread via GitHub
paramjeet01 commented on issue #38968: URL: https://github.com/apache/airflow/issues/38968#issuecomment-2053543932 @ephraimbuddy , The above config has improved the performance in scheduling the tasks and the gantt view shows the tasks queue time is lesser than before. Also , please share