guydriesen commented on PR #39027:
URL: https://github.com/apache/airflow/pull/39027#issuecomment-2058253085
Sure, will have a look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
romanzdk commented on issue #38836:
URL: https://github.com/apache/airflow/issues/38836#issuecomment-2058231556
Hi, is the release planned, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
eladkal commented on code in PR #38524:
URL: https://github.com/apache/airflow/pull/38524#discussion_r1566709304
##
chart/values.schema.json:
##
@@ -521,7 +521,8 @@
"LocalKubernetesExecutor",
"CeleryExecutor",
eladkal commented on PR #37352:
URL: https://github.com/apache/airflow/pull/37352#issuecomment-2058227849
@csp33 are you still working on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
amoghrajesh commented on PR #39003:
URL: https://github.com/apache/airflow/pull/39003#issuecomment-2058216450
@hussein-awala @potiuk @eladkal I need some help in adding the unit tests
here. I tried, but looks like I am unable to store the results to a DB and
check it. Also, static check
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch add-documentation-2024-04-13
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
from 25aaeff330 Add documentation for packages - 2024-04-13
add fb464bde6d Exclude
amoghrajesh commented on code in PR #39003:
URL: https://github.com/apache/airflow/pull/39003#discussion_r1566688312
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -334,6 +335,8 @@ def __init__(
self.env_vars = env_vars
if pod_runtime_info_envs:
slycyberguy commented on issue #39026:
URL: https://github.com/apache/airflow/issues/39026#issuecomment-2058172279
May I handle this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
boring-cyborg[bot] commented on PR #39048:
URL: https://github.com/apache/airflow/pull/39048#issuecomment-2058077070
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our
kerlion opened a new pull request, #39048:
URL: https://github.com/apache/airflow/pull/39048
---
When I use ftp hook in my airflow env, it will wait till timeout when I use
a none-standard ftp port. I fixed it by modify the source code. It has run for
2+
sunank200 commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1566585987
##
airflow/providers/pinecone/hooks/pinecone.py:
##
@@ -135,119 +170,106 @@ def upsert(
**kwargs,
)
-@staticmethod
+def
github-actions[bot] commented on PR #37802:
URL: https://github.com/apache/airflow/pull/37802#issuecomment-2058015866
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1566550167
##
airflow/providers/pinecone/hooks/pinecone.py:
##
@@ -64,43 +69,80 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
"""Return custom field
rasulkarimov commented on PR #39031:
URL: https://github.com/apache/airflow/pull/39031#issuecomment-2057982594
@jedcunningham
"restricting it artificially" - I agree with your point, I just wanted to
follow the established pattern in the "git_sync_container" template.
However, using
hussein-awala opened a new pull request, #39047:
URL: https://github.com/apache/airflow/pull/39047
This PR updates some typing hints in the salesforce provider to support
simple-salesforce 1.12.6, which improved its internal typing hints.
This change is compatible with the older
hussein-awala merged PR #39045:
URL: https://github.com/apache/airflow/pull/39045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
husseinawala pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 74d22fd6ce limit simple-salesforce version
o-nikolas opened a new pull request, #39046:
URL: https://github.com/apache/airflow/pull/39046
If a user tags a task to run with a particular executor, then triggers a dag
run, the task instance created persists the requested executor in the DB record
for that TI. However, if the user made
jedcunningham commented on code in PR #39045:
URL: https://github.com/apache/airflow/pull/39045#discussion_r1566508703
##
airflow/providers/salesforce/provider.yaml:
##
@@ -55,7 +55,7 @@ versions:
dependencies:
- apache-airflow>=2.6.0
- - simple-salesforce>=1.0.0
+ -
hussein-awala opened a new pull request, #39045:
URL: https://github.com/apache/airflow/pull/39045
[simple-salesforce 1.12.6](https://pypi.org/project/simple-salesforce/) was
released 6 hours ago, and it looks like it breaks our MyPy checks, for ex:
potiuk opened a new pull request, #39044:
URL: https://github.com/apache/airflow/pull/39044
---
**^ Add meaningful description above**
Read the **[Pull Request
hussein-awala commented on PR #38876:
URL: https://github.com/apache/airflow/pull/38876#issuecomment-2057810427
> Hi @hussein-awala , can you add more information to the commit message,
I'm finding it difficult to understand what you worked on.
I updated the PR description, could you
potiuk merged PR #39043:
URL: https://github.com/apache/airflow/pull/39043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 82e51760a1 Hostname was "redacted", not "redact"; remove it when there
is no context (#39037)
add 1e9d3d1c35 Do
potiuk opened a new pull request, #39043:
URL: https://github.com/apache/airflow/pull/39043
Follow up after #39035 where local airflow sources have been removed from
PROD image built in CI. The k8s image for tests also added the sources when
preparing the modified image. This is now
lotrias17 commented on issue #38147:
URL: https://github.com/apache/airflow/issues/38147#issuecomment-2057705580
Hello, could a colleague (@TiDeane) and I be assigned to this issue? We are
working for a university project and would be grateful to implement this
feature. Thank you in
dh-racheldean commented on issue #36090:
URL: https://github.com/apache/airflow/issues/36090#issuecomment-2057705616
If i was feeling super-hacky in my own fork, I'd be tweaking
`models.Trigger.clean_unused()`, and adapting `submit_failure` to do the
hilarious re-schedule. In theory, just
potiuk closed pull request #39042: Test for comparision
URL: https://github.com/apache/airflow/pull/39042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
potiuk opened a new pull request, #39042:
URL: https://github.com/apache/airflow/pull/39042
---
**^ Add meaningful description above**
Read the **[Pull Request
potiuk opened a new pull request, #39041:
URL: https://github.com/apache/airflow/pull/39041
---
**^ Add meaningful description above**
Read the **[Pull Request
RobbeSneyders commented on PR #37638:
URL: https://github.com/apache/airflow/pull/37638#issuecomment-2057667740
Hi @potiuk. Great to hear that you found the issue. Let me know if there is
anything else I can help with.
--
This is an automated message from the Apache Git Service.
To
vincbeck commented on code in PR #39039:
URL: https://github.com/apache/airflow/pull/39039#discussion_r1566274506
##
docs/apache-airflow/redirects.txt:
##
@@ -19,8 +19,8 @@
administration-and-deployment/security/index.rst security/index.rst
vincbeck commented on code in PR #38932:
URL: https://github.com/apache/airflow/pull/38932#discussion_r1566270520
##
docs/apache-airflow-providers-amazon/auth-manager/manage/index.rst:
##
@@ -18,3 +18,205 @@
Manage Airflow
vincbeck opened a new pull request, #39040:
URL: https://github.com/apache/airflow/pull/39040
---
**^ Add meaningful description above**
Read the **[Pull Request
dabla commented on PR #38986:
URL: https://github.com/apache/airflow/pull/38986#issuecomment-2057548239
> Thanks for doing it!
Thx for fixing it ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vincbeck commented on code in PR #39039:
URL: https://github.com/apache/airflow/pull/39039#discussion_r1566261785
##
docs/apache-airflow/redirects.txt:
##
@@ -19,8 +19,8 @@
administration-and-deployment/security/index.rst security/index.rst
potiuk commented on code in PR #39039:
URL: https://github.com/apache/airflow/pull/39039#discussion_r1566245887
##
docs/apache-airflow/redirects.txt:
##
@@ -19,8 +19,8 @@
administration-and-deployment/security/index.rst security/index.rst
This is an automated email from the ASF dual-hosted git repository.
jedcunningham pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 58820a914c Use default_factory instead of calling the method in
dataclass (#38948)
add 82e51760a1
jedcunningham merged PR #39037:
URL: https://github.com/apache/airflow/pull/39037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hussein-awala merged PR #38948:
URL: https://github.com/apache/airflow/pull/38948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
husseinawala pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 58820a914c Use default_factory instead of
vincbeck opened a new pull request, #39039:
URL: https://github.com/apache/airflow/pull/39039
Some doc redirection is broken and end up redirecting to the wrong page. The
current redirection redirects to
dabla commented on issue #38195:
URL: https://github.com/apache/airflow/issues/38195#issuecomment-2057482351
> As far as i remember, we recently discuss this case in slack. I guess
better introduce `sa_uri` property (or some similar naming) which returns
sicarul commented on issue #39038:
URL: https://github.com/apache/airflow/issues/39038#issuecomment-2057479094
If it helps to decipher this problem, i found another case:
https://github.com/apache/airflow/assets/4952116/895c1425-5b66-4ecc-9c08-bd7ab563840e;>
And in this one, i was
potiuk closed pull request #39011: Test fixing bad PROD image preparation in CI
URL: https://github.com/apache/airflow/pull/39011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
o-nikolas merged PR #38819:
URL: https://github.com/apache/airflow/pull/38819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sicarul opened a new issue, #39038:
URL: https://github.com/apache/airflow/issues/39038
### Apache Airflow version
2.9.0
### If "Other Airflow 2 version" selected, which one?
_No response_
### What happened?
Since upgrading from 2.8.3 to 2.9.0, some DAGs
boring-cyborg[bot] commented on issue #39038:
URL: https://github.com/apache/airflow/issues/39038#issuecomment-2057449333
Thanks for opening your first issue here! Be sure to follow the issue
template! If you are willing to raise PR to address this issue please do so, no
need to wait for
Taragolis merged PR #38905:
URL: https://github.com/apache/airflow/pull/38905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch improve-warning-system
in repository https://gitbox.apache.org/repos/asf/airflow.git
was 4d9a7f91e9 Apply suggestions from code review
The revisions that were on this branch are still
This is an automated email from the ASF dual-hosted git repository.
onikolas pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 1aa25f1c44 Change capture warnings output format to the JSON (#38905)
add 76e2b72df8 Add six unit tests for
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 1aa25f1c44 Change capture warnings output
Taragolis commented on PR #38905:
URL: https://github.com/apache/airflow/pull/38905#issuecomment-2057430746
Feel difference
**Python 3.12 (non-db)**
```console
== Warning summary. Total: 4,670, Unique: 329
==
airflow: total 133, unique 16
boring-cyborg[bot] commented on PR #38820:
URL: https://github.com/apache/airflow/pull/38820#issuecomment-2057425722
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional
potiuk commented on PR #38820:
URL: https://github.com/apache/airflow/pull/38820#issuecomment-2057426525
Now those tests looked more useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 10d5654c9b Add four unit tests for aws/utils
potiuk merged PR #38820:
URL: https://github.com/apache/airflow/pull/38820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ephraimbuddy commented on code in PR #39032:
URL: https://github.com/apache/airflow/pull/39032#discussion_r1566179122
##
airflow/migrations/versions/0142_2_10_0_update_missing_constraints.py:
##
@@ -0,0 +1,102 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
o-nikolas commented on code in PR #38998:
URL: https://github.com/apache/airflow/pull/38998#discussion_r1566178573
##
airflow/providers/amazon/aws/hooks/batch_client.py:
##
@@ -396,7 +396,11 @@ def get_job_description(self, job_id: str) -> dict:
try:
jedcunningham opened a new pull request, #39037:
URL: https://github.com/apache/airflow/pull/39037
Before:
--
This is an automated
o-nikolas commented on PR #38967:
URL: https://github.com/apache/airflow/pull/38967#issuecomment-2057387105
I'm really glad to see this one merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
romsharon98 commented on code in PR #38892:
URL: https://github.com/apache/airflow/pull/38892#discussion_r1566141583
##
airflow/models/taskinstance.py:
##
@@ -1213,10 +1213,11 @@ def _run_finished_callback(
if callbacks:
callbacks = callbacks if
This is an automated email from the ASF dual-hosted git repository.
vincbeck pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 246f697873 Fix PROD image package installation in CI (#39035)
add 1ded297509 Remove flag from AWS auth manager
vincbeck merged PR #39033:
URL: https://github.com/apache/airflow/pull/39033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Taragolis commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1566143859
##
airflow/providers/pinecone/hooks/pinecone.py:
##
@@ -64,43 +69,80 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
"""Return custom field
romsharon98 commented on code in PR #38892:
URL: https://github.com/apache/airflow/pull/38892#discussion_r1566141583
##
airflow/models/taskinstance.py:
##
@@ -1213,10 +1213,11 @@ def _run_finished_callback(
if callbacks:
callbacks = callbacks if
vatsrahul1001 opened a new pull request, #39036:
URL: https://github.com/apache/airflow/pull/39036
[PR
#37793](https://github.com/apache/airflow/pull/37793/files#diff-e08f6e1a4ea83e85c60acc015ae9cef3e739ead50bddfd1690cf73addcc468aaR312)
introduced KubernetesDeleteJobOperator in the latest
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from f902dbe91f Ban `unittest` marks which presented into the `pytest`
(#39025)
add 246f697873 Fix PROD image package
potiuk merged PR #39035:
URL: https://github.com/apache/airflow/pull/39035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Taragolis merged PR #39020:
URL: https://github.com/apache/airflow/pull/39020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Taragolis merged PR #39025:
URL: https://github.com/apache/airflow/pull/39025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new f902dbe91f Ban `unittest` marks which presented
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new e8082442a7 Remove redundant
eladkal commented on PR #39030:
URL: https://github.com/apache/airflow/pull/39030#issuecomment-2057241552
> > @eladkal looks like 10.17.0 of the Google provider won't work
> > with cncf-k8s provider <8.1.0. Do we need to take some care
> > for the released version of Google provider?
o-nikolas commented on PR #38820:
URL: https://github.com/apache/airflow/pull/38820#issuecomment-2057236733
> > You will need to remove these lines from the project structure tests:
> >
https://github.com/apache/airflow/blob/main/tests/always/test_project_structure.py#L85-L86
>
>
potiuk commented on code in PR #39025:
URL: https://github.com/apache/airflow/pull/39025#discussion_r1566042136
##
tests/providers/amazon/aws/hooks/test_s3.py:
##
@@ -467,7 +466,6 @@ async def
test_s3_key_hook_get_head_object_with_error_async(self, mock_client):
gabor-one commented on issue #39028:
URL: https://github.com/apache/airflow/issues/39028#issuecomment-2057211976
I made a mistake reading the log. You don't need https:// in the connection
URL. Please ignore this.
--
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch fix-prod-image-ci-preparation
in repository https://gitbox.apache.org/repos/asf/airflow.git
discard 34da29f58a Fix PROD image package installation in CI
add 7ddc9bc2ab Fix PROD image
potiuk commented on PR #39030:
URL: https://github.com/apache/airflow/pull/39030#issuecomment-2057180100
> @eladkal looks like 10.17.0 of the Google provider won't work
with cncf-k8s provider <8.1.0. Do we need to take some care
for the released version of Google provider?
potiuk opened a new pull request, #39035:
URL: https://github.com/apache/airflow/pull/39035
When PROD image packages are installed in in CI, the local sources should
not be present in the image, also constraints from sources shoudl replace the
one downloaded from main.
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch fix-prod-image-ci-preparation
in repository https://gitbox.apache.org/repos/asf/airflow.git
commit 34da29f58a1043875602fe07dee25b27ba26c9e0
Author: Jarek Potiuk
AuthorDate: Mon Apr 15 16:08:48
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch fix-prod-image-ci-preparation
in repository https://gitbox.apache.org/repos/asf/airflow.git
at 34da29f58a Fix PROD image package installation in CI
This branch includes the following new
pankajkoti commented on PR #39030:
URL: https://github.com/apache/airflow/pull/39030#issuecomment-2057134687
> It appears that google provider 10.17.0 won't together with
cncf-kubernetes provider <8.1.0. So we would also need to
discuss what could be done for the released google
This is an automated email from the ASF dual-hosted git repository.
pankaj pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 43919c2fa6 Avoid logging empty line KPO (#38247)
pankajastro closed issue #38105: Extra "None" logs from Kubernetes pod while
running a KubernetesPodOperator
URL: https://github.com/apache/airflow/issues/38105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
pankajastro merged PR #38247:
URL: https://github.com/apache/airflow/pull/38247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk merged PR #38967:
URL: https://github.com/apache/airflow/pull/38967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 21f08ddd93 Check whether `AUTH_ROLE_PUBLIC` is set in
`check_authentication` (#39012)
add ad1e473489 Add a
potiuk commented on PR #38967:
URL: https://github.com/apache/airflow/pull/38967#issuecomment-2057098949
Yep.
--
This is an automated message from the Apache Git Service.
To respond
vincbeck commented on PR #38998:
URL: https://github.com/apache/airflow/pull/38998#issuecomment-2057092799
@syedahsn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wlinamchurch commented on PR #38911:
URL: https://github.com/apache/airflow/pull/38911#issuecomment-2057073929
@Taragolis apologies if this is not the correct way to do this but tagging
you since you looked at https://github.com/apache/airflow/pull/35292 previously.
--
This is an
vincbeck commented on PR #38967:
URL: https://github.com/apache/airflow/pull/38967#issuecomment-2057050997
All tests are passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vincbeck commented on PR #38932:
URL: https://github.com/apache/airflow/pull/38932#issuecomment-2057045129
> I know the PR is already merged, so addressing my comments is optional
here.
I address these comments in #39033
--
This is an automated message from the Apache Git Service.
vincbeck commented on code in PR #39033:
URL: https://github.com/apache/airflow/pull/39033#discussion_r1565923872
##
docs/apache-airflow-providers-amazon/auth-manager/manage/index.rst:
##
Review Comment:
These changes address the comments given
1 - 100 of 190 matches
Mail list logo
