Re: [PR] fix: add retry logic in case of google auth refresh credential error [airflow]

2024-04-20 Thread via GitHub
Lee-W commented on PR #38961: URL: https://github.com/apache/airflow/pull/38961#issuecomment-2067906252 I'm planning on merging this one later today. Please let me know if anyone wants to take a deeper look  -- This is an automated message from the Apache Git Service. To respond to the

[I] Add end date of task instance to tooltip [airflow]

2024-04-20 Thread via GitHub
tirkarthi opened a new issue, #39150: URL: https://github.com/apache/airflow/issues/39150 ### Description Currently, only start date and duration of a task instance are displayed in the tooltip. It will be useful to display the end date too since some of our users are wanted to know

Re: [I] Add DNS config and log analytics to AzureContainerInstanceOperator [airflow]

2024-04-20 Thread via GitHub
boring-cyborg[bot] commented on issue #39149: URL: https://github.com/apache/airflow/issues/39149#issuecomment-2067801005 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[I] Add DNS config and log analytics to AzureContainerInstanceOperator [airflow]

2024-04-20 Thread via GitHub
Kylea650 opened a new issue, #39149: URL: https://github.com/apache/airflow/issues/39149 ### Description When creating a container using the AzureContainerInstanceOperator, it would be good to have the ability to provide DNS configuration and to be able to hook up an existing log

Re: [I] let BigQueryGetData operator take a list of fields for the "order by" clause [airflow]

2024-04-20 Thread via GitHub
shahar1 commented on issue #39127: URL: https://github.com/apache/airflow/issues/39127#issuecomment-2067773126 @eladkal Could you please assign me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [DRAFT] Switch to Connexion 3 framework [airflow]

2024-04-20 Thread via GitHub
potiuk commented on code in PR #39055: URL: https://github.com/apache/airflow/pull/39055#discussion_r1573343176 ## airflow/www/app.py: ## @@ -49,19 +50,20 @@ ) from airflow.www.extensions.init_session import init_airflow_session_interface from

Re: [PR] [DRAFT] Switch to Connexion 3 framework [airflow]

2024-04-20 Thread via GitHub
potiuk commented on code in PR #39055: URL: https://github.com/apache/airflow/pull/39055#discussion_r1573342812 ## airflow/www/views.py: ## @@ -3574,7 +3573,7 @@ class RedocView(AirflowBaseView): @expose("/redoc") def redoc(self): """Redoc API

Re: [PR] [DRAFT] Switch to Connexion 3 framework [airflow]

2024-04-20 Thread via GitHub
potiuk commented on code in PR #39055: URL: https://github.com/apache/airflow/pull/39055#discussion_r1573342339 ## airflow/www/app.py: ## @@ -49,35 +50,50 @@ ) from airflow.www.extensions.init_session import init_airflow_session_interface from

Re: [PR] Updated logic to allow AWS Batch Hook `get_job_description` retries to be more effective [airflow]

2024-04-20 Thread via GitHub
shahar1 commented on code in PR #38998: URL: https://github.com/apache/airflow/pull/38998#discussion_r1573340312 ## airflow/providers/amazon/aws/hooks/batch_client.py: ## @@ -396,7 +396,11 @@ def get_job_description(self, job_id: str) -> dict: try:

[I] Privacy menu item should link to https://privacy.apache.org/policies/privacy-policy-public.html [airflow-site]

2024-04-20 Thread via GitHub
sebbASF opened a new issue, #1008: URL: https://github.com/apache/airflow-site/issues/1008 The Privacy menu item should link to https://privacy.apache.org/policies/privacy-policy-public.html: https://www.apache.org/foundation/marks/pmcs.html#navigation This should be a direct

Re: [PR] Expose AWS IAM missing param in Hashicorp secret [airflow]

2024-04-20 Thread via GitHub
pankajastro commented on code in PR #38536: URL: https://github.com/apache/airflow/pull/38536#discussion_r1573322029 ## airflow/providers/hashicorp/_internal_client/vault_client.py: ## @@ -103,7 +108,11 @@ def __init__( password: str | None = None, key_id: str

Re: [PR] Expose AWS IAM missing param in Hashicorp secret [airflow]

2024-04-20 Thread via GitHub
pankajastro commented on code in PR #38536: URL: https://github.com/apache/airflow/pull/38536#discussion_r1573321715 ## airflow/providers/hashicorp/provider.yaml: ## @@ -55,6 +55,7 @@ versions: dependencies: - apache-airflow>=2.6.0 - hvac>=1.1.0 + -

Re: [PR] [FEAT] added notebook error in databricks deferrable handler [airflow]

2024-04-20 Thread via GitHub
gaurav7261 commented on code in PR #39110: URL: https://github.com/apache/airflow/pull/39110#discussion_r1573321766 ## airflow/providers/databricks/operators/databricks.py: ## @@ -156,17 +144,37 @@ def _handle_deferrable_databricks_operator_execution(operator, hook, log,

Re: [PR] Expose AWS IAM missing param in Hashicorp secret [airflow]

2024-04-20 Thread via GitHub
pankajastro commented on code in PR #38536: URL: https://github.com/apache/airflow/pull/38536#discussion_r1573321595 ## airflow/providers/hashicorp/_internal_client/vault_client.py: ## @@ -318,15 +322,23 @@ def _auth_azure(self, _client: hvac.Client) -> None: )

Re: [PR] Add Rendered k8s pod spec tab to ti details view [airflow]

2024-04-20 Thread via GitHub
raphaelauv commented on code in PR #39141: URL: https://github.com/apache/airflow/pull/39141#discussion_r1573313759 ## airflow/www/views.py: ## @@ -1533,6 +1533,48 @@ def rendered_k8s(self, *, session: Session = NEW_SESSION): title=title, ) +

Re: [PR] Lazy load dag run when doing dep context query [airflow]

2024-04-20 Thread via GitHub
dstandish commented on code in PR #39094: URL: https://github.com/apache/airflow/pull/39094#discussion_r1573307010 ## airflow/models/dagrun.py: ## @@ -614,6 +620,7 @@ def _check_last_n_dagruns_failed(self, dag_id, max_consecutive_failed_dag_runs, def get_task_instances(

Re: [PR] Lazy load dag run when doing dep context query [airflow]

2024-04-20 Thread via GitHub
dstandish commented on code in PR #39094: URL: https://github.com/apache/airflow/pull/39094#discussion_r1573306722 ## airflow/models/dagrun.py: ## @@ -614,6 +620,7 @@ def _check_last_n_dagruns_failed(self, dag_id, max_consecutive_failed_dag_runs, def get_task_instances(

Re: [PR] Lazy load dag run when doing dep context query [airflow]

2024-04-20 Thread via GitHub
dstandish commented on code in PR #39094: URL: https://github.com/apache/airflow/pull/39094#discussion_r1573306722 ## airflow/models/dagrun.py: ## @@ -614,6 +620,7 @@ def _check_last_n_dagruns_failed(self, dag_id, max_consecutive_failed_dag_runs, def get_task_instances(

Re: [PR] [FEAT] added notebook error in databricks deferrable handler [airflow]

2024-04-20 Thread via GitHub
Lee-W commented on code in PR #39110: URL: https://github.com/apache/airflow/pull/39110#discussion_r1573287116 ## airflow/providers/databricks/operators/databricks.py: ## @@ -156,17 +144,37 @@ def _handle_deferrable_databricks_operator_execution(operator, hook, log, contex

Re: [I] SSHClickhouseOperator [airflow]

2024-04-20 Thread via GitHub
vargacypher commented on issue #39140: URL: https://github.com/apache/airflow/issues/39140#issuecomment-2067672304 @eladkal sorry, I expressed myself poorly. I will create the Clickhouse provider (hook and ClickhouseSSHOperator ), but I will not develop an operator based on its

[I] hookimpl on_dag_run_failed goes to infinite loop [airflow]

2024-04-20 Thread via GitHub
vilozio opened a new issue, #39146: URL: https://github.com/apache/airflow/issues/39146 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.6.3 ### What happened? We have our own

Re: [I] SSHClickhouseOperator [airflow]

2024-04-20 Thread via GitHub
vargacypher commented on issue #39140: URL: https://github.com/apache/airflow/issues/39140#issuecomment-2067656156 O thanks @eladkal , but my approach it's a little bit different from the #25714 , since i pretend to make an derived SSHOperator. Could i open a new PR since #25714 is

Re: [I] SSHClickhouseOperator [airflow]

2024-04-20 Thread via GitHub
eladkal commented on issue #39140: URL: https://github.com/apache/airflow/issues/39140#issuecomment-2067636557 There was an attepmt to add ClickHouse provider https://github.com/apache/airflow/issues/10893#issuecomment-1517683079 Anyone can pick it up from where it left off and

Re: [I] SSHClickhouseOperator [airflow]

2024-04-20 Thread via GitHub
eladkal closed issue #39140: SSHClickhouseOperator URL: https://github.com/apache/airflow/issues/39140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Fix all deprecations for SQLAlchemy 2.0 [airflow]

2024-04-20 Thread via GitHub
dondaum commented on issue #28723: URL: https://github.com/apache/airflow/issues/28723#issuecomment-2067633235 Hi. I would like to support. To clarify is it correct that all warnings can be found in this issue detail section from potiuk? -- This is an automated message from the Apache

Re: [PR] [AIRFLOW-2193] Add ROperator for using R [airflow]

2024-04-20 Thread via GitHub
potiuk commented on PR #3115: URL: https://github.com/apache/airflow/pull/3115#issuecomment-2067631798 Just start PR. There is no need to have issue opened for PR to be reviewed/merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

(airflow) branch constraints-main updated: Updating constraints. Github run id:8763465189

2024-04-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 9eebc3c934 Updating

Re: [PR] Add Rendered k8s pod spec tab to ti details view [airflow]

2024-04-20 Thread via GitHub
raphaelauv commented on PR #39141: URL: https://github.com/apache/airflow/pull/39141#issuecomment-2067602332 This is great ! Also maybe a toggle to switch between JSON and YAML would be so cool ( same feature than inside the kubernetes dashboard ) -- This is an automated message

(airflow) branch main updated: Cleanup PagerdutyNotifier __init__ (#39145)

2024-04-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4374a49872 Cleanup PagerdutyNotifier __init__

Re: [PR] Cleanup PagerdutyNotifier __init__ [airflow]

2024-04-20 Thread via GitHub
boring-cyborg[bot] commented on PR #39145: URL: https://github.com/apache/airflow/pull/39145#issuecomment-2067588539 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Cleanup PagerdutyNotifier __init__ [airflow]

2024-04-20 Thread via GitHub
potiuk merged PR #39145: URL: https://github.com/apache/airflow/pull/39145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Resolve `B028` (no-explicit-stacklevel) in core (#39123)

2024-04-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 79286d6398 Resolve `B028` (no-explicit-stacklevel)

Re: [PR] Resolve `B028` (no-explicit-stacklevel) in core [airflow]

2024-04-20 Thread via GitHub
potiuk merged PR #39123: URL: https://github.com/apache/airflow/pull/39123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Custom FAB actions no longer work [airflow]

2024-04-20 Thread via GitHub
potiuk commented on issue #39144: URL: https://github.com/apache/airflow/issues/39144#issuecomment-2067587524 CC: @vincbeck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(airflow) branch main updated (2358064fdf -> 85bc9afcaa)

2024-04-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 2358064fdf Use `declarative_base` from `sqlalchemy.orm` instead of `sqlalchemy.ext.declarative` (#39134) add

Re: [PR] Fix templated env_vars field in `KubernetesPodOperator` to allow for compatibility with `XComArgs` [airflow]

2024-04-20 Thread via GitHub
potiuk commented on PR #39139: URL: https://github.com/apache/airflow/pull/39139#issuecomment-2067587175 NICE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix templated env_vars field in `KubernetesPodOperator` to allow for compatibility with `XComArgs` [airflow]

2024-04-20 Thread via GitHub
boring-cyborg[bot] commented on PR #39139: URL: https://github.com/apache/airflow/pull/39139#issuecomment-2067587137 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Fix templated env_vars field in `KubernetesPodOperator` to allow for compatibility with `XComArgs` [airflow]

2024-04-20 Thread via GitHub
potiuk merged PR #39139: URL: https://github.com/apache/airflow/pull/39139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Use `declarative_base` from `sqlalchemy.orm` instead of `sqlalchemy.ext.declarative` (#39134)

2024-04-20 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2358064fdf Use `declarative_base` from

Re: [PR] Use `declarative_base` from `sqlalchemy.orm` instead of `sqlalchemy.ext.declarative` [airflow]

2024-04-20 Thread via GitHub
Taragolis merged PR #39134: URL: https://github.com/apache/airflow/pull/39134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: