Re: [I] Move "create db from orm" to be a public method in db manager interface [airflow]

2025-03-19 Thread via GitHub
ephraimbuddy commented on issue #47975: URL: https://github.com/apache/airflow/issues/47975#issuecomment-2739390956 > Nice, thanks! cc @ephraimbuddy , can you review the PR when it's ready? Sure. I will -- This is an automated message from the Apache Git Service. To respond to the m

(airflow) branch feat/47972/move-airflow-ctl-out-of-core updated (101fea3e152 -> 1a74aca6e66)

2025-03-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch feat/47972/move-airflow-ctl-out-of-core in repository https://gitbox.apache.org/repos/asf/airflow.git from 101fea3e152 Remove the last changes to core add 1a74aca6e66 One last air

Re: [PR] Update task lifecycle diagram for missing states [airflow]

2025-03-19 Thread via GitHub
eladkal commented on PR #46056: URL: https://github.com/apache/airflow/pull/46056#issuecomment-2739345138 Rebased to make sure CI is green. I'll merge after -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Generate database ERD using chartdb [airflow]

2025-03-19 Thread via GitHub
eladkal commented on issue #46057: URL: https://github.com/apache/airflow/issues/46057#issuecomment-2739343327 @jx2lee did you make progress on this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Too many requests [airflow]

2025-03-19 Thread via GitHub
EvertonSA commented on issue #47950: URL: https://github.com/apache/airflow/issues/47950#issuecomment-2737149606 there is no need to check for the metadata to be available, if its not available it will fail anyway -- This is an automated message from the Apache Git Service. To respond to

(airflow) branch feat/47972/move-airflow-ctl-out-of-core updated (ccf85afd151 -> 2bbc966df01)

2025-03-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch feat/47972/move-airflow-ctl-out-of-core in repository https://gitbox.apache.org/repos/asf/airflow.git from ccf85afd151 Create basic files and include basics, move api and related code

Re: [I] Move "create db from orm" to be a public method in db manager interface [airflow]

2025-03-19 Thread via GitHub
Prab-27 commented on issue #47975: URL: https://github.com/apache/airflow/issues/47975#issuecomment-2739316562 @jedcunningham , I can work on this . I'll try to raise a PR as soon as possible -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] Scheduler crashes on expanding a task with a literal list [airflow]

2025-03-19 Thread via GitHub
phanikumv commented on issue #47735: URL: https://github.com/apache/airflow/issues/47735#issuecomment-2739309750 Assigned to @dstandish in the interest of time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Introduce API versioning into the Execution API [airflow]

2025-03-19 Thread via GitHub
amoghrajesh commented on code in PR #47951: URL: https://github.com/apache/airflow/pull/47951#discussion_r2004837052 ## airflow/api_fastapi/execution_api/datamodels/variable.py: ## @@ -32,7 +32,5 @@ class VariableResponse(BaseModel): class VariablePostBody(StrictBaseModel):

Re: [PR] Disallow platformdirs: 4.3.7 to limit setuptools 77.0.1 that breaks CI [airflow]

2025-03-19 Thread via GitHub
amoghrajesh commented on PR #47985: URL: https://github.com/apache/airflow/pull/47985#issuecomment-2739205211 Yeah this seems to fix the issue in the CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Setting Airflow context Environment variables for operators [airflow]

2025-03-19 Thread via GitHub
amoghrajesh commented on PR #47644: URL: https://github.com/apache/airflow/pull/47644#issuecomment-2739183691 There's a static check failure too: ``` mypy providers/http/src providers/http/tests providers/sqlite/src providers/sqlite/tests providers/docker/src providers/docker/tests pr

Re: [PR] Setting Airflow context Environment variables for operators [airflow]

2025-03-19 Thread via GitHub
amoghrajesh commented on code in PR #47644: URL: https://github.com/apache/airflow/pull/47644#discussion_r2004820685 ## airflow/version_compat.py: ## @@ -0,0 +1,36 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: No need to have this file #

Re: [PR] Render stacktraces properly [airflow]

2025-03-19 Thread via GitHub
aritra24 commented on PR #47965: URL: https://github.com/apache/airflow/pull/47965#issuecomment-2737460452 https://github.com/user-attachments/assets/187fed9e-2aa9-4fd9-bdb3-01a211154a1a"; /> First pass at fixing the stacktraces in logs, still need to make it prettier. So any recommendat

Re: [PR] Remove `subdir` command from task commands [airflow]

2025-03-19 Thread via GitHub
ambika-garg commented on PR #47837: URL: https://github.com/apache/airflow/pull/47837#issuecomment-2739143449 > > should we remove the `get_dags` function in `task_clear`, since the `task_clear` command only accepts a single `dag_id`? > > Not sure without digging in more. Might be som

Re: [I] ExternalTaskSensor is failing when logical_date is null [airflow]

2025-03-19 Thread via GitHub
kaxil commented on issue #47447: URL: https://github.com/apache/airflow/issues/47447#issuecomment-2736161401 fyi: https://github.com/apache/airflow/issues/47499 got merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] feat(providers): add infisical secret backend [airflow]

2025-03-19 Thread via GitHub
DanielHougaard opened a new pull request, #47986: URL: https://github.com/apache/airflow/pull/47986 This PR aims to add support for [Infisical](https://infisical.com) as a custom secrets backend. The PR is currently a draft until the following gets reso

[PR] Disallow platformdirs: 4.3.7 to limit setuptools 77.0.1 that breaks CI [airflow]

2025-03-19 Thread via GitHub
amoghrajesh opened a new pull request, #47985: URL: https://github.com/apache/airflow/pull/47985 Facing these issues in tests: ``` _ ERROR collecting providers/microsoft/winrm/tests/unit/microsoft/winrm/hooks/test_winrm.py _ ImportError while importing test modul

Re: [PR] Accept task_key as an argument in `DatabricksNotebookOperator` [airflow]

2025-03-19 Thread via GitHub
dheerajkumar-solanki commented on PR #44960: URL: https://github.com/apache/airflow/pull/44960#issuecomment-2739084630 @hardeybisey I think this MR is creating the issue when there we are adding databricks task dependencies: https://github.com/apache/airflow/issues/47983 -- This is an aut

[PR] Update taskflow.rst [airflow]

2025-03-19 Thread via GitHub
arjunpathak072 opened a new pull request, #47984: URL: https://github.com/apache/airflow/pull/47984 In the TaskFlow API documentation, I noticed that the examples for @task.virtualenv and @task.external_python decorators were referring back to the Apache 1.x way of doing things (i.e using P

Re: [PR] Added Fastapi endpoint for reserialize_dags [airflow]

2025-03-19 Thread via GitHub
jedcunningham commented on PR #47943: URL: https://github.com/apache/airflow/pull/47943#issuecomment-2738432977 > On a side note, do you have any updates on the 3.1 release timeline? Unfortunately, not at this time. We can merge new features once 3.0 is out though, so the period of ti

(airflow) branch feat/47972/move-airflow-ctl-out-of-core created (now 06fbce30097)

2025-03-19 Thread bugraoz
This is an automated email from the ASF dual-hosted git repository. bugraoz pushed a change to branch feat/47972/move-airflow-ctl-out-of-core in repository https://gitbox.apache.org/repos/asf/airflow.git at 06fbce30097 Create basic files and include basics, move api and related code to ai

(airflow) branch constraints-main updated: Updating constraints. Github run id:13960392547

2025-03-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 92ec5c738b0 Updating co

Re: [PR] [WIP] AIP-81 Move CLI codes to airflowctl [airflow]

2025-03-19 Thread via GitHub
bugraoz93 commented on PR #47981: URL: https://github.com/apache/airflow/pull/47981#issuecomment-2738943922 cc: @jedcunningham @kaxil -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(airflow) branch feat/47972/move-airflow-ctl-out-of-core updated (06fbce30097 -> ccf85afd151)

2025-03-19 Thread bugraoz
This is an automated email from the ASF dual-hosted git repository. bugraoz pushed a change to branch feat/47972/move-airflow-ctl-out-of-core in repository https://gitbox.apache.org/repos/asf/airflow.git discard 06fbce30097 Create basic files and include basics, move api and related code to ai

Re: [PR] Next run date should not be updated by backfills [airflow]

2025-03-19 Thread via GitHub
jedcunningham merged PR #47922: URL: https://github.com/apache/airflow/pull/47922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

(airflow) branch main updated (9b9a109f385 -> 857d14b34d3)

2025-03-19 Thread shubhamraj
This is an automated email from the ASF dual-hosted git repository. shubhamraj pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 9b9a109f385 docs: fix numbered list (#47978) add 857d14b34d3 Add Create Connection button and form on connecti

(airflow) branch main updated: docs: fix numbered list (#47978)

2025-03-19 Thread jasonliu
This is an automated email from the ASF dual-hosted git repository. jasonliu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9b9a109f385 docs: fix numbered list (#47978) 9b9a

Re: [I] DatabricksNotebookOperator generating invalid dependency graph [airflow]

2025-03-19 Thread via GitHub
boring-cyborg[bot] commented on issue #47983: URL: https://github.com/apache/airflow/issues/47983#issuecomment-2738986472 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] Add Create Connection button and form on connection page [airflow]

2025-03-19 Thread via GitHub
shubhamraj-git commented on PR #47868: URL: https://github.com/apache/airflow/pull/47868#issuecomment-2738996316 Thanks @jscheffl & @bbovenzi for the reviews, Merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[I] DatabricksNotebookOperator generating invalid dependency graph [airflow]

2025-03-19 Thread via GitHub
dheerajkumar-solanki opened a new issue, #47983: URL: https://github.com/apache/airflow/issues/47983 ### Apache Airflow Provider(s) databricks ### Versions of Apache Airflow Providers apache-airflow-providers-common-sql==1.24.0 apache-airflow-providers-databricks==7.2.

Re: [PR] Refactor container image to persist msodbcsql18 eula acceptance [airflow]

2025-03-19 Thread via GitHub
boring-cyborg[bot] commented on PR #47982: URL: https://github.com/apache/airflow/pull/47982#issuecomment-2738931790 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

(airflow) branch feat/47972/move-airflow-ctl-out-of-core deleted (was 31a826434ed)

2025-03-19 Thread bugraoz
This is an automated email from the ASF dual-hosted git repository. bugraoz pushed a change to branch feat/47972/move-airflow-ctl-out-of-core in repository https://gitbox.apache.org/repos/asf/airflow.git was 31a826434ed Create basic files and include basics, move api and related code to ai

Re: [PR] [WIP] AIP-81 Move CLI codes to airflowctl [airflow]

2025-03-19 Thread via GitHub
bugraoz93 closed pull request #47980: [WIP] AIP-81 Move CLI codes to airflowctl URL: https://github.com/apache/airflow/pull/47980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

(airflow) 01/01: Create basic files and include basics, move api and related code to airflowctl

2025-03-19 Thread bugraoz
This is an automated email from the ASF dual-hosted git repository. bugraoz pushed a commit to branch feat/47972/move-airflow-ctl-out-of-core in repository https://gitbox.apache.org/repos/asf/airflow.git commit 06fbce30097cd7d1e6bc4d47c9d8c2b306bebf12 Author: Bugra Ozturk AuthorDate: Thu Mar 20

(airflow) branch feat/47972/move-airflow-ctl-out-of-core created (now 31a826434ed)

2025-03-19 Thread bugraoz
This is an automated email from the ASF dual-hosted git repository. bugraoz pushed a change to branch feat/47972/move-airflow-ctl-out-of-core in repository https://gitbox.apache.org/repos/asf/airflow.git at 31a826434ed Create basic files and include basics, move api and related code to ai

Re: [PR] docs: fix numbered list [airflow]

2025-03-19 Thread via GitHub
boring-cyborg[bot] commented on PR #47978: URL: https://github.com/apache/airflow/pull/47978#issuecomment-2738880107 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Move airflow sources to airflow-core package [airflow]

2025-03-19 Thread via GitHub
potiuk commented on PR #47798: URL: https://github.com/apache/airflow/pull/47798#issuecomment-2738881478 OK. this one has a chance to be green. Happy to see reviews on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] docs: fix numbered list [airflow]

2025-03-19 Thread via GitHub
jason810496 merged PR #47978: URL: https://github.com/apache/airflow/pull/47978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airf

[PR] Added step to install docker compose in MacOs [airflow]

2025-03-19 Thread via GitHub
shahbazaamir opened a new pull request, #47979: URL: https://github.com/apache/airflow/pull/47979 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.r

Re: [PR] feat(api_fastapi): include asset id in asset nodes when calling "/ui/dependencies" and "/ui/structure/structure_data" [airflow]

2025-03-19 Thread via GitHub
Lee-W commented on PR #47381: URL: https://github.com/apache/airflow/pull/47381#issuecomment-2738812551 > I'm not sure what the issue is, but I can't seem to get `SerializedDagModel.get_dag_dependencies()` to ever have a populated response on my local dev. Even though `main` is fine

Re: [I] AIP-81 Central API Communication Mechanism for CLI [airflow]

2025-03-19 Thread via GitHub
jedcunningham closed issue #42561: AIP-81 Central API Communication Mechanism for CLI URL: https://github.com/apache/airflow/issues/42561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Implement multisort in DAGs table [airflow]

2025-03-19 Thread via GitHub
mariana-marcal-santana commented on PR #47849: URL: https://github.com/apache/airflow/pull/47849#issuecomment-2738434799 Thanks for the insights! I'll check on that and update on my progress -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] AIP 75 || Not able to use same URI for two Assets [airflow]

2025-03-19 Thread via GitHub
uranusjr closed issue #47830: AIP 75 || Not able to use same URI for two Assets URL: https://github.com/apache/airflow/issues/47830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Provide an alternative OpenTelemetry implementation for traces that follows standard otel practices [airflow]

2025-03-19 Thread via GitHub
ferruzzi commented on code in PR #43941: URL: https://github.com/apache/airflow/pull/43941#discussion_r2004447417 ## tests/jobs/test_scheduler_job.py: ## @@ -2367,6 +2370,194 @@ def test_runs_are_created_after_max_active_runs_was_reached(self, dag_maker, ses dag_runs =

[PR] Update S3 system test [airflow]

2025-03-19 Thread via GitHub
ferruzzi opened a new pull request, #47974: URL: https://github.com/apache/airflow/pull/47974 A Sensor was being skipped for a reason that is no longer true, so we may as well stop skipping it. This passes when I test it locally, should be good to go on the CI as well.

Re: [PR] Default to the FabAuthManager in the chart [airflow]

2025-03-19 Thread via GitHub
jedcunningham merged PR #47976: URL: https://github.com/apache/airflow/pull/47976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] Added Fastapi endpoint for reserialize_dags [airflow]

2025-03-19 Thread via GitHub
shubham-pyc commented on PR #47943: URL: https://github.com/apache/airflow/pull/47943#issuecomment-2738577032 @jedcunningham thanks for the clarification. Is it okay if I keep working on this feature and it just gets merged next month? I am open to addressing other open issues but any f

Re: [I] Scheduler crashes on expanding a task with a literal list [airflow]

2025-03-19 Thread via GitHub
rawwar commented on issue #47735: URL: https://github.com/apache/airflow/issues/47735#issuecomment-2738570586 > did you make any progress @rawwar ? I won't be able to statt this until saturday. If you would like to lick thid issue, please feel free to. -- This is an automated mess

Re: [PR] docs: fix numbered list [airflow]

2025-03-19 Thread via GitHub
boring-cyborg[bot] commented on PR #47978: URL: https://github.com/apache/airflow/pull/47978#issuecomment-2738561266 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] docs: fix numbered list [airflow]

2025-03-19 Thread via GitHub
yunchipang opened a new pull request, #47978: URL: https://github.com/apache/airflow/pull/47978 --- fixes a numbered list in `contributing-docs/03_contributors_quick_start.rst`. please see changes in rich diff. **^ Add meaningful description above**

Re: [PR] AIP-84 Move public api under /api/v2 [airflow]

2025-03-19 Thread via GitHub
jedcunningham merged PR #47760: URL: https://github.com/apache/airflow/pull/47760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] Introduce API versioning into the Execution API [airflow]

2025-03-19 Thread via GitHub
ashb commented on code in PR #47951: URL: https://github.com/apache/airflow/pull/47951#discussion_r2004457190 ## task-sdk/dev/generate_models.py: ## @@ -80,20 +76,20 @@ def load_config(): return cfg -def generate_file(app: FastAPI): -# The persisted openapi spec wil

Re: [PR] Add Create Connection button and form on connection page [airflow]

2025-03-19 Thread via GitHub
jscheffl commented on code in PR #47868: URL: https://github.com/apache/airflow/pull/47868#discussion_r2004466100 ## airflow/ui/src/pages/Connections/ConnectionForm.tsx: ## @@ -0,0 +1,294 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

(airflow) branch move_fab_session_table_creation_to_provider updated (1d84e91b5f8 -> 1b4b1094d9e)

2025-03-19 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a change to branch move_fab_session_table_creation_to_provider in repository https://gitbox.apache.org/repos/asf/airflow.git from 1d84e91b5f8 Move FAB session table creation to FAB provider add 1b4b1094d

Re: [PR] Add Create Connection button and form on connection page [airflow]

2025-03-19 Thread via GitHub
jscheffl commented on code in PR #47868: URL: https://github.com/apache/airflow/pull/47868#discussion_r2004464714 ## airflow/ui/src/pages/Connections/ConnectionForm.tsx: ## @@ -0,0 +1,293 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

(airflow) branch main updated (81893ed19a5 -> 6af0786c20b)

2025-03-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 81893ed19a5 AIP-81 - API Communication Mechanism (#45300) add 6af0786c20b Default to the FabAuthManager in

Re: [PR] AIP-81 - API Communication Mechanism [airflow]

2025-03-19 Thread via GitHub
jedcunningham commented on PR #45300: URL: https://github.com/apache/airflow/pull/45300#issuecomment-2738494507 #protm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

(airflow) branch main updated (4d6b0df1501 -> 81893ed19a5)

2025-03-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 4d6b0df1501 Update example_s3 system test (#47974) add 81893ed19a5 AIP-81 - API Communication Mechanism (#4

Re: [PR] AIP-81 - API Communication Mechanism [airflow]

2025-03-19 Thread via GitHub
jedcunningham merged PR #45300: URL: https://github.com/apache/airflow/pull/45300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] AIP-81 - API Communication Mechanism [airflow]

2025-03-19 Thread via GitHub
jedcunningham commented on PR #45300: URL: https://github.com/apache/airflow/pull/45300#issuecomment-2738492886 Failure is unrelated. Merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] Refactor core_api `test_client` to add api prefix automatically [airflow]

2025-03-19 Thread via GitHub
jedcunningham opened a new issue, #47977: URL: https://github.com/apache/airflow/issues/47977 ### Body This would mean you can do `test_client.get("auth/login")` vs `test_client.get("api/v2/auth/login")` everywhere. Originally brought up [here](https://github.com/apache/airflo

Re: [PR] Provide an alternative OpenTelemetry implementation for traces that follows standard otel practices [airflow]

2025-03-19 Thread via GitHub
ferruzzi commented on code in PR #43941: URL: https://github.com/apache/airflow/pull/43941#discussion_r2004452448 ## airflow/jobs/scheduler_job_runner.py: ## @@ -807,8 +818,18 @@ def process_executor_events( ti.pid, ) -with Trace.start

Re: [PR] Add Create Connection button and form on connection page [airflow]

2025-03-19 Thread via GitHub
jscheffl commented on code in PR #47868: URL: https://github.com/apache/airflow/pull/47868#discussion_r2004441285 ## airflow/ui/src/pages/Connections/ConnectionForm.tsx: ## @@ -0,0 +1,293 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

(airflow) branch main updated (2500dcf20d2 -> 4d6b0df1501)

2025-03-19 Thread ferruzzi
This is an automated email from the ASF dual-hosted git repository. ferruzzi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 2500dcf20d2 Move FAB session table creation to FAB provider (#47969) add 4d6b0df1501 Update example_s3 system te

Re: [PR] Update S3 system test [airflow]

2025-03-19 Thread via GitHub
ferruzzi merged PR #47974: URL: https://github.com/apache/airflow/pull/47974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Replace DAGs with dags in docs [airflow]

2025-03-19 Thread via GitHub
dstandish commented on code in PR #47959: URL: https://github.com/apache/airflow/pull/47959#discussion_r2004432289 ## docs/apache-airflow/administration-and-deployment/dagfile-processing.rst: ## @@ -19,7 +19,7 @@ DAG File Processing --- -DAG File Processing r

Re: [PR] AIP-84 Move public api under /api/v2 [airflow]

2025-03-19 Thread via GitHub
jedcunningham commented on code in PR #47760: URL: https://github.com/apache/airflow/pull/47760#discussion_r2004431967 ## airflow/api_fastapi/auth/managers/simple/ui/dev/index.html: ## @@ -3,7 +3,7 @@ -http://localhost:5174/public/pin_32.png"; /> +http://loca

Re: [I] Unable to assign executor_config for dynamic tasks using airflow policy [airflow]

2025-03-19 Thread via GitHub
karenbraganz commented on issue #46714: URL: https://github.com/apache/airflow/issues/46714#issuecomment-2738333414 Another more straightforward option is to override pod resources with a [pod policy](https://airflow.apache.org/docs/apache-airflow/stable/administration-and-deployment/cluster

Re: [PR] AIP-81 - API Communication Mechanism [airflow]

2025-03-19 Thread via GitHub
bugraoz93 commented on code in PR #45300: URL: https://github.com/apache/airflow/pull/45300#discussion_r2004388821 ## pyproject.toml: ## @@ -317,6 +317,9 @@ testing = ["dev", "providers.tests", "tests_common", "tests"] "providers/cncf/*/src/airflow/providers/cncf/__init__.py"

[PR] Default to the FabAuthManager in the chart [airflow]

2025-03-19 Thread via GitHub
jedcunningham opened a new pull request, #47976: URL: https://github.com/apache/airflow/pull/47976 Core is going to move to the SimpleAuthManager by default, but the chart should keep using the FabAuthManager as a default instead for the time being. Users can always change this to another a

[PR] Render stacktraces properly [airflow]

2025-03-19 Thread via GitHub
aritra24 opened a new pull request, #47965: URL: https://github.com/apache/airflow/pull/47965 Closes: #47921 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/

Re: [PR] Fix #44443: DAGs state change from running to queued, when paused, to avoid the increment of their duration [airflow]

2025-03-19 Thread via GitHub
PNL0 commented on PR #47557: URL: https://github.com/apache/airflow/pull/47557#issuecomment-2738272255 Hello, @bugraoz93 @pierrejeambrun @ephraimbuddy. Do you have any new feedback for my PR? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] AIP-81 - API Communication Mechanism [airflow]

2025-03-19 Thread via GitHub
jedcunningham commented on code in PR #45300: URL: https://github.com/apache/airflow/pull/45300#discussion_r2004378989 ## pyproject.toml: ## @@ -317,6 +317,9 @@ testing = ["dev", "providers.tests", "tests_common", "tests"] "providers/cncf/*/src/airflow/providers/cncf/__init__.

Re: [PR] Move FAB related dependencies into FAB provider [airflow]

2025-03-19 Thread via GitHub
jedcunningham commented on PR #47958: URL: https://github.com/apache/airflow/pull/47958#issuecomment-2738241355 Looks like it was FAB. I'll rework this in a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Updating EC2 Operators and Sensors with AWS Base classes [airflow]

2025-03-19 Thread via GitHub
o-nikolas commented on code in PR #47931: URL: https://github.com/apache/airflow/pull/47931#discussion_r2004349465 ## providers/amazon/src/airflow/providers/amazon/aws/operators/ec2.py: ## @@ -51,46 +52,42 @@ class EC2StartInstanceOperator(BaseOperator): between each in

Re: [I] Unable to assign executor_config for dynamic tasks using airflow policy [airflow]

2025-03-19 Thread via GitHub
karenbraganz commented on issue #46714: URL: https://github.com/apache/airflow/issues/46714#issuecomment-2738019101 You are experiencing this issue because the `executor_config` property for mapped tasks does not have a defined setter. This has been reported before in [#24547](https://githu

(airflow) branch main updated: Move FAB session table creation to FAB provider (#47969)

2025-03-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2500dcf20d2 Move FAB session table creation

Re: [PR] Replace DAGs with dags in docs [airflow]

2025-03-19 Thread via GitHub
RNHTTR commented on code in PR #47959: URL: https://github.com/apache/airflow/pull/47959#discussion_r2004332005 ## docs/apache-airflow/administration-and-deployment/dagfile-processing.rst: ## @@ -19,7 +19,7 @@ DAG File Processing --- -DAG File Processing refe

Re: [PR] Replace DAGs with dags in docs [airflow]

2025-03-19 Thread via GitHub
RNHTTR commented on code in PR #47959: URL: https://github.com/apache/airflow/pull/47959#discussion_r2004332005 ## docs/apache-airflow/administration-and-deployment/dagfile-processing.rst: ## @@ -19,7 +19,7 @@ DAG File Processing --- -DAG File Processing refe

Re: [PR] Replace DAGs with dags in docs [airflow]

2025-03-19 Thread via GitHub
dstandish commented on code in PR #47959: URL: https://github.com/apache/airflow/pull/47959#discussion_r2004273137 ## docs/apache-airflow/administration-and-deployment/dag-serialization.rst: ## @@ -79,14 +79,14 @@ Add the following settings in ``airflow.cfg``: compress_seri

Re: [PR] Replace DAGs with dags in docs [airflow]

2025-03-19 Thread via GitHub
aritra24 commented on code in PR #47959: URL: https://github.com/apache/airflow/pull/47959#discussion_r2004264995 ## docs/apache-airflow/administration-and-deployment/dag-serialization.rst: ## @@ -79,14 +79,14 @@ Add the following settings in ``airflow.cfg``: compress_seria

[PR] Feat/vpa chart [airflow]

2025-03-19 Thread via GitHub
wolvery opened a new pull request, #47973: URL: https://github.com/apache/airflow/pull/47973 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pu

Re: [PR] Don't expect default connections to be present [airflow]

2025-03-19 Thread via GitHub
o-nikolas commented on code in PR #47968: URL: https://github.com/apache/airflow/pull/47968#discussion_r2004239496 ## providers/amazon/src/airflow/providers/amazon/aws/transfers/redshift_to_s3.py: ## @@ -102,7 +103,7 @@ def __init__( table: str | None = None, s

Re: [PR] Provide an alternative OpenTelemetry implementation for traces that follows standard otel practices [airflow]

2025-03-19 Thread via GitHub
xBis7 commented on code in PR #43941: URL: https://github.com/apache/airflow/pull/43941#discussion_r2004230514 ## airflow/traces/otel_tracer.py: ## @@ -57,29 +56,65 @@ class OtelTrace: When OTEL is enabled, the Trace class will be replaced by this class. """ -def

Re: [PR] Provide an alternative OpenTelemetry implementation for traces that follows standard otel practices [airflow]

2025-03-19 Thread via GitHub
xBis7 commented on code in PR #43941: URL: https://github.com/apache/airflow/pull/43941#discussion_r2004193898 ## airflow/jobs/scheduler_job_runner.py: ## @@ -807,8 +818,18 @@ def process_executor_events( ti.pid, ) -with Trace.start_sp

Re: [PR] Fix typo in ``InProcessExecutionAPI`` [airflow]

2025-03-19 Thread via GitHub
kaxil merged PR #47966: URL: https://github.com/apache/airflow/pull/47966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap

(airflow) branch main updated (b1144ec4063 -> 0a0b33aca72)

2025-03-19 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b1144ec4063 Only return active assets in API by default (#47962) add 0a0b33aca72 Fix typo in ``InProcessExecuti

Re: [PR] Provide an alternative OpenTelemetry implementation for traces that follows standard otel practices [airflow]

2025-03-19 Thread via GitHub
xBis7 commented on code in PR #43941: URL: https://github.com/apache/airflow/pull/43941#discussion_r2004196012 ## airflow/jobs/scheduler_job_runner.py: ## @@ -966,6 +995,157 @@ def _update_dag_run_state_for_paused_dags(self, session: Session = NEW_SESSION) except Excep

Re: [PR] Provide an alternative OpenTelemetry implementation for traces that follows standard otel practices [airflow]

2025-03-19 Thread via GitHub
xBis7 commented on code in PR #43941: URL: https://github.com/apache/airflow/pull/43941#discussion_r2004192149 ## airflow/executors/base_executor.py: ## @@ -401,6 +409,33 @@ def trigger_tasks(self, open_slots: int) -> None: workloads.append(item)

Re: [PR] Provide an alternative OpenTelemetry implementation for traces that follows standard otel practices [airflow]

2025-03-19 Thread via GitHub
xBis7 commented on code in PR #43941: URL: https://github.com/apache/airflow/pull/43941#discussion_r2004182847 ## airflow/metrics/validators.py: ## @@ -82,7 +82,8 @@ class MetricNameLengthExemptionWarning(Warning): } BACK_COMPAT_METRIC_NAMES: set[Pattern[str]] = {re2.compile(n

Re: [PR] Provide an alternative OpenTelemetry implementation for traces that follows standard otel practices [airflow]

2025-03-19 Thread via GitHub
xBis7 commented on code in PR #43941: URL: https://github.com/apache/airflow/pull/43941#discussion_r2004178335 ## tests/jobs/test_scheduler_job.py: ## @@ -2367,6 +2370,194 @@ def test_runs_are_created_after_max_active_runs_was_reached(self, dag_maker, ses dag_runs = Da

Re: [I] AttributeError: module 'airflow.settings' has no attribute 'engine' [airflow]

2025-03-19 Thread via GitHub
kaxil commented on issue #47942: URL: https://github.com/apache/airflow/issues/47942#issuecomment-2736151854 >Related https://github.com/apache/airflow/issues/47706 . While disabling orm access in task-sdk the engine value is deleted from airflow.settings . I think these types of dags will

Re: [PR] Call `init` from auth managers only once [airflow]

2025-03-19 Thread via GitHub
jedcunningham commented on code in PR #47869: URL: https://github.com/apache/airflow/pull/47869#discussion_r2003895423 ## airflow/api_fastapi/auth/managers/simple/simple_auth_manager.py: ## @@ -98,37 +103,47 @@ def get_users() -> list[dict[str, str]]: @staticmethod d

Re: [I] "consuming_dags" and "producing_tasks" do not correct account for Asset.ref [airflow]

2025-03-19 Thread via GitHub
uranusjr commented on issue #47970: URL: https://github.com/apache/airflow/issues/47970#issuecomment-2737644292 Instead of union, we could also resolve the refs lazily when the property is accessed. This should cause a lot fewer compatibility issues; we’ll only need to fix SQL queries and a

Re: [PR] Move FAB related dependencies into FAB provider [airflow]

2025-03-19 Thread via GitHub
vincbeck commented on PR #47958: URL: https://github.com/apache/airflow/pull/47958#issuecomment-2737682793 Looks like we have a dependency of `wtforms` but we do not declare it. I guess we had it before before one of the Flask dependencies was bringing it along? -- This is an automated m

Re: [PR] Set simple auth manager as default [airflow]

2025-03-19 Thread via GitHub
vincbeck commented on code in PR #47691: URL: https://github.com/apache/airflow/pull/47691#discussion_r2004013444 ## Dockerfile.ci: ## @@ -1029,9 +1029,13 @@ function start_api_server_with_examples(){ echo airflow dags reserialize echo "Example dags parsing finish

(airflow) branch main updated (b3080badd11 -> e7e16379b6d)

2025-03-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b3080badd11 Delete asset relations when dag becomes inactive (#47903) add e7e16379b6d Fix code blocks in ex

Re: [PR] Set dag version on expanded tis [airflow]

2025-03-19 Thread via GitHub
jedcunningham merged PR #47953: URL: https://github.com/apache/airflow/pull/47953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] Set simple auth manager as default [airflow]

2025-03-19 Thread via GitHub
aritra24 commented on code in PR #47691: URL: https://github.com/apache/airflow/pull/47691#discussion_r2003985483 ## Dockerfile.ci: ## @@ -1029,9 +1029,13 @@ function start_api_server_with_examples(){ echo airflow dags reserialize echo "Example dags parsing finish

Re: [PR] Introduce API versioning into the Execution API [airflow]

2025-03-19 Thread via GitHub
ashb commented on code in PR #47951: URL: https://github.com/apache/airflow/pull/47951#discussion_r2004003141 ## task-sdk/dev/generate_models.py: ## @@ -80,20 +76,20 @@ def load_config(): return cfg -def generate_file(app: FastAPI): -# The persisted openapi spec wil

  1   2   3   >