[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-30 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r624273293 ## File path: docs/helm-chart/parameters-ref.rst ## @@ -474,6 +537,33 @@ The following tables lists the configurable parameters of the Airflow chart and

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-30 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r624205887 ## File path: chart/tests/test_basic_helm_chart.py ## @@ -36,13 +36,19 @@ def test_basic_deployments(self): 'metadata': 'AA',

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-30 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r624200327 ## File path: chart/tests/test_rbac.py ## @@ -0,0 +1,294 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-30 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r624200016 ## File path: chart/tests/test_basic_helm_chart.py ## @@ -36,13 +36,19 @@ def test_basic_deployments(self): 'metadata': 'AA',

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-30 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r624184513 ## File path: chart/tests/test_rbac.py ## @@ -0,0 +1,294 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-30 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r624182625 ## File path: chart/tests/test_basic_helm_chart.py ## @@ -36,13 +36,19 @@ def test_basic_deployments(self): 'metadata': 'AA',

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-30 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r624180212 ## File path: chart/templates/_helpers.yaml ## @@ -372,6 +391,127 @@ server_tls_key_file = /etc/pgbouncer/server.key {{ (printf "%s-airflow-config"

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623453566 ## File path: chart/tests/test_rbac.py ## @@ -0,0 +1,294 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623449476 ## File path: chart/tests/test_annotations.py ## @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623447730 ## File path: chart/templates/statsd/statsd-serviceaccount.yaml ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623445885 ## File path: chart/values.yaml ## @@ -427,6 +453,20 @@ scheduler: affinity: {} tolerations: [] +# Airflow migration and create user job settings

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623416129 ## File path: chart/templates/_helpers.yaml ## @@ -364,6 +383,105 @@ server_tls_key_file = /etc/pgbouncer/server.key {{ (printf "%s-airflow-config"

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623417179 ## File path: chart/values.yaml ## @@ -427,6 +453,20 @@ scheduler: affinity: {} tolerations: [] +# Airflow migration and create user job settings

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623416129 ## File path: chart/templates/_helpers.yaml ## @@ -364,6 +383,105 @@ server_tls_key_file = /etc/pgbouncer/server.key {{ (printf "%s-airflow-config"

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r62603 ## File path: chart/values.yaml ## @@ -427,6 +453,20 @@ scheduler: affinity: {} tolerations: [] +# Airflow migration and create user job settings