[GitHub] [airflow] potiuk commented on pull request #10708: Make breeeze-complete Google Shell Guide compatible

2020-09-14 Thread GitBox
potiuk commented on pull request #10708: URL: https://github.com/apache/airflow/pull/10708#issuecomment-691865843 Would love to get that one merged :) This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk commented on pull request #10708: Make breeeze-complete Google Shell Guide compatible

2020-09-08 Thread GitBox
potiuk commented on pull request #10708: URL: https://github.com/apache/airflow/pull/10708#issuecomment-689124114 Also only quarantined test failed. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on pull request #10708: Make breeeze-complete Google Shell Guide compatible

2020-09-08 Thread GitBox
potiuk commented on pull request #10708: URL: https://github.com/apache/airflow/pull/10708#issuecomment-688658252 @turbaszek ^^ :) This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] potiuk commented on pull request #10708: Make breeeze-complete Google Shell Guide compatible

2020-09-07 Thread GitBox
potiuk commented on pull request #10708: URL: https://github.com/apache/airflow/pull/10708#issuecomment-688633019 And yeah. The bats tests work just fine and pre-commit fails when any of the tests fail if that's what you asked for (and with the bats-assert extension it's output is really

[GitHub] [airflow] potiuk commented on pull request #10708: Make breeeze-complete Google Shell Guide compatible

2020-09-07 Thread GitBox
potiuk commented on pull request #10708: URL: https://github.com/apache/airflow/pull/10708#issuecomment-688630908 > Look good to me, however, would you mind testing pre-commit just to check that error information will be propagated? We all depend on this in our development flow Not

[GitHub] [airflow] potiuk commented on pull request #10708: Make breeeze-complete Google Shell Guide compatible

2020-09-04 Thread GitBox
potiuk commented on pull request #10708: URL: https://github.com/apache/airflow/pull/10708#issuecomment-687450981 Rebased to the latest asserts and added unit tests for breeze-complete. This is an automated message from the

[GitHub] [airflow] potiuk commented on pull request #10708: Make breeeze-complete Google Shell Guide compatible

2020-09-03 Thread GitBox
potiuk commented on pull request #10708: URL: https://github.com/apache/airflow/pull/10708#issuecomment-686412173 CC: @OmairK -> another example of the "Google Shell Guideline" compliance changes. This is an automated