potiuk commented on pull request #10708: URL: https://github.com/apache/airflow/pull/10708#issuecomment-688630908
> Look good to me, however, would you mind testing pre-commit just to check that error information will be propagated? We all depend on this in our development flow Not sure why pre-commits woudl be affected by this one :). I fixed yesterday an issue with rebuilds failing while running pre-commit (#10785 ) - but it was unrelated and result of fixing "traps" problem (the fix caused that the traps were not overwritten and started to kill non-existing job). I rebased this one and re-run all pre-commits and it seems everything works. BTW, This is the reason I am adding now more and more unit tests for all the bash functions (like in this PR), so I hope we will have much fewer regressions once we have good test coverage. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
