[GitHub] [airflow] samuelkhtu commented on pull request #8942: #8525 Add SQL Branch Operator

2020-06-01 Thread GitBox
samuelkhtu commented on pull request #8942: URL: https://github.com/apache/airflow/pull/8942#issuecomment-637024265 > Nice @samuelkhtu ! Thank you everyone's help! @potiuk @mik-laj @eladkal This is an automated messag

[GitHub] [airflow] samuelkhtu commented on pull request #8942: #8525 Add SQL Branch Operator

2020-05-27 Thread GitBox
samuelkhtu commented on pull request #8942: URL: https://github.com/apache/airflow/pull/8942#issuecomment-634753579 > @samuelkhtu we can do it in a separate PR. This will allow us to build a better git history. Thanks @mik-laj and @eladkal , can someone help and approve this PR? I am

[GitHub] [airflow] samuelkhtu commented on pull request #8942: #8525 Add SQL Branch Operator

2020-05-26 Thread GitBox
samuelkhtu commented on pull request #8942: URL: https://github.com/apache/airflow/pull/8942#issuecomment-633603940 > LGTM. > > One last observation about the file name `sql_branch_operator.py`. By accepting this PR Airflow will have 2 sql related operator files in the core (`check_

[GitHub] [airflow] samuelkhtu commented on pull request #8942: #8525 Add SQL Branch Operator

2020-05-24 Thread GitBox
samuelkhtu commented on pull request #8942: URL: https://github.com/apache/airflow/pull/8942#issuecomment-633279449 Hi @eladkal , Thank you again for the review. The latest commit should address the last set of comments. Please take a look when you have a chance. Thanks.

[GitHub] [airflow] samuelkhtu commented on pull request #8942: #8525 Add SQL Branch Operator

2020-05-21 Thread GitBox
samuelkhtu commented on pull request #8942: URL: https://github.com/apache/airflow/pull/8942#issuecomment-632474847 Hi @eladkal , the PR is ready to review again. Please take a look when you have a chance. Thanks! This is an