vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-575240752
> Hello @vsoch -> I am sorry you have this extra work, but unfortunately it
happens and this is part of our normal process. This
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-575113703
The PR has been open for so long (and a few of your maintainers updated it
after the initial submission) and this has led to the
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-571165087
To be clear, I did not edit those files. Your team has taken so long to
review that those conflicts arose. As I stated earlier,
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-564923592
See my previous comment. https://github.com/apache/airflow/pull/4846
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-564847214
I thought so too!
This is an automated message from the Apache
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-540662329
I'm not sure I can do those merge conflicts - I don't know enough about how
airflow works to do it correctly (and I'l likely mess
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-540612745
I kept updating the PR (mostly with linting and rebase with master), all was
green, but it was never reviewed or given attention,
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-527568363
It's okay airflow bot, I thought it would be useful, but I don't see any
pressing need from the community, so it's okay to close
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-494732901
Green again!
This is an automated message from the Apache Git
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-486278391
Awesome! Just changed it, and ran flake8 locally so hopefully the linting
issues are gone.
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-485852639
I get the opposite running locally for the flake8, when I add a newline it
tells me:
```
$ flake8
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-484529570
Happy to fix, and I'll note that their weren't conflicts before (the PR has
been sitting for a while)
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-475910707
wow what a beautiful integration! I didn't know codecov had come so far (I
remember it just spitting out a txt report after
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-475906977
Thank you!
This is an automated message from the Apache Git
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-474939864
Random testing failure?
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-473594009
I don't think I understand this mock setup enough to be able to do this,
sorry.
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-473593915
I still don't understand how I can test force pull (or other similar
functions) that require Singularity on the backend. It's not
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-472682900
Sure, what tests would you like to see?
This is an automated
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-472598291
@mik-laj I don't know how to fix this, Travis seems to always have one test
that fails. I'm not sure how to proceed, so I guess I
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-472450355
Resolved conflict - another module was added in setup.py on the same line as
singularity, I combined into one line.
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-472449465
is this a real fail or a travis blip?
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-472213759
okay, flake8 is green! Phew.
This is an automated message from
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-472208249
Strange, now it's telling me differently about the imports of Callable and
Pod, etc.
```
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-472199552
Here are the linting issues - strange that there are files not touched in
this pull request, I will fix these too.
```bash
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-472197325
oops - so sorry @mik-laj ! I didn't check the CI to see that linting failed.
I'll get that fixed up.
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-471228537
You're right the Client imported wasn't used - so I removed it in the test
file.
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-471228302
I will not learn blindly adding your code - I looked over the example that
you provided and used it to edit the
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-471228204
squashed commits
This is an automated message from the Apache Git
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-471227953
Oh this is awesome! Let me see if I can edit this into what I have open.
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-470710098
I'm not sure I understand - is the idea of "mock" that it doesn't actually
call Singularity (on the cost) to create the instance?
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-470691659
How are we supposed to test the operator without having Singularity
installed?
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for
airflow
URL: https://github.com/apache/airflow/pull/4846#issuecomment-470208501
hey @mik-laj ! Thanks for your quick feedback, I created and linked the Jira
issue, and I'll get the fixes pushed up in a bit
32 matches
Mail list logo
