Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-04-09 Thread via GitHub
howardyoo commented on PR #37989: URL: https://github.com/apache/airflow/pull/37989#issuecomment-2046369109 > One more comment here - I think we need to clearly describe what is the relation between the provider's traces that plugin interface provides - in the future when we merge the

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-04-09 Thread via GitHub
potiuk commented on PR #37989: URL: https://github.com/apache/airflow/pull/37989#issuecomment-2044674798 One more comment here - I think we need to clearly describe what is the relation between the provider's traces that plugin interface provides - in the future when we merge the #37752 .

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-04-09 Thread via GitHub
potiuk commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1557402237 ## airflow/providers/opentelemetry/hooks/otel.py: ## @@ -0,0 +1,421 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-04-09 Thread via GitHub
potiuk commented on PR #37989: URL: https://github.com/apache/airflow/pull/37989#issuecomment-2044661400 It looks good in general - I left a few comments where bad rebase/squash occured. Tests and Docs need to be fixed of course. I think we need to add more description (separate

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-04-09 Thread via GitHub
potiuk commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1557376553 ## pyproject.toml: ## @@ -100,49 +100,674 @@ dynamic = ["version", "optional-dependencies", "dependencies"] # # all, all-core, all-dbs, devel-all, devel-ci # -#

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-04-09 Thread via GitHub
potiuk commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1557377793 ## INSTALL: ## @@ -262,39 +262,24 @@ Those extras are available as regular core airflow extras - they install optiona # START CORE EXTRAS HERE -aiobotocore,

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-04-09 Thread via GitHub
potiuk commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1557369269 ## airflow/models/trigger.py: ## @@ -169,14 +169,16 @@ def clean_unused(cls, session: Session = NEW_SESSION) -> None: .values(trigger_id=None)

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-23 Thread via GitHub
howardyoo commented on PR #37989: URL: https://github.com/apache/airflow/pull/37989#issuecomment-2016507042 > The PR was broken with around 100 unrelated commits, I just squashed all related commits into a single commit and rebased `main` as it was impossible to review the PR. Could you

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-23 Thread via GitHub
howardyoo commented on PR #37989: URL: https://github.com/apache/airflow/pull/37989#issuecomment-2016506404 > The PR was broken with around 100 unrelated commits, I just squashed all related commits into a single commit and rebased `main` as it was impossible to review the PR. Could you

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-22 Thread via GitHub
hussein-awala commented on PR #37989: URL: https://github.com/apache/airflow/pull/37989#issuecomment-2016109464 The PR was broken with around 100 unrelated commits, I just squashed all related commits into a single commit and rebased `main` as it was impossible to review the PR. Could you

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
howardyoo commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524155170 ## tests/providers/opentelemetry/hooks/test_opentelemetry.py: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
howardyoo commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524154829 ## pyproject.toml: ## @@ -865,6 +865,10 @@ openlineage = [ # source: airflow/providers/openlineage/provider.yaml opensearch = [ # source:

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
howardyoo commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524153753 ## docs/apache-airflow-providers-opentelemetry/connections/opentelemetry.rst: ## @@ -0,0 +1,40 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
howardyoo commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524152601 ## airflow/providers/opentelemetry/plugins/otel_listener.py: ## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
howardyoo commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524150994 ## airflow/providers/opentelemetry/models.py: ## @@ -0,0 +1,82 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
howardyoo commented on PR #37989: URL: https://github.com/apache/airflow/pull/37989#issuecomment-1996309777 Thanks! :-) On Wed, Mar 13, 2024 at 7:37 PM Jarek Potiuk ***@***.***> wrote: > Finally made first pass. > > — > Reply to this email directly, view it on

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
potiuk commented on PR #37989: URL: https://github.com/apache/airflow/pull/37989#issuecomment-1996188719 Finally made first pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
potiuk commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524067179 ## tests/providers/opentelemetry/hooks/test_opentelemetry.py: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
potiuk commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524066862 ## pyproject.toml: ## @@ -865,6 +865,10 @@ openlineage = [ # source: airflow/providers/openlineage/provider.yaml opensearch = [ # source:

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
potiuk commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524064397 ## docs/apache-airflow-providers-opentelemetry/connections/opentelemetry.rst: ## @@ -0,0 +1,40 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
potiuk commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524062305 ## airflow/providers/opentelemetry/plugins/otel_listener.py: ## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-13 Thread via GitHub
potiuk commented on code in PR #37989: URL: https://github.com/apache/airflow/pull/37989#discussion_r1524059917 ## airflow/providers/opentelemetry/models.py: ## @@ -0,0 +1,82 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[PR] [AIP-49] Airflow OpenTelemetry Provider [airflow]

2024-03-07 Thread via GitHub
howardyoo opened a new pull request, #37989: URL: https://github.com/apache/airflow/pull/37989 closes #37628 --- Airflow OpenTelemetry Provider is a part of the Airflow OpenTelemetry feature that will allow DAG writers to emit opentelemetry metrics and