Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-05-27 Thread via GitHub
boring-cyborg[bot] commented on PR #38398: URL: https://github.com/apache/airflow/pull/38398#issuecomment-2133099237 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-05-27 Thread via GitHub
potiuk merged PR #38398: URL: https://github.com/apache/airflow/pull/38398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-05-27 Thread via GitHub
potiuk commented on PR #38398: URL: https://github.com/apache/airflow/pull/38398#issuecomment-2133098645 > LGTM I just rebased the branch. Lets confirm CI is green Looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-04-26 Thread via GitHub
molcay commented on PR #38398: URL: https://github.com/apache/airflow/pull/38398#issuecomment-2079000366 LGTM > Just a small thing: it can be good to squash the commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-04-03 Thread via GitHub
jalengg commented on code in PR #38398: URL: https://github.com/apache/airflow/pull/38398#discussion_r1550940677 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name: str) -> str:

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-04-03 Thread via GitHub
jalengg commented on code in PR #38398: URL: https://github.com/apache/airflow/pull/38398#discussion_r1550939930 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name: str) -> str:

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-04-03 Thread via GitHub
eladkal commented on code in PR #38398: URL: https://github.com/apache/airflow/pull/38398#discussion_r1549553297 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name: str) -> str:

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-03-27 Thread via GitHub
jalengg commented on code in PR #38398: URL: https://github.com/apache/airflow/pull/38398#discussion_r1542149732 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name: str) -> str:

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-03-27 Thread via GitHub
jalengg commented on code in PR #38398: URL: https://github.com/apache/airflow/pull/38398#discussion_r1540561139 ## tests/providers/google/cloud/hooks/test_gcs.py: ## @@ -565,6 +565,20 @@ def test_object_get_md5hash(self, mock_service): assert response ==

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-03-26 Thread via GitHub
amoghrajesh commented on code in PR #38398: URL: https://github.com/apache/airflow/pull/38398#discussion_r1538658019 ## tests/providers/google/cloud/hooks/test_gcs.py: ## @@ -565,6 +565,20 @@ def test_object_get_md5hash(self, mock_service): assert response ==

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-03-22 Thread via GitHub
jalengg commented on code in PR #38398: URL: https://github.com/apache/airflow/pull/38398#discussion_r1536565254 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name: str) -> str:

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-03-22 Thread via GitHub
dirrao commented on code in PR #38398: URL: https://github.com/apache/airflow/pull/38398#discussion_r1536551567 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name: str) -> str: