Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro merged PR #38423: URL: https://github.com/apache/airflow/pull/38423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609730866 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -213,6 +216,21 @@ def format_url(host: str) -> str: return host +def

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609729670 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
utkarsharma2 commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609710790 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -213,6 +216,21 @@ def format_url(host: str) -> str: return host +def

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
utkarsharma2 commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609709279 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609684585 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -388,16 +407,17 @@ def _es_read(self, log_id: str, offset: int | str) -> ElasticSearchResponse

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609681260 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609681260 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609678726 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -213,6 +216,21 @@ def format_url(host: str) -> str: return host +def

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
sunank200 commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609636322 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
utkarsharma2 commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609628899 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -213,6 +216,21 @@ def format_url(host: str) -> str: return host +def

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
utkarsharma2 commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609617108 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
utkarsharma2 commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609617108 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
utkarsharma2 commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609619659 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
utkarsharma2 commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609617108 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
utkarsharma2 commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609617108 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
ephraimbuddy commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609541430 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
ephraimbuddy commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609533227 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -213,6 +216,21 @@ def format_url(host: str) -> str: return host +def

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-08 Thread via GitHub
eladkal commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1594433582 ## airflow/providers/elasticsearch/provider.yaml: ## @@ -159,10 +159,19 @@ config: index_patterns: description: | Comma separated list of

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-04-04 Thread via GitHub
jedcunningham commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1552066975 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -213,6 +218,21 @@ def format_url(host: str) -> str: return host +def

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-04-04 Thread via GitHub
jedcunningham commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1552066248 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -153,6 +154,9 @@ def __init__( host: str = "http://localhost:9200;,

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-04-04 Thread via GitHub
jedcunningham commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1552064440 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -213,6 +218,21 @@ def format_url(host: str) -> str: return host +def

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-04-04 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1552034125 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -213,6 +218,21 @@ def format_url(host: str) -> str: return host +def

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-04-04 Thread via GitHub
jedcunningham commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1552007608 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -372,12 +392,15 @@ def _format_msg(self, hit: Hit): # Just a safe-guard to preserve

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-04-04 Thread via GitHub
jedcunningham commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1551866970 ## airflow/providers/elasticsearch/provider.yaml: ## @@ -158,10 +158,19 @@ config: index_patterns: description: | Comma separated

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-04-04 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1551811192 ## airflow/providers/elasticsearch/provider.yaml: ## @@ -158,10 +158,19 @@ config: index_patterns: description: | Comma separated list

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-04-04 Thread via GitHub
jedcunningham commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1551795357 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -372,12 +397,15 @@ def _format_msg(self, hit: Hit): # Just a safe-guard to preserve

[PR] Make elastic search index_pattern more configurable [airflow]

2024-03-23 Thread via GitHub
pankajastro opened a new pull request, #38423: URL: https://github.com/apache/airflow/pull/38423 closes: https://github.com/apache/airflow/issues/37999 --- **^ Add meaningful description above** Read the **[Pull Request