Re: [PR] Use async db calls in WorkflowTrigger [airflow]

Taragolis merged PR #38689: URL: https://github.com/apache/airflow/pull/38689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use async db calls in WorkflowTrigger [airflow]

stevenschaerer commented on code in PR #38689: URL: https://github.com/apache/airflow/pull/38689#discussion_r1552241684 ## airflow/triggers/external_task.py: ## @@ -98,44 +99,43 @@ async def run(self) -> typing.AsyncIterator[TriggerEvent]: """Check periodically tasks,

Re: [PR] Use async db calls in WorkflowTrigger [airflow]

Taragolis commented on code in PR #38689: URL: https://github.com/apache/airflow/pull/38689#discussion_r1552121352 ## airflow/triggers/external_task.py: ## @@ -98,44 +99,43 @@ async def run(self) -> typing.AsyncIterator[TriggerEvent]: """Check periodically tasks, task

Re: [PR] Use async db calls in WorkflowTrigger [airflow]

stevenschaerer commented on PR #38689: URL: https://github.com/apache/airflow/pull/38689#issuecomment-2034640475 > I don’t think we can just remove TaskStateTrigger, but let’s deprecate it for future removal. > > It would also be a good idea to implement an version of `_get_count` to

Re: [PR] Use async db calls in WorkflowTrigger [airflow]

stevenschaerer commented on code in PR #38689: URL: https://github.com/apache/airflow/pull/38689#discussion_r1549765130 ## tests/triggers/test_external_task.py: ## @@ -438,3 +464,12 @@ def test_serialization(self): "execution_dates": [timezone.datetime(2022, 1,

Re: [PR] Use async db calls in WorkflowTrigger [airflow]

stevenschaerer commented on code in PR #38689: URL: https://github.com/apache/airflow/pull/38689#discussion_r1549764466 ## tests/triggers/test_external_task.py: ## @@ -438,3 +464,12 @@ def test_serialization(self): "execution_dates": [timezone.datetime(2022, 1,

Re: [PR] Use async db calls in WorkflowTrigger [airflow]

Taragolis commented on code in PR #38689: URL: https://github.com/apache/airflow/pull/38689#discussion_r1549266494 ## tests/triggers/test_external_task.py: ## @@ -438,3 +464,12 @@ def test_serialization(self): "execution_dates": [timezone.datetime(2022, 1, 1)],

Re: [PR] Use async db calls in WorkflowTrigger [airflow]

hussein-awala commented on PR #38689: URL: https://github.com/apache/airflow/pull/38689#issuecomment-206828 Also some async features are only available in sqlalchemy 2.0, so maybe we need to focus on this migration first. -- This is an automated message from the Apache Git Service.

Re: [PR] Use async db calls in WorkflowTrigger [airflow]

hussein-awala commented on PR #38689: URL: https://github.com/apache/airflow/pull/38689#issuecomment-205138 > I don’t think we can just remove TaskStateTrigger, but let’s deprecate it for future removal. > > > > It would also be a good idea to implement an version of

Re: [PR] Use async db calls in WorkflowTrigger [airflow]

uranusjr commented on PR #38689: URL: https://github.com/apache/airflow/pull/38689#issuecomment-2033293112 I don’t think we can just remove TaskStateTrigger, but let’s deprecate it for future removal. It would also be a good idea to implement an version of `_get_count` to use the

[PR] Use async db calls in WorkflowTrigger [airflow]

stevenschaerer opened a new pull request, #38689: URL: https://github.com/apache/airflow/pull/38689 This closes: #38672 I opted to slightly extend some existing unit tests rather than write mostly identical new ones. If the `@sync_to_async` decorator and the `await`s before