Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-05-28 Thread via GitHub
TJaniF commented on PR #38902: URL: https://github.com/apache/airflow/pull/38902#issuecomment-2134635772 @rightx2 That is interesting. I just tried that and for me the map index values from the first run "stick", but maybe I misunderstood what you are doing :) This is what I tried:

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-05-28 Thread via GitHub
rightx2 commented on PR #38902: URL: https://github.com/apache/airflow/pull/38902#issuecomment-2134469117 I wonder what I've experienced is same type of the problem above: 1. clear dynnamic mapped tasks 2. all dynamic mapped tasks go into state of running 3. Force to set dag run

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-15 Thread via GitHub
Lee-W merged PR #38902: URL: https://github.com/apache/airflow/pull/38902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-12 Thread via GitHub
RNHTTR commented on code in PR #38902: URL: https://github.com/apache/airflow/pull/38902#discussion_r1562596410 ## airflow/models/taskinstance.py: ## @@ -2714,18 +2714,29 @@ def signal_handler(signum, frame): previous_state=TaskInstanceState.QUEUED,

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-12 Thread via GitHub
RNHTTR commented on code in PR #38902: URL: https://github.com/apache/airflow/pull/38902#discussion_r1562594872 ## airflow/models/taskinstance.py: ## @@ -2714,18 +2714,29 @@ def signal_handler(signum, frame): previous_state=TaskInstanceState.QUEUED,

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-12 Thread via GitHub
uranusjr commented on code in PR #38902: URL: https://github.com/apache/airflow/pull/38902#discussion_r1562406985 ## airflow/models/taskinstance.py: ## @@ -2714,18 +2714,29 @@ def signal_handler(signum, frame): previous_state=TaskInstanceState.QUEUED,

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-12 Thread via GitHub
kaxil commented on code in PR #38902: URL: https://github.com/apache/airflow/pull/38902#discussion_r1562401551 ## airflow/models/taskinstance.py: ## @@ -2714,18 +2714,29 @@ def signal_handler(signum, frame): previous_state=TaskInstanceState.QUEUED,

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-12 Thread via GitHub
ashb commented on code in PR #38902: URL: https://github.com/apache/airflow/pull/38902#discussion_r1562367870 ## airflow/models/taskinstance.py: ## @@ -2714,18 +2714,29 @@ def signal_handler(signum, frame): previous_state=TaskInstanceState.QUEUED,

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-12 Thread via GitHub
TJaniF commented on PR #38902: URL: https://github.com/apache/airflow/pull/38902#issuecomment-2051345427 @uranusjr thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-12 Thread via GitHub
uranusjr commented on PR #38902: URL: https://github.com/apache/airflow/pull/38902#issuecomment-2051246536 This should fix thingsā€¦ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-11 Thread via GitHub
TJaniF commented on PR #38902: URL: https://github.com/apache/airflow/pull/38902#issuecomment-2049927602 > Need to fix tests Sorry silly question but for `breeze testing non-db-tests --parallel-test-types "Core"` which I think runs my two new tests I get: ```text

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-11 Thread via GitHub
TJaniF commented on code in PR #38902: URL: https://github.com/apache/airflow/pull/38902#discussion_r1560866337 ## airflow/models/taskinstance.py: ## @@ -2715,29 +2727,26 @@ def signal_handler(signum, frame): # Execute the task with

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-11 Thread via GitHub
TJaniF commented on code in PR #38902: URL: https://github.com/apache/airflow/pull/38902#discussion_r1560866337 ## airflow/models/taskinstance.py: ## @@ -2715,29 +2727,26 @@ def signal_handler(signum, frame): # Execute the task with

Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

2024-04-10 Thread via GitHub
uranusjr commented on code in PR #38902: URL: https://github.com/apache/airflow/pull/38902#discussion_r1560385357 ## airflow/models/taskinstance.py: ## @@ -2715,29 +2727,26 @@ def signal_handler(signum, frame): # Execute the task with