Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-30 Thread via GitHub
Lee-W merged PR #37307: URL: https://github.com/apache/airflow/pull/37307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-26 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1581639781 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -135,119 +170,106 @@ def upsert( **kwargs, ) -@staticmethod +def

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-26 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1581639150 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -135,119 +170,132 @@ def upsert( **kwargs, ) -@staticmethod +def

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-26 Thread via GitHub
sunank200 commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1581266062 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -135,119 +170,106 @@ def upsert( **kwargs, ) -@staticmethod +def

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-26 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1580869413 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,73 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-26 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1580864264 ## airflow/providers/pinecone/CHANGELOG.rst: ## @@ -20,6 +20,36 @@ Changelog - +2.0.0 +. + +Breaking changes + + +.. warning:: +

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-26 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1580864264 ## airflow/providers/pinecone/CHANGELOG.rst: ## @@ -20,6 +20,36 @@ Changelog - +2.0.0 +. + +Breaking changes + + +.. warning:: +

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-26 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1580860624 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,73 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-26 Thread via GitHub
Lee-W commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1580751492 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,73 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-25 Thread via GitHub
sunank200 commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1579128144 ## airflow/providers/pinecone/CHANGELOG.rst: ## @@ -20,6 +20,36 @@ Changelog - +2.0.0 +. + +Breaking changes + + +.. warning:: +

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-25 Thread via GitHub
sunank200 commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1579126340 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,73 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-25 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1579077234 ## airflow/providers/pinecone/provider.yaml: ## @@ -45,7 +45,7 @@ dependencies: # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-24 Thread via GitHub
eladkal commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1578266977 ## airflow/providers/pinecone/provider.yaml: ## @@ -45,7 +45,7 @@ dependencies: # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-24 Thread via GitHub
rawwar commented on PR #37307: URL: https://github.com/apache/airflow/pull/37307#issuecomment-2075351057 @sunank200 , @Lee-W, Do you have any more feedback for the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-18 Thread via GitHub
Lee-W commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1570128288 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -135,119 +170,132 @@ def upsert( **kwargs, ) -@staticmethod +def

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-16 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1567582624 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -135,119 +170,106 @@ def upsert( **kwargs, ) -@staticmethod +def

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-16 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1567554452 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,73 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-16 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1567554452 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,73 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-16 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1567536996 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -135,119 +170,106 @@ def upsert( **kwargs, ) -@staticmethod +def

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-16 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1567525149 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,73 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-16 Thread via GitHub
Lee-W commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1567138786 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,73 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-15 Thread via GitHub
sunank200 commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1566585987 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -135,119 +170,106 @@ def upsert( **kwargs, ) -@staticmethod +def

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-15 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1566550167 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,80 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-15 Thread via GitHub
Taragolis commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1566143859 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,80 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-15 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1565860151 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,80 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-15 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1565860151 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,80 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field

Re: [PR] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-15 Thread via GitHub
sunank200 commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1565811272 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -64,43 +69,80 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field