[GitHub] [airflow] potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3]

2019-03-29 Thread GitBox
potiuk commented on a change in pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow Docker image [Step 1/3] URL: https://github.com/apache/airflow/pull/4936#discussion_r270425445 ## File path: setup.py ## @@ -252,7 +253,7 @@ def

[GitHub] [airflow] potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-29 Thread GitBox
potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#issuecomment-478016580 @fokko @ashb -> I pushed the latest version with pretty much all comments applied (except setup.py). There is one

[GitHub] [airflow] milton0825 commented on issue #5002: [AIRFLOW-XXX] Set inside docker env

2019-03-29 Thread GitBox
milton0825 commented on issue #5002: [AIRFLOW-XXX] Set inside docker env URL: https://github.com/apache/airflow/pull/5002#issuecomment-478026964 @ashb do we need to rollout this first as we will need to build the airflow image first?

[GitHub] [airflow] cixuuz commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-03-29 Thread GitBox
cixuuz commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-478032660 Yes. This could be a small part of a big change. I am thinking how to discuss this further. I guess maybe bring

[GitHub] [airflow] bryanyang0528 opened a new pull request #5004: [AIRFLOW-4187]pass conn_id to httphook and add tests

2019-03-29 Thread GitBox
bryanyang0528 opened a new pull request #5004: [AIRFLOW-4187]pass conn_id to httphook and add tests URL: https://github.com/apache/airflow/pull/5004 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-4187) Slack Webhook Operator do not pass conn_id to its parent class

2019-03-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805085#comment-16805085 ] ASF GitHub Bot commented on AIRFLOW-4187: - bryanyang0528 commented on pull request #5004:

[jira] [Updated] (AIRFLOW-3925) Don't pull docker-images on pretest

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3925: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Don't pull

[jira] [Updated] (AIRFLOW-3884) Doc checker does accept warnings

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3884: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Doc checker does

[jira] [Updated] (AIRFLOW-4000) Attempting to import variables without specifying a file ends with a server error

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4000: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Attempting to import

[jira] [Updated] (AIRFLOW-3699) Speed up Flake8

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3699: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Speed up Flake8 >

[jira] [Updated] (AIRFLOW-3866) Run docker-compose with quiet flag

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3866: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Run docker-compose

[jira] [Updated] (AIRFLOW-3475) Refactor: Move ImportError out of models.py

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3475: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Refactor: Move

[jira] [Updated] (AIRFLOW-3730) Improper use of logs mechanisms.

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3730: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Improper use of logs

[jira] [Updated] (AIRFLOW-3862) Check types with mypy

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3862: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Check types with mypy

[jira] [Updated] (AIRFLOW-3474) Refactor: Move SlaMiss out of models.py

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3474: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Refactor: Move SlaMiss

[jira] [Updated] (AIRFLOW-3811) Automatic generation of API Reference

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3811: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Automatic generation

[jira] [Commented] (AIRFLOW-4173) Improve scheduler performance by avoid Unnecessary actions in SchedulerJob.process_file()

2019-03-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805005#comment-16805005 ] ASF subversion and git services commented on AIRFLOW-4173: -- Commit

[GitHub] [airflow] mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style

2019-03-29 Thread GitBox
mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style URL: https://github.com/apache/airflow/pull/4823#discussion_r270422641 ## File path: airflow/www/templates/airflow/ti_log.html ## @@ -32,9 +32,17 @@ {{ title }} {% for log

[jira] [Commented] (AIRFLOW-4117) Travis CI uses multi-stage Docker image to run tests

2019-03-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805014#comment-16805014 ] ASF GitHub Bot commented on AIRFLOW-4117: - potiuk commented on pull request #4938:

[GitHub] [airflow] cixuuz commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-03-29 Thread GitBox
cixuuz commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-478028765 The AIP-16 is more like the interface refactor. > it is worth extract common logic to a separate place and

[GitHub] [airflow] bryanyang0528 commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table

2019-03-29 Thread GitBox
bryanyang0528 commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table URL: https://github.com/apache/airflow/pull/4996#discussion_r270459535 ## File path: airflow/contrib/hooks/aws_athena_hook.py ## @@ -148,3 +156,105 @@ def

[GitHub] [airflow] bryanyang0528 commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table

2019-03-29 Thread GitBox
bryanyang0528 commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table URL: https://github.com/apache/airflow/pull/4996#discussion_r270459535 ## File path: airflow/contrib/hooks/aws_athena_hook.py ## @@ -148,3 +156,105 @@ def

[GitHub] [airflow] bryanyang0528 commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table

2019-03-29 Thread GitBox
bryanyang0528 commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table URL: https://github.com/apache/airflow/pull/4996#discussion_r270458298 ## File path: airflow/contrib/hooks/aws_athena_hook.py ## @@ -148,3 +156,105 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class

2019-03-29 Thread GitBox
ashb commented on a change in pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class URL: https://github.com/apache/airflow/pull/5004#discussion_r270466069 ## File path: airflow/contrib/hooks/slack_webhook_hook.py ## @@ -95,6

[GitHub] [airflow] mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style

2019-03-29 Thread GitBox
mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style URL: https://github.com/apache/airflow/pull/4823#discussion_r270471430 ## File path: airflow/www/templates/airflow/graph.html ## @@ -43,37 +51,36 @@ - +

[jira] [Updated] (AIRFLOW-3685) Move licence header check to pre-test stage

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3685: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Move licence header

[GitHub] [airflow] bryanyang0528 commented on a change in pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class

2019-03-29 Thread GitBox
bryanyang0528 commented on a change in pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class URL: https://github.com/apache/airflow/pull/5004#discussion_r270492480 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py

[GitHub] [airflow] bryanyang0528 commented on a change in pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class

2019-03-29 Thread GitBox
bryanyang0528 commented on a change in pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class URL: https://github.com/apache/airflow/pull/5004#discussion_r270492480 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py

[GitHub] [airflow] milton0825 commented on issue #5003: [AIRFLOW-XXX] 1-setup-env.sh should only run in docker

2019-03-29 Thread GitBox
milton0825 commented on issue #5003: [AIRFLOW-XXX] 1-setup-env.sh should only run in docker URL: https://github.com/apache/airflow/pull/5003#issuecomment-478092195 tests passed in: https://travis-ci.org/milton0825/airflow/builds/513064124

[GitHub] [airflow] potiuk closed pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-29 Thread GitBox
potiuk closed pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style

2019-03-29 Thread GitBox
mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style URL: https://github.com/apache/airflow/pull/4823#discussion_r270426229 ## File path: airflow/www/static/css/_mixins.scss ## @@ -0,0 +1,38 @@ +/** +* Licensed to the Apache Software

[GitHub] [airflow] potiuk opened a new pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-03-29 Thread GitBox
potiuk opened a new pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938 ! Note to reviewer: Please review only the last commit (use commits section above). This change is based

[GitHub] [airflow] ashb commented on issue #5002: [AIRFLOW-XXX] Set inside docker env

2019-03-29 Thread GitBox
ashb commented on issue #5002: [AIRFLOW-XXX] Set inside docker env URL: https://github.com/apache/airflow/pull/5002#issuecomment-478032172 This docker file is what `apache/airflow` on docker hub is, so I think we should keep it :D

[jira] [Updated] (AIRFLOW-3490) BigQueryHook's Ability to Patch Table/View

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3490: --- Fix Version/s: (was: 2.0.0) 1.10.3 > BigQueryHook's Ability

[jira] [Assigned] (AIRFLOW-4120) SLA of zero timedelta is not respected

2019-03-29 Thread Simon Poortman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Poortman reassigned AIRFLOW-4120: --- Assignee: S. Poortman19-88 (was: Simon Poortman) Simon is the best I shoot ya >

[jira] [Assigned] (AIRFLOW-4120) SLA of zero timedelta is not respected

2019-03-29 Thread Simon Poortman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Poortman reassigned AIRFLOW-4120: --- Assignee: Simon Poortman (was: S. Poortman19-88) > SLA of zero timedelta is not

[GitHub] [airflow] bryanyang0528 commented on a change in pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class

2019-03-29 Thread GitBox
bryanyang0528 commented on a change in pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class URL: https://github.com/apache/airflow/pull/5004#discussion_r270492480 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py

[jira] [Commented] (AIRFLOW-3417) Use the platformVersion only for the FARGATE launch type

2019-03-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805240#comment-16805240 ] ASF subversion and git services commented on AIRFLOW-3417: -- Commit

[jira] [Commented] (AIRFLOW-3615) Connection parsed from URI - case-insensitive UNIX socket paths in python 2.7 -> 3.5 (but not in 3.6)

2019-03-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805242#comment-16805242 ] ASF subversion and git services commented on AIRFLOW-3615: -- Commit

[jira] [Commented] (AIRFLOW-4000) Attempting to import variables without specifying a file ends with a server error

2019-03-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805243#comment-16805243 ] ASF subversion and git services commented on AIRFLOW-4000: -- Commit

[GitHub] [airflow] feng-tao merged pull request #5003: [AIRFLOW-XXX] 1-setup-env.sh should only run in docker

2019-03-29 Thread GitBox
feng-tao merged pull request #5003: [AIRFLOW-XXX] 1-setup-env.sh should only run in docker URL: https://github.com/apache/airflow/pull/5003 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] wwlian commented on a change in pull request #4980: [AIRFLOW-3971] Add Google Cloud Natural Language operators

2019-03-29 Thread GitBox
wwlian commented on a change in pull request #4980: [AIRFLOW-3971] Add Google Cloud Natural Language operators URL: https://github.com/apache/airflow/pull/4980#discussion_r270516978 ## File path: docs/howto/operator/gcp/_partials/prerequisite_tasks.rst ## @@ -0,0 +1,31 @@

[GitHub] [airflow] wwlian commented on a change in pull request #4980: [AIRFLOW-3971] Add Google Cloud Natural Language operators

2019-03-29 Thread GitBox
wwlian commented on a change in pull request #4980: [AIRFLOW-3971] Add Google Cloud Natural Language operators URL: https://github.com/apache/airflow/pull/4980#discussion_r270519489 ## File path: docs/code.rst ## @@ -0,0 +1,574 @@ +.. Licensed to the Apache Software

[GitHub] [airflow] wwlian commented on a change in pull request #4980: [AIRFLOW-3971] Add Google Cloud Natural Language operators

2019-03-29 Thread GitBox
wwlian commented on a change in pull request #4980: [AIRFLOW-3971] Add Google Cloud Natural Language operators URL: https://github.com/apache/airflow/pull/4980#discussion_r270519973 ## File path: docs/howto/operator/gcp/natural_language.rst ## @@ -0,0 +1,179 @@ +..

[GitHub] [airflow] wwlian commented on a change in pull request #4980: [AIRFLOW-3971] Add Google Cloud Natural Language operators

2019-03-29 Thread GitBox
wwlian commented on a change in pull request #4980: [AIRFLOW-3971] Add Google Cloud Natural Language operators URL: https://github.com/apache/airflow/pull/4980#discussion_r270520554 ## File path: docs/howto/operator/gcp/natural_language.rst ## @@ -0,0 +1,179 @@ +..

[GitHub] [airflow] mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style

2019-03-29 Thread GitBox
mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style URL: https://github.com/apache/airflow/pull/4823#discussion_r270429156 ## File path: airflow/www/templates/airflow/graph.html ## @@ -43,37 +51,36 @@ - +

[GitHub] [airflow] mik-laj commented on issue #5002: [AIRFLOW-XXX] Set inside docker env

2019-03-29 Thread GitBox
mik-laj commented on issue #5002: [AIRFLOW-XXX] Set inside docker env URL: https://github.com/apache/airflow/pull/5002#issuecomment-478023542 CC: @potiuk This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] milton0825 commented on issue #5003: [AIRFLOW-XXX] 1-setup-env.sh should only run in docker

2019-03-29 Thread GitBox
milton0825 commented on issue #5003: [AIRFLOW-XXX] 1-setup-env.sh should only run in docker URL: https://github.com/apache/airflow/pull/5003#issuecomment-478029529 @ashb This is an automated message from the Apache Git

[GitHub] [airflow] milton0825 commented on issue #5002: [AIRFLOW-XXX] Set inside docker env

2019-03-29 Thread GitBox
milton0825 commented on issue #5002: [AIRFLOW-XXX] Set inside docker env URL: https://github.com/apache/airflow/pull/5002#issuecomment-478031076 I see let's push out https://github.com/apache/airflow/pull/5003 then. Should we remote this Dockerfile since it is not used by CI? I can

[GitHub] [airflow] potiuk commented on issue #5003: [AIRFLOW-XXX] 1-setup-env.sh should only run in docker

2019-03-29 Thread GitBox
potiuk commented on issue #5003: [AIRFLOW-XXX] 1-setup-env.sh should only run in docker URL: https://github.com/apache/airflow/pull/5003#issuecomment-478040515 It's really good idea. I've added very similar solution to my WIP PR for multi-staging. The nice thing there is that the image to

[GitHub] [airflow] sumous commented on issue #4969: [AIRFLOW-4148]form_choices in DagRunModelView may be wrong

2019-03-29 Thread GitBox
sumous commented on issue #4969: [AIRFLOW-4148]form_choices in DagRunModelView may be wrong URL: https://github.com/apache/airflow/pull/4969#issuecomment-478016560 Yes! It also happen on kali linux.

[GitHub] [airflow] potiuk commented on issue #4932: [AIRFLOW-3611] Simplified development workflow [Depends on multi-staging]

2019-03-29 Thread GitBox
potiuk commented on issue #4932: [AIRFLOW-3611] Simplified development workflow [Depends on multi-staging] URL: https://github.com/apache/airflow/pull/4932#issuecomment-478020135 @ashb @fokko -> I pushed latest version that is much improved: * mysql installation is now simplified,

[GitHub] [airflow] saurabh3091 opened a new pull request #4992: [AIRFLOW-4172] Fix changes for driver class path option in Spark Subm…

2019-03-29 Thread GitBox
saurabh3091 opened a new pull request #4992: [AIRFLOW-4172] Fix changes for driver class path option in Spark Subm… URL: https://github.com/apache/airflow/pull/4992 This is an automated message from the Apache Git Service.

[GitHub] [airflow] XD-DENG commented on issue #4992: [AIRFLOW-4172] Fix changes for driver class path option in Spark Subm…

2019-03-29 Thread GitBox
XD-DENG commented on issue #4992: [AIRFLOW-4172] Fix changes for driver class path option in Spark Subm… URL: https://github.com/apache/airflow/pull/4992#issuecomment-478024877 Hi @saurabh3091 was this closed by accident? I think we need this change ;)

[GitHub] [airflow] mik-laj commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-03-29 Thread GitBox
mik-laj commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-478033186 I think that it is enough to call the authors of these documents. If they know, they will be able to refer to

[jira] [Updated] (AIRFLOW-4173) Improve scheduler performance by avoid Unnecessary actions in SchedulerJob.process_file()

2019-03-29 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-4173: --- Fix Version/s: 1.10.3 > Improve scheduler performance by avoid Unnecessary actions in >

[jira] [Resolved] (AIRFLOW-4173) Improve scheduler performance by avoid Unnecessary actions in SchedulerJob.process_file()

2019-03-29 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG resolved AIRFLOW-4173. Resolution: Resolved > Improve scheduler performance by avoid Unnecessary actions in >

[GitHub] [airflow] davlum commented on a change in pull request #4952: [AIRFLOW-4008] add envFrom for Kubernetes Executor

2019-03-29 Thread GitBox
davlum commented on a change in pull request #4952: [AIRFLOW-4008] add envFrom for Kubernetes Executor URL: https://github.com/apache/airflow/pull/4952#discussion_r270432837 ## File path: tests/contrib/kubernetes/kubernetes_request_factory/test_kubernetes_request_factory.py

[GitHub] [airflow] ashb commented on issue #5002: [AIRFLOW-XXX] Set inside docker env

2019-03-29 Thread GitBox
ashb commented on issue #5002: [AIRFLOW-XXX] Set inside docker env URL: https://github.com/apache/airflow/pull/5002#issuecomment-478025821 @milton0825 Probably combine this with the change to the script in the same PR This

[GitHub] [airflow] mik-laj commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-03-29 Thread GitBox
mik-laj commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-478031667 I do not want you to create AIP for this change. I just wanted to point out that your change touches areas

[GitHub] [airflow] mik-laj edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-03-29 Thread GitBox
mik-laj edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-478031667 I do not want you to create AIP for this change. I just wanted to point out that your change touches

[GitHub] [airflow] ashb commented on a change in pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class

2019-03-29 Thread GitBox
ashb commented on a change in pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class URL: https://github.com/apache/airflow/pull/5004#discussion_r270463781 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py ## @@

[jira] [Assigned] (AIRFLOW-4131) Allow users to control undefined behavior in templates

2019-03-29 Thread Simon Poortman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Poortman reassigned AIRFLOW-4131: --- Assignee: Simon Poortman (was: Josh Carp) > Allow users to control undefined

[GitHub] [airflow] feng-tao commented on issue #5003: [AIRFLOW-XXX] 1-setup-env.sh should only run in docker

2019-03-29 Thread GitBox
feng-tao commented on issue #5003: [AIRFLOW-XXX] 1-setup-env.sh should only run in docker URL: https://github.com/apache/airflow/pull/5003#issuecomment-478047762 lgtm This is an automated message from the Apache Git Service.

[jira] [Assigned] (AIRFLOW-4120) SLA of zero timedelta is not respected

2019-03-29 Thread Simon Poortman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Poortman reassigned AIRFLOW-4120: --- Assignee: Simon Poortman (was: Markan Patel) > SLA of zero timedelta is not

[jira] [Commented] (AIRFLOW-1526) Add dingding opeartor

2019-03-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805197#comment-16805197 ] ASF subversion and git services commented on AIRFLOW-1526: -- Commit

[jira] [Created] (AIRFLOW-4188) Customized LivySparkOperator

2019-03-29 Thread Debashish Dhar (JIRA)
Debashish Dhar created AIRFLOW-4188: --- Summary: Customized LivySparkOperator Key: AIRFLOW-4188 URL: https://issues.apache.org/jira/browse/AIRFLOW-4188 Project: Apache Airflow Issue Type:

[GitHub] [airflow] ashb merged pull request #4993: [AIRFLOW-4173] Improve scheduler performance by avoid unnecessary actions in SchedulerJob.process_file()

2019-03-29 Thread GitBox
ashb merged pull request #4993: [AIRFLOW-4173] Improve scheduler performance by avoid unnecessary actions in SchedulerJob.process_file() URL: https://github.com/apache/airflow/pull/4993 This is an automated message from the

[GitHub] [airflow] mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style

2019-03-29 Thread GitBox
mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style URL: https://github.com/apache/airflow/pull/4823#discussion_r270422641 ## File path: airflow/www/templates/airflow/ti_log.html ## @@ -32,9 +32,17 @@ {{ title }} {% for log

[GitHub] [airflow] mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style

2019-03-29 Thread GitBox
mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style URL: https://github.com/apache/airflow/pull/4823#discussion_r270429685 ## File path: airflow/www/templates/airflow/ti_log.html ## @@ -32,9 +32,17 @@ {{ title }} {% for log

[GitHub] [airflow] milton0825 opened a new pull request #5002: [AIRFLOW-XXX] Set inside docker env

2019-03-29 Thread GitBox
milton0825 opened a new pull request #5002: [AIRFLOW-XXX] Set inside docker env URL: https://github.com/apache/airflow/pull/5002 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-4172) Invalid parameter --driver-classpath in SparkSubmitHook

2019-03-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805047#comment-16805047 ] ASF GitHub Bot commented on AIRFLOW-4172: - saurabh3091 commented on pull request #4992:

[GitHub] [airflow] davlum commented on a change in pull request #4952: [AIRFLOW-4008] add envFrom for Kubernetes Executor

2019-03-29 Thread GitBox
davlum commented on a change in pull request #4952: [AIRFLOW-4008] add envFrom for Kubernetes Executor URL: https://github.com/apache/airflow/pull/4952#discussion_r270440221 ## File path: tests/contrib/kubernetes/kubernetes_request_factory/test_kubernetes_request_factory.py

[GitHub] [airflow] saurabh3091 closed pull request #4992: [AIRFLOW-4172] Fix changes for driver class path option in Spark Subm…

2019-03-29 Thread GitBox
saurabh3091 closed pull request #4992: [AIRFLOW-4172] Fix changes for driver class path option in Spark Subm… URL: https://github.com/apache/airflow/pull/4992 This is an automated message from the Apache Git Service. To

[GitHub] [airflow] ashb commented on issue #5002: [AIRFLOW-XXX] Set inside docker env

2019-03-29 Thread GitBox
ashb commented on issue #5002: [AIRFLOW-XXX] Set inside docker env URL: https://github.com/apache/airflow/pull/5002#issuecomment-478027924 Oh this might not even help - the image we run in is currently `airflowci/incubator-airflow-ci:latest` - not the one in this repo. So perhaps

[GitHub] [airflow] ashb closed pull request #4984: Revert "[AIRFLOW-3992] 1-setup-env.sh should be re-runable"

2019-03-29 Thread GitBox
ashb closed pull request #4984: Revert "[AIRFLOW-3992] 1-setup-env.sh should be re-runable" URL: https://github.com/apache/airflow/pull/4984 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb commented on issue #4984: Revert "[AIRFLOW-3992] 1-setup-env.sh should be re-runable"

2019-03-29 Thread GitBox
ashb commented on issue #4984: Revert "[AIRFLOW-3992] 1-setup-env.sh should be re-runable" URL: https://github.com/apache/airflow/pull/4984#issuecomment-478032501 Closing in favour of #5003 This is an automated message from

[GitHub] [airflow] mik-laj edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-03-29 Thread GitBox
mik-laj edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-478031667 I do not want you to create AIP for this change. I just wanted to point out that your change touches

[jira] [Commented] (AIRFLOW-3992) run-ci.sh should be re-runable

2019-03-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805074#comment-16805074 ] ASF GitHub Bot commented on AIRFLOW-3992: - ashb commented on pull request #4984: Revert

[GitHub] [airflow] bryanyang0528 commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table

2019-03-29 Thread GitBox
bryanyang0528 commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table URL: https://github.com/apache/airflow/pull/4996#discussion_r270458298 ## File path: airflow/contrib/hooks/aws_athena_hook.py ## @@ -148,3 +156,105 @@ def

[jira] [Updated] (AIRFLOW-3462) Refactor: Move TaskReschedule out of models.py

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3462: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Refactor: Move

[jira] [Updated] (AIRFLOW-1814) Add op_args and op_kwargs in PythonOperator templated fields

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-1814: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Add op_args and

[jira] [Updated] (AIRFLOW-251) Add optional parameter SQL_ALCHEMY_SCHEMA to control schema for metadata repository

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-251: -- Fix Version/s: (was: 2.0.0) 1.10.3 > Add optional parameter

[jira] [Updated] (AIRFLOW-3383) Simplify fernet key rotation

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3383: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Simplify fernet key

[jira] [Updated] (AIRFLOW-3459) Refactor: Move DagPickle out of models.py

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3459: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Refactor: Move

[jira] [Updated] (AIRFLOW-3003) Pull the krb5 image instead of building it

2019-03-29 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3003: --- Fix Version/s: (was: 2.0.0) 1.10.3 > Pull the krb5 image

[GitHub] [airflow] ashb commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style

2019-03-29 Thread GitBox
ashb commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style URL: https://github.com/apache/airflow/pull/4823#discussion_r270467619 ## File path: airflow/www/templates/airflow/graph.html ## @@ -43,37 +51,36 @@ - +

[GitHub] [airflow] zhongjiajie commented on issue #4895: [AIRFLOW-1526] Add dingding hook and operator

2019-03-29 Thread GitBox
zhongjiajie commented on issue #4895: [AIRFLOW-1526] Add dingding hook and operator URL: https://github.com/apache/airflow/pull/4895#issuecomment-478078158 @ashb Thanks :+1: This is an automated message from the Apache Git

[jira] [Commented] (AIRFLOW-4173) Improve scheduler performance by avoid Unnecessary actions in SchedulerJob.process_file()

2019-03-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805004#comment-16805004 ] ASF GitHub Bot commented on AIRFLOW-4173: - ashb commented on pull request #4993: [AIRFLOW-4173]

[GitHub] [airflow] mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style

2019-03-29 Thread GitBox
mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style URL: https://github.com/apache/airflow/pull/4823#discussion_r270422423 ## File path: airflow/www/templates/airflow/graph.html ## @@ -43,37 +51,36 @@ - +

[GitHub] [airflow] saurabh3091 commented on a change in pull request #4992: [AIRFLOW-4172] Fix changes for driver class path option in Spark Subm…

2019-03-29 Thread GitBox
saurabh3091 commented on a change in pull request #4992: [AIRFLOW-4172] Fix changes for driver class path option in Spark Subm… URL: https://github.com/apache/airflow/pull/4992#discussion_r270442148 ## File path: airflow/contrib/hooks/spark_submit_hook.py ## @@ -250,8

[GitHub] [airflow] mik-laj edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-03-29 Thread GitBox
mik-laj edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-478033186 I think that it is enough to call the authors of these documents. If they know, they will be able to

[GitHub] [airflow] mik-laj edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-03-29 Thread GitBox
mik-laj edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-478033186 I think that it is enough to call the authors of these documents. If they know, they will be able to

[GitHub] [airflow] milton0825 closed pull request #5002: [AIRFLOW-XXX] Set inside docker env

2019-03-29 Thread GitBox
milton0825 closed pull request #5002: [AIRFLOW-XXX] Set inside docker env URL: https://github.com/apache/airflow/pull/5002 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] mik-laj edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-03-29 Thread GitBox
mik-laj edited a comment on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-478033186 I think that it is enough to notify the authors of these documents. If they know, they will be able to

[GitHub] [airflow] milton0825 commented on issue #5002: [AIRFLOW-XXX] Set inside docker env

2019-03-29 Thread GitBox
milton0825 commented on issue #5002: [AIRFLOW-XXX] Set inside docker env URL: https://github.com/apache/airflow/pull/5002#issuecomment-478033733 Got it! This is an automated message from the Apache Git Service. To respond

[jira] [Assigned] (AIRFLOW-4148) form_choices in DagRunModelView may be wrong

2019-03-29 Thread Simon Poortman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Poortman reassigned AIRFLOW-4148: --- Assignee: Simon Poortman (was: S. Poortman19-88) > form_choices in

[GitHub] [airflow] feng-tao commented on issue #4983: [AIRFLOW-4163] IntervalCheckOperator supports relative diff.

2019-03-29 Thread GitBox
feng-tao commented on issue #4983: [AIRFLOW-4163] IntervalCheckOperator supports relative diff. URL: https://github.com/apache/airflow/pull/4983#issuecomment-478092832 will take a look. This is an automated message from the

[GitHub] [airflow] codecov-io edited a comment on issue #4708: [AIRFLOW-3888] HA for metastore connection

2019-03-29 Thread GitBox
codecov-io edited a comment on issue #4708: [AIRFLOW-3888] HA for metastore connection URL: https://github.com/apache/airflow/pull/4708#issuecomment-477986178 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4708?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #4708: [AIRFLOW-3888] HA for metastore connection

2019-03-29 Thread GitBox
codecov-io edited a comment on issue #4708: [AIRFLOW-3888] HA for metastore connection URL: https://github.com/apache/airflow/pull/4708#issuecomment-477986178 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4708?src=pr=h1) Report > Merging

  1   2   3   4   >