[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #11627: URL: https://github.com/apache/airflow/pull/11627#issuecomment-715760981 [The Workflow run](https://github.com/apache/airflow/actions/runs/325528369) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] potiuk merged pull request #11791: Use LocalExecutor by default with tmux + Breeze

2020-10-24 Thread GitBox
potiuk merged pull request #11791: URL: https://github.com/apache/airflow/pull/11791 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] duyet commented on pull request #11767: Fix: Removed password if HiveServer2Hook in LDAP or CUSTOM mode

2020-10-24 Thread GitBox
duyet commented on pull request #11767: URL: https://github.com/apache/airflow/pull/11767#issuecomment-715822851 @mik-laj @kaxil Could you please help me to review? This is an automated message from the Apache Git Service.

[airflow] branch master updated (7b89a04 -> 0218bcf)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 7b89a04 Replace io.open with builtin open (#11807) add 0218bcf Use LocalExecutor by default with tmux +

[airflow] branch master updated (7b89a04 -> 0218bcf)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 7b89a04 Replace io.open with builtin open (#11807) add 0218bcf Use LocalExecutor by default with tmux +

[GitHub] [airflow] potiuk commented on pull request #11797: Fix locking issue stopping tasks running with SequentialExecutor

2020-10-24 Thread GitBox
potiuk commented on pull request #11797: URL: https://github.com/apache/airflow/pull/11797#issuecomment-715824117 Cool! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] dimberman commented on pull request #11815: Render k8s yaml for tasks via the Airflow UI

2020-10-24 Thread GitBox
dimberman commented on pull request #11815: URL: https://github.com/apache/airflow/pull/11815#issuecomment-715876436 cc: @ryanahamilton I still have a small bug on getting the button on the DAG view to work (also would love to merge this with those assets you built :) )

[GitHub] [airflow] github-actions[bot] commented on pull request #11465: Add Markdown linting to pre-commit

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #11465: URL: https://github.com/apache/airflow/pull/11465#issuecomment-715876374 [The Workflow run](https://github.com/apache/airflow/actions/runs/325627788) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] potiuk merged pull request #11814: Fix spelling and grammar

2020-10-24 Thread GitBox
potiuk merged pull request #11814: URL: https://github.com/apache/airflow/pull/11814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] github-actions[bot] commented on pull request #11815: Render k8s yaml for tasks via the Airflow UI

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #11815: URL: https://github.com/apache/airflow/pull/11815#issuecomment-715878101 [The Workflow run](https://github.com/apache/airflow/actions/runs/325640704) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] potiuk opened a new issue #11816: [QUARANTINE] Flaky test TestPostClearTaskInstances.test_should_response_200_with_reset_dag_run

2020-10-24 Thread GitBox
potiuk opened a new issue #11816: URL: https://github.com/apache/airflow/issues/11816 Flaky test here: TestPostClearTaskInstances.test_should_response_200_with_reset_dag_run https://github.com/apache/airflow/pull/11809/checks?check_run_id=1301036003#step:6:1336 Looks

[GitHub] [airflow] potiuk opened a new pull request #11817: Fixes flaky test test_should_response_200_with_reset_dag_run

2020-10-24 Thread GitBox
potiuk opened a new pull request #11817: URL: https://github.com/apache/airflow/pull/11817 Sometimes the rows were returned in reverse order. Fixes #11816 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk opened a new pull request #11818: Add links to PyPI packages.

2020-10-24 Thread GitBox
potiuk opened a new pull request #11818: URL: https://github.com/apache/airflow/pull/11818 Same as in #11801 but in provider's packages. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] KulykDmytro edited a comment on issue #11696: WebUI does not have access to pod logs

2020-10-24 Thread GitBox
KulykDmytro edited a comment on issue #11696: URL: https://github.com/apache/airflow/issues/11696#issuecomment-715886117 WebUI should run with serviceAccount which have RBAC permissions on k8s cluster to get logs ```yaml spec.template.spec.serviceAccount: airflow ``` ```yaml

[GitHub] [airflow] KulykDmytro edited a comment on issue #11696: WebUI does not have access to pod logs

2020-10-24 Thread GitBox
KulykDmytro edited a comment on issue #11696: URL: https://github.com/apache/airflow/issues/11696#issuecomment-715886117 WebUI/Scheduler pods should run with serviceAccount which have RBAC permissions on k8s cluster to get logs ```yaml spec.template.spec.serviceAccount: airflow

[GitHub] [airflow] potiuk commented on pull request #11817: Fixes flaky test test_should_response_200_with_reset_dag_run

2020-10-24 Thread GitBox
potiuk commented on pull request #11817: URL: https://github.com/apache/airflow/pull/11817#issuecomment-715894285 @mik-laj - one flaky test less. This is an automated message from the Apache Git Service. To respond to the

[airflow] branch master updated: Add links to PyPI packages. (#11818)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new e4adfd7 Add links to PyPI packages. (#11818)

[airflow] branch master updated (3934ef2 -> e4adfd7)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3934ef2 Remove redundant builtins imports (#11809) add e4adfd7 Add links to PyPI packages. (#11818) No new

[airflow] branch master updated (e4adfd7 -> aacf602)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e4adfd7 Add links to PyPI packages. (#11818) add aacf602 Fix spelling (#11457) No new revisions were added

[airflow] branch master updated (0218bcf -> 4c8e033)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 0218bcf Use LocalExecutor by default with tmux + Breeze (#11791) add 4c8e033 Fix spelling and grammar

[airflow] branch master updated (0218bcf -> 4c8e033)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 0218bcf Use LocalExecutor by default with tmux + Breeze (#11791) add 4c8e033 Fix spelling and grammar

[GitHub] [airflow] potiuk commented on pull request #11801: Add Project URLs for PyPI page

2020-10-24 Thread GitBox
potiuk commented on pull request #11801: URL: https://github.com/apache/airflow/pull/11801#issuecomment-715881997 Nice! Will add it to providers too! This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] KulykDmytro commented on issue #11696: WebUI does not have access to pod logs

2020-10-24 Thread GitBox
KulykDmytro commented on issue #11696: URL: https://github.com/apache/airflow/issues/11696#issuecomment-715886117 WebUI should run with serviceAccount which have RBAC permissions on k8s cluster to get logs ``` ``` ``` --- apiVersion: v1 kind: ServiceAccount metadata:

[GitHub] [airflow] KulykDmytro edited a comment on issue #11696: WebUI does not have access to pod logs

2020-10-24 Thread GitBox
KulykDmytro edited a comment on issue #11696: URL: https://github.com/apache/airflow/issues/11696#issuecomment-715886117 WebUI should run with serviceAccount which have RBAC permissions on k8s cluster to get logs ``` spec.template.spec.serviceAccount: airflow ``` ``` ---

[GitHub] [airflow] KulykDmytro edited a comment on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-24 Thread GitBox
KulykDmytro edited a comment on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-713855548 Another one example on 1.10.12 shows same behavior (join task skipping) for downstream tasks despite of any `trigger_rule` set (`all_done`, `none_failed`,

[GitHub] [airflow] KulykDmytro edited a comment on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-24 Thread GitBox
KulykDmytro edited a comment on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-713721131 Initial issue which seems to be fixed with AIRFLOW-4453 has been returned back (at least in 1.10.12) PR: https://github.com/apache/airflow/pull/7464 so

[GitHub] [airflow] potiuk merged pull request #11457: Fix spelling

2020-10-24 Thread GitBox
potiuk merged pull request #11457: URL: https://github.com/apache/airflow/pull/11457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk merged pull request #11818: Add links to PyPI packages.

2020-10-24 Thread GitBox
potiuk merged pull request #11818: URL: https://github.com/apache/airflow/pull/11818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #11820: Retrieve PR labels from the associated PR

2020-10-24 Thread GitBox
potiuk commented on pull request #11820: URL: https://github.com/apache/airflow/pull/11820#issuecomment-715895118 Works nicely here: In CI: https://github.com/potiuk/airflow/pull/134/checks?check_run_id=1301856214#step:2:595 In CI Build:

[jira] [Commented] (AIRFLOW-2075) Extract and create a data access layer

2020-10-24 Thread Richard Williamson (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220079#comment-17220079 ] Richard Williamson commented on AIRFLOW-2075: - Can we re-open the more general version of

[GitHub] [airflow] potiuk merged pull request #11817: Fixes flaky test test_should_response_200_with_reset_dag_run

2020-10-24 Thread GitBox
potiuk merged pull request #11817: URL: https://github.com/apache/airflow/pull/11817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow] branch master updated: Fix spelling (#11821)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 6ce855a Fix spelling (#11821) 6ce855a is

[GitHub] [airflow] potiuk closed issue #11816: [QUARANTINE] Flaky test TestPostClearTaskInstances.test_should_response_200_with_reset_dag_run

2020-10-24 Thread GitBox
potiuk closed issue #11816: URL: https://github.com/apache/airflow/issues/11816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk merged pull request #11821: Fix spelling

2020-10-24 Thread GitBox
potiuk merged pull request #11821: URL: https://github.com/apache/airflow/pull/11821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] dimberman opened a new pull request #11815: Render k8s yaml

2020-10-24 Thread GitBox
dimberman opened a new pull request #11815: URL: https://github.com/apache/airflow/pull/11815 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for

[GitHub] [airflow] github-actions[bot] commented on pull request #11465: Add Markdown linting to pre-commit

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #11465: URL: https://github.com/apache/airflow/pull/11465#issuecomment-715876333 [The Workflow run](https://github.com/apache/airflow/actions/runs/325627671) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] potiuk commented on pull request #11792: Local Executor is used by default for MySQL/Postgres breeze

2020-10-24 Thread GitBox
potiuk commented on pull request #11792: URL: https://github.com/apache/airflow/pull/11792#issuecomment-715879776 I think it's still worth merging now and we should go ahead and fal sequential for MySQL/Postgres (see devlist)

[GitHub] [airflow] potiuk edited a comment on pull request #11792: Local Executor is used by default for MySQL/Postgres breeze

2020-10-24 Thread GitBox
potiuk edited a comment on pull request #11792: URL: https://github.com/apache/airflow/pull/11792#issuecomment-715879776 I think it's still worth merging now and we should go ahead and fail sequential for MySQL/Postgres (see devlist) WDYT?

[GitHub] [airflow] potiuk commented on pull request #11785: Switch postgres from 10 to 13

2020-10-24 Thread GitBox
potiuk commented on pull request #11785: URL: https://github.com/apache/airflow/pull/11785#issuecomment-715880093 I modified it slighlty to also allow other versions in Breeze. This way we will see in breeze help that the in-between versions are supported as well. But CI tests wil

[airflow] branch master updated (4c8e033 -> 3934ef2)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4c8e033 Fix spelling and grammar (#11814) add 3934ef2 Remove redundant builtins imports (#11809) No new

[GitHub] [airflow] potiuk commented on pull request #11809: Remove redundant builtins imports

2020-10-24 Thread GitBox
potiuk commented on pull request #11809: URL: https://github.com/apache/airflow/pull/11809#issuecomment-715881758 Flaky test which I fixed in #11817 merging This is an automated message from the Apache Git Service. To

[GitHub] [airflow] potiuk merged pull request #11809: Remove redundant builtins imports

2020-10-24 Thread GitBox
potiuk merged pull request #11809: URL: https://github.com/apache/airflow/pull/11809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] KulykDmytro edited a comment on issue #11696: WebUI does not have access to pod logs

2020-10-24 Thread GitBox
KulykDmytro edited a comment on issue #11696: URL: https://github.com/apache/airflow/issues/11696#issuecomment-715886117 WebUI should run with serviceAccount which have RBAC permissions on k8s cluster to get logs ``` spec.template.spec.serviceAccount: airflow ``` ``` ---

[GitHub] [airflow] jbampton commented on pull request #11457: Fix spelling

2020-10-24 Thread GitBox
jbampton commented on pull request #11457: URL: https://github.com/apache/airflow/pull/11457#issuecomment-715890694 Hey @potiuk can you please review  This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] yangrong688 commented on pull request #11757: Add uSmart Securities to INTHEWILD.md

2020-10-24 Thread GitBox
yangrong688 commented on pull request #11757: URL: https://github.com/apache/airflow/pull/11757#issuecomment-715891591 Thanks for your review @kaxil . This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk opened a new pull request #11820: Retrieve PR labels from the associated PR

2020-10-24 Thread GitBox
potiuk opened a new pull request #11820: URL: https://github.com/apache/airflow/pull/11820 This change is needed to implement optimisation of running only limited version of the matrix tests for PRs that are not yet approved by committers. --- **^ Add meaningful

[GitHub] [airflow] potiuk commented on pull request #11820: Retrieve PR labels from the associated PR

2020-10-24 Thread GitBox
potiuk commented on pull request #11820: URL: https://github.com/apache/airflow/pull/11820#issuecomment-715895135 cc: @TobKed This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] jbampton opened a new pull request #11821: Fix spelling

2020-10-24 Thread GitBox
jbampton opened a new pull request #11821: URL: https://github.com/apache/airflow/pull/11821 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] BhuviTheDataGuy opened a new issue #11822: Python Operator - Get xcom_pull from a different task

2020-10-24 Thread GitBox
BhuviTheDataGuy opened a new issue #11822: URL: https://github.com/apache/airflow/issues/11822 I have a SQL file like below. ```sql select * from {{params.table_name }} where data > {{ params.maxdt }} ``` And Im calling a function from python operator. So I need to pass maxdt

[GitHub] [airflow] mik-laj commented on issue #11822: Python Operator - Get xcom_pull from a different task

2020-10-24 Thread GitBox
mik-laj commented on issue #11822: URL: https://github.com/apache/airflow/issues/11822#issuecomment-715908327 ```diff - params = {'table_name': table_name, 'maxdt': "{{ti.xcom_pull(task_ids='push_result_{}')}}.format(table_name)}", + params = {'table_name': table_name,

[GitHub] [airflow] potiuk merged pull request #11785: Switch postgres from 10 to 13

2020-10-24 Thread GitBox
potiuk merged pull request #11785: URL: https://github.com/apache/airflow/pull/11785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow] branch master updated (6ce855a -> dff9c9a)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 6ce855a Fix spelling (#11821) add dff9c9a Fixes flaky test test_should_response_200_with_reset_dag_run

[airflow] branch master updated (aacf602 -> 6ce855a)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from aacf602 Fix spelling (#11457) add 6ce855a Fix spelling (#11821) No new revisions were added by this update.

[GitHub] [airflow] potiuk commented on pull request #11785: Switch postgres from 10 to 13

2020-10-24 Thread GitBox
potiuk commented on pull request #11785: URL: https://github.com/apache/airflow/pull/11785#issuecomment-715909129 Just random integration error failing . I will take a look at stability of the Open LDAP next. Seems that once it fails, it fails

[airflow] branch master updated (6ce855a -> dff9c9a)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 6ce855a Fix spelling (#11821) add dff9c9a Fixes flaky test test_should_response_200_with_reset_dag_run

[airflow] branch master updated (dff9c9a -> 8d94214)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from dff9c9a Fixes flaky test test_should_response_200_with_reset_dag_run (#11817) add 8d94214 Switch postgres

[airflow] branch master updated (dff9c9a -> 8d94214)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from dff9c9a Fixes flaky test test_should_response_200_with_reset_dag_run (#11817) add 8d94214 Switch postgres

[GitHub] [airflow] potiuk edited a comment on pull request #11797: Fix locking issue stopping tasks running with SequentialExecutor

2020-10-24 Thread GitBox
potiuk edited a comment on pull request #11797: URL: https://github.com/apache/airflow/pull/11797#issuecomment-715882665 Whoa. One line :) . Thanks @kaxil and @ashb! This is an automated message from the Apache Git Service.

[GitHub] [airflow] potiuk commented on pull request #11797: Fix locking issue stopping tasks running with SequentialExecutor

2020-10-24 Thread GitBox
potiuk commented on pull request #11797: URL: https://github.com/apache/airflow/pull/11797#issuecomment-715882665 Whoa. One line :) . Thanks @kaxil! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #10917: WIP: Fix race conditions in task callback invocations

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #10917: URL: https://github.com/apache/airflow/pull/10917#issuecomment-715882668 [The Workflow run](https://github.com/apache/airflow/actions/runs/325681417) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] KulykDmytro opened a new issue #11819: LatestOnlyOperator cascades skipped status despite of trigger_rule set

2020-10-24 Thread GitBox
KulykDmytro opened a new issue #11819: URL: https://github.com/apache/airflow/issues/11819 **Apache Airflow version**: 1.10.12 **Kubernetes version**: 1.18.6 **What happened**: Forwarded from https://github.com/apache/airflow/issues/10686 In case when LatestOnlyOperator set as

[airflow] branch master updated (e4adfd7 -> aacf602)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e4adfd7 Add links to PyPI packages. (#11818) add aacf602 Fix spelling (#11457) No new revisions were added

[GitHub] [airflow] BhuviTheDataGuy commented on issue #11822: Python Operator - Get xcom_pull from a different task

2020-10-24 Thread GitBox
BhuviTheDataGuy commented on issue #11822: URL: https://github.com/apache/airflow/issues/11822#issuecomment-715910204 Hey @mik-laj Sure, Seems it's not resolving the template instead its passing the string as it is. ```sql select * from public.m1 where timestamp> {

[GitHub] [airflow] mik-laj commented on a change in pull request #11693: Add Python Helm testing framework

2020-10-24 Thread GitBox
mik-laj commented on a change in pull request #11693: URL: https://github.com/apache/airflow/pull/11693#discussion_r511528599 ## File path: .github/workflows/ci.yml ## @@ -424,6 +428,52 @@ jobs: name: airflow-provider-readmes path:

[GitHub] [airflow] mik-laj commented on pull request #11793: [AIRFLOW-8664] Postgres to GCS operator - use named cursor

2020-10-24 Thread GitBox
mik-laj commented on pull request #11793: URL: https://github.com/apache/airflow/pull/11793#issuecomment-716057427 I like this change very much, but I would like to test it before merging. Can you add system tests to make this easier?

[GitHub] [airflow] mik-laj edited a comment on pull request #11793: [AIRFLOW-8664] Postgres to GCS operator - use named cursor

2020-10-24 Thread GitBox
mik-laj edited a comment on pull request #11793: URL: https://github.com/apache/airflow/pull/11793#issuecomment-716057427 I like this change very much, but I would like to test it before merging. Can you add system tests to make this easier?

[GitHub] [airflow] github-actions[bot] commented on pull request #10917: WIP: Fix race conditions in task callback invocations

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #10917: URL: https://github.com/apache/airflow/pull/10917#issuecomment-716092955 [The Workflow run](https://github.com/apache/airflow/actions/runs/326856968) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] jmelot commented on issue #11040: Create ChainBetwenDAGAndOperatorNotAllowedRule to ease upgrade to Airflow 2.0

2020-10-24 Thread GitBox
jmelot commented on issue #11040: URL: https://github.com/apache/airflow/issues/11040#issuecomment-716090764 Thanks, and sorry for taking so long to follow up. I [implemented a rule](https://github.com/jmelot/airflow/commit/d9a109952d9bec5b7dc6e7db10001dd69a7e796d) for this that parses

[GitHub] [airflow] mik-laj commented on issue #8088: Auto-generate installation.rst

2020-10-24 Thread GitBox
mik-laj commented on issue #8088: URL: https://github.com/apache/airflow/issues/8088#issuecomment-716066856 > 'async': async_packages, async is a restricted keyword in python. You cannot create a variable with this name, but it can be the name of a key in the dictionary.

[GitHub] [airflow] mik-laj edited a comment on issue #8088: Auto-generate installation.rst

2020-10-24 Thread GitBox
mik-laj edited a comment on issue #8088: URL: https://github.com/apache/airflow/issues/8088#issuecomment-716066856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] kaxil opened a new pull request #11824: Fix typo in scripts/in_container/entrypoint_ci.sh

2020-10-24 Thread GitBox
kaxil opened a new pull request #11824: URL: https://github.com/apache/airflow/pull/11824 `xpessed` -> `xpassed` --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] ashb commented on a change in pull request #11335: Make Dag Serialization a hard requirement

2020-10-24 Thread GitBox
ashb commented on a change in pull request #11335: URL: https://github.com/apache/airflow/pull/11335#discussion_r511450726 ## File path: tests/jobs/test_scheduler_job.py ## @@ -1407,7 +1414,9 @@ def test_find_executable_task_instances_task_concurrency(self): # pylint: disab

[GitHub] [airflow] ashb commented on a change in pull request #11802: Add Kubernetes cleanup-pods CLI command for Helm Chart

2020-10-24 Thread GitBox
ashb commented on a change in pull request #11802: URL: https://github.com/apache/airflow/pull/11802#discussion_r511451313 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -61,3 +63,64 @@ def generate_pod_yaml(args): sanitized_pod =

[GitHub] [airflow] mik-laj commented on a change in pull request #11802: Add Kubernetes cleanup-pods CLI command for Helm Chart

2020-10-24 Thread GitBox
mik-laj commented on a change in pull request #11802: URL: https://github.com/apache/airflow/pull/11802#discussion_r511453580 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -61,3 +63,64 @@ def generate_pod_yaml(args): sanitized_pod =

[GitHub] [airflow] kaxil commented on a change in pull request #11335: Make Dag Serialization a hard requirement

2020-10-24 Thread GitBox
kaxil commented on a change in pull request #11335: URL: https://github.com/apache/airflow/pull/11335#discussion_r511457675 ## File path: tests/jobs/test_scheduler_job.py ## @@ -1407,7 +1414,9 @@ def test_find_executable_task_instances_task_concurrency(self): # pylint: disab

[GitHub] [airflow] kaxil commented on pull request #11803: Fix bug when marking tasks when DAG Serialization is enabled

2020-10-24 Thread GitBox
kaxil commented on pull request #11803: URL: https://github.com/apache/airflow/pull/11803#issuecomment-715927237 > Shoudl we add some tests @kaxil ? Check the PR description  tests would be covered in #11335 where we update all the tests to enable DAG Serialization.

[airflow] branch master updated: Update download url for Airflow Providers Version (#11823)

2020-10-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 97da08c Update download url for Airflow

[airflow] branch master updated: Fix bug when marking tasks when DAG Serialization is enabled (#11803)

2020-10-24 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 330cd42 Fix bug when marking tasks when

[GitHub] [airflow] kaxil merged pull request #11803: Fix bug when marking tasks when DAG Serialization is enabled

2020-10-24 Thread GitBox
kaxil merged pull request #11803: URL: https://github.com/apache/airflow/pull/11803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk merged pull request #11823: Update download url for Airflow Providers Version

2020-10-24 Thread GitBox
potiuk merged pull request #11823: URL: https://github.com/apache/airflow/pull/11823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #11826: Generated backport providers readmes/setup for 2020.10.29

2020-10-24 Thread GitBox
potiuk commented on pull request #11826: URL: https://github.com/apache/airflow/pull/11826#issuecomment-715928427 BTW. I am releasing all of them due to the .tar.gz installability fix This is an automated message from the

[GitHub] [airflow] potiuk commented on pull request #11826: Generated backport providers readmes/setup for 2020.10.29

2020-10-24 Thread GitBox
potiuk commented on pull request #11826: URL: https://github.com/apache/airflow/pull/11826#issuecomment-715928281 Updaed with the archive URL fix This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #11826: Generated backport providers readmes/setup for 2020.10.29

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #11826: URL: https://github.com/apache/airflow/pull/11826#issuecomment-715938902 [The Workflow run](https://github.com/apache/airflow/actions/runs/326088693) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] mik-laj opened a new pull request #11827: Migrate from helm-unittest to python unittest

2020-10-24 Thread GitBox
mik-laj opened a new pull request #11827: URL: https://github.com/apache/airflow/pull/11827 I am waiting for the @dimberman 's change to be merged, but in the meantime I have converted all tests with an automated script. Part of: https://github.com/apache/airflow/issues/11657

[GitHub] [airflow] potiuk commented on pull request #11828: Run only subset of tests for non approved prs

2020-10-24 Thread GitBox
potiuk commented on pull request #11828: URL: https://github.com/apache/airflow/pull/11828#issuecomment-715971599 @dimberman @ashb @kaxil @turbaszek -> once we have the labeling in place, this one limits not only the actual tests run but also the number of images prepared. We only need

[GitHub] [airflow] pkonarzewski commented on issue #9957: dbapi_hook get_records doesn't accept list.

2020-10-24 Thread GitBox
pkonarzewski commented on issue #9957: URL: https://github.com/apache/airflow/issues/9957#issuecomment-715917177 So I've wrote some code to fix this issue, but now i have some doubts. It's a simple fix, but there is few corner cases, that make it a little bit messy for me. My

[GitHub] [airflow] kaxil commented on a change in pull request #11335: Make Dag Serialization a hard requirement

2020-10-24 Thread GitBox
kaxil commented on a change in pull request #11335: URL: https://github.com/apache/airflow/pull/11335#discussion_r511457675 ## File path: tests/jobs/test_scheduler_job.py ## @@ -1407,7 +1414,9 @@ def test_find_executable_task_instances_task_concurrency(self): # pylint: disab

[GitHub] [airflow] github-actions[bot] commented on pull request #11447: Use PyUpgrade to use Python 3.6 features

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #11447: URL: https://github.com/apache/airflow/pull/11447#issuecomment-715916889 [The Workflow run](https://github.com/apache/airflow/actions/runs/325975561) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] kaxil commented on a change in pull request #11627: Add D205 pydocstyle check

2020-10-24 Thread GitBox
kaxil commented on a change in pull request #11627: URL: https://github.com/apache/airflow/pull/11627#discussion_r511460824 ## File path: airflow/providers/slack/operators/slack.py ## @@ -89,9 +92,9 @@ def execute(self, **kwargs): # noqa: D403 class

[GitHub] [airflow] github-actions[bot] removed a comment on pull request #11447: Use PyUpgrade to use Python 3.6 features

2020-10-24 Thread GitBox
github-actions[bot] removed a comment on pull request #11447: URL: https://github.com/apache/airflow/pull/11447#issuecomment-706778594 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] kaxil commented on a change in pull request #11627: Add D205 pydocstyle check

2020-10-24 Thread GitBox
kaxil commented on a change in pull request #11627: URL: https://github.com/apache/airflow/pull/11627#discussion_r511460824 ## File path: airflow/providers/slack/operators/slack.py ## @@ -89,9 +92,9 @@ def execute(self, **kwargs): # noqa: D403 class

[GitHub] [airflow] kaxil commented on a change in pull request #11627: Add D205 pydocstyle check

2020-10-24 Thread GitBox
kaxil commented on a change in pull request #11627: URL: https://github.com/apache/airflow/pull/11627#discussion_r511461221 ## File path: airflow/providers/slack/operators/slack.py ## @@ -159,8 +162,8 @@ def construct_api_call_params(self) -> Any: class

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-10-24 Thread Richard Williamson (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220106#comment-17220106 ] Richard Williamson commented on AIRFLOW-5071: - We were seeing this issue sporadically the

[GitHub] [airflow] kaxil commented on a change in pull request #11825: Fix spelling

2020-10-24 Thread GitBox
kaxil commented on a change in pull request #11825: URL: https://github.com/apache/airflow/pull/11825#discussion_r511462582 ## File path: airflow/providers/amazon/aws/operators/datasync.py ## @@ -199,7 +199,7 @@ def execute(self, context): if self.candidate_task_arns:

[GitHub] [airflow] potiuk opened a new pull request #11826: Generated backport providers readmes/setup for 2020.10.29

2020-10-24 Thread GitBox
potiuk opened a new pull request #11826: URL: https://github.com/apache/airflow/pull/11826 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] ktrueda commented on pull request #11627: Add D205 pydocstyle check

2020-10-24 Thread GitBox
ktrueda commented on pull request #11627: URL: https://github.com/apache/airflow/pull/11627#issuecomment-715927679 @kaxil Thank you for your suggestion very much!!  This is an automated message from the Apache

[GitHub] [airflow] ktrueda commented on a change in pull request #11627: Add D205 pydocstyle check

2020-10-24 Thread GitBox
ktrueda commented on a change in pull request #11627: URL: https://github.com/apache/airflow/pull/11627#discussion_r511483765 ## File path: airflow/providers/slack/operators/slack.py ## @@ -89,9 +92,9 @@ def execute(self, **kwargs): # noqa: D403 class

[GitHub] [airflow] ktrueda commented on a change in pull request #11627: Add D205 pydocstyle check

2020-10-24 Thread GitBox
ktrueda commented on a change in pull request #11627: URL: https://github.com/apache/airflow/pull/11627#discussion_r511485962 ## File path: airflow/providers/slack/operators/slack.py ## @@ -89,9 +92,9 @@ def execute(self, **kwargs): # noqa: D403 class

[GitHub] [airflow] szn commented on issue #8088: Auto-generate installation.rst

2020-10-24 Thread GitBox
szn commented on issue #8088: URL: https://github.com/apache/airflow/issues/8088#issuecomment-715959080 I have a case needed to be clarified: `setup.py:` ```python ... EXTRAS_REQUIREMENTS = { 'amazon': amazon, 'aws': amazon, # TODO: remove this in Airflow 2.1

[GitHub] [airflow] szn edited a comment on issue #8088: Auto-generate installation.rst

2020-10-24 Thread GitBox
szn edited a comment on issue #8088: URL: https://github.com/apache/airflow/issues/8088#issuecomment-715959080 I have a case needed to be clarified @mik-laj @potiuk: `setup.py:` ```python ... EXTRAS_REQUIREMENTS = { 'amazon': amazon, 'aws': amazon, # TODO:

  1   2   >