[jira] [Assigned] (AIRFLOW-5088) To implement DAG serialization using JSON for DB persistence

2019-07-31 Thread Zhou Fang (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhou Fang reassigned AIRFLOW-5088: -- Assignee: Zhou Fang > To implement DAG serialization using JSON for DB persistence >

[GitHub] [airflow] coufon opened a new pull request #5701: [AIRFLOW-5088] Add DAG serialization using JSON

2019-07-31 Thread GitBox
coufon opened a new pull request #5701: [AIRFLOW-5088] Add DAG serialization using JSON URL: https://github.com/apache/airflow/pull/5701 ### Jira - [x] My PR addresses the following [Airflow Jira 5088](https://issues.apache.org/jira/browse/AIRFLOW-5088) - AIP-24:

[jira] [Commented] (AIRFLOW-5088) To implement DAG serialization using JSON for DB persistence

2019-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897631#comment-16897631 ] ASF GitHub Bot commented on AIRFLOW-5088: - coufon commented on pull request #5701:

[jira] [Commented] (AIRFLOW-4924) Loading DAGs asynchronously in Airflow webserver

2019-07-31 Thread Zhou Fang (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897620#comment-16897620 ] Zhou Fang commented on AIRFLOW-4924: Will instead following AIP-24 to use JSON instead of Pickle

[jira] [Created] (AIRFLOW-5088) To implement DAG serialization using JSON for DB persistence

2019-07-31 Thread Zhou Fang (JIRA)
Zhou Fang created AIRFLOW-5088: -- Summary: To implement DAG serialization using JSON for DB persistence Key: AIRFLOW-5088 URL: https://issues.apache.org/jira/browse/AIRFLOW-5088 Project: Apache Airflow

[GitHub] [airflow] KevinYang21 commented on issue #5589: [AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming

2019-07-31 Thread GitBox
KevinYang21 commented on issue #5589: [AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming URL: https://github.com/apache/airflow/pull/5589#issuecomment-517042516 @ashb Updated with backward compatible approach, PTAL This

[GitHub] [airflow] potiuk commented on issue #5698: Airflow 5052 add include deleted to sf hook query

2019-07-31 Thread GitBox
potiuk commented on issue #5698: Airflow 5052 add include deleted to sf hook query URL: https://github.com/apache/airflow/pull/5698#issuecomment-517013470 Can you please follow CONTRIBUTING.md - w/regards to [AIRFLOW-XXX) in commit and add some unit test?

[GitHub] [airflow] mortenbpost commented on a change in pull request #5349: [AIRFLOW-4591] Make default_pool a real pool

2019-07-31 Thread GitBox
mortenbpost commented on a change in pull request #5349: [AIRFLOW-4591] Make default_pool a real pool URL: https://github.com/apache/airflow/pull/5349#discussion_r309405312 ## File path: airflow/migrations/versions/6e96a59344a4_make_taskinstance_pool_not_nullable.py ##

[jira] [Commented] (AIRFLOW-5086) Partial search in classic UI not working

2019-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897464#comment-16897464 ] ASF GitHub Bot commented on AIRFLOW-5086: - feluelle commented on pull request #5700:

[GitHub] [airflow] feluelle opened a new pull request #5700: [AIRFLOW-5086] Fix search for partial string in classic UI

2019-07-31 Thread GitBox
feluelle opened a new pull request #5700: [AIRFLOW-5086] Fix search for partial string in classic UI URL: https://github.com/apache/airflow/pull/5700 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Created] (AIRFLOW-5087) Display task/dag run stats on UI so that users can debug more easily

2019-07-31 Thread Ping Zhang (JIRA)
Ping Zhang created AIRFLOW-5087: --- Summary: Display task/dag run stats on UI so that users can debug more easily Key: AIRFLOW-5087 URL: https://issues.apache.org/jira/browse/AIRFLOW-5087 Project: Apache

[GitHub] [airflow] BasPH commented on issue #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
BasPH commented on issue #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#issuecomment-516970713 @ashb I've addressed all your comments: - Added a method `render_template_fields` to the BaseOperator, which is called from

[GitHub] [airflow] milton0825 commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op`

2019-07-31 Thread GitBox
milton0825 commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op` URL: https://github.com/apache/airflow/pull/5598#issuecomment-516970418 Still better than where we are now. Maybe we can add a note that this won't work for

[GitHub] [airflow] BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309370962 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[jira] [Resolved] (AIRFLOW-5057) Provide bucket name to functions in S3 Hook when none is specified

2019-07-31 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Uellendall resolved AIRFLOW-5057. --- Resolution: Fixed > Provide bucket name to functions in S3 Hook when none is

[jira] [Commented] (AIRFLOW-5086) Partial search in classic UI not working

2019-07-31 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897346#comment-16897346 ] Felix Uellendall commented on AIRFLOW-5086: --- But lets then add it to 1.10.5 since it is not

[jira] [Commented] (AIRFLOW-5086) Partial search in classic UI not working

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897348#comment-16897348 ] Ash Berlin-Taylor commented on AIRFLOW-5086: No arguments here! > Partial search in

[jira] [Commented] (AIRFLOW-5086) Partial search in classic UI not working

2019-07-31 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897340#comment-16897340 ] Felix Uellendall commented on AIRFLOW-5086: --- Fixed it, I think. Just waiting for the docker

[jira] [Commented] (AIRFLOW-5086) Partial search in classic UI not working

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897329#comment-16897329 ] Ash Berlin-Taylor commented on AIRFLOW-5086:  Oh I thought we fixed it in classic UI too.

[jira] [Assigned] (AIRFLOW-5086) Partial search in classic UI not working

2019-07-31 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Uellendall reassigned AIRFLOW-5086: - Assignee: Felix Uellendall > Partial search in classic UI not working >

[jira] [Commented] (AIRFLOW-5086) Partial search in classic UI not working

2019-07-31 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897313#comment-16897313 ] Felix Uellendall commented on AIRFLOW-5086: --- [~ash] found this while testing 1.10.4rc4 . It

[jira] [Created] (AIRFLOW-5086) Partial search in classic UI not working

2019-07-31 Thread Felix Uellendall (JIRA)
Felix Uellendall created AIRFLOW-5086: - Summary: Partial search in classic UI not working Key: AIRFLOW-5086 URL: https://issues.apache.org/jira/browse/AIRFLOW-5086 Project: Apache Airflow

[jira] [Commented] (AIRFLOW-3503) GoogleCloudStorageHook delete return success when nothing was done

2019-07-31 Thread Tomasz Urbaszek (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897290#comment-16897290 ] Tomasz Urbaszek commented on AIRFLOW-3503: -- [~kamil.bregula] what is your opinion? >

[jira] [Commented] (AIRFLOW-5085) When you run kubernetes git-sync test from TAG, it fails

2019-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897272#comment-16897272 ] ASF GitHub Bot commented on AIRFLOW-5085: - potiuk commented on pull request #5699:

[GitHub] [airflow] potiuk opened a new pull request #5699: [AIRFLOW-5085] we always pass the default branch name to the build

2019-07-31 Thread GitBox
potiuk opened a new pull request #5699: [AIRFLOW-5085] we always pass the default branch name to the build URL: https://github.com/apache/airflow/pull/5699 TRAVIS_BRANCH is set to TAG when TAG build runs. We should alwayss use branch and we already have our current branch in

[jira] [Created] (AIRFLOW-5085) When you run kubernetes git-sync test from TAG, it fails

2019-07-31 Thread Jarek Potiuk (JIRA)
Jarek Potiuk created AIRFLOW-5085: - Summary: When you run kubernetes git-sync test from TAG, it fails Key: AIRFLOW-5085 URL: https://issues.apache.org/jira/browse/AIRFLOW-5085 Project: Apache Airflow

[GitHub] [airflow] wmorris75 opened a new pull request #5698: Airflow 5052 add include deleted to sf hook query

2019-07-31 Thread GitBox
wmorris75 opened a new pull request #5698: Airflow 5052 add include deleted to sf hook query URL: https://github.com/apache/airflow/pull/5698 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-5084) Mypy.ini is accidentally committed

2019-07-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897216#comment-16897216 ] ASF subversion and git services commented on AIRFLOW-5084: -- Commit

[jira] [Commented] (AIRFLOW-5084) Mypy.ini is accidentally committed

2019-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897215#comment-16897215 ] ASF GitHub Bot commented on AIRFLOW-5084: - ashb commented on pull request #5697: [AIRFLOW-5084]

[jira] [Commented] (AIRFLOW-5063) When switching master <> v1-10-test performance of CI scripts drops dramatically

2019-07-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897217#comment-16897217 ] ASF subversion and git services commented on AIRFLOW-5063: -- Commit

[GitHub] [airflow] ashb merged pull request #5697: [AIRFLOW-5084] Remove mypy.ini

2019-07-31 Thread GitBox
ashb merged pull request #5697: [AIRFLOW-5084] Remove mypy.ini URL: https://github.com/apache/airflow/pull/5697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309228963 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,50 @@ def __setstate__(self, state):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309228434 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309228197 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309218376 ## File path: airflow/models/taskinstance.py ## @@ -1245,21 +1245,20 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5349: [AIRFLOW-4591] Make default_pool a real pool

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5349: [AIRFLOW-4591] Make default_pool a real pool URL: https://github.com/apache/airflow/pull/5349#discussion_r309217923 ## File path: airflow/migrations/versions/6e96a59344a4_make_taskinstance_pool_not_nullable.py ## @@ -0,0

[GitHub] [airflow] BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309215368 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,50 @@ def __setstate__(self, state):

[GitHub] [airflow] mortenbpost commented on a change in pull request #5349: [AIRFLOW-4591] Make default_pool a real pool

2019-07-31 Thread GitBox
mortenbpost commented on a change in pull request #5349: [AIRFLOW-4591] Make default_pool a real pool URL: https://github.com/apache/airflow/pull/5349#discussion_r309213144 ## File path: airflow/migrations/versions/6e96a59344a4_make_taskinstance_pool_not_nullable.py ##

[GitHub] [airflow] BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309212647 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309212647 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309211270 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309210653 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309209865 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,50 @@ def __setstate__(self, state):

[jira] [Commented] (AIRFLOW-5072) gcs_hook causes out-of-memory error when downloading huge files

2019-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897147#comment-16897147 ] ASF GitHub Bot commented on AIRFLOW-5072: - tkaymak commented on pull request #5685:

[jira] [Commented] (AIRFLOW-5072) gcs_hook causes out-of-memory error when downloading huge files

2019-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897145#comment-16897145 ] ASF GitHub Bot commented on AIRFLOW-5072: - tkaymak commented on pull request #5685:

[GitHub] [airflow] tkaymak commented on issue #5685: [AIRFLOW-5072] gcs_hook's download() method should download only once

2019-07-31 Thread GitBox
tkaymak commented on issue #5685: [AIRFLOW-5072] gcs_hook's download() method should download only once URL: https://github.com/apache/airflow/pull/5685#issuecomment-516837542 Closing and re-opening PR as Travis seems to have issues which are not related to the code

[GitHub] [airflow] tkaymak closed pull request #5685: [AIRFLOW-5072] gcs_hook's download() method should download only once

2019-07-31 Thread GitBox
tkaymak closed pull request #5685: [AIRFLOW-5072] gcs_hook's download() method should download only once URL: https://github.com/apache/airflow/pull/5685 This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] tkaymak opened a new pull request #5685: [AIRFLOW-5072] gcs_hook's download() method should download only once

2019-07-31 Thread GitBox
tkaymak opened a new pull request #5685: [AIRFLOW-5072] gcs_hook's download() method should download only once URL: https://github.com/apache/airflow/pull/5685 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow

[GitHub] [airflow] ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op`

2019-07-31 Thread GitBox
ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op` URL: https://github.com/apache/airflow/pull/5598#issuecomment-516807208 Argh. This works, except for when the DAG is pickled. Grr. (Maybe we just delete dag pickling

[jira] [Commented] (AIRFLOW-5052) Add the include_deleted parameter to Salesforce Hook

2019-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897056#comment-16897056 ] ASF GitHub Bot commented on AIRFLOW-5052: - wmorris75 commented on pull request #5687:

[GitHub] [airflow] wmorris75 closed pull request #5687: [AIRFLOW-5052] Add include_deleted param to salesforce_hook. parent 6ef0e37a63f8c876342f5625ef14c6109efe8eab

2019-07-31 Thread GitBox
wmorris75 closed pull request #5687: [AIRFLOW-5052] Add include_deleted param to salesforce_hook. parent 6ef0e37a63f8c876342f5625ef14c6109efe8eab URL: https://github.com/apache/airflow/pull/5687 This is an automated message

[jira] [Commented] (AIRFLOW-2891) Option to set container_name for DockerOperator

2019-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897048#comment-16897048 ] ASF GitHub Bot commented on AIRFLOW-2891: - BasPH commented on pull request #5696:

[jira] [Commented] (AIRFLOW-2891) Option to set container_name for DockerOperator

2019-07-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897049#comment-16897049 ] ASF subversion and git services commented on AIRFLOW-2891: -- Commit

[GitHub] [airflow] BasPH merged pull request #5696: [AIRFLOW-2891] Make DockerOperator container_name be templateable

2019-07-31 Thread GitBox
BasPH merged pull request #5696: [AIRFLOW-2891] Make DockerOperator container_name be templateable URL: https://github.com/apache/airflow/pull/5696 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-5065) Add colors to console log

2019-07-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897014#comment-16897014 ] ASF subversion and git services commented on AIRFLOW-5065: -- Commit

[jira] [Commented] (AIRFLOW-4289) spark_binary argument in SparkSubmitHook is ignored when building the connection_cmd

2019-07-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897020#comment-16897020 ] ASF subversion and git services commented on AIRFLOW-4289: -- Commit

[jira] [Commented] (AIRFLOW-5078) You should ask user locally whether to pull/build image when needed

2019-07-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897018#comment-16897018 ] ASF subversion and git services commented on AIRFLOW-5078: -- Commit

[jira] [Commented] (AIRFLOW-5077) CI builds gets slower when newer version of python gets released

2019-07-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897016#comment-16897016 ] ASF subversion and git services commented on AIRFLOW-5077: -- Commit

[jira] [Commented] (AIRFLOW-5075) HttpHook cannot handle connections with an empty host field

2019-07-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897019#comment-16897019 ] ASF subversion and git services commented on AIRFLOW-5075: -- Commit

[jira] [Commented] (AIRFLOW-4811) Implement GCP DLP' Hook and Operators

2019-07-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897015#comment-16897015 ] ASF subversion and git services commented on AIRFLOW-4811: -- Commit

[jira] [Commented] (AIRFLOW-5079) CI checklicence build does not need full CI image

2019-07-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897017#comment-16897017 ] ASF subversion and git services commented on AIRFLOW-5079: -- Commit

[jira] [Commented] (AIRFLOW-5084) Mypy.ini is accidentally committed

2019-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897008#comment-16897008 ] ASF GitHub Bot commented on AIRFLOW-5084: - potiuk commented on pull request #5697:

svn commit: r35076 - /dev/airflow/1.10.4rc4/

2019-07-31 Thread ash
Author: ash Date: Wed Jul 31 10:03:35 2019 New Revision: 35076 Log: Add artefacts for Airflow 1.10.4rc4 Added: dev/airflow/1.10.4rc4/ dev/airflow/1.10.4rc4/apache-airflow-1.10.4rc4-bin.tar.gz (with props) dev/airflow/1.10.4rc4/apache-airflow-1.10.4rc4-bin.tar.gz.asc

[GitHub] [airflow] potiuk opened a new pull request #5697: [AIRFLOW-5084] Remove mypy.ini

2019-07-31 Thread GitBox
potiuk opened a new pull request #5697: [AIRFLOW-5084] Remove mypy.ini URL: https://github.com/apache/airflow/pull/5697 Mypy.ini has been accidentally committed to the repo in AIRFLOW-5063 - caused mypy to fail if the sources are locally mounted or in IDE/local environment Make

[jira] [Created] (AIRFLOW-5084) Mypy.ini is accidentally committed

2019-07-31 Thread Jarek Potiuk (JIRA)
Jarek Potiuk created AIRFLOW-5084: - Summary: Mypy.ini is accidentally committed Key: AIRFLOW-5084 URL: https://issues.apache.org/jira/browse/AIRFLOW-5084 Project: Apache Airflow Issue Type:

[jira] [Resolved] (AIRFLOW-5031) Tzlocal 2.0.0 has been released today and it breaks the build

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-5031. Resolution: Fixed Fix Version/s: 2.0.0 > Tzlocal 2.0.0 has been released

[GitHub] [airflow] ashb commented on issue #5605: [AIRFLOW-4883] Kill hung file process managers

2019-07-31 Thread GitBox
ashb commented on issue #5605: [AIRFLOW-4883] Kill hung file process managers URL: https://github.com/apache/airflow/pull/5605#issuecomment-516781116 @tooptoop4 yeah, I hadn't cone through and updated fix versions for everything I'd cherry picked lately. I have now

[jira] [Resolved] (AIRFLOW-5065) Add colors to console log

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-5065. Resolution: Done > Add colors to console log > - > >

[jira] [Resolved] (AIRFLOW-4797) Zombie detection and killing is not deterministic

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4797. Resolution: Done > Zombie detection and killing is not deterministic >

[jira] [Resolved] (AIRFLOW-5063) When switching master <> v1-10-test performance of CI scripts drops dramatically

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-5063. Resolution: Done > When switching master <> v1-10-test performance of CI scripts

[jira] [Updated] (AIRFLOW-4797) Zombie detection and killing is not deterministic

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4797: --- Fix Version/s: 1.10.4 > Zombie detection and killing is not deterministic >

[jira] [Updated] (AIRFLOW-5065) Add colors to console log

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-5065: --- Fix Version/s: 1.10.4 > Add colors to console log > - > >

[jira] [Updated] (AIRFLOW-5063) When switching master <> v1-10-test performance of CI scripts drops dramatically

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-5063: --- Fix Version/s: 1.10.4 > When switching master <> v1-10-test performance of CI

[GitHub] [airflow] potiuk commented on issue #5677: [AIRFLOW-5063] Fix performance when switching between master/v1-10

2019-07-31 Thread GitBox
potiuk commented on issue #5677: [AIRFLOW-5063] Fix performance when switching between master/v1-10 URL: https://github.com/apache/airflow/pull/5677#issuecomment-516779634 Oh yeah. Accidentally committed empty mypy.ini when cherry-picked it. Clue of that change was exclusion of www_rbac

[jira] [Updated] (AIRFLOW-4583) ERROR - a bytes-like object is required, not 'str' while using gcp_conn_id and python3

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4583: --- Fix Version/s: (was: 2.0.0) 1.10.4 > ERROR - a bytes-like

[jira] [Updated] (AIRFLOW-3635) Fix incorrect logic in delete_dag (introduced in PR #4406)

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3635: --- Fix Version/s: 1.10.4 > Fix incorrect logic in delete_dag (introduced in PR #4406)

[jira] [Updated] (AIRFLOW-4170) Set variable using json in CLI

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4170: --- Fix Version/s: 1.10.4 > Set variable using json in CLI >

[jira] [Updated] (AIRFLOW-4883) Scheduler does not kill hung dag file process managers

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4883: --- Fix Version/s: (was: 2.0.0) 1.10.4 > Scheduler does not

[jira] [Updated] (AIRFLOW-4338) Change k8s pod_request_factory to use yaml safe_load

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4338: --- Fix Version/s: (was: 2.0.0) 1.10.4 > Change k8s

[jira] [Updated] (AIRFLOW-4306) Global operator extra links

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4306: --- Fix Version/s: (was: 2.0.0) 1.10.4 > Global operator extra

[jira] [Resolved] (AIRFLOW-3635) Fix incorrect logic in delete_dag (introduced in PR #4406)

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3635. Resolution: Fixed Please Resolve, not Close issues when merging (we can't edit

[GitHub] [airflow] potiuk commented on issue #5677: [AIRFLOW-5063] Fix performance when switching between master/v1-10

2019-07-31 Thread GitBox
potiuk commented on issue #5677: [AIRFLOW-5063] Fix performance when switching between master/v1-10 URL: https://github.com/apache/airflow/pull/5677#issuecomment-516778290 Let me take a look - there should not be mypy.ini in there. But it was in one of my local trials (abandoned). Might

[jira] [Reopened] (AIRFLOW-3635) Fix incorrect logic in delete_dag (introduced in PR #4406)

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-3635: > Fix incorrect logic in delete_dag (introduced in PR #4406) >

[jira] [Resolved] (AIRFLOW-2891) Option to set container_name for DockerOperator

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-2891. Resolution: Fixed Fix Version/s: 1.10.5 > Option to set container_name

[jira] [Commented] (AIRFLOW-2891) Option to set container_name for DockerOperator

2019-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896987#comment-16896987 ] ASF GitHub Bot commented on AIRFLOW-2891: - ashb commented on pull request #5696: [AIRFLOW-2891]

[GitHub] [airflow] ashb commented on issue #5696: [AIRFLOW-2891] Make DockerOperator container_name be templateable

2019-07-31 Thread GitBox
ashb commented on issue #5696: [AIRFLOW-2891] Make DockerOperator container_name be templateable URL: https://github.com/apache/airflow/pull/5696#issuecomment-516775678 cc @rocketbitz This is an automated message from the

[GitHub] [airflow] ashb opened a new pull request #5696: [AIRFLOW-2891] Make DockerOperator container_name be templateable

2019-07-31 Thread GitBox
ashb opened a new pull request #5696: [AIRFLOW-2891] Make DockerOperator container_name be templateable URL: https://github.com/apache/airflow/pull/5696 Make sure you have checked _all_ steps below. ### Jira - [x] https://issues.apache.org/jira/browse/AIRFLOW-2891 ###

[GitHub] [airflow] ashb edited a comment on issue #5677: [AIRFLOW-5063] Fix performance when switching between master/v1-10

2019-07-31 Thread GitBox
ashb edited a comment on issue #5677: [AIRFLOW-5063] Fix performance when switching between master/v1-10 URL: https://github.com/apache/airflow/pull/5677#issuecomment-516774578 This commit has changed the behaviour of `mypy airflow/some/file.py` -- it's ignoring the settings we have in

[GitHub] [airflow] ashb commented on issue #5677: [AIRFLOW-5063] Fix performance when switching between master/v1-10

2019-07-31 Thread GitBox
ashb commented on issue #5677: [AIRFLOW-5063] Fix performance when switching between master/v1-10 URL: https://github.com/apache/airflow/pull/5677#issuecomment-516774578 This commit has changed the behaviour of `mypy airflow/some/file.py` -- it's ignoring the settings we have in

[GitHub] [airflow] ashb commented on a change in pull request #5692: [AIRFLOW-5079] Checklicence test uses own, much smaller image

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5692: [AIRFLOW-5079] Checklicence test uses own, much smaller image URL: https://github.com/apache/airflow/pull/5692#discussion_r309119257 ## File path: Dockerfile-checklicence ## @@ -0,0 +1,73 @@ +# Licensed to the Apache

[GitHub] [airflow] ashb commented on a change in pull request #5692: [AIRFLOW-5079] Checklicence test uses own, much smaller image

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5692: [AIRFLOW-5079] Checklicence test uses own, much smaller image URL: https://github.com/apache/airflow/pull/5692#discussion_r309119257 ## File path: Dockerfile-checklicence ## @@ -0,0 +1,73 @@ +# Licensed to the Apache

[jira] [Commented] (AIRFLOW-5081) max_active_runs doesn't work correct

2019-07-31 Thread Dmitrii Bocharov (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896970#comment-16896970 ] Dmitrii Bocharov commented on AIRFLOW-5081: --- I triggered it manually and then later scheduler

[GitHub] [airflow] ashb commented on a change in pull request #5692: [AIRFLOW-5079] Checklicence test uses own, much smaller image

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5692: [AIRFLOW-5079] Checklicence test uses own, much smaller image URL: https://github.com/apache/airflow/pull/5692#discussion_r309119257 ## File path: Dockerfile-checklicence ## @@ -0,0 +1,73 @@ +# Licensed to the Apache

[jira] [Commented] (AIRFLOW-5081) max_active_runs doesn't work correct

2019-07-31 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896967#comment-16896967 ] Ash Berlin-Taylor commented on AIRFLOW-5081: Does the second active run come from trigger,

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309105615 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309104488 ## File path: airflow/models/taskinstance.py ## @@ -1245,21 +1245,20 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309106148 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309106230 ## File path: tests/models/test_dag.py ## @@ -387,243 +388,93 @@ def test_get_num_task_instances(self):

[GitHub] [airflow] ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

2019-07-31 Thread GitBox
ashb commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#discussion_r309102556 ## File path: airflow/models/baseoperator.py ## @@ -636,51 +636,50 @@ def __setstate__(self, state):

[GitHub] [airflow] potiuk commented on issue #5693: [AIRFLOW-5080] Added npm to apt-get install in compile.sh for docker

2019-07-31 Thread GitBox
potiuk commented on issue #5693: [AIRFLOW-5080] Added npm to apt-get install in compile.sh for docker URL: https://github.com/apache/airflow/pull/5693#issuecomment-516754995 It's an interesting one. I have not changed those cripts so likely it is there from the moment rbac build was

  1   2   >