codecov-io commented on issue #6103: [AIRFLOW-5482] Deprecate Schedule Interval
on task level
URL: https://github.com/apache/airflow/pull/6103#issuecomment-531540124
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6103?src=pr&el=h1)
Report
> Merging
[#6103](https://codecov.io/gh/
codecov-io edited a comment on issue #6103: [AIRFLOW-5482] Deprecate Schedule
Interval on task level
URL: https://github.com/apache/airflow/pull/6103#issuecomment-531540124
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6103?src=pr&el=h1)
Report
> Merging
[#6103](https://codecov
[
https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929842#comment-16929842
]
ASF GitHub Bot commented on AIRFLOW-4574:
-
dstandish commented on pull request
dstandish opened a new pull request #6104: [AIRFLOW-4574] add option to provide
private_key in SSHHook
URL: https://github.com/apache/airflow/pull/6104
* can provide in extras with key "private_key"
* can provide as parameter in SSHHook init
Make sure you have checked _all_ steps
codecov-io edited a comment on issue #5770: [AIRFLOW-5162] GCS Hook Upload
Method Improvement
URL: https://github.com/apache/airflow/pull/5770#issuecomment-529258006
# [Codecov](https://codecov.io/gh/apache/airflow/pull/5770?src=pr&el=h1)
Report
> Merging
[#5770](https://codecov.io/gh/
eladkal commented on a change in pull request #5998: [AIRFLOW-5398] Update
contrib example DAGs to context manager
URL: https://github.com/apache/airflow/pull/5998#discussion_r324431680
##
File path: airflow/contrib/example_dags/example_dingding_operator.py
##
@@ -59,173 +
mik-laj commented on a change in pull request #6086: [AIRFLOW-XXX] Display GCP
integration in table
URL: https://github.com/apache/airflow/pull/6086#discussion_r324429558
##
File path: docs/integration.rst
##
@@ -237,230 +235,290 @@ Airflow can be configured to read and wr
feluelle commented on a change in pull request #6086: [AIRFLOW-XXX] Display GCP
integration in table
URL: https://github.com/apache/airflow/pull/6086#discussion_r324429088
##
File path: docs/integration.rst
##
@@ -237,230 +235,290 @@ Airflow can be configured to read and w
feluelle commented on a change in pull request #6101: [AIRFLOW-5481] Allow
Deleting Renamed DAGs
URL: https://github.com/apache/airflow/pull/6101#discussion_r324428396
##
File path: tests/core.py
##
@@ -1696,6 +1696,15 @@ def test_delete_dag(self):
'--yes'
codecov-io commented on issue #6049: [AIRFLOW-XXX] Add prerequisite tasks for
all GCP operators guide
URL: https://github.com/apache/airflow/pull/6049#issuecomment-531476034
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6049?src=pr&el=h1)
Report
> Merging
[#6049](https://codeco
codecov-io commented on issue #6078: [AIRFLOW-5459] Use a dynamic tmp location
in Dataflow operator
URL: https://github.com/apache/airflow/pull/6078#issuecomment-531476010
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6078?src=pr&el=h1)
Report
> Merging
[#6078](https://codecov.
codecov-io edited a comment on issue #6086: [AIRFLOW-XXX] Display GCP
integration in table
URL: https://github.com/apache/airflow/pull/6086#issuecomment-530950111
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6086?src=pr&el=h1)
Report
> Merging
[#6086](https://codecov.io/gh/apa
mik-laj commented on issue #6074: [AIRFLOW-5390] Remove provide context
URL: https://github.com/apache/airflow/pull/6074#issuecomment-531475029
Travis is sad 😿 Can you comfort him?
```
==
8) FAIL: test_next_executi
mik-laj commented on issue #5419: [AIRFLOW-] Update pydoc of
mlengine_operator
URL: https://github.com/apache/airflow/pull/5419#issuecomment-531474465
We had a broken master branch - https://github.com/apache/airflow/pull/6098.
I did rebase.
---
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook
Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422494
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -418,23 +431,19 @@ def create_bucket(self,
:t
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook
Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422472
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -357,7 +374,6 @@ def get_size(self, bucket_name, objec
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook
Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422475
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -405,11 +420,9 @@ def create_bucket(self,
"""
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook
Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422477
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -405,11 +420,9 @@ def create_bucket(self,
"""
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook
Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422459
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -185,45 +180,72 @@ def download(self, bucket_name, obj
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook
Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422470
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -336,13 +355,11 @@ def list(self, bucket_name, version
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook
Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422466
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -289,7 +309,6 @@ def delete(self, bucket_name, object_
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook
Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422464
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -273,7 +294,6 @@ def is_updated_after(self, bucket_nam
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook
Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422462
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -238,7 +260,6 @@ def exists(self, bucket_name, object_
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook
Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422440
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -185,45 +180,72 @@ def download(self, bucket_name, obj
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422335
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -292,14 +504,38 @@ def acknowledge(s
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422317
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -259,29 +443,57 @@ def pull(
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422308
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -177,40 +293,88 @@ def create_subscr
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422309
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -219,30 +383,50 @@ def delete_subscr
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422287
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -154,6 +262,14 @@ def create_subscri
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422256
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -77,47 +106,110 @@ def publish(self,
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422266
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -129,23 +221,39 @@ def delete_topic(
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422248
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -77,47 +106,110 @@ def publish(self,
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422208
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -19,12 +19,18 @@
"""
This module c
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422074
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -77,47 +106,110 @@ def publish(self,
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422078
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -129,23 +221,39 @@ def delete_topic(
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422081
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -177,40 +293,88 @@ def create_subscr
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422078
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -129,23 +221,39 @@ def delete_topic(
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422074
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -77,47 +106,110 @@ def publish(self,
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r324422081
##
File path: airflow/gcp/hooks/pubsub.py
##
@@ -177,40 +293,88 @@ def create_subscr
[
https://issues.apache.org/jira/browse/AIRFLOW-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamil Bregula closed AIRFLOW-5479.
--
Fix Version/s: 1.10.6
Resolution: Fixed
> Normalize get_conn method in GCP Kubernetes
mik-laj commented on a change in pull request #6093: [AIRFLOW-5475] Normalize
gcp_conn_id in operators and hooks
URL: https://github.com/apache/airflow/pull/6093#discussion_r324406886
##
File path: airflow/gcp/hooks/bigquery.py
##
@@ -47,15 +48,23 @@ class BigQueryHook(Goo
mik-laj commented on a change in pull request #6093: [AIRFLOW-5475] Normalize
gcp_conn_id in operators and hooks
URL: https://github.com/apache/airflow/pull/6093#discussion_r324406904
##
File path: airflow/gcp/hooks/datastore.py
##
@@ -40,11 +41,19 @@ class DatastoreHook(G
mik-laj commented on a change in pull request #6093: [AIRFLOW-5475] Normalize
gcp_conn_id in operators and hooks
URL: https://github.com/apache/airflow/pull/6093#discussion_r324406927
##
File path: airflow/gcp/hooks/gcs.py
##
@@ -42,11 +43,20 @@ class GoogleCloudStorageHoo
mik-laj edited a comment on issue #6092: [AIRFLOW-5472] Fix labels in GCS
operator
URL: https://github.com/apache/airflow/pull/6092#issuecomment-531472546
![Screenshot 2019-09-14 at 13 33
42](https://user-images.githubusercontent.com/12058428/64907561-6ec0bc80-d6f4-11e9-8305-dc9f7cf156
[
https://issues.apache.org/jira/browse/AIRFLOW-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929755#comment-16929755
]
ASF GitHub Bot commented on AIRFLOW-5472:
-
mik-laj commented on pull request #6
mik-laj closed pull request #6092: [AIRFLOW-5472] Fix labels in GCS operator
URL: https://github.com/apache/airflow/pull/6092
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mik-laj commented on issue #6092: [AIRFLOW-5472] Fix labels in GCS operator
URL: https://github.com/apache/airflow/pull/6092#issuecomment-531472546
![Uploading Screenshot 2019-09-14 at 13.33.42.png…]()
Can you start a new PR from another branch?
--
codecov-io edited a comment on issue #6099: [AIRFLOW-5479] Normalize gcp_conn
method in GCP Kubernetes Hook
URL: https://github.com/apache/airflow/pull/6099#issuecomment-531416621
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6099?src=pr&el=h1)
Report
> Merging
[#6099](https://
codecov-io edited a comment on issue #6099: [AIRFLOW-5479] Normalize gcp_conn
method in GCP Kubernetes Hook
URL: https://github.com/apache/airflow/pull/6099#issuecomment-531416621
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6099?src=pr&el=h1)
Report
> Merging
[#6099](https://
codecov-io edited a comment on issue #6099: [AIRFLOW-5479] Normalize gcp_conn
method in GCP Kubernetes Hook
URL: https://github.com/apache/airflow/pull/6099#issuecomment-531416621
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6099?src=pr&el=h1)
Report
> Merging
[#6099](https://
codecov-io edited a comment on issue #6099: [AIRFLOW-5479] Normalize gcp_conn
method in GCP Kubernetes Hook
URL: https://github.com/apache/airflow/pull/6099#issuecomment-531416621
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6099?src=pr&el=h1)
Report
> Merging
[#6099](https://
codecov-io edited a comment on issue #6099: [AIRFLOW-5479] Normalize gcp_conn
method in GCP Kubernetes Hook
URL: https://github.com/apache/airflow/pull/6099#issuecomment-531416621
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6099?src=pr&el=h1)
Report
> Merging
[#6099](https://
[
https://issues.apache.org/jira/browse/AIRFLOW-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929753#comment-16929753
]
ASF subversion and git services commented on AIRFLOW-5479:
--
Co
mik-laj merged pull request #6099: [AIRFLOW-5479] Normalize gcp_conn method in
GCP Kubernetes Hook
URL: https://github.com/apache/airflow/pull/6099
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/AIRFLOW-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929752#comment-16929752
]
ASF GitHub Bot commented on AIRFLOW-5479:
-
mik-laj commented on pull request #6
kaxil commented on issue #6058: [AIRFLOW-5439] Add 'schedule_interval' to
'default_args'
URL: https://github.com/apache/airflow/pull/6058#issuecomment-531468123
The `default_args` is a dictionary that passes argument to each task (which
is deprecated).
alrolorojas commented on issue #6100: [AIRFLOW-5387] Fix show paused pagination
bug
URL: https://github.com/apache/airflow/pull/6100#issuecomment-531466819
@mik-laj Done! Can you take a look, please?
This is an automated mess
[
https://issues.apache.org/jira/browse/AIRFLOW-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929736#comment-16929736
]
Alejandro commented on AIRFLOW-3913:
This looks like it was fixed by:Â [https://gith
[
https://issues.apache.org/jira/browse/AIRFLOW-3912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929733#comment-16929733
]
Alejandro commented on AIRFLOW-3912:
This looks like it was fixed by:Â [https://gith
InigoSJ commented on issue #6058: [AIRFLOW-5439] Add 'schedule_interval' to
'default_args'
URL: https://github.com/apache/airflow/pull/6058#issuecomment-531463470
> We have deprecated using `schedule_interval` at task level. You need to
only specify it as a DAG parameter instead.
I'
Fokko commented on issue #6074: [AIRFLOW-5390] Remove provide context
URL: https://github.com/apache/airflow/pull/6074#issuecomment-531463399
Thanks @mik-laj for fixing this, appreciate it. Let's wait for Travis his
verdict.
mik-laj commented on issue #6100: [AIRFLOW-5387] Fix show paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#issuecomment-531460414
Yesterday I prepared a fix. it is already available on masters branch. Can
you do rebase onn latest apache/master?
---
alrolorojas commented on issue #6100: [AIRFLOW-5387] Fix show paused pagination
bug
URL: https://github.com/apache/airflow/pull/6100#issuecomment-531458315
There is a test failure that seem unrelated to the changes:
```
ERROR [airflow.models.dagbag.DagBag] Failed to import:
/opt/
63 matches
Mail list logo