[GitHub] [airflow] jedcunningham commented on a change in pull request #15997: Add Docs for ``default_pool`` slots

2021-05-21 Thread GitBox
jedcunningham commented on a change in pull request #15997: URL: https://github.com/apache/airflow/pull/15997#discussion_r637359766 ## File path: airflow/utils/db.py ## @@ -72,7 +72,7 @@ def add_default_pool_if_not_exists(session=None): if not

[GitHub] [airflow] eladkal commented on issue #15933: Consider splitting Google Provider

2021-05-21 Thread GitBox
eladkal commented on issue #15933: URL: https://github.com/apache/airflow/issues/15933#issuecomment-846348851 > +1 to that, I think we had similar discussion about salesforce, tableau and slack (Salesforce have bought Tableau and Slack) Thats true but there may be a different case

[airflow] branch master updated (ee470e1 -> 476d0f6)

2021-05-21 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from ee470e1 Fix failing spelling check on Master (#15998) add 476d0f6 Bump pyupgrade v2.13.0 to v2.18.1

[GitHub] [airflow] mik-laj merged pull request #15991: Bump pyupgrade v2.13.0 to v2.18.1

2021-05-21 Thread GitBox
mik-laj merged pull request #15991: URL: https://github.com/apache/airflow/pull/15991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] yuqian90 commented on pull request #15562: Fix changing the parent dag state on subdag clear

2021-05-21 Thread GitBox
yuqian90 commented on pull request #15562: URL: https://github.com/apache/airflow/pull/15562#issuecomment-846340998 This PR fixed some issues but isn't a complete fix (there are other ways the cleared TaskInstance can involve multiple DAGs. See [Cross-DAG

[airflow] branch constraints-master updated: Updating constraints. Build id:865578377

2021-05-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new a3178c1 Updating

[airflow] branch master updated: Fix failing spelling check on Master (#15998)

2021-05-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new ee470e1 Fix failing spelling check on

[GitHub] [airflow] kaxil merged pull request #15998: Fix failing spelling check on Master

2021-05-21 Thread GitBox
kaxil merged pull request #15998: URL: https://github.com/apache/airflow/pull/15998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] github-actions[bot] commented on pull request #15998: Fix failing spelling check on Master

2021-05-21 Thread GitBox
github-actions[bot] commented on pull request #15998: URL: https://github.com/apache/airflow/pull/15998#issuecomment-846325172 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] kaxil closed pull request #15995: Add flower service annotations in helm chart

2021-05-21 Thread GitBox
kaxil closed pull request #15995: URL: https://github.com/apache/airflow/pull/15995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] kaxil opened a new pull request #15998: Fix failing spelling check on Master

2021-05-21 Thread GitBox
kaxil opened a new pull request #15998: URL: https://github.com/apache/airflow/pull/15998 For some reason https://github.com/apache/airflow/pull/15972 was green -- Build docs was skipped for some reason (https://github.com/apache/airflow/runs/2634819101) which caused failing Master

[GitHub] [airflow] github-actions[bot] commented on pull request #15991: Bump pyupgrade v2.13.0 to v2.18.1

2021-05-21 Thread GitBox
github-actions[bot] commented on pull request #15991: URL: https://github.com/apache/airflow/pull/15991#issuecomment-846322902 [The Workflow run](https://github.com/apache/airflow/actions/runs/865545144) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] github-actions[bot] commented on pull request #15997: Add Docs for ``default_pool`` slots

2021-05-21 Thread GitBox
github-actions[bot] commented on pull request #15997: URL: https://github.com/apache/airflow/pull/15997#issuecomment-846322897 [The Workflow run](https://github.com/apache/airflow/actions/runs/865545144) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] o-nikolas commented on a change in pull request #15850: Add AWS DMS replication task operators

2021-05-21 Thread GitBox
o-nikolas commented on a change in pull request #15850: URL: https://github.com/apache/airflow/pull/15850#discussion_r636524649 ## File path: airflow/providers/amazon/aws/hooks/dms.py ## @@ -0,0 +1,222 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] o-nikolas commented on a change in pull request #15850: Add AWS DMS replication task operators

2021-05-21 Thread GitBox
o-nikolas commented on a change in pull request #15850: URL: https://github.com/apache/airflow/pull/15850#discussion_r636523602 ## File path: airflow/providers/amazon/aws/hooks/dms.py ## @@ -0,0 +1,222 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] github-actions[bot] commented on pull request #15181: Create the S3MultipleKeySensor for the s3 service for aws provider

2021-05-21 Thread GitBox
github-actions[bot] commented on pull request #15181: URL: https://github.com/apache/airflow/pull/15181#issuecomment-846315965 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on pull request #15206: [WIP] Bump sphinx-autoapi from 1.0.0 to 1.7.0

2021-05-21 Thread GitBox
github-actions[bot] commented on pull request #15206: URL: https://github.com/apache/airflow/pull/15206#issuecomment-846315960 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] potix2 commented on pull request #15973: Make scripts/ci/libraries Google Shell Guide Compliant

2021-05-21 Thread GitBox
potix2 commented on pull request #15973: URL: https://github.com/apache/airflow/pull/15973#issuecomment-846314571 @potiuk I have completed the task. Could you review this changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] jedcunningham commented on issue #15990: Logging bug in a long runs

2021-05-21 Thread GitBox
jedcunningham commented on issue #15990: URL: https://github.com/apache/airflow/issues/15990#issuecomment-846312161 @egS27, can you confirm if you have `enable_tcp_keepalive` set to True? If it isn't, can you try it with it enabled?

[GitHub] [airflow] kaxil edited a comment on pull request #15997: Add Docs for ``default_pool`` slots

2021-05-21 Thread GitBox
kaxil edited a comment on pull request #15997: URL: https://github.com/apache/airflow/pull/15997#issuecomment-846308256 > Hi All, > > Based on my testing changing the of `AIRFLOW__CORE__NON_POOLED_TASK_SLOT_COUNT` will not update the size of the pool. On a running environment of

[GitHub] [airflow] kaxil commented on pull request #15997: Add Docs for ``default_pool`` slots

2021-05-21 Thread GitBox
kaxil commented on pull request #15997: URL: https://github.com/apache/airflow/pull/15997#issuecomment-846308256 > Hi All, > > Based on my testing changing the of `AIRFLOW__CORE__NON_POOLED_TASK_SLOT_COUNT` will not update the size of the pool. On a running environment of you want

[GitHub] [airflow] andormarkus commented on pull request #15997: Add Docs for ``default_pool`` slots

2021-05-21 Thread GitBox
andormarkus commented on pull request #15997: URL: https://github.com/apache/airflow/pull/15997#issuecomment-846305710 Hi All, Based on my testing changing the of `AIRFLOW__CORE__NON_POOLED_TASK_SLOT_COUNT` will not update the size of the pool. On a running environment of you want

[airflow] branch master updated (9875f64 -> 8084cfb)

2021-05-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9875f64 `loadBalancerIP` and `annotations` for both Flower and Webserver (#15972) add 8084cfb Chart:

[GitHub] [airflow] kaxil merged pull request #15925: Cleanup gitsync

2021-05-21 Thread GitBox
kaxil merged pull request #15925: URL: https://github.com/apache/airflow/pull/15925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] kaxil closed issue #15900: Chart: Extra mounts with DAG persistence and gitsync

2021-05-21 Thread GitBox
kaxil closed issue #15900: URL: https://github.com/apache/airflow/issues/15900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] github-actions[bot] commented on pull request #15925: Cleanup gitsync

2021-05-21 Thread GitBox
github-actions[bot] commented on pull request #15925: URL: https://github.com/apache/airflow/pull/15925#issuecomment-846305613 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] dstandish commented on pull request #15995: Add flower service annotations in helm chart

2021-05-21 Thread GitBox
dstandish commented on pull request #15995: URL: https://github.com/apache/airflow/pull/15995#issuecomment-846303806 Ah ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] kaxil merged pull request #15972: loadBalancerIP and annotations for both flower and webserver

2021-05-21 Thread GitBox
kaxil merged pull request #15972: URL: https://github.com/apache/airflow/pull/15972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[airflow] branch master updated (bb43e06 -> 9875f64)

2021-05-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from bb43e06 Add more tests for the kubernetes executor (#15992) add 9875f64 `loadBalancerIP` and

[GitHub] [airflow] kaxil closed issue #12751: Helm Chart: Provide option to specify loadBalancerIP in webserver service

2021-05-21 Thread GitBox
kaxil closed issue #12751: URL: https://github.com/apache/airflow/issues/12751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] mik-laj commented on a change in pull request #15991: Bump pyupgrade v2.13.0 to v2.18.1

2021-05-21 Thread GitBox
mik-laj commented on a change in pull request #15991: URL: https://github.com/apache/airflow/pull/15991#discussion_r637291625 ## File path: airflow/executors/base_executor.py ## @@ -168,7 +168,7 @@ def order_queued_tasks_by_priority(self) -> List[Tuple[TaskInstanceKey,

[GitHub] [airflow] kaxil commented on pull request #15995: Add flower service annotations in helm chart

2021-05-21 Thread GitBox
kaxil commented on pull request #15995: URL: https://github.com/apache/airflow/pull/15995#issuecomment-846302579 @dstandish Looks like https://github.com/apache/airflow/pull/15972 already covered this and the other case too -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2021-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349502#comment-17349502 ] ASF GitHub Bot commented on AIRFLOW-5071: - tazimmerman commented on issue #10790: URL:

[GitHub] [airflow] tazimmerman commented on issue #10790: Copy of [AIRFLOW-5071] JIRA: Thousands of Executor reports task instance X finished (success) although the task says its queued. Was the task

2021-05-21 Thread GitBox
tazimmerman commented on issue #10790: URL: https://github.com/apache/airflow/issues/10790#issuecomment-846297186 I'm able to reproduce this using the standard `TimeDeltaSensor` with Airflow 1.10.14 and the `DaskExecutor`. The logs aren't helpful (at least to someone unfamiliar with the

[GitHub] [airflow] github-actions[bot] commented on pull request #15995: Add flower service annotations in helm chart

2021-05-21 Thread GitBox
github-actions[bot] commented on pull request #15995: URL: https://github.com/apache/airflow/pull/15995#issuecomment-846290657 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] dstandish commented on a change in pull request #15995: Add flower service annotations in helm chart

2021-05-21 Thread GitBox
dstandish commented on a change in pull request #15995: URL: https://github.com/apache/airflow/pull/15995#discussion_r637260878 ## File path: chart/templates/flower/flower-service.yaml ## @@ -33,6 +33,10 @@ metadata: {{- with .Values.labels }} {{ toYaml . | indent 4 }} {{-

[airflow] branch master updated (aa4713e -> bb43e06)

2021-05-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from aa4713e Use api version only in GoogleAdsHook not operators (#15266) add bb43e06 Add more tests for the

[GitHub] [airflow] kaxil merged pull request #15992: Add more tests for the kubernetes executor

2021-05-21 Thread GitBox
kaxil merged pull request #15992: URL: https://github.com/apache/airflow/pull/15992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] kaxil opened a new pull request #15997: Add Docs for ``default_pool`` slots

2021-05-21 Thread GitBox
kaxil opened a new pull request #15997: URL: https://github.com/apache/airflow/pull/15997 Until now this was undocumented, however it was used in: https://github.com/apache/airflow/blob/aa4713e43f92d3e4c68c3ad00e2d44caaf29aafe/airflow/utils/db.py#L75 This was done in 1.10.4 in

[GitHub] [airflow] uranusjr commented on a change in pull request #15991: Bump pyupgrade v2.13.0 to v2.18.1

2021-05-21 Thread GitBox
uranusjr commented on a change in pull request #15991: URL: https://github.com/apache/airflow/pull/15991#discussion_r637254797 ## File path: airflow/executors/base_executor.py ## @@ -168,7 +168,7 @@ def order_queued_tasks_by_priority(self) -> List[Tuple[TaskInstanceKey,

[GitHub] [airflow] kaxil commented on a change in pull request #15995: Add flower service annotations in helm chart

2021-05-21 Thread GitBox
kaxil commented on a change in pull request #15995: URL: https://github.com/apache/airflow/pull/15995#discussion_r637250279 ## File path: chart/templates/flower/flower-service.yaml ## @@ -33,6 +33,10 @@ metadata: {{- with .Values.labels }} {{ toYaml . | indent 4 }} {{- end

[GitHub] [airflow] ephraimbuddy commented on pull request #15939: Add CI test for helm upgrade with different Executors

2021-05-21 Thread GitBox
ephraimbuddy commented on pull request #15939: URL: https://github.com/apache/airflow/pull/15939#issuecomment-846271893 Hi @potiuk, I'm lost on this particular error. Please take a look. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] kaxil opened a new issue #15996: Move `UPDATING.md` to actual docs

2021-05-21 Thread GitBox
kaxil opened a new issue #15996: URL: https://github.com/apache/airflow/issues/15996 Currently, there are 2 places users need to look into when updating an Airflow Version: * Changelog: https://airflow.apache.org/docs/apache-airflow/2.1.0/changelog.html * Updating.md:

[GitHub] [airflow] dstandish opened a new pull request #15995: Add flower service annotations in helm chart

2021-05-21 Thread GitBox
dstandish opened a new pull request #15995: URL: https://github.com/apache/airflow/pull/15995 Annotations are necessary to run flower with a load balancer in a private subnet. Prior to this commit annotations were supported for webserver but not for flower. -- This is an automated

[GitHub] [airflow] leahecole commented on issue #15994: Use inclusive words in Apache Airflow project

2021-05-21 Thread GitBox
leahecole commented on issue #15994: URL: https://github.com/apache/airflow/issues/15994#issuecomment-846255023 Love it. A couple of clarifying questions - If I'm understanding correctly, the pre commit check is preventing the introduction of new instances of these words, but these

[GitHub] [airflow] freget commented on a change in pull request #15964: SSHHook: Using correct hostname for host_key when using non-default ssh port

2021-05-21 Thread GitBox
freget commented on a change in pull request #15964: URL: https://github.com/apache/airflow/pull/15964#discussion_r637205628 ## File path: airflow/providers/ssh/hooks/ssh.py ## @@ -218,7 +218,8 @@ def get_conn(self) -> paramiko.SSHClient: else: if

[GitHub] [airflow] anitakar commented on issue #15933: Consider splitting Google Provider

2021-05-21 Thread GitBox
anitakar commented on issue #15933: URL: https://github.com/apache/airflow/issues/15933#issuecomment-846186534 Hey, So maybe without big upfront design and trying to solve the problem of backwards compatibility for all cases, let's create another package for leveldb. I could

[GitHub] [airflow] kaxil commented on issue #15933: Consider splitting Google Provider

2021-05-21 Thread GitBox
kaxil commented on issue #15933: URL: https://github.com/apache/airflow/issues/15933#issuecomment-846179554 Agree with @turbaszek -- The best judge of the split is the company itself -- so according to me that would best. However, if Google does not want to do that, we should separate

[GitHub] [airflow] turbaszek commented on issue #15933: Consider splitting Google Provider

2021-05-21 Thread GitBox
turbaszek commented on issue #15933: URL: https://github.com/apache/airflow/issues/15933#issuecomment-846175099 > I think a cleaner solution would be if leveldb was made a distinct provider +1 to that, I think we had similar discussion about salesforce, tableau and slack (Salesforce

[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

2021-05-21 Thread GitBox
turbaszek commented on issue #15994: URL: https://github.com/apache/airflow/issues/15994#issuecomment-846155364 CC @leahecole -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] turbaszek opened a new issue #15994: Use inclusive words in Apache Airflow project

2021-05-21 Thread GitBox
turbaszek opened a new issue #15994: URL: https://github.com/apache/airflow/issues/15994 **Description** Apache Software Foundation is discussing how we can improve inclusiveness of projects and raise awareness of conscious language. Related thread on diversity@a.o:

[GitHub] [airflow] wahsmail commented on issue #15752: Airflow UI tree view: mark (success|failed) (past|future) only marking selected task instance

2021-05-21 Thread GitBox
wahsmail commented on issue #15752: URL: https://github.com/apache/airflow/issues/15752#issuecomment-846146800 Bump @jedcunningham -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] ashb commented on issue #15938: celery_executor becomes stuck if child process receives signal before reset_signals is called

2021-05-21 Thread GitBox
ashb commented on issue #15938: URL: https://github.com/apache/airflow/issues/15938#issuecomment-846143436 I have _no_ problem with us not using multiprocessing - this isn't or first such problem like this -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] bbovenzi commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
bbovenzi commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r637101562 ## File path: airflow/www/static/js/connection_form.js ## @@ -140,6 +140,55 @@ $(document).ready(function () { } } + $.fn.serializeObject =

[GitHub] [airflow] github-actions[bot] commented on pull request #15992: Add more tests for the kubernetes executor

2021-05-21 Thread GitBox
github-actions[bot] commented on pull request #15992: URL: https://github.com/apache/airflow/pull/15992#issuecomment-846139058 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] github-actions[bot] commented on pull request #15991: Bump pyupgrade v2.13.0 to v2.18.1

2021-05-21 Thread GitBox
github-actions[bot] commented on pull request #15991: URL: https://github.com/apache/airflow/pull/15991#issuecomment-846134408 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] bpleines edited a comment on issue #15670: Pod overrides not working

2021-05-21 Thread GitBox
bpleines edited a comment on issue #15670: URL: https://github.com/apache/airflow/issues/15670#issuecomment-846125695 Thanks for the example @kaxil. Understood if you want to keep the discussion for `2.0+` only, but wanted to note that I don't think this pod_override strategy works for

[GitHub] [airflow] bpleines commented on issue #15670: Pod overrides not working

2021-05-21 Thread GitBox
bpleines commented on issue #15670: URL: https://github.com/apache/airflow/issues/15670#issuecomment-846125695 Thanks for the example @kaxil. Understood if you want to keep the discussion for `2.0+` only, but wanted to note that I don't think this pod_override strategy works for

[GitHub] [airflow] uranusjr opened a new pull request #15993: A bunch of web UI backend tests

2021-05-21 Thread GitBox
uranusjr opened a new pull request #15993: URL: https://github.com/apache/airflow/pull/15993 Toward #15525. See individual commit messages for what views exactly were covered. This brings the coverage of `airflow.www.views` to 85%. There's one test marked as xfail due to an

[GitHub] [airflow] ephraimbuddy opened a new pull request #15992: Add more tests for the kubernetes executor

2021-05-21 Thread GitBox
ephraimbuddy opened a new pull request #15992: URL: https://github.com/apache/airflow/pull/15992 This change adds tests to improve coverage for the Kubernetes executor Part of https://github.com/apache/airflow/issues/15523 --- **^ Add meaningful description above** Read

[GitHub] [airflow] mik-laj commented on a change in pull request #15582: Add more typing to airflow.utils.helpers

2021-05-21 Thread GitBox
mik-laj commented on a change in pull request #15582: URL: https://github.com/apache/airflow/pull/15582#discussion_r637057400 ## File path: airflow/utils/helpers.py ## @@ -21,7 +21,7 @@ from datetime import datetime from functools import reduce from itertools import

[GitHub] [airflow] mik-laj opened a new pull request #15991: Bump pyupgrade v2.13.0 to v2.18.1

2021-05-21 Thread GitBox
mik-laj opened a new pull request #15991: URL: https://github.com/apache/airflow/pull/15991 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more

[airflow] tag 2.1.0 created (now 304e174)

2021-05-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to tag 2.1.0 in repository https://gitbox.apache.org/repos/asf/airflow.git. at 304e174 (commit) No new revisions were added by this update.

[airflow] tag constraints-2.1.0 created (now f76740c)

2021-05-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to tag constraints-2.1.0 in repository https://gitbox.apache.org/repos/asf/airflow.git. at f76740c (commit) No new revisions were added by this update.

[GitHub] [airflow] CatarinaSilva commented on issue #15670: Pod overrides not working

2021-05-21 Thread GitBox
CatarinaSilva commented on issue #15670: URL: https://github.com/apache/airflow/issues/15670#issuecomment-846030371 hey @kaxil I can confirm the requests and limits are working with the new way in 2.0.2 -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch constraints-master updated: Updating constraints. Build id:863239980

2021-05-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new 1ca5ada Updating

[GitHub] [airflow] mik-laj commented on a change in pull request #15945: Extract database options to new section

2021-05-21 Thread GitBox
mik-laj commented on a change in pull request #15945: URL: https://github.com/apache/airflow/pull/15945#discussion_r636986700 ## File path: scripts/ci/docker-compose/backend-mysql.yml ## @@ -20,8 +20,8 @@ services: airflow: environment: - BACKEND=mysql - -

[GitHub] [airflow] mik-laj commented on a change in pull request #15945: Extract database options to new section

2021-05-21 Thread GitBox
mik-laj commented on a change in pull request #15945: URL: https://github.com/apache/airflow/pull/15945#discussion_r636987661 ## File path: scripts/in_container/prod/entrypoint_prod.sh ## @@ -201,11 +201,11 @@ function wait_for_airflow_db() { # then uses netcat to

[GitHub] [airflow] mik-laj closed issue #15977: SalesforceToGcsOperator requires additional packages

2021-05-21 Thread GitBox
mik-laj closed issue #15977: URL: https://github.com/apache/airflow/issues/15977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] mik-laj commented on a change in pull request #15945: Extract database options to new section

2021-05-21 Thread GitBox
mik-laj commented on a change in pull request #15945: URL: https://github.com/apache/airflow/pull/15945#discussion_r636985154 ## File path: airflow/kubernetes/pod_template_file_examples/dags_in_image_template.yaml ## @@ -36,7 +36,7 @@ spec: secretKeyRef:

[GitHub] [airflow] yuqian90 commented on a change in pull request #15989: Fix Celery executor getting stuck randomly because of reset_signals in multiprocessing

2021-05-21 Thread GitBox
yuqian90 commented on a change in pull request #15989: URL: https://github.com/apache/airflow/pull/15989#discussion_r636976979 ## File path: scripts/ci/docker-compose/base.yml ## @@ -34,6 +34,8 @@ services: ports: - "${WEBSERVER_HOST_PORT}:8080" -

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15990: Logging bug in a long runs

2021-05-21 Thread GitBox
boring-cyborg[bot] commented on issue #15990: URL: https://github.com/apache/airflow/issues/15990#issuecomment-846000749 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on a change in pull request #15945: Extract database options to new section

2021-05-21 Thread GitBox
mik-laj commented on a change in pull request #15945: URL: https://github.com/apache/airflow/pull/15945#discussion_r636983257 ## File path: airflow/config_templates/config.yml ## @@ -436,6 +322,124 @@ example: ~ default: "" +- name: database + description: ~ +

[GitHub] [airflow] yuqian90 edited a comment on issue #15938: celery_executor becomes stuck if child process receives signal before reset_signals is called

2021-05-21 Thread GitBox
yuqian90 edited a comment on issue #15938: URL: https://github.com/apache/airflow/issues/15938#issuecomment-845994258 > Just how slow does it have to be to happen? > We can probably guard this by closing of the current pid when we register them, and checking that the signal is received

[GitHub] [airflow] mik-laj commented on issue #15977: SalesforceToGcsOperator requires additional packages

2021-05-21 Thread GitBox
mik-laj commented on issue #15977: URL: https://github.com/apache/airflow/issues/15977#issuecomment-846003928 This dependency is listed in "Cross provider package dependencies" section. See: https://pypi.org/project/apache-airflow-backport-providers-google/ Additionally, we do not

[GitHub] [airflow] egS27 opened a new issue #15990: Logging bug in a long runs

2021-05-21 Thread GitBox
egS27 opened a new issue #15990: URL: https://github.com/apache/airflow/issues/15990 **Apache Airflow version**: 2.0.2 **Environment**: Kubernetes v1.18.3+cdb0358 Openshift 4.5.37_1536 **What happened**: We are running our python code in kubernetes

[GitHub] [airflow] yuqian90 commented on issue #15938: celery_executor becomes stuck if child process receives signal before reset_signals is called

2021-05-21 Thread GitBox
yuqian90 commented on issue #15938: URL: https://github.com/apache/airflow/issues/15938#issuecomment-845994258 > Just how slow does it have to be to happen? > We can probably guard this by closing of the current pid when we register them, and checking that the signal is received by the

[GitHub] [airflow] yuqian90 opened a new pull request #15989: Fix Celery executor getting stuck randomly because of reset_signals in multiprocessing

2021-05-21 Thread GitBox
yuqian90 opened a new pull request #15989: URL: https://github.com/apache/airflow/pull/15989 Fixes #15938 `multiprocessing.Pool` is known to often become stuck. It causes celery_executor to hang randomly. This happens at least on Debian, Ubuntu using Python 3.8.7 and Python 3.8.10.

[GitHub] [airflow] mtrovo commented on issue #15675: Add optional justification when pausing a DAG

2021-05-21 Thread GitBox
mtrovo commented on issue #15675: URL: https://github.com/apache/airflow/issues/15675#issuecomment-845987453 Sure, go for it. I still didn't start anything on my end. On Thu, 20 May 2021 at 14:22, dillan teagle ***@***.***> wrote: > @mtrovo I

[GitHub] [airflow] uranusjr opened a new issue #15986: Deleting a DagRun from UI does not delete its associated tasks

2021-05-21 Thread GitBox
uranusjr opened a new issue #15986: URL: https://github.com/apache/airflow/issues/15986 **Apache Airflow version**: master When DagRuns are selected in the UI for deletion, a request is sent to the `DagRunModelView.action_muldelete`, a Flask-Appbuilder action:

[GitHub] [airflow] eladkal commented on issue #11134: Not able to delete the DAG from UI -

2021-05-21 Thread GitBox
eladkal commented on issue #11134: URL: https://github.com/apache/airflow/issues/11134#issuecomment-845954364 @Gaurang033 Airflow 1.10 is EOL Closing as its working fine on Master (also https://github.com/apache/airflow/issues/15832 is fixed) -- This is an automated message from the

[GitHub] [airflow] eladkal closed issue #11134: Not able to delete the DAG from UI -

2021-05-21 Thread GitBox
eladkal closed issue #11134: URL: https://github.com/apache/airflow/issues/11134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15985: Airflow UI displays \n instead of line break

2021-05-21 Thread GitBox
boring-cyborg[bot] commented on issue #15985: URL: https://github.com/apache/airflow/issues/15985#issuecomment-845948091 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] DylanCuure opened a new issue #15985: Airflow UI displays \n instead of line break

2021-05-21 Thread GitBox
DylanCuure opened a new issue #15985: URL: https://github.com/apache/airflow/issues/15985 **Apache Airflow version**: v2.0.1 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): v1.19.7 **What happened**: Using remote logging, logs are

[GitHub] [airflow] eladkal commented on issue #10160: Airflow cannot read files in Packaged DAGs folder.

2021-05-21 Thread GitBox
eladkal commented on issue #10160: URL: https://github.com/apache/airflow/issues/10160#issuecomment-845947802 Is the issue still happens in Airflow 2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow-site] ashb merged pull request #424: Add documentation for Apache Airflow 2.1.0

2021-05-21 Thread GitBox
ashb merged pull request #424: URL: https://github.com/apache/airflow-site/pull/424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] CatarinaSilva commented on issue #15670: Pod overrides not working

2021-05-21 Thread GitBox
CatarinaSilva commented on issue #15670: URL: https://github.com/apache/airflow/issues/15670#issuecomment-845924350 Thanks @kaxil currently testing with the new format, will let you know if it works -- This is an automated message from the Apache Git Service. To respond to the message,

[airflow-site] branch docs-2.1.0 created (now ad8b05e)

2021-05-21 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch docs-2.1.0 in repository https://gitbox.apache.org/repos/asf/airflow-site.git. at ad8b05e Add documentation for Apache Airflow 2.1.0 No new revisions were added by this update.

[GitHub] [airflow] github-actions[bot] commented on pull request #15981: Properly remove user for test_create_user for it to work against a dirty database

2021-05-21 Thread GitBox
github-actions[bot] commented on pull request #15981: URL: https://github.com/apache/airflow/pull/15981#issuecomment-845921770 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] ashb commented on pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
ashb commented on pull request #15795: URL: https://github.com/apache/airflow/pull/15795#issuecomment-845920577 I wonder if we should special case and detect the case when the API is disabled and disable the form control with a tool tip? -- This is an automated message from the Apache

svn commit: r47854 - /dev/airflow/2.1.0rc2/ /release/airflow/2.0.2/ /release/airflow/2.1.0/

2021-05-21 Thread ash
Author: ash Date: Fri May 21 12:35:51 2021 New Revision: 47854 Log: Release Apache Airflow 2.1.0 Added: release/airflow/2.1.0/ - copied from r47853, dev/airflow/2.1.0rc2/ Removed: dev/airflow/2.1.0rc2/ release/airflow/2.0.2/

[GitHub] [airflow] msumit commented on pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
msumit commented on pull request #15795: URL: https://github.com/apache/airflow/pull/15795#issuecomment-845918626 > Oh. Oh no. > > By default, the REST API is set to deny_all, meaning that out of the box the test button won't work :( Yeah, just realized this while chatting

[GitHub] [airflow] ashb commented on pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
ashb commented on pull request #15795: URL: https://github.com/apache/airflow/pull/15795#issuecomment-845916860 Oh. Oh no. By default, the REST API is set to deny_all, meaning that out of the box the test button won't work :( -- This is an automated message from the Apache Git

[GitHub] [airflow] ashb commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
ashb commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636879142 ## File path: airflow/www/templates/airflow/conn_edit_form.html ## @@ -0,0 +1,81 @@ +{# +Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] [airflow] msumit commented on a change in pull request #15795: Ability to test connections from UI or API

2021-05-21 Thread GitBox
msumit commented on a change in pull request #15795: URL: https://github.com/apache/airflow/pull/15795#discussion_r636875999 ## File path: airflow/www/templates/airflow/conn_edit_form.html ## @@ -0,0 +1,81 @@ +{# +Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] [airflow] BKronenbitter commented on pull request #15634: Fix multiple issues in Microsoft AzureContainerInstancesOperator

2021-05-21 Thread GitBox
BKronenbitter commented on pull request #15634: URL: https://github.com/apache/airflow/pull/15634#issuecomment-845912812 > > I am not sure, to what degree these errors are caused by the changes in the PR. > > Likely None. I will close/reopen to trigger the build again. How do

[jira] [Commented] (AIRFLOW-6786) Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor

2021-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349239#comment-17349239 ] ASF GitHub Bot commented on AIRFLOW-6786: - dferguson992 opened a new pull request #12388: URL:

[jira] [Commented] (AIRFLOW-6786) Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor

2021-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349240#comment-17349240 ] ASF GitHub Bot commented on AIRFLOW-6786: - ashb commented on pull request #12388: URL:

[GitHub] [airflow] ashb commented on pull request #12388: [AIRFLOW-6786] Added Kafka components, 3rd time's the charm

2021-05-21 Thread GitBox
ashb commented on pull request #12388: URL: https://github.com/apache/airflow/pull/12388#issuecomment-845912208 Yup, I'll pick this up and finish it off/get it over the line. Sorry I forgot about it (AGAIN!) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] dferguson992 opened a new pull request #12388: [AIRFLOW-6786] Added Kafka components, 3rd time's the charm

2021-05-21 Thread GitBox
dferguson992 opened a new pull request #12388: URL: https://github.com/apache/airflow/pull/12388 Dear Airflow Maintainers, Please accept the following PR that Add the KafkaProducerHook. Add the KafkaConsumerHook. Add the KafkaSensor which listens to messages with a

  1   2   >