[GitHub] [airflow] potiuk commented on pull request #29888: Move help message to the google auth code

2023-03-02 Thread via GitHub
potiuk commented on PR #29888: URL: https://github.com/apache/airflow/pull/29888#issuecomment-1453119981 inlined all the constants now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on pull request #29888: Move help message to the google auth code

2023-03-02 Thread via GitHub
potiuk commented on PR #29888: URL: https://github.com/apache/airflow/pull/29888#issuecomment-1453118275 > I wonder if we should just move all the underscore variables. Yeah. I was on the fence with this one, but I realized this is far more than our test's problem. Right now if

[GitHub] [airflow] potiuk closed pull request #29888: Move help message to the google auth code

2023-03-02 Thread via GitHub
potiuk closed pull request #29888: Move help message to the google auth code URL: https://github.com/apache/airflow/pull/29888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] shahar1 commented on issue #10596: Add support for impersonation in GKEStartPodOperator, DataflowCreateJavaJobOperator and DataflowCreatePythonJobOperator

2023-03-02 Thread via GitHub
shahar1 commented on issue #10596: URL: https://github.com/apache/airflow/issues/10596#issuecomment-1453096326 I've been trying to resolve this issue, and it seems that: - `GKEStartPodOperator` currently supports an impersonation chain. (#19518) - `DataflowCreateJavaJobOperator` and

[GitHub] [airflow] josh-fell opened a new pull request, #29892: Add testing a connection via Airflow CLI

2023-03-02 Thread via GitHub
josh-fell opened a new pull request, #29892: URL: https://github.com/apache/airflow/pull/29892 Closes: #29875 This PR introduces a new Airflow CLI command -- `airflow connections test ` -- to test a single, predefined Airflow connection. _Successful test_

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29832: Add `_on_failure_fail_dagrun` attribute for teardown tasks

2023-03-02 Thread via GitHub
ephraimbuddy commented on code in PR #29832: URL: https://github.com/apache/airflow/pull/29832#discussion_r1124058690 ## airflow/utils/task_group.py: ## @@ -245,6 +245,8 @@ def add(self, task: DAGNode) -> None: elif SetupTeardownContext.is_teardown: if

[GitHub] [airflow] ephraimbuddy opened a new pull request, #29891: Classic TaskGroup setup/teardown

2023-03-02 Thread via GitHub
ephraimbuddy opened a new pull request, #29891: URL: https://github.com/apache/airflow/pull/29891 This implements the classic TaskGroup setup/teardown. Ensures that nested TaskGroups are taken into account -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] uranusjr commented on a diff in pull request #29850: Fixing broken filter in in /taskinstance/list view

2023-03-02 Thread via GitHub
uranusjr commented on code in PR #29850: URL: https://github.com/apache/airflow/pull/29850#discussion_r1124054180 ## airflow/models/taskinstance.py: ## @@ -139,6 +139,10 @@ from airflow.models.operator import Operator from airflow.utils.task_group import

[GitHub] [airflow] uranusjr commented on pull request #29815: Add retry to the scheduler loop to protect against DB hiccups

2023-03-02 Thread via GitHub
uranusjr commented on PR #29815: URL: https://github.com/apache/airflow/pull/29815#issuecomment-1453013130 There are multiple db commits in the block and I wonder if the internal state would be messed up if the db fails midway through and the entire block got rerun. -- This is an

[GitHub] [airflow] uranusjr commented on a diff in pull request #29689: Add location to CloudBuildCreateBuildOperator

2023-03-02 Thread via GitHub
uranusjr commented on code in PR #29689: URL: https://github.com/apache/airflow/pull/29689#discussion_r1124049541 ## airflow/providers/google/cloud/hooks/cloud_build.py: ## @@ -158,13 +159,17 @@ def create_build_without_waiting_for_result( :param timeout: Optional, the

[GitHub] [airflow] uranusjr commented on pull request #29842: Allow for templated args to be passed to the result_processor function in the GithubSensor fixing templated tags in GithubTagSensor

2023-03-02 Thread via GitHub
uranusjr commented on PR #29842: URL: https://github.com/apache/airflow/pull/29842#issuecomment-1453008723 THe breakage sounds reasonable if we bump the GitHub provider to 3.0.0. So the question would be, is having the kwarg default to true a good idea? Let’s bump if it is. -- This is

[GitHub] [airflow] uranusjr commented on a diff in pull request #29840: DatabricksSubmitRunOperator to support taskflow

2023-03-02 Thread via GitHub
uranusjr commented on code in PR #29840: URL: https://github.com/apache/airflow/pull/29840#discussion_r1124046647 ## airflow/providers/databricks/operators/databricks.py: ## @@ -285,12 +285,12 @@ def __init__( *, json: Any | None = None, tasks:

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29890: Import error for dagfactory module

2023-03-02 Thread via GitHub
boring-cyborg[bot] commented on issue #29890: URL: https://github.com/apache/airflow/issues/29890#issuecomment-1453001049 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] Narsimha1997 opened a new issue, #29890: Import error for dagfactory module

2023-03-02 Thread via GitHub
Narsimha1997 opened a new issue, #29890: URL: https://github.com/apache/airflow/issues/29890 ### Apache Airflow version 2.5.1 ### What happened Iam running airflow version 2.3.0 through docker and python version is 3.10.6, i installed dag-factory python module using pip

[GitHub] [airflow] abin-tiger commented on issue #28751: KubernetesExecutor leaves failed pods due to deepcopy issue with Google providers

2023-03-02 Thread via GitHub
abin-tiger commented on issue #28751: URL: https://github.com/apache/airflow/issues/28751#issuecomment-1452996944 We're facing the same issue when using KubernetesExecutor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] ftaib commented on issue #27545: missing volumes for git-sync-ssh-key

2023-03-02 Thread via GitHub
ftaib commented on issue #27545: URL: https://github.com/apache/airflow/issues/27545#issuecomment-1452938150 When will the new Helm Chart be available with this changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] ftaib commented on issue #27476: Volume is missing for sshKeySecret when dag persistence is enabled.

2023-03-02 Thread via GitHub
ftaib commented on issue #27476: URL: https://github.com/apache/airflow/issues/27476#issuecomment-1452930037 Hi, may I know when will the new Helm Chart will be available with the changes above? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] uranusjr commented on pull request #29888: Move help message to the google auth code

2023-03-02 Thread via GitHub
uranusjr commented on PR #29888: URL: https://github.com/apache/airflow/pull/29888#issuecomment-1452928059 I wonder if we should just move all the underscore variables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] uranusjr commented on pull request #29609: Decouple production executor warning in dags UI

2023-03-02 Thread via GitHub
uranusjr commented on PR #29609: URL: https://github.com/apache/airflow/pull/29609#issuecomment-1452912263 Scraping it sounds reasonable to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] josh-fell commented on a diff in pull request #29694: `GoogleDriveHook`: Fixing log message + adding more verbose documentation

2023-03-02 Thread via GitHub
josh-fell commented on code in PR #29694: URL: https://github.com/apache/airflow/pull/29694#discussion_r1123963291 ## airflow/providers/google/suite/hooks/drive.py: ## @@ -243,8 +300,21 @@ def upload_file( .create(body=file_metadata, media_body=media, fields="id",

[GitHub] [airflow] agentdanger commented on issue #29444: Attempting to Upgrade Chart to Enable Examples Causes Postgres Error

2023-03-02 Thread via GitHub
agentdanger commented on issue #29444: URL: https://github.com/apache/airflow/issues/29444#issuecomment-1452826643 I was able to solve this issue by installing 1.8 with the configured yaml file. My namespace for this implementation was colosseum. I had a custom yaml filed

[GitHub] [airflow] github-actions[bot] closed issue #17977: DagRun marked as success without executing task

2023-03-02 Thread via GitHub
github-actions[bot] closed issue #17977: DagRun marked as success without executing task URL: https://github.com/apache/airflow/issues/17977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] github-actions[bot] commented on issue #17977: DagRun marked as success without executing task

2023-03-02 Thread via GitHub
github-actions[bot] commented on issue #17977: URL: https://github.com/apache/airflow/issues/17977#issuecomment-1452821207 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] closed pull request #24652: Add ``@task.snowpark`` decorator

2023-03-02 Thread via GitHub
github-actions[bot] closed pull request #24652: Add ``@task.snowpark`` decorator URL: https://github.com/apache/airflow/pull/24652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] hussein-awala commented on issue #29833: Celery tasks stuck in queued state after worker crash (Set changed size during iteration)

2023-03-02 Thread via GitHub
hussein-awala commented on issue #29833: URL: https://github.com/apache/airflow/issues/29833#issuecomment-1452785595 Can you extract the ti state from the DB for a task stuck in queued state? ```sql SELECT * FROM task_instance WHERE dag_id='' AND task_id='' AND execution_date=''

[GitHub] [airflow] o-nikolas commented on pull request #29609: Decouple production executor warning in dags UI

2023-03-02 Thread via GitHub
o-nikolas commented on PR #29609: URL: https://github.com/apache/airflow/pull/29609#issuecomment-1452761063 Thoughts on the above anyone? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] o-nikolas commented on pull request #29469: Updates to provider release verification documentation and check_files to produce a more useful Dockerfile

2023-03-02 Thread via GitHub
o-nikolas commented on PR #29469: URL: https://github.com/apache/airflow/pull/29469#issuecomment-1452742994 @potiuk I think this one is now ready for another round of review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-03-02 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1123866188 ## airflow/kubernetes/kube_client.py: ## @@ -105,16 +107,24 @@ def get_kube_client( if conf.getboolean("kubernetes_executor", "enable_tcp_keepalive"):

[GitHub] [airflow] potiuk closed pull request #29888: Move help message to the google auth code

2023-03-02 Thread via GitHub
potiuk closed pull request #29888: Move help message to the google auth code URL: https://github.com/apache/airflow/pull/29888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk commented on pull request #29888: Move help message to the google auth code

2023-03-02 Thread via GitHub
potiuk commented on PR #29888: URL: https://github.com/apache/airflow/pull/29888#issuecomment-1452721246 Should fix failing "canary" main build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk opened a new pull request, #29888: Move help message to the google auth code

2023-03-02 Thread via GitHub
potiuk opened a new pull request, #29888: URL: https://github.com/apache/airflow/pull/29888 The "google-auth" 2.16.2 just released, removed the _HELP_MESSAGE that was imported by google provider auth util thus failing the imports in canary builds of ours attempting to upgrade to newver

[GitHub] [airflow] raphaelauv commented on issue #27292: Support for Python 3.11 for Google Provider (upgrading all dependencies)

2023-03-02 Thread via GitHub
raphaelauv commented on issue #27292: URL: https://github.com/apache/airflow/issues/27292#issuecomment-1452712966 I din't found a working constraint for google-cloud-aiplatform for apache-airflow-providers-google==8.10.0 with python 3.11 -- This is an automated message from the Apache

[GitHub] [airflow] potiuk commented on issue #27292: Support for Python 3.11 for Google Provider (upgrading all dependencies)

2023-03-02 Thread via GitHub
potiuk commented on issue #27292: URL: https://github.com/apache/airflow/issues/27292#issuecomment-1452700803 Cool. Time to try 3.11 build back then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk closed issue #29828: JSON Schema Validation errors for Params prevent DAG from importing and errors are not shown

2023-03-02 Thread via GitHub
potiuk closed issue #29828: JSON Schema Validation errors for Params prevent DAG from importing and errors are not shown URL: https://github.com/apache/airflow/issues/29828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] potiuk commented on issue #29828: JSON Schema Validation errors for Params prevent DAG from importing and errors are not shown

2023-03-02 Thread via GitHub
potiuk commented on issue #29828: URL: https://github.com/apache/airflow/issues/29828#issuecomment-1452699881 Fixed in #29056 then. Closing as essentially duplicate of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] raphaelauv commented on issue #27292: Support for Python 3.11 for Google Provider (upgrading all dependencies)

2023-03-02 Thread via GitHub
raphaelauv commented on issue #27292: URL: https://github.com/apache/airflow/issues/27292#issuecomment-1452686038 https://github.com/googleapis/python-translate/releases/tag/v3.10.0 oogle-cloud-translat :heavy_check_mark:

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #28869: rewrite polling code for appflow hook

2023-03-02 Thread via GitHub
vandonr-amz commented on code in PR #28869: URL: https://github.com/apache/airflow/pull/28869#discussion_r1123823559 ## airflow/providers/amazon/aws/hooks/appflow.py: ## @@ -54,49 +50,35 @@ def conn(self) -> AppflowClient: """Get the underlying boto3 Appflow client

[airflow] branch main updated: Fix Amazon ECS Enums (#29871)

2023-03-02 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 76d8aaa836 Fix Amazon ECS Enums (#29871)

[GitHub] [airflow] o-nikolas merged pull request #29871: Fix Amazon ECS Enums

2023-03-02 Thread via GitHub
o-nikolas merged PR #29871: URL: https://github.com/apache/airflow/pull/29871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] SamWheating commented on issue #29828: JSON Schema Validation errors for Params prevent DAG from importing and errors are not shown

2023-03-02 Thread via GitHub
SamWheating commented on issue #29828: URL: https://github.com/apache/airflow/issues/29828#issuecomment-1452638928 This was inadvertently fixed in https://github.com/apache/airflow/pull/29056, where the `Except` in `_process_modules` was modified to catch any exceptions. Can

[GitHub] [airflow] agentdanger commented on issue #29444: Attempting to Upgrade Chart to Enable Examples Causes Postgres Error

2023-03-02 Thread via GitHub
agentdanger commented on issue #29444: URL: https://github.com/apache/airflow/issues/29444#issuecomment-1452631098 I'm caveating my "no issue" suggestion above. I'm currently working through bugs on the git-sync but those could be my own doing. My work around was able to solve the

[GitHub] [airflow] agentdanger commented on issue #29444: Attempting to Upgrade Chart to Enable Examples Causes Postgres Error

2023-03-02 Thread via GitHub
agentdanger commented on issue #29444: URL: https://github.com/apache/airflow/issues/29444#issuecomment-1452620409 I was able to resolve this issue. Upgrading also refers to upgrading the existing 1.8 instance. You have to follow @potiuk suggestion within the release notes.

[GitHub] [airflow] SamWheating commented on issue #29844: ComputeEngineInsertInstanceFromTemplateOperator fails to parse SEV_SNP_CAPABLE in guestOsFeatures disk field

2023-03-02 Thread via GitHub
SamWheating commented on issue #29844: URL: https://github.com/apache/airflow/issues/29844#issuecomment-1452592062 Could you run `pip list` and share your results? I suspect that this is due to an older version of the `google-cloud-compute` library. -- This is an automated message from

[GitHub] [airflow] agentdanger commented on issue #29444: Attempting to Upgrade Chart to Enable Examples Causes Postgres Error

2023-03-02 Thread via GitHub
agentdanger commented on issue #29444: URL: https://github.com/apache/airflow/issues/29444#issuecomment-1452576191 I get the issue when I do a helm upgrade to install the custom values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] agentdanger commented on issue #29444: Attempting to Upgrade Chart to Enable Examples Causes Postgres Error

2023-03-02 Thread via GitHub
agentdanger commented on issue #29444: URL: https://github.com/apache/airflow/issues/29444#issuecomment-1452573578 I can recreate this issue by doing a fresh install using the 1.8 helm image "my-airflow", in a fresh namespace on kubernetes, and customizing the values.yaml to attempt to

[GitHub] [airflow] ferruzzi commented on issue #29640: NoBoundaryInMultipartDefect raised using S3Hook

2023-03-02 Thread via GitHub
ferruzzi commented on issue #29640: URL: https://github.com/apache/airflow/issues/29640#issuecomment-1452530133 @antonio-antuan I am trying to reopen [the ticket](https://github.com/boto/botocore/issues/2608) that Taragolis found on the botocore side. It looks like it has been raised a

[airflow] branch main updated (372ea492e5 -> ab066b5823)

2023-03-02 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 372ea492e5 Update sftp_to_s3.rst (#29869) add ab066b5823 Add note about k8s version support (#29884) No

[GitHub] [airflow] jedcunningham merged pull request #29884: Add note about k8s version support

2023-03-02 Thread via GitHub
jedcunningham merged PR #29884: URL: https://github.com/apache/airflow/pull/29884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] o-nikolas commented on pull request #29772: Support deleting the local log files when using remote logging

2023-03-02 Thread via GitHub
o-nikolas commented on PR #29772: URL: https://github.com/apache/airflow/pull/29772#issuecomment-1452510296 Looks like there are still some failing tests @hussein-awala -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] o-nikolas merged pull request #29869: Update sftp_to_s3.rst

2023-03-02 Thread via GitHub
o-nikolas merged PR #29869: URL: https://github.com/apache/airflow/pull/29869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Update sftp_to_s3.rst (#29869)

2023-03-02 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 372ea492e5 Update sftp_to_s3.rst (#29869)

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29869: Update sftp_to_s3.rst

2023-03-02 Thread via GitHub
boring-cyborg[bot] commented on PR #29869: URL: https://github.com/apache/airflow/pull/29869#issuecomment-1452505556 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[airflow] branch main updated (9745032fa7 -> faf792f634)

2023-03-02 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 9745032fa7 including airflow/example_dags/sql/sample.sql in MANIFEST.in (#29883) add faf792f634 Implement

[GitHub] [airflow] o-nikolas merged pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-02 Thread via GitHub
o-nikolas merged PR #29822: URL: https://github.com/apache/airflow/pull/29822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] SamWheating opened a new pull request, #29886: Mask out non-access bits when comparing file modes

2023-03-02 Thread via GitHub
SamWheating opened a new pull request, #29886: URL: https://github.com/apache/airflow/pull/29886 While investigating https://github.com/apache/airflow/issues/29112 I found another issue in the way that the file task handler checks file access:

[GitHub] [airflow] potiuk commented on issue #29444: Attempting to Upgrade Chart to Enable Examples Causes Postgres Error

2023-03-02 Thread via GitHub
potiuk commented on issue #29444: URL: https://github.com/apache/airflow/issues/29444#issuecomment-1452466045 Yes. This is a known "expectation" for chart 1.8.0 and the way how to deal with it is described in [release

[GitHub] [airflow] PierreC1024 commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-02 Thread via GitHub
PierreC1024 commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1123625999 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] PierreC1024 commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-02 Thread via GitHub
PierreC1024 commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1123625999 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk commented on issue #18329: Add task name, DAG name, try_number, and run_id to all Kubernetes executor logs

2023-03-02 Thread via GitHub
potiuk commented on issue #18329: URL: https://github.com/apache/airflow/issues/18329#issuecomment-1452458530 Feel free -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow] branch main updated (b33b11bf9f -> 9745032fa7)

2023-03-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b33b11bf9f Update ref anchor for env var link in Connection how-to doc (#29816) add 9745032fa7 including

[GitHub] [airflow] potiuk merged pull request #29883: Including airflow/example_dags/sql/sample.sql in MANIFEST.in

2023-03-02 Thread via GitHub
potiuk merged PR #29883: URL: https://github.com/apache/airflow/pull/29883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] SamWheating commented on issue #29112: "Operation not permitted" error when chmod on log folder

2023-03-02 Thread via GitHub
SamWheating commented on issue #29112: URL: https://github.com/apache/airflow/issues/29112#issuecomment-1452445056 I have been trying to replicate this issue this morning, here's what I did: - set up a Kind cluster with a ReadWriteMany PVC (running on NFS) - Deployed Airflow

[GitHub] [airflow] bbovenzi opened a new pull request, #29885: Add filter task upstream/downstream to grid view

2023-03-02 Thread via GitHub
bbovenzi opened a new pull request, #29885: URL: https://github.com/apache/airflow/pull/29885 Add new filtering options in #29226 to the grid view filters and apply it to both grid_data and graph_data endpoints. Also, allow filtering tasks and resetting the root without a full reload

[GitHub] [airflow] vincbeck commented on a diff in pull request #29871: Fix Amazon ECS Enums

2023-03-02 Thread via GitHub
vincbeck commented on code in PR #29871: URL: https://github.com/apache/airflow/pull/29871#discussion_r1123591998 ## airflow/providers/amazon/aws/hooks/ecs.py: ## @@ -55,7 +55,24 @@ def should_retry_eni(exception: Exception): return False -class EcsClusterStates(str,

[GitHub] [airflow] empire-sports commented on issue #29444: Attempting to Upgrade Chart to Enable Examples Causes Postgres Error

2023-03-02 Thread via GitHub
empire-sports commented on issue #29444: URL: https://github.com/apache/airflow/issues/29444#issuecomment-1452416237 Commenting on this. I am upgrading from 1.7 to 1.8. I used a custom values.yaml file with my implementation to enable the git-sync. I'm receiving a similar error.

[GitHub] [airflow] Taragolis commented on a diff in pull request #29871: Fix Amazon ECS Enums

2023-03-02 Thread via GitHub
Taragolis commented on code in PR #29871: URL: https://github.com/apache/airflow/pull/29871#discussion_r1123587735 ## airflow/providers/amazon/aws/hooks/ecs.py: ## @@ -55,7 +55,24 @@ def should_retry_eni(exception: Exception): return False -class EcsClusterStates(str,

[GitHub] [airflow] vincbeck commented on a diff in pull request #29871: Fix Amazon ECS Enums

2023-03-02 Thread via GitHub
vincbeck commented on code in PR #29871: URL: https://github.com/apache/airflow/pull/29871#discussion_r1123582113 ## airflow/providers/amazon/aws/hooks/ecs.py: ## @@ -55,7 +55,24 @@ def should_retry_eni(exception: Exception): return False -class EcsClusterStates(str,

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers

2023-03-02 Thread via GitHub
jedcunningham commented on code in PR #29878: URL: https://github.com/apache/airflow/pull/29878#discussion_r1123583646 ## airflow/providers/mysql/CHANGELOG.rst: ## @@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7. Changelog - +4.0.2 +. + +Misc + +

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29871: Fix Amazon ECS Enums

2023-03-02 Thread via GitHub
o-nikolas commented on code in PR #29871: URL: https://github.com/apache/airflow/pull/29871#discussion_r1123582402 ## airflow/providers/amazon/aws/hooks/ecs.py: ## @@ -55,7 +55,24 @@ def should_retry_eni(exception: Exception): return False -class EcsClusterStates(str,

[GitHub] [airflow] jedcunningham closed pull request #29882: Drop support for k8s 1.23

2023-03-02 Thread via GitHub
jedcunningham closed pull request #29882: Drop support for k8s 1.23 URL: https://github.com/apache/airflow/pull/29882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] ferruzzi commented on a diff in pull request #28869: rewrite polling code for appflow hook

2023-03-02 Thread via GitHub
ferruzzi commented on code in PR #28869: URL: https://github.com/apache/airflow/pull/28869#discussion_r1123575711 ## airflow/providers/amazon/aws/hooks/appflow.py: ## @@ -54,49 +50,35 @@ def conn(self) -> AppflowClient: """Get the underlying boto3 Appflow client

[GitHub] [airflow] ferruzzi commented on a diff in pull request #28869: rewrite polling code for appflow hook

2023-03-02 Thread via GitHub
ferruzzi commented on code in PR #28869: URL: https://github.com/apache/airflow/pull/28869#discussion_r1123575711 ## airflow/providers/amazon/aws/hooks/appflow.py: ## @@ -54,49 +50,35 @@ def conn(self) -> AppflowClient: """Get the underlying boto3 Appflow client

[GitHub] [airflow] jedcunningham commented on pull request #29882: Drop support for k8s 1.23

2023-03-02 Thread via GitHub
jedcunningham commented on PR #29882: URL: https://github.com/apache/airflow/pull/29882#issuecomment-1452395447 Okay, opened #29884 so it's more visible! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] jedcunningham opened a new pull request, #29884: Add note about k8s version support

2023-03-02 Thread via GitHub
jedcunningham opened a new pull request, #29884: URL: https://github.com/apache/airflow/pull/29884 This will help prevent us accidentally dropping support for k8s versions earlier than we've agreed to it. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers

2023-03-02 Thread via GitHub
eladkal commented on code in PR #29878: URL: https://github.com/apache/airflow/pull/29878#discussion_r1123572510 ## airflow/providers/mysql/CHANGELOG.rst: ## @@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7. Changelog - +4.0.2 +. + +Misc + + +*

[GitHub] [airflow] o-nikolas commented on pull request #29869: Update sftp_to_s3.rst

2023-03-02 Thread via GitHub
o-nikolas commented on PR #29869: URL: https://github.com/apache/airflow/pull/29869#issuecomment-1452382584 > docs link in the PR description is old (1.10.3). The new docs is

[GitHub] [airflow] potiuk commented on pull request #29882: Drop support for k8s 1.23

2023-03-02 Thread via GitHub
potiuk commented on PR #29882: URL: https://github.com/apache/airflow/pull/29882#issuecomment-1452381931 > Hmm, I wasn't aware of the k8s exception. Let me have a think on that. Fwiw, as of today 2 support 1.22 still. Yep. I noticed :) -- This is an automated message from the

[GitHub] [airflow] bbovenzi closed issue #23169: Task Duration shows as "empty" when it was really less than 1 second

2023-03-02 Thread via GitHub
bbovenzi closed issue #23169: Task Duration shows as "empty" when it was really less than 1 second URL: https://github.com/apache/airflow/issues/23169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] bbovenzi commented on issue #23169: Task Duration shows as "empty" when it was really less than 1 second

2023-03-02 Thread via GitHub
bbovenzi commented on issue #23169: URL: https://github.com/apache/airflow/issues/23169#issuecomment-1452381187 https://user-images.githubusercontent.com/4600967/222523140-4728de05-80fa-40ca-b61b-aa2e9f54e459.png;> We got rid of the tree view a long time ago and we know calculate

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers

2023-03-02 Thread via GitHub
jedcunningham commented on code in PR #29878: URL: https://github.com/apache/airflow/pull/29878#discussion_r1123558759 ## airflow/providers/mysql/CHANGELOG.rst: ## @@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7. Changelog - +4.0.2 +. + +Misc + +

[GitHub] [airflow] amoghrajesh commented on issue #23169: Task Duration shows as "empty" when it was really less than 1 second

2023-03-02 Thread via GitHub
amoghrajesh commented on issue #23169: URL: https://github.com/apache/airflow/issues/23169#issuecomment-1452354467 @eladkal @bbovenzi I can take this issue if nobody is working on it. Seems like an interesting one. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] pankajastro commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-02 Thread via GitHub
pankajastro commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1123551136 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] amoghrajesh commented on issue #18329: Add task name, DAG name, try_number, and run_id to all Kubernetes executor logs

2023-03-02 Thread via GitHub
amoghrajesh commented on issue #18329: URL: https://github.com/apache/airflow/issues/18329#issuecomment-1452345107 @potiuk seems like the solution was not completed here. I would like to try my hand at it if it is available. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] PierreC1024 commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-02 Thread via GitHub
PierreC1024 commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1123543321 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] PierreC1024 commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-02 Thread via GitHub
PierreC1024 commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1123543321 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] SamWheating opened a new pull request, #29883: Including airflow/example_dags/sql/sample.sql in MANIFEST.in

2023-03-02 Thread via GitHub
SamWheating opened a new pull request, #29883: URL: https://github.com/apache/airflow/pull/29883 I was debugging another issue and running the official helm chart in Kind, and when I tried to run the `example_python_operator` DAG it failed on the `log_sql_query` task with the following

[GitHub] [airflow] pankajastro commented on a diff in pull request #29835: Provider Google Cloud - Add bigquery bi engine reservation operators

2023-03-02 Thread via GitHub
pankajastro commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1123530878 ## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] ferruzzi commented on a diff in pull request #29871: Fix Amazon ECS Enums

2023-03-02 Thread via GitHub
ferruzzi commented on code in PR #29871: URL: https://github.com/apache/airflow/pull/29871#discussion_r1123531685 ## airflow/providers/amazon/aws/hooks/ecs.py: ## @@ -55,7 +55,24 @@ def should_retry_eni(exception: Exception): return False -class EcsClusterStates(str,

[GitHub] [airflow] Taragolis commented on a diff in pull request #29871: Fix Amazon ECS Enums

2023-03-02 Thread via GitHub
Taragolis commented on code in PR #29871: URL: https://github.com/apache/airflow/pull/29871#discussion_r1123531262 ## airflow/providers/amazon/aws/hooks/ecs.py: ## @@ -55,7 +55,24 @@ def should_retry_eni(exception: Exception): return False -class EcsClusterStates(str,

[GitHub] [airflow] ferruzzi commented on pull request #29871: Fix Amazon ECS Enums

2023-03-02 Thread via GitHub
ferruzzi commented on PR #29871: URL: https://github.com/apache/airflow/pull/29871#issuecomment-1452321027 Thanks for getting this so fast, I was planning to look at it this morning. :+1: LOL. I did a review and it wouldn't let me submit because Niko left the same two comments

[GitHub] [airflow] vincbeck commented on a diff in pull request #28869: rewrite polling code for appflow hook

2023-03-02 Thread via GitHub
vincbeck commented on code in PR #28869: URL: https://github.com/apache/airflow/pull/28869#discussion_r1123525633 ## airflow/providers/amazon/aws/hooks/appflow.py: ## @@ -54,49 +50,35 @@ def conn(self) -> AppflowClient: """Get the underlying boto3 Appflow client

[GitHub] [airflow] vincbeck commented on a diff in pull request #28869: rewrite polling code for appflow hook

2023-03-02 Thread via GitHub
vincbeck commented on code in PR #28869: URL: https://github.com/apache/airflow/pull/28869#discussion_r1123525633 ## airflow/providers/amazon/aws/hooks/appflow.py: ## @@ -54,49 +50,35 @@ def conn(self) -> AppflowClient: """Get the underlying boto3 Appflow client

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29871: Fix Amazon ECS Enums

2023-03-02 Thread via GitHub
o-nikolas commented on code in PR #29871: URL: https://github.com/apache/airflow/pull/29871#discussion_r1123521462 ## airflow/providers/amazon/aws/hooks/ecs.py: ## @@ -55,7 +55,24 @@ def should_retry_eni(exception: Exception): return False -class EcsClusterStates(str,

[GitHub] [airflow] josh-fell merged pull request #29816: Fix ref anchor for env var link in Connection how-to doc

2023-03-02 Thread via GitHub
josh-fell merged PR #29816: URL: https://github.com/apache/airflow/pull/29816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Update ref anchor for env var link in Connection how-to doc (#29816)

2023-03-02 Thread joshfell
This is an automated email from the ASF dual-hosted git repository. joshfell pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b33b11bf9f Update ref anchor for env var link in

[GitHub] [airflow] josh-fell commented on pull request #29816: Fix ref anchor for env var link in Connection how-to doc

2023-03-02 Thread via GitHub
josh-fell commented on PR #29816: URL: https://github.com/apache/airflow/pull/29816#issuecomment-1452306725 > We can merge but I guess since releases are not synced there will be some time that the reference won't work I think that's fine. It's the only provider that uses this link

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #28869: rewrite polling code for appflow hook

2023-03-02 Thread via GitHub
vandonr-amz commented on code in PR #28869: URL: https://github.com/apache/airflow/pull/28869#discussion_r1123512646 ## airflow/providers/amazon/aws/hooks/appflow.py: ## @@ -54,49 +50,35 @@ def conn(self) -> AppflowClient: """Get the underlying boto3 Appflow client

[GitHub] [airflow] shyft-mike commented on a diff in pull request #28846: Updated app to support configuring the caching hash method for FIPS

2023-03-02 Thread via GitHub
shyft-mike commented on code in PR #28846: URL: https://github.com/apache/airflow/pull/28846#discussion_r1123510383 ## airflow/compat/hashlib_wrapper.py: ## @@ -0,0 +1,45 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] jedcunningham commented on pull request #29882: Drop support for k8s 1.23

2023-03-02 Thread via GitHub
jedcunningham commented on PR #29882: URL: https://github.com/apache/airflow/pull/29882#issuecomment-1452270108 Hmm, I wasn't aware of the k8s exception. Let me have a think on that. Fwiw, as of today 2 support 1.22 still. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] potiuk commented on pull request #29882: Drop support for k8s 1.23

2023-03-02 Thread via GitHub
potiuk commented on PR #29882: URL: https://github.com/apache/airflow/pull/29882#issuecomment-1452269709 (And yes, I would be happy to drop support immediately after they reach EOL, but it's not what we agreed to, unfortunately). -- This is an automated message from the Apache Git

  1   2   >