(airflow) branch v2-8-stable updated (1745dbe907 -> 2c0a119147)

2024-02-21 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-8-stable in repository https://gitbox.apache.org/repos/asf/airflow.git from 1745dbe907 Switch instance type to m7g (#37127) add 8a8b5557b6 Fix reproducibility of

Re: [PR] Refactor dataset class inheritance [airflow]

2024-02-21 Thread via GitHub
Lee-W commented on code in PR #37590: URL: https://github.com/apache/airflow/pull/37590#discussion_r1498805706 ## airflow/datasets/__init__.py: ## @@ -55,3 +72,42 @@ def __eq__(self, other): def __hash__(self): return hash(self.uri) + +def

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

2024-02-21 Thread via GitHub
Lee-W commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1498745854 ## airflow/models/dataset.py: ## @@ -341,9 +341,9 @@ def __repr__(self) -> str: class DatasetBooleanCondition: """ -Base class for boolean logic for

(airflow) branch constraints-2-8 updated: Updating constraints. Github run id:8000589360

2024-02-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-2-8 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-8 by this push: new 5983e2f69d Updating

Re: [I] `_airflow_parsing_context_manager` writes to os.environ after program has started [airflow]

2024-02-21 Thread via GitHub
hterik commented on issue #37484: URL: https://github.com/apache/airflow/issues/37484#issuecomment-1958850711 Ok, i was not aware how this was used to passed through forks and subprocesses. If it's required and you are sure about where this is called it should be fine. I don't have any

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
uranusjr commented on PR #37580: URL: https://github.com/apache/airflow/pull/37580#issuecomment-1958847389 Specifically `test_action_logging_get_legacy_view` seems directly relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Integrate the run coverage command to the CI [airflow]

2024-02-21 Thread via GitHub
ephraimbuddy commented on PR #37152: URL: https://github.com/apache/airflow/pull/37152#issuecomment-1958836255 > This is not likely to succeed.. The nature of tests we have - where we gather coverage and combine them from separate runs is such that every single run will get smaller

Re: [PR] Refactor dataset class inheritance [airflow]

2024-02-21 Thread via GitHub
uranusjr commented on PR #37590: URL: https://github.com/apache/airflow/pull/37590#issuecomment-1958820928 I feel we should do this before #37101. There are some parts on that PR (importing from `airflow.models`, for example) that I feel very wrong to be in main. -- This is an automated

Re: [PR] add magic method XCom docstrings D105 [airflow]

2024-02-21 Thread via GitHub
uranusjr commented on PR #37602: URL: https://github.com/apache/airflow/pull/37602#issuecomment-1958819826 Magic methods already have defined semantics and documenting them is entirely missing the point. If a tool requires you to do it, it is not a good tool. -- This is an automated

(airflow) branch v2-8-test updated (01af90931e -> 2c0a119147)

2024-02-21 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git discard 01af90931e Update RELEASE_NOTES.rst discard a3e68abe09 Change AirflowTaskTimeout to inherit

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

2024-02-21 Thread via GitHub
sunank200 commented on PR #37101: URL: https://github.com/apache/airflow/pull/37101#issuecomment-1958753213 > As #37016 has been merged, I think we might need to rebase from the main branch and resolve the conflicts before we can review it. Done. Please review @Lee-W -- This is

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

2024-02-21 Thread via GitHub
sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1498675285 ## airflow/models/dag.py: ## @@ -585,6 +587,8 @@ def __init__( self.timetable: Timetable self.schedule_interval: ScheduleInterval

Re: [PR] Fix credentials error for S3ToGCSOperator trigger [airflow]

2024-02-21 Thread via GitHub
korolkevich commented on code in PR #37518: URL: https://github.com/apache/airflow/pull/37518#discussion_r1498671418 ## airflow/providers/google/cloud/transfers/s3_to_gcs.py: ## @@ -269,6 +269,7 @@ def transfer_files_async(self, files: list[str], gcs_hook: GCSHook, s3_hook:

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
jedcunningham commented on PR #37580: URL: https://github.com/apache/airflow/pull/37580#issuecomment-1958710658 Looks like there might be a couple test failures from this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Enhancing breeze commands with PACKAGE_LIST env variable [airflow]

2024-02-21 Thread via GitHub
amoghrajesh commented on PR #37502: URL: https://github.com/apache/airflow/pull/37502#issuecomment-1958671254 @potiuk @eladkal just fixed the build docs and failing checks and also rebased. Should be green now hopefully! -- This is an automated message from the Apache Git Service. To

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-21 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1498585177 ## tests/api_connexion/schemas/test_dataset_schema.py: ## @@ -162,6 +162,37 @@ def test_serialize(self, session): } +class

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-21 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1498585057 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -301,3 +312,37 @@ def delete_dataset_queued_events( "Queue event not found",

Re: [PR] add magic method XCom docstrings D105 [airflow]

2024-02-21 Thread via GitHub
okirialbert commented on code in PR #37602: URL: https://github.com/apache/airflow/pull/37602#discussion_r1498578487 ## airflow/models/xcom.py: ## @@ -785,19 +801,26 @@ def __getstate__(self) -> Any: return (str(statement), query.count()) def

Re: [PR] add magic method XCom docstrings D105 [airflow]

2024-02-21 Thread via GitHub
okirialbert commented on PR #37602: URL: https://github.com/apache/airflow/pull/37602#issuecomment-1958606593 I was striving for better readability by including detailed function descriptions but now I see how it can be misleading in the event of future changes. -- This is an automated

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

2024-02-21 Thread via GitHub
Lee-W commented on PR #37101: URL: https://github.com/apache/airflow/pull/37101#issuecomment-1958591897 As https://github.com/apache/airflow/pull/37016 has been merged, I think we might need to rebase from the main branch and resolve the conflicts before we can review it. -- This is an

Re: [PR] Introduce new config variable to control whether DAG processor outputs to stdout [airflow]

2024-02-21 Thread via GitHub
Owen-CH-Leung commented on PR #37439: URL: https://github.com/apache/airflow/pull/37439#issuecomment-1958581109 > CAn you resolve conflicts and rebase please? Sure & rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Modernized front page scenario [airflow]

2024-02-21 Thread via GitHub
philiprbrenan opened a new pull request, #37609: URL: https://github.com/apache/airflow/pull/37609 --- Used the dag and task decorators to document a more compelling front page which makes Airflow's strengths more immediately visible to potential users.

Re: [PR] Modernized front page scenario [airflow]

2024-02-21 Thread via GitHub
boring-cyborg[bot] commented on PR #37609: URL: https://github.com/apache/airflow/pull/37609#issuecomment-1958571210 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

Re: [PR] Add datasets to dag graph [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on PR #37604: URL: https://github.com/apache/airflow/pull/37604#issuecomment-1958571357 > @bbovenzi Nice work. I believe this is for task view not dag view? Nope. For the whole dag. The example dag had only a single task. -- This is an automated message from the

Re: [PR] Fix rest API logging [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on PR #37581: URL: https://github.com/apache/airflow/pull/37581#issuecomment-1958563244 Made `extra` a json object instead of a tuple. Added request body to `extra`. And hiding sensitive fields for connections and variables:

Re: [PR] SECURITY_MANAGER_CLASS should be a referrence to class, not a string [airflow]

2024-02-21 Thread via GitHub
andrew-candela commented on PR #33690: URL: https://github.com/apache/airflow/pull/33690#issuecomment-1958505840 Just ran into this issue when trying to upgrade from 2.6 to 2.8. Thanks for updating the docs @Michalosu ! -- This is an automated message from the Apache Git Service. To

(airflow) branch constraints-main updated: Updating constraints. Github run id:7997655369

2024-02-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 4a19d21d46 Updating

Re: [PR] Attempt to update Connexion library to version 3 [airflow]

2024-02-21 Thread via GitHub
Satoshi-Sh commented on PR #36052: URL: https://github.com/apache/airflow/pull/36052#issuecomment-1958459086 @RobbeSneyders Thanks for the pointers. I will have a look at it and ask you if I have a question. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add support for impersonation chain to GKEStartPodOperator in deferrable mode [airflow]

2024-02-21 Thread via GitHub
potiuk merged PR #37486: URL: https://github.com/apache/airflow/pull/37486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: feat(GKEPodAsyncHook): use async credentials token implementation (#37486)

2024-02-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 810fb5f2a8 feat(GKEPodAsyncHook): use async

Re: [PR] `CloudRunExecuteJobOperator`: Add project_id to hook.get_job calls [airflow]

2024-02-21 Thread via GitHub
boring-cyborg[bot] commented on PR #37201: URL: https://github.com/apache/airflow/pull/37201#issuecomment-1958447427 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [I] `get_parsing_context().dag_id` is not set when using `airflow dags test` command [airflow]

2024-02-21 Thread via GitHub
potiuk closed issue #37483: `get_parsing_context().dag_id` is not set when using `airflow dags test` command URL: https://github.com/apache/airflow/issues/37483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Set parsing context dag_id in dag test command [airflow]

2024-02-21 Thread via GitHub
potiuk merged PR #37606: URL: https://github.com/apache/airflow/pull/37606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: `CloudRunExecuteJobOperator`: Add project_id to hook.get_job calls (#37201)

2024-02-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5fc866aebe `CloudRunExecuteJobOperator`: Add

Re: [PR] `CloudRunExecuteJobOperator`: Add project_id to hook.get_job calls [airflow]

2024-02-21 Thread via GitHub
potiuk merged PR #37201: URL: https://github.com/apache/airflow/pull/37201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Set parsing context dag_id in dag test command (#37606)

2024-02-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c0e30cb3f8 Set parsing context dag_id in dag test

Re: [I] `_airflow_parsing_context_manager` writes to os.environ after program has started [airflow]

2024-02-21 Thread via GitHub
potiuk commented on issue #37484: URL: https://github.com/apache/airflow/issues/37484#issuecomment-1958442204 Just a comment. I am not sure if that is a problem. If you look at where the `_airflow_parsing_context_manager` is used, it is used, right before running subproces.Popen or right

Re: [PR] enhance druid connection parameters [airflow]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #35244: URL: https://github.com/apache/airflow/pull/35244#issuecomment-1958428404 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

Re: [I] KubernetesPodOperator prints empty log lines without respecting the log format [airflow]

2024-02-21 Thread via GitHub
github-actions[bot] commented on issue #36571: URL: https://github.com/apache/airflow/issues/36571#issuecomment-1958428350 This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further

Re: [I] Add dag run_id to Audit Log [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on issue #37597: URL: https://github.com/apache/airflow/issues/37597#issuecomment-1958427327 Thanks @SamWheating. We migrated most things from `execution_date` to `run_id` but we seemingly forgot this one. So hopefully we can look up those PRs too for help. But doing

Re: [PR] Attempt to update Connexion library to version 3 [airflow]

2024-02-21 Thread via GitHub
RobbeSneyders commented on PR #36052: URL: https://github.com/apache/airflow/pull/36052#issuecomment-1958422648 Sorry for the late response, let me try to give some pointers for the open issues. > 1. Based on this discussion: > Blueprint is now can't be retrieved from connexion

Re: [PR] Show custom instance names for a mapped task in UI [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1498458390 ## airflow/www/static/js/dag/details/taskInstance/MappedInstances.tsx: ## @@ -68,7 +68,7 @@ const MappedInstances = ({ dagId, runId, taskId, onRowClicked }: Props)

Re: [I] Error "/bin/bash: line 1: exec: #magic___^_^___line: not found" on fresh install [airflow]

2024-02-21 Thread via GitHub
potiuk closed issue #35303: Error "/bin/bash: line 1: exec: #magic___^_^___line: not found" on fresh install URL: https://github.com/apache/airflow/issues/35303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Error "/bin/bash: line 1: exec: #magic___^_^___line: not found" on fresh install [airflow]

2024-02-21 Thread via GitHub
potiuk commented on issue #35303: URL: https://github.com/apache/airflow/issues/35303#issuecomment-1958408583 Sems like a bug in yamlffmt in case of some specific whitespace (End of line) in yaml https://github.com/google/yamlfmt/issues/86 has explanation. Seems you need to reformat your

Re: [PR] Integrate the run coverage command to the CI [airflow]

2024-02-21 Thread via GitHub
potiuk commented on PR #37152: URL: https://github.com/apache/airflow/pull/37152#issuecomment-1958393364 This is not likely to succeed.. The nature of tests we have - where we gather coverage and combine them from separate runs is such that every single run will get smaller coverage than

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on code in PR #37580: URL: https://github.com/apache/airflow/pull/37580#discussion_r1498448602 ## airflow/www/views.py: ## @@ -3737,7 +3709,6 @@ def datasets_summary(self): ) @expose("/robots.txt") -@action_logging Review Comment:

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
jedcunningham commented on code in PR #37580: URL: https://github.com/apache/airflow/pull/37580#discussion_r1498441335 ## airflow/www/views.py: ## @@ -3737,7 +3709,6 @@ def datasets_summary(self): ) @expose("/robots.txt") -@action_logging Review

Re: [PR] Add support for impersonation chain to GKEStartPodOperator in deferrable mode [airflow]

2024-02-21 Thread via GitHub
potiuk commented on PR #37486: URL: https://github.com/apache/airflow/pull/37486#issuecomment-1958302727 LGTM: @Lee-W ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(airflow-site) branch gh-pages updated (bd6d49dee6 -> f1700583cd)

2024-02-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git discard bd6d49dee6 Rewritten history to remove past gh-pages deployments new f1700583cd Rewritten history to

Re: [I] Add dag run_id to Audit Log [airflow]

2024-02-21 Thread via GitHub
SamWheating commented on issue #37597: URL: https://github.com/apache/airflow/issues/37597#issuecomment-1958258761  Hey Brent, this is a good idea. Feel free to assign to me if you want a hand, I've got some capacity in the next week or two. -- This is an automated message from

[PR] Set parsing context dag_id in dag test command [airflow]

2024-02-21 Thread via GitHub
SamWheating opened a new pull request, #37606: URL: https://github.com/apache/airflow/pull/37606 closes: https://github.com/apache/airflow/issues/37483 This PR sets the parsing context when loading a DAG as a part of the `airflow dags test` command. Since the DAG

Re: [PR] Add Yandex Query support from Yandex.Cloud [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37458: URL: https://github.com/apache/airflow/pull/37458#discussion_r1498408740 ## airflow/providers/yandex/hooks/http_client.py: ## @@ -0,0 +1,321 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

(airflow) branch constraints-main updated: Updating constraints. Github run id:7995800768

2024-02-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 13f5096c61 Updating

Re: [PR] Partially enable `D100`, `D102`, `D103` and `D104` [airflow]

2024-02-21 Thread via GitHub
potiuk commented on PR #37469: URL: https://github.com/apache/airflow/pull/37469#issuecomment-1958182711 conflicts to solve? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(airflow-site) branch main updated: Add Code of Conduct to Airflow Site (#957)

2024-02-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new 69faacd8f9 Add Code of Conduct to Airflow

Re: [PR] Add Code of Conduct to Airflow Site [airflow-site]

2024-02-21 Thread via GitHub
potiuk merged PR #957: URL: https://github.com/apache/airflow-site/pull/957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Introduce new config variable to control whether DAG processor outputs to stdout [airflow]

2024-02-21 Thread via GitHub
potiuk commented on PR #37439: URL: https://github.com/apache/airflow/pull/37439#issuecomment-1958145958 CAn you resolve conflicts and rebase please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
awdavidson commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498378572 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause

Re: [PR] Move fs scheme definition from Python to YAML [airflow]

2024-02-21 Thread via GitHub
potiuk commented on PR #35972: URL: https://github.com/apache/airflow/pull/35972#issuecomment-1958101758 Are you planning to continue that one @uranusjr / @bolkedebruin ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] execution_timeout not enforced, task hangs up [airflow]

2024-02-21 Thread via GitHub
potiuk commented on issue #35474: URL: https://github.com/apache/airflow/issues/35474#issuecomment-1958098338 > @Taragolis was wondering if you have a patch/workaround for this issue? Airflow 2.8.2 (RC likely tomorrow) - should have the fix applied from #35653 - if your problem

Re: [PR] Show custom instance names for a mapped task in UI [airflow]

2024-02-21 Thread via GitHub
RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1498365115 ## airflow/www/static/js/dag/details/taskInstance/MappedInstances.tsx: ## @@ -68,7 +68,7 @@ const MappedInstances = ({ dagId, runId, taskId, onRowClicked }: Props)

Re: [PR] Implement `batch_is_authorized_*` APIs in AWS auth manager [airflow]

2024-02-21 Thread via GitHub
o-nikolas commented on code in PR #37430: URL: https://github.com/apache/airflow/pull/37430#discussion_r1498351268 ## airflow/providers/amazon/aws/auth_manager/avp/facade.py: ## @@ -116,6 +125,63 @@ def is_authorized( return resp["decision"] == "ALLOW" +def

Re: [PR] Implement `batch_is_authorized_*` APIs in AWS auth manager [airflow]

2024-02-21 Thread via GitHub
vincbeck commented on code in PR #37430: URL: https://github.com/apache/airflow/pull/37430#discussion_r1498347166 ## airflow/providers/amazon/aws/auth_manager/avp/facade.py: ## @@ -116,6 +125,63 @@ def is_authorized( return resp["decision"] == "ALLOW" +def

Re: [PR] Implement `batch_is_authorized_*` APIs in AWS auth manager [airflow]

2024-02-21 Thread via GitHub
o-nikolas commented on code in PR #37430: URL: https://github.com/apache/airflow/pull/37430#discussion_r1498340343 ## airflow/auth/managers/base_auth_manager.py: ## @@ -254,6 +254,24 @@ def is_authorized_custom_view( """ raise AirflowException(f"The resource

(airflow) branch constraints-2-8 updated: Updating constraints. Github run id:7995416648

2024-02-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-2-8 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-8 by this push: new 119f5e40a8 Updating

(airflow) branch main updated (622d271048 -> d5d6f4b188)

2024-02-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 622d271048 Add tests to increase DagFileProcessorAgent coverage (#37605) add d5d6f4b188 Make Datasets hashable

Re: [PR] Make Datasets hashable [airflow]

2024-02-21 Thread via GitHub
potiuk merged PR #37465: URL: https://github.com/apache/airflow/pull/37465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Add tests to increase DagFileProcessorAgent coverage (#37605)

2024-02-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 622d271048 Add tests to increase

Re: [PR] Add tests to increase DagFileProcessorAgent coverage [airflow]

2024-02-21 Thread via GitHub
potiuk merged PR #37605: URL: https://github.com/apache/airflow/pull/37605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated (2699f8ce39 -> 2cb96a8e85)

2024-02-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 2699f8ce39 Fix spelling of `airflow` (#37601) add 2cb96a8e85 resolve template fields init checks for `bigquery`

Re: [PR] resolve template fields init checks for `bigquery` [airflow]

2024-02-21 Thread via GitHub
potiuk merged PR #37586: URL: https://github.com/apache/airflow/pull/37586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix spark-kubernetes-operator compatibility [airflow]

2024-02-21 Thread via GitHub
blcksrx commented on PR #31798: URL: https://github.com/apache/airflow/pull/31798#issuecomment-1957927822 Hi @sudohainguyen Unfortunately not. The operator has been changed a lot since then, please check the version and create an Issue if the latest version has any problem -- This is

Re: [PR] add magic method XCom docstrings D105 [airflow]

2024-02-21 Thread via GitHub
Taragolis commented on code in PR #37602: URL: https://github.com/apache/airflow/pull/37602#discussion_r1498307318 ## airflow/models/xcom.py: ## @@ -785,19 +801,26 @@ def __getstate__(self) -> Any: return (str(statement), query.count()) def

Re: [PR] add magic method XCom docstrings D105 [airflow]

2024-02-21 Thread via GitHub
Taragolis commented on code in PR #37602: URL: https://github.com/apache/airflow/pull/37602#discussion_r1498298023 ## airflow/models/xcom.py: ## @@ -131,6 +131,12 @@ def init_on_load(self): self.value = self.orm_deserialize_value() def __repr__(self): +

Re: [PR] add magic method XCom docstrings D105 [airflow]

2024-02-21 Thread via GitHub
Taragolis commented on code in PR #37602: URL: https://github.com/apache/airflow/pull/37602#discussion_r1498298023 ## airflow/models/xcom.py: ## @@ -131,6 +131,12 @@ def init_on_load(self): self.value = self.orm_deserialize_value() def __repr__(self): +

Re: [PR] Clean up webserver endpoints adding to audit log [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on code in PR #37580: URL: https://github.com/apache/airflow/pull/37580#discussion_r1498298441 ## airflow/config_templates/config.yml: ## @@ -1831,7 +1831,7 @@ webserver: version_added: 2.3.0 type: string example: ~ - default:

(airflow) branch v2-8-test updated (ac35b0b455 -> 01af90931e)

2024-02-21 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git omit ac35b0b455 Update RELEASE_NOTES.rst add 01af90931e Update RELEASE_NOTES.rst This update added new

[PR] Add tests to increase DagFileProcessorAgent coverage [airflow]

2024-02-21 Thread via GitHub
drajguru opened a new pull request, #37605: URL: https://github.com/apache/airflow/pull/37605 Add tests to increase DagFileProcessorAgent coverage Also added a coverage script for modules in the Other group related: #35127 -- This is an automated message from the Apache Git

Re: [PR] Show custom instance names for a mapped task in UI [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1498277930 ## airflow/www/static/js/dag/details/taskInstance/MappedInstances.tsx: ## @@ -68,7 +68,7 @@ const MappedInstances = ({ dagId, runId, taskId, onRowClicked }: Props)

Re: [PR] Show custom instance names for a mapped task in UI [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1498276463 ## airflow/www/static/js/dag/details/taskInstance/MappedInstances.tsx: ## @@ -68,7 +68,7 @@ const MappedInstances = ({ dagId, runId, taskId, onRowClicked }: Props)

Re: [PR] Show custom instance names for a mapped task in UI [airflow]

2024-02-21 Thread via GitHub
bbovenzi commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1498276463 ## airflow/www/static/js/dag/details/taskInstance/MappedInstances.tsx: ## @@ -68,7 +68,7 @@ const MappedInstances = ({ dagId, runId, taskId, onRowClicked }: Props)

(airflow) branch constraints-main updated: Updating constraints. Github run id:7994654715

2024-02-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 1bfb3bc71c Updating

[PR] Datasets in dag graph [airflow]

2024-02-21 Thread via GitHub
bbovenzi opened a new pull request, #37604: URL: https://github.com/apache/airflow/pull/37604 Add datasets as upstream and downstream nodes in the DAG graph. Make it easier to visualize what a DAG is connected to. And provide a tooltip to jump over to that dataset to see what else it

[PR] Show dataset events above task/run details in grid view [airflow]

2024-02-21 Thread via GitHub
bbovenzi opened a new pull request, #37603: URL: https://github.com/apache/airflow/pull/37603 Before, we had dataset events linked to a task instance or dag run below all of the details. It is too easy to miss that information, especially since those details contain a lot more information.

(airflow) branch main updated: Fix spelling of `airflow` (#37601)

2024-02-21 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2699f8ce39 Fix spelling of `airflow` (#37601)

Re: [PR] Fix spelling of `airflow` [airflow]

2024-02-21 Thread via GitHub
vincbeck merged PR #37601: URL: https://github.com/apache/airflow/pull/37601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498199155 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it

Re: [I] AIRFLOW_HOME doesn't propagate to logGroomerSidecar [airflow]

2024-02-21 Thread via GitHub
jabbera commented on issue #37579: URL: https://github.com/apache/airflow/issues/37579#issuecomment-1957772743 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498195225 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498189179 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498185263 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it

Re: [PR] add magic method XCom docstrings D105 [airflow]

2024-02-21 Thread via GitHub
okirialbert commented on PR #37602: URL: https://github.com/apache/airflow/pull/37602#issuecomment-1957756847 Add XCom magic method docstrings #37523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] add magic method XCom docstrings D105 [airflow]

2024-02-21 Thread via GitHub
okirialbert opened a new pull request, #37602: URL: https://github.com/apache/airflow/pull/37602 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498179774 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it

Re: [PR] Add GKEListJobsOperator and GKEDescribeJobOperator [airflow]

2024-02-21 Thread via GitHub
hussein-awala commented on code in PR #37598: URL: https://github.com/apache/airflow/pull/37598#discussion_r1498150187 ## airflow/providers/cncf/kubernetes/hooks/kubernetes.py: ## @@ -502,6 +503,30 @@ def create_job( raise e return resp +def

Re: [PR] Add GKEListJobsOperator and GKEDescribeJobOperator [airflow]

2024-02-21 Thread via GitHub
pankajastro commented on code in PR #37598: URL: https://github.com/apache/airflow/pull/37598#discussion_r1498175502 ## airflow/providers/cncf/kubernetes/hooks/kubernetes.py: ## @@ -502,6 +503,30 @@ def create_job( raise e return resp +def

(airflow) branch main updated: Add conditional logic for dataset triggering (#37016)

2024-02-21 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f971232ab4 Add conditional logic for dataset

Re: [PR] Add conditional logic for dataset triggering [airflow]

2024-02-21 Thread via GitHub
dstandish merged PR #37016: URL: https://github.com/apache/airflow/pull/37016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Deprecate PY* constants into the airflow module (#37575)

2024-02-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 564adcfb7a Deprecate PY* constants into the

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-21 Thread via GitHub
potiuk merged PR #37575: URL: https://github.com/apache/airflow/pull/37575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >