[GitHub] [airflow] ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy

2019-08-13 Thread GitBox
ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy URL: https://github.com/apache/airflow/pull/5664#discussion_r313477375 ## File path: tests/core.py ## @@ -41,6 +42,7 @@ from numpy.testing import

[GitHub] [airflow] ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy

2019-08-13 Thread GitBox
ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy URL: https://github.com/apache/airflow/pull/5664#discussion_r313476797 ## File path: tests/contrib/utils/gcp_authenticator.py ## @@ -55,7 +55,7 @@ class

[GitHub] [airflow] ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy

2019-08-13 Thread GitBox
ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy URL: https://github.com/apache/airflow/pull/5664#discussion_r313476178 ## File path: tests/contrib/hooks/test_gcp_cloud_build_hook.py ## @@ -46,7 +47,7 @@

[GitHub] [airflow] ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy

2019-08-13 Thread GitBox
ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy URL: https://github.com/apache/airflow/pull/5664#discussion_r313475553 ## File path: setup.py ## @@ -358,6 +358,8 @@ def do_setup():

[GitHub] [airflow] ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy

2019-08-13 Thread GitBox
ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy URL: https://github.com/apache/airflow/pull/5664#discussion_r313475114 ## File path: airflow/settings.py ## @@ -63,13 +67,13 @@ LOG_FORMAT =