[GitHub] [airflow] potiuk commented on a diff in pull request #28926: Upgrade mypy to 0.991

2023-01-20 Thread via GitHub
potiuk commented on code in PR #28926: URL: https://github.com/apache/airflow/pull/28926#discussion_r1082995085 ## tests/www/views/test_views_connection.py: ## @@ -40,11 +41,10 @@ "password": "admin", } -CONNECTION_WITH_EXTRA = CONNECTION.update( Review Comment:

[GitHub] [airflow] potiuk commented on a diff in pull request #28926: Upgrade mypy to 0.991

2023-01-18 Thread GitBox
potiuk commented on code in PR #28926: URL: https://github.com/apache/airflow/pull/28926#discussion_r1073431561 ## airflow/timetables/simple.py: ## @@ -55,6 +55,9 @@ def serialize(self) -> dict[str, Any]: def infer_manual_data_interval(self, *, run_after: DateTime) ->

[GitHub] [airflow] potiuk commented on a diff in pull request #28926: Upgrade mypy to 0.991

2023-01-13 Thread GitBox
potiuk commented on code in PR #28926: URL: https://github.com/apache/airflow/pull/28926#discussion_r1069994094 ## airflow/timetables/simple.py: ## @@ -55,6 +55,9 @@ def serialize(self) -> dict[str, Any]: def infer_manual_data_interval(self, *, run_after: DateTime) ->

[GitHub] [airflow] potiuk commented on a diff in pull request #28926: Upgrade mypy to 0.991

2023-01-13 Thread GitBox
potiuk commented on code in PR #28926: URL: https://github.com/apache/airflow/pull/28926#discussion_r1069990982 ## airflow/example_dags/plugins/workday.py: ## @@ -78,6 +78,9 @@ def next_dagrun_info( # [END howto_timetable_next_dagrun_info] +def validate(self):

[GitHub] [airflow] potiuk commented on a diff in pull request #28926: Upgrade mypy to 0.991

2023-01-13 Thread GitBox
potiuk commented on code in PR #28926: URL: https://github.com/apache/airflow/pull/28926#discussion_r1069978241 ## airflow/example_dags/plugins/workday.py: ## @@ -78,6 +78,9 @@ def next_dagrun_info( # [END howto_timetable_next_dagrun_info] +def validate(self):