[GitHub] [airflow] vandonr-amz commented on pull request #28816: introduce a method to convert dictionaries to boto-style key-value lists

2023-01-19 Thread GitBox
vandonr-amz commented on PR #28816: URL: https://github.com/apache/airflow/pull/28816#issuecomment-1397776181 @eladkal @uranusjr anything else you'd like changed with that PR ? Otherwise we could merge it  -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] vandonr-amz commented on pull request #28816: introduce a method to convert dictionaries to boto-style key-value lists

2023-01-12 Thread GitBox
vandonr-amz commented on PR #28816: URL: https://github.com/apache/airflow/pull/28816#issuecomment-1381159841 > * Can this be more-universal across the provider? There are likely other operators that have the same thing, ISTR there are some EC2 operators. I didn't find other

[GitHub] [airflow] vandonr-amz commented on pull request #28816: introduce a method to convert dictionaries to boto-style key-value lists

2023-01-10 Thread GitBox
vandonr-amz commented on PR #28816: URL: https://github.com/apache/airflow/pull/28816#issuecomment-1378016820 ok, made it accept a list or dict where meaningful, and added the missing file. It's also shipping a clandestine commit for now because it's stacked on top of

[GitHub] [airflow] vandonr-amz commented on pull request #28816: introduce a method to convert dictionaries to boto-style key-value lists

2023-01-10 Thread GitBox
vandonr-amz commented on PR #28816: URL: https://github.com/apache/airflow/pull/28816#issuecomment-1377735626 oh so you mean we should always accept either preformated or as a dict. Yeah why not, I can do that. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] vandonr-amz commented on pull request #28816: introduce a method to convert dictionaries to boto-style key-value lists

2023-01-09 Thread GitBox
vandonr-amz commented on PR #28816: URL: https://github.com/apache/airflow/pull/28816#issuecomment-1376598142 > @vandonr-amz One possible side effect of this change - I think Airflow still can't render dictionaries keys if it templated value: #18938 However, I don't really see why

[GitHub] [airflow] vandonr-amz commented on pull request #28816: introduce a method to convert dictionaries to boto-style key-value lists

2023-01-09 Thread GitBox
vandonr-amz commented on PR #28816: URL: https://github.com/apache/airflow/pull/28816#issuecomment-1376589091 > @vandonr-amz One possible side effect of this change - I think Airflow still can't render dictionaries keys if it templated value: #18938 wow that PR is an adventure... sad