molcay commented on PR #38398:
URL: https://github.com/apache/airflow/pull/38398#issuecomment-2079000366
LGTM
> Just a small thing: it can be good to squash the commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jalengg commented on code in PR #38398:
URL: https://github.com/apache/airflow/pull/38398#discussion_r1550940677
##
airflow/providers/google/cloud/hooks/gcs.py:
##
@@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name:
str) -> str:
jalengg commented on code in PR #38398:
URL: https://github.com/apache/airflow/pull/38398#discussion_r1550939930
##
airflow/providers/google/cloud/hooks/gcs.py:
##
@@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name:
str) -> str:
eladkal commented on code in PR #38398:
URL: https://github.com/apache/airflow/pull/38398#discussion_r1549553297
##
airflow/providers/google/cloud/hooks/gcs.py:
##
@@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name:
str) -> str:
jalengg commented on code in PR #38398:
URL: https://github.com/apache/airflow/pull/38398#discussion_r1542149732
##
airflow/providers/google/cloud/hooks/gcs.py:
##
@@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name:
str) -> str:
jalengg commented on code in PR #38398:
URL: https://github.com/apache/airflow/pull/38398#discussion_r1540561139
##
tests/providers/google/cloud/hooks/test_gcs.py:
##
@@ -565,6 +565,20 @@ def test_object_get_md5hash(self, mock_service):
assert response ==
amoghrajesh commented on code in PR #38398:
URL: https://github.com/apache/airflow/pull/38398#discussion_r1538658019
##
tests/providers/google/cloud/hooks/test_gcs.py:
##
@@ -565,6 +565,20 @@ def test_object_get_md5hash(self, mock_service):
assert response ==
jalengg commented on code in PR #38398:
URL: https://github.com/apache/airflow/pull/38398#discussion_r1536565254
##
airflow/providers/google/cloud/hooks/gcs.py:
##
@@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name:
str) -> str:
dirrao commented on code in PR #38398:
URL: https://github.com/apache/airflow/pull/38398#discussion_r1536551567
##
airflow/providers/google/cloud/hooks/gcs.py:
##
@@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name:
str) -> str: