[jira] [Commented] (AIRFLOW-3801) DagBag always import examples
[
https://issues.apache.org/jira/browse/AIRFLOW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784936#comment-16784936
]
ASF subversion and git services commented on AIRFLOW-3801:
--
Commit 351514905897e15e316b3e6ee812d085f4e3dcd8 in airflow's branch
refs/heads/v1-10-stable from Patouche
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=3515149 ]
[AIRFLOW-3801] Fix DagBag collect dags invocation to prevent examples to be
loaded (#4677)
> DagBag always import examples
> --
>
> Key: AIRFLOW-3801
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3801
> Project: Apache Airflow
> Issue Type: Bug
> Components: models
>Affects Versions: 1.10.2, 2.0.0
>Reporter: Patrick Allain
>Priority: Minor
> Fix For: 1.10.3
>
>
> Hello,
> Yesterday, I notice in my unit test that the example was always loaded even
> if I explicitly specified the parameters {{include_examples=False}} in the
> {{DagBag}} constructor.
> In fact, the DagBag init method invoke the {{collect_dags}} method without
> naming the parameters. Inside, the {{collect_dags}} method, the method
> {{list_py_file_paths}} was invoke without naming the parameters also.
> I tried to fix it in a pull request that will be made very soon.
>
> Regards,
> Patrick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-3801) DagBag always import examples
[
https://issues.apache.org/jira/browse/AIRFLOW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765133#comment-16765133
]
ASF GitHub Bot commented on AIRFLOW-3801:
-
ashb commented on pull request #4677: [AIRFLOW-3801] Fix DagBag collect dags
invocation to prevent examples…
URL: https://github.com/apache/airflow/pull/4677
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DagBag always import examples
> --
>
> Key: AIRFLOW-3801
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3801
> Project: Apache Airflow
> Issue Type: Bug
> Components: models
>Affects Versions: 1.10.2, 2.0.0
>Reporter: Patrick Allain
>Priority: Minor
> Fix For: 1.10.3
>
>
> Hello,
> Yesterday, I notice in my unit test that the example was always loaded even
> if I explicitly specified the parameters {{include_examples=False}} in the
> {{DagBag}} constructor.
> In fact, the DagBag init method invoke the {{collect_dags}} method without
> naming the parameters. Inside, the {{collect_dags}} method, the method
> {{list_py_file_paths}} was invoke without naming the parameters also.
> I tried to fix it in a pull request that will be made very soon.
>
> Regards,
> Patrick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-3801) DagBag always import examples
[
https://issues.apache.org/jira/browse/AIRFLOW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765134#comment-16765134
]
ASF subversion and git services commented on AIRFLOW-3801:
--
Commit 57c6665767d548eeb6bab5d2f12514e254c75e25 in airflow's branch
refs/heads/master from Patouche
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=57c6665 ]
[AIRFLOW-3801] Fix DagBag collect dags invocation to prevent examples to be
loaded (#4677)
> DagBag always import examples
> --
>
> Key: AIRFLOW-3801
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3801
> Project: Apache Airflow
> Issue Type: Bug
> Components: models
>Affects Versions: 1.10.2, 2.0.0
>Reporter: Patrick Allain
>Priority: Minor
> Fix For: 1.10.3
>
>
> Hello,
> Yesterday, I notice in my unit test that the example was always loaded even
> if I explicitly specified the parameters {{include_examples=False}} in the
> {{DagBag}} constructor.
> In fact, the DagBag init method invoke the {{collect_dags}} method without
> naming the parameters. Inside, the {{collect_dags}} method, the method
> {{list_py_file_paths}} was invoke without naming the parameters also.
> I tried to fix it in a pull request that will be made very soon.
>
> Regards,
> Patrick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-3801) DagBag always import examples
[
https://issues.apache.org/jira/browse/AIRFLOW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764071#comment-16764071
]
ASF GitHub Bot commented on AIRFLOW-3801:
-
Patouche commented on pull request #4677: [AIRFLOW-3801] Fix DagBag collect
dags invocation to prevent examples…
URL: https://github.com/apache/airflow/pull/4677
I closed the PR #4645 in favor of this one to set the correct base branch.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-3801) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-3801
### Description
- Fix in DagBag init method the`include_examples` parameters which was not
use properly.
### Tests
- [X] tests.models.DagBagTest#test_dont_load_example : When the parameter
`include_examples` is set to false on a empty dags folder, this validate that
the dagbag is empty.
### Documentation
- N/A
### Code Quality
- [X] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DagBag always import examples
> --
>
> Key: AIRFLOW-3801
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3801
> Project: Apache Airflow
> Issue Type: Bug
> Components: models
>Affects Versions: 1.10.2, 2.0.0
>Reporter: Patrick Allain
>Priority: Minor
> Fix For: 1.10.3
>
>
> Hello,
> Yesterday, I notice in my unit test that the example was always loaded even
> if I explicitly specified the parameters {{include_examples=False}} in the
> {{DagBag}} constructor.
> In fact, the DagBag init method invoke the {{collect_dags}} method without
> naming the parameters. Inside, the {{collect_dags}} method, the method
> {{list_py_file_paths}} was invoke without naming the parameters also.
> I tried to fix it in a pull request that will be made very soon.
>
> Regards,
> Patrick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-3801) DagBag always import examples
[
https://issues.apache.org/jira/browse/AIRFLOW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764068#comment-16764068
]
ASF GitHub Bot commented on AIRFLOW-3801:
-
Patouche commented on pull request #4645: [AIRFLOW-3801] Fix DagBag collect
dags invocation to prevent examples…
URL: https://github.com/apache/airflow/pull/4645
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DagBag always import examples
> --
>
> Key: AIRFLOW-3801
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3801
> Project: Apache Airflow
> Issue Type: Bug
> Components: models
>Affects Versions: 1.10.2, 2.0.0
>Reporter: Patrick Allain
>Priority: Minor
> Fix For: 1.10.3
>
>
> Hello,
> Yesterday, I notice in my unit test that the example was always loaded even
> if I explicitly specified the parameters {{include_examples=False}} in the
> {{DagBag}} constructor.
> In fact, the DagBag init method invoke the {{collect_dags}} method without
> naming the parameters. Inside, the {{collect_dags}} method, the method
> {{list_py_file_paths}} was invoke without naming the parameters also.
> I tried to fix it in a pull request that will be made very soon.
>
> Regards,
> Patrick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-3801) DagBag always import examples
[
https://issues.apache.org/jira/browse/AIRFLOW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759336#comment-16759336
]
ASF GitHub Bot commented on AIRFLOW-3801:
-
Patouche commented on pull request #4645: [AIRFLOW-3801] Fix DagBag collect
dags invocation to prevent examples…
URL: https://github.com/apache/airflow/pull/4645
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-3801) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-3801
### Description
- Fix in DagBag init method the`include_examples` parameters which was not
use properly.
### Tests
- [X] tests.models.DagBagTest#test_dont_load_example : When the parameter
`include_examples` is set to false on a empty dags folder, this validate that
the dagbag is empty.
### Documentation
- N/A
### Code Quality
- [X] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DagBag always import examples
> --
>
> Key: AIRFLOW-3801
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3801
> Project: Apache Airflow
> Issue Type: Bug
> Components: models
>Affects Versions: 1.10.2, 2.0.0
>Reporter: Patrick Allain
>Priority: Minor
> Fix For: 1.10.3
>
>
> Hello,
> Yesterday, I notice in my unit test that the example was always loaded even
> if I explicitly specified the parameters {{include_examples=False}} in the
> {{DagBag}} constructor.
> In fact, the DagBag init method invoke the {{collect_dags}} method without
> naming the parameters. Inside, the {{collect_dags}} method, the method
> {{list_py_file_paths}} was invoke without naming the parameters also.
> I tried to fix it in a pull request that will be made very soon.
>
> Regards,
> Patrick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
