[GitHub] artwr commented on issue #3692: [AIRFLOW-2847][WIP] Remove legacy imports support for plugins for 2.0 deprecation.

artwr commented on issue #3692: [AIRFLOW-2847][WIP] Remove legacy imports support for plugins for 2.0 deprecation. URL: https://github.com/apache/incubator-airflow/pull/3692#issuecomment-410401094 @holdenk, we have been relying somewhat heavily on setting up Travis CI on our own forks to

[GitHub] holdenk opened a new pull request #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

holdenk opened a new pull request #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691 Add missing python test dependency (tox) to setup.py dev requirement. Make sure you have checked _all_ steps below.

[GitHub] Fokko commented on issue #3612: [AIRFLOW-2755] Added `kubernetes.worker_dags_folder` configuration

Fokko commented on issue #3612: [AIRFLOW-2755] Added `kubernetes.worker_dags_folder` configuration URL: https://github.com/apache/incubator-airflow/pull/3612#issuecomment-410390277 Can you rebase onto master? The transient has been fixed in master.

[GitHub] ashb commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

ashb commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410444282 Last time I checked it wasn't possible to set extra via env vars -- am I wrong about that?

[GitHub] XD-DENG edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

XD-DENG edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410444530 Hi @kaxil , I think @ashb is right. I checked

[GitHub] XD-DENG commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

XD-DENG commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410446906 Hi @kaxil , I have added a short note to highlight this limitation to users. I didn't add anything into

[GitHub] ashb commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI

ashb commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI URL: https://github.com/apache/incubator-airflow/pull/3646#issuecomment-410460557 It's relatively easy to set up Travis on your personal fork of Airflow - IIRC it's as simple as

[GitHub] ashb commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

ashb commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-410463868 Could you rebase please? This is an automated

[GitHub] ashb commented on issue #3495: Small fix for BranchPythonOperator Operator

ashb commented on issue #3495: Small fix for BranchPythonOperator Operator URL: https://github.com/apache/incubator-airflow/pull/3495#issuecomment-410464695 Closing in favour of your other PR This is an automated message

[GitHub] ashb closed pull request #3495: Small fix for BranchPythonOperator Operator

ashb closed pull request #3495: Small fix for BranchPythonOperator Operator URL: https://github.com/apache/incubator-airflow/pull/3495 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] codecov-io edited a comment on issue #3664: [AIRFLOW-2821] Refine Doc "Plugins"

codecov-io edited a comment on issue #3664: [AIRFLOW-2821] Refine Doc "Plugins" URL: https://github.com/apache/incubator-airflow/pull/3664#issuecomment-408755463 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3664?src=pr=h1) Report > Merging

[GitHub] tedmiston opened a new pull request #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

tedmiston opened a new pull request #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] caddac commented on issue #3684: [AIRFLOW-2840] - add update connections cli option

caddac commented on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410483663 I've also noticed the cli option for adding connections doesn't support adding connections with duplicate `conn_id`,

[GitHub] SandroLuck commented on issue #3530: [AIRFLOW-2609] Fixed behavior of BranchPythonOperator

SandroLuck commented on issue #3530: [AIRFLOW-2609] Fixed behavior of BranchPythonOperator URL: https://github.com/apache/incubator-airflow/pull/3530#issuecomment-410485374 I'll have a look at it This is an automated

[GitHub] feng-tao commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

feng-tao commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-410487166 Thanks @tedmiston for fixing that. I wonder if @mistercrunch knows the initial reason behind using the original import

[GitHub] XD-DENG commented on a change in pull request #3664: [AIRFLOW-2821] Refine Doc "Plugins"

XD-DENG commented on a change in pull request #3664: [AIRFLOW-2821] Refine Doc "Plugins" URL: https://github.com/apache/incubator-airflow/pull/3664#discussion_r207714857 ## File path: docs/plugins.rst ## @@ -78,6 +78,21 @@ looks like: menu_links = [] +You can

[GitHub] codecov-io commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

codecov-io commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-410476973 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3696?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

codecov-io edited a comment on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-410476973 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3696?src=pr=h1) Report > Merging

[GitHub] tedmiston commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI

tedmiston commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI URL: https://github.com/apache/incubator-airflow/pull/3646#issuecomment-410482645 Thanks @ashb! Looks like you're right. On my personal account it "just worked" after I

[GitHub] tedmiston closed pull request #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI

tedmiston closed pull request #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI URL: https://github.com/apache/incubator-airflow/pull/3646 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] tedmiston commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI

tedmiston commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI URL: https://github.com/apache/incubator-airflow/pull/3646#issuecomment-410482688 Closing this PR for now as I have more work to do here first.

[GitHub] tedmiston edited a comment on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI

tedmiston edited a comment on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI URL: https://github.com/apache/incubator-airflow/pull/3646#issuecomment-410482688 Closing this PR for now as I have more work to do here before it can be merged.

[GitHub] ashb commented on a change in pull request #3664: [AIRFLOW-2821] Refine Doc "Plugins"

ashb commented on a change in pull request #3664: [AIRFLOW-2821] Refine Doc "Plugins" URL: https://github.com/apache/incubator-airflow/pull/3664#discussion_r207714602 ## File path: docs/plugins.rst ## @@ -78,6 +78,21 @@ looks like: menu_links = [] +You can

[GitHub] tedmiston commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

tedmiston commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-410466590 Good catch. I'm not sure how we made it this long without `tox` in there. I happen to install it

[GitHub] codecov-io commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

codecov-io commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410465847 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3693?src=pr=h1) Report > Merging

[GitHub] caddac commented on issue #3684: [AIRFLOW-2840] - add update connections cli option

caddac commented on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410482953 Would updating all of the connections be acceptable? Maybe with a flag to indicate this behavior? Or is refusing to update

[GitHub] feng-tao commented on issue #3637: [AIRFLOW-2796] Improve utils helpers code coverage

feng-tao commented on issue #3637: [AIRFLOW-2796] Improve utils helpers code coverage URL: https://github.com/apache/incubator-airflow/pull/3637#issuecomment-410487278 lgtm. Thanks for adding the test @andscoop . This is an

[GitHub] feng-tao commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

feng-tao commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-410487193 need to rebase. This is an automated message

[GitHub] ashb commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

ashb commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-410466900 I both have it installed globally, and don’t run with tox locally because the full test suite non-parallel takes

[GitHub] tedmiston opened a new pull request #3695: [AIRFLOW-2850] Remove deprecated airflow.utils.apply_defaults

tedmiston opened a new pull request #3695: [AIRFLOW-2850] Remove deprecated airflow.utils.apply_defaults URL: https://github.com/apache/incubator-airflow/pull/3695 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] codecov-io commented on issue #3695: [AIRFLOW-2850] Remove deprecated airflow.utils.apply_defaults

codecov-io commented on issue #3695: [AIRFLOW-2850] Remove deprecated airflow.utils.apply_defaults URL: https://github.com/apache/incubator-airflow/pull/3695#issuecomment-410476727 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3695?src=pr=h1) Report > Merging

[GitHub] feng-tao closed pull request #3637: [AIRFLOW-2796] Improve utils helpers code coverage

feng-tao closed pull request #3637: [AIRFLOW-2796] Improve utils helpers code coverage URL: https://github.com/apache/incubator-airflow/pull/3637 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] kaxil commented on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package

kaxil commented on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#issuecomment-410443782 @Fokko That looks fine. I wasn't entirely sure about `assert` just being a debug tool. But looks like it is from the

[GitHub] ashb closed pull request #3694: [AIRFLOW-2849] Add missing dependency flake8 to setup to allow running code quality checks locally

ashb closed pull request #3694: [AIRFLOW-2849] Add missing dependency flake8 to setup to allow running code quality checks locally URL: https://github.com/apache/incubator-airflow/pull/3694 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] ashb closed pull request #2722: [AIRFLOW-1749] Fix has_option to consider environment and cmd overrides

ashb closed pull request #2722: [AIRFLOW-1749] Fix has_option to consider environment and cmd overrides URL: https://github.com/apache/incubator-airflow/pull/2722 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] ashb commented on issue #2722: [AIRFLOW-1749] Fix has_option to consider environment and cmd overrides

ashb commented on issue #2722: [AIRFLOW-1749] Fix has_option to consider environment and cmd overrides URL: https://github.com/apache/incubator-airflow/pull/2722#issuecomment-410461814 Fixed as part of #3029. This is an

[GitHub] codecov-io edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

codecov-io edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-409789720 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3678?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package

codecov-io edited a comment on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#issuecomment-410424110 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3690?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package

codecov-io edited a comment on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#issuecomment-410424110 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3690?src=pr=h1) Report > Merging

[GitHub] ashb closed pull request #1998: [AIRFLOW-763] Add contrib check operator for Vertica

ashb closed pull request #1998: [AIRFLOW-763] Add contrib check operator for Vertica URL: https://github.com/apache/incubator-airflow/pull/1998 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] kaxil commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

kaxil commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410443943 @XD-DENG Yes, but it doesn't say how you can put the values in `Extra` params. This is easy in UI but it would be good to have

[GitHub] kaxil commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

kaxil commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410445618 @ashb Yes, you are right. @XD-DENG Can you please add a note which tells the users about this limitation.

[GitHub] ashb commented on issue #3684: [AIRFLOW-2840] - add update connections cli option

ashb commented on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410460193 connection ID is (by design) non-unique - its a mechanism of load balancing across multiple DBs for instance - you can have

[GitHub] ashb removed a comment on issue #3684: [AIRFLOW-2840] - add update connections cli option

ashb removed a comment on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410460193 connection ID is (by design) non-unique - its a mechanism of load balancing across multiple DBs for instance - you

[GitHub] ashb closed pull request #2237: [AIRFLOW-1102] Add `python:` prefix for gunicorn config to make it working with gunicorn 19.4+

ashb closed pull request #2237: [AIRFLOW-1102] Add `python:` prefix for gunicorn config to make it working with gunicorn 19.4+ URL: https://github.com/apache/incubator-airflow/pull/2237 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] ashb commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

ashb commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410463737 Good spot. Could you add a simple test please? Probably to somewhere in tests/core.py or tests/jobs.py

[GitHub] ashb commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

ashb commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410444795 We should probably add that at some point - perhaps by looking at multiple env vars for one connection. We have the issue that

[GitHub] xnuinside commented on a change in pull request #3690: [AIRFLOW-2845] Remove asserts from the contrib package

xnuinside commented on a change in pull request #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#discussion_r207708750 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -1518,14 +1517,17 @@

[GitHub] ashb commented on issue #3650: [AIRFLOW-2703] exceptions from scheduler's heartbeat is handled so that scheduler does not crash

ashb commented on issue #3650: [AIRFLOW-2703] exceptions from scheduler's heartbeat is handled so that scheduler does not crash URL: https://github.com/apache/incubator-airflow/pull/3650#issuecomment-410460440 What sort of exceptions happen here? Do we need to worry about the same error

[GitHub] ashb closed pull request #2143: [AIRFLOW-661] Add Celery broker_transport_options config

ashb closed pull request #2143: [AIRFLOW-661] Add Celery broker_transport_options config URL: https://github.com/apache/incubator-airflow/pull/2143 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] ashb commented on issue #2143: [AIRFLOW-661] Add Celery broker_transport_options config

ashb commented on issue #2143: [AIRFLOW-661] Add Celery broker_transport_options config URL: https://github.com/apache/incubator-airflow/pull/2143#issuecomment-410462856 Fixed in #2842. Sorry we didn't merge this one when it was first opened. (I'm doing a bit of a tidy up of old

[GitHub] ashb commented on a change in pull request #3605: [AIRFLOW-1238] Decode URL-encoded characters.

ashb commented on a change in pull request #3605: [AIRFLOW-1238] Decode URL-encoded characters. URL: https://github.com/apache/incubator-airflow/pull/3605#discussion_r207714364 ## File path: airflow/models.py ## @@ -686,8 +686,8 @@ def parse_from_uri(self, uri):

[GitHub] ashb commented on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package

ashb commented on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#issuecomment-410444352 Most of the time `assert` is enabled in Python, but it _can_ be disabled so shouldn't be relied on for critical checks.

[GitHub] ashb commented on issue #2804: [AIRFLOW-528] Add missing parameter in webserver systemd file

ashb commented on issue #2804: [AIRFLOW-528] Add missing parameter in webserver systemd file URL: https://github.com/apache/incubator-airflow/pull/2804#issuecomment-410461589 I also don't have any issues on Ubuntu 16.04.

[GitHub] ashb closed pull request #2804: [AIRFLOW-528] Add missing parameter in webserver systemd file

ashb closed pull request #2804: [AIRFLOW-528] Add missing parameter in webserver systemd file URL: https://github.com/apache/incubator-airflow/pull/2804 This is an automated message from the Apache Git Service. To respond

[GitHub] ashb commented on a change in pull request #3653: [AIRFLOW-2811] Fix scheduler_ops_metrics.py to work

ashb commented on a change in pull request #3653: [AIRFLOW-2811] Fix scheduler_ops_metrics.py to work URL: https://github.com/apache/incubator-airflow/pull/3653#discussion_r207714253 ## File path: scripts/perf/scheduler_ops_metrics.py ## @@ -178,6 +181,17 @@ def

[GitHub] XD-DENG commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

XD-DENG commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410444530 hi @kaxil , I think @ashb is right. I checked

[GitHub] XD-DENG edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

XD-DENG edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410444530 hi @kaxil , I think @ashb is right. I checked

[GitHub] eyaltrabelsi opened a new pull request #3694: [AIRFLOW-2849] Add missing dependency flake8 to setup to allow running code quality checks locally

eyaltrabelsi opened a new pull request #3694: [AIRFLOW-2849] Add missing dependency flake8 to setup to allow running code quality checks locally URL: https://github.com/apache/incubator-airflow/pull/3694 Make sure you have checked _all_ steps below. ### Jira - [X] My PR

[GitHub] ashb commented on issue #3489: [AIRFLOW-2594][WIP] Remove implicit commits

ashb commented on issue #3489: [AIRFLOW-2594][WIP] Remove implicit commits URL: https://github.com/apache/incubator-airflow/pull/3489#issuecomment-410461203 Interesting. What effect does this have on performance/load times? Would using a per-thread session available in SQLAlchemy

[GitHub] ashb commented on issue #2237: [AIRFLOW-1102] Add `python:` prefix for gunicorn config to make it working with gunicorn 19.4+

ashb commented on issue #2237: [AIRFLOW-1102] Add `python:` prefix for gunicorn config to make it working with gunicorn 19.4+ URL: https://github.com/apache/incubator-airflow/pull/2237#issuecomment-410462263 Closing in favour of the (merged) other PR. Now that we can close PRs \o/

[GitHub] ashb commented on issue #1998: [AIRFLOW-763] Add contrib check operator for Vertica

ashb commented on issue #1998: [AIRFLOW-763] Add contrib check operator for Vertica URL: https://github.com/apache/incubator-airflow/pull/1998#issuecomment-410463216 Closing - sounds like it's not needed. This is an

[GitHub] feng-tao closed pull request #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

feng-tao closed pull request #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] feng-tao commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

feng-tao commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410493784 lgtm, thanks for the fix. This is an

[GitHub] XD-DENG commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

XD-DENG commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410494299 Thanks @feng-tao This is an automated

[GitHub] Fokko commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

Fokko commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-410503637 In case who missed it: https://www.youtube.com/watch?v=5Il3w2P7IcM Awesome work @holdenk for getting people

[GitHub] bolkedebruin commented on issue #3684: [AIRFLOW-2840] - add update connections cli option

bolkedebruin commented on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410501309 Please move the core of the code out of the cli (e.g. make it part of the Connection model, see DagRun for an

[GitHub] feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id

feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id URL: https://github.com/apache/incubator-airflow/pull/3629#issuecomment-410490463 Do you have a pass travis CI link for your pr in your local repo?

[GitHub] feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id

feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id URL: https://github.com/apache/incubator-airflow/pull/3629#issuecomment-410490436 LGTM This is an automated message from the

[GitHub] codecov-io edited a comment on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

codecov-io edited a comment on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410465847 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3693?src=pr=h1) Report >

[GitHub] XD-DENG commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

XD-DENG commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410492163 Hi @ashb , as suggested, a test has been added into `tests/jobs.py` to check whether a few essential

[GitHub] feng-tao commented on a change in pull request #3650: [AIRFLOW-2703] exceptions from scheduler's heartbeat is handled so that scheduler does not crash

feng-tao commented on a change in pull request #3650: [AIRFLOW-2703] exceptions from scheduler's heartbeat is handled so that scheduler does not crash URL: https://github.com/apache/incubator-airflow/pull/3650#discussion_r207726248 ## File path: airflow/jobs.py ## @@

[GitHub] codecov-io commented on issue #3697: [AIRFLOW-2854] kubernetes_pod_operator add more configuration items

codecov-io commented on issue #3697: [AIRFLOW-2854] kubernetes_pod_operator add more configuration items URL: https://github.com/apache/incubator-airflow/pull/3697#issuecomment-410507534 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3697?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3697: [AIRFLOW-2854] kubernetes_pod_operator add more configuration items

codecov-io edited a comment on issue #3697: [AIRFLOW-2854] kubernetes_pod_operator add more configuration items URL: https://github.com/apache/incubator-airflow/pull/3697#issuecomment-410507534 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3697?src=pr=h1) Report >

[GitHub] Cplo opened a new pull request #3697: [AIRFLOW-2854] kubernetes_pod_operator add more configuration items

Cplo opened a new pull request #3697: [AIRFLOW-2854] kubernetes_pod_operator add more configuration items URL: https://github.com/apache/incubator-airflow/pull/3697 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] ashb commented on issue #3684: [AIRFLOW-2840] - add update connections cli option

ashb commented on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410517934 @bolkedeburin no worries on the label, I was just using them as a way of tracking in the PRs page which ones we've looked at

[GitHub] bolkedebruin edited a comment on issue #3684: [AIRFLOW-2840] - add update connections cli option

bolkedebruin edited a comment on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410501309 Please move the core of the code out of the cli (I.e. split between api/Commons and changes to the connection

[GitHub] bolkedebruin commented on issue #3684: [AIRFLOW-2840] - add update connections cli option

bolkedebruin commented on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410514576 O sorry @ashb I think I accidentally removed the label

[GitHub] XD-DENG opened a new pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file()

XD-DENG opened a new pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file() URL: https://github.com/apache/incubator-airflow/pull/3698 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)

[GitHub] andscoop opened a new pull request #3699: [AIRFLOW-2853] Add official committers to README

andscoop opened a new pull request #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] andscoop commented on a change in pull request #3699: [AIRFLOW-2853] Add official committers to README

andscoop commented on a change in pull request #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#discussion_r207743223 ## File path: README.md ## @@ -274,6 +270,35 @@ Currently **officially** using Airflow:

[GitHub] andscoop commented on a change in pull request #3699: [AIRFLOW-2853] Add official committers to README

andscoop commented on a change in pull request #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#discussion_r207743532 ## File path: README.md ## @@ -274,6 +270,35 @@ Currently **officially** using Airflow:

[GitHub] codecov-io commented on issue #3699: [AIRFLOW-2853] Add official committers to README

codecov-io commented on issue #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#issuecomment-410536262 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3699?src=pr=h1) Report > Merging

[GitHub] bolkedebruin commented on issue #3700: [AIRFLOW-2140] Don't require kubernetes for the SparkSubmit hook

bolkedebruin commented on issue #3700: [AIRFLOW-2140] Don't require kubernetes for the SparkSubmit hook URL: https://github.com/apache/incubator-airflow/pull/3700#issuecomment-410538108 Can you verify other hooks / operators as well?

[GitHub] ashb commented on a change in pull request #3699: [AIRFLOW-2853] Add official committers to README

ashb commented on a change in pull request #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#discussion_r207743076 ## File path: README.md ## @@ -274,6 +270,35 @@ Currently **officially** using Airflow: 1.

[GitHub] ashb commented on a change in pull request #3699: [AIRFLOW-2853] Add official committers to README

ashb commented on a change in pull request #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#discussion_r207743727 ## File path: README.md ## @@ -274,6 +270,35 @@ Currently **officially** using Airflow: 1.

[GitHub] kaxil closed pull request #3664: [AIRFLOW-2821] Refine Doc "Plugins"

kaxil closed pull request #3664: [AIRFLOW-2821] Refine Doc "Plugins" URL: https://github.com/apache/incubator-airflow/pull/3664 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] codecov-io edited a comment on issue #3699: [AIRFLOW-2853] Add official committers to README

codecov-io edited a comment on issue #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#issuecomment-410536262 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3699?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3699: [AIRFLOW-2853] Add official committers to README

codecov-io edited a comment on issue #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#issuecomment-410536262 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3699?src=pr=h1) Report > Merging

[GitHub] kaxil closed pull request #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

kaxil closed pull request #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] kaxil closed pull request #3695: [AIRFLOW-2850] Remove deprecated airflow.utils.apply_defaults

kaxil closed pull request #3695: [AIRFLOW-2850] Remove deprecated airflow.utils.apply_defaults URL: https://github.com/apache/incubator-airflow/pull/3695 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] codecov-io commented on issue #3700: [AIRFLOW-2140] Don't require kubernetes for the SparkSubmit hook

codecov-io commented on issue #3700: [AIRFLOW-2140] Don't require kubernetes for the SparkSubmit hook URL: https://github.com/apache/incubator-airflow/pull/3700#issuecomment-410537638 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3700?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3699: [AIRFLOW-2853] Add official committers to README

codecov-io edited a comment on issue #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#issuecomment-410536262 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3699?src=pr=h1) Report > Merging

[GitHub] r39132 commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues

r39132 commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues URL: https://github.com/apache/incubator-airflow/pull/3656#issuecomment-410548883 Any updates on this PR? This is an automated message from the

[GitHub] codecov-io commented on issue #3701: [AIRFLOW-2856] Pass in SLUGIFY_USES_TEXT_UNIDECODE=yes ENV to docker run

codecov-io commented on issue #3701: [AIRFLOW-2856] Pass in SLUGIFY_USES_TEXT_UNIDECODE=yes ENV to docker run URL: https://github.com/apache/incubator-airflow/pull/3701#issuecomment-410549010 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3701?src=pr=h1) Report >

[GitHub] andscoop commented on issue #3699: [AIRFLOW-2853] Add official committers to README

andscoop commented on issue #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#issuecomment-410549554 @r39132 please try again - just officially signed up for the cwiki which is apparently different than the jira signup.

[GitHub] andscoop opened a new pull request #3702: [AIRFLOW-81] add ScheduleBlackoutSensor

andscoop opened a new pull request #3702: [AIRFLOW-81] add ScheduleBlackoutSensor URL: https://github.com/apache/incubator-airflow/pull/3702 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] r39132 commented on issue #3699: [AIRFLOW-2853] Add official committers to README

r39132 commented on issue #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#issuecomment-410550116 @andscoop I graned you access... please update the wiki.

[GitHub] r39132 edited a comment on issue #3699: [AIRFLOW-2853] Add official committers to README

r39132 edited a comment on issue #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#issuecomment-410550116 @andscoop I granted you access... please update the wiki.

[GitHub] r39132 edited a comment on issue #3699: [AIRFLOW-2853] Add official committers to README

r39132 edited a comment on issue #3699: [AIRFLOW-2853] Add official committers to README URL: https://github.com/apache/incubator-airflow/pull/3699#issuecomment-410550116 @andscoop I granted you access... though I see in your PR, that you do still link to the cwiki. You may not have much

  1   2   3   4   5   6   7   8   9   10   >