Re: [I] [Improvement]: Use Duration unit with Self-optimizing Configurations [amoro]

2025-09-14 Thread via GitHub
github-actions[bot] commented on issue #3119: URL: https://github.com/apache/amoro/issues/3119#issuecomment-3268398733 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [PR] Release Apache amoro 0.8.1-incubating [amoro-site]

2025-09-13 Thread via GitHub
zhoujinsong merged PR #58: URL: https://github.com/apache/amoro-site/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.a

Re: [PR] [AMORO-3729][Improvement]: Clear up unnecessary but memory-consuming records in table optimizing_process_state [amoro]

2025-09-12 Thread via GitHub
github-actions[bot] commented on PR #3730: URL: https://github.com/apache/amoro/pull/3730#issuecomment-3287195096 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull re

Re: [PR] [Subtask]: add "bucket_id" field to the table_identifier table to support balanced table partitioning in master-slave mode. [amoro]

2025-09-12 Thread via GitHub
wardlican commented on PR #3783: URL: https://github.com/apache/amoro/pull/3783#issuecomment-3284465054 > Hi, maybe we can add this new column to the `table_runtime` table rather than the `table_identifier` table. > > The `table_identifier` table is used to represent the identificatio

Re: [PR] [Subtask]: add "bucket_id" field to the table_identifier table to support balanced table partitioning in master-slave mode. [amoro]

2025-09-12 Thread via GitHub
zhoujinsong commented on PR #3783: URL: https://github.com/apache/amoro/pull/3783#issuecomment-3284384785 Hi, maybe we can add this new column to the `table_runtime` table rather than the `table_identifier` table. The `table_identifier` table is used to represent the identification i

Re: [PR] [Amoro-3762][Subtask] Change TableService to SPI mode to support expansion of other implementation methods. [amoro]

2025-09-12 Thread via GitHub
wardlican commented on PR #3764: URL: https://github.com/apache/amoro/pull/3764#issuecomment-3284193114 > > To distinguish between the master-slave mode and the master-slave mode, the newly added master-slave mode should not affect the original logic. The master-slave mode will make more lo

[I] [Subtask]: The "bucket_id" field is added to the table_identifier table to support balanced table partitioning in master-slave mode. [amoro]

2025-09-12 Thread via GitHub
wardlican opened a new issue, #3782: URL: https://github.com/apache/amoro/issues/3782 ### Search before asking - [x] I have searched in the [issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no similar issues. ### Description The "bucket_id" fie

[I] [Feature]: Save the last completion time of the executor cleanup [amoro]

2025-09-12 Thread via GitHub
zhangwl9 opened a new issue, #3781: URL: https://github.com/apache/amoro/issues/3781 ### Description _No response_ ### Use case/motivation The Amoro cleanup executor triggers its first execution when AMS starts, and subsequently runs periodically according to its respect

Re: [PR] [AMORO-3541]Support readonly user [amoro]

2025-09-11 Thread via GitHub
zhoujinsong commented on PR #3544: URL: https://github.com/apache/amoro/pull/3544#issuecomment-3283540019 Sorry for the delay in reviewing. Will you fix the conflicts? And we can push forward this PR together then. @ihadoop -- This is an automated message from the Apache Git Servi

Re: [I] [Improvement]: Optimizing the RestAPI efficiency [amoro]

2025-09-11 Thread via GitHub
github-actions[bot] commented on issue #3064: URL: https://github.com/apache/amoro/issues/3064#issuecomment-3268398685 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [PR] [AMORO-3772] Fix AuthenticatedHiveClientPool init fail and MixedTables#createChangeStore log printing error [amoro]

2025-09-11 Thread via GitHub
zhoujinsong merged PR #3773: URL: https://github.com/apache/amoro/pull/3773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.ap

Re: [PR] [AMORO-3632]: data-retention, add support for partition column type Date [amoro]

2025-09-11 Thread via GitHub
zhoujinsong commented on PR #3665: URL: https://github.com/apache/amoro/pull/3665#issuecomment-3283560042 @lsyulong do you still have time to fix the issues in CI or can I help you fix it if you need? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [AMORO-3608] Using rolling batch files cleaner to reduce memory usage [amoro]

2025-09-11 Thread via GitHub
zhoujinsong commented on code in PR #3630: URL: https://github.com/apache/amoro/pull/3630#discussion_r2342876485 ## amoro-ams/src/main/java/org/apache/amoro/server/utils/RollingFileCleaner.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [AMORO-3754]failed to failover when only one node is alive in ha mode #3754 [amoro]

2025-09-11 Thread via GitHub
zhoujinsong commented on code in PR #3768: URL: https://github.com/apache/amoro/pull/3768#discussion_r2342840471 ## amoro-ams/src/main/java/org/apache/amoro/server/AmoroServiceContainer.java: ## @@ -200,11 +200,11 @@ private void addHandlerChain(RuntimeHandlerChain chain) { }

[PR] Fix the download url for source. [amoro-site]

2025-09-11 Thread via GitHub
Jzjsnow opened a new pull request, #62: URL: https://github.com/apache/amoro-site/pull/62 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] Enhance the release guide for the web release procedure [amoro-site]

2025-09-11 Thread via GitHub
klion26 opened a new pull request, #61: URL: https://github.com/apache/amoro-site/pull/61 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Fix the download url for source. [amoro-site]

2025-09-11 Thread via GitHub
klion26 merged PR #62: URL: https://github.com/apache/amoro-site/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.apach

Re: [PR] Fix the download url for source. [amoro-site]

2025-09-11 Thread via GitHub
klion26 commented on PR #62: URL: https://github.com/apache/amoro-site/pull/62#issuecomment-3283323989 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Enhance the release guide for the web release procedure [amoro-site]

2025-09-11 Thread via GitHub
klion26 commented on PR #61: URL: https://github.com/apache/amoro-site/pull/61#issuecomment-3283110535 cc @zhoujinsong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] [Improvement] Implement manifest-driven data expiration [amoro]

2025-09-11 Thread via GitHub
xxubai opened a new pull request, #3780: URL: https://github.com/apache/amoro/pull/3780 ## Why are the changes needed? Close #3749 . ## Brief change log - Reduce I/O frequency by tuning manifest operations - Limit the maximum number of cached data/delet

Re: [I] [Bug]: AuthenticatedHiveClientPool init fail and MixedTables#createChangeStore log printing error [amoro]

2025-09-11 Thread via GitHub
zhoujinsong closed issue #3772: [Bug]: AuthenticatedHiveClientPool init fail and MixedTables#createChangeStore log printing error URL: https://github.com/apache/amoro/issues/3772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] [Improvement]: Add healthScoreDetails page to show details of healthScore [amoro]

2025-09-11 Thread via GitHub
xxubai closed issue #3736: [Improvement]: Add healthScoreDetails page to show details of healthScore URL: https://github.com/apache/amoro/issues/3736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [AMORO-3736]Add healthScoreDetails page to show details of healthScore [amoro]

2025-09-11 Thread via GitHub
xxubai merged PR #3769: URL: https://github.com/apache/amoro/pull/3769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.apache.

Re: [PR] [AMORO-3778] Add release yml to auto generate the release note [amoro]

2025-09-11 Thread via GitHub
zhoujinsong commented on PR #3779: URL: https://github.com/apache/amoro/pull/3779#issuecomment-3280323709 Is [here](https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes) the detailed guide of this change? -- This is an automated messa

[PR] [AMORO-3778] Add release yml to auto generate the release note [amoro]

2025-09-11 Thread via GitHub
klion26 opened a new pull request, #3779: URL: https://github.com/apache/amoro/pull/3779 ## Why are the changes needed? Close #3778 . ## Brief change log - ## How was this patch tested? - [ ] Add some test cases that check the changes thoroug

Re: [PR] [AMORO-SITE-59] Improve the release guide [amoro-site]

2025-09-11 Thread via GitHub
klion26 commented on PR #60: URL: https://github.com/apache/amoro-site/pull/60#issuecomment-3280053367 cc @zhoujinsong @xxubai -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] [AMORO-SITE-59] Improve the release guide [amoro-site]

2025-09-11 Thread via GitHub
klion26 opened a new pull request, #60: URL: https://github.com/apache/amoro-site/pull/60 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] Release Apache amoro 0.8.1-incubating [amoro-site]

2025-09-11 Thread via GitHub
Jzjsnow opened a new pull request, #58: URL: https://github.com/apache/amoro-site/pull/58 Update with 0.8.1 release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] [Feature]: Refactor AMS using function and process api [amoro]

2025-09-11 Thread via GitHub
github-actions[bot] commented on issue #2596: URL: https://github.com/apache/amoro/issues/2596#issuecomment-3276924857 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

Re: [PR] Combine the functions of the executors to reduce the number of table loads [amoro]

2025-09-10 Thread via GitHub
github-actions[bot] commented on PR #3657: URL: https://github.com/apache/amoro/pull/3657#issuecomment-3276925073 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull re

Re: [I] [Feature]: Support multi-instance AMS REST service [amoro]

2025-09-10 Thread via GitHub
github-actions[bot] closed issue #2810: [Feature]: Support multi-instance AMS REST service URL: https://github.com/apache/amoro/issues/2810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] [Feature]: Enable catalog-level default properties storing into underlying tables within a unified catalog [amoro]

2025-09-10 Thread via GitHub
github-actions[bot] commented on issue #3470: URL: https://github.com/apache/amoro/issues/3470#issuecomment-3276925025 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] [Feature]: Refactor AMS using function and process api [amoro]

2025-09-10 Thread via GitHub
github-actions[bot] closed issue #2596: [Feature]: Refactor AMS using function and process api URL: https://github.com/apache/amoro/issues/2596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] [AMORO-3775] Add support for pluggable refresh event in TableRuntimeRefreshExecutor [amoro]

2025-09-09 Thread via GitHub
Jzjsnow opened a new pull request, #3776: URL: https://github.com/apache/amoro/pull/3776 ## Why are the changes needed? Close #3775. ## Brief change log - Through SPI mode, make the refresh and evaluation process in TableRuntimeRefreshExecutor a pluggable

[I] [Subtask]: Add support for pluggable refresh event in TableRuntimeRefreshExecutor and DefaultRefreshEvent [amoro]

2025-09-09 Thread via GitHub
Jzjsnow opened a new issue, #3775: URL: https://github.com/apache/amoro/issues/3775 ### Search before asking - [x] I have searched in the [issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no similar issues. ### Description Through SPI mode, mak

[I] [Feature]: Event-Triggered Optimization of Iceberg Tables in Amoro [amoro]

2025-09-09 Thread via GitHub
Jzjsnow opened a new issue, #3774: URL: https://github.com/apache/amoro/issues/3774 ### Description Currently, Amoro determines Iceberg table optimizations through periodic full-refresh evaluations at the table level. While this design ensures consistent refreshes, it introduces inef

Re: [I] [Bug]: Issue with Table Optimization Due to Duplicate Insertions [amoro]

2025-09-08 Thread via GitHub
github-actions[bot] commented on issue #3408: URL: https://github.com/apache/amoro/issues/3408#issuecomment-3268399007 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] [Bug]: The commit.retry.num-retries configuration does not take effect when configured on the catalog. [amoro]

2025-09-08 Thread via GitHub
github-actions[bot] commented on issue #3384: URL: https://github.com/apache/amoro/issues/3384#issuecomment-3268398861 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] [Improvement]: AK/SK Leakage Security [amoro]

2025-09-08 Thread via GitHub
github-actions[bot] commented on issue #3310: URL: https://github.com/apache/amoro/issues/3310#issuecomment-3268398817 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] [Bug]: Process deadlock causes the Amoro process to be stuck in committing permanently. [amoro]

2025-09-08 Thread via GitHub
github-actions[bot] commented on issue #3395: URL: https://github.com/apache/amoro/issues/3395#issuecomment-3268398943 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] [Bug]: Optimization records cannot be seen in some table details on Amoro UI [amoro]

2025-09-08 Thread via GitHub
github-actions[bot] commented on issue #3388: URL: https://github.com/apache/amoro/issues/3388#issuecomment-3268398907 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] [Improvement]: There are slow SQL issues when querying the optimizing process [amoro]

2025-09-08 Thread via GitHub
github-actions[bot] commented on issue #2869: URL: https://github.com/apache/amoro/issues/2869#issuecomment-3268398637 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [PR] [AMORO-3698] Remove Flink 1.15 modules [amoro]

2025-09-08 Thread via GitHub
codecov-commenter commented on PR #3771: URL: https://github.com/apache/amoro/pull/3771#issuecomment-3266089514 ## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3771?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

Re: [PR] [AMORO-3772] Fix AuthenticatedHiveClientPool init fail and MixedTables#createChangeStore log printing error [amoro]

2025-09-08 Thread via GitHub
gong commented on PR #3773: URL: https://github.com/apache/amoro/pull/3773#issuecomment-3266659670 @zhoujinsong @baiyangtx PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] [AMORO-3772] Fix AuthenticatedHiveClientPool init fail and MixedTables#createChangeStore log printing error [amoro]

2025-09-08 Thread via GitHub
gong opened a new pull request, #3773: URL: https://github.com/apache/amoro/pull/3773 ## Why are the changes needed? Close #3772. ## Brief change log -[amoro-common] Fix AuthenticatedHiveClientPool init -[amoro-format-iceberg] Fix MixedTables#cr

[PR] [AMORO-3698] Remove Flink 1.15 modules [amoro]

2025-09-08 Thread via GitHub
ygjia opened a new pull request, #3771: URL: https://github.com/apache/amoro/pull/3771 ## Why are the changes needed? Close #3698 ## Brief change log - Remove Flink 1.15 modules for mixed format ## How was this patch tested? Pass CI -

Re: [PR] [AMORO-3697] add Flink 1.18 support for mixed-format [amoro]

2025-09-08 Thread via GitHub
zhoujinsong merged PR #3700: URL: https://github.com/apache/amoro/pull/3700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.ap

Re: [I] [Feature]: Improve the release procedure [amoro]

2025-09-08 Thread via GitHub
klion26 commented on issue #3770: URL: https://github.com/apache/amoro/issues/3770#issuecomment-3265376059 one option for the improvements: maybe we can use Github action to trigger the release -- This is an automated message from the Apache Git Service. To respond to the message, please

[I] [Feature]: Improve the release procedure [amoro]

2025-09-08 Thread via GitHub
klion26 opened a new issue, #3770: URL: https://github.com/apache/amoro/issues/3770 ### Description When releasing 0.8.1-incubating, there are some comments when voting, we need to ``` RECOMMENDATIONS FOR FUTURE RELEASES For Release Process Improvement: 1. Fix sou

Re: [PR] [Improvement]: Introduce TableRuntimeFactory interface [amoro]

2025-09-07 Thread via GitHub
baiyangtx merged PR #3760: URL: https://github.com/apache/amoro/pull/3760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.apac

Re: [PR] [Improvement]: Introduce TableRuntimeFactory interface [amoro]

2025-09-07 Thread via GitHub
Aireed commented on PR #3760: URL: https://github.com/apache/amoro/pull/3760#issuecomment-3264418676 > > I left some tiny comment. PTAL > > Thx for your review, by the way, this PR using plugin system to load TableRuntimeFactory, and I found the plugins config is in `/conf/plugins ` d

Re: [PR] [AMORO-3754]failed to failover when only one node is alive in ha mode #3754 [amoro]

2025-09-07 Thread via GitHub
baiyangtx commented on code in PR #3768: URL: https://github.com/apache/amoro/pull/3768#discussion_r2328996955 ## amoro-ams/src/main/java/org/apache/amoro/server/metrics/MetricRegistry.java: ## @@ -78,6 +78,7 @@ public MetricKey register( define.getName()); Metr

Re: [PR] [Amoro-3762][Subtask] Change TableService to SPI mode to support expansion of other implementation methods. [amoro]

2025-09-07 Thread via GitHub
baiyangtx commented on PR #3764: URL: https://github.com/apache/amoro/pull/3764#issuecomment-3264351244 > To distinguish between the master-slave mode and the master-slave mode, the newly added master-slave mode should not affect the original logic. The master-slave mode will make more

Re: [PR] [Amoro-3762][Subtask] Change TableService to SPI mode to support expansion of other implementation methods. [amoro]

2025-09-07 Thread via GitHub
wardlican commented on code in PR #3764: URL: https://github.com/apache/amoro/pull/3764#discussion_r2328978202 ## amoro-ams/src/main/java/org/apache/amoro/server/table/TableService.java: ## @@ -46,4 +47,16 @@ default boolean contains(Long tableId) { * @return managed table.

Re: [PR] [Amoro-3762][Subtask] Change TableService to SPI mode to support expansion of other implementation methods. [amoro]

2025-09-07 Thread via GitHub
wardlican commented on PR #3764: URL: https://github.com/apache/amoro/pull/3764#issuecomment-3264321760 > t TableService? Whether to deploy in multi-node mode should be controlled by a simple configuration flag; it shouldn’t require a completely separate TableService implementation.

Re: [PR] [AMORO-3736]Add healthScoreDetails page to show details of healthScore [amoro]

2025-09-07 Thread via GitHub
zhangwl9 commented on PR #3769: URL: https://github.com/apache/amoro/pull/3769#issuecomment-3264306522 @MarigWeizhi I see you're the implementer of this [PR.](https://github.com/apache/amoro/issues/3180) Could you please review the code when you have a chance? I'd really appreciate it.

Re: [PR] [AMORO-3736]Add healthScoreDetails page to show details of healthScore [amoro]

2025-09-07 Thread via GitHub
zhangwl9 commented on PR #3769: URL: https://github.com/apache/amoro/pull/3769#issuecomment-3264308248 @xxubai Thank you very much for your suggestions. I have accepted these code modifications. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] [Bug]: java.lang.IllegalArgumentException: Row arity: 2, but serializer arity: 4 [amoro]

2025-09-07 Thread via GitHub
github-actions[bot] closed issue #3003: [Bug]: java.lang.IllegalArgumentException: Row arity: 2, but serializer arity: 4 URL: https://github.com/apache/amoro/issues/3003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Bug]: java.lang.IllegalArgumentException: Row arity: 2, but serializer arity: 4 [amoro]

2025-09-07 Thread via GitHub
github-actions[bot] commented on issue #3003: URL: https://github.com/apache/amoro/issues/3003#issuecomment-3264171488 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

Re: [PR] [AMORO-3608] Using rolling batch files cleaner to reduce memory usage [amoro]

2025-09-07 Thread via GitHub
github-actions[bot] commented on PR #3630: URL: https://github.com/apache/amoro/pull/3630#issuecomment-3256520397 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull re

Re: [PR] [Improvement]: Introduce TableRuntimeFactory interface [amoro]

2025-09-07 Thread via GitHub
Aireed commented on code in PR #3760: URL: https://github.com/apache/amoro/pull/3760#discussion_r2320678201 ## dist/src/main/amoro-bin/conf/plugins/table-runtime-factories.yaml: ## @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

[PR] [Amoro-3766][Subtask] Change TableService to SPI mode to support expansion of other implementation methods. [amoro]

2025-09-07 Thread via GitHub
wardlican opened a new pull request, #3767: URL: https://github.com/apache/amoro/pull/3767 ## Why are the changes needed? Close #3766 . ## Brief change log Through the SPI mode, a new implementation entry for MasterSlaveTableService is added for gradually adding

[PR] [AMORO-3761] Fix licnese-binary [amoro]

2025-09-07 Thread via GitHub
klion26 opened a new pull request, #3765: URL: https://github.com/apache/amoro/pull/3765 ## Why are the changes needed? Close #3761. ## Brief change log - Correct content for snakeyaml-engine in `LICENSE-binary` ## How was this patch tested?

Re: [PR] [Amoro-3762][Subtask] Change TableService to SPI mode to support expansion of other implementation methods. [amoro]

2025-09-07 Thread via GitHub
codecov-commenter commented on PR #3764: URL: https://github.com/apache/amoro/pull/3764#issuecomment-3263816315 ## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3764?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

Re: [I] [Bug]: LICENSE-BINARY lists snakeyaml-engine as BSD license - should be Apache license [amoro]

2025-09-07 Thread via GitHub
xxubai closed issue #3761: [Bug]: LICENSE-BINARY lists snakeyaml-engine as BSD license - should be Apache license URL: https://github.com/apache/amoro/issues/3761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [AMORO-3761] Fix licnese-binary [amoro]

2025-09-06 Thread via GitHub
klion26 commented on PR #3765: URL: https://github.com/apache/amoro/pull/3765#issuecomment-3260207553 @pjfanning @xxubai thanks for for the review and merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [AMORO-3736]Add healthScoreDetails page to show details of healthScore [amoro]

2025-09-06 Thread via GitHub
xxubai commented on code in PR #3769: URL: https://github.com/apache/amoro/pull/3769#discussion_r2325258343 ## amoro-web/src/language/zh.ts: ## @@ -226,4 +226,14 @@ export default { Finished: '已结束', Created: '已创建', totalCount: '共 {total} 条', + healthScoreDetails: '健康分数

Re: [PR] [Amoro-3762][Subtask] Change TableService to SPI mode to support expansion of other implementation methods. [amoro]

2025-09-06 Thread via GitHub
baiyangtx commented on code in PR #3764: URL: https://github.com/apache/amoro/pull/3764#discussion_r2327378787 ## amoro-ams/src/main/java/org/apache/amoro/server/table/TableService.java: ## @@ -46,4 +47,16 @@ default boolean contains(Long tableId) { * @return managed table.

Re: [I] [Bug]: The partition field of the mixed_hive table contains uppercase letters, which can lead to the erroneous deletion of Hive partitions when synchronizing data to Hive. [amoro]

2025-09-05 Thread via GitHub
github-actions[bot] commented on issue #3422: URL: https://github.com/apache/amoro/issues/3422#issuecomment-3260096074 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

Re: [I] [Bug]: The partition field of the mixed_hive table contains uppercase letters, which can lead to the erroneous deletion of Hive partitions when synchronizing data to Hive. [amoro]

2025-09-05 Thread via GitHub
github-actions[bot] closed issue #3422: [Bug]: The partition field of the mixed_hive table contains uppercase letters, which can lead to the erroneous deletion of Hive partitions when synchronizing data to Hive. URL: https://github.com/apache/amoro/issues/3422 -- This is an automated message

[PR] [AMORO-3736]Add healthScoreDetails page to show details of healthScore [amoro]

2025-09-05 Thread via GitHub
zhangwl9 opened a new pull request, #3769: URL: https://github.com/apache/amoro/pull/3769 ## Why are the changes needed? Close #3736. ## Brief change log -Calculate the score for each submodule that constitutes the healthScore, such as SmallFileScore, EqD

Re: [I] [Bug]: set "self-optimizing.enabled=true" but table optimizing task keep pending [amoro]

2025-09-05 Thread via GitHub
xxubai closed issue #3763: [Bug]: set "self-optimizing.enabled=true" but table optimizing task keep pending URL: https://github.com/apache/amoro/issues/3763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [AMORO-3761] Fix licnese-binary [amoro]

2025-09-05 Thread via GitHub
xxubai merged PR #3765: URL: https://github.com/apache/amoro/pull/3765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.apache.

Re: [I] [Bug]: set "self-optimizing.enabled=true" but table optimizing task keep pending [amoro]

2025-09-05 Thread via GitHub
xxubai commented on issue #3763: URL: https://github.com/apache/amoro/issues/3763#issuecomment-3257606013 > no optimizer in default group @CatchYouIfICan The optimizer is the actual job that performs compaction. Please ensure at least one optimizer is running in the group -- This i

[PR] [AMORO-3754]failed to failover when only one node is alive in ha mode #3754 [amoro]

2025-09-05 Thread via GitHub
Aireed opened a new pull request, #3768: URL: https://github.com/apache/amoro/pull/3768 ## Why are the changes needed? Close #3754 . ## Brief change log - call stop regardless of whether the service is serving - unregister metric key before registration

[I] [Subtask]: Supports the use of the default master-slave mode or the extended master-slave mode through configuration control [amoro]

2025-09-05 Thread via GitHub
wardlican opened a new issue, #3766: URL: https://github.com/apache/amoro/issues/3766 ### Search before asking - [x] I have searched in the [issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no similar issues. ### Description Through the SPI mod

Re: [I] [Bug]: set "self-optimizing.enabled=true" but table optimizing task keep pending [amoro]

2025-09-04 Thread via GitHub
CatchYouIfICan commented on issue #3763: URL: https://github.com/apache/amoro/issues/3763#issuecomment-3257228143 > Do you have any optimizers in `default` optimizer group no optimizer in default group -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] [AMORO-3761] Fix licnese-binary [amoro]

2025-09-04 Thread via GitHub
klion26 commented on PR #3765: URL: https://github.com/apache/amoro/pull/3765#issuecomment-3257153064 @zhoujinsong Please help review this when you're free, thanks. cc @pjfanning -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [I] [Bug]: Flaky test for TestDefaultOptimizingService [amoro]

2025-09-04 Thread via GitHub
github-actions[bot] closed issue #3435: [Bug]: Flaky test for TestDefaultOptimizingService URL: https://github.com/apache/amoro/issues/3435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] [Bug]: set "self-optimizing.enabled=true" but table optimizing task keep pending [amoro]

2025-09-04 Thread via GitHub
xxubai commented on issue #3763: URL: https://github.com/apache/amoro/issues/3763#issuecomment-3252620878 Do you have any optimizers in `default` optimizer group -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] [Bug]: LICENSE-BINARY lists snakeyaml-engine as BSD license - should be Apache license [amoro]

2025-09-04 Thread via GitHub
pjfanning opened a new issue, #3761: URL: https://github.com/apache/amoro/issues/3761 ### What happened? https://github.com/apache/amoro/blob/master/LICENSE-binary#L370 https://bitbucket.org/snakeyaml/snakeyaml-engine/src/master/LICENSE.txt ### Affects Versions mas

[PR] [Amoro-3762][Subtask] Change TableService to SPI mode to support expansion of other implementation methods. [amoro]

2025-09-04 Thread via GitHub
wardlican opened a new pull request, #3764: URL: https://github.com/apache/amoro/pull/3764 ## Why are the changes needed? Close #xxx. ## Brief change log Solution Overview Added a new SPI factory interface, TableServiceProvider (based on ServiceLoader).

Re: [PR] [Improvement]: Introduce TableRuntimeFactory interface [amoro]

2025-09-04 Thread via GitHub
baiyangtx commented on PR #3760: URL: https://github.com/apache/amoro/pull/3760#issuecomment-3251693904 > I left some tiny comment. PTAL Thx for your review, by the way, this PR using plugin system to load TableRuntimeFactory, and I found the plugins config is in `/conf/plugins ` dir

[I] [Subtask]: Change TableService to SPI mode to support expansion of other implementation methods. [amoro]

2025-09-04 Thread via GitHub
wardlican opened a new issue, #3762: URL: https://github.com/apache/amoro/issues/3762 ### Search before asking - [x] I have searched in the [issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no similar issues. ### Description Solution Overview

[I] [Bug]: set "self-optimizing.enabled=true" but table optimizing task keep pending [amoro]

2025-09-04 Thread via GitHub
CatchYouIfICan opened a new issue, #3763: URL: https://github.com/apache/amoro/issues/3763 ### What happened? When I set "self-optimizing.enabled=true" to table or catalog, table optimizing task keep pending,this is not reasonable. https://github.com/user-attachments/assets/7f

Re: [I] [Bug]: LICENSE-BINARY lists snakeyaml-engine as BSD license - should be Apache license [amoro]

2025-09-04 Thread via GitHub
klion26 commented on issue #3761: URL: https://github.com/apache/amoro/issues/3761#issuecomment-3252320442 @pjfanning Thanks for reporting this. We'll fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] [Bug]: Flaky test for TestDefaultOptimizingService [amoro]

2025-09-03 Thread via GitHub
github-actions[bot] commented on issue #3435: URL: https://github.com/apache/amoro/issues/3435#issuecomment-3251170235 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

[PR] [Improvement]: Introduce TableRuntimeFactory interface [amoro]

2025-09-03 Thread via GitHub
baiyangtx opened a new pull request, #3760: URL: https://github.com/apache/amoro/pull/3760 ## Why are the changes needed? ## Brief change log - Introduce the TableRuntimeFactory interface with plugin api. - Refactor code about how TableRuntime is created.

[I] [Improvement]: use table_identifier as cache for front-end list table [amoro]

2025-09-03 Thread via GitHub
Aireed opened a new issue, #3759: URL: https://github.com/apache/amoro/issues/3759 ### Search before asking - [x] I have searched in the [issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no similar issues. ### What would you like to be improved?

[I] [Improvement]: Optimize log output of SchedulingPolicy [amoro]

2025-09-03 Thread via GitHub
Aireed opened a new issue, #3755: URL: https://github.com/apache/amoro/issues/3755 ### Search before asking - [x] I have searched in the [issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no similar issues. ### What would you like to be improved?

Re: [I] [Improvement]: Add support for API Token service [amoro]

2025-09-02 Thread via GitHub
zhoujinsong closed issue #3744: [Improvement]: Add support for API Token service URL: https://github.com/apache/amoro/issues/3744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [AMORO-3744] Add support for API Token service [amoro]

2025-09-01 Thread via GitHub
zhoujinsong merged PR #3746: URL: https://github.com/apache/amoro/pull/3746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.ap

[PR] [AMORO-3757] Configure ml for discussion to make .asf.yml notification happy [amoro]

2025-09-01 Thread via GitHub
klion26 opened a new pull request, #3758: URL: https://github.com/apache/amoro/pull/3758 ## Why are the changes needed? Close #3757 . ## Brief change log - Add ml settings for `discussions` in `.asf.yaml` ## How was this patch tested? - [

Re: [PR] [AMORO-3757] Configure ml for discussion to make .asf.yml notification happy [amoro]

2025-09-01 Thread via GitHub
zhoujinsong merged PR #3758: URL: https://github.com/apache/amoro/pull/3758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.ap

Re: [I] [Feature]: Configure the discussion maillist target in .asf.yaml [amoro]

2025-09-01 Thread via GitHub
zhoujinsong closed issue #3757: [Feature]: Configure the discussion maillist target in .asf.yaml URL: https://github.com/apache/amoro/issues/3757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] [Feature]: Configure the discussion maillist target in .asf.yaml [amoro]

2025-09-01 Thread via GitHub
klion26 opened a new issue, #3757: URL: https://github.com/apache/amoro/issues/3757 ### Description In the recently `.asf.yaml`, we enabled notifying the `discussion` message, but didn't configure the mailing list target. Currently, there will be some mail sent to `commits@amoro.apac

Re: [PR] [AMORO-3755][Improvement]: Optimize log output of SchedulingPolicy [amoro]

2025-09-01 Thread via GitHub
zhoujinsong merged PR #3756: URL: https://github.com/apache/amoro/pull/3756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.ap

Re: [I] [Improvement]: Optimize log output of SchedulingPolicy [amoro]

2025-09-01 Thread via GitHub
zhoujinsong closed issue #3755: [Improvement]: Optimize log output of SchedulingPolicy URL: https://github.com/apache/amoro/issues/3755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] [AMORO-3755][Improvement]: Optimize log output of SchedulingPolicy [amoro]

2025-08-31 Thread via GitHub
Aireed opened a new pull request, #3756: URL: https://github.com/apache/amoro/pull/3756 ## Why are the changes needed? Close #3755 ## Brief change log - ## How was this patch tested? - [ ] Add some test cases that check the changes thoroughl

Re: [I] [Improvement]: enable configure session timeout for ha zookeeper [amoro]

2025-08-31 Thread via GitHub
Aireed closed issue #3753: [Improvement]: enable configure session timeout for ha zookeeper URL: https://github.com/apache/amoro/issues/3753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

  1   2   3   4   5   6   7   8   9   10   >