bchapuis merged PR #855:
URL: https://github.com/apache/incubator-baremaps/pull/855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2139384658
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2139381407
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2139377617
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2139225667
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2139219914
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
github-advanced-security[bot] commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619450379
##
baremaps-core/src/main/java/org/apache/baremaps/storage/geoparquet/GeoParquetTypeConversion.java:
##
@@ -0,0 +1,77 @@
+/*
+ * License
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2138223634
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2138219247
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2137782209
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2137782511
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2137770551
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619143177
##
baremaps-core/src/test/java/org/apache/baremaps/storage/geoparquet/GeoParquetToPostgresTest.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Softwa
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619142230
##
baremaps-core/src/main/java/org/apache/baremaps/storage/geoparquet/GeoParquetDataSchema.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software F
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2137762249
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619135943
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,277 @@
+/*
+ * Licensed to the Apache Software Founda
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619135943
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,277 @@
+/*
+ * Licensed to the Apache Software Founda
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619135943
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,277 @@
+/*
+ * Licensed to the Apache Software Founda
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619135943
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,277 @@
+/*
+ * Licensed to the Apache Software Founda
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2137724373
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
bchapuis commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619110238
##
baremaps-core/src/main/java/org/apache/baremaps/storage/geoparquet/GeoParquetTypeConversion.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Softw
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619089065
##
baremaps-core/src/test/java/org/apache/baremaps/storage/geoparquet/GeoParquetToPostgresTest.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Softwa
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619084887
##
baremaps-core/src/main/java/org/apache/baremaps/storage/geoparquet/GeoParquetTypeConversion.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Softwa
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1619084887
##
baremaps-core/src/main/java/org/apache/baremaps/storage/geoparquet/GeoParquetTypeConversion.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Softwa
github-advanced-security[bot] commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1618553524
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,277 @@
+/*
+ * Licensed to the
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2136953944
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https:
github-advanced-security[bot] commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1617937771
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2136174530
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2133966695
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2133964999
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2133958623
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2133936755
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https:
Drabble commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2131242523
I did a little bit of reading on the spec of geoparquet.
https://github.com/opengeospatial/geoparquet/blob/main/format-specs/geoparquet.md
I have a feeling that in our l
bchapuis commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1614617900
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/hadoop/GeoParquetGroupWriteSupport.java:
##
Review Comment:
Yes, I kept them with th
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1614608962
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/hadoop/GeoParquetGroupWriteSupport.java:
##
Review Comment:
All the writer files are
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2130318794
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https:
bchapuis commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613994827
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Found
bchapuis commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613993646
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Found
bchapuis commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613992792
##
pom.xml:
##
@@ -321,6 +340,16 @@ limitations under the License.
lucene-spatial-extras
${version.lib.lucene}
+
Review Comm
github-advanced-security[bot] commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613989180
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2130297886
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2130295171
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https:
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613713190
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/data/FileInfo.java:
##
Review Comment:
We can probably discuss organising these files
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613144814
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Founda
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613144814
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Founda
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613107467
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Founda
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613107467
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Founda
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613104762
##
baremaps-geoparquet/pom.xml:
##
@@ -0,0 +1,54 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schema
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613093655
##
pom.xml:
##
@@ -321,6 +340,16 @@ limitations under the License.
lucene-spatial-extras
${version.lib.lucene}
+
Review Comme
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1613085030
##
pom.xml:
##
@@ -95,13 +96,15 @@ limitations under the License.
6.6.4
23.0.3
33.0.0-jre
+3.4.0
5.1.0
1.52
2.16.1
1.19
bchapuis commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2126406044
@sebr72 I just pushed the `GeoParquetGroup` interface, which I think would
be a decent abstraction to access the records of a geoparquet file. It contains
getters and setters f
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2126397664
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
github-advanced-security[bot] commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1611079446
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/data/GeoParquetGroupImpl.java:
##
@@ -0,0 +1,284 @@
+/*
+ * Licensed
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2126331152
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2126330459
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2124906010
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2124905691
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2124903383
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
github-advanced-security[bot] commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1610010156
##
baremaps-geoparquet/src/test/java/org/apache/baremaps/geoparquet/GeoParquetReaderTest.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to t
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2124855799
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
bchapuis commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2124202443
Previous attempt #851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-advanced-security[bot] commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1609543001
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/data/GeoParquetGroupConverter.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Lice
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2124191651
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2124185876
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
bchapuis commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1609531753
##
pom.xml:
##
@@ -95,13 +96,15 @@ limitations under the License.
6.6.4
23.0.3
33.0.0-jre
+3.4.0
5.1.0
1.52
2.16.1
1.1
bchapuis commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1609526193
##
baremaps-geoparquet/pom.xml:
##
@@ -0,0 +1,46 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schem
github-advanced-security[bot] commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1609042961
##
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##
@@ -0,0 +1,289 @@
+/*
+ * Licensed to the
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2123571420
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https:
Drabble commented on code in PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#discussion_r1608989495
##
baremaps-geoparquet/pom.xml:
##
@@ -0,0 +1,46 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schema
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2123445413
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https:
sonarcloud[bot] commented on PR #855:
URL:
https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2123435583
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https:
bchapuis opened a new pull request, #855:
URL: https://github.com/apache/incubator-baremaps/pull/855
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
72 matches
Mail list logo