[jira] [Commented] (BEAM-1567) hashStream should be closed in PackageUtil#createPackageAttributes()

2017-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892531#comment-15892531 ] ASF GitHub Bot commented on BEAM-1567: -- Github user asfgit closed the pull request at:

[jira] [Commented] (BEAM-1567) hashStream should be closed in PackageUtil#createPackageAttributes()

2017-03-01 Thread JIRA
[ https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891145#comment-15891145 ] Ismaël Mejía commented on BEAM-1567: I just took a look and gave my comments, we will have to wait for

[jira] [Commented] (BEAM-1567) hashStream should be closed in PackageUtil#createPackageAttributes()

2017-03-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890543#comment-15890543 ] Ted Yu commented on BEAM-1567: -- [~iemejia]: Can you take a look at the PR ? Thanks > hashStream should be

[jira] [Commented] (BEAM-1567) hashStream should be closed in PackageUtil#createPackageAttributes()

2017-02-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888484#comment-15888484 ] Ted Yu commented on BEAM-1567: -- [~dhalp...@google.com]: Can you take a look at the latest PR ? > hashStream

[jira] [Commented] (BEAM-1567) hashStream should be closed in PackageUtil#createPackageAttributes()

2017-02-27 Thread JIRA
[ https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887307#comment-15887307 ] Ismaël Mejía commented on BEAM-1567: Welcome [~tedyu] ! Nice to see you here, and even better with a

[jira] [Commented] (BEAM-1567) hashStream should be closed in PackageUtil#createPackageAttributes()

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886905#comment-15886905 ] ASF GitHub Bot commented on BEAM-1567: -- GitHub user tedyu opened a pull request:

[jira] [Commented] (BEAM-1567) hashStream should be closed in PackageUtil#createPackageAttributes()

2017-02-27 Thread Daniel Halperin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886492#comment-15886492 ] Daniel Halperin commented on BEAM-1567: --- Actually it was auto-assigned to him by default. :) So if

[jira] [Commented] (BEAM-1567) hashStream should be closed in PackageUtil#createPackageAttributes()

2017-02-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886471#comment-15886471 ] Ted Yu commented on BEAM-1567: -- I was looking at code under google-cloud-dataflow-java and happened to see

[jira] [Commented] (BEAM-1567) hashStream should be closed in PackageUtil#createPackageAttributes()

2017-02-27 Thread Daniel Halperin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886456#comment-15886456 ] Daniel Halperin commented on BEAM-1567: --- Thanks [~te...@apache.org], This indeed looks like it could