[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114655#comment-16114655 ] ASF GitHub Bot commented on BEAM-2676: -- Github user XuMingmin closed the pull request at:

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110516#comment-16110516 ] ASF GitHub Bot commented on BEAM-2676: -- GitHub user XuMingmin opened a pull request:

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110430#comment-16110430 ] ASF GitHub Bot commented on BEAM-2676: -- Github user XuMingmin closed the pull request at:

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-08-01 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110323#comment-16110323 ] Xu Mingmin commented on BEAM-2676: -- [~robertwb] [~takidau], get your point. I will move {{BeamRecord}}

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-08-01 Thread Tyler Akidau (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109295#comment-16109295 ] Tyler Akidau commented on BEAM-2676: +1 to Robert's proposal (including renaming BeamRecord; BeamRow

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-07-31 Thread Robert Bradshaw (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107771#comment-16107771 ] Robert Bradshaw commented on BEAM-2676: --- The motivation for this came up because (1) we're currently

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-07-27 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103484#comment-16103484 ] Xu Mingmin commented on BEAM-2676: -- I would say it's "SQL centric" as it leverages {{java.sql.Types}} to

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-07-27 Thread JIRA
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102886#comment-16102886 ] Ismaël Mejía commented on BEAM-2676: I don't want to be contentious, but should this really be in core?

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-07-27 Thread JIRA
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102852#comment-16102852 ] Jean-Baptiste Onofré commented on BEAM-2676: Putting this in the core can make sense if it's

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-07-26 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102317#comment-16102317 ] Xu Mingmin commented on BEAM-2676: -- SGTM, then we've all the type classes in one package. [~robertwb] make

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-07-25 Thread Luke Cwik (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099989#comment-16099989 ] Luke Cwik commented on BEAM-2676: - I would suggest moving this to *org.apache.beam.sdk.values* instead of

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099249#comment-16099249 ] ASF GitHub Bot commented on BEAM-2676: -- GitHub user XuMingmin opened a pull request:

[jira] [Commented] (BEAM-2676) move BeamSqlRow and BeamSqlRowType to sdk/java/core

2017-07-24 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099155#comment-16099155 ] Xu Mingmin commented on BEAM-2676: -- [~robertwb] [~lcwik] for any comments > move BeamSqlRow and