[GitHub] incubator-beam pull request #513: Fix BEAM-359

2016-06-21 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/513

Fix BEAM-359

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

Rather than throwing an exception when checking determinism of an erased
generic, record that as a non-determistic class and proceed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam beam-359-avrocode.r

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/513.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #513


commit 0e656f4df4371fdf6da181ddb984027bce7ec72d
Author: bchambers <bchamb...@google.com>
Date:   2016-06-21T20:42:33Z

Fix BEAM-359

Rather than throwing an exception when checking determinism of an erased
generic, record that as a non-determistic class and proceed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #521: [BEAM-37] DoFnReflector: Add inoker interf...

2016-06-22 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/521

[BEAM-37] DoFnReflector: Add inoker interface and generate code

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

The method to call for a DoFnWithContext requires reflection since the
shape of the parameters may change. Doing so in each processElement call
puts this refelection in the hot path.

This PR introduces a DoFnInvoker interface which is bound to a specific
DoFnWithContext and delegates the three important methods (startBundle,
processElement, finishBundle).

It uses byte-buddy to generate a simple trampoline implementation of
the DoFnInvoker class for each type of DoFnWithContext.

This leads to 2-3x better performance in micro-benchmarks of method
dispatching.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam byte-buddy-dofn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #521


commit 009be346ecbf4e2db899982f6070e2208e47be10
Author: Ben Chambers <bchamb...@google.com>
Date:   2016-06-22T13:47:23Z

[BEAM-37] DoFnReflector: Add inoker interface and generate code

The method to call for a DoFnWithContext requires reflection since the
shape of the parameters may change. Doing so in each processElement call
puts this refelection in the hot path.

This PR introduces a DoFnInvoker interface which is bound to a specific
DoFnWithContext and delegates the three important methods (startBundle,
processElement, finishBundle).

It uses byte-buddy to generate a simple trampoline implementation of
the DoFnInvoker class for each type of DoFnWithContext.

This leads to 2-3x better performance in micro-benchmarks of method
dispatching.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #529: [BEAM-390] Remove many additional definiti...

2016-06-24 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/529

[BEAM-390] Remove many additional definitions/uses of .named methods

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam beam-390-named-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/529.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #529


commit dc3f4f96b172b5bda53b68c639f7e5c1a7d1df68
Author: Ben Chambers <bchamb...@google.com>
Date:   2016-06-24T00:55:24Z

Remove many definitions of named methods

Specifically, remove the occurrences in:
  - Window
  - AvroIO
  - PubsubIO
  - TextIO
  - BigQueryIO
  - Read

commit 96dcd4787a96b04ceeb50a2685295e9e1d8b6f71
Author: Ben Chambers <bchamb...@google.com>
Date:   2016-06-24T05:27:05Z

Remove many uses of .named methods

Specifically, remove uses of:
  - Window.named
  - AvroIO.named
  - PubSubIO.named
  - TextIO.named
  - BigQueryIO.named
  - Read.named




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #535: [BEAM-377] Validate BigQueryIO.Read is pro...

2016-06-25 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/535

[BEAM-377] Validate BigQueryIO.Read is properly configured

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

Previously, using withoutValidation would disable all validation,
leading to a NullPointerException if there wasn't a table or schema
provided.

The intention of the withoutValidation parameter is to bypass more
expensive (and possibly incorrect checks, such as the existence of
the table prior to pipeline execution in cases where earlier stages
create the table).

This moves the basic usage validation to always happen, while the
extended validation is still disabled by withoutValidation.

This closes BEAM-377.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam beam-377-bigquery-io

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #535


commit bf4f8b693aab539282c72dbc77195cd07d3f24f8
Author: Ben Chambers <bchamb...@google.com>
Date:   2016-06-25T21:11:17Z

[BEAM-377] Validate BigQueryIO.Read is properly configured

Previously, using withoutValidation would disable all validation,
leading to a NullPointerException if there wasn't a table or schema
provided.

The intention of the withoutValidation parameter is to bypass more
expensive (and possibly incorrect checks, such as the existence of
the table prior to pipeline execution in cases where earlier stages
create the table).

This moves the basic usage validation to always happen, while the
extended validation is still disabled by withoutValidation.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request: Register debuggee prior to job submis...

2016-03-03 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/15

Register debuggee prior to job submission

@davorbonaci 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam cdbg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit d1bf08463e091d6900dd81bcfde4948f9f9a09b9
Author: bchambers <bchamb...@google.com>
Date:   2016-03-03T01:38:49Z

Register debuggee prior to job submission




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request: Minor tweaks to PULL_REQUEST_TEMPLATE...

2016-03-31 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/111

Minor tweaks to PULL_REQUEST_TEMPLATE.md

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable 
   Travis-CI for on your fork and ensure the whole test matrix passes).
 - [ ] Replace "" in the title with the actual Jira issue 
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
   
---

Fix a typo

Add a horizontal rule between the PR description contents and the
checkboxes/process content.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam tweak-template

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #111


commit 6f9c2c46a41e3521a58e4521da19025ab63be9f4
Author: bchambers <bchamb...@google.com>
Date:   2016-04-01T00:48:28Z

Update PULL_REQUEST_TEMPLATE

Fix a typo

Add a horizontal rule between the template content and the PR
description which is automatically filled in by Github. This
makes it easier to separate the two, and reduces the number
of edits to the template necessary to clean it up.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request: DebuggingWordCount now takes filter a...

2016-03-31 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/108

DebuggingWordCount now takes filter as an option

Allow DebuggingWordCount to take the filter to be matched as an option.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable 
   Travis-CI for on your fork and ensure the whole test matrix passes).
 - [ ] Replace "" in the title with the actual Jira issue 
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
   

Previously it was hard-coded as "Flourish|stomach".
Now it is a PipelineOption with that as the default.

This allows "breaking" the pipeline by mis-specifying the pattern
without changing the code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam debugging

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #108


commit 374c6477f053b67e3edb4743168f82157628c558
Author: bchambers <bchamb...@google.com>
Date:   2016-03-31T22:18:09Z

DebuggingWordCount now takes filter as an option

Previously it was hard-coded as "Flourish|stomach".
Now it is a PipelineOption with that as the default.

This allows "breaking" the pipeline by mis-specifying the pattern
without changing the code.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request: Add a compatibility stub of GABWViaWi...

2016-05-18 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/351

Add a compatibility stub of GABWViaWindowSetDoFn

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

Direct calls to
`org.apache.beam.sdk.util.GroupAlsoByWindowViaWindowSetDoFn#create`
failed following the rename in 892ead2c.

This re-introduces that method as a redirect to the new name to
unbreak things while waiting for a complete fix.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam stub-gabw

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #351


commit 6c942435b52ab7f79ead3342e79154aab5e133bc
Author: bchambers <bchamb...@google.com>
Date:   2016-05-19T00:20:18Z

Add a compatibility stub of GABWViaWindowSetDoFn

Direct calls to
`org.apache.beam.sdk.util.GroupAlsoByWindowViaWindowSetDoFn#create`
failed following the rename in 892ead2c.

This re-introduces that method as a redirect to the new name to
unbreak things while waiting for a complete fix.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request: Write to TextIO in DebuggingWordCount

2016-04-15 Thread bjchambers
Github user bjchambers closed the pull request at:

https://github.com/apache/incubator-beam/pull/157


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request: [BEAM-210] Test that empty final pane...

2016-04-19 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/211

[BEAM-210] Test that empty final panes are not produced.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam empty-final-panes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #211


commit cae541795c632f5ba4799b24a730018ec75ffb1b
Author: bchambers <bchamb...@google.com>
Date:   2016-04-19T18:34:25Z

Remove unused generic arguments in ReduceFnRunnerTest.

commit 4ab1c175f188e03f0ef2a5b6b2019c1e0ba27260
Author: bchambers <bchamb...@google.com>
Date:   2016-04-19T19:43:52Z

Add test for empty ON_TIME and no empty final pane

Add a test that we get an empty `ON_TIME` pane, and don't get the empty
final pane when using accumulation mode with the only if non-empty
`ClosingBehavior`.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request: Rename packages

2016-04-13 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/176

Rename packages

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

I'm verifying this now so there may be a few more fixups, but I wanted to 
give you a chance to get started on the review.

R: @davorbonaci 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam rename-packages

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #176


commit de03fd8a9e812add6d1e35afa437db28164b5c9d
Author: bchambers <bchamb...@google.com>
Date:   2016-04-13T16:17:37Z

Apply the package rename and organize imports

commit 083dcebb43bef33a1a2c4352b455e9a0815e09ac
Author: bchambers <bchamb...@google.com>
Date:   2016-04-13T17:00:42Z

fixup! Update main pom.xml files.

commit e0807b22a329d02f7f3891c1e4eba48d47507cbc
Author: bchambers <bchamb...@google.com>
Date:   2016-04-13T16:52:05Z

fixup! Get the SDK tests passing.

commit b9c3b534ceaaf94325143e08b12d37fceb81315a
Author: bchambers <bchamb...@google.com>
Date:   2016-04-13T16:59:45Z

fixup! Move the files in the join-library and update the pom.

commit 3e96cc51395ac322b036084559d979ef8be331c1
Author: bchambers <bchamb...@google.com>
Date:   2016-04-13T17:00:07Z

fixup! Move the files in the hadoop contrib directory, and update pom.

commit a5acb43a8674ca96b3e76d0cb0f569adea5ed553
Author: bchambers <bchamb...@google.com>
Date:   2016-04-13T17:00:52Z

fixup! Update test_wordcount.sh

commit e1819c64b267ff499bb01457dace9c45d9662eb8
Author: bchambers <bchamb...@google.com>
Date:   2016-04-13T17:03:59Z

fixup! move sdk.properties file

commit aa4adc377838ebb5fff78fbf7de977bc824f24a4
Author: bchambers <bchamb...@google.com>
Date:   2016-04-13T20:33:35Z

fixup! Update the archetypes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #735: Implement Aggregators directly in the Dire...

2016-07-26 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/735

Implement Aggregators directly in the DirectRunner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam 
direct-runner-aggregators

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #735


commit b78beb1610e31e0d2d768588754c14344cb2015d
Author: bchambers <bchamb...@google.com>
Date:   2016-07-26T17:33:40Z

core-java: Make DoFnRunner independent of Counter

This enables the next commit -- making the direct-java runner implement
Aggregators by running the CombineFn directly.

commit 208c79b4cc192c6ea29838cf8febd78d765d07a8
Author: bchambers <bchamb...@google.com>
Date:   2016-07-26T16:39:36Z

direct-java: Implement Aggregators directly




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #553: Add initial microbenchmark for DoFnReflect...

2016-06-28 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/553

Add initial microbenchmark for DoFnReflector

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam microbenchmarks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #553


commit 66512605162424a5d98cdafe9e116f1076c033a3
Author: bchambers <bchamb...@google.com>
Date:   2016-06-28T22:55:16Z

Add initial microbenchmarks directory




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #764: Add ElementByteSizeObserver default constr...

2016-08-01 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/764

Add ElementByteSizeObserver default constructor

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

This enables constructing an observer without the Counter to simplify
testing and use with other ways of reporting byte size.

Once compatibility issues are resolved, the class will become abstract
with the Counter-specific functionality removed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam 
element-byte-size-observer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/764.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #764


commit 243edfec7e2593dcf8c49541da437a3a6744b5d6
Author: bchambers <bchamb...@google.com>
Date:   2016-08-01T17:37:14Z

Add ElementByteSizeObserver default constructor

This enables constructing an observer without the Counter to simplify
testing and use with other ways of reporting byte size.

Once compatibility issues are resolved, the class will become abstract
with the Counter-specific functionality removed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #778: Correct some accidental renames

2016-08-03 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/778

Correct some accidental renames

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

IDE over-eagerly replaced some occurrences of createAggregator with
createAggregatorForDoFn. This corrects that.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam fix-javadoc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #778


commit a39d682e3e2c22eb1efa597dc734d44c27113937
Author: bchambers <bchamb...@google.com>
Date:   2016-08-03T20:38:43Z

Correct some accidental renames

IDE over-eagerly replaced some occurrences of createAggregator with
createAggregatorForDoFn. This corrects that.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #869: Remove legacy import order

2016-08-23 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/869

Remove legacy import order

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam import-orders

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/869.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #869


commit b1123417a6b55fba1560fa68096d0b5551efa960
Author: Ismaël Mejía <ieme...@gmail.com>
Date:   2016-08-22T15:25:32Z

[BEAM-574] Remove log when new records have not been read yet (KafkaIO)

commit b380a677b2823897b1ecc1b903e0775d794423e0
Author: Dan Halperin <dhalp...@google.com>
Date:   2016-08-23T16:59:53Z

Closes #859

commit 9fb604d670267e2ae60ca94320a5a033b405fefb
Author: bchambers <bchamb...@google.com>
Date:   2016-08-24T00:06:17Z

Update checkstyle.xml to put all imports in one group

commit 6487fb11676e8a436a3cc40e06909d8caabec0b6
Author: bchambers <bchamb...@google.com>
Date:   2016-08-24T00:27:50Z

Optimize imports




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1024: [BEAM-147] Prototype of Metrics API for J...

2016-09-28 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1024

[BEAM-147] Prototype of Metrics API for Java DirectRunner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam metrics

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1024.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1024


commit 40961aa24468c810f5f3377620fe14bc7d40c55c
Author: bchambers <bchamb...@google.com>
Date:   2016-09-20T19:44:39Z

Initial prototype of Beam Metrics API

This is labeled @Experimental since it is only supported by the Direct
Runner and may change as it is implemented in other runners.

Future work includes adding additional kinds of metrics and wiring them
up to the various runners.

commit 0c73cf2f2fb73eb1d171c911c10b36f79d564899
Author: bchambers <bchamb...@google.com>
Date:   2016-09-27T23:41:10Z

squash! Prototype Distribution metrics




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1121: Remove unnecessary rawtype cast

2016-10-17 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1121

Remove unnecessary rawtype cast

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

R: @jkff 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam fix-tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1121


commit ce2a6502009f2cecd9b214b29124ca72b8cb9362
Author: bchambers <bchamb...@google.com>
Date:   2016-10-17T21:41:54Z

Remove unnecessary rawtype cast




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1417: Simplify the API for managing MetricsEnvi...

2016-11-22 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1417

Simplify the API for managing MetricsEnvironment

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

1. setCurrentContainer returns the previous MetricsEnvironment
2. setCurrentContainer(null) resets the thread local
3. scopedCurrentContainer sets the container and returns a Closeable to
   reset the previous container.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam metrics-environment

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1417.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1417


commit e02b0251c5106ccde21e9ff6efce49c8ed010c85
Author: bchambers <bchamb...@google.com>
Date:   2016-11-22T19:37:23Z

Simplify the API for managing MetricsEnvironment

1. setCurrentContainer returns the previous MetricsEnvironment
2. setCurrentContainer(null) resets the thread local
3. scopedCurrentContainer sets the container and returns a Closeable to
   reset the previous container.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1121: Remove unnecessary rawtype cast

2016-11-21 Thread bjchambers
Github user bjchambers closed the pull request at:

https://github.com/apache/incubator-beam/pull/1121


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1403: Remove microbenchmarks from pom.xml aggre...

2016-11-21 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1403

Remove microbenchmarks from pom.xml aggregation

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

The microbenchmarks should not be released as part of the Beam
distribution, rather they exist for internal measurements and testing.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam microbenchmarks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1403.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1403


commit 582152cd1b63026b11cd33e229a4d87914520acf
Author: bchambers <bchamb...@google.com>
Date:   2016-11-21T21:35:39Z

Remove microbenchmarks from pom.xml aggregation

The microbenchmarks should not be released as part of the Beam
distribution, rather they exist for internal measurements and testing.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1381: Remove dead code from MetricsContainer

2016-11-17 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1381

Remove dead code from MetricsContainer

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam remove-duplicate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1381


commit c7f25639874d0127bc0c8949c43b43bc28f0af8c
Author: bchambers <bchamb...@google.com>
Date:   2016-11-17T22:40:52Z

Remove dead code from MetricsContainer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1117: Fix SplittableParDoTest

2016-10-17 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1117

Fix SplittableParDoTest

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

This required fixing GBKIntoKeyedWorkItems to properly set the coder on
the primitive, and updating the assertions to match the actual (and
correct) behavior.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam fix-tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1117


commit 577d04ab0799b18d5c2c88e2250859678f589968
Author: bchambers <bchamb...@google.com>
Date:   2016-10-17T19:35:03Z

Fix SplittableParDoTest

This required fixing GBKIntoKeyedWorkItems to properly set the coder on
the primitive, and updating the assertions to match the actual (and
correct) behavior.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1554: Change Dataflow profiling option to saveP...

2016-12-08 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1554

Change Dataflow profiling option to saveProfilesToGcs

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam profiling

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1554


commit a57bf6a147ad1d05ed1f0d3f5981a6296b50bd35
Author: bchambers <bchamb...@google.com>
Date:   2016-12-08T18:40:17Z

Change Dataflow profiling option to saveProfilesToGcs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1566: Add missing @Test annotation to DirectRun...

2016-12-09 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1566

Add missing @Test annotation to DirectRunnerTest

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam metrics-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1566.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1566


commit d7533228f28fc6535a3c76aefe4d2e3eea9a253f
Author: bchambers <bchamb...@google.com>
Date:   2016-12-09T22:05:30Z

Add missing @Test annotation to DirectRunnerTest

commit c36132e7181ed8be0ac0c123082a42497d56bf8c
Author: bchambers <bchamb...@google.com>
Date:   2016-12-09T22:11:54Z

fixup! Improve MetricMatchers mismatch description

commit 224c52fa68ca20e73b996143d6fe099e625f37c5
Author: bchambers <bchamb...@google.com>
Date:   2016-12-09T22:13:46Z

fixup! Fix test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1625: Don't incorrectly log error in MetricsEnv...

2016-12-15 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1625

Don't incorrectly log error in MetricsEnvironment

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

Using getCurrentContainer() logs an error if metrics are not supported.
This is because it acts as the common point of access for user code that
reports metrics.

It should not be used within setCurrentContainer(), because the first
container being set will have a null previous-current-container, which
will cause the error to be incorrectly logged.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam fix-metrics-warning

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1625.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1625


commit 125223f8feb3576d3ff5ccdffa58a5e80808286c
Author: bchambers <bchamb...@google.com>
Date:   2016-12-14T19:23:39Z

Don't incorrectly log error in MetricsEnvironment

Using getCurrentContainer() logs an error if metrics are not supported.
This is because it acts as the common point of access for user code that
reports metrics.

It should not be used within setCurrentContainer(), because the first
container being set will have a null previous-current-container, which
will cause the error to be incorrectly logged.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1638: Make a RunnableOnService test for Metrics

2016-12-15 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1638

Make a RunnableOnService test for Metrics

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam ros-metrics-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1638


commit 6f57c0bda89b49576a09d2babe386632522b8544
Author: bchambers <bchamb...@google.com>
Date:   2016-12-16T01:04:59Z

Add UsesMetrics interface and exclude from runners

commit 850af9c5e2566e1127ab8e5c0e2f1b50e3cc404e
Author: bchambers <bchamb...@google.com>
Date:   2016-12-16T01:04:21Z

Add Serializability as needed for Metrics

commit 960f931b6e1893b85feda157e11b354480f9e62b
Author: bchambers <bchamb...@google.com>
Date:   2016-12-16T01:05:16Z

Add runnable on service test for Metrics

commit 4d698cec4b8353d1e7cdc6bcc6b762d59874035e
Author: bchambers <bchamb...@google.com>
Date:   2016-12-16T01:48:23Z

fixup! Remove test from DirectRunnerTest




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1615: [BEAM-1104] Don't incorrectly log error i...

2016-12-15 Thread bjchambers
Github user bjchambers closed the pull request at:

https://github.com/apache/incubator-beam/pull/1615


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1615: [BEAM-1104] Don't incorrectly log error i...

2016-12-14 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1615

[BEAM-1104] Don't incorrectly log error in MetricsEnvironment

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

Using getCurrentContainer() logs an error if metrics are not supported.
This is because it acts as the common point of access for user code that
reports metrics.

It should not be used within setCurrentContainer(), because the first
container being set will have a null previous-current-container, which
will cause the error to be incorrectly logged.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam fix-metrics-warning

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1615.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1615


commit 125223f8feb3576d3ff5ccdffa58a5e80808286c
Author: bchambers <bchamb...@google.com>
Date:   2016-12-14T19:23:39Z

Don't incorrectly log error in MetricsEnvironment

Using getCurrentContainer() logs an error if metrics are not supported.
This is because it acts as the common point of access for user code that
reports metrics.

It should not be used within setCurrentContainer(), because the first
container being set will have a null previous-current-container, which
will cause the error to be incorrectly logged.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1622: Make {Metric,Counter,Distribution}Cell pu...

2016-12-14 Thread bjchambers
GitHub user bjchambers opened a pull request:

https://github.com/apache/incubator-beam/pull/1622

Make {Metric,Counter,Distribution}Cell public

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [*] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [*] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [*] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

These classes may be useful to hold on to within a runner where the step
context is known to be unchanging and there may be a desire to avoid the
extra indirection of using {Counter,Distribution} directly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bjchambers/incubator-beam expose-metric-cells

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1622


commit 41a77087ed9539a8a37b1f49325e937fc0acec2d
Author: bchambers <bchamb...@google.com>
Date:   2016-12-14T23:46:50Z

Make {Metric,Counter,Distribution}Cell public

These classes may be useful to hold on to within a runner where the step
context is known to be unchanging and there may be a desire to avoid the
extra indirection of using {Counter,Distribution} directly.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---