[jira] [Commented] (BEAM-596) Support cancel() and waitUntilFinish() in DirectRunner

2016-10-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583014#comment-15583014
 ] 

ASF GitHub Bot commented on BEAM-596:
-

GitHub user tgroh opened a pull request:

https://github.com/apache/incubator-beam/pull/1115

[BEAM-596] Support waitUntilFinish, cancel in the DirectRunner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tgroh/incubator-beam wait_until_finsish

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1115


commit b8a441263a574b1fb87eb8fa2b6d78304a168ada
Author: Thomas Groh 
Date:   2016-10-17T18:21:02Z

Support waitUntilFinish, cancel in the DirectRunner




> Support cancel() and waitUntilFinish() in DirectRunner
> --
>
> Key: BEAM-596
> URL: https://issues.apache.org/jira/browse/BEAM-596
> Project: Beam
>  Issue Type: New Feature
>  Components: runner-direct
>Reporter: Pei He
>Assignee: Thomas Groh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BEAM-596) Support cancel() and waitUntilFinish() in DirectRunner

2016-10-14 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15577065#comment-15577065
 ] 

ASF GitHub Bot commented on BEAM-596:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1098


> Support cancel() and waitUntilFinish() in DirectRunner
> --
>
> Key: BEAM-596
> URL: https://issues.apache.org/jira/browse/BEAM-596
> Project: Beam
>  Issue Type: New Feature
>  Components: runner-direct
>Reporter: Pei He
>Assignee: Thomas Groh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BEAM-596) Support cancel() and waitUntilFinish() in DirectRunner

2016-10-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573352#comment-15573352
 ] 

ASF GitHub Bot commented on BEAM-596:
-

GitHub user tgroh opened a pull request:

https://github.com/apache/incubator-beam/pull/1098

[BEAM-596] Replace DirectResult#awaitCompletion with waitUntilFinish

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

This is the PipelineResult interface method, rather than the
DirectRunner-specific method.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tgroh/incubator-beam wait_until_finsish

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1098.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1098


commit 851b447584015e9e0e864554d1ba507f09157eb8
Author: Thomas Groh 
Date:   2016-10-13T22:07:51Z

Replace DirectResult#awaitCompletion with waitUntilFinish

This is the PipelineResult interface method, rather than the
DirectRunner-specific method.




> Support cancel() and waitUntilFinish() in DirectRunner
> --
>
> Key: BEAM-596
> URL: https://issues.apache.org/jira/browse/BEAM-596
> Project: Beam
>  Issue Type: New Feature
>  Components: runner-direct
>Reporter: Pei He
>Assignee: Thomas Groh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)